profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/scier/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

scier/ZIPFoundation 0

Effortless ZIP Handling in Swift

issue commentapptentive/apptentive-ios

Support Swift Package Manager in Xcode 11

That's great news -- thank you for the update @vivekbhupatiraju!

KaneCheshire

comment created time in 13 days

issue commentapptentive/apptentive-ios

Support Swift Package Manager in Xcode 11

This is blocking us as well; Apptentive is the only major third-party library we use that hasn't provided SwiftPM support. We're in the process of migrating from CocoaPods to SwiftPM, leaving us with the options of either finding an unreliable workaround (such as a git submodule) or switching away from Apptentive.

The analysis by @frankus above is out of date now; as @mattozer said, resources are now supported. The "platform independence" is a capability SwiftPM provides, not something it enforces: many SwiftPM packages (indeed, the significant majority) include references to UIKit and other Apple frameworks, either requiring them or providing preprocessor branches to use them when available.

KaneCheshire

comment created time in 14 days

push eventscier/ZIPFoundation

Sean Cier

commit sha 8d3a9696ce8191d0a932d51bac0ee7ab8c3ba21f

Fix build error with Swift 4: add explicit return statement

view details

push time in a month

push eventscier/ZIPFoundation

Sean Cier

commit sha 833f23f617e024ab53afea78d185fee0f0f9127e

Fix variable name in unit test to avoid SwiftLint warning

view details

push time in a month

created tagscier/ZIPFoundation

tag1.0.0

Effortless ZIP Handling in Swift

created time in a month

push eventscier/ZIPFoundation

Sean Cier

commit sha cae5de20af2aa29c01e0eea7dbb29b026d339c15

Add unit test for crc32 correctness (vs. performance) Enable the zlib-based crc32 for swift < 5

view details

push time in a month

pull request commentweichsel/ZIPFoundation

Use zlib.crc32 when available to improve performance of Data.crc32()

Is there actually a platform where inflate/deflate algorithms are available and zlib is not there?

No, but -- the manifest (and Data+Compression.swift) seems to specifically depend on zlib on systems where Compression is available (i.e. Apple platforms), so I didn't want to introduce a dependency on it just for crc32 when there's a fallback available.

I believe you should always use zlib for crc32.

That would certainly let us get rid of some code and a corner case, if we were willing to introduce an explicit zlib dependency even on Apple platforms.

By the way, it would be nice to move it to a separate type instead of that nasty typealias CRC32 = UInt32

I agree, that would be cleaner; but that seems orthogonal to this change and would introduce a lot more little changes, so it feels like it should be a separate PR.

scier

comment created time in a month

fork scier/Instructions

Create walkthroughs and guided tours (coach marks) in a simple way, with Swift.

fork in 3 months