profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/sbenzaquen/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

google/googletest 23796

GoogleTest - Google Testing and Mocking Framework

sbenzaquen/cctz 0

CCTZ is a C++ library for translating between absolute and civil times using the rules of a time zone.

pull request commentgoogle/googletest

Simplify example code with c++11

Thank you, we have started internal review. Please don’t push any more changes into this PR as they might be overwritten. (392042170)

theidexisted

comment created time in a month

push eventgoogle/googletest

Abseil Team

commit sha 2f80c2ba71c0e8922a03b9b855e5b019ad1f7064

Googletest export Standardize access to GoogleTest flags on GTEST_FLAG_GET/GTEST_FLAG_SET Custom implementations can decide how access to flags is performed depending on the implementation of flags being used. PiperOrigin-RevId: 391971115

view details

push time in a month

delete branch google/googletest

delete branch : 32546A73C75F4DB5BAAF643E38EF6A0E

delete time in a month

PR closed google/googletest

Export Test - Do Not Merge cla: yes

Export Test - Do Not Merge

Standardize access to GoogleTest flags on GTEST_FLAG_GET/GTEST_FLAG_SET

Custom implementations can decide how access to flags is performed depending on the implementation of flags being used.

+3 -3

0 comment

1 changed file

sbenzaquen

pr closed time in a month

issue commentgoogle/googletest

Support custom user-defined logic for tests filtering

GoogleTest supports skipping tests with GTEST_SKIP();. You can do so from the test, or from the fixture (eg in SetUp). Example: https://gcc.godbolt.org/z/sPhTxnn5G

It is not exactly the same as filters because the test will show in the output as skipped, though. But this is something you can do today, and you can use any runtime logic you want to skip the tests.

Filtering can't really be that dynamic because it is used in several parts of the framework and it is expected to be deterministic.

victordk13

comment created time in a month

push eventgoogle/googletest

Peter Hill

commit sha 2292b6d856335b6c1ee352e9cb97d7a5b193c989

CMake: Add namespaced ALIAS library Fixes #3125

view details

Gautham B A

commit sha 626ce00befee975637c7d7795d8d1fce60cea77d

Fix typo

view details

Yuriy Chernyshov

commit sha 263220d2c1211e3ec95602ff3c81cf75cd55e19a

Use proper feature test macro to test if library supports char8_t Reference is here: https://en.cppreference.com/w/cpp/feature_test This PR fixes the weird case of compiling with `clang++ -std=c++17 -fchar8_t`

view details

Mattias Ellert

commit sha 05e9fa23f74a4766294f858c16e87a1560261340

Port to GNU/Hurd

view details

Niels Dekker

commit sha ac3c2a8d0496893787015014a5abd397b766cce2

overload PrintTo for std::type_info and std::type_index Included the string returned by their `name()` member function with the output of `PrintTo`. Typical use case: std::unique_ptr<AbstractProduct> product = FactoryMethod(); // Assert that the product is of type X: ASSERT_EQ(std::type_index{typeid(*product)}, std::type_index{typeid(ProductX)}); Possible output in case of a test assert failure, now including the names of the compared type indices: > error: Expected equality of these values: > std::type_index(typeid(*product)) > Which is: 8-byte object <D0-65 54-8C F6-7F 00-00> ("class ProductY") > std::type_index(typeid(ProductX)) > Which is: 8-byte object <40-64 54-8C F6-7F 00-00> ("class ProductX") With help from Krystian Kuzniarek.

view details

Be

commit sha 497db77a0af7054215101b2a5399dea1314e73e1

remove -Zi from MSVC compiler options This is incompatible with compiler caches such as sccache and clcache. If a project including Google Test specifies /Z7 instead, building fails with: sccache C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1428~1.293\bin\Hostx64\x64\cl.exe /nologo /TP -D__SSE2__ -D__SSE__ -I..\lib\googletest-1.10.x\googlemock\include -I..\lib\googletest-1.10.x\googlemock -I..\lib\googletest-1.10.x\googletest\include -I..\lib\googletest-1.10.x\googletest /DWIN32 /D_WINDOWS /W4 /GR /MD /Z7 /O2 /Ob1 /DNDEBUG -GS -W4 -WX -wd4251 -wd4275 -nologo -J -Zi -D_UNICODE -DUNICODE -DWIN32 -D_WIN32 -DSTRICT -DWIN32_LEAN_AND_MEAN -wd4702 -DGTEST_HAS_PTHREAD=0 -EHsc -D_HAS_EXCEPTIONS=1 /Gy /showIncludes /Folib\googletest-1.10.x\googlemock\CMakeFiles\gmock_main.dir\src\gmock-all.cc.obj /Fdbin\gmock_main.pdb /FS -c ..\lib\googletest-1.10.x\googlemock\src\gmock-all.cc FAILED: lib/googletest-1.10.x/googlemock/CMakeFiles/gmock_main.dir/src/gmock-all.cc.obj ..\lib\googletest-1.10.x\googletest\src\gtest-all.cc: fatal error C1041: cannot open program database 'D:\a\mixxx\mixxx\build\bin\gmock_main.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS cl : Command line warning D9025 : overriding '/Z7' with '/Zi'

view details

Abseil Team

commit sha 3832a41ef984578ff673c75d7d36a499fe7aa828

Googletest export Update links in index.md PiperOrigin-RevId: 358956598

view details

Abseil Team

commit sha e8b478a7356f21efbada1aae15b49b332cc54e3f

Googletest export Update gtest doc link PiperOrigin-RevId: 359622286

view details

Abseil Team

commit sha de41f8223c4aa8ff447dbc03b25e57b53dd75867

Googletest export Add Supported Platforms page to docs PiperOrigin-RevId: 360307129

view details

Abseil Team

commit sha 32983d211b71c3d3ed2d7770ae149ddfb4b0b703

Googletest export Fix enum names in a value-parameterized test example. PiperOrigin-RevId: 360559723

view details

Abseil Team

commit sha e7e591764baba0a0c3c9ad0014430e7a27331d16

Googletest export Format WORKSPACE and googlemock/test/BUILD.bazel using buildifier PiperOrigin-RevId: 360913861

view details

Abseil Team

commit sha 79b556eff66383002e7186c30a93a0098625f498

Googletest export Add CI test scripts PiperOrigin-RevId: 360931988

view details

Dino Radaković

commit sha bcfcf75ef62af29f15fbb98be25fbfb87f45036e

Merge pull request #3184 from N-Dekker:PrintTo-type_index-overload PiperOrigin-RevId: 361175466

view details

Abseil Team

commit sha bf465ff05d74ca6829c49c321069a34f21b97f5d

Internal change PiperOrigin-RevId: 361213113

view details

Abseil Team

commit sha bb4f87e6c6699507608042554ddce896ba751643

Googletest export gtest.cc: Split out functions for printing `TestResult` objects This will make it possible to reuse this code for outputting the "ad_hoc" `TestResult` objects in structured form in XML/JSON. PiperOrigin-RevId: 361604860

view details

Abseil Team

commit sha 763eaa430540926fa16060654427149802c97fba

Googletest export Use monotonic time to measure test duration System time may be updated while a test is running. When this occurs a duration measured using system time may appear to move backwards, or jump far forwards. This change updates the duration measurement to use monotonic time instead. Timestamps for the test start still use system time. PiperOrigin-RevId: 361700881

view details

Abseil Team

commit sha 861d535e2595894c7a214f05c1578d964a617643

Googletest export Update READMEs and issue template PiperOrigin-RevId: 361931644

view details

Abseil Team

commit sha e8512bc38c4c0060858c3306b0660a3f126aee30

Googletest export Add missing period and use "that" in restrictive clause. PiperOrigin-RevId: 361941663

view details

Vollstrecker

commit sha 5065389aabfa1d70a49d57eb355b9db4500801be

Use Fetchcontent instead of ExternalProject Hi, instead of ExternalProject and a new file that is spawned in a new process, it's easier to just use FetchContent. cmake 3.14 should be old enough to be spread.

view details

Ezekiel Warren

commit sha 5c08f92c881b666998a4f7852c3cf9e393bf33a7

Use @platforms instead of @bazel_tools for windows constraint

view details

push time in a month

PR opened google/googletest

Export Test - Do Not Merge

Export Test - Do Not Merge

Standardize access to GoogleTest flags on GTEST_FLAG_GET/GTEST_FLAG_SET

Custom implementations can decide how access to flags is performed depending on the implementation of flags being used.

+3 -3

0 comment

1 changed file

pr created time in a month

pull request commentgoogle/googletest

Allow empty Type<> type list

We have had many complaints in the past of cases where the test pass but didn't actually run anything. Eg with a filter that does nothing, or with parameterized tests that were never instantiated. I don't know if adding yet one more way of having trivial PASS is a good idea. Can you give more details as to why you want to instantiate with no types?

havogt

comment created time in 2 months

issue commentgoogle/googletest

Best printer selection for containers is a pain

Regarding asking users to fix the code, it is not always their code to fix. They might just be using someone else's library. It is also recursive. You need every operator<< down the chain to ask its inner objects if they support it. This is rarely done in older code because SFINAE was hard without things like decltype.

So, we could change the order these are evaluated but I don't know if it is worth the risk. We could evaluate this to see how much known code is broken by it.

Silicomancer

comment created time in 3 months

issue commentgoogle/googletest

Best printer selection for containers is a pain

Sadly, broken stream operators are very common for class templates and if we use them first it breaks tons of code. For example, if you container unconditionally advertises its own stream operator and uses the stream operator of its value_type, then your stream operator is invalid when your value_type does not have one, but there is no way to know from the outside. Your stream operator needs to only participate in overload resolution if can really print its contents, which means it needs some SFINAE to disable itself. This SFINAE is seldom implemented, in my experience.

But for those containers, if we iterate them ourselves we can use the universal printer for its contents and have more options than just the stream operator.

Silicomancer

comment created time in 3 months