profile
viewpoint
Samuel Horwitz samuelhorwitz @Facebook New York, NY samurl.com Software Engineer @Facebook

samuelhorwitz/regres 3

A PLV8 Development Library

samuelhorwitz/phosphorescence 2

Phosphorescence trance playlist builder for Spotify

samuelhorwitz/markdown-it-pseudocodejs 1

Pseudocode.js for markdown-it

samuelhorwitz/algo 0

Set up a personal IPSEC VPN in the cloud

samuelhorwitz/angular-16776-example 0

https://github.com/angular/angular/issues/16776

samuelhorwitz/apollo-angular 0

Angular integration for the Apollo Client

samuelhorwitz/babel 0

:tropical_fish: Babel is a compiler for writing next generation JavaScript.

samuelhorwitz/contract 0

Design by contract for Go

samuelhorwitz/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

pull request commentprebid/Prebid.js

Adds advertiserDomains to kargo adapter

Hey! Thanks for the heads up. I'm actually no longer maintaining this (although from what I can see it's likely fine), I'll CC @andyrusiecki who I believe would be maintaining things now.

patmmccann

comment created time in a month

push eventsamuelhorwitz/hugo

Samuel Horwitz

commit sha ecae209832163300cb03359b1556fab47f25be0b

Add support for Goldmark footnote render hooks See #7291

view details

push time in 3 months

push eventsamuelhorwitz/hugo

Samuel Horwitz

commit sha 954bcc45f47983cb65f2c89bb5e3c0fd949eae5f

Add support for Goldmark footnote render hooks See #7291

view details

push time in 3 months

push eventsamuelhorwitz/hugo

Samuel Horwitz

commit sha 6495962bcc6783abdffd820afd57e4cf02adaf04

Add support for Goldmark footnote render hooks See #7291

view details

push time in 3 months

push eventsamuelhorwitz/hugo

Samuel Horwitz

commit sha 2abace42b952fe3f92cc4c90031adaae0356c469

Add support for Goldmark footnote render hooks See #7291

view details

push time in 3 months

push eventsamuelhorwitz/hugo

Samuel Horwitz

commit sha d357e8556958987e13c5abdbac3f5add5bb046e3

Add support for Goldmark footnote render hooks See #7291

view details

push time in 3 months

PR opened gohugoio/hugo

Add support for Goldmark footnote render hooks

See #7291

I created this PR to allow custom Goldmark rendering templates for footnotes. This was previously requested but it wasn't completely accepted that this is the right path forward. I did the work on this PR to show it's feasible and as a place to start discussion on whether it's the right direction now that it's been implemented.

My personal use case is I would like to use Chicago Manual of Style symbolic footnotes (asterix, dagger, double dagger, etc) rather than numbers. Other notes are that in summaries, footnotes are present which is a) undesirable and b) if it's desirable the issue becomes that the IDs are non-unique as every summary restarts counting from 1 without a unique prefix.

My pull request allows all of these things.

+481 -8

0 comment

7 changed files

pr created time in 3 months

push eventsamuelhorwitz/hugo

Samuel Horwitz

commit sha f4e6f7661c931577f2d6235b7fa6846721927591

Add support for Goldmark footnote render hooks See #7291

view details

push time in 3 months

push eventsamuelhorwitz/hugo

Samuel Horwitz

commit sha 680051216429416dbf8549e21f8d4a22effef788

Add support for Goldmark footnote render hooks See #7291

view details

push time in 3 months

create barnchsamuelhorwitz/hugo

branch : custom-footnotes

created branch time in 3 months

fork samuelhorwitz/hugo

The world’s fastest framework for building websites.

https://gohugo.io

fork in 3 months

more