profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/samjewell/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

gnclmorais/paloma 92

Page-specific JavaScript for Rails done right

grafana/singer-python 0

Writes the Singer format from Python

samjewell/catalog 0

The Ruby Toolbox library catalog

samjewell/dotfiles 0

My gorgeous dotfiles

samjewell/ftse-crash 0

Tool for finding long term average of the FTSE, and whether we're above or below it right now

samjewell/getting-started 0

Getting started with Docker

PullRequestReviewEvent

push eventgrafana/synthetic-monitoring-app

Sam Jewell

commit sha 969c3d4f5fa916aecdcab48f6fb4dd6ac5fc8d97

Default server for DNS to domain name (#364) Currently the default server for DNS checks is set to an IPv4 address. But users can choose to use IPv6 instead, at which point the IPv4 default address leads to the check constantly failing. This default will work for both IPv4 and IPv6 without issue. See this working in practice on this check here: https://syntheticmonitoring.grafana.net/a/grafana-synthetic-monitoring-app/?page=checks&id=63Revert "Revert "Default server for DNS to domain name""

view details

push time in 4 days

delete branch grafana/synthetic-monitoring-app

delete branch : sj/dns-server-default-ipv6

delete time in 4 days

PR merged grafana/synthetic-monitoring-app

Reviewers
Default server for DNS to domain name enhancement

Currently the default server for DNS checks is set to an IPv4 address. But users can choose to use IPv6 instead, at which point the IPv4 default address leads to the check constantly failing. This default will work for both IPv4 and IPv6 without issue.

See this working in practice on this check here: https://syntheticmonitoring.grafana.net/a/grafana-synthetic-monitoring-app/?page=checks&id=63

+6 -6

0 comment

4 changed files

samjewell

pr closed time in 4 days

PR opened grafana/synthetic-monitoring-app

Default server for DNS to domain name

Currently the default server for DNS checks is set to an IPv4 address. But users can choose to use IPv6 instead, at which point the IPv4 default address leads to the check constantly failing. This default will work for both IPv4 and IPv6 without issue.

See this working in practice on this check here: https://syntheticmonitoring.grafana.net/a/grafana-synthetic-monitoring-app/?page=checks&id=63

+6 -6

0 comment

4 changed files

pr created time in 5 days

create barnchgrafana/synthetic-monitoring-app

branch : sj/dns-server-default-ipv6

created branch time in 5 days

push eventgrafana/synthetic-monitoring-app

Sam Jewell

commit sha 08384ffa09b829a57aad5f64b2ea1fb054cc41bf

Revert "Default server for DNS to domain name" This reverts commit ae3b4169274ff514adaca8a99ad04dff89037f2f This was pushed up to `main` by mistake, without review

view details

push time in 5 days

push eventgrafana/synthetic-monitoring-app

Sam Jewell

commit sha ae3b4169274ff514adaca8a99ad04dff89037f2f

Default server for DNS to domain name Currently the default server for DNS checks is set to an IPv4 address. But users can choose to use IPv6 instead, at which point the IPv4 default address leads to the check constantly failing. This default will work for both IPv4 and IPv6 without issue. See this working in practice on this check here: https://syntheticmonitoring.grafana.net/a/grafana-synthetic-monitoring-app/?page=checks&id=63

view details

push time in 5 days

pull request commentgrafana/synthetic-monitoring-app

Add traceroute

<img src=https://media.giphy.com/media/hPGloL5hneaSA/giphy.gif>

rdubrock

comment created time in 9 days

issue commentgrafana/grizzly

[Grizzly] Synthetic Monitoring (example) not found after creation

This issue is present on one of our private GrafanalLabs Github project boards. That's why I've included the name Grizzly in the issue title.

samjewell

comment created time in 10 days

Pull request review commentgrafana/grizzly

Switch to dot as resource separator

 func (r *Resource) MatchesTarget(targets []string) bool { 	if len(targets) == 0 { 		return true 	}-	key := r.Key()+	UID := r.UID()+	slashKey := fmt.Sprintf("%s/%s", r.Kind(), UID)+	dotKey := fmt.Sprintf("%s.%s", r.Kind(), UID)

I'd be tempted to use the following here, to have less duplication and fewer sources of truth:

	dotKey := r.Key() // fmt.Sprintf("%s.%s", r.Kind(), UID)
	slashKey := fmt.Sprintf("%s/%s", r.Kind(), UID)
malcolmholmes

comment created time in 16 days

Pull request review commentgrafana/grizzly

Switch to dot as resource separator

 func (r Resource) String() string { 	return r.Key() } -// Key returns a key that combines kind and uid-func (r *Resource) Key() string {+func (r Resource) UID() string { 	handler, err := Registry.GetHandler(r.Kind()) 	if err != nil { 		return "Unknown-handler:" + r.Kind() 	}-	uid, err := handler.GetUID(*r)+	uid, err := handler.GetUID(r) 	if err != nil { 		return "error:" + err.Error() 	}-	return fmt.Sprintf("%s/%s", r.Kind(), uid)+	return uid+}++// Key returns a key that combines kind and uid+func (r *Resource) Key() string {+	uid := r.UID()+	return fmt.Sprintf("%s.%s", r.Kind(), uid) }

Could be nice to define the .Key method before the .UID() method, so that the file reads from higher-level methods to lower level ones. Similar to the description on this post.

malcolmholmes

comment created time in 16 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentsinger-io/singer-python

Add `default` key to Schema

@dmosorast just a short initial message to say: thanks for your thoughts- that’s very helpful: both about the singer philosophy and also the dependencies approach.

I may follow up again soon to share our use-case, but my thinking right now is that we are including a Transform step when we shouldn’t be. So we may instead ditch this PR, and apply our transforms downstream of the singer target, with DBT or something

samjewell

comment created time in 18 days

Pull request review commentadswerve/target-bigquery

Update singer dependency

-singer-python==5.9.0+singer-python==5.12.1

To the project maintainers - would you consider accepting the following change instead 🙏 ?

singer-python~=5.12.1

I think this would reduce the potential for dependency hell

RutgerKe

comment created time in 18 days

PullRequestReviewEvent

PR merged grafana/singer-python

Add `default` key to Schema

Description of change

The default keyword is supported in JSON Schema, as described here: https://json-schema.org/understanding-json-schema/reference/generic.html#annotations

So any data for defaults within a Catalog file should be accessible through the Schema class.

Manual QA steps

A Catalog file which looks like this:

{
  "streams": [
    {
      "stream": "cortex_distributor_writes",
      "tap_stream_id": "cortex_distributor_writes",
      "schema": {
        "properties": {
          "namespace": {
            "type": "string",
            "default": "prod"
          }
        }
      }
    }
  ]
}

Should allow the default key to be accessed through: singer.Catalog.load(path_to_catalog_file).streams[0].schema.to_dict()["properties"]["namespace"]["default"]

Risks

unknown

Rollback steps

  • revert this branch
+3 -1

0 comment

1 changed file

samjewell

pr closed time in 18 days

push eventgrafana/singer-python

Sam Jewell

commit sha e5e8f71c868d0bab33b2b8fe1e3bb819c964e29e

Add `default` key to Schema The default keyword is supported in JSON Schema, as described here: https://json-schema.org/understanding-json-schema/reference/generic.html#annotations

view details

Sam Jewell

commit sha 3f4e3d343d89534efeb4310ac3bdc92bc14f0dba

Merge pull request #1 from grafana/sj/add-default-key-to-schema Add `default` key to Schema

view details

push time in 18 days

PR opened grafana/singer-python

Add `default` key to Schema

The default keyword is supported in JSON Schema, as described here: https://json-schema.org/understanding-json-schema/reference/generic.html#annotations

Description of change

(write a short description or paste a link to JIRA)

Manual QA steps

Risks

Rollback steps

  • revert this branch
+3 -1

0 comment

1 changed file

pr created time in 18 days

MemberEvent

pull request commentsinger-io/singer-python

Add `default` key to Schema

@leslievandemark @zachharris1 @jacobrobertbaca @dmosorast @cosimon Is there any change I can have this work reviewed and merged? This is a pretty small and low-impact change, but we're experiencing some small dependency-hell currently while this is unmerged.

samjewell

comment created time in 18 days

PullRequestReviewEvent

push eventgrafana/synthetic-monitoring-agent

dependabot[bot]

commit sha 1b68d15e275a8666e55b935adc6b085fc8b9f540

Bump github.com/go-logfmt/logfmt from 0.5.0 to 0.5.1 (#204) Bumps [github.com/go-logfmt/logfmt](https://github.com/go-logfmt/logfmt) from 0.5.0 to 0.5.1. - [Release notes](https://github.com/go-logfmt/logfmt/releases) - [Changelog](https://github.com/go-logfmt/logfmt/blob/master/CHANGELOG.md) - [Commits](https://github.com/go-logfmt/logfmt/compare/v0.5.0...v0.5.1) --- updated-dependencies: - dependency-name: github.com/go-logfmt/logfmt dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in a month

delete branch grafana/synthetic-monitoring-agent

delete branch : dependabot/go_modules/github.com/go-logfmt/logfmt-0.5.1

delete time in a month

PR merged grafana/synthetic-monitoring-agent

Reviewers
Bump github.com/go-logfmt/logfmt from 0.5.0 to 0.5.1 dependencies

Bumps github.com/go-logfmt/logfmt from 0.5.0 to 0.5.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/go-logfmt/logfmt/releases">github.com/go-logfmt/logfmt's releases</a>.</em></p> <blockquote> <h2>v0.5.1</h2> <p>This release does not contain any code changes. Most of the changes since the last release are related to CI logistics behind the scenes. The only reason for tagging a new release is to update the <code>go.mod</code> file for Go 1.17 as described in the <a href="https://golang.org/doc/go1.17#go-command">Go 1.17 release notes</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/go-logfmt/logfmt/blob/master/CHANGELOG.md">github.com/go-logfmt/logfmt's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <p>All notable changes to this project will be documented in this file.</p> <p>The format is based on <a href="https://keepachangelog.com/en/1.0.0/">Keep a Changelog</a>, and this project adheres to <a href="https://semver.org/spec/v2.0.0.html">Semantic Versioning</a>.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/go-logfmt/logfmt/commit/2fe45f2cf057d707c50bc1949e25ec2cd6b7a015"><code>2fe45f2</code></a> Merge branch 'release/v0.5.1'</li> <li><a href="https://github.com/go-logfmt/logfmt/commit/e03cb7c6c47c029f1aa91aaed2b3e4f3699cf18d"><code>e03cb7c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/go-logfmt/logfmt/issues/12">#12</a> from go-logfmt:feature/go1.17</li> <li><a href="https://github.com/go-logfmt/logfmt/commit/3b63871bcd727ec3bf5a0412ffd5474fe145edc7"><code>3b63871</code></a> go mod tidy -go=1.17</li> <li><a href="https://github.com/go-logfmt/logfmt/commit/38d6ce4f38d4c48ed5d611f92df3a36ffcf297cd"><code>38d6ce4</code></a> Add Go 1.17 to build matrix</li> <li><a href="https://github.com/go-logfmt/logfmt/commit/4e64dd1ccc01f924a2c20cfe88de4817ef7b1359"><code>4e64dd1</code></a> Merge branch 'develop'</li> <li><a href="https://github.com/go-logfmt/logfmt/commit/b3417bd5707eb82510e4f580427c5e3e8475b71d"><code>b3417bd</code></a> Update badges</li> <li><a href="https://github.com/go-logfmt/logfmt/commit/2c97639616f67681458897fde38e3bf9be72a1fc"><code>2c97639</code></a> Merge branch 'feature/github-actions' into develop</li> <li><a href="https://github.com/go-logfmt/logfmt/commit/82b160a048f8825e78e9a65a999c11ff6bc59c27"><code>82b160a</code></a> Stop using TravisCI</li> <li><a href="https://github.com/go-logfmt/logfmt/commit/12868300ebc16d8c98c9c5b94cea30a8a7d6243a"><code>1286830</code></a> Fix coverage on Windows with Powershell</li> <li><a href="https://github.com/go-logfmt/logfmt/commit/80e8e54adfc2acddd70c1a5340794174cda0cc0c"><code>80e8e54</code></a> Add test coverage</li> <li>Additional commits viewable in <a href="https://github.com/go-logfmt/logfmt/compare/v0.5.0...v0.5.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+3 -2

0 comment

2 changed files

dependabot[bot]

pr closed time in a month

PullRequestReviewEvent
PullRequestReviewEvent

startedjeschkies/spark-loki-datasource

started time in a month