profile
viewpoint
Sam Saccone samccone Google ∆∆∆

kdzwinel/betwixt 4200

:zap: Web Debugging Proxy based on Chrome DevTools Network panel.

jescalan/roots 1476

a toolkit for rapid advanced front-end development

paulirish/pwmetrics 1220

Progressive web metrics at your fingertipz

paulirish/speedline 662

Calculate the speed index and visual performance metrics from chrome dev tool timeline (recently: pmdartus -> paulirish)

jamiebuilds/marionette-wires 329

:shipit: An opinionated example application built with Marionette.js.

nasa/code-nasa-gov 202

code.nasa.gov site leveraging the Open Source Catalog on github.com, powered by Polymer

carrot/ship 151

⛔️ currently unmaintained ⛔️

jescalan/accord 137

a unified interface for compiled languages and templates in javascript

carrot/sprout 88

:seedling: simple project templating & skeletons

paulirish/caltrainschedule.io 50

:bullettrain_side: caltrain schedules - offline first :dolphin:

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 54aa06974aab89b93f178b87c2f7ebbca87d94c4

Fix typo

view details

push time in 3 hours

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 794e9ae3a3576a2daa3237e9774f955214cfc79f

Add the ability to download and import downloaded analysis bundles.

view details

push time in 6 hours

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 3a8deec5bbada7ee978de07647944d5a20209062

Remove unused imports

view details

Sam Saccone

commit sha 086259ac1f2fea5446fc4c14337fcede26400666

Mark one-line eval as ok.

view details

Sam Saccone

commit sha 5b8b0eea6c2b246f521dfec437be4703100f9235

Remove unused imports from resolve

view details

Sam Saccone

commit sha f9b3becbdbe5c25a041d2f6d2e0a4b00b08212bd

Remove whitespace from tr node

view details

Sam Saccone

commit sha ea495fec154db194a901c8cba3730cea81f63d5a

Remove additional lint warnings

view details

Sam Saccone

commit sha b39fc118e04272126c9d545a8462b0e8c7fcec8a

Remove production lock on host

view details

push time in 7 hours

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 76415ed32bc8a2c2d60bc24c7a061e740cbfa17d

Open external links as blank to preserve state. https://github.com/samccone/bundle-buddy/pull/36

view details

Sam Saccone

commit sha 76fa9d62eca5ff868ad6836af1470559f263a59d

Fix webpack instruction code https://github.com/samccone/bundle-buddy/pull/35

view details

Sam Saccone

commit sha 5acfe002677e64bd24968922a3a48d9dac001fe0

Migrate Report to tsx additionally fix noopener lint warning

view details

push time in 8 hours

push eventsamccone/bundle-buddy

Cameron Yick

commit sha 5b79c7645677e78d29f0201aad582a346b88122a

[feature] Add support for inlining data into HTML #20

view details

push time in 8 hours

PR merged samccone/bundle-buddy

Reviewers
[feature] Support inlining graph data into application HTML for single-folder deploys

Overview

  • Adds support for --standalone-bundle as suggested in https://github.com/samccone/bundle-buddy/issues/20#issuecomment-318680363
  • Modifies the base react app to read from the global DATA variable instead of fetching data if it is present on the window.
  • This command will create a folder adjacent to the existing viz/build folder, called viz/build-standalone. The contents of the existing folder are not modified, and a clean folder is created each time.

Motivation

Someone should be able to comfortably run gh-pages, netlify, or any static site host on the build-standalone/ folder to share their results.

Testing

I commented out this line https://github.com/samccone/bundle-buddy/blob/7746d3497d8d3d53219698e9be6c4a913c257a68/process.ts#L241 , and ran bundle buddy against itself. While it currently doesn't have any duplication (leading to the result that no data was displayed), it demonstrated that the app can load without crashing in this inline mode.

yarn start viz/build/static/js/*.map --standalone-bundle

Miscellaneous

  • I mocked out the jsdom type definition since installing @types/jsdom and @types/parse5 was not sufficient to make type errors go away, and it didn't seem worth it to add many dependencies for what wasn't a key part of the app.
+756 -13

1 comment

9 changed files

hydrosquall

pr closed time in 8 hours

issue closedsamccone/bundle-buddy

Nothing happens?

Hi, when I run bundle-buddy, after 3 minutes of doing something, it exits with `"no bundle duplication detected" and nothing else happens, how do I open the UI?

My bundle is quite large.

closed time in 8 hours

FezVrasta

issue closedsamccone/bundle-buddy

Graph area too small, bundles fall outside of space and are unreachable

Problem: In large projects, some bundles are impossible to find in the graph area. Example:

screen shot 2017-07-26 at 11 18 50 am

As you can see, I have my browser extremely maximized and yet some bundles are falling out to the right of the screen. When the browser window is made smaller, this is the outcome:

screen shot 2017-07-26 at 11 20 18 am

Notice that the bundles from the far left of the original screenshot are missing and many from the right are also missing.

Details:

  • bundle-buddy@0.1.2
  • Chrome 60
  • Webpack 2.4.1

closed time in 8 hours

paularmstrong

issue closedsamccone/bundle-buddy

CI integration: Add return code

Hey,

I'd love to use bundle-buddy to make sure we do not have duplicates (especially important when you have singleton modules such as a store/cache).

Would like to add a return code, or -quiet flag so that we can just detect the status and fail the build if we have duplicates.

closed time in 8 hours

abergs

issue closedsamccone/bundle-buddy

Missing "Synthetic" Async Bundles

When you use CommonsChunkPlugin() you can even remove duplication across async (lazy-loaded) chunks.

However I noticed that somewhere, the "async commons chunk" is ignored and not added to the viz (maybe missed in graph too?).

Steps to Reproduce:

  1. Clone this repo
  2. Comment out the AgressiveSplittingPlugin() (its so slow you'll get distracted and perf storm the plugin instead) from the webpack.config.js file, and add the property devtool: "source-map"
  3. Run yarn build See from results files like 0.0.bundle.js (should be a async commons chunk)
  4. Run bundle-buddy against the dist folder where assets and maps are output.

I'd help more with this for you but I'm working on some of the bundle type mapping code right now.

Here is a screen shot (for example the bundle I'm saying was missing is 0.0.bundle.js.map. screen shot 2017-07-16 at 5 34 15 pm

closed time in 8 hours

TheLarkInn

issue closedsamccone/bundle-buddy

Hosting bundle-buddy and viewing stats using JSON file.

As of now, we can view the bundle-buddy stats only locally. It would be better to host it remotely (on github pages).

It will be something similar to https://chrisbateman.github.io/webpack-visualizer/

Any suggestions would be great.

closed time in 8 hours

reznord

issue closedsamccone/bundle-buddy

Bundle Classifications

Reference

webpack has 3 types of chunks (or as.most people call them, bundles) that are generated:

  • Entry Chunk: this is a bundle that contains the webpack bootstrap/runtime code in it.

  • Initial Chunk: a chunk that does not have a runtime, and is usually generated via some configuration feature. It is loaded sync

  • Normal Chunk: a chunk that does not have the runtime and is created by code-splitting (lazy). It is not called async on the page.

For the most part one can gather enough information with the source maps to classify a majority of the chunk types.

Proposal

I'd like to propose the creation of an API that will help to classify bundles into these three categories based on their source and runtime contents.

To classify each:

  • Entry Chunk: read source to see if it contains modules and runtime code in single bundle

  • Initial Chunk: Look for no runtime and only modules. Can typically be found by presence of modules wrapped in webpackJsonp function, however since this function name is configurable it's best to instead identify by lack of runtime. The second part is looking for the Entry chunk this chunk sync depends on. This will be identified by looking for the chunk initiator inside of the accompanying Entry chunk.

  • Normal Chunk: this can be classified by a bundle having no runtime and the accompanying Entry chunk having no chunk initializer inside of the entry chunk (therefore indicating that it is loaded completely independent of the accompanying Entry chunk)

Bonus Points

Since this tool is (mostly) webpack specific, we could also add an extra API that skips all this crazy classification work, and consumes a bit of metadata that describes all this info from webpack's emitted Stats object.

closed time in 8 hours

TheLarkInn

issue closedsamccone/bundle-buddy

Error when co-located source maps

Hey @samccone, I am trying to run bundle-buddy src/**/*.map but for all files its throwing Error processing src/folderName/fileName.js.map, TypeError: Cannot read property 'split' of null and ends with No bundle source maps were processed.

My source maps files are co-located with source files and not in public.

closed time in 8 hours

ivikash

issue closedsamccone/bundle-buddy

Add tslint

closed time in 8 hours

morajabi

issue closedsamccone/bundle-buddy

Add some badges

closed time in 8 hours

morajabi

delete branch samccone/bundle-buddy

delete branch : paulirish-patch-1

delete time in 8 hours

PR closed samccone/bundle-buddy

fix stats.json fs.write call

writeJSONSync isn't a thing, but that'd be cool. :p

+3 -3

1 comment

1 changed file

paulirish

pr closed time in 8 hours

pull request commentsamccone/bundle-buddy

fix stats.json fs.write call

manually applied.

paulirish

comment created time in 8 hours

delete branch samccone/bundle-buddy

delete branch : paulirish-patch-2

delete time in 8 hours

PR closed samccone/bundle-buddy

target=_blank on external link

so i dont loose my state.

+1 -1

2 comments

1 changed file

paulirish

pr closed time in 8 hours

pull request commentsamccone/bundle-buddy

target=_blank on external link

manually applied

paulirish

comment created time in 8 hours

PR closed samccone/bundle-buddy

Bump handlebars from 4.0.10 to 4.7.3 in /viz dependencies

Bumps handlebars from 4.0.10 to 4.7.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/wycats/handlebars.js/blob/master/release-notes.md">handlebars's changelog</a>.</em></p> <blockquote> <h2>v4.7.3 - February 5th, 2020</h2> <p>Chore/Housekeeping:</p> <ul> <li><a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1644">#1644</a> - Download links to aws broken on handlebarsjs.com - access denied (<a href="https://api.github.com/users/Tea56">@Tea56</a>)</li> <li>Fix spelling and punctuation in changelog - d78cc73</li> </ul> <p>Bugfixes:</p> <ul> <li>Add Type Definition for Handlebars.VERSION, Fixes <a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1647">#1647</a> - 4de51fe</li> <li>Include Type Definition for runtime.js in Package - a32d05f</li> </ul> <p>Compatibility notes:</p> <ul> <li>No incompatibilities are to be expected</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.2...v4.7.3">Commits</a></p> <h2>v4.7.2 - January 13th, 2020</h2> <p>Bugfixes:</p> <ul> <li>fix: don't wrap helpers that are not functions - 9d5aa36, <a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1639">#1639</a></li> </ul> <p>Chore/Build:</p> <ul> <li>chore: execute saucelabs-task only if access-key exists - a4fd391</li> </ul> <p>Compatibility notes:</p> <ul> <li>No breaking changes are to be expected</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.1...v4.7.2">Commits</a></p> <h2>v4.7.1 - January 12th, 2020</h2> <p>Bugfixes:</p> <ul> <li>fix: fix log output in case of illegal property access - f152dfc</li> <li>fix: log error for illegal property access only once per property - 3c1e252</li> </ul> <p>Compatibility notes:</p> <ul> <li>no incompatibilities are to be expected.</li> </ul> <p><a href="https://github.com/wycats/handlebars.js/compare/v4.7.0...v4.7.1">Commits</a></p> <h2>v4.7.0 - January 10th, 2020</h2> <p>Features:</p> </tr></table> ... (truncated) </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/wycats/handlebars.js/commit/c9789691af60b446f12f75dd9762f9d8fd3f36eb"><code>c978969</code></a> v4.7.3</li> <li><a href="https://github.com/wycats/handlebars.js/commit/9278f217e0033cc980c58d50e7fd4b05c8ef7c35"><code>9278f21</code></a> Update release notes</li> <li><a href="https://github.com/wycats/handlebars.js/commit/d78cc73d3c51763654d66d52b5b761231f5adea9"><code>d78cc73</code></a> Fixes spelling and punctuation</li> <li><a href="https://github.com/wycats/handlebars.js/commit/4de51fe26ba049c743993424b937c0afc6cd9ae9"><code>4de51fe</code></a> Add Type Definition for Handlebars.VERSION, Fixes <a href="https://github-redirect.dependabot.com/wycats/handlebars.js/issues/1647">#1647</a></li> <li><a href="https://github.com/wycats/handlebars.js/commit/a32d05f2fc65b1c017e7f482430392d242a97ffc"><code>a32d05f</code></a> Include Type Definition for runtime.js in Package</li> <li><a href="https://github.com/wycats/handlebars.js/commit/ad63f5189ffe262e013f2bb9da69c66bed7801ee"><code>ad63f51</code></a> chore: add missing "await" in aws-s3 publishing code</li> <li><a href="https://github.com/wycats/handlebars.js/commit/586e672c8bba7db787bc9bfe9a9fde4ec98d5b4f"><code>586e672</code></a> v4.7.2</li> <li><a href="https://github.com/wycats/handlebars.js/commit/f0c6c4cc1f9a91371535ad6affe09dfc1880dd9e"><code>f0c6c4c</code></a> Update release notes</li> <li><a href="https://github.com/wycats/handlebars.js/commit/a4fd391ba1c9faa1004e879f314beb80c3afe0b6"><code>a4fd391</code></a> chore: execute saucelabs-task only if access-key exists</li> <li><a href="https://github.com/wycats/handlebars.js/commit/9d5aa363cf3031b586e9945cf990e178f5b370db"><code>9d5aa36</code></a> fix: don't wrap helpers that are not functions</li> <li>Additional commits viewable in <a href="https://github.com/wycats/handlebars.js/compare/v4.0.10...v4.7.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+35 -14

1 comment

1 changed file

dependabot[bot]

pr closed time in 8 hours

pull request commentsamccone/bundle-buddy

target=_blank on external link

LGTM

paulirish

comment created time in 10 hours

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 2211352f71ea6f2e5230098c20e6e4d8b48504af

Force add service worker shim in

view details

push time in 10 hours

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 7eb5381f9adf99f7613d87dbcdcf48bfbbd6c3c3

Update travis.yml now that the project is no longer nested

view details

push time in 10 hours

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 4ececf6491b3f3574ec55089be733287ab7effa8

Move files for new application to the root dir.

view details

push time in 10 hours

push eventsamccone/bundle-buddy

Sam Saccone

commit sha b0d2d2eef99a5d27dbeb90c133a5369dc93a4bc7

Bump travis to latest node version

view details

push time in 10 hours

push eventsamccone/bundle-buddy

Sam Saccone

commit sha a0ec9bfd1334965c5507c1f5f5955d332904c6c7

Remove trailing , in tsconfig https://github.com/nrwl/nx/issues/1462

view details

Sam Saccone

commit sha f173090d087efad945fe9fbe6e94f7de51c843d8

Update storybook and additional packages

view details

push time in 10 hours

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 87ccd54e37c58d3fd028e584adfdf06382993af8

Upgrade packages + typescript for project

view details

Sam Saccone

commit sha a6f5e33418adb9d8852eebbf49c31f8f7af1d46a

Bump react scripts to latest

view details

push time in 10 hours

push eventpaulirish/caltrainschedule.io

Sam Saccone

commit sha 4856321a3b2cd8e2f9c4831cdc565fc46a8c9c2a

Inline code to cut down on critical e2e load time.

view details

push time in 2 months

push eventpaulirish/caltrainschedule.io

Sam Saccone

commit sha 5e16271ddff398ba065609c61f1c24ef8a2aee01

Fix infinite loop situation where program crashed. Previously on ER ... the loop would never end if there were no matching schedules. Assume that the train runs at least once per week.

view details

Sam Saccone

commit sha 42b364da52671d0776ac7ea137025096ac7d115a

ignore node_modules it is 2020 \o/

view details

Sam Saccone

commit sha 8d79441d0a21cc644581e21c3ce95537f2ca5ab6

bump sw

view details

push time in 2 months

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 98520b731e73dc488fcdf5ecb6f9b51cde4d8469

ignore magic bootstrap

view details

push time in 3 months

PR opened drop-ice/dear-github-2.0

Reviewers
add @samccone
+1 -0

0 comment

1 changed file

pr created time in 4 months

push eventsamccone/dear-github-2.0

Sam Saccone

commit sha 9b78585f7177f583ac6e918758683b4273ae3453

add @samccone

view details

push time in 4 months

fork samccone/dear-github-2.0

📨 An open letter to GitHub from the maintainers of open source projects

fork in 4 months

startedpaulirish/mojibar-web

started time in 5 months

push eventsamccone/trace

Sam Saccone

commit sha ebdbffc9a6886a4ef82342fafe0d44e7764c6eac

Bump v0.1.4

view details

push time in 5 months

push eventsamccone/trace

Sam Saccone

commit sha c747d2c53e455f292ae3bcefd837546e9bbe7102

for loop bucket loop due to CC bug

view details

Sam Saccone

commit sha 08161c1c7858cf49b6c85a35764a87ad6b449574

Switch from parseInt to Number

view details

Sam Saccone

commit sha f46dd6c6b1eac56c980dfda98bcd0503af425068

Fix compile errors

view details

push time in 5 months

created tagsamccone/trace

tagv0.1.3

created time in 5 months

push eventsamccone/trace

Sam Saccone

commit sha 082b7244b050ed8236728598ef1f39d27c119b74

Enable unregistration of global events. This makes creation and cleanup easy and prevents double registrations for events which can cause many problems.

view details

Sam Saccone

commit sha 394e111d020d8e0d0b884bdc561099814001ee4b

bump v0.1.3

view details

push time in 5 months

pull request commentpaulirish/caltrainschedule.io

update gems

sgtm <3 ruby

paulirish

comment created time in 5 months

push eventsamccone/trace

Sam Saccone

commit sha d02e538365ff1e28425fab998a252074103a6e14

Pass through generic type for lastRenderOpts. This avoids a strict compile error.

view details

push time in 5 months

created tagsamccone/trace

tagv0.1.1

created time in 6 months

created tagsamccone/trace

tagv0.1.2

created time in 6 months

push eventsamccone/trace

Sam Saccone

commit sha 81c51f485784feb068924e06b7756e2ae5eb15b3

v0.1.2 bump

view details

push time in 6 months

push eventsamccone/trace

Sam Saccone

commit sha 5bd0c3e8c042826d16a88b7a13c48b315108f348

Initial time zoom glue

view details

push time in 6 months

push eventsamccone/trace

Sam Saccone

commit sha 2551b89c79d5286094b124853039fee520a1b56a

Migrate to bare d3 for easier compat builds

view details

Sam Saccone

commit sha 1a954da03fbb65528d6c092c71fd84350e368067

bump v0.1.1

view details

push time in 6 months

push eventsamccone/trace

Sam Saccone

commit sha 941d2401f758b53d3b668c51a29c083074e51ea2

Add description and repo to package.json

view details

push time in 6 months

created tagsamccone/trace

tagv0.1.0

created time in 6 months

push eventsamccone/trace

Sam Saccone

commit sha 5f5af0e01d1b8b0252ef96e70f0ef63392cf11c4

Add initial name and version

view details

push time in 6 months

issue closedsamccone/trace

add time legend

closed time in 6 months

samccone

push eventsamccone/trace

Sam Saccone

commit sha 8f378b5658c4ab5cdd0a2283c10d544ec0456d8d

removed unused filter helper

view details

push time in 6 months

push eventsamccone/trace

Sam Saccone

commit sha d71d402fe29a0ac15657b0a7f26e4fe7bc5f937d

Move facet inside of core public typing

view details

Sam Saccone

commit sha 08226a70d7ca7e38cac9c40002f8dd1c93bace05

only start range with keydown

view details

Sam Saccone

commit sha 6471345c08a5a6ba79258624fe3eac30d483c549

Unset cursor state when over margins.

view details

Sam Saccone

commit sha b1ff9d9bb3c5dbdbcb0c89f0988c6744e42b666d

Add theming support for the renderer.

view details

Sam Saccone

commit sha 0d3f108efa3a7b68a32afa636d426de8e80ab85f

Add basic readme

view details

push time in 6 months

PublicEvent

pull request commentsamccone/bundle-buddy

[feature] Support inlining graph data into application HTML for single-folder deploys

Thanks for the PR @hydrosquall I will review this.

hydrosquall

comment created time in 6 months

issue commentsamccone/bundle-buddy

Invalid 302 redirect when attempting to load

bundle-buddy@0.2.2 is now published

tivac

comment created time in 6 months

created tagsamccone/bundle-buddy

tagv0.2.2

A tool to identify bundle duplication across splits.

created time in 6 months

push eventsamccone/bundle-buddy

Sam Saccone

commit sha 7746d3497d8d3d53219698e9be6c4a913c257a68

Bump v0.2.2

view details

push time in 6 months

issue commentsamccone/bundle-buddy

Invalid 302 redirect when attempting to load

Big thanks to @ian-craig for fixing this.

tivac

comment created time in 6 months

push eventsamccone/bundle-buddy

Ian Craig

commit sha 68480f4125a3cd7feef1a808d7c81939ca2b7124

Fix contributing steps for CLI, Suggest running with npx

view details

push time in 6 months

PR merged samccone/bundle-buddy

Fix contributing steps for CLI, Suggest running with npx

Steps for working on the CLI don't indicate that you need to build the front end first. I got caught by this as I wasn't immediately aware that the front end was a separate package.

npx now allows installing on demand, which significantly reduces the barrier to entry for trying a tool like bundle-buddy, so the usage instructions should take advantage of this.

+13 -2

1 comment

1 changed file

ian-craig

pr closed time in 6 months

pull request commentsamccone/bundle-buddy

Fix contributing steps for CLI, Suggest running with npx

Again, an awesome contribution. thank you so much!

ian-craig

comment created time in 6 months

push eventsamccone/bundle-buddy

Ian Craig

commit sha 07213ec8e57964ce93ee1f235912f281472730ac

Upgrade http-server to fix invalid redirect error

view details

Ian Craig

commit sha 41f8cf67d42cd2109ebbb74af3552f274db63c43

Switch to express for more stability

view details

push time in 6 months

PR merged samccone/bundle-buddy

Switch http-server to express fix invalid redirect error

Fixes #30

Update: I started by just updating http-server but was still running into issues sometimes. Switching to express seems to have fixed it, and it's better supported.

Also switching from openport to portfinder as openport is deperecated and wasn't correctly finding open ports.

+415 -99

1 comment

3 changed files

ian-craig

pr closed time in 6 months

issue closedsamccone/bundle-buddy

Invalid 302 redirect when attempting to load

Every time I try to open the URL for my local bundle-buddy instance my browser breaks.

Here's what it looks like in FF:

image

And in Chrome:

image

I investigated further, here's what I'm seeing:

  1. I run npx bundle-buddy dist/*.map
  2. bundle-buddy runs, and opens a new tab in my default browser to http://localhost:1024/?file=data_1560791818215
  3. That URL returns a 302 with a location header value of //?file=data_1560791818215
  4. The browser ignores that invalid 302 value and throws up its hands
> npm --versions
{ '*********': '1.0.0',
  npm: '6.9.0',
  ares: '1.15.0',
  cldr: '33.1',
  http_parser: '2.8.0',
  icu: '62.1',
  modules: '64',
  napi: '3',
  nghttp2: '1.34.0',
  node: '10.15.3',
  openssl: '1.1.0j',
  tz: '2018e',
  unicode: '11.0',
  uv: '1.23.2',
  v8: '6.8.275.32-node.51',
  zlib: '1.2.11' }
> node -p process.platform
win32

closed time in 6 months

tivac

pull request commentsamccone/bundle-buddy

Switch http-server to express fix invalid redirect error

Awesome! thank you for the contribution

ian-craig

comment created time in 6 months

pull request commentsindresorhus/devtools-detect

OH HAI I BUMPED THIS FOR U

We were so naive.

passy

comment created time in 6 months

issue commentangular/tsickle

tsickle generates invalid type annotation syntax in async/await literal

beautiful, thank you Evan!

samccone

comment created time in 6 months

more