profile
viewpoint
Sam Roberts sam-github IBM Canada Vancouver, BC, Canada https://sam-github.github.io/

libnet/libnet 560

A portable framework for low-level network packet construction

RuntimeTools/appmetrics-dash 319

A data visualizer that uses " Node Application Metrics" (appmetrics) to monitor and display Node.js application data as a html web application.

ibmruntimes/yieldable-json 74

Asynchronous JSON parser and stringify APIs that make use of generator patterns

nodejs/webcrypto 54

Implementation of WebCrypto API as an npm package

IBM/nodejs-in-the-cloud 2

Node.js in the Cloud tutorial

kjdelisle/dist-tagger 1

A tool for not wasting time manually typing out dist-tag commands.

sam-github/bcrc-lua 1

lua binding to boost/crc, a generic CRC library

hassaanp/node 0

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

libnet/libnet-lua 0

lua bindings for libnet

miqmago/reuse-session-node 0

See issue in node repo

PR closed nodejs/node

test: mark test-dgram-multicast-ssmv6-multi-process flaky fast-track test

refs: https://github.com/nodejs/node/issues/32946

Mark this test as flaky on linux as its been failing test-commit-custom-suites-freestylefor a while

Ive used sequential.status as a template for this file.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

+26 -0

5 comments

1 changed file

AshCripps

pr closed time in 3 days

pull request commentnodejs/node

test: mark test-dgram-multicast-ssmv6-multi-process flaky

Landed in e14786f69f8a

AshCripps

comment created time in 3 days

push eventnodejs/node

AshCripps

commit sha e14786f69f8a7564ea568dee5ae25a7b35522e59

test: mark test-dgram-multicast-ssmv6-multi-process flaky refs: https://github.com/nodejs/node/issues/32946 Mark this test as flaky on linux Ive used sequential.status as a template for this file PR-URL: https://github.com/nodejs/node/pull/33498 Refs: https://github.com/nodejs/node/issues/32946 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

push time in 3 days

create barnchCloudNativeJS/cloud-health

branch : sam-github-patch-1

created branch time in 3 days

create barnchCloudNativeJS/cloud-health-connect

branch : sam-github-patch-1

created branch time in 3 days

pull request commentnodejs/node

meta: add flaky test issue template

@bcoe WDYT? I'd be tempted to leave it out, the tap output is usually not that long.

AshCripps

comment created time in 4 days

pull request commentnodejs/node-core-utils

[WIP] Add functionality for daily-master to NCU-CI

The intention was just this,

adds some logic so that the command can be used on daily build data

but maybe some other logic was added as needed.

AshCripps

comment created time in 4 days

issue commentnodejs/admin

Approval to enable github pages for node-addon-examples

There was a org wide audit of wikis from a security perspective, because some of them were turned on, world-writable. It was a fair bit of work, @MylesBorins I think did the work, but it gave me the sense that turning features in a github repo on and off is not just the concern of the people working in that repo, it can have org wide concerns.

The posting of an issue in admin isn't so much of a "asking permission", IMO, its more of a courtesy notification. There are lots of projects sharing the nodejs org, some small amount of coordination/notification of what's going on doesn't seem like an excessive burden to me. We could even make it explicit that it doesn't have to wait for approval, its just for notification.

Or maybe github pages is not in the same category as the wiki, and I'm overly concerned, but above is the source of my concern.

mhdawson

comment created time in 4 days

pull request commentnodejs/node

process: Throw exception on --unhandled-rejections=default

tsc-agenda was put on 28 days ago, so its been through multiple TSC meetings, is there still some feedback that is needed?

dfabulich

comment created time in 4 days

pull request commentnodejs/node

win: allow skipping the supported platform check

These were tagged TSC agenda, but it looks like consensus was found, and there isn't anything to discuss?

joaocgreis

comment created time in 4 days

pull request commentnodejs/node

src,win: Replacement of unsupported versions of Windows runtime exit.

Tagged TSC agenda, but not clear what should be discussed. It looks like #33176 is accepted?

xCykrix

comment created time in 4 days

pull request commentnodejs/build

Add IBM i initial playbooks

:birthday:

ThePrez

comment created time in 4 days

push eventnodejs/build

Jesse Gorzinski

commit sha 9cf3680add6ee833cff9bdf855d5c9ab70c1532a

Add IBM i initial playbooks (#1923) Co-Authored-By: Kevin Adler <kadler@us.ibm.com> Co-authored-by: Sam Roberts <vieuxtech@gmail.com> Co-authored-by: George Adams <george.adams@uk.ibm.com> Co-authored-by: Richard Lau <riclau@uk.ibm.com>

view details

push time in 4 days

PR merged nodejs/build

Add IBM i initial playbooks ansible platform:ibmi

Supercedes and addresses PR #1700

Addresses part of issue #1697

TODO items remaining are (at least):

  • [ ] test and verify whether su works now.
+151 -11

26 comments

15 changed files

ThePrez

pr closed time in 4 days

issue closedlibnet/libnet

Libenet

closed time in 4 days

dadaluna89

Pull request review commentnodejs/node

meta: add flaky test issue template

+---+name: Report a flaky test+about: Report a flaky test in our CI+labels: "CI / flaky test"++---++<!--+Thank you for reporting an flaky test.++Please fill in as much of the template below as you're able.++Test: The test that is flaky - e.g. `test-fs-stat-bigint`+Platform: The platform the test is flaky on - e.g. `macos` or `linux`+Console Output: A pasted console output from a failed CI job showing the whole failure of the test+Build Links: Links to builds affected by the flaky test+Failure Rate: How often does this test fail - e.g. 1 in 10 builds++If possible please try to give a timeframe to the when the test started failing to assist with investigation+-->++* **Test**:+* **Platform**:+* **Console Output**:+* **Build Links**:+* **Failure Rate**:

I don't think we should do this, see my suggestion above. I don't usually include anything like this. I might mention whether it is always or sometimes (but tests that fail always are usually caught by PRs because they always fail... resuming the PR build won't get past them and it would have to be fixed).

AshCripps

comment created time in 4 days

Pull request review commentnodejs/node

meta: add flaky test issue template

+---+name: Report a flaky test+about: Report a flaky test in our CI+labels: "CI / flaky test"++---++<!--+Thank you for reporting an flaky test.++Please fill in as much of the template below as you're able.++Test: The test that is flaky - e.g. `test-fs-stat-bigint`+Platform: The platform the test is flaky on - e.g. `macos` or `linux`+Console Output: A pasted console output from a failed CI job showing the whole failure of the test+Build Links: Links to builds affected by the flaky test+Failure Rate: How often does this test fail - e.g. 1 in 10 builds++If possible please try to give a timeframe to the when the test started failing to assist with investigation+-->++* **Test**:+* **Platform**:+* **Console Output**:

If the markup is included with a COPY THE FAIL TEST OUTPUT HERE that could help a bunch.

AshCripps

comment created time in 4 days

Pull request review commentnodejs/node

meta: add flaky test issue template

+---+name: Report a flaky test+about: Report a flaky test in our CI+labels: "CI / flaky test"++---++<!--+Thank you for reporting an flaky test.++Please fill in as much of the template below as you're able.++Test: The test that is flaky - e.g. `test-fs-stat-bigint`+Platform: The platform the test is flaky on - e.g. `macos` or `linux`+Console Output: A pasted console output from a failed CI job showing the whole failure of the test+Build Links: Links to builds affected by the flaky test+Failure Rate: How often does this test fail - e.g. 1 in 10 builds++If possible please try to give a timeframe to the when the test started failing to assist with investigation

If any investigation has been done, please include any information found, such as how consistently the test fails, whether the failure could be reproduced locally, when the test started failing, or anything else you think is relevant.
AshCripps

comment created time in 4 days

Pull request review commentnodejs/node

meta: add flaky test issue template

+---+name: Report a flaky test+about: Report a flaky test in our CI+labels: "CI / flaky test"++---++<!--+Thank you for reporting an flaky test.++Please fill in as much of the template below as you're able.
Thank you for reporting a flaky test.

Flaky tests are tests that fail occaisonally in Node.js CI, but not consistently enough to block PRs from landing, or that are failing in CI jobs or test modes that are do not run for every PR. Since they are failing in CI, all the information for the template below should be available.
AshCripps

comment created time in 4 days

pull request commentnodejs/security-wg

chore(member): add myself as new member

Invite sent.

DanielRuf

comment created time in 4 days

pull request commentnodejs/node

test: mark test-dgram-multicast-ssmv6-multi-process flaky

I propose fast-tracking if CI is green for the PR.

AshCripps

comment created time in 5 days

pull request commentnodejs/node

test: mark test-dgram-multicast-ssmv6-multi-process flaky

the daily triggers this through https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/configure, and it looks good

python tools/test.py -j $JOBS -p tap --logfile test.tap --mode=release --flaky-tests=dontcare $TEST_ARGS $CI_JS_SUITES

AshCripps

comment created time in 5 days

pull request commentnodejs/node-core-utils

[WIP] Add functionality for daily-master to NCU-CI

We're trying to figure out if we should push it forward because its useful and achievable, or perhaps whether its a bit of an improvement already and can be merged, or perhaps it was just an interesting experiment and we should abandon it.

@joyeecheung what do you think?

AshCripps

comment created time in 5 days

issue commentnodejs/node

flaky test-dgram-multicast-ssmv6-multi-process on linux

still failing: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/14334/

sam-github

comment created time in 5 days

pull request commentnodejs/security-wg

chore(member): add myself as new member

@lirantal SGTM. Do you need to do that to add him to https://github.com/orgs/nodejs/teams/ecosystem-security? I can do it if you don't have enough privs.

DanielRuf

comment created time in 5 days

issue closednodejs/build

Planned outage for test-osuosl-aix72-ppc64_be-2

FYI @nodejs/libuv

This coming Monday, April 27th, test-osuosl-aix72-ppc64_be-2 will be taken down so that the hardware its running on can get some routine maintenance. Its predicted it will occur sometime during the day, Oregon (US) time, and take about 4 hours.

libuv-test-commit-aix uses this machine for xlc builds, and is the only user.

https://ci.nodejs.org/computer/test-osuosl-aix72-ppc64_be-2/builds

Sorry for the disruption, it should be fairly brief.

closed time in 5 days

sam-github

issue commentnodejs/build

Planned outage for test-osuosl-aix72-ppc64_be-2

I believe so, but another is planned, #2329

sam-github

comment created time in 5 days

issue commentnodejs/Release

Node.js Release WorkGroup Meeting 2020-05-21

I labelled it.

mhdawson

comment created time in 5 days

pull request commentnodejs/build

Add IBM i initial playbooks

There are a couple minor comments, but once addressed, I think this should be merged. Its not set in stone, we can PR more changes later if necessary while getting node.js build jobs working.

ThePrez

comment created time in 5 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

 After these steps are performed and the Pi's are running, Ansible can be run to [Setting up a Windows Host]: https://docs.ansible.com/ansible/latest/user_guide/windows_setup.html [newer Ansible configuration]: https://github.com/nodejs/build/tree/master/ansible [stand-alone]: https://github.com/nodejs/build/tree/master/setup/windows++## IBM i++Ansible 2.7.6 is required.++There isn't a system start service on IBMi -- the machine should not be+rebooted, and after ansible is run, jenkins needs to be started with+jenkins-start.sh. This will submit the job under the iojs user++The following manual steps must be done to set 

deleted sentence, we are already in the manual steps docs.

ThePrez

comment created time in 5 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

 #    - name: upgrade installed packages-    yum: name=* state=latest+    yum: name=* state=latest use_backend=yum+# XXX might have needed `use_backend=yum` at end of last line, but prob+# not, was a workaround for a fixed path problem
# If difficulty recognizing yum is encountered, see https://github.com/ansible/ansible/pull/69484, it is possible
# to apply that patch manually to a local install of ansible (if necessary).
ThePrez

comment created time in 5 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

 #    - name: upgrade installed packages-    yum: name=* state=latest+    yum: name=* state=latest use_backend=yum+# XXX might have needed `use_backend=yum` at end of last line, but prob

seems we did need it

ThePrez

comment created time in 5 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

 After these steps are performed and the Pi's are running, Ansible can be run to [Setting up a Windows Host]: https://docs.ansible.com/ansible/latest/user_guide/windows_setup.html [newer Ansible configuration]: https://github.com/nodejs/build/tree/master/ansible [stand-alone]: https://github.com/nodejs/build/tree/master/setup/windows++## IBM i++Ansible 2.7.6 is required.++There isn't a system start service on IBMi -- the machine should not be

This is out of date now, isn't it? the start is being submitted as some kind of IBMi specific service job?

ThePrez

comment created time in 5 days

Pull request review commentneeraj-laad/nodejs-basic-starter

Sync express from appsody/stacks

-const express = require('express')-const app = express()-const port = 3000+module.exports = (/*options*/) => {+  // Use options.server to access http.Server. Example with socket.io:+  //     const io = require('socket.io')(options.server)+  const app = require('express')() -app.get('/', (req, res) => res.send('Hello World!'))+  app.get('/', (req, res) => {+    // Use req.log (a `pino` instance) to log JSON:+    req.log.info({message: 'Hello from Appsody!'});

I could, from a user-perspective, it sounds nice, but it I am concerned that doing it would be demonstrating anti-patterns in the sample app:

  1. there are good ways to send html to the client, and bad ways, and if we just have a hard-coded html string we dump we are doing it the bad way, but doing the better ways are all bringing a lot of machinery for html generation into a simple application that doesn't otherwise need it

  2. the app isn't supposed to know anything about the stack-defined routes around it, so once again, though its convenient, having the app generate an HTML page that refers to routes back in the stack seems an anti-pattern in that it breaks seperation of concerns

Also, I think its something that should be done across the stacks/CP4Apps, not just a per-stack one-off.

That said, if the benefits of a nicer HTML welcome page are compelling, I could do it.

WDYT?

sam-github

comment created time in 5 days

delete branch sam-github/nodejs-basic-starter

delete branch : sync-to-appsody

delete time in 5 days

issue openednodejs/build

maintenance notification: test-osuosl-aix72-ppc64_be-2

https://ci.nodejs.org/computer/test-osuosl-aix72-ppc64_be-2/ will be down for a few hours on Monday May 25th, 0600 GMT.

Planned work is:

Basically, all that is going to happen is a rootvg clone, then reboot to the clone; cleanup the old rootvg (i.e., remove from ODM so the disk can be removed). Ideally, systems should be up and running in less than 2 hours after I start.

@nodejs/libuv this will briefly affect availability of the xlc builds of the https://ci.nodejs.org/job/libuv-test-commit-aix/ job

created time in 5 days

issue commentnodejs/build

root access to OSUOSL AIX machines for Michael Felt

If we could get a couple +1s, that would be great, the rework being done should be quite helpful to us, but the infra provider will need to "peek into the box" to make it happen, and that requires ssh access.

And to be explicit, I'm definitely +1!

mhdawson

comment created time in 5 days

push eventsam-github/nodejs-stack-registry

Neeraj Laad

commit sha 39f61658cbeea2111bf739f17bbf56bcc296fa4c

Merge pull request #1 from sam-github/sync-to-appsody Sync to appsody/stacks capabilities

view details

Neeraj Laad

commit sha 98273919bfb75d57fdfaf34aeb9de80d6a52a916

Rename devfiles/nodejs/devfile.yaml to devfiles/nodejs-basic/devfile.yaml

view details

Neeraj Laad

commit sha 7f1cb1647193cfc695b2f2f038309e5764b91311

Rename devfiles/nodejs/meta.yaml to devfiles/nodejs-basic/meta.yaml

view details

Neeraj Laad

commit sha ca2b10c1a45e8ca57f241f60d7d921fb76966119

repo renames

view details

push time in 5 days

issue commentopenshift/odo

--downloadSource doesn't feel natural

I like --starter, I found --downloadSource undiscoverable (I didn't guess its purpose even from the CLI help). Later, perhaps, --starter[=NAME | git-repo] if people want to select a specific starter, though starters should have as little code as possible, so maybe a well run stack will not have many of them

deboer-tim

comment created time in 6 days

pull request commentnodejs/node

src: document headers members in src/util.h

IFor unused headers, deleting their include statements SGTM, totally uncontroversial.

juanarbol

comment created time in 6 days

push eventsam-github/nodejs-stacks

Sam Roberts

commit sha e9800db9932be299600700d40467830ac3d095ff

fixup! Sync to appsody/stacks capabilities

view details

push time in 6 days

push eventsam-github/express-starter-simple

Sam Roberts

commit sha 9394a9e918fb667e4df54fba9d38e4494bda20c0

fixup! Sync to appsody/stacks capabilities

view details

push time in 6 days

push eventsam-github/express-starter-simple

Sam Roberts

commit sha b739b3efaa0a37652a4d57831363fa0ce5e0e317

Sync to appsody/stacks capabilities

view details

push time in 6 days

create barnchsam-github/express-starter-simple

branch : sync-to-appsody

created branch time in 6 days

push eventsam-github/nodejs-starter-express

Sam Roberts

commit sha d92076883c2f6b59a2d2050ced97dd5f28c97850

Sync express from appsody/stacks Use incubator/nodejs-express layout.

view details

push time in 6 days

create barnchsam-github/nodejs-stacks

branch : sync-to-appsody

created branch time in 6 days

push eventsam-github/nodejs-starter-express

Sam Roberts

commit sha 13a5aeee79a16b6325e4bc0ee15d4bfdc90a378b

Sync express from appsody/stacks Use incubator/nodejs-express layout.

view details

push time in 6 days

fork sam-github/nodejs-stacks

Node.js stacks based on Devfile v1

fork in 6 days

PR opened neeraj-laad/nodejs-starter-express

Sync express from appsody/stacks

Use incubator/nodejs-express layout.

See: https://github.ibm.com/runtimes/squad-node/issues/713

+177 -6

0 comment

4 changed files

pr created time in 6 days

create barnchsam-github/nodejs-starter-express

branch : sync-to-appsody

created branch time in 6 days

Pull request review commentnodejs/security-wg

(WIP) docs: add meeting notes 2020-05-18

+# Node.js  Security WorkGroup Meeting 2020-05-18++## Links++* **Recording**:  
* **Recording**: https://www.youtube.com/watch?v=2TsR4kjrRVI 
lirantal

comment created time in 8 days

issue commentnodejs/security-wg

Nominate Eva Sarafianou to the triage team

@lirantal and @sam-github discussed in wg meeting, we've no objections, and no one else has had any objects.

MarcinHoppe

comment created time in 8 days

issue commentnodejs/security-wg

Nominate Eva Sarafianou to the triage team

+1 LGTM

MarcinHoppe

comment created time in 8 days

issue commentnodejs/security-wg

Reaching out to other projects of the OpenJS Foundation

There doesn't seem to be any topic to discuss live, so removed agenda.

If folks want to champion this, they should get involved, it seems reasonable.

vdeturckheim

comment created time in 8 days

issue commentnodejs/security-wg

Introducing Audit Hooks to Node.js

@vdeturckheim I think this should be discussed in Node.js core, and ping the sec folks here to ask them if they have comments.

Of was there something specific to add in the agenda?

vdeturckheim

comment created time in 8 days

issue commentnodejs/security-wg

Change repo name?

No objections, but should change after the DB has moved out of this repo, which is close to done.

MylesBorins

comment created time in 8 days

issue commentnodejs/security-wg

Node.js Security WorkGroup Meeting 2020-05-18

I started the meeting!

mhdawson

comment created time in 8 days

issue commentwtfutil/wtf

Security: open call for thoughts on securing WTF's config file

Note that on mac OS, you can also use docker-credential-pass, you aren't tied to keychain, or you can just write a shell script called docker-credential-keybase (or some more suitable name).

If you have immediate desire for pulling keys from keybase, your script only has to satisfy the "get" interface from https://github.com/docker/docker-credential-helpers#development: read the name of the server from stdin, then write a 3-item bit of JSON to stdout.

If you wanted to write a full keybase helper in go the credential-helper repo has some utility functions for building such a beast, maybe they'd even accept a contribution, keybase is pretty popular. Who knows what direction it will take post-zoom, though. I wish them well, I use it a bit myself.

In the longer term, I think the secret idea is interesting, give it a shot, The current helper approach didn't add any yml config file syntax, so the field is wide open still for some kind of generic shell script config-generation facility, or something more targeted at secrets.

senorprogrammer

comment created time in 8 days

pull request commentwtfutil/wtf

golangci-lint configuration file

ok, give me a chance to tidy this up a bit, I'll add at least a couple comments so people know how to do the setup.

Actually, WDYT, setup target, or just a comment saying "go get it"? I suspect for vscode integration it might need to be global anyhow.

sam-github

comment created time in 8 days

pull request commentwtfutil/wtf

golangci-lint configuration file

Btw, I don't use vscode, but it has golangci-lint integrations: https://golangci-lint.run/usage/integrations/, might be useful (I'm not sure if the standalone tools also do that).

sam-github

comment created time in 8 days

Pull request review commentwtfutil/wtf

golangci-lint configuration file

 install: 	@echo "${APP} installed into ${INSTALLPATH}"  ## lint: runs a number of code quality checks against the source code+cilint:

I should have mentioned, I called this cilint just so I could leave the original lint target in. Its a poor name, given that ci doesn't use it, it just uses the action. Oops.

I think the cilint target should be renamed lint, and the (current) lint target deleted.

sam-github

comment created time in 8 days

pull request commentwtfutil/wtf

golangci-lint configuration file

Yes, running the tool against multiple inputs simultaneously helps the current stuff a lot, its basically the optimization that golangci-lint does.

The current lint target assumes errcheck and staticcheck were installed globally, the cilint target assumes golantlint-ci is installed globally, its the same situation, isn't it? I'm pretty sure when I first tried to run make lint, I just looked up the name of the tools from the comments in the Makefile, and did a manual got get ... on them, then re-ran.

The build tool situation with go modules seems a bit obscure ATM, from https://github.com/golang/go/issues/25922 I've found and tried https://github.com/go-modules-by-example/index/blob/master/010_tools/README.md, but I still needed a setup style target:

setup:
	GOBIN=$$PWD/bin go install github.com/golangci/golangci-lint

# Make the obvious lint target depend on setup, so it works "out of the box"
lint: setup just-lint

# If you have done setup already, don't repeat it, its slow
just-lint:
        ./bin/golangci-lint run 

Other than an explicit setup target, I don't see a way of ensuring dev-time tools are available. Adding a tools.go to the above seems to be a way to ensure exact versions of the tools are installed, which could be a big deal for a long-running large project that needs stable builds over years, but not so much here.

sam-github

comment created time in 8 days

issue commentgolangci/golangci-lint

Invalid error message "context loading failed: no go files to analyze" when can't build project

In https://github.com/wtfutil/wtf/pull/895 I used args: ./... with golangci/golangci-lint-action@v0.2.0 to avoid this, though I don't need to when running on my own machine.

rmilejcz

comment created time in 9 days

pull request commentwtfutil/wtf

golangci-lint configuration file

Times for runs can be seen above. golangci-lint was 1m, imports check 51 sec, the others are 2m+. A small win.

sam-github

comment created time in 9 days

pull request commentwtfutil/wtf

golangci-lint configuration file

The inline annotations are nice (the existing integration likely has them, too, that's not an advantage).

Turns out it was just a ./... arg that's needed in the CI action (though not locally).

sam-github

comment created time in 9 days

push eventsam-github/wtf

Chris Cummer

commit sha e43c37cc076d6de73c97056db64da58ad126bc54

Fix broken gCal title Signed-off-by: Chris Cummer <chriscummer@me.com>

view details

Sam Roberts

commit sha 4bb725db9e51d196b88f2333acbfd0917ecd9c1d

golangci-lint configuration file golangci-lint can run all the currently enabled linters, and as far as I can tell, does it in under 5 seconds as opposed to over 180 seconds (compare `time make cilint` and `time make lint`). Some of the linters that are listed in the "enabled" section but commented out looked like a good idea to me, and fairly low hanging fruit to fix, but they are not passing at the moment. All the linters covered in the current Makefile are run. TODO: - replace lint target in Makefile with golangci-lint - remove .github/workflow/errcheck.yml

view details

push time in 9 days

pull request commentwtfutil/wtf

golangci-lint configuration file

Its possible (see https://github.com/golangci/golangci-lint/issues/825) that this is because go build (no args) tries to make a ./wtf executable, but there is already a ./wtf/ directory.

sam-github

comment created time in 9 days

push eventsam-github/wtf

Sam Roberts

commit sha b1aa57f851582a1d483a8a8234e948cbd635e8ab

fixup! golangci-lint configuration file

view details

push time in 9 days

PR opened wtfutil/wtf

golangci-lint configuration file

golangci-lint can run all the currently enabled linters, and as far as I can tell, does it in under 5 seconds as opposed to over 180 seconds (compare time make cilint and time make lint).

Some of the linters that are listed in the "enabled" section but commented out looked like a good idea to me, and fairly low hanging fruit to fix, but they are not passing at the moment.

All the linters covered in the current Makefile are run.

TODO:

  • replace lint target in Makefile with golangci-lint
  • remove .github/workflow/errcheck.yml

Just a suggestion. It might be much faster, and yet do the same thing, win-win. I did some fixing of things gocritic didn't like (its a big fan of switch statements over if/if else/if else/else series), but then stopped and disabled it. Some of the sec warnings seem not applicable to wtf given that it does shell out to user-defined commands at times, so enabling gosec would involve whitelisting some of the warnings. Etc.

On the down side, since this is passing, I won't see the line-annotation feature that is supposed to be enabled... maybe I should enable a couple of the failing linters temporarily in the PR, so that feature is visible?

+83 -41

0 comment

23 changed files

pr created time in 9 days

push eventsam-github/wtf

Sam Roberts

commit sha 6d9537f2b6530a447d8cf6adaa29d8b3204228a1

golangci-lint configuration file golangci-lint can run all the currently enabled linters, and as far as I can tell, does it in under 5 seconds as opposed to over 180 seconds (compare `time make cilint` and `time make lint`). Some of the linters that are listed in the "enabled" section but commented out looked like a good idea to me, and fairly low hanging fruit to fix, but they are not passing at the moment. All the linters covered in the current Makefile are run. TODO: - replace lint target in Makefile with golangci-lint - remove .github/workflow/errcheck.yml

view details

push time in 9 days

create barnchsam-github/wtf

branch : lint

created branch time in 9 days

issue commentnodejs/security-wg

Triage Buckets and Prioritization

I think this conversation is mixing in discussion of opt-in to bounties, and whether to accept reports at all.

Not addressing bounties for the moment:

@lirantal

We should communicate clearly that the SLA will be significantly slow

For the lower priority, what appears to be happening is the delay is infinite, because there aren't enough people to work through the high priority reports.

Is it saying we don't care about a module that has 1000 downloads?

No, it isn't saying "we don't care", its saying "sorry, but we don't have the capacity to handle these". Those are very different.

I feel its more caring, because instead of telling people "wait, we'll get to it eventually" (and then perhaps not) we say "I'm sorry, we don't have capacity to address this report".

Which leads to...

, and advise them to consider posting the report elsewhere like with npmjs, snyk or others.

I think this is a great idea. For packages under a certain number of downloads, they can report to organizations that have the capacity and interest to handle reports against (relatively) unpopular packages.

Even if we agree to that, it leaves the question: do we close as "sorry, no capacity to accept" or do we auto-disclose? I tend to the former.

lirantal

comment created time in 11 days

issue commentnodejs/node

I can't install in Ubuntu Focal Fossa due to python 2 dependencies

@hajalali Please see https://github.com/nodejs/node/issues/31247#issuecomment-571668788

The nodejs project can't fix this, because we didn't produce the nodesource packages. Our downloads are at https://nodejs.org/en/download/ and have no such dependency.

abolivar

comment created time in 11 days

issue commentnodejs/security-wg

Node.js Security WorkGroup Meeting 2020-05-18

Its a holiday here, but I can make it. I can likely start the video and all, as well.

mhdawson

comment created time in 11 days

issue commentnodejs/node

crypto: expose tls's x509 Certificate Object

You can see that #30675 is a quick POC, but I make no promises about having the time to finish it.

@RalphBragg If you want to pick it up, feel free to take that code and finish it, there's not much there and you are welcome to call it your own.

panva

comment created time in 12 days

issue commentnodejs/build

PSA: Scheduled maintanence of our orka environment

SGTM. also, won't builds continue on the nearform machines even if orka is down?

AshCripps

comment created time in 13 days

pull request commentnodejs/node

[v10.x] deps: fix V8 compiler error with clang++-11

https://ci.nodejs.org/job/node-test-commit-linux/34933/ failed on euid tests, hard to see how they are related. resumed again.

sam-github

comment created time in 13 days

pull request commentCloudNativeJS/cloud-health-connect

chore(deps-dev): bump @types/node from 13.13.6 to 14.0.1

@richardlau @seabaylea It looks like dependabot won't merge because CLA assistant failed "CI".

dependabot-preview[bot]

comment created time in 13 days

pull request commentnodejs/build

Add IBM i initial playbooks

It doesn't seem to be valid syntax:

failed: [test-iinthecloud-ibmi72-ppc64_be-1] (item=openssl-devel >= 1.1.1) => {"changed": false, "msg": "It appears that a space separated string of packages was passed in as an argument. To 
operate on several packages, pass a comma separated string of packages or a list of packages.", "package": "openssl-devel >= 1.1.1"}
ThePrez

comment created time in 13 days

pull request commentnodejs/build

Add IBM i initial playbooks

I pushed a fix to the openssl depspec.

Also, this was running to completion, now failing on

TASK [package-upgrade : upgrade installed packages] *******************************************
fatal: [test-iinthecloud-ibmi72-ppc64_be-1]: FAILED! => {"changed": false, "msg": "The Python 2 bindings for rpm are needed for this module. If you require Python 3 support use the `dnf` Ansi
ble module instead.. The Python 2 yum module is needed for this module. If you require Python 3 support use the `dnf` Ansible module instead."}

PLAY RECAP ************************************************************************************
test-iinthecloud-ibmi72-ppc64_be-1 : ok=2    changed=0    unreachable=0    failed=1 
ThePrez

comment created time in 13 days

push eventThePrez/build

Sam Roberts

commit sha 99f2deb84ffc3d6d7734ce122ea4ffed09d457cd

fixup! fixup! Add new IBM i system

view details

push time in 13 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

   when: jobs_env is undefined  - name: create group-  when: not os|startswith("zos")+  when: not os|startswith("zos") and not os|startswith("ibmi")   group: name="{{ server_user }}"  - name: create user-  when: "not os|startswith('zos')"+  when: "not os|startswith('zos') and not os|startswith('ibmi')"   user:     name: "{{ server_user }}"     group: "{{ server_user }}"     shell: "{{ bash_path[os|stripversion]|default('/bin/bash') }}" +- name: create user for ibmi+  when: os|startswith("ibmi")+  command: "/QOpenSys/usr/bin/system 'CRTUSRPRF USRPRF({{ server_user }}) PASSWORD(*none)'"

TASK [jenkins-worker : create user for ibmi] ************************************************** fatal: [test-iinthecloud-ibmi72-ppc64_be-1]: FAILED! => {"changed": true, "cmd": ["/QOpenSys/usr/bin/system", "CRTUSRPRF USRPRF(iojs) PASSWORD(*none)"], "delta": "0:00:00.117563", "end": "202 0-05-12 18:29:21.000635", "msg": "non-zero return code", "rc": 255, "start": "2020-05-12 18:29:20.883072", "stderr": "CPF2214: User profile IOJS already exists.", "stderr_lines": ["CPF2214: U ser profile IOJS already exists."], "stdout": "", "stdout_lines": []}

@ThePrez

ThePrez

comment created time in 13 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

+---++#+# install tap2junit ibmi+#++- name: install tap2junit+  pip: name=tap2junit state=present+  executable: pip2

TASK [jenkins-worker : prepare installing tap2junit] ****************************************** fatal: [test-iinthecloud-ibmi72-ppc64_be-1]: FAILED! => {"reason": "'executable' is not a valid attribute for a Task\n\nThe error appears to have been in '/home/sam/w/core/build/ansible/roles /jenkins-worker/tasks/partials/tap2junit/ibmi.yml': line 7, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name : install tap2junit\n ^ here\n\nThis error can be suppressed as a warning using the "invalid_task_attribute_failed" configuration"}

thoughts?

ThePrez

comment created time in 13 days

push eventThePrez/build

Sam Roberts

commit sha dbbe18488eac31d70d16f22f4aea80e081fb6286

fixup! Add new IBM i system

view details

push time in 13 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

   command: systemctl restart iptables   when: "'rhel7-s390x' in inventory_hostname" +- name: Check if SU is installed on IBMi+  when: os|startswith("ibmi")+  stat:+    path: /QOpenSys/pkgs/bin/su+  register: su_exists++- name: git clone su on ibmi+  git:+    repo: https://github.com/ThePrez/IBMiOSS-utils.git+    dest: /tmp/IBMiOSS-utils+  when: su_exists.stat.exists == False and os|startswith("ibmi")++- name: copy su into /QOpenSys/pkgs/bin IBMi+  copy:+    src: /tmp/IBMiOSS-utils/su+    dest: /QOpenSys/pkgs/bin/su+    remote_src: true+  when: su_exists.stat.exists == False and os|startswith("ibmi")++- name: copy su-setup into /QOpenSys/pkgs/bin IBMi+  copy:+    src: /tmp/IBMiOSS-utils/su-setup+    dest: /QOpenSys/pkgs/bin/su-setup+    remote_src: true+  when: su_exists.stat.exists == False and os|startswith("ibmi")++- name: Check if SU is installed on IBMi+  when: os|startswith("ibmi")+  stat:+    path: /QOpenSys/pkgs/bin/su+  register: su_exists++# FIXME rewrite jenkins start to use ssh or SBMJOB, so su is not needed.

I think you have done this, so is su not needed anymore?

ThePrez

comment created time in 13 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

    - name: upgrade installed packages     yum: name=* state=latest+# XXX might have needed `use_backend=yum` at end of last line, but prob

we can remove this comment before landing

ThePrez

comment created time in 13 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

   command: systemctl restart iptables   when: "'rhel7-s390x' in inventory_hostname" +- name: Check if SU is installed on IBMi

still needed?

ThePrez

comment created time in 13 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

 packages: {     'bash,cmake,gcc-c++,gcc6-c++,tar,unzip,git,make,sudo',   ], +  # @jgorzins - this works, but @rvagg says doing it as a concatenated string

@ThePrez I'll make this change, once I get ansible to run (having ssh auth problems ATM)

ThePrez

comment created time in 13 days

Pull request review commentnodejs/build

Add IBM i initial playbooks

+---

this can be removed before landing, and I'll directly put the secrets in nodejs/secrets

ThePrez

comment created time in 13 days

pull request commentnodejs/build

Add IBM i initial playbooks

I rebased this, and force pushed @ThePrez 's branch, and saved the original at https://github.com/sam-github/build/tree/ibmi-orig for future reference.

ThePrez

comment created time in 13 days

push eventThePrez/build

Ash Cripps

commit sha 9df1fc4544dcfa8b17e4e5098836ac48cef9231d

Reprovision s390x machines (#2083) * ansible: update playbooks for new s390x machines * Remove symbolic link + turn devtoolset install to manual * ansible: Rename every reference of rhel72 -> rhel7

view details

Sam Roberts

commit sha c891903c0cd54678f8c101aee6701fab3e678952

ansible: manual AIX7.2 install instructions moved (#2107) They used to be part of the legacy AIX6.1 manualBootstrap.md. Since AIX7.2 is current, and runs from top-level ansible playbooks, move them to MANUAL_STEPS.md.

view details

Sam Roberts

commit sha 968c03313c8e952d709d79429a5ff77400cc91c5

ansible: aix6.1 ccache needs recreation on ramdisk (#2109)

view details

Ash Cripps

commit sha 48e99171cb768e4483a3d1afc5eca4345accf9b0

Enable jenkins testing on AIX71 (#2098)

view details

Ash Cripps

commit sha 2eb6db4c781cda8f7732a289a4408923dab1a033

ansible: add back the firewall rules for rhel7_s390x (#2104) * ansible: add back the firewall rules for rhel7_s390x * ansible: remove firewalld and install iptables on rhel-s390x

view details

Sam Roberts

commit sha cec3bc55c7029961fe11789d4d9c5d5e51842611

Proposal to add AshCripps as member of build-wg (#2101) He is employed full-time by IBM in my team to work on Node.js community build infrastructure, and I am mentoring him. He has setup and has ongoing "special access" to maintain build machines: - https://github.com/nodejs/build/issues/2054 - https://github.com/nodejs/build/issues/2081 - https://github.com/nodejs/build/issues/1695 He doesn't have the ability to run CI jobs much less configure CI jobs, so he can't complete the rhel7-s390x or aix7.1-ppc64 setup or nearform macmini setup, I have to run all the jobs for him. Criteria: https://github.com/nodejs/build/blob/master/doc/access.md#build-working-group-membership History: - Continous involvement in build-wg since joining our team - nodejs/build PRs: 10 close, 2 open: https://github.com/nodejs/build/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3AAshCripps+ - nodejs/node PRs: 3 closed: https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3AAshCripps+ - ansibilization of 3 systems to prep them for joining to CI (aix, rhel, and os x)

view details

Ash Cripps

commit sha 552c2c1627e7c1933721064ae31df183b0929950

jenkins: use AIX7.1 for 13.x and 14.x (#2111) 13.x still releases on 6.1, 14.x only releases on 7.1. Testing for 13.x is on 7.1 and 6.1

view details

Ash Cripps

commit sha a40f504006d0f8be133a82fd4020c8dd2125bcb0

jenkins: add gt operator to VersionSelectorScript (#2113) Fix: https://github.com/nodejs/build/pull/2111

view details

Ash Cripps

commit sha e40375f84353a42be4491743841f7d2c2e578e35

ansible: rhel: add gconf2-devel package to ansible scripts (#2114) This installed a dependency needed by V8 refs: https://github.com/nodejs/build/issues/2080#issuecomment-569428811

view details

Sam Roberts

commit sha 1bbcd2cb2cece64287b47d8448556d6d73547664

ansible: rhel7-s390x manual ninja/v8 build step Needed for V8 jobs. Description is incomplete wrt. how to build them initially, but better than the previous state of no docs at all.

view details

Sam Roberts

commit sha 1dd97fa746c3a22a5a09ee8990aff8ed14862091

jenkins: rename sections to "OS + ARCH" (#2118) *NO* changes made to actual exclusion lines, just reordered, and comment cleanups. Some of the names ("s390x") didn't have the OS, it was just implied by the architecture (to those in the know), and some used a specific distro as the OS name, but the platform support is wider than just what distro we build on.

view details

João Reis

commit sha 31c0cbca33bae52366246de0f301ba5f5dcd0c80

jenkins: add Windows to VersionSelectorScript PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 360cd75ac87cbb3d45d3cb7eea232c9d2787b86d

jenkins: add Windows scripts PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha fee9565ed771ae99e87689d9012197e496d163c0

ansible,win: disable SSLv2 and SSLv3 Following Azure security recommendations. PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 5967f5805cd03d2a971724242a82b1cdb8a24b41

ansible,win: don't install MFC and XP compat PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha ea9a1399952b7de7b775a8ab01139f17137927a3

ansible,win: add VS2019 support PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha a98e05e91c0fe2b7764e3d8c0d0549ace21e57cb

ansible,win: add clcache Specific commit and floating PRs known to work. PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 7c3aa84f03b0bc824a6d85d3ec93faaa14103e0f

ansible,win: add Python 3 PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 5e270bebac1f1f78329857be0a24cc1163ad6320

ansible,win: add CMake Refs: https://github.com/nodejs/build/issues/2097 PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

João Reis

commit sha 4b5c48fef79ff1ae4c9b9781385426e5d7360680

ansible,win: add update-windows playbook PR-URL: https://github.com/nodejs/build/pull/2099 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com>

view details

push time in 13 days

create barnchsam-github/build

branch : ibmi-orig

created branch time in 13 days

issue commentnodejs/help

[RESOLVED] Lost/missing data on Unix Domain Socket

@jessereitsma Use strace, you can see the network calls made by the process, should allow you to find where its dropped. https://gist.github.com/jhass/5896418 might help as well.

ForeverACE

comment created time in 14 days

more