profile
viewpoint
Sam Roberts sam-github IBM Canada Vancouver, BC, Canada https://sam-github.github.io/

libnet/libnet 534

A portable framework for low-level network packet construction

RuntimeTools/appmetrics-dash 294

A data visualizer that uses " Node Application Metrics" (appmetrics) to monitor and display Node.js application data as a html web application.

ibmruntimes/yieldable-json 68

Asynchronous JSON parser and stringify APIs that make use of generator patterns

nodejs/webcrypto 48

Implementation of WebCrypto API as an npm package

kjdelisle/dist-tagger 1

A tool for not wasting time manually typing out dist-tag commands.

sam-github/appmetrics-dash 1

A data visualizer that uses " Node Application Metrics" (appmetrics) to monitor and display Node.js application data as a html web application.

sam-github/bcrc-lua 1

lua binding to boost/crc, a generic CRC library

libnet/libnet-lua 0

lua bindings for libnet

miqmago/reuse-session-node 0

See issue in node repo

sam-github/admin 0

Facilitating joint collaboration amongst the TSC and CommComm

pull request commentsiimon/prom-client

Update README to reflect more v12 changes

I wasn't thinking that registerCollector() would be used outside of the defaults, its a somewhat unfortunate interface (a version that supports callbacks would be better, but since .metrics() doesn't take a callback, that's not an option ATM), but it is what it is, and if prom-client wants to expose it I guess its at least simple and should be easy to keep stable.

zbjornson

comment created time in a day

issue commentnodejs/build

ci,libuv,zos: switch from gyp cmake

cmake on zos is a thing, @bnoordhuis you should be able to repeat the below using the test ssh key. libuv cmake may need to be taught about xlc. Where it says "Enter the password for iojs: " just hit ENTER. If you need to use git, always use /u/iojs/git-wrapper (or risk it overwriting .git/config with garbage).

% ssh test-marist-zos13-s390x-1
UNIX1:/u/unix1: >su - iojs
FSUM5019 Enter the password for iojs: 
IOJS:/u/iojs: >bash
IOJS:/u/iojs: >cd tmp/libuv
IOJS:/u/iojs/tmp/libuv: >../../miladfar/bin/Cmake/bin/cmake -DCMAKE_C_COMPILER=xlc .
-- The C compiler identification is zOS
-- Check for working C compiler: /bin/xlc
-- Check for working C compiler: /bin/xlc -- broken
CMake Error at /u/iojs/miladfar/bin/Cmake/share/cmake-3.5/Modules/CMakeTestCCompiler.cmake:61 (message):
  The C compiler "/bin/xlc" is not able to compile a simple test program.

  It fails with the following output:

   Change Dir: /u/iojs/tmp/libuv/CMakeFiles/CMakeTmp

  

  Run Build Command:"/bin/make" "cmTC_6a589/fast"

  make -f CMakeFiles/cmTC_6a589.dir/build.make
  CMakeFiles/cmTC_6a589.dir/build

  Building C object CMakeFiles/cmTC_6a589.dir/testCCompiler.c.o

  /bin/xlc -o CMakeFiles/cmTC_6a589.dir/testCCompiler.c.o -c
  /u/iojs/tmp/libuv/CMakeFiles/CMakeTmp/testCCompiler.c

  Linking C executable cmTC_6a589

  /u/iojs/miladfar/bin/Cmake/bin/cmake -E cmake_link_script
  CMakeFiles/cmTC_6a589.dir/link.txt --verbose=1

  /bin/xlc CMakeFiles/cmTC_6a589.dir/testCCompiler.c.o -o cmTC_6a589

  FSUM3008 Specify a file with the correct suffix (.c, .i, .s, .o, .x, .p,
  .I, or .a), or a corresponding data set name, instead of -o./cmTC_6a589.

  FSUM8226 make: Error code 1

  FSUM8226 make: Error code 255

  

  

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:3 (project)


-- Configuring incomplete, errors occurred!
See also "/u/iojs/tmp/libuv/CMakeFiles/CMakeOutput.log".
See also "/u/iojs/tmp/libuv/CMakeFiles/CMakeError.log".
IOJS:/u/iojs/tmp/libuv: >
bnoordhuis

comment created time in a day

issue commentnodejs/node

possible libuv issue with macos 10.15: empty udp message not registering

IMO, I suggest our tests should be reworked to not require platforms support zero-length UDP datagrams, and instead check they either work, or not throw js/c++ errors because our code is broken.

For platforms that do support them, its nice that node and libuv do, as well, but its not exactly a critical feature. I'm not aware of any actual uses for zero-length UDP other than port-knocking during network intrusion or crashing unsuspecting UDP listeners, who insufficiently validate the received packet sizes.

Making the tests auto-detect what is happening, and pass whether or not the packets are received seems like a long-term robust solution, and will get OS X 10.15 out of perma-yellow.

Thoughts?

cc: @AshCripps

daviehh

comment created time in a day

issue commentkabanero-io/collections

incubator/nodejs fails to build under buildah

No luck, I'm just familiar enough with buildah.

I suspect that your build container somehow managed to get a corrupted ubi node container or image, specifically, the /usr/lib/node_modules/npm contains pieces of an older version of node-gyp which is overriding the one it should find, its almost like the :12 container is overlayed on top of the :10 container. Is it possible that happened?

I say that because, on linux+docker, I see that ubi8/nodejs-10 has a 2.2.1 version of tar at /usr/lib/node_modules/npm/node_modules/node-gyp/node_modules/tar, where ubi8/nodejs-12 does not have that (when I run from docker on linux), but it does have that package there when ubi8/nodejs12 is run with buildah, inside your docker.io/appsody/appsody-buildah:0.5.8-buildah1.9.0

This also explains your fix... npm install overwrites the global npm with a fresh install, removing the previous. As a pretty ugly workaround, you could add a npm install -g npm@6.12.1, that is the version that is expected on the container. I think it will overwrite with a functional npm.

jgawor

comment created time in a day

issue commentkabanero-io/collections

incubator/nodejs fails to build under buildah

On host:

% docker run -it --user root registry.access.redhat.com/ubi8/nodejs-12:1-27 find /usr/lib -name tar
/usr/lib/node_modules/npm/node_modules/tar

Inside docker.io/appsody/appsody-buildah:0.5.8-buildah1.9.0

buildah from --name n12 registry.access.redhat.com/ubi8/nodejs-12:1-27
buildah run -t n12 sh -c find /usr/lib -name tar
/usr/lib/node_modules/npm/node_modules/node-gyp/node_modules/tar
/usr/lib/node_modules/npm/node_modules/tar

The node-gyp/node_modules/tar is invalid, it is 2.2.1, instead of 4.x.

Still troubleshooting why it is like that.

jgawor

comment created time in a day

pull request commentappsody/stacks

Run nodejs stack as node user rather than root

Talked to @skoh7645 , it sounds like #624 is the approach that will be taken with all 3.

Kamran64

comment created time in a day

Pull request review commentappsody/stacks

node-red: Run stack as non root

 FROM node:12+  +RUN useradd -m node_user && groupadd node_group

how do I reproduce the problem that led to this being the solution?

Kamran64

comment created time in a day

pull request commentappsody/stacks

Run nodejs stack as node user rather than root

Needs to be synced with the other PRs: #589 #604 #624

Kamran64

comment created time in a day

pull request commentappsody/stacks

nodejs-express: run as node user rather than root

Needs to be synced with the other PRs: #589 #604 #624

Kamran64

comment created time in a day

pull request commentappsody/stacks

node-red: Run stack as non root

Needs to be synced with the other PRs: #589 #604 #624

Kamran64

comment created time in a day

issue commentkabanero-io/collections

incubator/nodejs fails to build under buildah

Ok, but @groeges , if the npm that is packaged in ubi/node:12 doesn't work, that's a problem with the upstream image that needs reporting.

I'll try to find time today to repro this.

Anyone know where UBI bugs are reported to?

jgawor

comment created time in a day

issue commentnodejs/node

CI is unusable

@gireeshpunathil I would suggest not going through build failures in node-test-pull-request, failures are expected on PRs (code fails), so its hard to detangle expected vs unexpected failures.

I suggest you look at https://ci.nodejs.org/job/node-daily-master/ -- those builds all come from master, therefore every failure there is either a failure in infrastructure, or a flaky test.

https://github.com/nodejs/node-core-utils/pull/379 can be helpful in analysis.

<details><summary>output</summary>

core/node-core-utils (add-daily-master $% u=) % ./bin/ncu-ci daily
✔  Done
--------------------------------------------------------------------------------
[1/8] Running health
--------------------------------------------------------------------------------
| UTC Time         | RUNNING | SUCCESS | UNSTABLE | ABORTED | FAILURE | Green Rate |
| ---------------- | ------- | ------- | -------- | ------- | ------- | ---------- |
| 2020-02-26 15:02 | 0       | 1       | 4        | 0       | 7       | 8.33%      |

--------------------------------------------------------------------------------
[2/8] Running https://ci.nodejs.org/job/node-daily-master/1847/
--------------------------------------------------------------------------------
✔  Build data downloaded
✔  Build data downloaded
✔  Data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/node-test-commit/35963/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/master
Commit     [940325042bef] test: add secp224k1 check in crypto-dh-stateless
Date       2020-02-25 06:14:32 +0100
Author     Daniel Bevenius <daniel.bevenius@gmail.com>
------------------------ RUN_SUBSET=0,label=pi2-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=0,label=pi2-docker/4539/console
Type       JS_TEST_FAILURE
Built On   test-requireio_joeyvandijk-debian10-armv7l_pi2-1
Reason
  not ok 650 known_issues/test-vm-timeout-escape-queuemicrotask
    ---
    duration_ms: 1.243
    severity: fail
    stack: |-
    ...

------------------------ RUN_SUBSET=0,label=pi3-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=0,label=pi3-docker/4539/console
Type       JS_TEST_FAILURE
Built On   test-requireio_securogroup-debian10-arm64_pi3-2
Reason
  not ok 660 parallel/test-worker-stdio
    ---
    duration_ms: 251.448
    severity: fail
    exitcode: -15
    stack: |-
      timeout
    ...

--------------------------------- Other builds ---------------------------------
--------------------------------------------------------------------------------
[3/8] Running https://ci.nodejs.org/job/node-daily-master/1846/
--------------------------------------------------------------------------------
✔  Build data downloaded
✔  Build data downloaded
----------------------------------- Summary ------------------------------------
Result     UNSTABLE
URL        https://ci.nodejs.org/job/node-test-commit/35927/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/master
Commit     [9c702922cdcf] async_hooks: introduce async-context API
Date       2020-02-23 20:24:02 +0100
Author     Vladimir de Turckheim <vlad2t@hotmail.com>
--------------------------------- Other builds ---------------------------------
Unstable   https://ci.nodejs.org/job/node-test-commit-arm-fanned/13338/
--------------------------------------------------------------------------------
[4/8] Running https://ci.nodejs.org/job/node-daily-master/1844/
--------------------------------------------------------------------------------
✔  Build data downloaded
✔  Build data downloaded
✔  Data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/node-test-commit/35887/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/master
Commit     [2f23918ca509] doc: update stream.pipeline() signature
Date       2020-02-22 08:18:43 +0100
Author     Luigi Pinca <luigipinca@gmail.com>
------------------------------- node-test-linter -------------------------------
URL        https://ci.nodejs.org/job/node-test-linter/32923/console
Type       BUILD_FAILURE
Built On   test-packetnet-ubuntu1604-x64-1
Reason
  Error: No module named enum
  Makefile:1347: recipe for target 'lint-py' failed
  make: *** [lint-py] Error 1
  + cat test-eslint.tap
  + grep -v '^ok\|^TAP version 13\|^1\.\.'
  + sed '/^\s*$/d'
--------------------------------- Other builds ---------------------------------
Unstable   https://ci.nodejs.org/job/node-test-commit-arm-fanned/13298/
--------------------------------------------------------------------------------
[5/8] Running https://ci.nodejs.org/job/node-daily-master/1841/
--------------------------------------------------------------------------------
✔  Build data downloaded
✔  Build data downloaded
----------------------------------- Summary ------------------------------------
Result     UNSTABLE
URL        https://ci.nodejs.org/job/node-test-commit/35839/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/master
Commit     [b8e41774d428] fs: add fs/promises alias module
Date       2020-02-18 22:15:50 -0800
Author     Gus Caplan <me@gus.host>
--------------------------------- Other builds ---------------------------------
Unstable   https://ci.nodejs.org/job/node-test-commit-arm-fanned/13255/
--------------------------------------------------------------------------------
[6/8] Running https://ci.nodejs.org/job/node-daily-master/1839/
--------------------------------------------------------------------------------
✔  Build data downloaded
✔  Build data downloaded
✔  Data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/node-test-commit/35767/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/master
Commit     [4c746a6cfda9] doc: move gireeshpunathil to TSC emeritus
Date       2020-02-17 10:33:54 +0530
Author     Gireesh Punathil <gpunathi@in.ibm.com>
--------------- RUN_SUBSET=1,nodes=win2008r2-COMPILED_BY-vs2017 ----------------
URL        https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=1,nodes=win2008r2-COMPILED_BY-vs2017/1820/console
Type       JENKINS_FAILURE
Built On   test-rackspace-win2008r2_vs2017-x64-3
Reason
  Build timed out (after 10 minutes). Marking the build as failed.
------------------------------ centos7-arm64-gcc6 ------------------------------
URL        https://ci.nodejs.org/job/node-test-commit-arm/nodes=centos7-arm64-gcc6/29460/console
Type       JS_TEST_FAILURE
Built On   test-packetnet-centos7-arm64-2
Reason
  not ok 2899 sequential/test-worker-prof
    ---
    duration_ms: 0.814
    severity: fail
    exitcode: 1
    stack: |-
      assert.js:102
        throw new AssertionError(obj);
        ^

      AssertionError [ERR_ASSERTION]: child exited with signal: {
        status: null,
        signal: 'SIGSEGV',
        output: [ null, '', '' ],
        pid: 98106,
        stdout: '',
        stderr: ''
      }
          at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/nodes/centos7-arm64-gcc6/test/sequential/test-worker-prof.js:57:10)
          at Module._compile (internal/modules/cjs/loader.js:1206:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:1226:10)
          at Module.load (internal/modules/cjs/loader.js:1055:32)
          at Function.Module._load (internal/modules/cjs/loader.js:950:14)
          at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
          at internal/main/run_main_module.js:17:47 {
        generatedMessage: false,
        code: 'ERR_ASSERTION',
        actual: 'SIGSEGV',
        expected: null,
        operator: 'strictEqual'
      }
    ...

------------------------ RUN_SUBSET=1,label=pi3-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=1,label=pi3-docker/4399/console
Type       GIT_FAILURE
Built On   test-requireio_notthetup_sayanee-debian10-arm64_pi3-1
Reason
  warning: failed to remove out/Release/.nfs00000000005a46070000098f: Device or resource busy
------------------------ RUN_SUBSET=3,label=pi3-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=3,label=pi3-docker/4399/console
Type       GIT_FAILURE
Built On   test-requireio_notthetup_sayanee-debian10-arm64_pi3-1
Reason
  warning: failed to remove out/Release/.nfs00000000005a46070000098f: Device or resource busy
--------------------------------- Other builds ---------------------------------
--------------------------------------------------------------------------------
[7/8] Running https://ci.nodejs.org/job/node-daily-master/1838/
--------------------------------------------------------------------------------
✔  Build data downloaded
✔  Build data downloaded
✔  Data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/node-test-commit/35752/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/master
Commit     [a7c523e26df4] src: prefer 3-argument Array::New()
Date       2020-02-15 21:39:32 +0100
Author     Anna Henningsen <anna@addaleax.net>
------------------------------ centos7-arm64-gcc6 ------------------------------
URL        https://ci.nodejs.org/job/node-test-commit-arm/nodes=centos7-arm64-gcc6/29448/console
Type       JS_TEST_FAILURE
Built On   test-packetnet-centos7-arm64-2
Reason
  not ok 2897 sequential/test-worker-prof
    ---
    duration_ms: 1.716
    severity: fail
    exitcode: 1
    stack: |-
      assert.js:102
        throw new AssertionError(obj);
        ^

      AssertionError [ERR_ASSERTION]: child exited with signal: {
        status: null,
        signal: 'SIGSEGV',
        output: [ null, '', '' ],
        pid: 91489,
        stdout: '',
        stderr: ''
      }
          at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/nodes/centos7-arm64-gcc6/test/sequential/test-worker-prof.js:57:10)
          at Module._compile (internal/modules/cjs/loader.js:1206:30)
          at Object.Module._extensions..js (internal/modules/cjs/loader.js:1226:10)
          at Module.load (internal/modules/cjs/loader.js:1055:32)
          at Function.Module._load (internal/modules/cjs/loader.js:950:14)
          at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
          at internal/main/run_main_module.js:17:47 {
        generatedMessage: false,
        code: 'ERR_ASSERTION',
        actual: 'SIGSEGV',
        expected: null,
        operator: 'strictEqual'
      }
    ...

------------------------ RUN_SUBSET=1,label=pi2-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=1,label=pi2-docker/4387/console
Type       JENKINS_FAILURE
Built On   test-requireio_louiscntr-debian10-armv7l_pi2-1
Reason
  java.io.IOException: Backing channel 'JNLP4-connect connection from 203.217.18.114/203.217.18.114:56254' is disconnected.
        at hudson.remoting.RemoteInvocationHandler.channelOrFail(RemoteInvocationHandler.java:214)
        at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:283)
        at com.sun.proxy.$Proxy90.isAlive(Unknown Source)
        at hudson.Launcher$RemoteLauncher$ProcImpl.isAlive(Launcher.java:1150)
        at hudson.Launcher$RemoteLauncher$ProcImpl.join(Launcher.java:1142)
------------------------ RUN_SUBSET=1,label=pi3-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=1,label=pi3-docker/4387/console
Type       GIT_FAILURE
Built On   test-requireio_notthetup_sayanee-debian10-arm64_pi3-1
Reason
  warning: failed to remove out/Release/.nfs00000000005a46070000098f: Device or resource busy
------------------------ RUN_SUBSET=3,label=pi3-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=3,label=pi3-docker/4387/console
Type       GIT_FAILURE
Built On   test-requireio_notthetup_sayanee-debian10-arm64_pi3-1
Reason
  warning: failed to remove out/Release/.nfs00000000005a46070000098f: Device or resource busy
--------------------------------- Other builds ---------------------------------
Unstable   https://ci.nodejs.org/job/node-test-commit-windows-fanned/33992/
--------------------------------------------------------------------------------
[8/8] Running https://ci.nodejs.org/job/node-daily-master/1837/
--------------------------------------------------------------------------------
✔  Build data downloaded
✔  Build data downloaded
✔  Data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/node-test-commit/35734/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/master
Commit     [79296dc2d02c] doc: guide - using valgrind to debug memory leaks
Date       2020-02-14 18:19:16 -0500
Author     Michael Dawson <michael_dawson@ca.ibm.com>
------------------------ RUN_SUBSET=0,label=pi2-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=0,label=pi2-docker/4370/console
Type       GIT_FAILURE
Built On   test-requireio_rvagg-debian10-armv7l_pi2-1
Reason
  warning: failed to remove out/Release/.nfs0000000000763f2b000012bc: Device or resource busy
------------------------ RUN_SUBSET=0,label=pi3-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=0,label=pi3-docker/4370/console
Type       GIT_FAILURE
Built On   test-requireio_williamkapke-debian10-arm64_pi3-1
Reason
  warning: failed to remove out/Release/.nfs00000000002caa3800000faf: Device or resource busy
------------------------ RUN_SUBSET=1,label=pi2-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=1,label=pi2-docker/4370/console
Type       GIT_FAILURE
Built On   test-requireio_joeyvandijk-debian10-armv7l_pi2-2
Reason
  warning: failed to remove out/Release/.nfs00000000007c439200001175: Device or resource busy
------------------------ RUN_SUBSET=1,label=pi3-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=1,label=pi3-docker/4370/console
Type       GIT_FAILURE
Built On   test-requireio_notthetup_sayanee-debian10-arm64_pi3-1
Reason
  warning: failed to remove out/Release/.nfs00000000005a46070000098f: Device or resource busy
------------------------ RUN_SUBSET=2,label=pi2-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=2,label=pi2-docker/4370/console
Type       GIT_FAILURE
Built On   test-requireio_joeyvandijk-debian10-armv7l_pi2-1
Reason
  warning: failed to remove out/Release/.nfs00000000007c5ad000001385: Device or resource busy
------------------------ RUN_SUBSET=2,label=pi3-docker -------------------------
URL        https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=2,label=pi3-docker/4370/console
Type       GIT_FAILURE
Built On   test-requireio_pivotalagency-debian10-arm64_pi3-1
Reason
  warning: failed to remove out/Release/.nfs00000000005e146e000009f6: Device or resource busy
--------------------------------- Other builds ---------------------------------
Unstable   https://ci.nodejs.org/job/node-test-commit-windows-fanned/33978/

------------------------------------ Stats -------------------------------------

------------------------------- JENKINS_FAILURE --------------------------------
Reason     Backing channel 'JNLP4-connect connection from ... is disconnected.
Type       JENKINS_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-requireio_louiscntr-debian10-armv7l_pi2-1
Last CI    https://ci.nodejs.org/job/node-test-commit/35752/

Example: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=1,label=pi2-docker/4387/console

java.io.IOException: Backing channel 'JNLP4-connect connection from 203.217.18.114/203.217.18.114:56254' is disconnected.
        at hudson.remoting.RemoteInvocationHandler.channelOrFail(RemoteInvocationHandler.java:214)
        at hudson.remoting.RemoteInvocationHandler.invoke(RemoteInvocationHandler.java:283)
        at com.sun.proxy.$Proxy90.isAlive(Unknown Source)
        at hudson.Launcher$RemoteLauncher$ProcImpl.isAlive(Launcher.java:1150)
        at hudson.Launcher$RemoteLauncher$ProcImpl.join(Launcher.java:1142)
--------------------------------------------------------------------------------
Reason     Build timed out (after 10 minutes). Marking the build as failed.
Type       JENKINS_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-rackspace-win2008r2_vs2017-x64-3
Last CI    https://ci.nodejs.org/job/node-test-commit/35767/

Example: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/RUN_SUBSET=1,nodes=win2008r2-COMPILED_BY-vs2017/1820/console

Build timed out (after 10 minutes). Marking the build as failed.
--------------------------------------------------------------------------------
-------------------------------- BUILD_FAILURE ---------------------------------
Reason     Error: No module named enum
Type       BUILD_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-packetnet-ubuntu1604-x64-1
Last CI    https://ci.nodejs.org/job/node-test-commit/35887/

Example: https://ci.nodejs.org/job/node-test-linter/32923/console

Error: No module named enum
Makefile:1347: recipe for target 'lint-py' failed
make: *** [lint-py] Error 1
+ cat test-eslint.tap
+ grep -v '^ok\|^TAP version 13\|^1\.\.'
+ sed '/^\s*$/d'
--------------------------------------------------------------------------------
------------------------------- JS_TEST_FAILURE --------------------------------
Reason     known_issues/test-vm-timeout-escape-queuemicrotask
Type       JS_TEST_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-requireio_joeyvandijk-debian10-armv7l_pi2-1
Last CI    https://ci.nodejs.org/job/node-test-commit/35963/

Example: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=0,label=pi2-docker/4539/console

not ok 650 known_issues/test-vm-timeout-escape-queuemicrotask
  ---
  duration_ms: 1.243
  severity: fail
  stack: |-
  ...

--------------------------------------------------------------------------------
Reason     parallel/test-worker-stdio
Type       JS_TEST_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-requireio_securogroup-debian10-arm64_pi3-2
Last CI    https://ci.nodejs.org/job/node-test-commit/35963/

Example: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=0,label=pi3-docker/4539/console

not ok 660 parallel/test-worker-stdio
  ---
  duration_ms: 251.448
  severity: fail
  exitcode: -15
  stack: |-
    timeout
  ...

--------------------------------------------------------------------------------
Reason     sequential/test-worker-prof
Type       JS_TEST_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-packetnet-centos7-arm64-2
Last CI    https://ci.nodejs.org/job/node-test-commit/35767/

Example: https://ci.nodejs.org/job/node-test-commit-arm/nodes=centos7-arm64-gcc6/29460/console

not ok 2899 sequential/test-worker-prof
  ---
  duration_ms: 0.814
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:102
      throw new AssertionError(obj);
      ^

    AssertionError [ERR_ASSERTION]: child exited with signal: {
      status: null,
      signal: 'SIGSEGV',
      output: [ null, '', '' ],
      pid: 98106,
      stdout: '',
      stderr: ''
    }
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/nodes/centos7-arm64-gcc6/test/sequential/test-worker-pr...
--------------------------------------------------------------------------------
--------------------------------- GIT_FAILURE ----------------------------------
Reason     warning: failed to remove out/Release/.nfs00000000002caa3800000faf: Device or resource busy
Type       GIT_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-requireio_williamkapke-debian10-arm64_pi3-1
Last CI    https://ci.nodejs.org/job/node-test-commit/35734/

Example: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=0,label=pi3-docker/4370/console

warning: failed to remove out/Release/.nfs00000000002caa3800000faf: Device or resource busy
--------------------------------------------------------------------------------
Reason     warning: failed to remove out/Release/.nfs00000000005a46070000098f: Device or resource busy
Type       GIT_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-requireio_notthetup_sayanee-debian10-arm64_pi3-1
Last CI    https://ci.nodejs.org/job/node-test-commit/35767/

Example: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=1,label=pi3-docker/4399/console

warning: failed to remove out/Release/.nfs00000000005a46070000098f: Device or resource busy
--------------------------------------------------------------------------------
Reason     warning: failed to remove out/Release/.nfs00000000005e146e000009f6: Device or resource busy
Type       GIT_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-requireio_pivotalagency-debian10-arm64_pi3-1
Last CI    https://ci.nodejs.org/job/node-test-commit/35734/

Example: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=2,label=pi3-docker/4370/console

warning: failed to remove out/Release/.nfs00000000005e146e000009f6: Device or resource busy
--------------------------------------------------------------------------------
Reason     warning: failed to remove out/Release/.nfs0000000000763f2b000012bc: Device or resource busy
Type       GIT_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-requireio_rvagg-debian10-armv7l_pi2-1
Last CI    https://ci.nodejs.org/job/node-test-commit/35734/

Example: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=0,label=pi2-docker/4370/console

warning: failed to remove out/Release/.nfs0000000000763f2b000012bc: Device or resource busy
--------------------------------------------------------------------------------
Reason     warning: failed to remove out/Release/.nfs00000000007c439200001175: Device or resource busy
Type       GIT_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-requireio_joeyvandijk-debian10-armv7l_pi2-2
Last CI    https://ci.nodejs.org/job/node-test-commit/35734/

Example: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=1,label=pi2-docker/4370/console

warning: failed to remove out/Release/.nfs00000000007c439200001175: Device or resource busy
--------------------------------------------------------------------------------
Reason     warning: failed to remove out/Release/.nfs00000000007c5ad000001385: Device or resource busy
Type       GIT_FAILURE
Failed PR  1 (https://api.github.com/repos/nodejs/node/git/refs/heads/master)
Appeared   test-requireio_joeyvandijk-debian10-armv7l_pi2-1
Last CI    https://ci.nodejs.org/job/node-test-commit/35734/

Example: https://ci.nodejs.org/job/node-test-binary-arm-12+/RUN_SUBSET=2,label=pi2-docker/4370/console

warning: failed to remove out/Release/.nfs00000000007c5ad000001385: Device or resource busy
--------------------------------------------------------------------------------
core/node-core-utils (add-daily-master $% u=) %

</details>

tniessen

comment created time in a day

push eventnodejs/node

Sam Roberts

commit sha 24a4f76709bd9edc8d86e9f3fb4d5e3c7d4c3d69

test: mark empty udp tests flaky on OS X They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: https://github.com/nodejs/node/issues/30030 Refs: https://github.com/nodejs/build/pull/2189#issuecomment-589767606 PR-URL: https://github.com/nodejs/node/pull/31936 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

view details

push time in a day

PR closed nodejs/node

test: mark empty udp tests flaky on OS X CI / flaky test fast-track lts-watch-v10.x lts-watch-v12.x test

They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: https://github.com/nodejs/node/issues/30030 Refs: https://github.com/nodejs/build/pull/2189#issuecomment-589767606

Note: CI doesn't test on Catalina, yet (though I assume nodejs developers do). Test failures will indirectly block fixing of https://github.com/nodejs/node/issues/29216, which requires running notarization on Catalina, which requires tests passing on Catalina.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+7 -0

11 comments

1 changed file

sam-github

pr closed time in a day

pull request commentnodejs/node

test: mark empty udp tests flaky on OS X

Landed in 24a4f76709bd

sam-github

comment created time in a day

issue commentkabanero-io/collections

incubator/nodejs fails to build under buildah

Running on Linux, I installed 0.5.8 of appsody, checked this repo out, cded to incubator/nodejs, ran appsody stack package, it completed sucessfully.

Any reproduction hints?

cc: @groeges

jgawor

comment created time in 2 days

pull request commentnodejs/build

[WIP] ansible: add 10.15 macs

@AshCripps you are already a https://github.com/nodejs/build#jenkins-admins, so, the thing to do now is to create a node-test-commit-osx-ashcripps job by cloning the base job. Once you have the clone, go to the machine selection part, and find the osx1015 label that the 3 new test machines have, and click it. At that point, you should be able trigger a run of the job against nodejs/master from the Jenkins UI, and see that they fail on the tests that are skipped by https://github.com/nodejs/node/pull/31936, or you could even test my specific branch from that PR, if you want, to confirm the build is green. Then, once we can see the build is green in your cloned job, we are good to select the osx1015 machines to add them to CI in the regular node-test-commit-osx... and the test side of this is done.

After that, its mop-up: adding the label to the release builds, the v8 builds, citgm.... etc.

AshCripps

comment created time in 2 days

pull request commentnodejs/build

[WIP] ansible: add 10.15 macs

@AshCripps no, I can't try, only these people have the private key that goes with that public one :-)

I'll open an issue to get you enough access to do add the machines to test CI.

AshCripps

comment created time in 2 days

pull request commentnodejs/build

[WIP] ansible: add 10.15 macs

@AshCripps the machine is in ci-release and is connected: https://ci-release.nodejs.org/computer/release-nearform-macos10.15-x64-1/ (for those with visibility).

I had trouble getting in by ssh, but could you add the release team ssh key to .ssh/authorized_keys?

ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDFCAmx+ldk/UyR0x0xrsvdORi59uGPdErcitIjjBZRFnE87MGIZtmsZIqGogxgEc1A1t86/eCCvL7we31iE0sF71Stx17ZxTKuo/VCTACeg1GRd3/wdVHXphAss5sBYyV/T7hcGq7aq4PsrloAUhLfmivXAG0ALhWG3AAv4AnVWaa372XWIoYqiDQCL5uEClEP/A95CdqRrbYY4bWZRR0eZMgWhX5Npy1tThuA+p0+mmvY6AGHpTW33+d8qfGwubv1tPvV7G+vQ2cjlQTWd+NfnmzoOGUIcXGZ8yhfdXwFeNdduyIalL1Jm2WxbyStQ2SFXIFgSK+tjVEMGC4H+N8oOd2jbZYANxkCDugbaP3OSYwOYyUGnMJztt1g8oemGN9QtY7GGssuOxeUrYXGAYpD7BEqX7Jh2v5zd7Uvl7W60oYwikTtJkIEclEKOE2dEhHwDrZbt3KhF+VSjhaZdfrt+fMm3qQMGPdx16lT/IxHUm825A6Nzbmtm0H8yczXGnhG59w3bGAcUxD7OqZPmQaQnw1Abba0BBbsjj28KdkUddm91DjRzJCnXtJ6DLJxxn40MISE/loy/yvCLb3HCvhgo55hB4C0XCeMfbVYGwbx3TrX1en89aZ96s9EAMATZk4S+47cnx3jfy/5CP6ms4UsvGCelMPhgdqGBG/xOr7kKw== release@build.nodejs.org

^--- check for inadvertent cut-n-paste line breaks! should be one line. That's the public key, it has no sec significance, but once its there any release team member can ssh in (I assume, not a member myself).

At that point, I think @rvagg could dry-run notarization.

AshCripps

comment created time in 2 days

Pull request review commentappsody/stacks

nodejs - Optimize copy for buildah

 RUN apt-get update \  && apt-get clean \  && echo 'Finished installing dependencies' +# Copying individual files/folders as buildah 1.9.0 does not honour .dockerignore+COPY --chown=node:node package*.json /project/

These package files don't seem to be used (there is no WORKDIR /project; RUN npm install). The old code used to do COPY --chown=node:node . /project, so it would be copying COPY package.* node_modules /project, but that doesn't seem to be replaced. Perhaps that happens elsewhere? Sorry, I only have a general sense of how appsody uses this file.

neeraj-laad

comment created time in 2 days

pull request commentnodejs/node

test: mark empty udp tests flaky on OS X

Btw, the build status reported is incorrect - PR passed on everything but arm, as would be expected. I kicked a resume on the PR, though.

sam-github

comment created time in 2 days

pull request commentnodejs/node

test: mark empty udp tests flaky on OS X

@nodejs/build @nodejs/testing Can we fast-track marking these tests flaky?

sam-github

comment created time in 2 days

pull request commentappsody/stacks

Run nodejs stack as node user rather than root

@skoh7645

As stack maintainer, would you prefer this PR goes in as is

I don't have strong opinions, as long as it runs (which it doesn't now, not for me).

(with the warning that you cannot access this log file - might be cleaner than using the host's ID in the container and pointing files to different directories),

Not sure what you mean by "pointing files to different directories"

or if you test adding those changes and it works, would you prefer to include it in the PR?

"those changes" ... those refers to #624?

"include it in the PR" ... it is what?

@neeraj-laad

As a general rule, I prefer to avoid using APPSODY_RUN_AS_LOCAL as much as possible as that is just an indication that we are writing to user's filesystem from within the container and that is not a great idea.

For production, that would be a terrible idea, but appsody is trying to build a local dev experience with files being edited live on the host, and the app and unit tests running in a container, with the host FS mapped into the container...

Its not unreasonable for an app to write to FS, particularly in a "dev mode". Templates might get recompiled on the fly, unit tests will certainly write to FS in all kinds of configurations, such as when collecting coverage information, or creating text fixtures.

This doesn't strike me as a Node.js specific issue, that would be true of most/all runtimes, wouldn't it?

For example, with this PR, with a pretend test script that fakes writing coverage, this won't run:

incubator/ex (pr/604 $%) % vi package.json 
incubator/ex (pr/604 $%) % appsody test   
Running test environment
Using local cache for image dev.local/appsody/nodejs:0.3
Running command: docker run --rm -p 3000:3000 -p 9229:9229 --name ex-dev -v /home/sam/w/cloud-node/appsody-stacks/incubator/ex/:/project/user-app -v ex-deps:/project/user-app/node_modules -v 
appsody-controller-0.3.3:/.appsody -t --entrypoint /.appsody/appsody-controller dev.local/appsody/nodejs:0.3 --mode=test
[Container] Running APPSODY_PREP command: npm install && npm audit fix
up to date in 0.508s
[Container] found 0 vulnerabilities
[Container] 
up to date in 0.04s
[Container] fixed 0 of 0 vulnerabilities in 0 scanned packages
[Container] Running command:  npm test
[Container] 
[Container] > nodejs-simple@0.1.0 test /project/user-app
[Container] > touch coverage.txt
[Container] 
[Container] touch: cannot touch 'coverage.txt': Permission denied
[Container] npm ERR! Test failed.  See above for more details.
[Container] [Error] Wait received error with status code: 1 due to error: exit status 1
[Error] Error in 'appsody test': exit status 1
incubator/ex (pr/604 $%) % git diff
incubator/ex (pr/604 $%) % grep test package.json 
    "test": "touch coverage.txt",

Anyhow, I originally got pulled into this to answer some questions about IBM's apm plugin and its unfortunate writing of resource.log, which can't be disabled. I filed an issue upstream (no response yet on that).

In terms of generally how appsody will enable the code running in the container to write to its src directory, I'm not sure.

I suppose it might be possible to make (and document) "rules" -- such as "apps can't run in appsody unless they always write not to the CWD, but to APPSODY_TMP, or maybe appsody should actually run with the CWD in /tmp? I'm not sure.

Kamran64

comment created time in 2 days

pull request commentappsody/stacks

Run nodejs stack as node user rather than root

Was it your intention to not use the node user, and instead create a new one? The mixture of permissions seems unusual, and may be the source of the perm problems, because /project/user-app is owned by node, but npm start is being run as the user node_user:

incubator/nodejs (pr/604 $%) % docker exec -it f042030663b7 /bin/bash
node_user@f042030663b7:/project/user-app$ ls
app.js  node_modules  package-lock.json  package.json
node_user@f042030663b7:/project/user-app$ ls -l
total 16
-rw-rw-r-- 1 node      node        37 Feb 25 18:03 app.js
drwxr-xr-x 2 node_user node_user 4096 Feb 25 17:59 node_modules
-rw-rw-r-- 1 node      node        76 Feb 25 18:03 package-lock.json
-rw-rw-r-- 1 node      node       358 Feb 25 18:03 package.json
node_user@f042030663b7:/project/user-app$ id    
uid=1001(node_user) gid=1001(node_user) groups=1001(node_user)
node_user@f042030663b7:/project/user-app$ touch fu
touch: cannot touch 'fu': Permission denied
node_user@f042030663b7:/project/user-app$ ls -ld /project /project/user-app
drwxr-xr-x 1 node_user node_group 4096 Feb 25 18:00 /project
drwxrwxr-x 4 node      node       4096 Feb 25 18:03 /project/user-app
Kamran64

comment created time in 2 days

pull request commentappsody/stacks

Run nodejs stack as node user rather than root

<details><summary>This PR does not run for me. See below. I ran docker system prune --all --volumes --force before to get a clean system state, and don't think I'm seeing a volume persistence issue because I had no docker volumes before doing appsody run.</summary>

incubator/nodejs (pr/604 $%) % appsody stack package
******************************************
Running appsody stack package
******************************************
[Warning] Not all labels will be set. Unable to determine origin to compute repository URL
Running docker build
Running command: docker build -t dev.local/appsody/nodejs:0.3.3 -t dev.local/appsody/nodejs:0.3 -t dev.local/appsody/nodejs:0 -t dev.local/appsody/nodejs --label org.opencontainers.image.created=2020-02-25T09:58:56-08:00 --label org.opencontainers.image.authors=Sam Roberts <vieuxtech@gmail.com> --label org.opencontainers.image.version=0.3.3 --label org.opencontainers.image.licenses=Apache-2.0 --label org.opencontainers.image.title=Node.js --label org.opencontainers.image.description=Runtime for Node.js applications --label dev.appsody.stack.id=nodejs --label dev.appsody.stack.tag=dev.local/appsody/nodejs:0.3.3 -f /home/sam/.appsody/stacks/packaging-nodejs/image/Dockerfile-stack /home/sam/.appsody/stacks/packaging-nodejs/image
[Docker] Sending build context to Docker daemon  22.53kB
[Docker] Step 1/37 : FROM node:12
target is: /home/sam/.appsody/stacks/dev.local/nodejs.v0.3.3.templates.
...
new target is: /home/sam/.appsody/stacks/dev.local/nodejs.v0.3.3.templates.simple.tar.gz
Writing: /home/sam/.appsody/stacks/dev.local/dev.local-index.yaml
Your local stack is available as part of repo dev.local
incubator/nodejs (pr/604 $%) % rm -rf ../ex
incubator/nodejs (pr/604 $) % mkdir ../ex
incubator/nodejs (pr/604 $) % cd ../ex
incubator/ex (pr/604 $) % appsody init dev.local/nodejs
Checking stack requirements...
Docker requirements met
Appsody requirements met
Running appsody init...
Downloading nodejs template project from file:///home/sam/.appsody/stacks/dev.local/nodejs.v0.3.3.templates.simple.tar.gz
Download complete. Extracting files from /home/sam/w/cloud-node/appsody-stacks/incubator/ex/nodejs.tar.gz
Setting up the development environment
Your Appsody project name has been set to ex
Using local cache for image dev.local/appsody/nodejs:0.3
Running command: docker run --rm --entrypoint /bin/bash dev.local/appsody/nodejs:0.3 -c find /project -type f -name .appsody-init.sh
Successfully initialized Appsody project with the dev.local/nodejs stack and the default template.
incubator/ex (pr/604 $%) % docker volume ls
DRIVER              VOLUME NAME
incubator/ex (pr/604 $%) % appsody run
Running development environment...
Using local cache for image dev.local/appsody/nodejs:0.3
Running command: docker run --rm -v appsody-controller-0.3.3:/.appsody appsody/init-controller:0.3.3
Unable to find image 'appsody/init-controller:0.3.3' locally
0.3.3: Pulling from appsody/init-controller
322973677ef5: Pulling fs layer
d6bf415d0a7d: Pulling fs layer
322973677ef5: Verifying Checksum
322973677ef5: Download complete
d6bf415d0a7d: Download complete
322973677ef5: Pull complete
d6bf415d0a7d: Pull complete
Digest: sha256:038374ea014798d9cf1ad8f591eb0985039b7edaeb638f2cdc540747262ee7ed
Status: Downloaded newer image for appsody/init-controller:0.3.3
Running command: docker run --rm -p 3000:3000 -p 9229:9229 --name ex-dev -v /home/sam/w/cloud-node/appsody-stacks/incubator/ex/:/project/user-app -v ex-deps:/project/user-app/node_modules -v appsody-controller-0.3.3:/.appsody -t --entrypoint /.appsody/appsody-controller dev.local/appsody/nodejs:0.3 --mode=run
[Container] Running APPSODY_PREP command: npm install && npm audit fix
up to date in 0.332s
[Container] found 0 vulnerabilities
[Container]
[Container] up to date in 0.037s
[Container] fixed 0 of 0 vulnerabilities in 0 scanned packages
[Container] Running command:  npm start --node-options --require=appmetrics-dash/attach
[Container]
[Container] > nodejs-simple@0.1.0 start /project/user-app
[Container] > node app.js
[Container]
[Container] [Tue Feb 25 18:03:20 2020] com.ibm.diagnostics.healthcenter.loader INFO: Node Application Metrics 5.1.1.202002251800 (Agent Core 4.0.5)
[Container] Hello from Node.js 12!
[Container] log4js.fileAppender - Writing to file resourceRegistry.log, error happened  [Error: EACCES: permission denied, open '/project/user-app/resourceRegistry.log'] {
[Container]   errno: -13,
[Container]   code: 'EACCES',
[Container]   syscall: 'open',
[Container]   path: '/project/user-app/resourceRegistry.log'
[Container] }

</details>

Kamran64

comment created time in 2 days

pull request commentnodejs/node

test: mark empty udp tests flaky on OS X

@AshCripps would it be helpful to get this fast-tracked? I kicked of a full CI on it, but it still needs 25 hours, but we can fast-track given its triviality and impact on CI stability if its blocking bringing the OS X 10.15/Catalina machines into CI.

sam-github

comment created time in 2 days

issue commentsiimon/prom-client

nodejs_version_info empty after registry reset

Probably the version gauge needs to return a collect function. It didn't before, and doesn't now, because the values never change. I guess the interaction with reset wasn't considered.

ssube

comment created time in 2 days

delete branch sam-github/node

delete branch : tls-min-max-cli-v10.x

delete time in 3 days

pull request commentnodejs/node

[v10.x] tls: support TLS min/max protocol defaults in CLI

Yay!

sam-github

comment created time in 3 days

issue openedibm-garage-cloud/ibm-garage-developer-guide

page isn't readable with chrome

Describe the bug ibm-garage-cloud.github.io/ibm-garage-developer-guide/starterkits/starterkittemplates is unreadable

https://ibm-garage-cloud.github.io/ibm-garage-developer-guide/starterkits/starterkittemplates/ with chrome looks like this:

image

Its not possible to move the left-side navigation panel, and its not possible to scroll the text, so the left 1/3 of the page can't be read.

In Firefox, its readable.

image

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS] Linux
  • Browser [e.g. chrome, safari] chrome
  • Version [e.g. 22] current

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

created time in 3 days

delete branch sam-github/stacks

delete branch : fix-conventions

delete time in 3 days

pull request commentappsody/stacks

node-red: Run stack as non root

Fails to run with same issues as in https://github.com/appsody/stacks/pull/604#issuecomment-590523106

Kamran64

comment created time in 3 days

pull request commentappsody/stacks

Run nodejs stack as node user rather than root

So, the changes in here are now a copy of https://github.com/appsody/stacks/pull/624?

I'm not sure if you want me to review, or still have open questions.

I cleaned all containers and images, packaged the stack, and tried to use it. No luck.

It fails to run, npm has no write access to /project/user-app/node_modules in the container, and appsody caused docker to create a node_modules on the host that is owned by root:root (I'm on Linux, if that's relevant).

Same for you?

incubator/nodejs (pr/604 $%) % pwd
/home/sam/w/cloud-node/appsody-stacks/incubator/nodejs
incubator/nodejs (pr/604 $%) % mkdir ex
incubator/nodejs (pr/604 $%) % cd ex
nodejs/ex (pr/604 $%) % appsody init dev.local/nodejs
Checking stack requirements...
Docker requirements met
Appsody requirements met
Running appsody init...
Downloading nodejs template project from file:///home/sam/.appsody/stacks/dev.local/nodejs.v0.3.3.templates.simple.tar.gz
Download complete. Extracting files from /home/sam/w/cloud-node/appsody-stacks/incubator/nodejs/ex/nodejs.tar.gz
Setting up the development environment
Your Appsody project name has been set to ex
Using local cache for image dev.local/appsody/nodejs:0.3
Running command: docker run --rm --entrypoint /bin/bash dev.local/appsody/nodejs:0.3 -c find /project -type f -name .appsody-init.sh
Successfully initialized Appsody project with the dev.local/nodejs stack and the default template.
nodejs/ex (pr/604 $%) % ls
./  ../  app.js  .appsody-config.yaml  .gitignore  package.json  package-lock.json  .vscode/
nodejs/ex (pr/604 $%) % appsody run
Running development environment...
Using local cache for image dev.local/appsody/nodejs:0.3
Running command: docker run --rm -p 3000:3000 -p 9229:9229 --name ex-dev -v /home/sam/w/cloud-node/appsody-stacks/incubator/nodejs/ex/:/project/user-app -v ex-deps:/project/user-app/node_modules -v appsody-controller-0.3.3:/.appsody -t --entrypoint /.appsody/appsody-controller dev.local/appsody/nodejs:0.3 --mode=run
[Container] Running APPSODY_PREP command: npm install && npm audit fix
npm WARN checkPermissions Missing write access to /project/user-app/node_modules/ansi-colors
[Container] npm WARN checkPermissions Missing write access to /project/user-app/node_modules/ansi-regex
[Container] npm WARN checkPermissions Missing write access to /project/user-app/node_modules/assert-plus
.......... etc.....
[Container] npm ERR!   errno: -13,
[Container] [Error] FATAL error APPSODY_PREP command received an error.  The controller is exiting: exit status 243
[Error] Error in 'appsody run': exit status 1
nodejs/ex (pr/604 $%) % ls -l 
total 36
drwxrwxr-x 4 sam  sam  4096 Feb 24 11:54 ./
drwxrwxr-x 5 sam  sam  4096 Feb 24 11:54 ../
-rw-rw-r-- 1 sam  sam    37 Feb 24 11:54 app.js
-rw-rw-r-- 1 sam  sam    53 Feb 24 11:54 .appsody-config.yaml
-rw-rw-r-- 1 sam  sam  1316 Feb 24 11:54 .gitignore
drwxr-xr-x 2 root root 4096 Feb 24 11:54 node_modules/
-rw-rw-r-- 1 sam  sam   358 Feb 24 11:54 package.json
-rw-rw-r-- 1 sam  sam    76 Feb 24 11:54 package-lock.json
drwxr-xr-x 2 sam  sam  4096 Feb 24 11:54 .vscode/
Kamran64

comment created time in 3 days

delete branch sam-github/node

delete branch : update-zlib

delete time in 3 days

push eventnodejs/node

Sam Roberts

commit sha 5f0181a079f4dd328fb01a75daff0a128c33fc70

deps: move zlib maintenance info to guides deps/zlib/README.md is not part of the upstream zlib, it is a Node.js specific addition describing how to maintain zlib and should be in doc/guides/. PR-URL: https://github.com/nodejs/node/pull/31800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Sam Roberts

commit sha 0d95eda4996e5e895b80cd68052332a102de9fd3

doc: describe how to update zlib See: - https://github.com/nodejs/node/pull/31201 PR-URL: https://github.com/nodejs/node/pull/31800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

Sam Roberts

commit sha 9a1719b541b53eae844d801a74a8b6328ad1c9fd

deps: update zlib to upstream d7f3ca9 Updated as described in doc/guides/maintaining-zlib.md. PR-URL: https://github.com/nodejs/node/pull/31800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

view details

push time in 3 days

PR closed nodejs/node

doc: add zlib maintenance doc zlib

Add a maintenance doc for deps/zlib, and run the process.

Result is an almost entirely empty "update" (only the mode of one file was different from upstream).

Note: we changed to using a google repo as upstream in https://github.com/nodejs/node/pull/31201

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+34 -6

4 comments

3 changed files

sam-github

pr closed time in 3 days

pull request commentnodejs/node

doc: add zlib maintenance doc

Landed in b70dd9d662aa...9a1719b541b5

sam-github

comment created time in 3 days

Pull request review commentappsody/stacks

Run nodejs stack as node user rather than root

 RUN apt-get update \  && echo 'Finished installing dependencies'  # Copy the project-COPY --chown=node:node . /project+COPY --chown=node_user:node_group . /project  # Copy all dependencies-COPY --chown=node:node --from=0 /project/user-app/node_modules /project/user-app/node_modules+COPY --chown=node_user:node_group --from=0 /project/user-app/node_modules /project/user-app/node_modules++RUN chown -hR node_user:0 /project \+ && chmod -R g=u /project  WORKDIR "/project/user-app"  ENV NODE_ENV production -USER node+USER node_user  CMD ["npm", "start"]

^--- missing NL at end of line (GH and git don't like it)

Kamran64

comment created time in 3 days

pull request commentnodejs/node

[v10.x] tls: support TLS min/max protocol defaults in CLI

10.x CI is pretty unstable. To save any searching, this is failing on unrelated tests on Windows:

  • test.parallel/test-http2-client-upload
  • test.parallel/test-worker-messageport-transfer-terminate

ref

sam-github

comment created time in 3 days

Pull request review commentnodejs/build

workflow: add stale action

+name: "Close stale issues"+on:+  schedule:+  - cron: "0 0 * * *"++jobs:+  stale:+    runs-on: ubuntu-latest+    steps:+    - uses: actions/stale@v1+      with:+        repo-token: ${{ secrets.GITHUB_TOKEN }}+        stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days'+        stale-issue-label: 'stale'

It wasn't clear whether this label has to be created, or the plugin will create it. I guess I'll find out if we decide to try this out.

sam-github

comment created time in 3 days

Pull request review commentnodejs/build

workflow: add stale action

+name: "Close stale issues"+on:+  schedule:+  - cron: "0 0 * * *"++jobs:+  stale:+    runs-on: ubuntu-latest+    steps:+    - uses: actions/stale@v1+      with:+        repo-token: ${{ secrets.GITHUB_TOKEN }}+        stale-issue-message: 'This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days'+        stale-issue-label: 'stale'+        days-before-stale: 90

Just a suggested value. With 90, every issue will get a nudge every 3 months, and if its still relevant whoever is interested just has to comment with a "I still plan to do this" or "current state is ..." (or anything else, or just remove the label), and it will get another 90 days of being ignored.

sam-github

comment created time in 3 days

issue commentnodejs/build

suggestion: we enable the "stale" bot on nodejs/build

In case we do decide to try this: https://github.com/nodejs/build/pull/2196

sam-github

comment created time in 3 days

PR opened nodejs/build

workflow: add stale action

Setup to mark stale after 90 days, and close 15 days after marked stale unless the issue is commented on, or has the stale label removed.

Fixes: https://github.com/nodejs/build/issues/2190


Draft - awaiting some comment on https://github.com/nodejs/build/issues/2190 to agree this is useful. I've never configured a GH action before, I'd appreciate a review by someone who has!

+16 -0

0 comment

1 changed file

pr created time in 3 days

create barnchsam-github/build

branch : add-stale-action

created branch time in 3 days

issue commentnodejs/build

suggestion: we enable the "stale" bot on nodejs/build

Since we are already using actions, I assume that would be lower barrier to entry.

@nodejs/build - any comments pro or con?

sam-github

comment created time in 3 days

push eventsam-github/node

Sam Roberts

commit sha e2d2d3b60bcd94f284c388cab6979a7e0b3aedbb

doc: update security release process

view details

push time in 3 days

push eventsam-github/node

Sam Roberts

commit sha 125d6b76523f3e7eec4c7d97e353d693857b5d31

Update doc/guides/security_release_process.md

view details

push time in 3 days

push eventsam-github/node

Sam Roberts

commit sha 2f41bbad721941f9443c337347209e6a5df09387

doc: update security release process

view details

push time in 3 days

push eventsam-github/node

Shelley Vohr

commit sha 3a2254959b9e8c5177289ab1c1259f18ceaf9449

src: use hex not decimal in IsArrayIndex PR-URL: https://github.com/nodejs/node/pull/31758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Michael Dawson

commit sha 79296dc2d02c0b9872bbfcbb89148ea036a546d0

doc: guide - using valgrind to debug memory leaks Add doc for using valgrind to debug native memory leaks. Started writing this up as part of an effort in the Diagnostic WG but think it's better to have it in the core guides and then be referenced by the docs in the Diagnostic WG repo. For more details on the Diagnostic WG effort see https://github.com/nodejs/diagnostics/issues/254#issuecomment-538853390 This guide is related to `/step3 - using_native_tools.md` PR-URL: https://github.com/nodejs/node/pull/31501 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Anna Henningsen

commit sha a7c523e26df468782691c7e16b2e033c6256beb3

src: prefer 3-argument Array::New() This is nicer, because: 1. It reduces overall code size, 2. It’s faster, because `Object::Set()` calls are relatively slow, and 3. It helps avoid invalid `.Check()`/`.FromJust()` calls. PR-URL: https://github.com/nodejs/node/pull/31775 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Robert Nagy

commit sha c776a37791007e0d570355b731647e58ea5885be

http: end with data can cause write after end Calling end() with data while ending should trigger a write after end error. PR-URL: https://github.com/nodejs/node/pull/28666 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha 568fdfb1658bfcaa7832759e03661f2cb958c155

fs: fix WriteStream autoClose order WriteStream autoClose was implemented by manually calling .destroy() instead of using autoDestroy and callback. This caused some invariants related to order of events to be broken. Fixes: https://github.com/nodejs/node/issues/31776 PR-URL: https://github.com/nodejs/node/pull/31790 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Samuel Attard

commit sha 093639614fa1cea7a1bc3493d28119a924c97bc9

doc: claim ABI version 82 for Electron 10 PR-URL: https://github.com/nodejs/node/pull/31778 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Anna Henningsen

commit sha 26e49d83323c78e89b2664b6eeaee90757d52868

worker: unroll file extension regexp Refs: https://github.com/nodejs/node/pull/31662#discussion_r377016190 PR-URL: https://github.com/nodejs/node/pull/31779 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Jeff

commit sha e028ea0291b845e4bec3c7cff7319a027b8c815e

doc: fix typos in doc/api/https.md PR-URL: https://github.com/nodejs/node/pull/31793 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

Jeremiah Senkpiel

commit sha 4d6c861800cc6ac1dc6a0fd9d3a8b0053baec62a

doc: move @Fishrock123 to a previous releaser I have not done a release in well over a year, maybe even two. I also don't really plan to do more, as Node.js releases are very tedious. PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 928c210a611fb6b4575843708e7cb921f311ebde

doc: move @Fishrock123 to TSC Emeriti It was a good run. Almost 5 years. I haven't really been involved in the last 3+? months though, so it's time I call it and 'retire'. I think it is unlikely that I'll be on the TSC again, as node is unfortunately becoming increasingly disinteresting (& frustrating) to me. (So long and thanks for all the fish!) PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Jeremiah Senkpiel

commit sha 30e6049c75590dec8d5edbf033edbc20e79efcb7

doc: pronouns for @Fishrock123 might as well while I'm at it feels a bit weird being the first person on this list with '/they' but I guess someone's gota do it PR-URL: https://github.com/nodejs/node/pull/31725 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Gireesh Punathil

commit sha 4c746a6cfda980c1cd0de6246781c0083d9e416c

doc: move gireeshpunathil to TSC emeritus PR-URL: https://github.com/nodejs/node/pull/31770 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

James M Snell

commit sha 5bef2ccf20cceda7975f8bce860e0f60595482fc

test: add known issue test for sync writable callback If the write callbacks are invoked synchronously with an error, onwriteError would cause the error event to be emitted synchronously, making it impossible to attach an error handler after the call that triggered it. PR-URL: https://github.com/nodejs/node/pull/31756 Refs: https://github.com/nodejs/quic/commit/b0d469c69c49c9186c1a581a7cebce4c5d398947 Refs: https://github.com/nodejs/quic/pull/341 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

view details

Robert Nagy

commit sha 85c6fcd1cd11ec6ee22891e48a67cc97f60880e8

stream: avoid writing to writable A remainder from a previous refactoring. Refs: https://github.com/nodejs/node/pull/31197 PR-URL: https://github.com/nodejs/node/pull/31805 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Rich Trott

commit sha 99428e0858bb3cce820190770ca8217460d95c80

doc: reword possessive form of Node.js in debugger.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha d40c648e884bd64028fa0a67122a0af87c60f467

doc: reword possessive form of Node.js in process.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha d25fcb0c201286d18c07653347258ce02951ddf8

doc: reword possessive form of Node.js in http.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Rich Trott

commit sha eb0ade10a7af855ecdaa822dea028d661664cd43

doc: reword possessive form of Node.js in adding-new-napi-api.md Throughout the docs, we sometimes write the possessive of _Node.js_ as _Node.js'_ and other times as _Node.js's_. The former conforms with some generally accepted style guides (e.g., Associated Press Stylebook) while the latter complies with others (e.g., Chicago Manual of Style). Since there is no clear authoritative answer as to which form is correct, and since (at least to me) both are visually jarring and sometimes cause a pause to understand, I'd like to reword things to eliminate the possessive form where possible. This is one of those examples. PR-URL: https://github.com/nodejs/node/pull/31748 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha fab3eff2e53eb9bfbb890e5ac45523ae68ae95e5

src: inform callback scopes about exceptions in HTTP parser Refs: https://github.com/nodejs/node/commit/4aca277f16b8649b5fc21d41f340fad0a47c2e61 Refs: https://github.com/nodejs/node/pull/30236 Fixes: https://github.com/nodejs/node/issues/31796 PR-URL: https://github.com/nodejs/node/pull/31801 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Rich Trott

commit sha 794bfacb26c4059c2eab7efb475489b7010054c3

test: remove common.PORT from test-net-timeout Switch test-net-timeout from common.PORT to a port assigned by the operating system. PR-URL: https://github.com/nodejs/node/pull/31749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 3 days

pull request commentnodejs/node

test: mark empty udp tests flaky on OS X

I don't have access to a machine I can repro this on, but I asked @AshCripps to try it (https://github.com/nodejs/build/pull/2189#issuecomment-590483454). @lpinca , perhaps you can review, too?

sam-github

comment created time in 3 days

pull request commentnodejs/build

[WIP] ansible: add 10.15 macs

@AshCripps can you try https://github.com/nodejs/node/pull/31936 and see if the updating of expected status fixes this for you?

AshCripps

comment created time in 3 days

PR opened nodejs/node

test: mark empty udp tests flaky on OS X

They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X.

Refs: https://github.com/nodejs/node/issues/30030 Refs: https://github.com/nodejs/build/pull/2189#issuecomment-589767606

Note: CI doesn't test on Catalina, yet (though I assume nodejs developers do). Test failures will indirectly block fixing of https://github.com/nodejs/node/issues/29216, which requires running notarization on Catalina, which requires tests passing on Catalina.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [ ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [ ] documentation is changed or added
  • [ ] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+7 -0

0 comment

1 changed file

pr created time in 3 days

push eventsam-github/node

Sam Roberts

commit sha e8667bb72ec3769b26ab723ce46d85538b5846c0

test: mark empty udp tests flaky on OS X They fail on OS X 10.15 (aka "Catalina"), but pass on earlier OS X. Refs: https://github.com/nodejs/node/issues/30030 Refs: https://github.com/nodejs/build/pull/2189#issuecomment-589767606

view details

push time in 3 days

create barnchsam-github/node

branch : catalina-udp-flakes

created branch time in 3 days

pull request commentappsody/stacks

Nodejs express optimize copy for buildah

The issue we have today is that buildah 1.9.0 does not honour .dockerignore, and has a buggy algorithm for iterating over files. We can not move to a higher version (which has this fix) yet because of other issues.

^--- without this information, the Dockerfile isn't understandable on its own, so its likely to get refactored to break buildah. I strongly suggest that the information above be put into the dockerfile in a comment. It doesn't necessarily need a link to this PR in the comment, since that can be found from git blame.

Also, I'm a bit confused by "we can't update", who is "we"? appsody doesn't use buildah, does it? Since buildah isn't used in appsody AFAICT, its not possible to know if any future change here breaks whoever is using buildah downstream (who is using buildah downstream?). At some point in the future, I assume this structure can be deleted, but without any reproduction information here, or link to the downstream consumer who is having this issue, it won't be possible to know or ask when the workaround can be deleted.

neeraj-laad

comment created time in 3 days

delete branch sam-github/security-wg

delete branch : feb-2020-node-sec

delete time in 3 days

push eventnodejs/security-wg

Sam Roberts

commit sha 0bf201409d659e0cca19fc32815b5dabfde14406

vuln: Node.js Feb 2020 security release (#629) * Fix typo in tools/README run command * vuln: Node.js Feb 2020 security release

view details

push time in 3 days

PR merged nodejs/security-wg

vuln: Node.js Feb 2020 security release

The JSON was created by npm run report, but they fail to validate.

I correct cves to cve, but then there was another error. I'm not sure, am I doing this wrong?

+26 -2

2 comments

4 changed files

sam-github

pr closed time in 3 days

delete branch nodejs/TSC

delete branch : sam-github-patch-1

delete time in 3 days

push eventnodejs/TSC

Sam Roberts

commit sha fa00319d3c9f87ce827e632a5deea549dd090b02

doc: describe workaround for authorization error (#826)

view details

push time in 3 days

push eventnodejs/TSC

Sam Roberts

commit sha 145329f3fb909a5ec3c65c9acd4f0fff72a03626

Update Streaming/Streaming-To-Youtube.md Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com>

view details

push time in 3 days

issue commentnodejs/security-wg

CVE-2019-15605 and CVE-2019-15606 on hackerone

@mralekzandr can you look at https://hackerone.com/reports/730779 ? The reporter would like to approve disclosure, but can't figure out how. I don't know what it looks like from their end, but the UI doesn't seem to have a display of disclosure requests. I know I've requested disclosure, because it says so on the top of the report, but that's all I see.

Beuc

comment created time in 3 days

PR opened nodejs/TSC

doc: describe workaround for authorization error
+4 -1

0 comment

1 changed file

pr created time in 3 days

create barnchnodejs/TSC

branch : sam-github-patch-1

created branch time in 3 days

issue commentsiimon/prom-client

nodejs_version_info empty after registry reset

@ssube was this fixed by #180?

ssube

comment created time in 5 days

issue commentsiimon/prom-client

Unable to get Counter value

For a unit test, I would suggest putting the counter in a registry (make one specifically for the test), call reg.metrics(), parse value from there.

Close this as won't fix?

brian-byungsookim

comment created time in 5 days

pull request commentappsody/stacks

Run nodejs stack as node user rather than root

@skoh7645 You mentioned an alternative technique ENV APPSODY_USER_RUN_AS_LOCAL=true, I tried:

  1. added that to incubator/nodejs-express/image/Dockerfile-stack,
  2. ran appsody stack package,
  3. mkdir ex; cd ex; appsody init dev.local/nodejs-express,
  4. appsody run,

and hit the same

EACCES: permission denied, open '/project/resourceRegistry.log

I expected to see what you reported:

npm ERR! correctMkdir failed to make directory /.npm/_locks
[Container] npm ERR! code EACCES
[Container] npm ERR! syscall mkdir
[Container] npm ERR! path /.npm
[Container] npm ERR! errno -13

So I'm doing something wrong. Would you like to give me repro information?

nodejs-express/ex (pr/604 *$%) % appsody version
appsody 0.5.3
nodejs-express/ex (pr/604 *$%) % uname -a
Linux samtu 5.3.0-29-generic #31-Ubuntu SMP Fri Jan 17 17:27:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
nodejs-express/ex (pr/604 *$%) % docker -v
Docker version 19.03.6, build 369ce74a3c

Since user-app is being mounted in from the host, I think running with the host user's credentials makes a lot of sense... if it can be made to work.

Kamran64

comment created time in 6 days

issue openedIBM/node-ibmapm-restclient

resource.log file is always created,throwing errors on read-only filesystems

For security, containers should be able to run with a read-only FS, but this package throws errors if it cannot create resourceRegistry.log.

There appears to be some configuration available in https://github.com/IBM/node-ibmapm-restclient/blob/464089d21dce4f2baefa7487fd6ae71f3b18008b/lib/plugins/logutil.js#L22-L31, but it isn't sufficient.

Even when KNJ_LOG_LEVEL is set to NONE, the file is created (but empty).

Even when KNJ_LOG_TO_CONSOLE is set to true, the file is created.

Is there any other mechanisms to avoid any attempts to write to the local FS?

If not, can you implement one? Perhaps make KNJ_LOG_TO_CONSOLE cause all logging to go to console?

created time in 6 days

pull request commentappsody/stacks

Run nodejs stack as node user rather than root

@skoh7645 You asked:

Can we turn off writing to the resourceRegistry.log file as users would not see this anyway?

No.  > If not, could we write the file elsewhere?

No.

I have opened an issue on ibmapm-restclient.

Kamran64

comment created time in 6 days

issue commentnodejs/build

Request URL redirect: Node.js case studies

to: @nodejs/build-infra

brianwarner

comment created time in 6 days

fork sam-github/CMake

Mirror of CMake upstream repository

https://gitlab.kitware.com/cmake/cmake

fork in 6 days

issue commentnodejs/TSC

Sorting out Intl vs I18n labels, teams, and repos

see new --> replaced by the ?

sam-github

comment created time in 6 days

issue commentnodejs/i18n

i18n WG Meeting - Feb 21

If anybody in the WG wants to take on sorting https://github.com/nodejs/TSC/issues/813 out, I'd sure appreciate it!

obensource

comment created time in 6 days

pull request commentnodejs/build

[WIP] ansible: add 10.15 macs

Perhaps a one-time run of https://github.com/nodejs/node/blob/master/tools/macos-firewall.sh is needed?

AshCripps

comment created time in 6 days

issue openednodejs/build

Move refack to Emiritus

I checked with @refack, he is OK if we move him to Emiritus and remove him from the various build-wg teams.

He made major contributions to the build-wg during his time, and I'd like to publically thank him for that. Cheers!

This is probably a good test run of the offboarding process, too. I'll do that next week after a couple thumbs ups.

created time in 6 days

pull request commentnodejs/build

doc: sync teams from github to README

Since this just updates the README to correctly document the current state, I merged.

sam-github

comment created time in 6 days

delete branch sam-github/build

delete branch : update-teams

delete time in 6 days

push eventnodejs/build

Sam Roberts

commit sha 67f52191a55d335d9cd51d237cf61f2b353cb94a

doc: sync teams from github to README (#2191) Result of running `ncu-team sync README.md`.

view details

push time in 6 days

PR merged nodejs/build

doc: sync teams from github to README

Result of running ncu-team sync README.md.

+3 -1

0 comment

1 changed file

sam-github

pr closed time in 6 days

PR opened nodejs/build

doc: sync teams from github to README

Result of running ncu-team sync README.md.

+3 -1

0 comment

1 changed file

pr created time in 6 days

create barnchsam-github/build

branch : update-teams

created branch time in 6 days

issue commentnodejs/Release

Removing python 2.7

https://github.com/nodejs/node/issues/25789#issuecomment-571293501 discusses the plan wrt. Python 3 support.

the version that is used by npm is not quite recent enough and still has python 2.7 support.

... and it also has Python 3 support, so should work for everybody. This is a good thing.

Pomax

comment created time in 6 days

Pull request review commentappsody/stacks

Nodejs express optimize copy for buildah

 RUN apt-get update \  && apt-get clean \  && echo 'Finished installing dependencies' +WORKDIR "/project/user-app/node_modules"

Yes: https://github.com/appsody/stacks/pull/679#issuecomment-589350889

neeraj-laad

comment created time in 6 days

issue commentnodejs/security-wg

CVE-2019-15605 and CVE-2019-15606 on hackerone

Fair enough. We're disclosing for transparency, but you'll find that the repro was in the sec release, for example: https://nodejs.org/en/blog/release/v13.8.0/ has

[eea3a7429b] - test: using TE to smuggle reqs is not possible (Sam Roberts)

similar tests landed in http-parser and llhttp.

Beuc

comment created time in 6 days

pull request commentsiimon/prom-client

fix: TypeScript declaration - strict label values

This makes me wonder if some tests actually written in typescript against the ts defs would be useful, to confirm that the ts defs are actually valid and useful (speaking as a non-ts developer who has had to update the defs lately, and did so with trepidation).

kobiburnley

comment created time in 7 days

pull request commentappsody/stacks

nodejs - Optimize copy for buildah

This PR is a duplicate of https://github.com/appsody/stacks/pull/680 which changes both stacks in the same PR. I suggest closing this PR, since the changes are cut-n-paste, its easier to fix in one PR and easier to understand the historical record as well.

neeraj-laad

comment created time in 7 days

issue commentnodejs/security-wg

CVE-2019-15605 and CVE-2019-15606 on hackerone

It looks like H1 is setup so that it takes agreement of reporter AND the project before a report is disclosed, so the timing is not entirely under our control. I'm doing what I can to expedite it, though (I pinged the reporters).

Fwiw, the http-parser fixes are public (as are the node commits) https://github.com/nodejs/http-parser/commit/7d5c99d09f6743b055d53fc3f642746d9801479b

cc: @mralekzandr

Beuc

comment created time in 7 days

pull request commentsiimon/prom-client

fix: align compliancy to Prometheus naming convention

I just checked this out, rebased it against master, and it passed. The last commit adds timestamp support, and all timestampe support is unneeded. So, I pushed that commit off my branch, and retested, and it passed.... that shows the last commit lacked unit tests! :-)

But, since it should be removed, it doesn't matter.

I didn't actually look at the output and run it pass the promtool checker, though, so I've no comment on the substance of the PR yet.

izonder

comment created time in 7 days

delete branch sam-github/prom-client

delete branch : remove-timeout

delete time in 7 days

delete branch sam-github/prom-client

delete branch : rm-timestamp

delete time in 7 days

Pull request review commentappsody/stacks

Nodejs express optimize copy for buildah

 RUN apt-get update \  && echo 'Finished installing dependencies'  # Copy the project-COPY --chown=node:node . /project

Does buildah do better when copying between images than it does when copying from host?

It looks like all the lines from here to ENV NODE_PATH could be replaced by a single line:

COPY --chown=node:node --from=0 /project /project

neeraj-laad

comment created time in 7 days

Pull request review commentappsody/stacks

Nodejs express optimize copy for buildah

 RUN apt-get update \  && echo 'Finished installing dependencies'  # Install stack dependencies+WORKDIR /project/node_modules

Isn't this a nul-op, given the next line sets the WORKDIR to something else?

neeraj-laad

comment created time in 7 days

Pull request review commentappsody/stacks

Nodejs express optimize copy for buildah

 RUN apt-get update \  && echo 'Finished installing dependencies'  # Install stack dependencies+WORKDIR /project/node_modules WORKDIR /project COPY ./package*.json ./-RUN npm install --production+RUN npm install --production && tar czf stack_modules.tgz node_modules && rm -rf node_modules  # Install user-app dependencies+WORKDIR /project/user-app/node_modules

Isn't this a nul-op, given the next line sets the WORKDIR to something else?

neeraj-laad

comment created time in 7 days

pull request commentnodejs/quic

deps: use akamai's openssl 1.1.1d quic API port

Ooops, sorry, I just looked at

merge 4 commits into nodejs:master ...

and thought that meant nodejs/node:master. I think github elided some useful information there.

Ignore my comments, and I'll remove them.

jasnell

comment created time in 7 days

issue commentnodejs/security-wg

CVE-2019-15605 and CVE-2019-15606 on hackerone

@Beuc

so I can better locate and test vulnerabilities in older nodejs versions

Do you mean pre-10.x Node.js versions? I'm curious, does Debian offer support for EOL Node.js release lines?

Beuc

comment created time in 7 days

issue closednodejs/security-wg

CVE-2019-15605 and CVE-2019-15606 on hackerone

Hi,

I'm investigating CVE-2019-15604/5/6 for Debian (fixed in nodejs release 2020-02-06). https://hackerone.com/reports/735748 and https://hackerone.com/reports/730779 are currently private - is there plan to make them public, so I can better locate and test vulnerabilities in older nodejs versions?

Cheers!

closed time in 7 days

Beuc

issue commentnodejs/security-wg

CVE-2019-15605 and CVE-2019-15606 on hackerone

Disclosure has been requested, they will be disclosed in 16 days (about) or when the reporters accept the request (whichever comes first).

Beuc

comment created time in 7 days

pull request commentappsody/stacks

Typescript express stack

Specifically, I do not understand why typescript cannot be handled as another template in https://github.com/appsody/stacks/tree/master/incubator/nodejs-express/templates Why can't the app's transpilation dependencies and setup be put into a typescript specific version of https://github.com/appsody/stacks/blob/master/incubator/nodejs-express/templates/scaffold/package.json ? Did you try? What specific issues did you encounter?

Transpilation has to occur on-change (so modified code is transpiled). That appears to me to require either a modified start script in the ts version of scaffold/package.json (should work fine), or a derived stack with one small change to https://github.com/appsody/stacks/blob/master/incubator/nodejs-express/image/Dockerfile-stack#L14

SaifRehman

comment created time in 7 days

pull request commentappsody/stacks

Typescript express stack

I'm not a typescript user, but it was my understanding that if the app was written in typescript, it could be mounted into the nodejs-express app, does that not work? The top-level app doesn't have to be written in ts itself in order to use a ts-implemented and exported app.

Alternatively, is it possible to inherit from the nodejs-express base stack image, adding only the differences?

I'm somewhat concerned about the maintainability of this, it contains a lot of copy-n-paste from nodejs-express, particularly the README, and a whole bunch of typescript boilerplate that I don't understand. Are you comitting to supporting this going forward and copying the changes over?

I'd be remiss for not mentioning that loopback was written in typescript.

cc: @raymondfeng

SaifRehman

comment created time in 8 days

more