profile
viewpoint

pokanop/nostromo 80

CLI for building powerful aliases

pokanop/homebrew-pokanop 1

🍻 Formulae for Pokanop Apps Homebrew packages

saheljalal/awesome-go 0

A curated list of awesome Go frameworks, libraries and software

saheljalal/saucy-server 0

a saucy test server

issue commentUnity-Technologies/arfoundation-samples

Body tracking arms zone has a big offset issue

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Hypnotistas

comment created time in an hour

issue commentUnity-Technologies/arfoundation-samples

[Bug] Periodic EXC_BAD_ACCESS on iOS when using WorldCameraWithUserFacingFaceTracking

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

allensanderlin

comment created time in an hour

issue commentUnity-Technologies/arfoundation-samples

[Bug] Crash after a few minutes in AR with image tracking enabled

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kjyv

comment created time in an hour

push eventapple/swift-evolution

Joe Groff

commit sha 5f79481244329ec2860951c0c49c101aef5069e7

Introduce a dedicated proposal for `with*Continuation` (#1244) * Introduce a dedicated proposal for `with*Continuation` * Updates in response to feedback - Trap on multiple resumes, rather than merely logging - Add discussion of alternatives considered, such as trapping vs logging tradeoffs, and lack of additional handle API * Add some more interesting examples from the pitch discussion * Add an example of a callback-based API respecting its parent task's cancellation state. Provided by @ktoso * Assign number, review manager Co-authored-by: Ben Cohen <airspeedswift@users.noreply.github.com>

view details

push time in 11 hours

issue commentUnity-Technologies/arfoundation-samples

Pointcloud problems on iPhone 12 Pro

Video demonstrates two point clouds made by capturing points (tracking features) from both devices. Maybe it is hard to see the problem since I haven't attached picture of actual space they were framing - I might do that to better illustrate the "ground truth".

I mean even without this kind of visualization it is obvious that there is something wrong with the tracking features on new iPhone. There are many points just floating around - not tracking any actual feature in the image (causing the mess in accumulated point cloud).

I will do a better a visualization to demonstrate there is clearly something wrong. I am not saying it is problem with AR Foundation, maybe core of the problem is in ARKit itself.

Nevertheless it just doesn't seem right. How come that old camera system does such a good job and the new one (even with LIDAR) performs so "badly" in terms of tracking features?

trandzik

comment created time in 12 hours

issue commentUnity-Technologies/arfoundation-samples

Pointcloud problems on iPhone 12 Pro

As you suggest, it is not surprising that there is a difference between devices with a LiDAR sensor and those without. However, I'm not really sure what your video is demonstrating. In our tests, the results are comparable between an iPhone 6 and 12, with the 12 generally providing a few more feature points.

Any differences are likely to be due to the device; AR Foundation just gets an array of points from ARKit.

trandzik

comment created time in 13 hours

issue commentUnity-Technologies/arfoundation-samples

ARFoundation and ARCore compatibility

Oh...
That might save me some headache. Thanks a lot! :)

mpyrk

comment created time in 14 hours

issue commentUnity-Technologies/arfoundation-samples

ARFoundation and ARCore compatibility

Yes, exactly. Google makes the "ARCore SDK for Unity" which does not use AR Foundation. It is a standalone plugin they maintain.

Unity provides the ARCore XR Plugin, which works with AR Foundation and is provided as a package.

mpyrk

comment created time in 14 hours

issue commentUnity-Technologies/arfoundation-samples

ARFoundation and ARCore compatibility

Sorry - my head is spinning... Google's ARCore SDK for Unity is one plugin and ARCore XR Plugin is something else?

mpyrk

comment created time in 14 hours

issue commentUnity-Technologies/arfoundation-samples

Update Environment Depth Image in iOS.

Environment depth on iOS requires a device with a LiDAR sensor. What device are you using?

MTL2097

comment created time in 14 hours

issue commentUnity-Technologies/arfoundation-samples

ARFoundation and ARCore compatibility

You need the ARCore XR Plugin, which is a Unity package (instructions for installing it are in the tutorial). You should not check the "ARCore Supported" checkbox.

mpyrk

comment created time in 14 hours

push eventUnity-Technologies/mono

Alex Thibodeau

commit sha f6debf5c29dc811279d75aedb10439700d37916d

Updating unityaot profile to have host specific profiles. Linux and OSX profiles are currently identical. Need to disable btls on both linux and macos

view details

push time in 14 hours

push eventUnity-Technologies/mono

Ritesh Oedayrajsingh Varma

commit sha 1ed0304f1b109cd1768048d62087f21e1b49b6c8

Added support for enumerating all methods that have been JIT compiled - Added `mono_jit_info_table_foreach`. This function can be used to enumerate all currently JIT compiled methods in a domain. - Added `mono_domain_jit_foreach`. This function internally just forwards to `mono_jit_info_table_foreach` and is only there for consistency with the existing `mono_domain_foreach`, `mono_domain_assembly_foreach` functions.

view details

Ritesh Oedayrajsingh Varma

commit sha e7721a836261e3109b5cb4232b88fd6e72637faf

Added accessors for the data needed for PDB lookup - The existing `get_pe_debug_guid` function has been updated to optionally output the path to the PDB as extracted from the PE header. The existing user of this function (`mono_ppdb_load_file`) passes NULL as argument for the new path argument. These are all the fields that are needed for PDB lookup in symbol servers and such. - Added `mono_ppdb_get_signature`, which internally just calls `get_pe_debug_guid`, but is exported - Exported the existing `mono_unity_method_get_token` function so that it can be used from profiler modules. The method token is needed for lookup of method data inside a PDB. removing whitespace change

view details

Ritesh Oedayrajsingh Varma

commit sha 4e1aeccc913ab0918e43fbec7889b53ada006401

Fixed signature of mono_jit_info_table_foreach Was using wrong type of callback func

view details

push time in 15 hours

push eventUnity-Technologies/mono

Ritesh Oedayrajsingh Varma

commit sha 139a48039944725da4a6600f321fcf6a7f201b12

Added support for enumerating all methods that have been JIT compiled - Added `mono_jit_info_table_foreach`. This function can be used to enumerate all currently JIT compiled methods in a domain. - Added `mono_domain_jit_foreach`. This function internally just forwards to `mono_jit_info_table_foreach` and is only there for consistency with the existing `mono_domain_foreach`, `mono_domain_assembly_foreach` functions.

view details

Ritesh Oedayrajsingh Varma

commit sha 35d37e1a308f5e80e5549b662e355a1cc6c77097

Added accessors for the data needed for PDB lookup - The existing `get_pe_debug_guid` function has been updated to optionally output the path to the PDB as extracted from the PE header. The existing user of this function (`mono_ppdb_load_file`) passes NULL as argument for the new path argument. These are all the fields that are needed for PDB lookup in symbol servers and such. - Added `mono_ppdb_get_signature`, which internally just calls `get_pe_debug_guid`, but is exported - Exported the existing `mono_unity_method_get_token` function so that it can be used from profiler modules. The method token is needed for lookup of method data inside a PDB. removing whitespace change

view details

Ritesh Oedayrajsingh Varma

commit sha 694ab90277c51ba3907aab3a8ebf82bbed6831e5

Fixed signature of mono_jit_info_table_foreach Was using wrong type of callback func

view details

push time in 15 hours

PR closed Unity-Technologies/mono

JIT code enumeration + PDB info

As discussed in our call yesterday, these are the minimal changes to Mono that we'd need to support Unity with Superluminal. While we're making these changes in the context of Superluminal, they should be useful for any profiler that wants to achieve similar things.

If approved, it would be great if these changes could be backported to 2018.

There are two main changes:

JIT Code Enumeration In order to support 'attach' scenarios where the user would like to profile an already-running process, a profiler module needs to have the ability to emit information for JIT code that was compiled prior to the profiler 'attaching'. In order to do this, there needs to be a way to enumerate all JIT-compiled methods. We've added a function that can do this (commit a64696e): mono_jit_info_table_foreach. This function uses the domain's jit_info_table to iterate through all JIT code for that domain and then invokes the callback function for each method.

For consistency with existing 'enumeration' functions in Mono like mono_domain_foreach and mono_domain_assembly_foreach, there is a new wrapper function mono_domain_jit_foreach that internally just forwards to mono_jit_info_table_foreach.

Questions we have with regards to this change:

  • Is this thread-safe? Other code around the JIT table works with hazard pointers, but since we're taking the domain lock before iterating through the JIT table, my understanding is that we don't need to do that here. Is that correct?
  • Does this cover all JIT cases? For example, does the JIT code for dynamic methods end up in the table?

PDB Info Mono's debug layer (mono_debug_find_method, mono_debug_lookup_source_location, etc) allows you to lookup address-to-line mappings at runtime. However, this is extremely slow and can take several seconds for even small test programs. In order to be able to lookup address-to-line mappings offline, you need info about the PDB in order to find it (path, guid, age, timestamp).

Mono already has such a function in debug-mono-ppdb.h: get_pe_debug_guid. It previously didn't return the PDB path, but we've updated it so it (optionally) does. Furthermore, a new function mono_ppdb_get_signature has been added that internally just calls get_pe_debug_guid but is exported.

The final piece of info you need to lookup address-to-line mappings in the PDB is the method token. There was already a function to get that, mono_unity_method_get_token, but it wasn't exported. We've changed it so that it is.

+51 -4

2 comments

7 changed files

rovarma

pr closed time in 15 hours

pull request commentUnity-Technologies/mono

JIT code enumeration + PDB info

Referenced staging PR: #1386 has landed

rovarma

comment created time in 15 hours

delete branch Unity-Technologies/mono

delete branch : superluminal-support-staging

delete time in 15 hours

push eventUnity-Technologies/mono

Ritesh Oedayrajsingh Varma

commit sha 7b9c6096e13f4cc3c3c1afcf654db32e5d7c14f1

Added support for enumerating all methods that have been JIT compiled - Added `mono_jit_info_table_foreach`. This function can be used to enumerate all currently JIT compiled methods in a domain. - Added `mono_domain_jit_foreach`. This function internally just forwards to `mono_jit_info_table_foreach` and is only there for consistency with the existing `mono_domain_foreach`, `mono_domain_assembly_foreach` functions.

view details

Ritesh Oedayrajsingh Varma

commit sha 6827fbe5716666a19d89af339294db7b69a5ce7d

Added accessors for the data needed for PDB lookup - The existing `get_pe_debug_guid` function has been updated to optionally output the path to the PDB as extracted from the PE header. The existing user of this function (`mono_ppdb_load_file`) passes NULL as argument for the new path argument. These are all the fields that are needed for PDB lookup in symbol servers and such. - Added `mono_ppdb_get_signature`, which internally just calls `get_pe_debug_guid`, but is exported - Exported the existing `mono_unity_method_get_token` function so that it can be used from profiler modules. The method token is needed for lookup of method data inside a PDB. removing whitespace change

view details

Ritesh Oedayrajsingh Varma

commit sha 674307a11b6ea6f6bae95e3a3673f06ab7f4e3fb

Fixed signature of mono_jit_info_table_foreach Was using wrong type of callback func

view details

Alex Thibodeau

commit sha 741c85984c4cf3c9e2509de4b048ea08f0f07a7a

Merge pull request #1386 from Unity-Technologies/superluminal-support-staging Superluminal support staging

view details

push time in 15 hours

PR merged Unity-Technologies/mono

Superluminal support staging

Copy of PR: https://github.com/Unity-Technologies/mono/pull/1369

Done so we can run CI on changes & land

+50 -3

0 comment

7 changed files

UnityAlex

pr closed time in 15 hours

push eventUnity-Technologies/mono

Alex Thibodeau

commit sha 9758c6897b9a0136d47884dc4f003382020dcbab

Updating unityaot profile to have host specific profiles. Linux and OSX profiles are currently identical.

view details

push time in 15 hours

Pull request review commentUnity-Technologies/Unity.Mathematics

Fixed the floatX property drawer to support fields inside polymorphic objects

 public override void OnGUI(Rect position, SerializedProperty property, GUIConten         {             var subLabels = Content.labels4;             var startIter = "x";-            switch (property.type[property.type.Length - 1])+            var propertyType = property.type;+            var isManagedRef = property.type.StartsWith("managedReference", StringComparison.Ordinal);+            if (isManagedRef)+            {+                var startIndex = "managedReference<".Length;+                var length = propertyType.Length - startIndex - 1;+                propertyType = propertyType.Substring("managedReference<".Length, length);+            }+            switch (propertyType[propertyType.Length - 1])

Done in b0d4bfb

bogdancu

comment created time in 16 hours

push eventUnity-Technologies/Unity.Mathematics

Bogdan Corciova

commit sha b0d4bfb2d28e73a874ea9b4204369475dabe8106

Cache the property type to avoid GC allocations

view details

push time in 16 hours

issue commentUnity-Technologies/arfoundation-samples

[Bug] URP with ARFoundation-ARKit in Unity2020.2.1f1 metal error!

We have not been able to reproduce this issue. Please log a bug with an project that reproduces the issue and post the case ID here.

weacw

comment created time in 16 hours

created tagUnity-Technologies/com.unity.probuilder

tagr-4.5.0

created time in 17 hours

Pull request review commentUnity-Technologies/Unity.Mathematics

Fixed the floatX property drawer to support fields inside polymorphic objects

 public override void OnGUI(Rect position, SerializedProperty property, GUIConten         {             var subLabels = Content.labels4;             var startIter = "x";-            switch (property.type[property.type.Length - 1])+            var propertyType = property.type;+            var isManagedRef = property.type.StartsWith("managedReference", StringComparison.Ordinal);+            if (isManagedRef)+            {+                var startIndex = "managedReference<".Length;+                var length = propertyType.Length - startIndex - 1;+                propertyType = propertyType.Substring("managedReference<".Length, length);+            }+            switch (propertyType[propertyType.Length - 1])

SubString() will allocate a string, which we definitely don't want inside the OnGUI loop. I'd suggest doing this check one time and caching the result on the drawer instance. A single drawer instance should not be used to draw more than one type, so it should be safe to do

bogdancu

comment created time in 18 hours

PR opened Unity-Technologies/Unity.Mathematics

Fixed the floatX property drawer to support fields inside polymorphic objects

This PR fixes the property drawer for float2/3/4 fields inside polymorphic objects.

Consider the following

[Serializable]
public class ConcreteValue
{
   [SerializeReference]
    public object _Value;
}

var ConcreteValue val = new ConcreteValue { _Value = new float2(1.0f, 1.0f) }; 

In this case, the SerializedProperty.type of the _Value property is managedReference<float2>.

This results in the following UI bug image

This PR fixes the parsing of the SerializedProperty type string for polymorphic objects.

+9 -1

0 comment

1 changed file

pr created time in 18 hours

create barnchUnity-Technologies/Unity.Mathematics

branch : fix-float-property-drawer

created branch time in 18 hours

PR opened Unity-Technologies/mono

Reviewers
Update vs projects to visual studio 19
+191 -179

0 comment

38 changed files

pr created time in 19 hours

more