profile
viewpoint
Deepak Sharma sadysnaat @spectrocloud

sadysnaat/AdvancedGitnGithub 0

Practice repo for Advanced Git and Github Chapter from RBND

sadysnaat/api 0

The canonical location of the Kubernetes API definition.

sadysnaat/avataaars-geneator 0

Simple generator React app for avataaars

sadysnaat/awesome-scalability 0

The Patterns Behind Scalable, Reliable, and Performant Large-Scale Systems

sadysnaat/basiccoin 0

The smallest currency I can make

sadysnaat/bigchaindb 0

A scalable blockchain database

pull request commentkubernetes-sigs/cluster-api-provider-vsphere

add keep alive support for session.TagManager rest client

This implementation leaks vim sessions as clearcache doesn't remove or logout the existing sessions just remove them from map I am working on alternate implementation will update the PR soon

sadysnaat

comment created time in 4 days

push eventspectrocloud/cluster-api-provider-vsphere

Deepak Sharma

commit sha 8e74ae28a667d6e6d1971e55a38420184d5cade1

cherry-pick vspherefailuredomain vspheredeploymentzone conversion

view details

Deepak Sharma

commit sha cc10abe67cefc5a7f7b5296e448ae439ecaca2cb

Merge pull request #19 from spectrocloud/failuredomain-v1alpha3-cherrypick cherry-pick vspherefailuredomain vspheredeploymentzone conversion

view details

push time in 5 days

PR merged spectrocloud/cluster-api-provider-vsphere

cherry-pick vspherefailuredomain vspheredeploymentzone conversion

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+139 -1

0 comment

5 changed files

sadysnaat

pr closed time in 5 days

push eventspectrocloud/cluster-api-provider-gcp

Snehal Amrutkar

commit sha 56fdf9d6ffc1d019a05cdbbbdd973f563975edd9

Resolved route delete issue

view details

Deepak Sharma

commit sha f9e752b6a77d138aa7d646fe198fc8c40d5a64fd

Merge pull request #13 from spectrocloud/routeIssue Resolved route delete issue

view details

push time in 5 days

PR merged spectrocloud/cluster-api-provider-gcp

Reviewers
Resolved route delete issue

<!-- If this is your first PR, welcome! Please make sure you read the contributing guidelines. -->

<!-- Please label this pull request according to what type of issue you are addressing (see ../CONTRIBUTING.md) --> What type of PR is this?

<!-- Add one of the following kinds: /kind feature /kind bug /kind api-change /kind cleanup /kind deprecation /kind design /kind documentation /kind failing-test /kind flake /kind other -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs: <!-- Put an "X" character inside the brackets of each completed task. Some may be optional depending on the PR. -->

  • [ ] squashed commits
  • [ ] includes documentation
  • [ ] adds unit tests

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+48 -8

0 comment

2 changed files

snehala27

pr closed time in 5 days

PR opened spectrocloud/cluster-api-provider-vsphere

cherry-pick vspherefailuredomain vspheredeploymentzone conversion

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+139 -1

0 comment

5 changed files

pr created time in 6 days

issue commentkubernetes-sigs/cluster-api-provider-vsphere

kube-apiserver cache watch failing for vspheredeploymentzone,vspherefailuredomain

thanks @srm09 for quick response and resolution

sadysnaat

comment created time in 6 days

issue openedkubernetes-sigs/cluster-api-provider-vsphere

kube-apiserver cache watch failing for vspheredeploymentzone,vspherefailuredomain

/kind bug

What steps did you take and what happened: [A clear and concise description of what the bug is.]

clusterctl4 init --infrastructure vsphere

create a vspherefailuredomain or vspheredeploymentzone object as soon as object is created api-server cacher begins watch for v1alpha3/vspherefailuredomain

E0119 13:06:02.595563       1 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list infrastructure.cluster.x-k8s.io/v1alpha3, Kind=VSphereDeploymentZone: conversion webhook for infrastructure.cluster.x-k8s.io/v1alpha4, Kind=VSphereDeploymentZone failed: *v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone; reinitializing...
E0119 13:06:03.599101       1 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list infrastructure.cluster.x-k8s.io/v1alpha3, Kind=VSphereDeploymentZone: conversion webhook for infrastructure.cluster.x-k8s.io/v1alpha4, Kind=VSphereDeploymentZone failed: *v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone; reinitializing...
E0119 13:06:04.602673       1 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list infrastructure.cluster.x-k8s.io/v1alpha3, Kind=VSphereDeploymentZone: conversion webhook for infrastructure.cluster.x-k8s.io/v1alpha4, Kind=VSphereDeploymentZone failed: *v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone; reinitializing...
E0119 13:06:05.606517       1 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list infrastructure.cluster.x-k8s.io/v1alpha3, Kind=VSphereDeploymentZone: conversion webhook for infrastructure.cluster.x-k8s.io/v1alpha4, Kind=VSphereDeploymentZone failed: *v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone; reinitializing...
E0119 13:06:06.611030       1 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list infrastructure.cluster.x-k8s.io/v1alpha3, Kind=VSphereDeploymentZone: conversion webhook for infrastructure.cluster.x-k8s.io/v1alpha4, Kind=VSphereDeploymentZone failed: *v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone; reinitializing...
E0119 13:06:07.615677       1 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list infrastructure.cluster.x-k8s.io/v1alpha3, Kind=VSphereDeploymentZone: conversion webhook for infrastructure.cluster.x-k8s.io/v1alpha4, Kind=VSphereDeploymentZone failed: *v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone; reinitializing...
E0119 13:06:08.619502       1 cacher.go:419] cacher (*unstructured.Unstructured): unexpected ListAndWatch error: failed to list infrastructure.cluster.x-k8s.io/v1alpha3, Kind=VSphereDeploymentZone: conversion webhook for infrastructure.cluster.x-k8s.io/v1alpha4, Kind=VSphereDeploymentZone failed: *v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone; reinitializing...

capv logs

I0119 13:09:04.057527       1 reflector.go:530] pkg/mod/k8s.io/client-go@v0.21.2/tools/cache/reflector.go:167: Watch close - *v1alpha4.VSphereVM total 0 items received
E0119 13:09:04.147874       1 deleg.go:144] conversion-webhook "msg"="failed to convert" "error"="*v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone"  "request"="15b7b19d-f122-4bd9-b669-3f85a74c0534"
E0119 13:09:05.149805       1 deleg.go:144] conversion-webhook "msg"="failed to convert" "error"="*v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone"  "request"="42df0c65-7485-444b-b3b5-fe245b125458"
E0119 13:09:06.153431       1 deleg.go:144] conversion-webhook "msg"="failed to convert" "error"="*v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone"  "request"="41bd12a8-85d5-4808-a02d-5ea97dc66faa"
E0119 13:09:07.156732       1 deleg.go:144] conversion-webhook "msg"="failed to convert" "error"="*v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone"  "request"="3cc76ab7-18ba-4cd1-9559-a503b8199196"
E0119 13:09:08.159709       1 deleg.go:144] conversion-webhook "msg"="failed to convert" "error"="*v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone"  "request"="33878cdd-4578-479e-b497-9cf987b0fe10"
E0119 13:09:09.163892       1 deleg.go:144] conversion-webhook "msg"="failed to convert" "error"="*v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone"  "request"="0eb457f4-4404-42e0-9007-0ec470172ee3"
E0119 13:09:10.168390       1 deleg.go:144] conversion-webhook "msg"="failed to convert" "error"="*v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone"  "request"="bf430182-d398-41ee-8bff-c83be7457cdf"
E0119 13:09:11.171952       1 deleg.go:144] conversion-webhook "msg"="failed to convert" "error"="*v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone"  "request"="c35b6a49-6065-47ac-b7a8-b8e8ac12aab4"
E0119 13:09:12.177050       1 deleg.go:144] conversion-webhook "msg"="failed to convert" "error"="*v1alpha4.VSphereDeploymentZone is not convertible to *v1alpha3.VSphereDeploymentZone"  "request"="4713bfbd-84c9-4972-911a-f4c7b0211dde"

What did you expect to happen:

api-server to not create cache for v1alpha3 vspherefailuredomain and vspheredeploymentzone

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version: v0.4.5

  • Cluster-api-provider-vsphere version: v0.8.2

  • Kubernetes version: (use kubectl version): kubectl version Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.1", GitCommit:"86ec240af8cbd1b60bcc4c03c20da9b98005b92e", GitTreeState:"clean", BuildDate:"2021-12-16T11:33:37Z", GoVersion:"go1.17.5", Compiler:"gc", Platform:"darwin/amd64"} Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-21T23:01:33Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}

  • OS (e.g. from /etc/os-release): Darwin Deepaks-MacBook-Pro.local 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:54 PST 2021; root:xnu-8019.61.5~1/RELEASE_X86_64 x86_64

created time in 7 days

PR merged spectrocloud/cluster-api-provider-vsphere

revert rest keepalive

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+4 -20

0 comment

2 changed files

sadysnaat

pr closed time in 8 days

push eventspectrocloud/cluster-api-provider-vsphere

Deepak Sharma

commit sha 214dc4caa94e74a7ba69a71334bfdd7bdb66915c

revert rest keepalive

view details

Deepak Sharma

commit sha 6c9d1b76d7bf82ac95718b0bc9cc0b7ec0cd4712

Merge pull request #18 from spectrocloud/revert-rest-keepalive revert rest keepalive

view details

push time in 8 days

PR opened spectrocloud/cluster-api-provider-vsphere

revert rest keepalive

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+4 -20

0 comment

2 changed files

pr created time in 8 days

push eventspectrocloud/cluster-api-provider-vsphere

Deepak Sharma

commit sha 32b9b14f62fb227ee171579c0cd314f86caea1e4

log instead of error

view details

Deepak Sharma

commit sha 11a1f21ef757f47e8fcc9f533574a3d9e17de1ec

Merge pull request #17 from spectrocloud/BET-3808 log instead of error

view details

push time in 20 days

PR merged spectrocloud/cluster-api-provider-vsphere

Reviewers
log instead of error

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+1 -1

0 comment

1 changed file

sadysnaat

pr closed time in 20 days

PR opened spectrocloud/cluster-api-provider-vsphere

Reviewers
log instead of error

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+1 -1

0 comment

1 changed file

pr created time in 20 days

push eventspectrocloud/cluster-api-provider-vsphere

Deepak Sharma

commit sha 32b9b14f62fb227ee171579c0cd314f86caea1e4

log instead of error

view details

push time in 20 days

create barnchspectrocloud/cluster-api-provider-vsphere

branch : BET-3808

created branch time in 20 days

push eventspectrocloud/cluster-api-provider-vsphere

Deepak Sharma

commit sha 65616cc2f59ba9b2166534624b3a668758af8274

add keep alive support for rest client

view details

Deepak Sharma

commit sha 7c666a0b60ba4464e4e8c05e238da6129f4ac7e4

feature enablekeepalive

view details

Deepak Sharma

commit sha 68f923726626a77a2dc00edcc03c4fcbf44e3fc6

Merge pull request #15 from spectrocloud/rest-keep-alive Rest keep alive

view details

push time in 21 days

PR merged spectrocloud/cluster-api-provider-vsphere

Rest keep alive

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+18 -2

0 comment

1 changed file

sadysnaat

pr closed time in 21 days

push eventspectrocloud/cluster-api-provider-vsphere

Deepak Sharma

commit sha fc16bbdad5bdd33a2248c36a2d82ffa6ce1ba774

fix reconcile owned clusters only

view details

Deepak Sharma

commit sha 7f87914473feed2fa0fb6a9342d4301f393d4724

enable filter iff namespace is specified

view details

Deepak Sharma

commit sha 13eb609633538d1d7b9eac23ec6fba49b0dcfa65

Merge pull request #16 from spectrocloud/skip-notowned-failuredomain fix reconcile owned vspheredeploymentzone only

view details

push time in 21 days

PR merged spectrocloud/cluster-api-provider-vsphere

Reviewers
fix reconcile owned vspheredeploymentzone only

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+18 -1

0 comment

1 changed file

sadysnaat

pr closed time in 21 days

push eventspectrocloud/cluster-api-provider-vsphere

Deepak Sharma

commit sha 7f87914473feed2fa0fb6a9342d4301f393d4724

enable filter iff namespace is specified

view details

push time in 21 days

PR opened kubernetes-sigs/cluster-api-provider-vsphere

add keep alive support for session.TagManager rest client

feature enablekeepalive

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it: currently session.Tagmanger is initialized separately from vim.Client and there is not keep-alive added to it. this PR adds keep-alive support to session.Tagmanager rest.Client

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+18 -2

0 comment

1 changed file

pr created time in 22 days

push eventspectrocloud/cluster-api-provider-vsphere

Deepak Sharma

commit sha 91f47ed85ad13e391575499eff27dc75f280522e

replace sort.SearchString

view details

Deepak Sharma

commit sha 7fb1f1e54bfa373637b71c48fe5efb42f7187522

fix unit-test

view details

push time in 22 days

PR opened spectrocloud/cluster-api-provider-vsphere

Reviewers
fix reconcile owned clusters only

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md
  4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests
  5. If this PR changes image versions, please title this PR "Bump <image name> from x.x.x to y.y.y." -->

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note: <!-- Write your release note:

  1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required".
  2. If no release note is required, just write "NONE". -->

+16 -1

0 comment

1 changed file

pr created time in 22 days

Pull request review commentspectrocloud/cluster-api-provider-vsphere

Rest keep alive

 func clearCache(sessionKey string) { }  // newManager creates a Manager that encompasses the REST Client for the VSphere tagging API-func newManager(ctx context.Context, client *vim25.Client, user *url.Userinfo) (*tags.Manager, error) {+func newManager(ctx context.Context, logger logr.Logger, sessionKey string, client *vim25.Client, user *url.Userinfo, feature Feature) (*tags.Manager, error) {

Thanks Deepak. Shall we open PR to upstream and have it reviewed there before merge?

Ack

sadysnaat

comment created time in 22 days

more