profile
viewpoint

s-tuli/coreclr 0

This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.

s-tuli/corefx 0

This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.

s-tuli/dev-spaces 0

Azure Dev Spaces is an Azure developer service that helps teams develop with speed on Kubernetes.

s-tuli/githubactioncomment 0

githubactioncomment

push eventAzure/dev-spaces

Anupama Tuli

commit sha 71c33f28a196cdd9fb17006c5708298e0260d34c

Updating the templates to support k8 1.16. Essentially updating the deprecated apiversions: apps/v1beta2 and extensions/v1beta1 to apps/v1 and apps/v1 respectively. Note there will be a document update needed since if there is a AKS cluster targeting version 1.16, the minimum client helm version needs to be >=2.15.1

view details

atuli

commit sha 3bc0a1fe1bd7651e54a8686339ef529f109ec2be

Merge pull request #264 from Azure/s-tuli/support1.16 Update the templates to support k8 version 1.16

view details

push time in 19 days

PR merged Azure/dev-spaces

Update the templates to support k8 version 1.16

Updating the templates to support k8 version 1.16. Essentially updating the d…eprecated apiversions: apps/v1beta2 and extensions/v1beta1 to apps/v1 and apps/v1 respectively. Note there will be a document update needed since if there is a AKS cluster targeting version 1.16, the minimum client helm version needs to be >=2.15.1

+15 -9

5 comments

9 changed files

s-tuli

pr closed time in 19 days

PullRequestEvent

pull request commentAzure/dev-spaces

Update the templates to support k8 version 1.16

Could you please clarify why PopulateDatabase doesn't need this update as well? Is there something different for this one?

https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ is the link to the deprecated apiversions documentation. kind==ingress is not impacted.

s-tuli

comment created time in 20 days

PR opened Azure/dev-spaces

Reviewers
Update the templates to support k8 version 1.16

Updating the templates to support k8 version 1.16. Essentially updating the d…eprecated apiversions: apps/v1beta2 and extensions/v1beta1 to apps/v1 and apps/v1 respectively. Note there will be a document update needed since if there is a AKS cluster targeting version 1.16, the minimum client helm version needs to be >=2.15.1

+15 -9

0 comment

9 changed files

pr created time in 20 days

create barnchAzure/dev-spaces

branch : s-tuli/support1.16

created branch time in 20 days

issue openedmicrosoft/ApplicationInsights-dotnet

AddFilter not working for ApplicationInsightsLoggerProvider. Duplicate Events logged while using: .ConfigureLogging(logging => logging.SetMinimumLevel(LogLevel.Warning))

My goal: (I am using Microsoft.Extensions.Logging.ApplicationInsights 2.9.1)

  • Filter to LogLevel.Information for any CategoryName

  • but when CategoryName contains "Microsoft", I would like the LogLevel to be LogLevel.Warning

Here's a snippet from: startup.cs public static void ConfigureServices(IServiceCollection services) { services.AddSingleton<ITelemetryInitializer, OperationParentIdTelemetryInitializer>(); services.AddLogging(loggingBuilder => {
loggingBuilder.AddFilter<ApplicationInsightsLoggerProvider>("", LogLevel.Information); loggingBuilder.AddFilter<ApplicationInsightsLoggerProvider>("Microsoft", LogLevel.Warning); loggingBuilder.AddApplicationInsights(<AIkey>); }); services.AddApplicationInsightsTelemetry();
} Result:

  • AddFilter does not work.

  • I made the filter work by adding .ConfigureLogging(logging => logging.SetMinimumLevel(LogLevel.Warning)): to my service class.

  • I am seeing 2 logs for each call: _logger.LogCritical(<some telemetry content>); ... return new WebHostBuilder() .UseKestrel() .ConfigureServices( services => services .AddSingleton<StatelessServiceContext>(serviceContext)) .UseContentRoot(Directory.GetCurrentDirectory()) .UseStartup<Startup>() .ConfigureLogging(logging => logging.SetMinimumLevel(LogLevel.Warning)) .UseServiceFabricIntegration(listener, ServiceFabricIntegrationOptions.None) .UseUrls(url) .Build(); }))

Any pointers?

created time in 2 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha ca80b389404ca3f0b1677d77cf57d672074bd12d

trig

view details

atuli

commit sha 5bc33a525fdcde8f6709e1156e86e699df3a151f

Merge pull request #36 from s-tuli/anutuli/versioning trig

view details

push time in 2 months

PR merged s-tuli/dev-spaces

trig
+2 -2

0 comment

2 changed files

s-tuli

pr closed time in 2 months

PR opened s-tuli/dev-spaces

trig
+2 -2

0 comment

2 changed files

pr created time in 2 months

create barnchs-tuli/dev-spaces

branch : anutuli/versioning

created branch time in 2 months

PR opened s-tuli/dev-spaces

update values.yaml
+1 -2

0 comment

1 changed file

pr created time in 2 months

PR closed Azure/dev-spaces

S tuli/test
+199 -10

0 comment

6 changed files

s-tuli

pr closed time in 2 months

PR opened Azure/dev-spaces

S tuli/test
+199 -10

0 comment

6 changed files

pr created time in 2 months

create barnchs-tuli/dev-spaces

branch : s-tuli/test

created branch time in 2 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 827d445c50cd69ad7b803282d050a1606fda91af

trig

view details

Anupama Tuli

commit sha 606f7e4fd6817122aa01e4eab087fd2209190977

trig

view details

Anupama Tuli

commit sha 9339fdc2c4c86285637037e6a9af0b748f754a07

trig

view details

Anupama Tuli

commit sha b4a5559589719d4ca32d5c3d14922646ee18a1bc

trig

view details

Anupama Tuli

commit sha e0eaf9c182cddfb48225509ba7de977ad72e8511

trig

view details

Anupama Tuli

commit sha 3242534cbecc5d883cd48d5f1763304bad2db0d3

trig

view details

Anupama Tuli

commit sha be0835d99ce562650ffaa682c7ad11975ad62298

trig

view details

Anupama Tuli

commit sha 0104d94a58bbaecda70d26e311e086a9dd26b8e8

trig

view details

Anupama Tuli

commit sha a7aa8d88551567d8196c50a07f1dfb0228c31e90

trig

view details

Anupama Tuli

commit sha 73ae6950f21c9e84d93d48d6a520bcff892ae880

trig

view details

Anupama Tuli

commit sha 2e69ee91837e0242c5a98e5dbda7759e6a24d41b

trig

view details

Anupama Tuli

commit sha 56d333fea90e8dd846feebbbb7944e1457d5b2d4

trig

view details

Anupama Tuli

commit sha 17849a77e062c0a9e29c09b9c416cf3afe320b3d

trig

view details

Anupama Tuli

commit sha b32708919d6f10b02a5f419a502af48929cbb127

trig

view details

Anupama Tuli

commit sha 470a6350ecf68d509fa8916e0fe1c7be50fae55d

trig

view details

Anupama Tuli

commit sha 090f5d4fb053fbbf76754d0a9f4ed8ba45d27045

trig

view details

Anupama Tuli

commit sha 16871b041410349008b90c74b71ad8065c8e7af0

trig

view details

Anupama Tuli

commit sha e828e04270fa8ade91ad48580abdfeb5816c7d8d

trig

view details

Anupama Tuli

commit sha 5fa7a2f8e86de7b87aea47edace0613f76e8c7d9

trig

view details

Anupama Tuli

commit sha e0e265bf372f21cd732837f73e0d0b8b33d42675

trig

view details

push time in 2 months

PR merged s-tuli/dev-spaces

trig
+52 -22

48 comments

3 changed files

s-tuli

pr closed time in 2 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 3ec3fc51d120b35db03fb09ccd0d99495fbc4c3e

update values.yaml

view details

push time in 2 months

push eventAzure/dev-spaces

Anupama Tuli

commit sha 7f5f44e1337651988c4ab0ff1b48cb96c855f24b

Update Readme.md to be in sync with action add-review-url@ Releases/v2

view details

atuli

commit sha 3e87a8229fc735de855b899a8c578603d561ba7b

Merge pull request #212 from Azure/s-tuli/updateactionreadme Update Readme.md to be in sync with action add-review-url@ Releases/v2

view details

push time in 2 months

push eventAzure/dev-spaces

Anupama Tuli

commit sha a89d56057bddff70fe7f7142a7a69bfd19dbdc7a

Update the workflow template to be in sync with bikes.yml and the updates that were recently made

view details

atuli

commit sha 4276bfdb6dfadf6acc233bcdb38557f176230d5a

Merge pull request #213 from Azure/s-tuli/updateTemplate Update the workflow template to be in sync with bikes.yml and the upd…

view details

push time in 3 months

PR merged Azure/dev-spaces

Reviewers
Update the workflow template to be in sync with bikes.yml and the upd…

Update the workflow template to be in sync with bikes.yml and the updates that were recently made

+54 -13

0 comment

1 changed file

s-tuli

pr closed time in 3 months

PR opened Azure/dev-spaces

Update the workflow template to be in sync with bikes.yml and the upd…

Update the workflow template to be in sync with bikes.yml and the updates that were recently made

+54 -13

0 comment

1 changed file

pr created time in 3 months

create barnchAzure/dev-spaces

branch : s-tuli/updateTemplate

created branch time in 3 months

create barnchAzure/dev-spaces

branch : s-tuli/updateactionreadme

created branch time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 8b6b2ad546bcbf79e84d363c6e350f6fb287aa1c

test

view details

push time in 3 months

create barnchAzure/dev-spaces

branch : Releases/v2

created branch time in 3 months

push eventAzure/dev-spaces

Anupama Tuli

commit sha d7eecaf827348ef51828391aa42807c15911adce

Update bikes.yml by adding a new step that updates the user's branch name such that a valid namespace can be created using that. This also needs an update to the existing add-review-url custom action. There is a new input that is passed in to this action to construct the url which contains the valid child namespace. Note: there is another update needed such that we call the version2 of the custom github action: add-review-url@Releases/v2

view details

Anupama Tuli

commit sha 9b13d7d596f91ccf5fc199cc6d04e382a15662a2

Merging from master

view details

Anupama Tuli

commit sha 479903f087d0af0068348fcc305e038a99d0cf50

Address Pr feedback. Update the length to 41 as allowed by namespace name specs and Release spec for the Helm install command in bikes.yml. Update some of the variable names. Tested E2E. This will need a Release/v2 branch which will contain node_modules as well.

view details

Anupama Tuli

commit sha 01b23a8df76c3ee752987dd2b344db66ea843479

Update the output parameter name

view details

Anupama Tuli

commit sha 7cf7b541326b2206feb316ccd32510459f47cf0d

Add optional parameter: protocol for the custom github action: add-review-url such that the user specifies http vs https as needed. If not specified the protocol defaults to http. Update bikes.yml to add a step for installing helm for client if client and server version does not match. Add a step to create a valid release-name based on spec for the same by formatting the GITHUB_HEAD_REF environment variable.

view details

Anupama Tuli

commit sha 8ab742499888fb7b074737b1d3abf00118f3bdc1

Addressing PR feedback. Code clean-up. Using a temporary directory for installing Helm into in case the client version does not match the server version.

view details

Anupama Tuli

commit sha 011fec917fe3b20538f8b8fe690c8f55d6b21473

Merge branch 'master' of https://github.com/Azure/dev-spaces into s-tuli/childnamespaceUpdate

view details

Anupama Tuli

commit sha 41af60fe5c1c1c91f787b33331f4ed955baf81e4

Update the step:Create 'child namespaces and add Dev Spaces labels' and clean-up and make it faster by updating the command-kubectl label namespace

view details

Anupama Tuli

commit sha b7f84e1c76afcf0beb163beb1e7d18eb595f97e2

Update the name of the output for the step: Install Helm for client

view details

Anupama Tuli

commit sha a4c40877d53ec0d44e40de303588b16b9834ebfa

Indenting the commands post kubectl label namespace command in the step: Create child namespaces and add Dev Spaces labels

view details

atuli

commit sha d4e9c8d28a716700c087547e7474dd3d1282ab8a

Merge pull request #204 from Azure/s-tuli/childnamespaceUpdate Update bikes.yml by adding a new step that updates the user's branch …

view details

push time in 3 months

PR merged Azure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

Update bikes.yml by adding a new step that updates the user's branch name such that a valid namespace can be created using that. This also needs an update to the existing add-review-url custom action. There is a new input that is passed in to this action to construct the url which contains the valid child namespace. Note: there is another update needed such that we call the version2 of the custom github action: add-review-url@Releases/v2

+71 -24

0 comment

5 changed files

s-tuli

pr closed time in 3 months

push eventAzure/dev-spaces

Anupama Tuli

commit sha a4c40877d53ec0d44e40de303588b16b9834ebfa

Indenting the commands post kubectl label namespace command in the step: Create child namespaces and add Dev Spaces labels

view details

push time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}} \+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} \+        azds.io/parent-space=${{ secrets.MASTER_SPACE }} \

Updated

s-tuli

comment created time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 3548f0969516c2a35b87945f2f7365904d22e0d2

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 501a5a48c537cf546b79cc407b2f65d0e30efd19

test

view details

push time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')+        serverversion=$(echo $(helm version --server --short) | sed -n 's/.*Server: \(.*\)+.*/\1/p')+        if [[ ! -n "$serverversion" ]];+        then+          echo "Please install Helm on the server!" 1>&2+          exit 64+        elif [[ "$clientversion" == "$serverversion" ]]; +        then   +          echo "Versions are equal"+          echo ::set-output name=result::+        else+          mkdir prflow        +          export DESIRED_VERSION=$serverversion export HELM_INSTALL_DIR=./prflow+          curl https://raw.githubusercontent.com/helm/helm/master/scripts/get > get_helm.sh+          chmod 700 get_helm.sh+          ./get_helm.sh+          echo ::set-output name=result::./prflow/

Updated the name of the output variable as helm and the value to be the path to helm

s-tuli

comment created time in 3 months

push eventAzure/dev-spaces

Anupama Tuli

commit sha b7f84e1c76afcf0beb163beb1e7d18eb595f97e2

Update the name of the output for the step: Install Helm for client

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 50bde7a0d82d7487ea35515d3cf3e2b9204519d3

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 92d3c5716f65034e115c898c897d8ee2a91f2598

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha f3dadae8b3c5a4b54b5b2b49ed6ac2140d30554a

test

view details

push time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')+        serverversion=$(echo $(helm version --server --short) | sed -n 's/.*Server: \(.*\)+.*/\1/p')+        if [[ ! -n "$serverversion" ]];+        then+          echo "Please install Helm on the server!" 1>&2+          exit 64+        elif [[ "$clientversion" == "$serverversion" ]]; +        then   +          echo "Versions are equal"+          echo ::set-output name=result::+        else+          mkdir prflow        +          export DESIRED_VERSION=$serverversion export HELM_INSTALL_DIR=./prflow+          curl https://raw.githubusercontent.com/helm/helm/master/scripts/get > get_helm.sh+          chmod 700 get_helm.sh+          ./get_helm.sh+          echo ::set-output name=result::./prflow/

Updated 'result' to 'install-location'

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} 

Updated. Sounds good.

s-tuli

comment created time in 3 months

push eventAzure/dev-spaces

Shruti

commit sha 09615dc566caec12ed458c7ea4ad576779f0ceb1

Upload public ips for all regions

view details

Shruti

commit sha fa679981bb7a46e8b6f621b73d634efeb7421e76

Update

view details

Shruti

commit sha e2bd9d90745c51eca32070e5ae7dfd926520dbb3

Change to IP range

view details

Shruti

commit sha a8978920fb1014a7b238883bea7e73780e999565

Added a readme

view details

Philo

commit sha 04b73e251d7ad5b985ea5354db13a3791b54c089

Merge pull request #210 from ShrutiPPathak/public_ips Public ips

view details

Anupama Tuli

commit sha 011fec917fe3b20538f8b8fe690c8f55d6b21473

Merge branch 'master' of https://github.com/Azure/dev-spaces into s-tuli/childnamespaceUpdate

view details

Anupama Tuli

commit sha 41af60fe5c1c1c91f787b33331f4ed955baf81e4

Update the step:Create 'child namespaces and add Dev Spaces labels' and clean-up and make it faster by updating the command-kubectl label namespace

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 02cee73ca10e18c760071a3e0e2dff94c02766f6

test

view details

push time in 3 months

push eventAzure/dev-spaces

Anupama Tuli

commit sha 8ab742499888fb7b074737b1d3abf00118f3bdc1

Addressing PR feedback. Code clean-up. Using a temporary directory for installing Helm into in case the client version does not match the server version.

view details

push time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')+        serverversion=$(echo $(helm version --server --short) | sed -n 's/.*Server: \(.*\)+.*/\1/p')+        if [[ ! -n "$serverversion" ]];+        then+          echo "Please install Helm on the server!" 1>&2+          exit 64+        elif [[ "$clientversion" == "$serverversion" ]]; +        then   +          echo "Versions are equal"+          echo ::set-output name=result::+        else+          mkdir prflow        +          export DESIRED_VERSION=$serverversion export HELM_INSTALL_DIR=./prflow+          curl https://raw.githubusercontent.com/helm/helm/master/scripts/get > get_helm.sh

Updated. Non-zero exit code does fail the script though.

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')+        serverversion=$(echo $(helm version --server --short) | sed -n 's/.*Server: \(.*\)+.*/\1/p')+        if [[ ! -n "$serverversion" ]];+        then+          echo "Please install Helm on the server!" 1>&2+          exit 64

I saw this online on stackoverflow: https://stackoverflow.com/questions/30078281/raise-error-in-a-bash-script. That said, It need not be 64. Any non-zero exit code should do. Changed it to 1.

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')

clientversion=$(helm version --client --short | cut -d' ' -f2) ... does not work because this command does not give us the version number which we need in the subsequent steps. I modified it (and similarly for serverversion) to: clientversion=$(helm version --client --short | cut -d' ' -f2 | cut -d'+' -f1)

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')+        serverversion=$(echo $(helm version --server --short) | sed -n 's/.*Server: \(.*\)+.*/\1/p')+        if [[ ! -n "$serverversion" ]];

Updated. Thanks. (Was adding 'then' on the next line for readability.)

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}

Updated. Good catch. Thanks.

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')+        serverversion=$(echo $(helm version --server --short) | sed -n 's/.*Server: \(.*\)+.*/\1/p')+        if [[ ! -n "$serverversion" ]];+        then+          echo "Please install Helm on the server!" 1>&2+          exit 64+        elif [[ "$clientversion" == "$serverversion" ]]; +        then   +          echo "Versions are equal"+          echo ::set-output name=result::+        else+          mkdir prflow        +          export DESIRED_VERSION=$serverversion export HELM_INSTALL_DIR=./prflow

Since we have so many lines in bikes.yml, I had intentionally put these on the same line. I meant to remove the second 'export'. Updated.

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')+        serverversion=$(echo $(helm version --server --short) | sed -n 's/.*Server: \(.*\)+.*/\1/p')+        if [[ ! -n "$serverversion" ]];+        then+          echo "Please install Helm on the server!" 1>&2+          exit 64+        elif [[ "$clientversion" == "$serverversion" ]]; +        then   +          echo "Versions are equal"+          echo ::set-output name=result::+        else+          mkdir prflow        

Done

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')+        serverversion=$(echo $(helm version --server --short) | sed -n 's/.*Server: \(.*\)+.*/\1/p')+        if [[ ! -n "$serverversion" ]];+        then+          echo "Please install Helm on the server!" 1>&2+          exit 64+        elif [[ "$clientversion" == "$serverversion" ]]; +        then   +          echo "Versions are equal"+          echo ::set-output name=result::+        else+          mkdir prflow        +          export DESIRED_VERSION=$serverversion export HELM_INSTALL_DIR=./prflow+          curl https://raw.githubusercontent.com/helm/helm/master/scripts/get > get_helm.sh+          chmod 700 get_helm.sh+          ./get_helm.sh+          echo ::set-output name=result::./prflow/

"The name result makes more sense if its value is the path to the helm executable though." It is the path to the helm executable. Leaving this as is for now.

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:         creds: '${{ secrets.AZURE_CREDENTIALS }}'         cluster-name: ${{ secrets.CLUSTER_NAME }}         resource-group: ${{ secrets.RESOURCE_GROUP }}-                ++    - name: Create valid child namespace name+      id: generate-child-space-name+      run: |+        branch=${GITHUB_HEAD_REF::63}        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$branch         +         - name: Create child namespaces and add Dev Spaces labels       run:  |-        if [ -n "$(kubectl get namespace $GITHUB_HEAD_REF --ignore-not-found -o name)" ]; then exit 0; fi-        kubectl create namespace $GITHUB_HEAD_REF-        kubectl label namespace $GITHUB_HEAD_REF azds.io/parent-space=${{ secrets.MASTER_SPACE }} -        kubectl label namespace $GITHUB_HEAD_REF azds.io/space=true-        kubectl label namespace $GITHUB_HEAD_REF azds.io/pull-request-space=true+        if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi+        kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }} +        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true+        kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true              - uses: azure/k8s-actions/k8s-create-secret@master       with:-        namespace: ${{ github.head_ref }}+        namespace: ${{ steps.generate-child-space-name.outputs.result }}         container-registry-url: ${{ secrets.CONTAINER_REGISTRY }}         container-registry-username: ${{ secrets.REGISTRY_USERNAME }}         container-registry-password: ${{ secrets.REGISTRY_PASSWORD }}         secret-name: ${{ secrets.IMAGE_PULL_SECRET }}-        -    - name: Helm Install PR++    - name: Create valid release-name+      id: generate-release-name       run: |-        helm init --upgrade --wait-        helm upgrade --install --namespace $GITHUB_HEAD_REF bikesharing-$GITHUB_HEAD_REF samples/BikeSharingApp/Bikes/charts/bikes \+        release=${bikesharing-$GITHUB_HEAD_REF}+        release=${release::53}+        release=$(echo ${release//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed -e 's/^-/z/' -e 's/-$/z/')+        echo ::set-output name=result::$release++    - name: Install Helm for client+      id: install-helm-client+      run: |+        clientversion=$(echo $(helm version --client --short) | sed -n 's/.*Client: \(.*\)+.*/\1/p')+        serverversion=$(echo $(helm version --server --short) | sed -n 's/.*Server: \(.*\)+.*/\1/p')+        if [[ ! -n "$serverversion" ]];+        then+          echo "Please install Helm on the server!" 1>&2+          exit 64+        elif [[ "$clientversion" == "$serverversion" ]]; +        then   +          echo "Versions are equal"+          echo ::set-output name=result::+        else+          mkdir prflow        +          export DESIRED_VERSION=$serverversion export HELM_INSTALL_DIR=./prflow+          curl https://raw.githubusercontent.com/helm/helm/master/scripts/get > get_helm.sh+          chmod 700 get_helm.sh+          ./get_helm.sh+          echo ::set-output name=result::./prflow/+        fi++    - name: Helm Upgrade PR+      run: |        +        ${{steps.install-helm-client.outputs.result}}helm upgrade --install --namespace ${{steps.generate-child-space-name.outputs.result}} ${{steps.generate-release-name.outputs.result}} samples/BikeSharingApp/Bikes/charts/bikes \

Updated. I moved the --install option to a separate line as well.

s-tuli

comment created time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 320472bf03be7709c31579b70d57f06308d34dd2

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha e39e20264aa71142138897899296b624de4ecc71

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 0ea57d3787d6e249481a015a0cbb8daa65833319

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 179a2dd478ba738a638c2db148a0841f4ce02abf

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 8786cf2e621398d23707e37f4c3128f1d2072b9a

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha acb0469ea311a7451f0c91f713e7d67d305298ba

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 819deb3b9bf2a725416c3ef6ebd765b781d65834

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha d9939f11ecd426be4cc9619472b7dec04f2c89c9

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 64f4ab21fa07b5650e734536ec35d0658cc6ca48

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha ecb1a0680582f108bdd7ec8b78d810faa9024753

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha c05cac2d0339d51c6f350d3dde6d5d9050566860

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 5d4d67335fd3de7516c90fbef161bc27275739f5

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 34cab22184c030cb9b439a057846e4bcfe3a1d7a

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 52cccadc68b8eece64c21782d9692f8ed7b27f15

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 302757ce8c347ab70a32ba34ec2b01a43822ca0a

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha e4d3159b2c89e0ede2cfa9a1b88457e10f8bd02a

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 3f1dbc03de11a8574bf5565d378b10c1b381c67a

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 31a818e04af483c064c7959c6e5b8a8e9513778c

test

view details

push time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 jobs:     steps:          - uses: actions/checkout@master-    ++    - name: Create valid child namespace name+      id: replace+      run: |+        branch=$GITHUB_HEAD_REF        +        branch=$(echo ${branch//[!0-9a-zA-Z]/-} | tr '[:upper:]' '[:lower:]' | sed '/^[-]/ s/./n/' | sed '/[-]$/ s/-$/n/')

Added a new step for constructing release-name from the environment variable GITHUB_HEAD_REF and honoring the helm 'release-name' spec.

s-tuli

comment created time in 3 months

Pull request review commentAzure/dev-spaces

Update bikes.yml by adding a new step that updates the user's branch …

 function run() {         const addComment = new AddReviewUrl_1.default();
         try {
             const host = core.getInput('host');
-            let headref = process.env.GITHUB_HEAD_REF || '';
+            let headref = core.getInput('child-namespace') || '';
             const comment = `You can see a private version of the changes made in this pull request here:\nhttp://${headref}.s.${host}/`;

Added an additional optional parameter for the custom action which defaults to http.

s-tuli

comment created time in 3 months

push eventAzure/dev-spaces

Anupama Tuli

commit sha 7cf7b541326b2206feb316ccd32510459f47cf0d

Add optional parameter: protocol for the custom github action: add-review-url such that the user specifies http vs https as needed. If not specified the protocol defaults to http. Update bikes.yml to add a step for installing helm for client if client and server version does not match. Add a step to create a valid release-name based on spec for the same by formatting the GITHUB_HEAD_REF environment variable.

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha ba0deecf046a0f16b93870eb4c2510a800a646ce

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 1f00c2cc8b4a7039012b2e6716f917d03c091609

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha e323150f4c8c5d18d085c0d758e6e3b3727a0ed2

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 815b31194be3fcc9824389543fa643ec6cd3f14e

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha b44e585dbcd263f542cc13ba52bdccd6211e9035

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha a8aa5f9af07906a1edc863d575aa2c0242cb1262

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 4346735d552076bc24ec5df788fe762af37d7a7a

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 1d10b848d70655e07bacb3574327f3b2f3ba8bb3

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 20f388562f903a811aa0cd40af06ced7b484a264

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 66f181e83276518e9eee2d8ac6387307644b9510

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha c8738ca33e8899bfd2a7ce9a35885237fb7b51d9

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha e2093a360e88f1692317666a1d33d446267fab42

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 106d1bfda0411e467609bc650a416f2593cb4d4e

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 13a12f7d27499ca4abc1127845f400e80c424801

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha a77752ba09961ed6f832fefb65b11348d1d1891f

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 15f439ec67a2eb832c2e58114bf1cbd1d881f89f

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 6a71834c9c639280998a80bcd23258f076df68c0

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha adc702d02ea45e8bc3267cd9d2b5150c7544a8d8

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha a2148a6b4758f0c10a911e2c677110f1229a96bf

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha be2eee9dc5ad85d5e4f91674359b51f9984b675e

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 3eb1b633138bf8cf5eef7fd9718cc84480cf8a96

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 45265c2d3ac13e22f2ea71263a81ef36eb7c763f

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha e4279831cee4c6268b8d599d5a58fd2bfc06bc06

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha 623cdae59f66b45f679438c4ea3abbfb1ff42fdb

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha ae697ac02b10301a4ad52d0a5ae551e8c769e826

test

view details

push time in 3 months

push events-tuli/dev-spaces

Anupama Tuli

commit sha b64d3323b6b7bd575c7dee0114757c51bbf2ff0d

test

view details

push time in 3 months

more