profile
viewpoint
Rustie Lin rustielin @novifinancial Berkeley, CA rustie.xyz Productionizing @libra core. Previously @BerkeleyBlockchain

rustielin/Blockchain-Notes 22

Meticulous notes on various topics in cryptography, cryptocurrencies, and blockchain based on Blockchain at Berkeley's Spring 2017 "Introduction to Cryptocurrencies and Blockchain" course.

rustielin/blockshell 9

🎉 Minimal Blockchain Learning CLI

indexofknowledge/iok 4

Index of Knowledge

rustielin/atom-image-paste 3

Pastes images from your clipboard into atom. Supports various filetypes

rustielin/DEEPSus 2

GCP/OSI/everything

glowang/FocusNow 1

Google chrome extension that prevents users from wasting time on social media websites that they idenitfy.

rustielin/awesome-blockchain 1

⚡️Curated list of resources for the development and applications of blockchain.

rustielin/Cadence 1

Minimal Chrome new tab markdown editor, for quick notes. Inspired by Moment, by Siebe Van Dijck

rustielin/Command-Utils 1

Some useful utils, mostly for classes

rustielin/cytoscape-rust-wasm 1

Utility for writing network simulations in Rust, compiling to WebAssembly, and displaying graphics with CytoscapeJS

issue closedlibra/libra

[roar] remove terraform dependency

Just use a series of aws cli calls, especially after https://github.com/libra/libra/issues/4481, rather than relying on terraform show. This reduces permissions required to run roar test and makes it more portable (no longer have to use terraform working directory.)

closed time in 12 days

rustielin

issue commentlibra/libra

[roar] remove terraform dependency

this is not longer supported

rustielin

comment created time in 12 days

push eventlibra/libra

dependabot[bot]

commit sha f3f3615695317efde359fcd92c95c5902078033f

Bump handlebars from 3.4.0 to 3.5.0 Bumps [handlebars](https://github.com/sunng87/handlebars-rust) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/sunng87/handlebars-rust/releases) - [Changelog](https://github.com/sunng87/handlebars-rust/blob/v3.5.0/CHANGELOG.md) - [Commits](https://github.com/sunng87/handlebars-rust/compare/v3.4.0...v3.5.0) Signed-off-by: dependabot[bot] <support@github.com> Closes: #6183

view details

dependabot[bot]

commit sha 793d1c1ea40fff3222100078c5aa95ee31e993a5

Bump serde-generate from 0.14.1 to 0.14.2 Bumps [serde-generate](https://github.com/novifinancial/serde-reflection) from 0.14.1 to 0.14.2. - [Release notes](https://github.com/novifinancial/serde-reflection/releases) - [Commits](https://github.com/novifinancial/serde-reflection/commits) Signed-off-by: dependabot[bot] <support@github.com> Closes: #6136

view details

dependabot[bot]

commit sha 330a53213c29455ebe7cd6675a941b0522589ef8

Bump actions/setup-node from v1 to v2.1.1 Bumps [actions/setup-node](https://github.com/actions/setup-node) from v1 to v2.1.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/v1...321b6ccb03083caa2ad22b27dc4b45335212e824) Signed-off-by: dependabot[bot] <support@github.com> Closes: #6159

view details

dependabot[bot]

commit sha a8205421d7546df2815b7e0546b700a4a9f2bc4d

Bump structopt from 0.3.17 to 0.3.18 Bumps [structopt](https://github.com/TeXitoi/structopt) from 0.3.17 to 0.3.18. - [Release notes](https://github.com/TeXitoi/structopt/releases) - [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) - [Commits](https://github.com/TeXitoi/structopt/compare/v0.3.17...v0.3.18) Signed-off-by: dependabot[bot] <support@github.com> Closes: #6184

view details

Brandon Williams

commit sha 025d5e47a5a086c1f7357a53b794395cb853d701

website: update 'bl' to 1.2.3 Update the javascript package 'bl' to version 1.2.3 in order to fix the vulnerablility present in 1.2.2. Closes: #6188

view details

Brandon Williams

commit sha ee069585eab04be6459ec1c1e42adeacb2825dd4

ci: skip 'diff LEC summary' step for bors Skip the 'diff LEC summary' step of the 'Dependency Notifier' action when bors is the user. This should remove the spurious failure when bors lands a PR. Closes: #6191

view details

Rex Hoffman

commit sha e78669c3988516e737e4552f56c376c71f72eb88

[gha] remove temp hack to make dep-summaries work Closes: #6190

view details

Tim Zakian

commit sha ee744dc1bea277b76af2fbdaa2719add040dde96

[json-rpc][libra framework] Add human-readable explanation for Move aborts to json-rpc Closes: #5854

view details

Joshua Lind

commit sha e36f161bd6f81972e21f3f0f6f8b9e528d359340

[Smoke Tests] Split up massive smoke-tests.rs file into components.

view details

Joshua Lind

commit sha 7fd293530b5ac117fbe72100ca8470b4175f19c5

[Smoke Tests] Rename TestEnvironment to SmokeTestEnvironment. Closes: #6158

view details

Brandon Williams

commit sha d5d626fc39a0bdc8cda3e56d3467acadd24f259f

swarm: require paths to binaries

view details

Brandon Williams

commit sha c55f5e9fac06b9359080b773a4452331bca35205

swarm: better error message when a process was failed to be started Closes: #6154

view details

Junkil Park

commit sha 5d97b0b0c90d857ed959484d5c41706ac9fb1253

Update install-boogie.sh upgrade the version of boogie to 2.7.30 Closes: #6192

view details

Greg Nazario

commit sha a21d7223cc2fda451b4ead8f278e7e01fb9d3ef0

[logging] Add support for display/debug structured log fields Many times the identifier based one off structured logs require conversion of objects to debug or strings before using, and cannot be displayed with the serializer. Debug can now be used by putting a ? before the identifier, and a % before the identifier for display. Closes: #6151

view details

Wolfgang Grieskamp

commit sha 6cf1303e291624ab5e91d3becb541c26107e05cf

[docgen] Support for overview documentation. This PR adds support for overview documentation to the documentation generator. An overview is provided via a template file in markdown format. This markdown is subject to all the processing we do for Move documentation comments (automatic referencing, highlighting, and section organization). The template can also contain placeholders for generated documentation content: ``` > {{move-include NAME_OF_MODULE_OR_SCRIPT}} > {{move-toc}} > {{move-index}} ``` See a strawmann [overview template](https://github.com/wrwg/libra/blob/script_doc/language/stdlib/transaction_scripts/overview_template.md) for transaction scripts ([rendered form](https://github.com/wrwg/libra/blob/script_doc/language/stdlib/transaction_scripts/doc/overview.md)) for more details. The implementation also works for overviews for modules in the Libra framework, and a strawman template has been added there as well. Even without further documentation, the automatically genearted index of all scripts/modules is useful. Technical details: - New default for documentation generation is to place specs together with implementations instead of a separate section. This is for now a flag-controlled experiment. Bugs needed to be fixed to make this unused feature work. - Boilerplate for script documentation has been removed, exploiting that they can contain only one function. - Removed the restriction that the spec-lang enviroment can contain only one script. This makes generation of script documentation more efficient because they can be all done in one run. Closes: #6185

view details

Greg Nazario

commit sha 100f69f9a0bba0c87b062eb4a27155c544cbd4ee

[network] Make NetworkContext serialize consistently NetworkContext wasn't serializing Private networks into a single string like it would for validator and public networks. Now, it'll serialize them all into a string for logs. Closes: #6174

view details

David Wolinsky

commit sha 8f10e641695fbc5c04eaf37a4a8b2d37d3e50731

Some tweaks to the documentation layout * Removed a duplicate CONTRIBUTING.md * Moved the contributing docs into documentation * Moved tech-papers into documentation (we should discuss if specifications should go in there too) Closes: #6193

view details

aldenhu

commit sha f1046eaf7984906f2d0c8c908e0b0157068763d6

trivial: downgrade "system counter missing" error log to warning Closes: #6180

view details

Wolfgang Grieskamp

commit sha 05b05e35269ca215989d35d0d710a86013073417

[move-prover] Sorting deps. This PR sorts automatically computed dependencies by simple file name. This should help to avoid unnecessary SMT non-determinism in tests. Closes: #6202

view details

rustielin

commit sha fabc68e8b96c0712ba54b67fe591981560babf81

[codebuild] deal with download failed Closes: #6195

view details

push time in 13 days

pull request commentlibra/libra

[json-rpc] CORS: allowing all origins for the interface

How do we verify that this works? I just built an image from this PR and deployed to a testnet: http://rustielin.aws.hlw3truzy4ls.com/

Curl is not returning the right headers I think:

$ ▶ curl -d '{"jsonrpc": "2.0", "method": "get_account", "params": ["000000000000000000000000000000dd"]}' -H 'Content-Type: application/json' -i --verbose http://rustielin.aws.hlw3truzy4ls.com/
*   Trying 64:ff9b::2ce6:4e4e...
* TCP_NODELAY set
* Connected to rustielin.aws.hlw3truzy4ls.com (64:ff9b::2ce6:4e4e) port 80 (#0)
> POST / HTTP/1.1
> Host: rustielin.aws.hlw3truzy4ls.com
> User-Agent: curl/7.64.1
> Accept: */*
> Content-Type: application/json
> Content-Length: 91
>
* upload completely sent off: 91 out of 91 bytes
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< Date: Wed, 30 Sep 2020 20:30:57 GMT
Date: Wed, 30 Sep 2020 20:30:57 GMT
< Content-Type: application/json
Content-Type: application/json
< Content-Length: 1159
Content-Length: 1159
< Connection: keep-alive
Connection: keep-alive

<
* Connection #0 to host rustielin.aws.hlw3truzy4ls.com left intact
{"libra_chain_id":3,"libra_ledger_version":486588,"libra_ledger_timestampusec":1601497857028863,"jsonrpc":"2.0","id":null,"result":{"address":"000000000000000000000000000000dd","authentication_key":"cd907006959c0f4afb78568710e418ba3630930522a40bd3146f71de5b4f23d0","balances":[{"amount":4611686016239387903,"currency":"Coin1"},{"amount":4611686018427387903,"currency":"Coin2"},{"amount":9223371981554775807,"currency":"LBR"}],"delegated_key_rotation_capability":false,"delegated_withdrawal_capability":false,"is_frozen":false,"received_events_key":"0300000000000000000000000000000000000000000000dd","role":{"base_url":"","base_url_rotation_events_key":"0200000000000000000000000000000000000000000000dd","compliance_key":"","compliance_key_rotation_events_key":"0100000000000000000000000000000000000000000000dd","expiration_time":18446744073709551615,"human_name":"moneybags","preburn_balances":[{"amount":0,"currency":"Coin1"},{"amount":0,"currency":"Coin2"}],"received_mint_events_key":"0000000000000000000000000000000000000000000000dd","type":"designated_dealer"},"sent_events_key":"0400000000000000000000000000000000000000000000dd","sequence_number":3289}}* Closing connection 0
mimoo

comment created time in 20 days

PR closed libra/libra

[WIP][cluster-test] add pylibra to client compat test cla-signed

Add another test node to client_compatibility_test that will run pylibra commands. This will test pylibra arbitrary network configuration and a "mint and wait" use case. This PR also adds pylibra-beta into the faucet image for convenience.

<!-- Thank you for sending a PR. We appreciate you spending time to help improve the Libra project.

The project is undergoing daily changes. Pull Requests will be reviewed and responded to as time permits. -->

Motivation

(Write your motivation for proposed changes here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/libra/website, and link to your PR here.)

+144 -21

0 comment

5 changed files

rustielin

pr closed time in 20 days

PullRequestReviewEvent
PullRequestReviewEvent

PR closed libra/libra

[DO NOT MERGE] Lbt err slack newline canary cla-signed

for canary, invokes failure in cluster-test

+4 -2

6 comments

2 changed files

rustielin

pr closed time in 25 days

PR closed libra/libra

Reviewers
[gha][lbt] fix newlines in slack msg cla-signed

Slack message doesn't play nice with newline characters and prints them literally. This just changes newlines into spaces if we're dumping the report to slack message.

Test: canary with https://github.com/libra/libra/pull/6216

+2 -2

2 comments

1 changed file

rustielin

pr closed time in 25 days

pull request commentlibra/libra

[gha][lbt] fix newlines in slack msg

closing for now

rustielin

comment created time in 25 days

pull request commentlibra/libra

[DO NOT MERGE] Lbt err slack newline canary

/canary

rustielin

comment created time in 25 days

push eventrustielin/libra

rustielin

commit sha 6789fef718d139de66e40da7e99b903d81ef3b16

[gha][lbt] fix newlines in slack msg

view details

rustielin

commit sha dd12549945355b2182a36d4d982eb067b967f045

[DO NOT MERGE] invoke failure for LBT

view details

push time in 25 days

pull request commentlibra/libra

[gha][lbt] fix newlines in slack msg

turns out this still doesn't work, so I'll just make the newlines into spaces ;//

rustielin

comment created time in 25 days

push eventrustielin/libra

rustielin

commit sha 6789fef718d139de66e40da7e99b903d81ef3b16

[gha][lbt] fix newlines in slack msg

view details

push time in 25 days

pull request commentlibra/libra

[DO NOT MERGE] Lbt err slack newline canary

/canary

rustielin

comment created time in a month

PR opened libra/libra

[DO NOT MERGE] Lbt err slack newline canary

for canary, invokes failure in cluster-test

+6 -2

0 comment

2 changed files

pr created time in a month

create barnchrustielin/libra

branch : lbt-err-slack-newline-canary

created branch time in a month

PR opened libra/libra

Reviewers
[gha][lbt] fix newlines in slack msg

Slack message doesn't play nice with newline characters and prints them literally. This forces the newlines to be evaluated by the shell before sending to slack.

+4 -2

0 comment

1 changed file

pr created time in a month

push eventrustielin/libra

rustielin

commit sha 5023fdd41f0e0ed1c2f0f3cf718906a9403df19e

[gha][lbt] fix newlines in slack msg

view details

push time in a month

push eventrustielin/libra

rustielin

commit sha ebd684c981a3a3868e0acd06502099c02d31710f

[gha][lbt] fix newlines in slack msg

view details

push time in a month

create barnchrustielin/libra

branch : lbt-err-slack-newline

created branch time in a month

pull request commentlibra/libra

[gha][lbt] add PR num to error msg

/land

rustielin

comment created time in a month

PR opened libra/libra

Reviewers
[gha][lbt] add PR num to error msg

Makes it easier to see whether flaky land-blocking CT is from the same PR or not.

+1 -1

0 comment

1 changed file

pr created time in a month

push eventrustielin/libra

rustielin

commit sha 5023047459a152d59e7a78781f9083a38722794a

[gha][lbt] add PR num to error msg

view details

push time in a month

create barnchrustielin/libra

branch : lbt-err-pr-num

created branch time in a month

pull request commentlibra/libra

[codebuild] deal with download failed

/land

rustielin

comment created time in a month

push eventrustielin/libra

rustielin

commit sha cbfced43a7be8af566a7363e715bf1f41ab809a9

[codebuild] deal with download failed

view details

push time in a month

pull request commentlibra/libra

[codebuild] deal with download failed

/land

rustielin

comment created time in a month

PR opened libra/libra

[codebuild] deal with download failed

Make error nicer for download failed.

Test: try building from a PR that doesn't exist (yet)

$ /docker/build-aws.sh --build-init --version pull/7000
Building with SOURCE_VERSION=refs/pull/7000/head TAGS=dev_rustielin_pull_7000
Started build for project libra-init with ID libra-init:0a231b38-6eb8-4843-8839-0ceae028076e. Link to the build https://us-west-2.console.aws.amazon.com/codesuite/codebuild/projects/libra-init/build/libra-init:0a231b38-6eb8-4843-8839-0ceae028076e/
libra-init current phase: QUEUED
libra-init current phase: PROVISIONING
libra-init current phase: PROVISIONING
libra-init current phase: PROVISIONING
libra-init current phase: DOWNLOAD_SOURCE
libra-init current phase: DOWNLOAD_SOURCE
libra-init current phase: DOWNLOAD_SOURCE
libra-init download source failed

$ echo $?
1
+6 -1

0 comment

1 changed file

pr created time in a month

create barnchrustielin/libra

branch : codebuild-download-fail

created branch time in a month

push eventindexofknowledge/iok

Rustie (Ting-Chi) Lin

commit sha 3ab916760f3125e70849ba2abff68426985ad3c6

[awesomescraper][cleaner] start data cleaning for scraped ioks Until our mdscraper gets good enough, we'll have to manually clean some IoKs we scrape in automatically. Ideally, all awesomelists follow some format, such as standadization of header and bullet point use, but that's hard to enforce. All awesomelists created from IoK --> awesomelist will be like that, but it's not guaranteed for the other way around. Now that we have a bunch of awesomelists in this project, we can clean some up manually. That will: 1. give us more hollistic insight into what awesomelists look like, so we can design better ways to scrape md content 2. create a curated list of ioks to feature on our webapp 3. have more data to play with, to test edge cases in our tooling, as well as webapp UI

view details

Rustie Lin

commit sha f1c8e630a73f68b97d86d4916a3758553f0b0558

Merge pull request #134 from indexofknowledge/iok-cleaner [awesomescraper][cleaner] start data cleaning for scraped ioks

view details

push time in a month

PR merged indexofknowledge/iok

Reviewers
[awesomescraper][cleaner] start data cleaning for scraped ioks

Until our mdscraper gets good enough, we'll have to manually clean some IoKs we scrape in automatically. Ideally, all awesomelists follow some format, such as standadization of header and bullet point use, but that's hard to enforce. All awesomelists created from IoK --> awesomelist will be like that, but it's not guaranteed for the other way around. Now that we have a bunch of awesomelists in this project, we can clean some up manually. That will:

  1. give us more hollistic insight into what awesomelists look like, so we can design better ways to scrape md content
  2. create a curated list of ioks to feature on our webapp
  3. have more data to play with, to test edge cases in our tooling, as well as webapp UI

Test Plan

Detailed in the created README. It creates the CID bafyreicl47uygayidmtysna2gv4g2q7vgdnd2ds55gmlocestf3bhwqcji from an audio visualization awesomelist. Pop that into a webapp, such as https://iok-rustie.firebaseapp.com/ipfs?hash=bafyreicl47uygayidmtysna2gv4g2q7vgdnd2ds55gmlocestf3bhwqcji

Related PRs or Issues

(If your PR adds or changes functionality, please take time to update any related docs and link to your issue or PR here.)

+324 -9

0 comment

5 changed files

rustielin

pr closed time in a month

PR closed libra/libra

[DO NOT MERGE] panic on invalid addr cla-signed

Canary build for testing state sync on k8s testnet

+2 -0

0 comment

1 changed file

rustielin

pr closed time in a month

PR opened libra/libra

[DO NOT MERGE] panic on invalid addr

Canary build for testing state sync on k8s testnet

+2 -0

0 comment

1 changed file

pr created time in a month

create barnchrustielin/libra

branch : canary-invalid-addr-panic

created branch time in a month

PullRequestReviewEvent
PullRequestReviewEvent

PR opened indexofknowledge/iok

Reviewers
Iok cleaner 2

Stacked on 3ab9167 (#134), only review baec068

Clean more awesomelists manually from our cached bunch, and add them to the README for now. Started a list of small bugs I faced when scraping. The tool is run manually though, so these bugs are pretty low-priority, as normal users will not see them, only us devs/operators :)

Also hacked iok.meta to use UUID for ID calculation again, instead of hash. Sometimes the scraper will think there's no text (bug) to hash, but the hack around that is to just get the ID independently of whatever is in the node data in the first place. The graph is formatted later on anyways in the cleanup procedure, as documented in the README.

+1516 -13

0 comment

13 changed files

pr created time in a month

create barnchindexofknowledge/iok

branch : iok-cleaner-2

created branch time in a month

pull request commentlibra/libra

[gha][lbt] append a happy message when LBT passes

/land

rustielin

comment created time in a month

push eventrustielin/libra

rustielin

commit sha 476e6776653995eea8fcb11080483f6451d3c244

[gha][lbt] append a happy message when LBT passes If LBT passes, add a line that says: :tada: Land-blocking test passed! :ok_hand:

view details

push time in a month

Pull request review commentlibra/libra

[gha][lbt] append a happy message when LBT passes

 jobs:             }             // Post test result on original pull request             try {+              if (!should_fail) {+                body += "\n :tada: Land-blocking test passed! :ok_hand:"

It's in reference to the name of the GHA workflow, which is "Land-blocking Test". Actually now that you mention it it's a bit confusing... I'll change it to cluster-test

rustielin

comment created time in a month

PullRequestReviewEvent

PR opened libra/libra

[gha][lbt] append a happy message when LBT passes

If LBT passes, add a line that says:

:tada: Land-blocking test passed! :ok_hand:

+3 -0

0 comment

1 changed file

pr created time in a month

push eventrustielin/libra

rustielin

commit sha f301214e42d0bf8dedf50d39793fdafb104051fd

[gha][lbt] append a happy message when LBT passes If LBT passes, add a line that says: :tada: Land-blocking test passed! :ok_hand:

view details

push time in a month

create barnchrustielin/libra

branch : lbt-pass-msg

created branch time in a month

issue openedindexofknowledge/iok

sidebar scrollable

Sidebar is not scrollable, so spillover is lost to the user.

e.g. https://iok-rustie.firebaseapp.com/ipfs?hash=bafyreicl47uygayidmtysna2gv4g2q7vgdnd2ds55gmlocestf3bhwqcji > "Videos"

image

created time in a month

PR closed libra/libra

Lbt report pr num fail cla-signed

For canarying CI. This is stacked on top of 9df83f6d9175953672eaa72454c681c8fb95ac18, for which there is a separate PR

+72 -15

19 comments

2 changed files

rustielin

pr closed time in a month

Pull request review commentindexofknowledge/iok

We ate bugs

+function TreeCircleLayout(options) {

:o wow this is cool

rianadon

comment created time in a month

PullRequestReviewEvent

Pull request review commentindexofknowledge/iok

We ate bugs

 class IokEdit extends Component {   }    onNodeTap(evt, cy) {-    const { selected, selectNode, mergingNode } = this.props;-    console.log('SELECTED', selected, 'MERGING', mergingNode);+    const { selected, selectNode, prevNode } = this.props;     if (evt.target === cy) {       if (selected) {+        this.clearTool();         selectNode(null);       }     } else if (evt.target.isNode()) {       const id = evt.target.id();-      if (!selected || selected.id !== id) {-        selectNode(id);-        const { secretCodeSign } = this.state;-        this.setState({ secretCodeSign: [...secretCodeSign, id] }, () => {-          // eslint-disable-next-line-          if (JSON.stringify(this.statesecretCodeSign) === JSON.stringify(['04eaf9a2a65d37f254fab35f969da7b133cea2087e1be846ea2dc8ccbb0e2470',-            'e6f043e27913e1ceb469bfbcc6eca983a374918618c4912e65f4756f6e177855', '8d3e61ce168c16ae5c10fc0eb2085e7063844736be62d37c1318b437e60a06b2',-            '71686ead6a4dc2481870877da6a888fab7c488819572c391b71acabd047930fe', 'e6f043e27913e1ceb469bfbcc6eca983a374918618c4912e65f4756f6e177855'])) {-            window.location = 'https://bab-internal.slack.com';-          }-        });+      if (selected && selected.id === id) return;+      this.clearTool();+      if (prevNode !== null && id === prevNode.id) {+        selectNode(null);+        return;       }+      selectNode(id);+      // extra below+      const { secretCodeSign } = this.state;+      this.setState({ secretCodeSign: [...secretCodeSign, id] }, () => {+        // eslint-disable-next-line+        if (JSON.stringify(this.statesecretCodeSign) === JSON.stringify(['04eaf9a2a65d37f254fab35f969da7b133cea2087e1be846ea2dc8ccbb0e2470',

what's this?

rianadon

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

PR closed libra/libra

[DO NOT MERGE] canary build images if not found by compat cla-signed

Canary for #5878 (edits in a813bb4)

  • remove slack logs to reduce spam for this canary

This PR is against branch https://github.com/libra/libra/tree/test-no-image-built. The latest commit in that branch is a dummy [breaking] change. We expect the following to occur:

  • LBT will check if an image exists for the latest rev in the base branch
  • LBT will realize that such an image does not exist, and note that the latest commit was breaking. This ends the image reverse search in find-lbt-images.sh
  • Because LBT failed to find an image to compat test against, a new set of images will be built off of the latest commit in the base branch. This will happen in parallel with the normal images build.
  • LBT continues along with compat test as before (and passes)
+122 -75

3 comments

3 changed files

rustielin

pr closed time in 2 months

pull request commentlibra/libra

[gha][lbt] build images if not found by compat

/land

rustielin

comment created time in 2 months

pull request commentlibra/libra

[gha][lbt] build images if not found by compat

/canary

rustielin

comment created time in 2 months

push eventrustielin/libra

Zekun Li

commit sha 7371a80092fd1a435c735f019dcfb9ec8c318690

[easy][safety-rules] fix the error representation Closes: #5867

view details

snakech

commit sha 39fca8bd2b81b0b231773cc817a8b5a532b10c8b

[cluster-test] remove re-serialization in CT Closes: #5816

view details

Tim Zakian

commit sha 7ca74667c12090e5603ab268be45ef342bf0ac34

[functional tests] Make checks for test output unique Closes: #5815

view details

Greg Nazario

commit sha 240b9b1c4061c0b34b59cefda7cc2dd76652d6b1

[network] delete unused buffered send Closes: #5868

view details

Greg Nazario

commit sha 9fd63e1e6a74473d54102d5a93fa07195aeb2ffe

[logging] remove new_unnamed in favor of default new_unnamed() was not being used elsewhere, and was just basically a clone of default(). So, I've removed it for default().

view details

Greg Nazario

commit sha de642a0aafb736b7ba2c649fa993074370b8e7c2

[logging] rename structured log log field to message It was confusing having a field named "log" in a log. So, now the field is more appropriately named "message" Closes: #5863

view details

Joshua Lind

commit sha 2f0577313e5643741af6944061619568f9dff7cb

[Specifications] Add the TCB README to the repository.

view details

Joshua Lind

commit sha 6f1bcf38aa66a97f931a3f66f664ac7b2d874a07

[Specifications] Add the key manager specification to the repository.

view details

Joshua Lind

commit sha 88310f606a55bb7bd34f9dd352991e06fc46db1e

[Specifications] Add the secure storage specification to the repository.

view details

Joshua Lind

commit sha 41e598a7331ed7d959f1514022a62bea5d93110f

[Specification] Add safety rules specification to the repo. Closes: #5870

view details

Aaron Gao

commit sha 7f5c4593f5ae1849635b01ea9be6fd7f7fef5e94

[storage][dashboard] add restore status panel Closes: #5873

view details

Greg Nazario

commit sha 70ce3f6c8da62f7a4a7974ae68860a3148c59028

[cli] move cli metrics to cli crate Closes: #5872

view details

Joshua Lind

commit sha b7bb94de0cca02100d7aafb2ec9a62a51d7a1fe9

[Specifications] Rename specification markdown files to README for automatic display.

view details

Joshua Lind

commit sha 72fb4b1fe561a72582a9767a468cf43673ae7e5d

[Specifications] Updated the TCB README file. Closes: #5874

view details

Mathieu Baudet

commit sha 617251817645389ab8bb87a69a36f02e87e75f27

[Move script] tiered_mint: fix quotes in doc comment

view details

Mathieu Baudet

commit sha 16371df95d7bea9c866105ff51729e40cb66c69d

[Move transaction builders] Java: support javadoc Closes: #5880

view details

Emma Zhong

commit sha 0d3782be759de15ff06792060f1b51dd74415efc

[libra framework] specify mint_lbr and some functions in LBR, LibraAccount Closes: #5855

view details

Jack Moffitt

commit sha 4e0135a7af927f22d29624cf3f994824f21a364a

[ci] Remove checked in summaries Closes: #5885

view details

SunMi Lee

commit sha d45754cc16192e1600cc648a4ee425702d53e02f

[faucet] Add longer delay for timeout Closes: #5884

view details

aldenhu

commit sha d369b70ad8fde4009b65dbc6f33c572004016df6

add tools buildspec Closes: #5886

view details

push time in 2 months

push eventrustielin/libra

rustielin

commit sha aa5065f68d3fc4701bcf087f2e7dc8c6fab70267

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

push eventrustielin/libra

rustielin

commit sha 621a7504be477d6d19504ef966b40a8c16ea511e

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

push eventrustielin/libra

rustielin

commit sha 72d96e4898f3cae2d3e1be2cf870f18c54511838

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

pull request commentlibra/libra

[gha][lbt] don't run LBT compat on cherry-pick and update slack log

/land

rustielin

comment created time in 2 months

pull request commentlibra/libra

[testsuite] remove compat and roar

/land

rustielin

comment created time in 2 months

pull request commentlibra/libra

[gha][lbt] don't run LBT on cherry-pick and update slack log

@sausagee @andll agreed, thanks for the feedback! I've added the ability for LBT to build two sets of images if it is unable to find the right images to use for compat test (https://github.com/libra/libra/pull/5878 which is stacked on this PR) LBT + compat should now work for cherry-picking into release branches.

rustielin

comment created time in 2 months

pull request commentlibra/libra

[DO NOT MERGE] canary build images if not found by compat

/canary

rustielin

comment created time in 2 months

PR opened libra/libra

[DO NOT MERGE] canary build images if not found by compat

Canary:

  • remove slack logs
  • stacked on previous PRs
+122 -75

0 comment

3 changed files

pr created time in 2 months

PR closed libra/libra

[DO NOT MERGE] canary compat on refs with no image built cla-signed

Canary for https://github.com/libra/libra/pull/5878

This PR is against branch https://github.com/libra/libra/tree/test-no-image-built. The latest commit in that branch is a dummy [breaking] change. We expect the following to occur:

  1. LBT will check if an image exists for the latest rev in the base branch
  2. LBT will realize that such an image does not exist, and note that the latest commit was breaking. This ends the image reverse search
  3. Because LBT failed to find an image to compat test against, a new image will be built off of the latest commit in the base branch
  4. LBT continues along with compat test as before
+130 -39

14 comments

3 changed files

rustielin

pr closed time in 2 months

push eventlibra/libra

rustielin

commit sha 38c4e9e6de42da1c1affd30e51ed9758c25a9c09

[breaking][DO NOT MERGE] add rev with no built image

view details

push time in 2 months

push eventrustielin/libra

rustielin

commit sha a813bb48c43af90e8e8a9745e6b15821c0ef24b3

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

create barnchrustielin/libra

branch : lbt-report-pr-num-2-canary

created branch time in 2 months

pull request commentlibra/libra

[DO NOT MERGE] canary compat on refs with no image built

/canary

rustielin

comment created time in 2 months

PR opened libra/libra

[testsuite] remove compat and roar

Now that we've phased out the old ECS testnet, we can get rid of record and replay, and also the ECS version of compat. Compat is already running in cluster test. Record-and-replay implementation in k8s will be a bit more involved, and not sure if we need it at the moment.

Corresponding changes need to be made on the infra side too.

+0 -1379

0 comment

20 changed files

pr created time in 2 months

create barnchrustielin/libra

branch : compat-cleanup

created branch time in 2 months

push eventrustielin/libra

rustielin

commit sha 462f0869d2186857cbdf13e13aaaac1c5ad5557c

[DO NOT MERGE] remove slack error logging

view details

push time in 2 months

push eventrustielin/libra

rustielin

commit sha cbd3740648457d703e3f6457c28dbb75be693694

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

pull request commentlibra/libra

[DO NOT MERGE] canary compat on refs with no image built

/canary

rustielin

comment created time in 2 months

push eventrustielin/libra

rustielin

commit sha 10db84a29f1f9f2d7de66878248dc0253b7a8ac1

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

pull request commentlibra/libra

[DO NOT MERGE] canary compat on refs with no image built

/canary

rustielin

comment created time in 2 months

push eventlibra/libra

rustielin

commit sha c443a2aec0e28a4887430a1e4b2c37904ace3c37

[breaking][DO NOT MERGE] add rev with no built image

view details

push time in 2 months

pull request commentlibra/libra

[WIP][gha][lbt] build images if not found by compat

/canary

rustielin

comment created time in 2 months

push eventrustielin/libra

rustielin

commit sha 7d9cd537799aec5daaeececaa3eaa38504a20347

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

push eventrustielin/libra

rustielin

commit sha 00c9d1edca2884c7110beff44d2fa784ade55a9c

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

push eventrustielin/libra

rustielin

commit sha e68773d0cac9abeeb229f4a03ea7052715928601

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

pull request commentlibra/libra

[DO NOT MERGE] canary compat on refs with no image built

/canary

rustielin

comment created time in 2 months

push eventrustielin/libra

rustielin

commit sha 42b58566b71830535735b0f2804861f85a5cd220

[gha][lbt] build images if not found by compat `find-lbt-images.sh` now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from `BASE_REF` and continue with the workflow. Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable `BASE_REF`. Depends on https://github.com/libra/libra/pull/5701

view details

push time in 2 months

pull request commentlibra/libra

[DO NOT MERGE] canary compat on refs with no image built

/canary

rustielin

comment created time in 2 months

push eventlibra/libra

rustielin

commit sha 4c51fe3601207e93e875a8185cac958c82ee2b20

[breaking][DO NOT MERGE] add rev with no built image

view details

push time in 2 months

PR opened libra/libra

[DO NOT MERGE] canary compat on refs with no image built

Canary

+118 -36

0 comment

3 changed files

pr created time in 2 months

create barnchlibra/libra

branch : test-no-image-built

created branch time in 2 months

PR opened libra/libra

[WIP][gha][lbt] build images if not found by compat

WIP

Stacked on 9df83f6, only review 034bd06

Overview

find-lbt-images.sh now only looks for recent images until the first breaking change has been found, since after that, compat is bound to fail. If a recent image is not found, report to Slack, but also build the expected image from BASE_REF and continue with the workflow.

Also allows land-blocking compat test to be run on non-master branches, such as for verifying commits cherry-picked into release branches. Appropriate changes have been made in scripts to account for variable BASE_REF.

+118 -36

0 comment

3 changed files

pr created time in 2 months

create barnchrustielin/libra

branch : lbt-report-pr-num-2

created branch time in 2 months

pull request commentlibra/libra

Lbt report pr num fail

/canary

rustielin

comment created time in 2 months

push eventrustielin/libra

rustielin

commit sha 9df83f6d9175953672eaa72454c681c8fb95ac18

[gha][lbt] calculate PR number earlier for slack log * Changes PR number and details calculation, and reorders initial steps * fetch base ref for use in compat test * New button in Slack to Visit PR * Slack message uses the report.json

view details

rustielin

commit sha 84dd938f48a208b1128ee5a87a432175b9ceb2b4

[DO NOT MERGE] invoke failure for LBT

view details

push time in 2 months

push eventrustielin/libra

rustielin

commit sha 9df83f6d9175953672eaa72454c681c8fb95ac18

[gha][lbt] calculate PR number earlier for slack log * Changes PR number and details calculation, and reorders initial steps * fetch base ref for use in compat test * New button in Slack to Visit PR * Slack message uses the report.json

view details

push time in 2 months

pull request commentlibra/libra

[gha][lbt] calculate PR number earlier for slack log

/canary

rustielin

comment created time in 2 months

push eventrustielin/libra

rustielin

commit sha 6797abb7451a8ed324d282989c5bdb90b43b94e8

[gha][lbt] calculate PR number earlier for slack log * Changes PR number and details calculation, and reorders initial steps * fetch base ref for use in compat test * New button in Slack to Visit PR * Slack message uses the report.json

view details

push time in 2 months

pull request commentlibra/libra

Lbt report pr num fail

/canary

rustielin

comment created time in 2 months

push eventrustielin/libra

rustielin

commit sha 6797abb7451a8ed324d282989c5bdb90b43b94e8

[gha][lbt] calculate PR number earlier for slack log * Changes PR number and details calculation, and reorders initial steps * fetch base ref for use in compat test * New button in Slack to Visit PR * Slack message uses the report.json

view details

rustielin

commit sha 3b1d851601e2b62c4c603595eb81547adc775ace

[DO NOT MERGE] invoke failure for LBT

view details

push time in 2 months

pull request commentlibra/libra

Lbt report pr num fail

/canary

rustielin

comment created time in 2 months

more