profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/rswgnu/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Robert Weiner rswgnu New York Region linkedin.com/in/rswgnu I build software in dynamic languages that works, is extensively documented, and lasts for years, the MIT way.

rswgnu/hyperbole 74

GNU Hyperbole: The Everyday, Hypertextual Information Manager

stardiviner/eldoc-overlay 22

display eldoc doc with contextual documentation overlay for easy to look.

rswgnu/rsw-elisp 6

Interactively evaluate regions, preceding variable definitions and quoted sexpressions

rswgnu/rsw-visidata 4

Documentation and configuration extensions for VisiData, the universal data wrangling tool

rswgnu/display-until 3

Display a window or frame topmost in the frame stack until a condition or timeout occurs

rswgnu/ace-window 0

Quickly switch windows in Emacs

rswgnu/aht-ha-ui 0

AHT Smart Homes - Home Automation User Interface Samples

rswgnu/avy 0

Jump to things in Emacs tree-style

rswgnu/burly.el 0

Save and restore buffers and window configurations in Emacs

rswgnu/company-mode 0

Modular in-buffer completion framework for Emacs

Pull request review commentrswgnu/hyperbole

Add target that controls what byte compile warnings are displayed

 bin: src 	$(RM) *.elc kotl/*.elc 	$(EMACS) $(BATCHFLAGS) $(PRELOADS) -f batch-byte-compile $(EL_KOTL) $(EL_COMPILE) +# Byte compile files but apply a filter for either including or+# removing warnings. See variable {C-hv byte-compile-warnings RET} for+# list if warnings that can be controlled. Default is set to suppress

of warnings

matsl

comment created time in 14 hours

PullRequestReviewEvent

pull request commentrswgnu/hyperbole

Add test for split-cell

New cell should get a copy if the plist aside from the properties added at i itial cell creation, which are cell specific,i.e. copy only user added properties, which typically is none/nil.

-- Bob

On Sep 18, 2021, at 8:37 AM, Mats Lidell ***@***.***> wrote:

@rswgnu Changed how the new cells gets its plist. It seems to fix the test case. PTAL since I'm not sure if anything else is needed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

matsl

comment created time in 3 days

PullRequestReviewEvent

pull request commentrswgnu/hyperbole

Add test for split-cell

Thanks, I’ll work on it when I get time.

-- Bob

On Sep 17, 2021, at 6:13 PM, Mats Lidell ***@***.***> wrote:

@matsl requested your review on: #122 Add test for split-cell.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

matsl

comment created time in 3 days

PullRequestReviewEvent

pull request commentrswgnu/melpa

Merging updates from upstream

Merge from master

rswgnu

comment created time in 7 days

push eventrswgnu/melpa

Miquel Sabaté Solà

commit sha 9196110908f0d2130f7963499a94853b5192ac8c

recipes: added the soria theme (#6808) Soria is a color theme based on xoria256 (vim.org #2140) but with some modifications here and there with colors from openSUSE's guidelines (http://opensuse.github.io/branding-guidelines/). Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>

view details

Campbell Barton

commit sha abaa6522f18ca1f47788ebb3281fbfcdade2b7c7

Add spell-fu package (#6809)

view details

Lassi Kortela

commit sha 2ec3f57a05e1b2e28ce33700d8ea98758b0bb69d

Add lisp-local recipe (#6812)

view details

Naoya Yamashita

commit sha 2e51160b1e5d277e66b9cff493b1f6b3c6f9ee28

add leaf-tree recipe (#6814)

view details

Omar Antolín Camarena

commit sha 1a952162da476b4a0f496d9dc15d2d7a8d0964f6

Add recipe for icomplete-vertical (#6817)

view details

Eric Dallo

commit sha acbba6bc6f1bb6e1153f1f75ca1dc025bb5a8993

Add lsp-dart recipe (#6823)

view details

Naoya Yamashita

commit sha e1d80f4662a0f77360244fc4b34f2076db4fd478

add leaf-manager (#6831)

view details

Étienne Deparis

commit sha ddaffa55c1b99cce9097c019efe9a236e2f5a395

recipes(flycheck-grammalecte): Add missing python script in :files list (#6832) The last flycheck-grammalecte release add a new external python script, which should be embed in the package.

view details

Sibi

commit sha fbc0b93675f6baab6ab023b596e65658c9e2a534

Add rego mode (#6789)

view details

Jordan Besly

commit sha cb18ad238792570e5ef825a101059bfdc293949f

Recipe/friendly tramp path (#6825) * New recipe: space-theming * New recipe: friendly-tramp-path * Delete space-theming Co-authored-by: Chris Rayner <riscy@users.noreply.github.com>

view details

LAI Shulu

commit sha 82ef5414e63fe94905f042534d8bde88fb5461c6

Add recipe for smart-input-source (#6815)

view details

Mehmet Tekman

commit sha 8c86ca9b1ad39282f965d36ec2a8df807cc0ebb1

Add elisp-depmap recipe (#6791)

view details

Mehmet Tekman

commit sha 8868893e4109db9b348a62bc012c89648384994e

add org-treeusage recipe (#6811)

view details

Alexander Fu Xi

commit sha caa6bf82ea660f8e1d68e45cc99c6f6427cf1327

Add org-noter-pdftools (#6813) Co-authored-by: fuxialexander <xfu@DESKTOP-658E7EA.localdomain>

view details

Zachary Kanfer

commit sha d3828ad7599d13728b5571b882344c3ada434b85

Migrate packages from Bitbucket. Packages are: 2048-game minesweeper org-parser zpresent

view details

Titus von der Malsburg

commit sha 873ae2af16e03c8e10494be3f0e7840eb27172a3

Make bibtex-completion a separate package (#6840) Useful for org-roam-bibtex and generally cleaner.

view details

USAMI Kenta

commit sha bc0ea837b6813002826d861acb7f3cc506c337ba

Add flymake-phpstan package (#6803)

view details

Jordan Besly

commit sha 5529fcf16b877b01ee0aff710ebfb0ad5da8dba1

New recipe: space-theming (#6824)

view details

Topi Kettunen

commit sha e415b9a4d269cfee5ee2b0e58acb18804c2a8cb7

Add brutal-theme (#6826)

view details

Eder Elorriaga

commit sha 054a7c164fae0c76ad2b3c6891d37a03f3e08823

Add recipe for simple-modeline (#6818) * Add recipe for simple-modeline * Fix repo url in simple-modeline recipe

view details

push time in 7 days

PR merged rswgnu/melpa

Merging updates from upstream
+6262 -3245

0 comment

2392 changed files

rswgnu

pr closed time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventrswgnu/hyperbole

Bob Weiner

commit sha b7b779338a1c89375c279d6ad2cd34a1383b306a

kexport:html - Allow only Koutline buffers and files Also stop centering HTML title since often ends up to far to the right.

view details

Bob Weiner

commit sha 493c5bb877535637a34e08330c9b8a0cbf746138

Merge branch 'master' of hyperbole

view details

Bob Weiner

commit sha 9113e1bae663ec157c9f12a497b5b7bd91be324b

Merge branch 'master' of hyperbole

view details

push time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 the symbol list.  For `suspicious', only `set-buffer' can be used." ;;; Private functions ;;; ************************************************************************ -(defun hypb:constant-vector-symbol-replace-  (constant-vector sym-to-replace replace-with-sym)-  "Replace symbols within a byte-compiled constant vector."-  (let ((i (length constant-vector))-	constant)-    (while (>= (setq i (1- i)) 0)-      (setq constant (aref constant-vector i))-      (cond ((eq constant sym-to-replace)-	     (aset constant-vector i replace-with-sym))-	    ((and (fboundp 'compiled-function-p)-		  (compiled-function-p constant))-	     (hypb:function-symbol-replace-	      constant sym-to-replace replace-with-sym))))))-

Is this not being called anywhere?

matsl

comment created time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 Current button is being modified when MODIFYING is non-nil. Return nil if ACTION is not a list or `byte-code' object, has no interactive form or takes no arguments."   (and (or (hypb:emacs-byte-code-p action) (listp action))-       (let ((interactive-form (action:commandp action)))+       (let ((interactive-form (interactive-form action))) 	 (when interactive-form 	   (hpath:relative-arguments 	    (hargs:iform-read interactive-form modifying))))))

Make all code above here in hact.el and hargs.el a separate pull request.

matsl

comment created time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 	;; Selected subject is different from current article's. 	(gnus-summary-display-article article)))) --;;; Redefine 'gnus-inews-article' from "gnuspost.el" to make it include-;;; any signature before Hyperbole button data.  Does this by having-;;; signature inserted within narrowed buffer and then applies a hook to-;;; have the buffer widened before sending.-(hypb:function-symbol-replace-  'gnus-inews-article 'widen 'hmail:msg-narrow)--;;; Overload this function from "rnewspost.el" for supercite compatibility-;;; only when supercite is in use.-(if (hypb:supercite-p)-    (defun news-reply-yank-original (arg)-      "Supercite version of news-reply-yank-original.-Insert the message being replied to in the reply buffer. Puts point-before the mail headers and mark after body of the text.  Calls-mail-yank-original to actually yank the message into the buffer and-cite text.--If mail-yank-original is not overloaded by supercite, each nonblank-line is indented ARG spaces (default 3).  Just \\[universal-argument]-as ARG means don't indent and don't delete any header fields."-      (interactive "P")-      (mail-yank-original arg)-      (exchange-point-and-mark)-      (run-hooks 'news-reply-header-hook))-  )-

Skip this change.

matsl

comment created time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 Return either the modified string or the original ARG when not modified."        nil t)     arg)) -(defun hypb:function-copy (func-symbol)-  "Copy FUNC-SYMBOL's body for overloading.  Return a copy of the body."-  (if (fboundp func-symbol)-      (let ((func (hypb:indirect-function func-symbol)))-	(cond ((listp func) (copy-sequence func))-	      ((subrp func) (error "(hypb:function-copy): `%s' is a primitive; can't copy body"-				   func-symbol))-	      ((and (hypb:emacs-byte-code-p func) (fboundp 'make-byte-code))-	       (let ((new-code (append func nil))) ; turn it into a list-		 (apply 'make-byte-code new-code)))-	      (t (error "(hypb:function-copy): Can't copy function body: %s" func))))-    (error "(hypb:function-copy): `%s' symbol is not bound to a function"-	   func-symbol)))--(defun hypb:function-overload (func-sym prepend &rest new-forms)-  "Redefine function named FUNC-SYM by either PREPENDing (or appending if nil) rest of quoted NEW-FORMS."-  (let ((old-func-sym (intern-			(concat "hypb--old-"-				(symbol-name func-sym)))))-    (or (fboundp old-func-sym)-	(defalias old-func-sym (hypb:function-copy func-sym)))-    (let* ((old-func (hypb:indirect-function old-func-sym))-	   (old-param-list (action:params old-func))-	   (param-list (action:param-list old-func))-	   (old-func-call-	     (list (if (memq '&rest old-param-list)-		       ;; Have to account for extra list wrapper from &rest.-		       (cons 'apply-			     (cons (list 'quote old-func-sym) param-list))-		     (cons old-func-sym param-list)))))-      (eval (append-	      (list 'defun func-sym old-param-list)-	      (delq nil-		    (list-		      (documentation old-func-sym)-		      (action:commandp old-func-sym)))-	      (if prepend-		  (append new-forms old-func-call)-		(append old-func-call new-forms)))))))--(defun hypb:function-symbol-replace (func-sym sym-to-replace replace-with-sym)-  "Replace in body of FUNC-SYM SYM-TO-REPLACE with REPLACE-WITH-SYM.-FUNC-SYM may be a function symbol or its body.  All occurrences within lists-are replaced.  Returns body of modified FUNC-SYM."-  (let ((body (hypb:indirect-function func-sym))-	(constant-vector) (constant))-    (if (subrp body)-        ;; Non-Lisp code, can't do any replacement-        body-      (if (listp body)-	  ;; assume V18 byte compiler-	  (setq constant-vector-	        (car (delq nil (mapcar-			        (lambda (elt)-				  (and (listp elt)-				       (vectorp (setq constant-vector (nth 2 elt)))-				       constant-vector))-			        body))))-        ;; assume EMACS byte compiler   (eq (compiled-function-p body) t)-        (setq constant (if (fboundp 'compiled-function-constants)-			   (compiled-function-constants body)-		         (aref body 2))-	      constant-vector (when (vectorp constant) constant)))-      (if constant-vector-	  ;; Code is byte-compiled.-	  (hypb:constant-vector-symbol-replace-	   constant-vector sym-to-replace replace-with-sym)-        ;;-        ;; Code is not byte-compiled.-        ;; Replaces occurrence of symbol within lists only.-        (hypb:map-sublists-         (lambda (atom list)-	   ;; The ' in the next line *is* required for proper substitution.-	   (when (eq atom 'sym-to-replace)-	     (let ((again t))-	       (while (and again list)-	         (if (eq (car list) atom)-		     (progn (setcar list replace-with-sym)-			    (setq again nil))-		   (setq list (cdr list)))))))-         body))-      body)))-

Are these not being called anywhere?

matsl

comment created time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 type created with `defact' but may not return nil since any nil value returned is converted to t to ensure the implicit button checker recognizes that the action has been executed. -Optional TO-P is a boolean form which moves point immediately after the next-button of this type within the current buffer and returns a list of (button--label start-pos end-pos), or nil when none is found.--Optional STYLE is a display style specification to use when highlighting-buttons of this type; most useful when TO-P is also given.- Return symbol created when successful, else nil.  Nil indicates that action type for ibtype is presently undefined."+  (declare (indent defun)+           (doc-string 3)+           (debug (&define name lambda-list+                           [&optional stringp] ; Doc string, if present.+                           def-body)))   (when type-    (let ((to-func (when to-p (action:create nil (list to-p))))-	  (at-func (list at-p)))+    (let ((at-func (list at-p)))       `(progn (symtable:add ',type symtable:ibtypes) 	      (htype:create ,type ibtypes ,doc nil ,at-func-			    '(to-p ,to-func style ,style))))))--(defalias 'ibtype:create 'defib)-(put      'defib 'lisp-indent-function 'defun)+			    '(to-p nil style nil))))))

Skip this line.

matsl

comment created time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 Return nil if no matching button is found." 	  ;; `hbut:key-src' sets current buffer to key-src buffer. 	  (setq buffer (current-buffer))))       (when (and (stringp lbl-key) key-src)-	(when (stringp key-src)-	  (setq key-dir (file-name-directory key-src)-		key-file (file-name-nondirectory key-src)))+	;; (when (stringp key-src)+	;;   (setq key-dir (file-name-directory key-src)+	;; 	key-file (file-name-nondirectory key-src))) 	(set-buffer (find-file-noselect key-src)) 	(goto-char (point-min)) 	(ibut:next-occurrence lbl-key) 	;; Build and return button symbol with button properties-	(ibut:at-p)))))+	(ibut:at-p))));; )

Apply this hunk but get rid of everything commented out.

matsl

comment created time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 Return symbol for button deleted or nil."   (unless but-sym     (setq but-sym 'hbut:current))   (when (ibut:is-p but-sym)-    (let ((but-key (hattr:get but-sym 'lbl-key))+    (let (;; (but-key (hattr:get but-sym 'lbl-key)) 	  (loc     (hattr:get but-sym 'loc)) 	  (start   (hattr:get but-sym 'lbl-start)) 	  (end     (hattr:get but-sym 'lbl-end)))       (when (and start end)-	(save-excursion-	  (with-current-buffer (if (bufferp loc) loc (find-file-noselect loc))-	    (when (ibut:to (ibut:key but-sym))-	      (let (buffer-read-only)-		(if (< (point) start)-		    ;; Find beginning of button named label delimiter and delete-		    ;; from there.-		    (progn (goto-char (- (point) (length ibut:label-start)))-			   (delete-region (point) end))-		  ;; No label, just delete delimited ibutton text.-		  (delete-region start end))-		(when (looking-at "[ \t]*\r?\n")-		  (delete-region (point) (match-end 0)))-		(run-hooks 'ibut-delete-hook)))))+	(with-current-buffer (if (bufferp loc) loc (find-file-noselect loc))+	  (when (ibut:to (ibut:key but-sym))+	    (let ((inhibit-read-only t))+	      (if (< (point) start)+		  ;; Find beginning of button named label delimiter and delete+		  ;; from there.+		  (progn (goto-char (- (point) (length ibut:label-start)))+			 (delete-region (point) end))+		;; No label, just delete delimited ibutton text.+		(delete-region start end))+	      (when (looking-at "[ \t]*\r?\n")+		(delete-region (point) (match-end 0)))+	      (run-hooks 'ibut-delete-hook))))

Skip this hunk because we want save-excursion.

matsl

comment created time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 associated arguments from the button."       (unless (string-match "::" type-name) 	(setq ibut-type-symbol (intern-soft (concat "ibtypes::" type-name))))       (when ibut-type-symbol-	(let ((types (htype:category 'ibtypes))+	(let ((types (htype:category 'ibtypes)) ;FIXME: Unused? 	      ;; Global var used in (hact) function, don't delete.

Mats: Remove that first line of the let and run all your tests to see if anything breaks. If not, leave it out.

matsl

comment created time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 Return symbol for button deleted or nil."   (unless but-sym     (setq but-sym 'hbut:current))   (when (ibut:is-p but-sym)-    (let ((but-key (hattr:get but-sym 'lbl-key))+    (let (;; (but-key (hattr:get but-sym 'lbl-key))

Yes, okay to delete but-key here.

matsl

comment created time in 9 days

Pull request review commentrswgnu/hyperbole

Use interactive-form for action:commandp

 Return the symbol for the button when found, else nil." (defun    gbut:ibut-key-list ()   "Return a list of implicit button label keys from the global button file."   (when (file-readable-p gbut:file)-    (save-excursion-      (with-current-buffer (find-file-noselect gbut:file)-	(save-restriction-	  (widen)-	  (ibut:label-map #'(lambda (label start end) (ibut:label-to-key label))))))))+    (with-current-buffer (find-file-noselect gbut:file)+      (save-restriction+	(widen)+	(ibut:label-map #'(lambda (label _start _end) (ibut:label-to-key label)))))))

Need original save-excursion; do not apply this hunk.

matsl

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentrswgnu/hyperbole

Use browse-url--browser-defcustom-type for customization

 Hyperbole, and then restart Emacs." 	 (hyperbole-toggle-messaging (if value 0 1)))   :group 'hyperbole-buttons) -(defcustom hyperbole-web-search-browser-function browse-url-browser-function+(defcustom hyperbole-web-search-browser-function 'browse-url-default-browser

I don't think this line should change because the user may have chosen a different function to use here. Can discuss tomorrow if need be. -- Bob

matsl

comment created time in 10 days

PullRequestReviewEvent