profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/rohanpurohit/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Rohan Purohit rohanpurohit Pune, India

PR opened pez-globo/pufferfish-software

Refactor icons and controllers to feature folders domain: frontend stage: dev type: fix

This PR includes:

  • decompose icons from a top-level folder into feature folders
  • move Controllers to shared/values
  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? No
+44 -82

0 comment

48 changed files

pr created time in 4 days

push eventpez-globo/pufferfish-software

rohan

commit sha 6f1154c83b562aaa896c466dd4de79bc0007e5ea

fix build errors

view details

push time in 4 days

push eventpez-globo/pufferfish-software

Rohan Purohit

commit sha 6b40c3527e6fb6f3b67743ae35ed0faef6cc4096

Restructure frontend files into feature folders (#441) * move toolbar alarms to its folder * move shared files to shared feature folder * fix imports * move carousel to app/landing page * move units from info/ to shared/ * remane settings/containers folder to tabs * move more files to shared * fix imports * move rotary files into shared/rotary * resolve a couple of TODO's related to organizing * fix imports * fix eslint errors * move some files out of top level folders * fix imports * fix eslint errors

view details

push time in 4 days

delete branch pez-globo/pufferfish-software

delete branch : feature/frontend-file-structure

delete time in 4 days

PR merged pez-globo/pufferfish-software

Reviewers
Restructure frontend files into feature folders domain: frontend stage: dev type: chore

This PR includes:

  • Move alarms.tsx from alarms to app/toolbar
  • move shared components to top-level shared folder
  • move Carousel component to app/landing-page
  • rename modules/logs to modules/event-logs
  • remove ModesPage (it's deprecated)
  • move ModesDropDown to app (as this shows the current HFNC mode in some screens, therefore not removed, but needs to be deprecated later)
  • move rotary encoder related files to shared/rotary
  • move multistep wizard into a separate folder in app

TODO (for future PR):

  • decompose icons from top-level folder into feature folders
  • move Controllers to shared/values
+81 -329

3 comments

59 changed files

rohanpurohit

pr closed time in 4 days

push eventpez-globo/pufferfish-software

rohan

commit sha d6aac6ea3f4488247e06d354ebf1de1ad96d4019

fix eslint errors

view details

push time in 4 days

pull request commentpez-globo/pufferfish-software

Restructure frontend files into feature folders

Tested the frontend and accessed standard features on the backend simulator and everything looks good to me. since these were just file restructuring and the content inside the files hasn't changed, I'll be merging this in.

rohanpurohit

comment created time in 4 days

push eventpez-globo/pufferfish-software

Raavi

commit sha 964ac3611a7a798e087a813632902ab3328f66f4

Unit test for Util (#425) * Unit test for Util 1.EnumMap 2.EnumSet 3.OrderedMap 4.RingBuffer * Unit Test cases for 1. EnumMap 2.EnumSet 3.OrderedMap * Additional test cases for 1.EnumMap 2.EnumSet 3.OrderedMap 4.RingBuffer 5.Vector Solved an issue for vector initializer list in Vector.h file * Catch2-clang-tidy fixes * Catch2-clang-tidy fixes * Catch2-clang-tidy * Catch2-clang-tidy fix * More unit tests for 1. EnumMap 2. EnumSet 3. OrderedMap 4. RingBuffer 5. Vector * Catch2-clang-tidy fixes * Catch2-clang-tidy * Catch2-Clang-Tidy fixes * Clang-tidy fix * Added tests in EnumMap for struct and cpp check error * Test cases for RingBuffer Fixed clang-tidy error * Clang-tidy fix * Clang-tidy fixes * Clang-tidy fix * Cpp-check error fix * Additional test for 1.EnumMap 2.EnumSet 3.OrderedMap 4.RingBuffer

view details

Raavi

commit sha 9109acee99fdbc158d4d822145c564578e9bfa7f

Unit Test case for SFM3019 Device (#437) * Unit Test case for SFM3019 * SFM3019 Device Unit Test * Clang-tidy fixes * More test for SFM3019 Device.cpp file * More Test cases for Device.h * Catch-clang-tidy fixes * Catch2-clang-tidy fixes * Format fixes * Additional tests and structural changes for Device.txt file * Catch2-clang-tidy fixes * Additional test in read_conversion factor and read_sample read_product_id is spilt into request_product_id and read_product_id * clang-tidy fixes * Format fixes * Structure changes in Device.txt file * Catch2-clang-tidy fixes * Structrural changes in request_conversion_factors and read_conversion_factors and read_sample function in txt file * Device.txt file small changes for typos

view details

Rohan Purohit

commit sha f09087d83d3598e5974413fdb17f3d8b354f199b

Reorganize some selectors and reducers (#442) * restructure selectors and reducers * rename updateState to receive message * make screen lock a request/response * fix pylint errors * fix eslint errors * fix build error * add screen lock simulator in the firmware * add screen_status_request to mc ouptut sched

view details

rohan

commit sha 22c998009b94a7f065cf1f1cba2e1291793827fc

Merge branch 'develop' into feature/frontend-file-structure

view details

rohan

commit sha 2449c925ffacf803133476d9a82294f89a1c9fa4

fix imports

view details

push time in 4 days

push eventpez-globo/pufferfish-software

Rohan Purohit

commit sha f09087d83d3598e5974413fdb17f3d8b354f199b

Reorganize some selectors and reducers (#442) * restructure selectors and reducers * rename updateState to receive message * make screen lock a request/response * fix pylint errors * fix eslint errors * fix build error * add screen lock simulator in the firmware * add screen_status_request to mc ouptut sched

view details

push time in 5 days

delete branch pez-globo/pufferfish-software

delete branch : feature/frontend-redux-restructure

delete time in 5 days

PR merged pez-globo/pufferfish-software

Reorganize some selectors and reducers domain: frontend stage: dev type: chore

This PR includes:

  • Resolves some TODO'S in redux store
  • implement screen lock in the simulator
  • implement screen lock in the firmware
+900 -615

4 comments

59 changed files

rohanpurohit

pr closed time in 5 days

pull request commentpez-globo/pufferfish-software

Reorganize some selectors and reducers

Tested this branch on the backend simulator, while checking the redux console for any regressions and accessed standard features of the frontend and there are no regressions that I faced, merging this now.

rohanpurohit

comment created time in 5 days

pull request commentpez-globo/pufferfish-software

Reorganize some selectors and reducers

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
  2. Were any of these contributions also part of work you did for an employer or a client? No.
  3. Does this work include, or is it based on, any third-party work which you did not create? No.
rohanpurohit

comment created time in 11 days

pull request commentpez-globo/pufferfish-software

Restructure frontend files into feature folders

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
  2. Were any of these contributions also part of work you did for an employer or a client? No.
  3. Does this work include, or is it based on, any third-party work which you did not create? No.
rohanpurohit

comment created time in 11 days

push eventpez-globo/pufferfish-software

rohan

commit sha 0d0a321aa92aadd2bfd4a723583cad1683a77e36

add screen lock simulator in the firmware

view details

rohan

commit sha 38f0e2052d52f3b3112898429bd2e062ecdc66d6

add screen_status_request to mc ouptut sched

view details

push time in 12 days

push eventpez-globo/pufferfish-software

rohan

commit sha b84b181ddd863068ae7543dbd8210cc6cb6ff018

move some files out of top level folders

view details

push time in 13 days

push eventpez-globo/pufferfish-software

rohan

commit sha e50271fc95071e18855de950b6e972a4ff7ecc52

move some files out of top level folders

view details

push time in 13 days

PR opened pez-globo/pufferfish-software

Reviewers
Reorganize some selectors and reducers domain: frontend stage: dev type: chore

This PR includes:

  • Resolves some TODO'S in redux store
  • implement screen lock in the simulator
+802 -613

0 comment

52 changed files

pr created time in 14 days

push eventpez-globo/pufferfish-software

rohan

commit sha 1245a73c58031c9b1be53e3f45d4066935a7eed8

fix build error

view details

push time in 14 days

push eventpez-globo/pufferfish-software

rohan

commit sha 97985611e34f2b392ba4f4b1772a92c031688efd

fix eslint errors

view details

push time in 14 days

PR opened pez-globo/pufferfish-software

Restructure frontend files into feature folders domain: frontend stage: dev type: chore
+64 -83

0 comment

58 changed files

pr created time in 15 days

create barnchpez-globo/pufferfish-software

branch : feature/frontend-file-structure

created branch time in 15 days

push eventpez-globo/pufferfish-software

Rohan Purohit

commit sha 14c10fdcb16a11cb05b93d734e392c8651d9b433

Move files from app/ to feature folders (#438) * move sidebar to it's own feature folder * move more files from app to feature folders * update reducers to remove usage of new Date * improve actions * move self-contained battery selectors out of selectors.ts * remove unused import * refactor folder structure for app/ * fix eslint warnings * move navigation and toolbar to app * fix eslint errors

view details

push time in 25 days

delete branch pez-globo/pufferfish-software

delete branch : hotfix/frontend-app-decluster

delete time in 25 days

PR merged pez-globo/pufferfish-software

Move files from app/ to feature folders domain: frontend stage: dev type: chore

This PR:

  • Move new Date() calls from reducers to their respective actions
  • Move files from modules/app to feature folders
    • Toolbar related files to toolbar folder
    • sidebar related files to sidebar
    • overlayscreen to overlay
+134 -168

2 comments

43 changed files

rohanpurohit

pr closed time in 25 days

pull request commentpez-globo/pufferfish-software

Move files from app/ to feature folders

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? No
rohanpurohit

comment created time in 25 days

push eventpez-globo/pufferfish-software

Rohan Purohit

commit sha 6f6e1295ac995c4e608690c5d8f1c462e08d5039

Improve some of the driver interfaces for the Nonin sensor (#434) * Update few statuses and functions in FrameReceiver * some code improvements in PacketReceiver * rename start_of_packet_status to at_start_of_frame * Update interface for framebuffer * Update high level driver * add AlarmService for nonin sensor * add alarms for various sensor statuses * Trigger alarms for measurements out of track * fix clang-tidy errors * trigger alarm for failed sensor output * Sensor: add wait time for setup and output and return failed if exceeded * fix clang-tidy errors * add logevent codes for various nonin sensor alarms * SensorAlarmService: update alarm codes array * Sensor: return InitializableState::setup for setup() method * update high level driver * pass sensor_connections as an output parameter * Sensor: update setup and output method logic * sensor: minor improvements * remove unnecessary extern defs * update few methods of framereceiver * PacketReceiver: update singal perfusion logic * sensor: misc improvements * update sensoralarmservice * fix unit test cases * FrameReceiver: remove extern * add code comment for frameBuffer full status * Sensor: add a reset timer method call before the main loop starts to avoid failing * remove unnecessary if statement * fix the order of post_setup_reset call * Sensor: increase measurement timeout to 5 seconds * fix hr showing 127 instead of NaN * refactor hr data * Fix HR measurement loss, add frontend display config for Nonin alarms Co-authored-by: Ethan Li <lietk12@gmail.com>

view details

push time in 25 days

delete branch pez-globo/pufferfish-software

delete branch : feature/firmware-nonin-refactor

delete time in 25 days