profile
viewpoint
Ruslan Hrabovyi ro0gr LigaDigital Kyiv

ro0gr/ember-cli-open 1

Opens ember-cli application in browser

ro0gr/boilerplate-update 0

Update boilerplate code between versions

ro0gr/broccoli-svg-optimizer 0

Broccoli plugin for optimizing SVG files by SVGO with a persistent cache for fast restarts

ro0gr/code-corps-ember 0

Ember web application for Code Corps.

ro0gr/data 0

A data persistence library for Ember.js.

ro0gr/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

issue commentemberjs/ember.js

Angle bracket component with splattributes not correctly merging attributes

This has come up on discord again. Not documented. No error. Just lucky if someone manages to find this thread or asks on discord and someone is around that knows the issue.
This is a major bug open for over a year.

barryofguilder

comment created time in 4 hours

issue openedember-cli/ember-cli

Add eslint-plugin-qunit to blueprint

Have we ever considered adding/enabling eslint-plugin-qunit linting to the Ember blueprints? It's a great plugin for enforcing QUnit best practices in tests, and I consider it to be the most useful/relevant linting plugin that we haven't added to the blueprint yet. I use in many of my Ember apps/addons.

If there's interest, I could put together an RFC similar to the recent prettier RFC.

created time in 4 hours

issue commentemberjs/rfcs

Feature Request: consistent API between classic and Glimmer components

If talks about use cases, for example, I have wrote an addon with itemscontrol (like in wpf), where component (item container) should be created in code, in response to itemcollection changing. Now I have to create model of component and render it in template. I would like to create and initialize component in code and manage component lifecycle by myself.

boris-petrov

comment created time in 5 hours

issue commentemberjs/rfcs

Component helper in JS

If talks about use cases, for example, I have wrote an addon with itemscontrol (like in wpf), where component should be created in code, in response to itemcollection changing. Now I have to create model of component and render it in template. I would like to create and initialize component in code and manage component lifecycle by myself.

mehulkar

comment created time in 5 hours

issue commentemberjs/ember.js

Redirecting a transition to same route with different query params does not work unless transition is aborted before

I am experiencing the same issue where an exception is thrown when the application is loaded on the route which is transitioning only to change the query-params. It's a very simple reproduction in 3.22: https://github.com/kmccullough/ember-default-query-param

jelhan

comment created time in 7 hours

issue openedember-template-lint/ember-template-lint

ember-template-lint in Github actions in PR makes annotation show twice

I have set-up github action so that it runs ember-template-lint . for every pull-request to the repo.

But what I see is the annotations are getting duplicated (shown twice) in github PR files page. Which I do not want.

Eg: image

"Interaction added to non-interactive element" error has been annotated twice as well as "Do not use action as..." error.

You can view the sample PR I created here: https://github.com/Robin-Thomas-577/ember-template-lint-sample-repo/pull/1/files

Interestingly, if passed DISABLE_GITHUB_ACTIONS_ANNOTATIONS=trueonly one annotation is shown. But I thought DISABLE_GITHUB_ACTIONS_ANNOTATIONS was to disable annotation altogether!

package versions used ember-cli: 3.22.0 node: 12.19.0 ember-template-lint: 2.14.0

created time in 8 hours

issue commentemberjs/ember.js

[Bug] Unicode Emojis Break Build

Thank you for the detailed explaination and the fix @rwjblue 👍

srsgores

comment created time in 9 hours

issue commentemberjs/ember.js

<textarea> `disabled` and `{{on "blur" this.onBlur}}` don't seem to work in combination

LMK if a failing test would be useful, I'd be happy to add one

GavinJoyce

comment created time in 13 hours

issue openedsalsify/ember-css-modules

Virtual modules as transitive dependency break build

If an addon (direct-addon) has a dependency onto another addon (intermediary-addon) that depends on a third addon ('transitive-addon') that provides virtual modules, the build breaks.

  • host-app
    • app with a direct dependency on direct-addon
  • direct-addon
    • addon with a direct dependency on intermediary-addon
    • composes local-classes from intermediary-addon physical .css files
  • intermediary-addon
    • addon with a direct dependency on transitive-addon
    • imports @values or composes local-classes from transitive-addon's virtual modules
  • transitive-addon
    • an addon without any physical .css files
    • provides virtual modules

Running ember s inside intermediary-addon works. But running ember s inside direct-addon or host-app does not.

The actual error thrown is:

Error: Unable to resolve styles module 'transitive-addon/virtual-module' imported from '/Users/jan/demo/direct-addon/addon/components/some-component/styles.css'. No virtual module with that name was defined and no corresponding addon was found.
    at resolveExternalPath (/Users/jan/demo/node_modules/ember-css-modules/lib/resolve-path.js:55:11)
    at ModulesPreprocessor.resolvePath [as _resolvePath] (/Users/jan/demo/node_modules/ember-css-modules/lib/resolve-path.js:14:12)
    at ModulesPreprocessor.resolvePath (/Users/jan/demo/node_modules/ember-css-modules/lib/modules-preprocessor.js:185:17)
    at ModulesPreprocessor.resolveAndRecordPath (/Users/jan/demo/node_modules/ember-css-modules/lib/modules-preprocessor.js:156:25)
    at CSSModules.fetchExports (/Users/jan/demo/node_modules/broccoli-css-modules/index.js:138:29)
    at fetchImport (/Users/jan/demo/node_modules/broccoli-css-modules/lib/link-modules.js:40:34)
    at /Users/jan/demo/node_modules/broccoli-css-modules/lib/link-modules.js:31:20
    at Root.each (/Users/jan/demo/node_modules/postcss/lib/container.js:105:16)
    at fetchAllImports (/Users/jan/demo/node_modules/broccoli-css-modules/lib/link-modules.js:29:7)
    at /Users/jan/demo/node_modules/broccoli-css-modules/lib/link-modules.js:19:24

But it gets swallowed as:

Error: Unable to locate module "direct-addon/components/some-component/styles" imported from /var/folders/zd/7ly06mpn2t512t2fr1g1ppw80000gq/T/broccoli-88502T1X0zlnjt79z/out-3664-module_source_funnel/direct-addon/components/other-component/styles.css
    at ModulesPreprocessor.onModuleResolutionFailure (/Users/jan/demo/node_modules/ember-css-modules/lib/modules-preprocessor.js:133:11)
    at /Users/jan/demo/node_modules/broccoli-css-modules/lib/link-modules.js:54:13
    at tryCatcher (/Users/jan/demo/node_modules/rsvp/dist/lib/rsvp/-internal.js:39:19)
    at invokeCallback (/Users/jan/demo/node_modules/rsvp/dist/lib/rsvp/-internal.js:211:31)
    at publish (/Users/jan/demo/node_modules/rsvp/dist/lib/rsvp/-internal.js:197:7)
    at publishRejection (/Users/jan/demo/node_modules/rsvp/dist/lib/rsvp/-internal.js:132:3)
    at flush (/Users/jan/demo/node_modules/rsvp/dist/lib/rsvp/asap.js:80:5)
    at processTicksAndRejections (internal/process/task_queues.js:75:11)

When I add transitive-addon as a direct dependency to direct-addon as well, it works.

created time in 14 hours

issue openedemberjs/ember.js

<Textarea> `@disabled` and `{{on "blur" this.onBlur}}` don't seem to work in combination

🐞 Describe the Bug

There seems to be a new class of backtracking error present in 3.23.1 but not in 3.21.3. While there is no error in 3.21.3, the behaviour seems like a bug to me.

🔬 Minimal Reproduction

I've created a reproduction here: https://github.com/GavinJoyce/backdrifts/pull/6

[isFocused: {{this.isFocused}}, isDisabled: {{this.isDisabled}}]
<br>
<Textarea
  {{on "keydown" this.onKeyDown}}
  {{on "focus" this.onFocus}}
  {{on "blur" this.onBlur}}
  @disabled={{this.isDisabled}}
  class="bg-yellow-200"
  placeholder="type something then press enter"
/>
export default class extends Component {
  @tracked isFocused = false;
  @tracked isDisabled = false;

  @action
  onFocus() {
    this.isFocused = true;
  }

  @action
  onBlur() {
    this.isFocused = false;
  }

  @action
  onKeyDown(e) {
    switch (e.keyCode) {
      case 13: // Enter
        e.preventDefault();
        this.isDisabled = true;
        break;
    }
  }
};

😕 Actual Behavior

In 3.23.1, when this.isDisabled is set to true (by pressing enter), a backtracking error is emitted:

Screenshot 2020-11-27 at 12 24 19

In 3.21.3, there is no error, but isFocused remains true even though the onBlur action sets it to false:

Screenshot 2020-11-27 at 12 27 14

🤔 Expected Behavior

I'd expect no error to be emitted and isFocused to be false.

🌍 Environment

  • Ember: 3.23.1
  • Node.js/npm: v14.15.0 / 6.14.8
  • OS: OSX
  • Browser: Chrome

created time in 14 hours

issue commentemberjs/ember.js

[Bug] Ember Data error after upgrading Ember to 3.21.1

Upgrading Ember Data does not produce the Ember Data error.

It is just upgrading Ember, that produces the Ember Data error.

What could the interaction be between Ember and Ember Data, that could cause this? It doesn't make any sense to me!

amk221

comment created time in 16 hours

PR opened ember-template-lint/ember-template-lint

Implement `splat-attributes-only` rule

splat-attributes-only

It is easy to introduce typos when typing out ...attributes or to use e.g. ...arguments instead. Unfortunately, that leads to a cryptic runtime error, but does not fail the build.

This rule warns you when you use an attribute starting with ... that is not ...attributes.

Examples

This rule forbids the following:

<div ...atributes></div>
<div ...arguments></div>

This rule allows the following:

<div ...attributes></div>
+86 -0

0 comment

5 changed files

pr created time in 16 hours

push eventember-learn/ember-cli-addon-docs

GitHub Actions

commit sha b989975e3f628604e2fb303c5808f10658715d88

Deployed c7349e2

view details

push time in 17 hours

delete branch ember-learn/ember-cli-addon-docs

delete branch : dependabot/npm_and_yarn/release-it-14.2.2

delete time in 18 hours

push eventember-learn/ember-cli-addon-docs

dependabot-preview[bot]

commit sha c7349e2d38661591b92e4332d2689a6e167c5142

Bump release-it from 14.2.1 to 14.2.2 (#653)

view details

push time in 18 hours

PR merged ember-learn/ember-cli-addon-docs

Bump release-it from 14.2.1 to 14.2.2 dependencies

Bumps release-it from 14.2.1 to 14.2.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/release-it/release-it/releases">release-it's releases</a>.</em></p> <blockquote> <h2>Release 14.2.2</h2> <ul> <li>Fix lint issue (a2b68ed)</li> <li>Update dependencies (2ebeadb)</li> <li>Fix failing test by ignoring OS-based path (0b9aa23)</li> <li>Add test for plugin context (c628990)</li> <li>Remove unusde variables (3082fc5)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/release-it/release-it/commit/71f18120ebaadba93576d42da8072ec1a960c7ed"><code>71f1812</code></a> Release 14.2.2</li> <li><a href="https://github.com/release-it/release-it/commit/a2b68ed75d2c78361b8725ee68573503baf82fd7"><code>a2b68ed</code></a> Fix lint issue</li> <li><a href="https://github.com/release-it/release-it/commit/2ebeadb315054e8dbc8ea9bb0af1324e810e1e0a"><code>2ebeadb</code></a> Update dependencies</li> <li><a href="https://github.com/release-it/release-it/commit/0b9aa23c8b4e096d497c7b44b189c1db8bad6222"><code>0b9aa23</code></a> Fix failing test by ignoring OS-based path</li> <li><a href="https://github.com/release-it/release-it/commit/c628990110d36cb62db948bc47a6762adacb957d"><code>c628990</code></a> Add test for plugin context</li> <li><a href="https://github.com/release-it/release-it/commit/3082fc503dccbf3b7ba27c227d7648ca6bdb5294"><code>3082fc5</code></a> Remove unusde variables</li> <li>See full diff in <a href="https://github.com/release-it/release-it/compare/14.2.1...14.2.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+41 -34

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 18 hours

PR opened ember-learn/ember-cli-addon-docs

Bump release-it from 14.2.1 to 14.2.2

Bumps release-it from 14.2.1 to 14.2.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/release-it/release-it/releases">release-it's releases</a>.</em></p> <blockquote> <h2>Release 14.2.2</h2> <ul> <li>Fix lint issue (a2b68ed)</li> <li>Update dependencies (2ebeadb)</li> <li>Fix failing test by ignoring OS-based path (0b9aa23)</li> <li>Add test for plugin context (c628990)</li> <li>Remove unusde variables (3082fc5)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/release-it/release-it/commit/71f18120ebaadba93576d42da8072ec1a960c7ed"><code>71f1812</code></a> Release 14.2.2</li> <li><a href="https://github.com/release-it/release-it/commit/a2b68ed75d2c78361b8725ee68573503baf82fd7"><code>a2b68ed</code></a> Fix lint issue</li> <li><a href="https://github.com/release-it/release-it/commit/2ebeadb315054e8dbc8ea9bb0af1324e810e1e0a"><code>2ebeadb</code></a> Update dependencies</li> <li><a href="https://github.com/release-it/release-it/commit/0b9aa23c8b4e096d497c7b44b189c1db8bad6222"><code>0b9aa23</code></a> Fix failing test by ignoring OS-based path</li> <li><a href="https://github.com/release-it/release-it/commit/c628990110d36cb62db948bc47a6762adacb957d"><code>c628990</code></a> Add test for plugin context</li> <li><a href="https://github.com/release-it/release-it/commit/3082fc503dccbf3b7ba27c227d7648ca6bdb5294"><code>3082fc5</code></a> Remove unusde variables</li> <li>See full diff in <a href="https://github.com/release-it/release-it/compare/14.2.1...14.2.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+41 -34

0 comment

1 changed file

pr created time in 18 hours

Pull request review commentkategengler/ember-cli-code-coverage

ember-cli-update to Ember 3.22 blueprint

 module.exports = {   env: {     browser: true,   },-  rules: {-    'ember/no-jquery': 'error',

why did you remove this rule?

loganrosen

comment created time in 18 hours

Pull request review commentkategengler/ember-cli-code-coverage

ember-cli-update to Ember 3.22 blueprint

 module.exports = async function () {   return {     scenarios: [       {-        name: 'ember-lts-3.12',+        name: 'ember-lts-3.16',

why are you dropping support for Ember 3.12?

loganrosen

comment created time in 18 hours

Pull request review commentkategengler/ember-cli-code-coverage

ember-cli-update to Ember 3.22 blueprint

 module.exports = async function () {           },         },       },-      // The default `.travis.yml` runs this scenario via `npm test`,-      // not via `ember try`. It's still included here so that running-      // `ember try:each` manually or from a customized CI config will run it-      // along with all the other scenarios.-      {-        name: 'ember-default',-        npm: {-          devDependencies: {},-        },-      },

why are you removing this scenario?

loganrosen

comment created time in 18 hours

issue openedemberjs/ember-test-helpers

Create a new helper ("getCurrentPathName" or similar) to better deal with "toc_routing-transition-methods" deprecation ?

Hi !

According to this deprecation I started to replace some calls to replaceRoute & transitionToRoute by calls on router service on my ember App...

The result was a lot of failing test (mainly test using getCurrentURL helper) because of URL now includes Query Params :

Calling transitionTo from the Router service will cause default query parameter values to be included in the URL. (see RouterService transitionTo documentation)

On some test, I replaced the getCurrentURL by getCurrentRouteName helper & it works great.

But for some tests, I can't because I need to test the route, but also the dynamic segment value like :

assert.equal(
  getCurrentURL(),
  `a/route/with/${model_id}/model`,
  "..."
)

What I've done to fix this, is create a new helper returning only the pathName of the current URL.

So I'm wonder if a such helper could be implemented here as a part of ember-test-helpers ?

I can create a PR for this, but just want to be sure it's a good idea before working on it :thinking:

created time in 19 hours

delete branch emberjs/ember.js

delete branch : cron-master-49214a7004c3a8628be014985b5d4b83b702e3c1

delete time in 19 hours

delete branch emberjs/ember.js

delete branch : cron-release-b5cc394e0c59abf210a3bbc5b752fdf3a95f1aec

delete time in 19 hours

delete branch emberjs/ember.js

delete branch : cron-beta-ea3c87d46ecc1914aa1fee714ba8a480926d1cca

delete time in 19 hours

delete branch typed-ember/ember-cli-typescript

delete branch : 2.x

delete time in a day

push eventember-template-lint/ember-template-lint

Alex LaFroscia

commit sha 4e6284552664e18ac7ebda5771cb86c80b4088b9

feat: add `no-down-event-binding` rule

view details

Bryan Mishkin

commit sha b7d7303b9957cd65d0d053ddd948067500dbe39a

Merge pull request #1620 from alexlafroscia/no-down-event-binding Add new rule `no-down-event-binding`

view details

push time in a day

more