profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/rmagatti/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ronnie Magatti rmagatti @neofinancial Calgary A passionate open source loving developer who has a thing for Kotlin and Neovim. Currently building Canada's best challenger bank at @neofinancial. 🇨🇦

rmagatti/auto-session 259

A small automated session manager for Neovim

rmagatti/goto-preview 151

A small Neovim plugin for previewing definitions using floating windows.

rmagatti/session-lens 77

A session-switcher extension for rmagatti/auto-session using Telescope.nvim

rmagatti/alternate-toggler 18

A very small plugin for toggling alternate "boolean" values.

rmagatti/language-kivy 7

Language definition for the Kivy Language

rmagatti/dotfiles 6

Collection of my dotfiles. Likely unpolished and at times forgotten but always around. :wink:

rmagatti/autoreggol 4

A collection of handy decorators for auto logging class methods and properties.

rmagatti/tree-sitter-terraform 4

Tree Sitter grammar for Terraform (hcl2)

rmagatti/dota2herovoices 1

Dota 2 Hero Voices made with Kivy Framework.

PullRequestReviewEvent

issue commentrmagatti/goto-preview

LSP Documentation not showing in first try

This has likely to do with the z-index. When opening a preview window, I don't actually set the z-index anymore. The reason calling it again seems to make it show up above is probably because that focuses the popup window, which I'm assuming changes its z-index to be the upper most. I'm not entirely sure this is fixable within goto-preview tbh. Might be something to fix upstream 🤔

marcelarie

comment created time in 3 days

push eventrmagatti/goto-preview

Ronnie Magatti

commit sha 05383bbbfccbf4fd6a4527ef8383270d03dde833

Update issue templates

view details

push time in 3 days

push eventrmagatti/goto-preview

Sávio Carlos Martins Costa

commit sha 835f847343fbbd40afefb87c20fc010c6e6c6c89

add option to modify the floating window border in the setup function

view details

Sávio Carlos Martins Costa

commit sha 56b8d4aef96bb8ce219b4ff68e30f4f6727179d6

document the new option in the README file

view details

Ronnie Magatti

commit sha 05c6983e6d6cb6e35367a13eeda1ffb160f48753

Merge pull request #33 from saviocmc/add-option-to-modify-border-in-setup Add option to modify the floating window border in the setup function

view details

push time in 6 days

PR merged rmagatti/goto-preview

Add option to modify the floating window border in the setup function

Add an entry "border" in the default conf table, allowing the user to customize it in the setup function. My use case was to be able to use the same border style for all plugins the use floating windows, as nvim-lspconfig and telescope. They both let you define custom borders for the floating windows.

+3 -1

1 comment

3 changed files

saviocmc

pr closed time in 6 days

PullRequestReviewEvent

issue closedrmagatti/auto-session

Runtime path is messed up when plugin loaded

I'll try to explain a weird problem I had today and explain why I believe this has to do with this plugin (I have been using this plugin for some time and had no issues before this). I opened Neovim and suddenly had no TreeSitter syntax highlighting anymore, like this: Screenshot from 2021-08-23 21-03-53

Then I tried running :checkhealth and got this error: E5009: Invalid 'runtimepath'

So I checked set runtimepath? which prints this output (shortened for readability):

runtimepath=~/.config/nvim, [...], /tmp/.mount_nvim8wjgL7/usr/share/nvim/runtime,/tmp/.mount_nvim8wjgL 7/usr/share/nvim/runtime/pack/dist/opt/matchit,/tmp/.mount_nvim8wjgL7/usr/lib/nvim, [...]

Notice the path is .mount_nvim8wjgL7.

I read here that the runtime path must contain the result of $VIMRUNTIME.

This was not the case for me since echo $VIMRUNTIME prints /tmp/.mount_nvimbXWU5b/usr/share/nvim/runtime (this time it's a different path .mount_nvimbXWU5b)

I then disabled the auto-session plugin and all the problems were gone. So I assume that the session is somehow loaded incorrectly.

Does this even have to do something with this plugin or is this a Neovim specific issue? I hope this made any sense ^^

Thanks for your time!

closed time in 7 days

jonasstr

issue commentrmagatti/auto-session

Runtime path is messed up when plugin loaded

I'll be closing this for now then!

jonasstr

comment created time in 7 days

PullRequestReviewEvent

pull request commentrmagatti/session-lens

Feature: ability to provide a theme in setup other than get_dropdown

@tiagovla yes, something like: use the theme_conf if passed in with a vim.tbl_extend on whatever the uses passes into the theme setting instead of using the theme setting straight up?

I can elaborate if that wasn't clear 😅

tiagovla

comment created time in 7 days

pull request commentrmagatti/auto-session

Quietly restore a session

@tiagovla thanks for addressing the changes! Would you mind adding something to the README about this option? If not that's alright too, I'll add some stuff later today or tomorrow!

tiagovla

comment created time in 7 days

issue commentrmagatti/session-lens

Confirm session load twice

@mrdgo, yeah so this likely comes from a combination of two things.

  1. The commands not being silent
  2. Your cmdheight is probably only one line of height.

@tiagovla's PR fixes it mostly by turning the restore command from auto-session silent, but you'd still have to confirm even after his PR is merged if your cmdheight is only one and the plugin's log_level is set to anything too noisy.

fyi this is a Vim thing. Ref: https://vim.fandom.com/wiki/Avoiding_the_%22Hit_ENTER_to_continue%22_prompts

mrdgo

comment created time in 8 days

PullRequestReviewEvent

push eventrmagatti/auto-session

Ronnie Magatti

commit sha 6f9506c1a8445b902e121a630613b94c8b0cd52a

Update issue templates

view details

push time in 8 days

push eventrmagatti/auto-session

Ronnie Magatti

commit sha f74e0e118a15ed4905a74265053b86eb0650fecf

Update issue templates

view details

push time in 8 days

issue commentrmagatti/auto-session

Runtime path is messed up when plugin loaded

Hey, sorry about the delay here! So yeah, I don't know exactly why but having options in sessionoptions causes all sorts of issues for me too, for example with the way packer lazy loading and its keys feature works, when I have options set, it'll never reverse the mapping for the packer lazy loading i.e require('packer.load')({'plugin-name'})..., I assume because saving the session ends up saving the current value of the mapping, i.e post lazy loading. And this is just one of the weird things I saw, there were other things I couldn't quite pinpoint. 😞

jonasstr

comment created time in 8 days

issue openedrmagatti/auto-session

Enable CI

Setup CI with:

  1. Test runs
  2. Formatting and linting.

created time in 8 days

PullRequestReviewEvent

Pull request review commentrmagatti/auto-session

Quietly restore a session

 local defaultConf = {   auto_restore_enabled = nil, -- Enables/disables auto restore feature   auto_session_suppress_dirs = nil, -- Suppress session restore/create in certain directories   auto_session_allowed_dirs = nil, -- Allow session restore/create in certain directories+  restore_quietly = false,

I'd probably change this to just be silent = false.

tiagovla

comment created time in 8 days

Pull request review commentrmagatti/auto-session

Quietly restore a session

 end ------ MAIN FUNCTIONS ------ function AutoSession.AutoSaveSession(sessions_dir)   if is_enabled() and auto_save() and not suppress_session() and is_allowed_dir() then-	if not is_auto_create_enabled() then-	  local session_file_name = get_session_file_name(sessions_dir)-	  if not Lib.is_readable(session_file_name) then-	    return-	  end-	end-	AutoSession.SaveSession(sessions_dir, true)+    if not is_auto_create_enabled() then+      local session_file_name = get_session_file_name(sessions_dir)+      if not Lib.is_readable(session_file_name) then+        return+      end+    end+  AutoSession.SaveSession(sessions_dir, true)

This should probably be indented another value to the right from the looks of it?

tiagovla

comment created time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentrmagatti/session-lens

Feature: ability to provide a theme in setup other than get_dropdown

 SessionLens.search_session = function(custom_opts)     custom_opts.shorten_path = nil   end -  local theme_opts = themes.get_dropdown(custom_opts.theme_conf)+  local theme_opts+  if custom_opts ~= nil then+      theme_opts = custom_opts.theme(custom_opts.theme_conf)+  else+      theme_opts = themes.get_dropdown(custom_opts.theme_conf)+  end

Hey, thanks for the PR! Mind making this 2 spaces to maintain the standard?

tiagovla

comment created time in 10 days

PullRequestReviewEvent

issue commentneovim/neovim

LSP: code actions handler is not called after update

@mjlbach @mfussenegger something I'm not quite getting with overriding vim.ui.select is how could one have different UIs for different LSP handlers exactly?

In the code for https://github.com/gbrlsnchs/telescope-lsp-handlers.nvim for example, one could override a particular handler in a particular way, for code actions for example I'd configure it to use the telescope cursor theme. But for other handlers like "references" I'd use the regular theme where previews were available for example.

With having to override a single point, i.e vim.ui.select I don't quite see how I'd pull this off? Maybe by doing the LSP call manually myself but if that's the case it seems to me like something was easier to do before than it is now with the new changes and maybe there's a way to make things more granular going forward?

Disclaimer: I don't really know enough about how all of this works to be certain I'm making valid observations here, please enlighten me if perhaps I'm just blatantly missing something.

gfanto

comment created time in 15 days

push eventrmagatti/auto-session

Yuta Katayama

commit sha a47458b1f258273187fa6b8c1e30a98d8c6b8da6

Fix the directory

view details

Ronnie Magatti

commit sha dc7619fc3c6e3368ae449bf8ae1ad7630a720406

Merge pull request #71 from yutkat/patch-1 Fix the directory

view details

push time in 16 days

PR merged rmagatti/auto-session

Fix the directory
+1 -1

0 comment

1 changed file

yutkat

pr closed time in 16 days

PullRequestReviewEvent

push eventrmagatti/dotfiles

Ronnie Magatti

commit sha 7b3a9f17970f49064a6b17d440c179e721b0b036

Starting jest debug stuff. Also add a :windo diffthis mapping.

view details

push time in 17 days

push eventrmagatti/goto-preview

Clément Joly

commit sha e4a29111369a405692bb103047dfcd45e41d2b89

Update on the Neovim TUI bug Version 0.5.1 is now out and include the relevant fix! https://github.com/neovim/neovim/commit/0159e4daaed1347db8719c27946fcfdc4e49e92d

view details

Clément Joly

commit sha 94cd4cbe6b2f216b37ca057861939ef4fc021b8c

Add default telescope mapping to the documentation

view details

Ronnie Magatti

commit sha b04d83414d113aedf2e4beb1dd030f8a909ee8a8

Merge pull request #32 from cljoly/doc-improvements Improvements to the documentation

view details

push time in 19 days