profile
viewpoint
Rijk van Zanten rijkvanzanten @directus New York City https://rijks.website Builder of things, designer of stuff.

issue commentdirectus/directus

File attached to entity ends forbidden to see after session expired

Status for missing items is currently always 403, regardless of source. The main improvement here is that we want to update the file interfaces to show "couldn't load file" rather than throw the unexpected error modal 👍🏻

desirelabs

comment created time in 12 hours

create barnchdirectus/directus

branch : translations

created branch time in 14 hours

PR opened directus/directus

New Crowdin updates
+14 -0

0 comment

1 changed file

pr created time in 14 hours

push eventdirectus/directus

Rijk van Zanten

commit sha b8b339b50a8deeebfbc5c98424d354bec745bd56

New translations en-US.yaml (Polish)

view details

push time in 14 hours

create barnchdirectus/directus

branch : translations

created branch time in 14 hours

push eventdirectus/directus

Rijk van Zanten

commit sha fc9834e31632be6582f216173c5d990cabeae41f

New translations en-US.yaml (Russian)

view details

push time in 15 hours

PR opened directus/directus

New Crowdin updates
+2 -0

0 comment

1 changed file

pr created time in 15 hours

create barnchdirectus/directus

branch : translations

created branch time in 15 hours

PR opened directus/directus

New Crowdin updates
+30 -0

0 comment

1 changed file

pr created time in 15 hours

push eventdirectus/directus

Rijk van Zanten

commit sha 9505b304f208c96f495c46d3c58e8644cea501ae

New translations en-US.yaml (Russian)

view details

push time in 15 hours

push eventknex/knex-schema-inspector

rijkvanzanten

commit sha ac1d5b7e7d3ae7bdcf4ded209f60eb6767b2365f

Update .tables()

view details

rijkvanzanten

commit sha 1e3af01617ef270d5e74bb27cf9e1fe9499099a1

Update hasTable

view details

rijkvanzanten

commit sha cdff87a211e36b163dea7bc8f055d4922fd9e910

Update primary

view details

rijkvanzanten

commit sha f992961b83c7689cc8debeab1c710f906994cc01

Update foreignKeys call

view details

push time in a day

issue commentdirectus/directus

SMTP email

@j-kia Try setting EMAIL_SMTP_SECURE to false. When false, nodemailer will automatically decide whether or not to use SSL based on the host used

j-kia

comment created time in a day

push eventdirectus-community/awesome-directus

Jacobo Tabernero

commit sha c6dffec1a72b8b191f038f8b105b39828888dab9

Add directus-extension-display-link

view details

Rijk van Zanten

commit sha 8dd1f88834871f8982eb4f408d031a2e118214e2

Merge pull request #10 from jacoborus/patch-1 Add directus-extension-display-link

view details

push time in a day

PullRequestReviewEvent

issue commentknex/knex

Unsupported driver used: Client_BetterSQLite3

@kibertoad I don't think we're doing anything that's specific to node-sqlite in there, so adding support might be as easy as extending:

https://github.com/knex/knex-schema-inspector/blob/b0af557df44a77abdbda7137253b512b79b5cacb/lib/index.ts#L17-L19

to

    case 'Client_SQLite3':
    case 'Client_BetterSQLite3':
      constructor = require('./dialects/sqlite').default;
      break;
ozziest

comment created time in a day

push eventknex/knex-schema-inspector

rijkvanzanten

commit sha 79c114cd6b40c78dadcbaec1458e659643d01254

Update .tableInfo

view details

push time in a day

push eventknex/knex-schema-inspector

rijkvanzanten

commit sha 67dfe81b98c259d1feb18ee669ec775ad265e051

Add schema search, update columns

view details

push time in a day

issue commentdirectus/directus

Critical performance regression in Postgres since merge of CockroachDB

Also ensure the nested transactions in DDL operations are resolved

rijkvanzanten

comment created time in 2 days

PR opened knex/knex-schema-inspector

Rework PG to use (way faster) pg_catalog

Resolves performance regression in PG by relying on the faster pg_catalog tables (rather than the information_schema views).

Ideally, we do the same for the cockroach internal tables in a custom dialect, seeing cockroach has a similar performance penalty on pg_* tables.

Fixes directus/directus#11209

+154 -157

0 comment

3 changed files

pr created time in 2 days

create barnchknex/knex-schema-inspector

branch : improvement/pg

created branch time in 2 days

issue openeddirectus/directus

Critical performance regression in Postgres since merge of CockroachDB

To support Cockroach, we had to add an additional where statement to the columnInfo inspection:

https://github.com/knex/knex-schema-inspector/commit/118634c58dddb5276b649b9284c36c363c76b498

This turns out to tremendously hurt performance on Postgres. A solution is in the works (see linked PR).

created time in 2 days

create barnchdirectus/directus

branch : translations

created branch time in 3 days

issue commentdirectus/directus

Default values on revisions

@joselcvarela I agree with that rhetoric. Revisions stores the changes made by the user, so if there was no change, no diff is stored 🤔

DavidPLamas

comment created time in 3 days

pull request commentdirectus/directus

Added insights docs draft and images

Deploy preview for this change:

https://deploy-preview-11175--directus-docs.netlify.app/app/insights/

erondpowell

comment created time in 3 days

push eventdirectus/directus

Eron Donevan Powell

commit sha f0a1177b98a402c7230d760938542ea2b20dce17

moved sso doc over to configurations (#11041) * moved sso doc over to configurations * updated nav menu to link to SSO's new location

view details

Rijk van Zanten

commit sha e534af60708e6ff2743654fca48db60cc7aac418

New translations en-US.yaml (Chinese Simplified) (#11183)

view details

Rijk van Zanten

commit sha a38bcddb7edb7497016e4405fc352008ab4cb31b

New translations en-US.yaml (Chinese Simplified) (#11184)

view details

John Huffsmith

commit sha e7ada1f173dc6756cce40743023a8873ed2623e2

Moving schema and relation types into shared package (#11179) * moving schema and relation types into shared package * updating SchemaOverview imports * removing duplicate import

view details

Michael Schramm

commit sha 75b5f33727bff8f086d6f8e89f9eb2a09630a7cd

Implement CockroachDB support (#10113) * base changes for cockroachdb * allow creating of tables * allow deleting of fields * allow deleting of tables * rebase * fix migrations * bump knex-schema-inspector to 1.7.0 * Update package-lock * Add cockroach to debugging docker-compose file * Remove unused import * Tweak name in example.env * Force nullable primary keys in cockroach * Tweak shares migration to run on cockroach * Rename var for clarification * suggestion for migration helper * change to schema and update remaining migrations * Remove custom cockroach schema in favor of sharing with pg * Fix migrations for CockroachDB * Hopefully fix Oracle migrations 🤞🏻 * Make ~~aiden~~ oracle happy * Resolve branching paths in migrations * Enable tests for cockroach * Fix test config * One more config change for good measure * Adjust test to match cockroach's bigint auto-int structure * Increase request timeout for mssql * Update api/src/database/helpers/schema/types.ts Co-authored-by: Aiden Foxx <aiden.foxx.mail@gmail.com> Co-authored-by: rijkvanzanten <rijkvanzanten@me.com> Co-authored-by: Oreille <33065839+Oreilles@users.noreply.github.com> Co-authored-by: Aiden Foxx <aiden.foxx.mail@gmail.com>

view details

Brainslug

commit sha 595eb696ea1dc4de3e1306843b5d5914c54a6675

Remove reference to readByQuery (#11188) Updated order of examples and aligned titles to match Added missing updateOne example

view details

Jay Cammarano

commit sha b96d7775d33113aa0d00bc1355e09fc58d16c483

Add soft character limit to various inputs (#11009) * added soft_length to lang * added softLength option to input interface * softLength => textarea, md, wysiwyg * really broken but counting characters * return 0 not null oops * characters remaining displaying * percentageRemaining => shared * placeholders => string * markdown inputs need to change preview css * account for multiple md inputs * works for multiple inputs on a page * let it breathe * text area but no warning color (yet) * newline is 1 char * null => undefined * shows with 0 hard limit left * softlength tied to maxlength * preview displaying md * using share util * Replace shared "interface" with util * Add test setup * Lock package versions Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>

view details

Rijk van Zanten

commit sha 2f02ecad802f6774c771038a37b990e367c4c21a

New Crowdin updates (#11189) * New translations en-US.yaml (Bulgarian) * New translations en-US.yaml (German) * New translations en-US.yaml (Italian)

view details

Azri Kahar

commit sha 6368f641e5843e1236d94af474034c0567b8dde3

Add CSV/JSON Import capability via App (#11050) * Allow import data to collections via App directly * clear file input after import * tweak translations * reduce vertical gap * fix clear file input logic * Change export data button text * update start import button disabled color * undo unintended changes to translations quotes * add docs for importing items sidebar * update exporting items docs * Combine import/export sidebar details * Remove unused import detail * Fix docs Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>

view details

Rijk van Zanten

commit sha a19fc451fa470b76766f38c300a4163532e6dbca

New Crowdin updates (#11190) * New translations en-US.yaml (Indonesian) * New translations en-US.yaml (Persian) * New translations en-US.yaml (Spanish, Chile) * New translations en-US.yaml (Thai) * New translations en-US.yaml (Breton) * New translations en-US.yaml (Serbian (Latin)) * New translations en-US.yaml (Spanish, Latin America) * New translations en-US.yaml (Vietnamese) * New translations en-US.yaml (Russian) * New translations en-US.yaml (Polish) * New translations en-US.yaml (Portuguese) * New translations en-US.yaml (Swedish) * New translations en-US.yaml (Turkish) * New translations en-US.yaml (Estonian) * New translations en-US.yaml (Portuguese, Brazilian) * New translations en-US.yaml (Chinese Traditional) * New translations en-US.yaml (French) * New translations en-US.yaml (Spanish) * New translations en-US.yaml (Arabic) * New translations en-US.yaml (Bulgarian) * New translations en-US.yaml (Catalan) * New translations en-US.yaml (Czech) * New translations en-US.yaml (Danish) * New translations en-US.yaml (German) * New translations en-US.yaml (Finnish) * New translations en-US.yaml (Hungarian) * New translations en-US.yaml (Chinese Simplified) * New translations en-US.yaml (Italian) * New translations en-US.yaml (Korean) * New translations en-US.yaml (Lithuanian) * New translations en-US.yaml (Dutch) * New translations en-US.yaml (Norwegian) * New translations en-US.yaml (Slovenian) * New translations en-US.yaml (Ukrainian) * New translations en-US.yaml (English, United Kingdom) * New translations en-US.yaml (English, Canada) * New translations en-US.yaml (French, Canada)

view details

Nicola Krumschmidt

commit sha 889668f9726711da35df97178917a3aad2a78c35

Remove API extension types from the API (#11191) There is little value in keeping these types inside the API package. We should instead focus on improving the types in shared.

view details

rijkvanzanten

commit sha 3cbe86d3f1a257711844fd9dc625cc4450dcea59

Mark CRDB as beta, mark oracle as ga

view details

Rijk van Zanten

commit sha 88c87f39204995ede02b932ca0054e8581b7c6e1

Set CRDB options to avoid inconsistencies between vendors (#11193) * Set correct CRDB options * Add missing SETs to pool config for e2e * How about now * Better solution for the same problem

view details

Rijk van Zanten

commit sha d772fa61c996e59b47ac085da8eafe2eb51ba941

New translations en-US.yaml (French) (#11198)

view details

Rijk van Zanten

commit sha b882884b922014c0a3c6ad566a5cbb1506a6c3c3

New translations en-US.yaml (Hindi) (#11201)

view details

Rijk van Zanten

commit sha 973e2dc6bb207a0af5f8db66bcb91494dc81a857

Update knex-schema-inspector (#11203)

view details

rijkvanzanten

commit sha 63b1039391219c464148b145329aeae63607fa10

Fix site build

view details

rijkvanzanten

commit sha 73721da80e24b7ac7d3c8ec051eec8262ba00421

Merge branch 'main' into insights-doc

view details

push time in 3 days

push eventdirectus/directus

rijkvanzanten

commit sha 63b1039391219c464148b145329aeae63607fa10

Fix site build

view details

push time in 3 days

issue commentdirectus/directus

Align `readMany` and `readByQuery` in SDK

If we would implement readMany on SDK, it was simply a filter: { [primaryKey]: { _in: [keys] } } on current readMany, so I am not sure if makes sense to create such method

To me, that actually makes sense. If you have people that are writing both extensions, and use the SDK on their own projects, this consistent naming system with different type signatures is very confusing!

br41nslug

comment created time in 3 days

push eventdirectus/directus

Rijk van Zanten

commit sha 973e2dc6bb207a0af5f8db66bcb91494dc81a857

Update knex-schema-inspector (#11203)

view details

push time in 3 days

delete branch directus/directus

delete branch : dep/knex-schema-inspector

delete time in 3 days

more