profile
viewpoint
Ryan Griffith rgriffith Hannon Hill

rgriffith/jquery.yqlhelper 2

Provides a simple way to query YQL using jQuery

rgriffith/Fabricated-Events 1

An easy to use event management plugin that utilizes new features added in Wordpress v3.0.

rgriffith/LogMaster5000 1

Utility to parse log files for entries and stack traces. Generates a pretty table listing each entry that was found.

rgriffith/remove-comments-url 1

WordPress plugin that removes the url/website field from the comments form.

rgriffith/Velocity-Cookbook 1

Dedicated repository for Velocity script examples and resources for use inside of Cascade Server.

hannonhill/tinymce 0

TinyMCE is a JavaScript library for platform independent 'WYSIWYG' or rich text editing. It is released as open source under the LGPL.

hannonhill/ts-lambda-handler 0

Typescript library for writing AWS Lambda functions.

created taghannonhill/Universal-Migration-Tool

tagvREST-API-1.0.6

CMS-agnostic tool to migrate static web content into a Cascade Server instance

created time in 4 days

release hannonhill/Universal-Migration-Tool

vREST-API-1.0.6

released time in 4 days

delete branch hannonhill/Universal-Migration-Tool

delete branch : chore-update-cascadserver-references

delete time in 6 days

push eventhannonhill/Universal-Migration-Tool

Ryan Griffith

commit sha cd7898529d037a5e3ec00c29b006290b7315205f

chore: Update Cascade Server references to Cascade CMS (#29)

view details

push time in 6 days

PR merged hannonhill/Universal-Migration-Tool

chore: Update Cascade Server references to Cascade CMS

Scope

  • Updates all Cascade Server references to Cascade CMS
  • Changes Cascade CMS URL placeholder to https:// to promote secure URLs

/cc @samskinner111

+17 -18

0 comment

12 changed files

rgriffith

pr closed time in 6 days

PR opened hannonhill/Universal-Migration-Tool

chore: Update Cascade Server references to Cascade CMS

Scope

  • Updates all Cascade Server references to Cascade CMS
  • Changes Cascade CMS URL placeholder to https:// to promote secure URLs

/cc @samskinner111

+17 -18

0 comment

12 changed files

pr created time in 6 days

PR merged hannonhill/Universal-Migration-Tool

chore: Update to latest Cascade CMS logo

Scope

  • Updates Cascade CMS logo to the latest version instead of the old Cascade Server logo.
  • Minor CSS tweaks to brand/logo area

/cc @samskinner111

+4 -2

0 comment

2 changed files

rgriffith

pr closed time in 6 days

delete branch hannonhill/Universal-Migration-Tool

delete branch : chore-update-logo

delete time in 6 days

push eventhannonhill/Universal-Migration-Tool

Ryan Griffith

commit sha be36f655b8f1095aa46d754446fd19973d1de720

chore: Update to latest Cascade CMS logo (#28)

view details

push time in 6 days

PR opened hannonhill/Universal-Migration-Tool

chore: Update to latest Cascade CMS logo

Scope

  • Updates Cascade CMS logo to the latest version instead of the old Cascade Server logo.
  • Minor CSS tweaks to brand/logo area

/cc @samskinner111

+4 -2

0 comment

2 changed files

pr created time in 6 days

create barnchhannonhill/Universal-Migration-Tool

branch : chore-update-logo

created branch time in 6 days

delete branch hannonhill/Universal-Migration-Tool

delete branch : fix-rest-contenttype-header

delete time in 6 days

pull request commenthannonhill/Universal-Migration-Tool

fix: Set explicit application/json Content-Type header for REST API operations

Looks like this was already added 961b0f71e112ac40905aeef875b756f6c4d98407. Closing/deleting.

rgriffith

comment created time in 6 days

pull request commenthannonhill/Universal-Migration-Tool

fix: Set explicit application/json Content-Type header for REST API operations

I stumbled on this one earlier. I'll clean up the unused imports, catch it up and merge.

rgriffith

comment created time in 6 days

Pull request review commenthannonhill/tinymce

feat: Show applicable formats/classes in image/link WYSIWYG dialog

 define(         return uniqueImageClasses;       }; +      var getFormatInlineStyles = function (selectedCustomFormatNames, customStyleFormats) {

This was reworked in 270813b

nadirayasmeen

comment created time in 13 days

push eventhannonhill/tinymce

Ryan Griffith

commit sha 4f89e804ca74f020d24408302f02276e3536622c

Code cleanup and restructuring hannonhill/Cascade#3915

view details

push time in 13 days

push eventhannonhill/tinymce

Ryan Griffith

commit sha a89c3b9d62262314796ddeef72dcb863e44b53c0

Fix misspelled method name hannonhill/Cascade#3915

view details

push time in 14 days

push eventhannonhill/tinymce

Ryan Griffith

commit sha 376ac0a3b3340ed58c17cacd2ebdfc72734c53e6

Inline styles applied via a Format take priority over manually added styles Prevents issue where a customized inline style would prevent the Format from being selected on subsequent dialog loading, since the style no longer matches the Format. hannonhill/Cascade#3915

view details

push time in 14 days

push eventhannonhill/tinymce

Ryan Griffith

commit sha 270813b06a9044291537d11c8fac5a72b9bf2cfb

Update handling of existing styles and styles applied through formats hannonhill/Cascade#3915

view details

push time in 14 days

push eventhannonhill/tinymce

Ryan Griffith

commit sha 9ef88c0a40ba078ec84ae0c2bb4da201f39a5149

Always output opt groups hannonhill/Cascade#3915

view details

Ryan Griffith

commit sha edd7f3ae2d625980b03312ab4af8f8a1fd2cb9d8

Sort options when building optgroups hannonhill/Cascade#3915

view details

Ryan Griffith

commit sha 78af7623e7e26640b3fe6a22d344c36ca001f45b

Reworking logic and generation of format and class list items. hannonhill/Cascade#3915

view details

Ryan Griffith

commit sha 14e680f294d1c530845f9f2d9bca83c8c679b236

Pass editor settings not editor when getting link class list setting. hannonhill/Cascade#3915

view details

push time in 17 days

push eventhannonhill/tinymce

Ryan Griffith

commit sha 8377e28bd643a0dd7e35d497cedcc6f868c2ba72

Add missing type to list items hannonhill/Cascade#3915

view details

Ryan Griffith

commit sha bb5934b47452be230d131b7f5b9d2a01fb283cb6

Refactor merging of selected formats and classes hannonhill/Cascade#3915

view details

Ryan Griffith

commit sha 4263fab90da8eb2bc9ce27fb3f23e8449445a41b

Pass style attribute into link hannonhill/Cascade#3915

view details

push time in 17 days

Pull request review commenthannonhill/tinymce

feat: Show applicable formats/classes in image/link WYSIWYG dialog

 define(   ],     function (Tools) {       var getImageClassesForDropdown = function (editor, defaultClassList) {-        return getClassesForDropdown(editor, defaultClassList, "image");+        return getClassesForDropdown(editor, defaultClassList, "img");       };       var getLinkClassesForDropdown = function (editor, defaultClassList) {-        return getClassesForDropdown(editor, defaultClassList, "link");+        return getClassesForDropdown(editor, defaultClassList, "a");       };       var getClassesForDropdown = function (editor, defaultClassList, element) {         var editorSettings = editor.settings;-        var classList = [];+        var selectedNode = editor.selection.getNode();+        var nodeName = selectedNode.nodeName;++        if (nodeName.toLowerCase() !== element) {+          var elementNode = editor.dom.create(element, {});+         // editor.selection.setNode(elementNode); //adds node to DOM

We worked through this by using the Formatter class and an empty element on creation.

nadirayasmeen

comment created time in 17 days

Pull request review commenthannonhill/tinymce

feat: Show applicable formats/classes in image/link WYSIWYG dialog

 define(         };       } -      if (Settings.hasLinkClassList(editor.settings)) {+      if (editor.settings.style_formats) {+        var classList;++        classList = CascadeUtils.getClassesForDropdown(editor, editor.settings.link_class_list);++        if (classList) {+          // Add a 'None' option to the beginning if it is not already present.+          if (typeof classList[0] !== 'object') {

We worked through this with a "common plugin"

nadirayasmeen

comment created time in 17 days

push eventhannonhill/tinymce

Ryan Griffith

commit sha 3c044b2a7a0274921d1641660e1f2d8710a9fa23

Ensure class select options have a value #3915

view details

Ryan Griffith

commit sha ce47b933099fe835a31b3d8402a1cb329596d6e3

General code cleanup and reuse #3915

view details

push time in 17 days

Pull request review commenthannonhill/tinymce

fix: Check if the format applies to the current selection before adding it…

 define(   ],     function (Tools) {       var getImageClassesForDropdown = function (editor, defaultClassList) {-        return getClassesForDropdown(editor, defaultClassList, "image");+        return getClassesForDropdown(editor, defaultClassList, "img");       };       var getLinkClassesForDropdown = function (editor, defaultClassList) {-        return getClassesForDropdown(editor, defaultClassList, "link");+        return getClassesForDropdown(editor, defaultClassList, "a");       };       var getClassesForDropdown = function (editor, defaultClassList, element) {         var editorSettings = editor.settings;-        var classList = [];+        var selectedNode = editor.selection.getNode();+        var nodeName = selectedNode.nodeName;++        if (nodeName.toLowerCase() !== element) {+          var elementNode = editor.dom.create(element, {});+         // editor.selection.setNode(elementNode); //adds node to DOM+         // selectedNode.append(elementNode); // definitely adds node+         // var selectedNewNode = editor.selection.select(elementNode); //selecting without inserting/appending causes error+         // selectedNode = editor.selection.getNode();+          selectedNode = elementNode; //doesn't seem to work against editor.dom.is for some reason, maybe because it's not an actual node?+        } +        var classList = [];         var formatMenuItems = editorSettings.style_formats;-        Tools.each(formatMenuItems, function (formatMenuItem) {-          if (formatMenuItem.title === "Custom") {-            Tools.each(formatMenuItem.items, function (format) {-              var formatName = format.name;-              if (editor.formatter.canApply(formatName) && format.classes) {-                Tools.each(format.classes, function (formatClass) {-                  if (isInElementClassList(formatClass, element, editorSettings)) {-                    classList.push(formatClass);-                  }-                });-              }+        var customMenu = formatMenuItems.filter(function (format) {+          return format.title === "Custom";+        });++        if (customMenu[0] === null) {+          return defaultClassList;+        }++        Tools.each(customMenu[0].items, function (format) {+          if ((editor.dom.is(selectedNode, format.selector) || matchesSelectorForNewElement(element, editor.selection.getNode(), format.selector, editor)) && format.classes) {+            Tools.each(format.classes, function (formatClass) {+              classList.push(formatClass);             });           }         });          return hasAdvancedFormatMenu(editor) ? classList : defaultClassList;       }; +      // Attempts to checks the selector up until the element since it hasn't been inserted into the editor yet+      var matchesSelectorForNewElement = function (element, selectedNode, selector, editor) {

We ended up reworking this such that we test if the format is applicable to a node which mimics the functionality of TinyMCE's Format dropdown.

nadirayasmeen

comment created time in 18 days

Pull request review commenthannonhill/tinymce

fix: Check if the format applies to the current selection before adding it…

+/**+ * Utils.js+ *+ */+define(+  'tinymce.plugins.cascade.core.Utils',

Yeah, I think this is fine. I recall looking through WordPress' customizations at one point and they have a similar setup with some specific plugins.

nadirayasmeen

comment created time in 18 days

push eventhannonhill/tinymce

Ryan Griffith

commit sha f07d429c351f15cb7ded3c54d05151aa797d9702

Allow multiple applicable styles to be selected within image and link plugin dialogs hannonhill/Cascade#3915

view details

push time in 25 days

create barnchhannonhill/tinymce

branch : shipit-embedded-blocks

created branch time in a month

created taghannonhill/Universal-Migration-Tool

tagvREST-API-1.0.5

CMS-agnostic tool to migrate static web content into a Cascade Server instance

created time in a month

push eventhannonhill/Universal-Migration-Tool

Ryan Griffith

commit sha 961b0f71e112ac40905aeef875b756f6c4d98407

feat: Set Content-Type request header to application/json

view details

push time in a month

PR merged hannonhill/Universal-Migration-Tool

feat: Preserve order of Metadata and Data Definition fields enhancement

Summary

When mapping fields, the order of metadata and data defintion fields within the select was not consistent with the order received from Cascade CMS. Switching to LinkedHashMap preserves that insertion order.

+6 -12

0 comment

2 changed files

rgriffith

pr closed time in a month

delete branch hannonhill/Universal-Migration-Tool

delete branch : feat-ordered-metadata-dd-fields

delete time in a month

push eventhannonhill/Universal-Migration-Tool

Ryan Griffith

commit sha 20dac71367e6ef2723ca8e419f40fbcc38856076

feat: Preserve order of Metadata and Data Definition fields (#27)

view details

push time in a month

PR opened hannonhill/Universal-Migration-Tool

feat: Preserve order of Metadata and Data Definition fields enhancement

Summary

When mapping fields, the order of metadata and data defintion fields within the select was not consistent with the order received from Cascade CMS. Switching to LinkedHashMap preserves that insertion order.

+6 -12

0 comment

2 changed files

pr created time in a month

delete branch rgriffith/scalyr-chef

delete branch : chore-upgrade-scalyr-agent

delete time in a month

PR opened scalyr/scalyr-chef

chore: Upgrade Scalyr Agent and move package URL and files to attributes

After speaking with Scalyr support, it was recommended to upgrade the agent; however, I was unable to do so because the Chef cookbook hard codes an older version.

This pull request introduces new attributes so the URL and package files can be overwritten in the installation recipes. It also updates the version of Scalyr agent to the latest.

+13 -8

0 comment

3 changed files

pr created time in 2 months

create barnchrgriffith/scalyr-chef

branch : chore-upgrade-scalyr-agent

created branch time in 2 months

fork rgriffith/scalyr-chef

Chef recipes for installing the Scalyr Agent

fork in 2 months

push eventhannonhill/Velocity-Cookbook

Ryan Griffith

commit sha 88902911ea82653fc9ab7426f27f3e6d6af4096d

perf: Use $currentPage instead of Locator Tool The `$currentPage` variable already provides a Cascade API object for the page currently being viewed. Using `$_.locatePage` just adds unnecessary overhead.

view details

push time in 2 months

create barnchhannonhill/Velocity-Cookbook

branch : perf-quickedit-currentpage

created branch time in 2 months

more