profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/raon0211/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Sojin Park raon0211 @toss Seoul, Korea https://sojin.io ๐Ÿ”ฅ

raon0211/korean-web-font-optimization 6

ํ•œ๊ธ€ ์›น ํฐํŠธ ์ตœ์ ํ™”๋ฅผ ๋„์™€์ฃผ๋Š” ์Šคํฌ๋ฆฝํŠธ

junsooo/Fake_love 5

Your fake girl/boy friend

raon0211/eridown 2

A scalable, fast, and accurate markdown parser. Built in Scala.

raon0211/SchoolApp 1

๊ธ‰์‹ ๋ฐ ํ•™์‚ฌ์ผ์ • ์ •๋ณด๋ฅผ ์ œ๊ณตํ•˜๋Š” ๊ณ ๋“ฑํ•™๊ต ์•ˆ๋“œ๋กœ์ด๋“œ ์• ํ”Œ๋ฆฌ์ผ€์ด์…˜

raon0211/XamarinToDo 1

A simple MVVM to-do app using Xamarin, MvvmCross, and SQLite.

headcrabtan/pkm-storage 0

ํ”„ํผ์ €์žฅ์†Œ: ํ”„ํผ์„ ์—…๋กœ๋“œํ•˜๊ณ , ๊ณต์œ ํ•˜๊ณ , ๋‹ค์šด๋กœ๋“œํ•˜์ž!

raon0211/babel 0

๐Ÿ  Babel is a compiler for writing next generation JavaScript.

raon0211/berry 0

๐Ÿ“ฆ๐Ÿˆ Active development trunk for Yarn โš’

PR opened facebook/jscodeshift

fix: Set `configFile: false` option in `@babel/register`

JSCodeShift is transpiling transform files given as arguments, and it is currently ignoring package-wide .babelrc settings file in @babel/register so that it shows a consistent behavior across many packages.

However, since configFile option is not set to false, it is still affected by the project-wide babel.config.js settings file. Hence it some cases JSCodeShift may behave differently, dependending on the settings of babel.config.js.

This PR fixes this behavior by setting configFile: false option to @babel/register, so that JSCodeShift behaves completely independent of the project-wide settings.

+1 -0

0 comment

1 changed file

pr created time in 7 hours

create barnchraon0211/jscodeshift

branch : configfile

created branch time in 8 hours

startedmattermost/mattermost-mobile

started time in 12 days

startedcraftzdog/react-native-quick-base64

started time in 13 days

startedcallstack/react-native-builder-bob

started time in 13 days

startedmicrosoft/react-native-windows

started time in 13 days

startedfacebook/folly

started time in 13 days

startedreact-native-community/jsc-android-buildscripts

started time in 13 days

startedreact-native-community/cli

started time in 18 days

startedfacebook/metro

started time in 18 days

startedfacebook/hermes

started time in 20 days

PR opened i18next/i18next-parser

Add @babel/runtime as deps

Why am I submitting this PR

i18next-parser is requiring @babel/runtime in its output file, but @babel/runtime is not specified in its dependencies. When used with strict package managers such as pnpm or Yarn 2+, it causes the program to break.

https://github.com/i18next/i18next-parser/blob/9d7f24d05fc28f5e55327d14c9ed1e7d1beb1950/dist/transform.js#L1

I added @babel/runtime as a regular dependency to the package.

Does it fix an existing ticket?

No

Checklist

  • [x] only relevant code is changed (make a diff before you submit the PR)
  • [ ] tests are included and pass (see details here)
  • [ ] documentation is changed or added
  • [x] I ran yarn build to compile and prettify the code
+8 -0

0 comment

2 changed files

pr created time in 23 days

create barnchraon0211/i18next-parser

branch : fix-deps

created branch time in 23 days

fork raon0211/i18next-parser

Code parser for i18next

fork in 23 days

startedisaachinman/next-i18next

started time in 23 days

create barnchraon0211/react-calendar

branch : add-sandbox-config

created branch time in 25 days

fork raon0211/react-calendar

:calendar: React Hooks for building extensible calendar user interface (a.k.a Headless Calendar)

https://veccu-react-calendar.netlify.app

fork in 25 days

pull request commenttoss/yarn-plugin-workspace-since

feat: commands ํ…Œ์ŠคํŠธ ๊ธฐ๋Šฅ ์ถ”๊ฐ€

๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ์˜ ์‹ค์ œ ๋™์ž‘์ด ๋ณ€ํ•˜์ง€ ์•Š์•˜๋‹ค ๋ณด๋‹ˆ test: ๋˜๋Š” chore: ๋กœ ์‹œ์ž‘ํ•˜๋„๋ก PR ์ œ๋ชฉ์„ ๋ฐ”๊ฟ”๋ณด๋ฉด ์–ด๋–จ๊นŒ์š”?

apple12347678

comment created time in a month

PullRequestReviewEvent

Pull request review commenttoss/yarn-plugin-workspace-since

feat: commands ํ…Œ์ŠคํŠธ ๊ธฐ๋Šฅ ์ถ”๊ฐ€

 import { initializeTestRepository } from '../../testing/repository'; import getUpdatedWorkspaces from './getUpdatedWorkspaces'; -describe('getUpdatedWorkspaces๋Š”', () => {-  it('Workspace ๋‚ด๋ถ€์˜ ์—…๋ฐ์ดํŠธ๋œ ํŒจํ‚ค์ง€ ๋ฆฌ์ŠคํŠธ๋ฅผ ๋ฐ˜ํ™˜ํ•œ๋‹ค.', async () => {+describe('getUpdatedWorkspaces', () => {

(์‚ฌ์†Œ) ์˜์–ด๋ผ๋ฉด describe('Something', () => { it('does some other thing', ...) }) ํ˜•์‹์ด ์ž์—ฐ์Šค๋Ÿฝ์ง€๋งŒ ํ•œ๊ตญ์–ด๋ฉด X๋Š” Yํ•œ๋‹ค. ํ˜•์‹์ด ๋” ์ž์—ฐ์Šค๋Ÿฝ๊ฒŒ ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ๊ฐ€ ๋‚˜์˜ฌ ๊ฑฐ๋ผ๊ณ  ์ƒ๊ฐํ–ˆ์—ˆ๋Š”๋ฐ ํ˜น์‹œ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”?

image

์˜ˆ๋ฅผ ๋“ค์–ด์„œ ํ˜„์žฌ ์ƒํƒœ๋Š”

getUpdatedWorkspaces
  ใ„ด Workspace ๋‚ด๋ถ€์˜ ์—…๋ฐ์ดํŠธ๋œ ํŒจํ‚ค์ง€ ๋ฆฌ์ŠคํŠธ๋ฅผ ๋ฐ˜ํ™˜ํ•œ๋‹ค

์ด๋Ÿฐ ์‹์œผ๋กœ ๋ณด์ด๊ฒŒ ๋  ๊ฒƒ ๊ฐ™์•„์„œ ์˜ˆ์ „๋ณด๋‹ค ์ž์—ฐ์Šค๋Ÿฌ์›€์ด ๋–จ์–ด์ง€๊ฒŒ ๋  ๊ฑฐ๋ผ๊ณ  ์ƒ๊ฐํ–ˆ์—ˆ์–ด์š”

apple12347678

comment created time in a month

PullRequestReviewEvent

Pull request review commenttoss/yarn-plugin-workspace-since

feat: commands ํ…Œ์ŠคํŠธ ๊ธฐ๋Šฅ ์ถ”๊ฐ€

 export default async function getUpdatedWorkspaces({   ignore?: string;   workspaceDir?: string; }) {-  const matchedWorkspaceGlobs = PackageJson(workspaceDir).workspaces.filter(v => !minimatch(v, ignore));+  const matchedWorkspaceGlobs = PackageJson(workspaceDir).workspaces.filter(+    v => !minimatch(v, ignore),+  );

์Šคํƒ€์ผ์ด ๋‹ค์†Œ ํ”๋“ค๋ฆฌ๋Š”๋ฐ ESLint + Prettier ์„ค์ •์„ ์ž˜ ํ•ด๋‘ฌ์•ผ๊ฒ ๊ตฐ์š” ๐Ÿ˜ญ

apple12347678

comment created time in a month

PullRequestReviewEvent

pull request commenttoss/yarn-plugin-workspace-since

feat: commands ํ…Œ์ŠคํŠธ ๊ธฐ๋Šฅ ์ถ”๊ฐ€

ํ˜น์‹œ ํ…Œ์ŠคํŠธ๋ฅผ ์ž‘์„ฑํ•  ๋•Œ setup ์ฝ”๋“œ๋ฅผ beforeEach/afterEach ๋ณด๋‹ค๋Š” react-testing-library ์ฒ˜๋Ÿผ fixture ์ƒ์„ฑ์„ ํ•ด์ฃผ๋ฉด ์–ด๋–จ๊นŒ์š”? ๊ด€๋ จํ•œ ๋ธ”๋กœ๊ทธ ์•„ํ‹ฐํด: https://kentcdodds.com/blog/avoid-nesting-when-youre-testing

apple12347678

comment created time in a month

push eventtoss/yarn-plugin-workspace-since

Kenneth Kang

commit sha 5b65c7753cb5521f102d0114cb9cf2566d4f7092

chore: typescript ๋ฒ„์ „ ์—…๋ฐ์ดํŠธ (#10)

view details

push time in a month

PR merged toss/yarn-plugin-workspace-since

chore: typescript ๋ฒ„์ „ ์—…๋ฐ์ดํŠธ

ts ๋ฒ„์ „์„ ์ตœ์‹ ์œผ๋กœ ์—…๋ฐ์ดํŠธํ•ฉ๋‹ˆ๋‹ค. ํ…Œ์ŠคํŠธ์—์„œ ๋ฐœ์ƒํ•˜๋Š” ๋‹ค์Œ ์—๋Ÿฌ๋ฅผ ๋ฐฉ์ง€ํ•ฉ๋‹ˆ๋‹ค.

ts-jest[versions] (WARN) Version 4.1.0-beta of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=3.8.0 <5.0.0-0). Please do not report issues in ts-jest if you are using unsupported versions.
+20 -20

0 comment

7 changed files

apple12347678

pr closed time in a month

PullRequestReviewEvent

startedformat-message/format-message

started time in a month

push eventtoss/yarn-plugin-workspace-since

Sojin Park

commit sha 6f20291a742bbc7930e172b306d2d52dcddcba16

fix: ํ•œ๊ธ€์„ ํฌํ•จํ•˜๋Š” ๊ฒฝ๋กœ์˜ ํŒŒ์ผ์ด ์žˆ์„ ๊ฒฝ์šฐ since๊ฐ€ ํŒจํ‚ค์ง€๋ฅผ ๊ณ„์‚ฐํ•˜์ง€ ๋ชปํ•˜๋Š” ๋ฌธ์ œ ์ˆ˜์ • (#9) * Update to yarn 3 * Update sdks * add test * ํ•œ๊ธ€์— ๋Œ€์‘ * add cleanups * Update to Yarn 3 * remove obsolete dependencies * Update sdks * Update since binary

view details

push time in 2 months

PR merged toss/yarn-plugin-workspace-since

fix: ํ•œ๊ธ€์„ ํฌํ•จํ•˜๋Š” ๊ฒฝ๋กœ์˜ ํŒŒ์ผ์ด ์žˆ์„ ๊ฒฝ์šฐ since๊ฐ€ ํŒจํ‚ค์ง€๋ฅผ ๊ณ„์‚ฐํ•˜์ง€ ๋ชปํ•˜๋Š” ๋ฌธ์ œ ์ˆ˜์ •

์ด PR์ด ๊ณ ์น˜๋Š” ์ƒํ™ฉ

Git์—์„œ๋Š” git diff ๋ฅผ ์‹คํ–‰ํ–ˆ์„ ๋•Œ ASCII๊ฐ€ ์•„๋‹Œ ๋””๋ ‰ํ† ๋ฆฌ๋ฅผ ๊ธฐ๋ณธ์ ์œผ๋กœ ์•„๋ž˜์™€ ๊ฐ™์ด ๋”ฐ์˜ดํ‘œ๋ฅผ ๋ถ™์—ฌ์ค€ ์ฑ„ ์ถœ๋ ฅํ•ฉ๋‹ˆ๋‹ค.

$ git diff HEAD~...HEAD --name-only
"\355\205\214\354\212\244\355\212\270\354\236\205\353\213\210\353\213\244.tsx"

ํ˜„์žฌ ํ”Œ๋Ÿฌ๊ทธ์ธ์˜ ๊ตฌํ˜„์—์„œ๋Š” ๋ฐ”๋กœ startsWith ๋กœ ์—…๋ฐ์ดํŠธ๋œ ํŒจํ‚ค์ง€๋ฅผ ์ฐพ๊ณ  ์žˆ์–ด์„œ, ํŒŒ์ผ ๊ฒฝ๋กœ๊ฐ€ ๋”ฐ์˜ดํ‘œ๋กœ ๊ฐ์‹ธ์ ธ ์žˆ๋Š” ๊ฒฝ์šฐ์—๋Š” since๊ฐ€ ์—…๋ฐ์ดํŠธ๋œ ํŒจํ‚ค์ง€๋ฅผ ์ž˜ ๊ณ„์‚ฐํ•˜์ง€ ๋ชปํ•˜๋Š” ์ด์Šˆ๊ฐ€ ์žˆ์Šต๋‹ˆ๋‹ค.

https://github.com/toss/yarn-plugin-workspace-since/blob/ca13aa1ccb0cfce8e3bdef6841f39e27812d17c5/sources/getUpdatedWorkspaces/matchWorkspacesByFiles.ts#L10

(์œ„ ๋ถ€๋ถ„์—์„œ file ์€ '\"services/some-service/...\"' ์™€ ๊ฐ™์ด ๋”ฐ์˜ดํ‘œ๋กœ ๊ฐ์‹ธ์ ธ ์žˆ๋Š”๋ฐ, startsWith์˜ ์ธ์ž๋Š” 'services/some-service'์™€ ๊ฐ™์ด ๋”ฐ์˜ดํ‘œ๋กœ ๊ฐ์‹ธ์ ธ ์žˆ์ง€ ์•Š์•„์„œ ๊ณ„์‚ฐ์— ์‹คํŒจํ•จ)

์ˆ˜์ •์‚ฌํ•ญ ์š”์•ฝ

Git ์˜ต์…˜ ์ค‘์—์„œ -c core.quotepath=false ๋ผ๊ณ  ํ•˜๋Š” ์˜ต์…˜์ด ์žˆ์–ด์„œ diff ๊ณ„์‚ฐ ์‹œ์— ๋”ฐ์˜ดํ‘œ๋กœ ๊ฒฝ๋กœ๋ฅผ ๊ฐ์‹ธ์ง€ ์•Š๋„๋ก ์ˆ˜์ •ํ•ฉ๋‹ˆ๋‹ค.

(+ ์•„์ง ์‹ค์ œ ๋ ˆํฌ์ง€ํ† ๋ฆฌ๋ฅผ ๋‹ค๋ฃจ๋Š” ํ…Œ์ŠคํŠธ๊ฐ€ ์—†์–ด์„œ ํ”Œ๋Ÿฌ๊ทธ์ธ ๋™์ž‘์„ E2E ํ…Œ์ŠคํŠธ์— ๊ฐ€๊น๊ฒŒ ํ…Œ์ŠคํŠธํ•˜๋Š” ์ฝ”๋“œ๋ฅผ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค.)

+428 -14

0 comment

19 changed files

raon0211

pr closed time in 2 months