profile
viewpoint

pushkine/svelte 0

Cybernetically enhanced web apps

issue commentsveltejs/svelte

`use:` Action not being fired in {#each }

You're using a non keyed #each block, non keyed each blocks update based on index

When you remove a page it iterates through the complete array and updates every block whose value at array[index] changed

The href attribute gets updated because its value changed, svelte attempts to dispatch the update to use:active but that action does not return an object with an .update method

https://svelte.dev/repl/e8523aaf03054c379fb469d332bd2ec0?version=3.23.2

jayliu50

comment created time in 8 days

issue commentsveltejs/svelte

Store is not being updated synchronously / store value is incorrect

svelte store sets are always synchronous

in your examples, the second store is not a store, you're only using the event dispatching feature of the store

the issue is that stores triggering other stores to update are by definition derived stores, so svelte treats them differently

$count = 0 works because the compiler knows for sure that $count will be set to 0, so it sets the value locally at the same time as it calls count.set

set_store_value(count, $count = 0);

that however is willy-nilly compiler optimization that should be removed, as that causes stores such as tweened and spring to be out of sync with the local component value, and $count = 0 only works locally as $count will still be out of sync if read in other components

yuliankarapetkov

comment created time in 10 days

issue closedsveltejs/svelte

await block fails when resolved immediately

https://svelte.dev/repl/b7e56668dfae4f80bf2b37fe2ed1c6c7?version=3.20.1

<script>
	const promise = {then:(r) => r("world")}
</script>

{#await promise then v}
	<h1>Hello {v}!</h1>
{/await}
Cannot read property 'parentNode' of undefined

handle_promise's update function attempts to detach the previous block whose nodes aren't created yet

closed time in 11 days

pushkine

issue commentsveltejs/svelte

Volume won't tween

It's not a bug, volumechange fires every time volume changes, you cannot tween it without a guard

You could raise a proposal for svelte to auto guard all bindings to events that trigger on change

function audio_volumechange_handler() {
+	 if ($volume !== this.volume) {
		$volume = this.volume;
		volume.set($volume);
+	 }
}
arxpoetica

comment created time in 11 days

issue commentsveltejs/svelte

Sync issue with input's checked-binding

Internally on:change and bind:checked both listen to the change event, usually if you get sync issues you can work around it by changing their order

https://svelte.dev/repl/2738cb27318446c1b58d430b79ade182?version=3.23.2

#3254 works in the current version, the component was missing its binding

https://svelte.dev/repl/406349eb7ad84d4b92e6c7b2adfcee7f?version=3.23.2

arggh

comment created time in 12 days

issue commentsveltejs/svelte

Volume won't tween

bind:value listens to input events bind:volume listens to volumechange events

you can fix by guarding the setter

https://svelte.dev/repl/a37443ed1b604a479219df59ce8f5a0d?version=3.23.2 https://svelte.dev/repl/8c99ae976e27445995fb483585c6a36b?version=3.23.2

arxpoetica

comment created time in 12 days

issue openedsveltejs/svelte

`$store =`doesn't check whether `store` is different in current scope

https://svelte.dev/repl/8b351c8352044772a0561cc56a5f85a2?version=3.23.2

	const click_handler = store => {
		set_store_value(store, $store = Math.random());
	};

Error: store.set is not a function

created time in 12 days

issue commentsveltejs/svelte

Animation doesn't complete

@antony #4634

kewp

comment created time in 16 days

issue openedmicrosoft/TypeScript-TmLanguage

Highlighting breaks in inline function

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->

const swap = (b) => (0 ? (b ? 0 : 1) : b ? 1 : (_) => 0);
const foo = "";

Code_2020-06-06_23-50-15

probably related to https://github.com/microsoft/TypeScript-TmLanguage/issues/828

adding parens around (_) => 0 fixes it, but prettier will remove them on format

1.45.1

created time in 23 days

pull request commentsveltejs/svelte

Transition internals

Also here's a playground for the fork https://svelte.dev/repl/3548e4d0a06f4440847e5c92caa02b93 Each column is a different easing strategy Changing easing does not work on the web repl since transitions are only ever computed once

pushkine

comment created time in 23 days

PR opened sveltejs/svelte

Transition internals

Following #4742 Unfortunately crossfading and the animate directive turned out to be incompatible with transitions by design. There is still a few things related to transitions from that PR

  • New frame callback system keeps track of all pending tasks to shrink work performed each frame (previously iterating over a Set calling each animation) down to as little as one timestamp check

  • Measurements and animations are now batched to be applied after flush, this avoids layout trashing and significantly improves performance in same tick tasks performing several DOM reads This is the cause of most changed tests as it was expected for animations to be applied synchronously Fixes #4732

  • Position freeze is now reversed if re-introed, fixes animated todo list bug where a node would hide behind others

  • Bidi transitions now recompute on every run, fixes #4784 and #4831

    • To further customization, if a bidi config returns a function it will now be called with a is_intro boolean
  • Bidi transitions now handle several delay reversals, fixes #4968

    • Handling delay properly while also recomputing on every run requires to know whether a config has delay before running the transition function ( as its measurements cannot be delayed ), so on init and every time a config changes there is a dry run to scan for the delay parameter. If config returns a function it is called with is_intro undefined ezgif-4-27ff836ebf74
  • Transition bugfix #4974 #4954

  • Added rotate option to fly transition, rewrote svelte/transition types

notes

  • motion still uses the old loop system, I started rewriting some of it using motion stores from #4742 but the current implementation is so egregious I really doubt anyone using it is concerned about performance

todo

Remove transition easing strategies ( cool but unnecessary ) Write tests for fixed bugs

Can't work on this for some time but it's there if someone needs it

+949 -1181

0 comment

65 changed files

pr created time in 23 days

push eventpushkine/svelte

pushkine

commit sha d94d3bfc33b95049a059d48d8b58268d810e66e9

fix

view details

push time in 23 days

push eventpushkine/svelte

pushkine

commit sha de2526739a53c784f3eaef3abee47a9b7494ce53

fix

view details

pushkine

commit sha 0ec763a2159466a539b8727fff5c37bd3aa2739e

fix

view details

push time in 23 days

push eventpushkine/svelte

pushkine

commit sha 0353d52d919041b20d2adec23803cd187ef52174

delayed

view details

pushkine

commit sha b59759cd4a7b2d85c90bf8e1a174e7f4ceb9e185

fix

view details

push time in 24 days

create barnchpushkine/svelte

branch : transitions-test

created branch time in 24 days

issue openedmicrosoft/vscode

Highlighting breaks in inline function

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->

const swap = (b) => (0 ? (b ? 0 : 1) : b ? 1 : (_) => 0);
const foo = "";

Code_2020-06-06_23-50-15

probably related to https://github.com/microsoft/TypeScript-TmLanguage/issues/828

adding parens around (_) => 0 fixes it, but prettier will remove them on format

created time in a month

issue openedsveltejs/svelte

Error in bidi transitions when returning a function

https://svelte.dev/repl/283d750225684048b26cf6880dfcea2d?version=3.23.0 Cannot read property 'r' of undefined

https://github.com/sveltejs/svelte/blob/dba6e5efadb8aaf86ca25022cd3279bb4ea42434/src/runtime/internal/transitions.ts#L337-L342

wait.then resolves after check_outros meaning that outros will be the reassigned to its parent group, which is undefined in this case

created time in a month

issue commentsveltejs/svelte

Transitions are not triggered for the else of an each-else block

https://github.com/sveltejs/svelte/blob/f111cf6881d6708f0e7d0b7db9653f411dd6bab1/src/compiler/compile/render_dom/wrappers/EachBlock.ts#L307-L308 https://github.com/sveltejs/svelte/blob/f111cf6881d6708f0e7d0b7db9653f411dd6bab1/src/compiler/compile/render_dom/wrappers/EachBlock.ts#L323-L324

@transition_in(${each_block_else}, 1);

I can't rn but you'd just need to insert that line at those two places

<script>
   export let arr = []
</script>
GrygrFlzr

comment created time in a month

issue commentsveltejs/svelte

Consider removing transition events

Making the post I assumed that the cost of that function call could only be due to event dispatching

So I removed them, and it turns out that that block actually performs work that is not referenced in the flame chart

chrome_2020-06-04_07-03-23

So dispatching 100 events actually is 10.2ms on mobile 2.1ms on desktop

All in all it's not that big of a deal, still unnecessary work though

pushkine

comment created time in a month

issue openedsveltejs/svelte

delay in transitions only applies to last change

https://svelte.dev/repl/577f73063a75469292b63d384f72ea9c?version=3.23.0 Untitlesd-1 ( reload to replay gif )

created time in a month

issue commentsveltejs/svelte

Allow let in reactive variable declarations

let squared: number;
$: squared = num * num;
benmccann

comment created time in a month

issue commentsveltejs/svelte

Allow let in reactive variable declarations

label: let is invalid javascript

benmccann

comment created time in a month

issue openedsveltejs/svelte

Consider removing transition events

introstart, outrostart, introend, outroend are events triggering at the exact same time as the native animationstart animationend events, those events are supported in all browsers going as far back as IE10

Svelte dispatches those events regardless of whether something listens to it, resulting in a large loss of performance scaling with the amount of transitions triggered in the same tick

100 transitions, no listeners https://svelte.dev/repl/086da3669aed4ec4b9f00c847494da28?version=3.23.0

chrome_2020-06-03_20-45-04 all the big yellow chunks are event dispatching, nothing else

chrome_2020-06-02_15-33-28 mobile : screen freezes for 17 frames

chrome_2020-06-03_21-08-13 desktop i7 : 2 frames

created time in a month

issue openedsveltejs/svelte

outroing transition group never unmounts if one sibling remounts with delay in bidirectional transition

https://svelte.dev/repl/7157234039fa43c2ac779c534941e263?version=3.23.0 https://github.com/sveltejs/svelte/blob/8fc85f0ef6b53ed85e54c129d79270fe577626dc/src/runtime/internal/transitions.ts#L309-L320 pending_program is only present in bidirectional transitions with delay

reversing one while it's outroing will fail the !pending_program check, and discard running_program

the group running_program belongs to subsequently cannot complete its transition

created time in a month

issue openedmicrosoft/TypeScript-TmLanguage

breakline changes highlighting

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->

const foo = (true);
const bar = (
  true);

Code_2020-05-21_12-24-28 1.45.1

created time in a month

push eventpushkine/svelte

pushkine

commit sha 5d0430e79577ba559d52af370cd45d14afe29d32

fix

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 398aa59eb5e79b4cd3db207c3c357db2d7fb578f

fix

view details

push time in a month

pull request commentsveltejs/svelte

[internals] /environment refactoring

Anyone know what's going on with the linting ? I don't get errors on my machine...

pushkine

comment created time in a month

push eventpushkine/svelte

pushkine

commit sha ab09b33d199180c9a9f484ba3f61ee3f4db0b3d8

fix

view details

pushkine

commit sha 5d1608a24535e4b4092710e1ad53bb65a2f40d71

fix

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 839639fe8cf02b8f4436e878770a55cea7669ed3

fix

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 2e094a0b13d7fa32059d72fd38c323a505e5817f

fix

view details

push time in a month

PR opened sveltejs/svelte

[internals] /environment refactoring

Pools env checks & variables together

+33 -50

0 comment

10 changed files

pr created time in a month

create barnchpushkine/svelte

branch : environment-

created branch time in a month

create barnchpushkine/svelte

branch : transitions-rework

created branch time in a month

startedsebastian-software/effective-prettier

started time in a month

push eventpushkine/svelte

pushkine

commit sha da97e6dd53e27e36b3e82b639673fbebc3ad8431

fix

view details

push time in a month

issue closedsveltejs/svelte

Subscribing to a store while it's dispatching an update results in subscriber being called twice with the same value

https://svelte.dev/repl/c1911924dea745ba9194891113129eb2?version=3.23.0

closed time in a month

pushkine

issue openedsveltejs/svelte

Subscribing to a store while it's dispatching an update results in subscriber being called twice with the same value

https://svelte.dev/repl/c1911924dea745ba9194891113129eb2?version=3.23.0

created time in a month

push eventpushkine/svelte

pushkine

commit sha 825ae0bb11a21d9441f2f2fd727d23382d8ce03e

fix

view details

push time in a month

issue openedsveltejs/svelte

Unsubscribing last subscriber twice from a writable store runs `null()`

https://svelte.dev/repl/fc33f2d0f07c43c0a90b5de49b267396?version=3.23.0 https://github.com/sveltejs/svelte/blob/a4dadf82be8c5b13915241d6d3999dd54e75e2d4/src/runtime/store/index.ts#L100-L109

created time in a month

push eventpushkine/svelte

pushkine

commit sha a355c5ccab8b5c4f2c5ecffe6fa61ce103eabe36

fix

view details

push time in a month

create barnchpushkine/svelte

branch : class-stores

created branch time in a month

issue commentsveltejs/svelte

Prevent unnecessary store subscriptions

It might be worth mentioning that changes in this regard will affect StartStopListeners, so it could just as much be deemed a bug if count were to run side effects on first sub

Overall I do not think this issue should be addressed, it is not the first time I see a component subscribing to a store whose value it does not need

<script>
  import { count } from './stores.js';
</script>

{#if false}
	{$count}
{/if}

https://svelte.dev/repl/c548bac309fb4fb6b9ea4eedd76366a8?version=3.23.0

It has been implicitly established that $stores will be subscribed to on mount and unsubscribed to on destroy, it would be a mistake to break that pattern for some cases while leaving it in others

Rich-Harris

comment created time in a month

issue commentsveltejs/svelte

Prevent unnecessary store subscriptions

For assignments other than = (i.e. += 1 etc), it would use update instead of set

The update method isn't part of the store spec

Any object that correctly implements .subscribe, unsubscribe, and (optionally) .set is a valid store

Rich-Harris

comment created time in a month

issue commentsveltejs/svelte

Variable toggled during transition doesn't update from within {#if}

duplicate #4683

mattwolff

comment created time in a month

issue commentsveltejs/svelte

destroy function returned from onMount is not called if onMount is passed an async function

It's not a bug, checking whether the returned value is a promise really isn't a big deal @antony.

There's another problem however, async functions are run ( wait for it ) asynchronously, meaning that they will actually run afterFlush™.

Accepting async lifecycle functions therefore would bring confusion as to why async onMount functions ( that you specifically said were allowed and supported in the documentation ) aren't run onMount but after flush.

it all ties back to the same problem which is about general javascript knowledge. So @tanhauhau is correct, it should throw an error.

frederikhors

comment created time in a month

PR closed sveltejs/svelte

add cubicBezier
+70 -171

1 comment

2 changed files

pushkine

pr closed time in a month

pull request commentsveltejs/svelte

add cubicBezier

closed in #4925

pushkine

comment created time in a month

PR opened sveltejs/svelte

Disable "one-var" lint rule

Code_2020-05-29_12-32-03 I just don't think it's necessary, maybe I'm missing something ?

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchpushkine/svelte

branch : lint

created branch time in a month

pull request commentsveltejs/svelte

Convert /test to typescript

So apparently @lukeed was right, you can just import tiny-glob normally like you'd anywhere else (can you believe this ?), there was absolutely no reason to inline it

I followed the other advice and shared the code transforming the compiled component into expected output between the script and the test & moved the helper to helpers.ts

I kind of had to merge the two PRs together to share that code, seems alright to me but let me know if I need to raise another PR ? maybe it's the added script in package.json that's uncomfortable ? I don't see any issue with the code

pushkine

comment created time in a month

push eventpushkine/svelte

pushkine

commit sha bcb13218809a29b18a3422aea455c02b28d1f32e

fix

view details

push time in a month

push eventpushkine/svelte

Ben McCann

commit sha 4124ec535eddc2a519b210e948028aaaac36e40d

site: update FAQ to point to svelte-check (#4916)

view details

pushkine

commit sha 86323addfb441d71d1055ba590e9fe33f05c4275

fix error & crlf

view details

pushkine

commit sha 61a27d5f98ca41ad1ec3ce3fa81dcab1816b6487

Merge branch 'update-expected' into typescript-tests

view details

pushkine

commit sha e0c67b57757ec26ed4a039ed91e84dd7aa48c4e4

remove error end check

view details

pushkine

commit sha 3b9106d193ce8b336d730429c5a17bf82b33b6c2

Merge branch 'update-expected' into typescript-tests

view details

pushkine

commit sha fe865526708745f878bc053357fc70db4209d015

dry + only replace updated files

view details

pushkine

commit sha 16da0c260cdcff5ec17ca9af25fc23f621ef5d08

lint

view details

pushkine

commit sha 2545fe7fd342c250dc4c1994c60a64e8ce5df0b5

rename for clarity

view details

pushkine

commit sha 03907e59c49e26be1ad6231380d1e35e8027813e

rebuild before script

view details

pushkine

commit sha 5be29fe0d53c07d70cf5501155a39cf5c431e6fd

Merge branch 'update-expected' into typescript-tests

view details

pushkin

commit sha 0da70f46b9cf8f702c6d50ba030939362be17ee5

handle line ending differences in tests (#4915)

view details

pushkine

commit sha c353632a8a533a35860edd4038fbd8a15b3b72e5

glob

view details

pushkine

commit sha 5136cc832e68c6da2f0219ea11878fae433db248

Merge branch 'master' into typescript-tests

view details

pushkine

commit sha 548a4154389ed84b064c9a21dff7ce6ec73ba084

Merge branch 'update-expected' into typescript-tests

view details

pushkine

commit sha 36a0b717d43cb0c2f0f4c5ccbf5530c0ff47e627

lint

view details

pushkine

commit sha 6f61b5d70d6a9879ff5dfe1137c90a22d279fdea

glob

view details

pushkine

commit sha fa363a5b6cf316e608a17f464f19f17e053a0364

lint

view details

push time in a month

PR closed sveltejs/svelte

Better /test expected result update

Previously you'd have to re-run the command once for every updated result, and it'd still update files whose results did not change

this pr adds a script that updates all expected results from test/js and test/parser, it mimics test assertions so as to only commit changed output

+369 -27

4 comments

7 changed files

pushkine

pr closed time in a month

pull request commentsveltejs/svelte

[internals] Inline helpers + tweaks

The disagreement appears to be on the tradeoff between extra bytes & runtime performance I guess it means the PR is on sleep until we get some kind of benchmarking and sciency graph going

My bet is that nobody really knows since the source code is actually torn apart between the two extremes, so the safe bet is as always ``no changes

pushkine

comment created time in a month

pull request commentsveltejs/svelte

[internals] Inline helpers + tweaks

Can I ask why these changes are necessary? What benefits do they bring?

Hiya! My understanding is that the use of helpers, methods & iterations to type less code and improve readability is worth it in user land, however in tools such as in a compiler the goal is rather to take every chance you get to "pre chew" any piece of work before it lands in the browser

I don't know, is there a disagreement or a misunderstanding ? Don't hesitate hitting me up on discord for instant messaging btw

pushkine

comment created time in a month

pull request commentsveltejs/svelte

Better /test expected result update

I'm not sure what you mean, could you demonstrate another way to update those files ? At once ? Without adding 300~ visibly unchanged files to your pr ?

Why are you worried about performance after mentioning it should rarely run, if ever ? Have you tried running it ? The actual scripts shouldn't take more than a second or two.

Are you implying that the compiler is unlikely to change ? I tried addressing specifically the problems you mention, shrinking the "to keep track of" part down to the absolute minimum. If I knew how to import properly I'd just share code between the two but it appears that you don't know either

Am I missing something ? I've been tweaking a lot with the library in the past few weeks and that part was especially a pain to get through, meanwhile this pr gets it done in a single click

pushkine

comment created time in a month

pull request commentsveltejs/svelte

Better /test expected result update

Hiya! I think you're right, however I don't any clue as to how to import the module in this configuration, I'm always getting the Cannot find module 'tiny-glob/sync.js' error on my side, perhaps could you point me toward the solution ?

pushkine

comment created time in a month

issue commentsveltejs/svelte

Events happen in a different order in Chrome vs Firefox

firefox - chrome firefox_2020-05-28_17-59-42

https://svelte.dev/repl/eb67900496e94128b8a54133c3e5c1b0?version=3.22.3

Rich-Harris

comment created time in a month

PR opened sveltejs/svelte

[internals] Inline helpers + tweaks

$$restProps & $$slots ( render_dom/index.ts, wrappers/Slot.ts )

  • inline all helpers but get_slot_changes
  • removed unused $$scope declaration variable in dev mode

other inlined helpers

  • destroy_each( arr, detaching )
    • for ( ... ) if ( each_value ) each_value.d( detaching )
  • query_selector_all( id, document.head )
    • Array.from((document.head || document.body ).querySelectorAll( id ))
  • create_component / claim_component (component.$$.fragment)
    • if ( component.$$.fragment ) component.$$.fragment .c() / .l()
  • component_subscribe( $$self, store, callback )
    • $$self.$$.on_destroy.push(subscribe(store, callback))
  • null_to_empty
    • null != value ? value : ""
  • is_function
    • "function" === typeof value
  • is_promise
    • value && "object" === typeof value && "function" === typeof value.then
  • assign
    • { ...a, ...b }
  • blank_object
    • Object.create( null )
  • get_spread_object
    • typeof props === "object" && props !== null ? props : {}
  • run / run_all
    • for( ... ) each_value();
  • foo = get_store_value( store )
    • subscribe(store, (v) => foo = v)()

render_listeners

  • follow domnodes pattern whereby each listener now gets its own variable
  • avoid declaring an extra variable for action.destroy

src/runtime

  • inlined components update function
  • moved all dev functions to dev.ts
  • predeclared loop variables & removed the unnecessary consts in dom.ts and spread.ts
  • moved once modifier from utils.ts to dom.ts
  • converted some .forEach into for loops

Those changes naturally require updating expected test results. I intentionally did not commit those so as to give maintainers an opportunity to test the #4914 script, but all test are passing.

+276 -366

0 comment

29 changed files

pr created time in a month

push eventpushkine/svelte

pushkine

commit sha 6095628c3eddfe0eccfa2610db1643f7472d4f31

for loops

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha f20359c920c6ed1df561d1e56cdfd96728da91ec

lint

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 1157cee42adedda5f289f7e4db33c21ee8363695

fix

view details

pushkine

commit sha 5a7d1c05c8faef1764bea028910a5ef3e20927b6

fix

view details

pushkine

commit sha d354a5bc6ddf0e55aba0ce6a9e4f86db7ea3ad93

fix

view details

push time in a month

create barnchpushkine/svelte

branch : inline-helpers

created branch time in a month

push eventpushkine/svelte

pushkine

commit sha 03907e59c49e26be1ad6231380d1e35e8027813e

rebuild before script

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 2545fe7fd342c250dc4c1994c60a64e8ce5df0b5

rename for clarity

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 16da0c260cdcff5ec17ca9af25fc23f621ef5d08

lint

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha fe865526708745f878bc053357fc70db4209d015

dry + only replace updated files

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 8fabca902803d12f928fbe65ce4c3f68289f761e

Revert "add error `end` check" This reverts commit 9cbd760d86263b391d1d6718404cd59f22e6109d.

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha e0c67b57757ec26ed4a039ed91e84dd7aa48c4e4

remove error end check

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 9cbd760d86263b391d1d6718404cd59f22e6109d

add error `end` check

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 86323addfb441d71d1055ba590e9fe33f05c4275

fix error & crlf

view details

push time in a month

pull request commentsveltejs/svelte

fix auto crlf issue

Done, let me know if there's anything else

pushkine

comment created time in a month

PR opened sveltejs/svelte

remove legacy mode

legacy : true does 2 things: it adds a dev warning for event listener modifiers and it passes slightly different arguments to set_input_type. Docs say it generates different output for element.dataset which is not even true. I don't think that keeping an option to target IE8 sets realistic expectations for users of the framework

+1 -86

0 comment

12 changed files

pr created time in a month

create barnchpushkine/svelte

branch : remove-legacy

created branch time in a month

push eventpushkine/svelte

pushkine

commit sha b1556ea3b5c66b25df0fa7a8ff490a0160e39cff

remove autocrlf from actions & readme

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha b351f0d262cd48a85d97d19e1bacbd3ae0c14dad

lint

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 813fd4b2e2da82a2de41dd780ea4a8483a7de274

missed 1 glob import

view details

push time in a month

PR opened sveltejs/svelte

Convert /test to typescript

This pr builds on top of #4915 and #4914

#4914 required inlining tiny-glob, in this pr it is removed from dependencies.

mocha.opts is deprecated, so I deleted it and included it to package.json with options bail ( stop at first test failed ) and timeout : 10000 ( throw if a test goes beyond 10s [default 2s] )

Github doesn't pickup changes in some renamed files so I'll write what I've done

In a nutshell I made mocha require sucrase so it could run typescript & renamed every file from .js to .ts. All I had to do then is to keep running tests and fix incoming errors until everything passes. I have not added type checking yet so as to make the reviewing process straightforward.

Here are the changes :

  • use import instead of require in test/test.ts

  • import from helpers instead of helpers.js

  • fix Cannot set property document of #<Window> which has only a getter by adding a in check in helpers.ts line 67

  • fix TypeError: assert.htmlEqual is not a function by exporting assert from helpers

  • fix TypeError: puppeteer.launch is not a function by importing default instead of *

  • fix TypeError: virtual is not a function by importing default instead of *

  • fix lint Unnecessary try/catch wrapper by removing it in hydration/index

  • fix lint Empty block statement by adding empty comment in hydration/index

+406 -107

0 comment

27 changed files

pr created time in a month

create barnchpushkine/svelte

branch : typescript-tests

created branch time in a month

pull request commentsveltejs/svelte

fix auto crlf issue

Basically hundreds of tests will fail on windows machines unless you clone the repository with the core.autocrlf false parameter or something, I know it's written about somewhere in a contributing FAQ/WIKI but I can't find it anymore this pr basically removes \r from every test & from css hashing so that every platform produces the same output by default I believe --global core.autocrlf false can be removed, I just don't know anything about that stuff so I didn't mess with it

pushkine

comment created time in a month

push eventpushkine/svelte

pushkine

commit sha 34f946894e3e4713247c385fc29c2529ea0090b4

lint

view details

push time in a month

PR opened sveltejs/svelte

fix auto crlf issue
+16 -18

0 comment

8 changed files

pr created time in a month

create barnchpushkine/svelte

branch : test-error-pos

created branch time in a month

push eventpushkine/svelte

pushkine

commit sha d7708c5c92cf6efddb0f25e833cba2648113aa6e

lint

view details

push time in a month

PR opened sveltejs/svelte

Better /test expected result update

Previously you'd have to re-run the command once for every updated result, this updates test/js and test/parser with a single npm script

+345 -26

0 comment

6 changed files

pr created time in a month

push eventpushkine/svelte

pushkine

commit sha 00bb5d103a5a268f79dcb95213a7d176747ad21e

restore tiny-glob

view details

push time in a month

create barnchpushkine/svelte

branch : update-expected

created branch time in a month

create barnchpushkine/svelte

branch : tests

created branch time in a month

PR closed sveltejs/svelte

Convert /test to typescript
  • bumped all dependencies except for periscopic, eslint and css-tree
  • added dependencies @types/puppeteer, @types/jsdom
  • inlined dependency tiny-glob
  • added script to update expected in css & js
  • updated expected
  • removed error position checking for some tests
  • removed css hash checking for some tests
  • replaced [\r\n] in output comparison tests to avoid windows issues
  • added .skip feature in some dirs
+2092 -1573

5 comments

122 changed files

pushkine

pr closed time in a month

fork pushkine/svelte

Cybernetically enhanced web apps

https://svelte.dev

fork in a month

Pull request review commentsveltejs/svelte

Convert /test to typescript

 npm install && npm run update npm run dev ``` -### Is svelte.dev down?

this is embarrassing

pushkine

comment created time in a month

push eventpushkine/svelte

pushkine

commit sha 3244a3eaa6b6ef4f65d9b0e9587fd8defeafaccf

revert package-lock

view details

push time in a month

push eventpushkine/svelte

mtrelis

commit sha aac78219cc84e24696d2fa809510bc619dd2b93d

commit

view details

mtrelis

commit sha fe634a8e042584e5b9d132901f3c2d026ba59c06

c

view details

mtrelis

commit sha ce101ea026ab1ec2875b205c813d9183bad7d7ba

c

view details

mtrelis

commit sha 029030cd27ec476ef8b7ef4f03a266c3ddf257c6

lint

view details

mtrelis

commit sha d643ac784947c045b39dacd03802a87797c8a2ac

api docs + test

view details

pushkin

commit sha 63217887f9059561d79c3bbe01819542d90da912

Merge branch 'master' into master

view details

pushkine

commit sha af558a2bf4c9992d2962279b595d791f663c4578

Merge remote-tracking branch 'upstream/master'

view details

pushkine

commit sha a4f7624b9a85fd54caea14f0e3a66b504a099148

init

view details

pushkine

commit sha e68ebb40b026a32667fece040841e6a7a2fe8982

expected, lint, etc

view details

pushkine

commit sha 25a631a78f991213b81fd8d651f1c4c0b424583f

Merge branch 'master' of https://github.com/pushkine/svelte

view details

pushkine

commit sha 125ac529e8f07ecb1445d3584261eedd789fce4f

Revert "Merge branch 'master' of https://github.com/pushkine/svelte" This reverts commit 25a631a78f991213b81fd8d651f1c4c0b424583f, reversing changes made to e68ebb40b026a32667fece040841e6a7a2fe8982.

view details

pushkine

commit sha 8e6103740e985113d78288f9fbf5730fa8dc54f4

Merge branch 'master' of https://github.com/pushkine/svelte

view details

Ben McCann

commit sha 745c7778060eebc77e38f5d33fac804473d33172

site: move .dev TLD info from FAQ to readme (#4883)

view details

Matt Wolff

commit sha 97db5cc7f73c97b7a94f4fa5ee8a0a28978e65bc

docs: add blur to list of svelte/transition exports

view details

Daniel Imfeld

commit sha f624d6e292e6cf960200ba9ae42e3d5fdf7d7003

docs: `value` cannot be set via spread for indirectly bound values (#4832)

view details

Tan Li Hau

commit sha e34f2088434423914bbc91b84a450a7f7477252b

reselect <select> when the option values change (#4885)

view details

pushkine

commit sha 71571b0b1f16fc0ca0a647d56b875a00b25172eb

Merge remote-tracking branch 'upstream/master'

view details

pushkine

commit sha deab67bb0480219fdf86832e61ca0a66abe1b2ca

Merge branch 'master' into tests

view details

pushkine

commit sha 40de1feb9514e69a609763e436996c1d4d68e3be

try with crlf

view details

pushkine

commit sha 47bb5bbe94301e48c583d066420457ce17dfb783

Revert "Merge branch 'master' into tests" This reverts commit deab67bb0480219fdf86832e61ca0a66abe1b2ca, reversing changes made to aff9f42673e03965b1058c229fd2be8f90c775bf.

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha aff9f42673e03965b1058c229fd2be8f90c775bf

rollback package-lock

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha e30f34618540e35f0600ebd1b14e4515bdb4af8c

lint

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha 18cf3c105fdfcb1a177802316aba410a5823ce88

remove esm, ts-mocha

view details

push time in a month

pull request commentsveltejs/svelte

Convert /test to typescript

initial commit up to https://github.com/sveltejs/svelte/pull/4886/commits/6e94f5bd2e4963bc01219f5e26486dbf3c214740 works fine with updated deps on node >= 10 rolled back deps on last commit, it should work after updating expected tests results I'm getting windows permissions conflicts with npm, I don't have time for that

pushkine

comment created time in a month

push eventpushkine/svelte

pushkine

commit sha a91a7d4570637393d389335989a45c16898d6f8c

update expected

view details

push time in a month

push eventpushkine/svelte

pushkine

commit sha d6ae61f61161f7d1785b7fc3bb66b5de04a02815

remove deps bump

view details

push time in a month

more