profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/pracucci/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Marco Pracucci pracucci Grafana Labs Italy https://pracucci.com Principal Software Engineer at Grafana Labs

grafana/cortex-jsonnet 65

This repo has the jsonnet for deploying and also the mixin for monitoring Cortex

pracucci/node-cidr-matcher 22

Fast CIDR matcher. Given an input IPv4 or IPv6 address, it checks if it's inside a set of IP ranges, expressed in CIDR notation.

grafana/puppet-promtail 12

Deploy and configure Grafana's Promtail with Puppet

pracucci/php-on-kubernetes 8

Lessons learned running PHP on Kubernetes in production

pracucci/lokitool 5

Tooling for Grafana Loki

pracucci/elasticsearch-playstore 3

Google Play Store App Analytics importer for ElasticSearch

pracucci/alertmanager 1

Prometheus Alertmanager

pracucci/avalanche 1

Prometheus/OpenMetrics endpoint series generator for load testing.

pracucci/cortex 1

A multitenant, horizontally scalable Prometheus as a Service

pracucci/etcd 1

Distributed reliable key-value store for the most critical data of a distributed system

push eventcortexproject/cortex

ci

commit sha 0c4672fe77119c0fdd9ed7ed8208c9eaf887a6dd

Deploy to GitHub pages

view details

push time in a day

PR opened thanos-io/thanos

Allow to customize attributes cache for CachingBucket.GetRange() operation
  • [ ] I added CHANGELOG entry for this change.
  • [x] Change is not relevant to the end user.

Changes

CachingBucket.GetRange() currently caches attributes in the same cache backend where the subobjects are cached. We have an use cases for which we would like to set a different caching backend for attributes. In this PR I'm proposing to allow it.

Draft: if PR is fine, then I will do changes in Cortex first in order to get the PR correctly compile (right now I've committed a change to vendor/ too).

Verification

Existing tests.

+15 -7

0 comment

4 changed files

pr created time in a day

push eventcortexproject/cortex

ci

commit sha 2bf5837134f103fefaacbd3e11f4ce65a9f2173c

Deploy to GitHub pages

view details

push time in a day

PullRequestReviewEvent

push eventcortexproject/cortex

ci

commit sha 8d8c49a43e736c8fc4d345c0ae329c158cd42bea

Deploy to GitHub pages

view details

push time in 2 days

PullRequestReviewEvent

push eventcortexproject/cortex

ci

commit sha 8c7c9449c0b1936812d07f4d73be851ebd165299

Deploy to GitHub pages

view details

push time in 3 days

push eventcortexproject/cortex

ci

commit sha 7f8a37f36e1b5c453847ee23ae21a9dae6c0694a

Deploy to GitHub pages

view details

push time in 3 days

PullRequestReviewEvent

delete branch pracucci/alertmanager

delete branch : fix-sns-receiver-http-client

delete time in 3 days

create barnchpracucci/alertmanager

branch : fix-sns-receiver-http-client

created branch time in 4 days

PR opened prometheus/alertmanager

Fix HTTP client options in SNS receiver

The HTTP client options passed to SNS receiver are ignored because the HTTP client is never passed to the SNS client. This PR fixes it.

+3 -3

0 comment

1 changed file

pr created time in 4 days

delete branch grafana/cortex-jsonnet

delete branch : improve-queries-dashboard

delete time in 4 days

push eventgrafana/cortex-jsonnet

Marco Pracucci

commit sha e2d45e7afa5dad6dbe45cd3288c04bce006afae0

Improve Cortex / Queries dashboard Signed-off-by: Marco Pracucci <marco@pracucci.com>

view details

Marco Pracucci

commit sha 1d5e6a4a90b412c10ada522d887197b4eab960d5

Merge pull request #393 from grafana/improve-queries-dashboard Improve Cortex / Queries dashboard

view details

push time in 4 days

PR merged grafana/cortex-jsonnet

Improve Cortex / Queries dashboard

What this PR does: In this PR I'm proposing to improve a bit the "Cortex / Queries" dashboard.

Which issue(s) this PR fixes: N/A

Checklist

  • [ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
+49 -15

0 comment

1 changed file

pracucci

pr closed time in 4 days

PR opened grafana/cortex-jsonnet

Reviewers
Improve Cortex / Queries dashboard

What this PR does: In this PR I'm proposing to improve a bit the "Cortex / Queries" dashboard.

Which issue(s) this PR fixes: N/A

Checklist

  • [ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
+49 -15

0 comment

1 changed file

pr created time in 4 days

create barnchgrafana/cortex-jsonnet

branch : improve-queries-dashboard

created branch time in 4 days

pull request commentgrafana/dskit

Adding util/shard and util/yolobuf

Let's please move both ShuffleShardSeed and yoloString into the ring code. It's fine to export ShuffleShardSeed, but let's keep yoloString private. We don't want to encourage its use from dskit.

I agree with Peter.

treid314

comment created time in 4 days

pull request commentgrafana/dskit

add util/strings

Let's keep this out of public API, and focus on moving code useful for building "distributed systems" into dskit. If Ring code uses them, feel free to make a copy in the Ring PR, but let's keep the functions private.

I agree with Peter.

treid314

comment created time in 4 days

pull request commentgrafana/dskit

Feature: Add dslog and tenant packages

Who else uses the tenant stuff, other than Cortex?

aknuds1

comment created time in 4 days

issue commentgrafana/dskit

Make `flagext` pkg consistent across different projects

@56quarters Loki still have its custom version of flagext (already mentioned in the description) and its still using it. My point is we should bring that also into dskit. And Loki should use only flagext from dskit!.

I think it depends on what we wanna port. Is the data type specific to Loki? Then I would keep it in Loki. Is the data type generic (ex. human bytes) then we can move it to dskit if can benefit other projects too.

kavirajk

comment created time in 4 days

issue commentgrafana/dskit

Replace use of default registerer in flagext package

What @pstibrany suggested sounds a reasonable solution to me. I would keep the init function restricted to the flagext package tho. If we make it generic, it's more likely we'll end up using global logger/registered in other places, which is something we want to strongly discourage.

56quarters

comment created time in 4 days

Pull request review commentgrafana/cortex-jsonnet

Split limits config into a variable we can reuse

       'server.grpc.keepalive.max-connection-idle': '1m',        'distributor.ingestion-rate-limit-strategy': 'global',

[nit] I would move this too.

gouthamve

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventcortexproject/cortex

ci

commit sha d3669c8f81df719c36d76bc0fe7b0fbfeeee3e1b

Deploy to GitHub pages

view details

push time in 5 days

push eventcortexproject/cortex

nous23

commit sha 523dde19b8c841f62152a5cd6110cf67bd5540b9

fix querier panics when query exemplars (#4473) * fix querier panics when query exemplars Signed-off-by: nous23 <cchen23@outlook.com> * Update CHANGELOG.md Co-authored-by: Peter Štibraný <pstibrany@gmail.com> Signed-off-by: nous23 <cchen23@outlook.com> Co-authored-by: Peter Štibraný <pstibrany@gmail.com>

view details

push time in 5 days

PR merged cortexproject/cortex

fix querier panics when query exemplars size/XS

What this PR does: fix querier panics when query exemplars

Which issue(s) this PR fixes: Fixes #4469

The panic:

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x14497b5]

goroutine 1295 [running]:
github.com/opentracing-contrib/go-stdlib/nethttp.MiddlewareFunc.func5.1(0xc000a1fc08, 0x2d46780, 0xc00113f560)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/opentracing-contrib/go-stdlib@v1.0.0/nethttp/server.go:150 +0x1ab
panic(0x242fb40, 0x3e2f400)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/runtime/panic.go:965 +0x1b9
github.com/cortexproject/cortex/pkg/util/extract.MetricNameMatcherFromMatchers(0xc000942578, 0x1, 0x1, 0xc000af2e80, 0x20, 0x0, 0x0, 0x14f9b45)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/util/extract/extract.go:58 +0x75
github.com/cortexproject/cortex/pkg/distributor.(*Distributor).GetIngestersForQuery(0xc000664000, 0x2d18a20, 0xc0010b66c0, 0xc000942578, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, ...)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/distributor/query.go:138 +0x133
github.com/cortexproject/cortex/pkg/distributor.(*Distributor).QueryExemplars.func1(0x2d18a20, 0xc0010b66c0, 0x1a, 0xc0469b556a0f3025)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/distributor/query.go:67 +0x119
+2 -1

2 comments

2 changed files

nous23

pr closed time in 5 days

issue closedcortexproject/cortex

querier panics when query exemplars

Describe the bug querier panics when query exemplars

To Reproduce

  1. set ShardByAllLabels = false for querier
  2. call /api/v1/query_exemplars

Expected behavior querier dose not panic

Environment:

  • Kubernetes

Storage Engine

  • Blocks

Additional Context

https://github.com/cortexproject/cortex/blob/74055d8f4176a1907d548e377f44b67e18d7306e/pkg/distributor/query.go#L62

replicationSet, err := d.GetIngestersForQuery(ctx, nil)

should not pass nil here. will result in panics later in MetricNameMatcherFromMatchers

https://github.com/cortexproject/cortex/blob/74055d8f4176a1907d548e377f44b67e18d7306e/pkg/util/extract/extract.go#L58

stack info:

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x14497b5]

goroutine 1295 [running]:
github.com/opentracing-contrib/go-stdlib/nethttp.MiddlewareFunc.func5.1(0xc000a1fc08, 0x2d46780, 0xc00113f560)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/opentracing-contrib/go-stdlib@v1.0.0/nethttp/server.go:150 +0x1ab
panic(0x242fb40, 0x3e2f400)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/runtime/panic.go:965 +0x1b9
github.com/cortexproject/cortex/pkg/util/extract.MetricNameMatcherFromMatchers(0xc000942578, 0x1, 0x1, 0xc000af2e80, 0x20, 0x0, 0x0, 0x14f9b45)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/util/extract/extract.go:58 +0x75
github.com/cortexproject/cortex/pkg/distributor.(*Distributor).GetIngestersForQuery(0xc000664000, 0x2d18a20, 0xc0010b66c0, 0xc000942578, 0x1, 0x1, 0x0, 0x0, 0x0, 0x0, ...)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/distributor/query.go:138 +0x133
github.com/cortexproject/cortex/pkg/distributor.(*Distributor).QueryExemplars.func1(0x2d18a20, 0xc0010b66c0, 0x1a, 0xc0469b556a0f3025)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/distributor/query.go:67 +0x119
github.com/weaveworks/common/instrument.CollectedRequest(0x2d18978, 0xc001159bc0, 0x28526e8, 0x1a, 0x2d07e30, 0xc0001a1338, 0x29b7fd0, 0xc000942790, 0x10, 0xc000b45b30)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/weaveworks/common@v0.0.0-20210419092856-009d1eebd624/instrument/instrument.go:152 +0x271
github.com/cortexproject/cortex/pkg/distributor.(*Distributor).QueryExemplars(0xc000664000, 0x2d18978, 0xc001159bc0, 0x17bca307ae0, 0x17bca676960, 0xc000a1fd40, 0x1, 0x1, 0xc0007a0600, 0x20, ...)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/distributor/query.go:60 +0x125
github.com/cortexproject/cortex/pkg/querier.(*distributorExemplarQuerier).Select(0xc0007a0600, 0x17bca307ae0, 0x17bca676960, 0xc000a1fd40, 0x1, 0x1, 0x0, 0xed8cbec9c, 0x0, 0x0, ...)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/querier/distributor_queryable.go:228 +0x9e
github.com/prometheus/prometheus/web/api/v1.(*API).queryExemplars(0xc000b49440, 0xc00031f800, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/prometheus/prometheus@v1.8.2-0.20210510213326-e313ffa8abf6/web/api/v1/api.go:509 +0x9cb
github.com/prometheus/prometheus/web/api/v1.(*API).Register.func1.1(0x2d06c60, 0xc0007a0540, 0xc00031f800)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/prometheus/prometheus@v1.8.2-0.20210510213326-e313ffa8abf6/web/api/v1/api.go:264 +0xa5
net/http.HandlerFunc.ServeHTTP(0xc000b77c50, 0x2d06c60, 0xc0007a0540, 0xc00031f800)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/net/http/server.go:2069 +0x44
github.com/prometheus/prometheus/util/httputil.CompressionHandler.ServeHTTP(0x2cd3560, 0xc000b77c50, 0x2d0c450, 0xc0007a04e0, 0xc00031f800)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/prometheus/prometheus@v1.8.2-0.20210510213326-e313ffa8abf6/util/httputil/compression.go:90 +0x7e
github.com/prometheus/common/route.(*Router).handle.func1(0x2d0c450, 0xc0007a04e0, 0xc00031f700, 0x0, 0x0, 0x0)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/prometheus/common@v0.26.1-0.20210603143733-6ef301f414bf/route/route.go:83 +0x27f
github.com/julienschmidt/httprouter.(*Router).ServeHTTP(0xc000b7bf80, 0x2d0c450, 0xc0007a04e0, 0xc00031f700)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/julienschmidt/httprouter@v1.3.0/router.go:387 +0xc7e
github.com/prometheus/common/route.(*Router).ServeHTTP(0xc000b78e20, 0x2d0c450, 0xc0007a04e0, 0xc00031f700)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/prometheus/common@v0.26.1-0.20210603143733-6ef301f414bf/route/route.go:121 +0x4c
github.com/cortexproject/cortex/pkg/api.getHTTPCacheGenNumberHeaderSetterMiddleware.func1.1(0x2d0c450, 0xc0007a04e0, 0xc00031f700)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/api/middlewares.go:26 +0x206
net/http.HandlerFunc.ServeHTTP(0xc0007a0320, 0x2d0c450, 0xc0007a04e0, 0xc00031f700)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/net/http/server.go:2069 +0x44
github.com/weaveworks/common/middleware.Instrument.Wrap.func1.2(0x2d0c450, 0xc0007a04e0)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/weaveworks/common@v0.0.0-20210419092856-009d1eebd624/middleware/instrument.go:68 +0x4c
github.com/felixge/httpsnoop.CaptureMetricsFn(0x2d0c450, 0xc0007a02e0, 0xc000549300, 0x2, 0x2d41c90, 0xc001159b80)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/felixge/httpsnoop@v1.0.1/capture_metrics.go:81 +0x24b
github.com/weaveworks/common/middleware.Instrument.Wrap.func1(0x2d0c450, 0xc0007a02e0, 0xc00031f700)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/weaveworks/common@v0.0.0-20210419092856-009d1eebd624/middleware/instrument.go:67 +0x325
net/http.HandlerFunc.ServeHTTP(0xc0009a84b0, 0x2d0c450, 0xc0007a02e0, 0xc00031f700)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/net/http/server.go:2069 +0x44
github.com/gorilla/mux.(*Router).ServeHTTP(0xc0008b4300, 0x2d0c450, 0xc0007a02e0, 0xc00031f400)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/gorilla/mux@v1.7.3/mux.go:212 +0xd3
github.com/cortexproject/cortex/pkg/querier/stats.WallTimeMiddleware.Wrap.func1(0x2d0c450, 0xc0007a02e0, 0xc00031f400)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/querier/stats/time_middleware.go:25 +0xca
net/http.HandlerFunc.ServeHTTP(0xc000690d80, 0x2d0c450, 0xc0007a02e0, 0xc00031f400)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/net/http/server.go:2069 +0x44
github.com/weaveworks/common/middleware.glob..func1.1(0x2d0c450, 0xc0007a02e0, 0xc00031f300)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/weaveworks/common@v0.0.0-20210419092856-009d1eebd624/middleware/http_auth.go:17 +0x147
net/http.HandlerFunc.ServeHTTP(0xc000690e28, 0x2d0c450, 0xc0007a02e0, 0xc00031f300)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/net/http/server.go:2069 +0x44
github.com/gorilla/mux.(*Router).ServeHTTP(0xc0008b4a80, 0x2d0c450, 0xc0007a02e0, 0xc00031f100)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/gorilla/mux@v1.7.3/mux.go:212 +0xd3
github.com/weaveworks/common/middleware.Instrument.Wrap.func1.2(0x2d0c450, 0xc0007a02e0)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/weaveworks/common@v0.0.0-20210419092856-009d1eebd624/middleware/instrument.go:68 +0x4c
github.com/felixge/httpsnoop.CaptureMetricsFn(0x2d07e60, 0xc0009a8410, 0xc000549990, 0x2, 0x2d41c90, 0xc001159b40)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/felixge/httpsnoop@v1.0.1/capture_metrics.go:81 +0x24b
github.com/weaveworks/common/middleware.Instrument.Wrap.func1(0x2d07e60, 0xc0009a8410, 0xc00031f100)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/weaveworks/common@v0.0.0-20210419092856-009d1eebd624/middleware/instrument.go:67 +0x325
net/http.HandlerFunc.ServeHTTP(0xc000a18960, 0x2d07e60, 0xc0009a8410, 0xc00031f100)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/net/http/server.go:2069 +0x44
github.com/weaveworks/common/middleware.Log.Wrap.func1(0x2d0c150, 0xc0007a0220, 0xc00031f100)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/weaveworks/common@v0.0.0-20210419092856-009d1eebd624/middleware/logging.go:52 +0x1a9
net/http.HandlerFunc.ServeHTTP(0xc000959000, 0x2d0c150, 0xc0007a0220, 0xc00031f100)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/net/http/server.go:2069 +0x44
github.com/opentracing-contrib/go-stdlib/nethttp.MiddlewareFunc.func5(0x2d0a5f0, 0xc001159a40, 0xc00031f000)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/opentracing-contrib/go-stdlib@v1.0.0/nethttp/server.go:154 +0x5e4
net/http.HandlerFunc.ServeHTTP(0xc000959040, 0x2d0a5f0, 0xc001159a40, 0xc00031f000)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16_cache/buildbox/go-1.16.3/src/net/http/server.go:2069 +0x44
github.com/weaveworks/common/httpgrpc/server.Server.Handle(0x2cd3560, 0xc000959040, 0x2d18a20, 0xc000515710, 0xc0009a8280, 0xc000515710, 0x231c1e0, 0x3ddfd60)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/cmd/pkg/mod/github.com/weaveworks/common@v0.0.0-20210419092856-009d1eebd624/httpgrpc/server/server.go:61 +0x2f1
github.com/cortexproject/cortex/pkg/querier/worker.(*frontendProcessor).runRequest(0xc000b26e40, 0x2d18978, 0xc0000d4580, 0xc0009a8280, 0x1, 0xc000a1fbc0)
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/querier/worker/frontend_processor.go:123 +0x89
created by github.com/cortexproject/cortex/pkg/querier/worker.(*frontendProcessor).process
	/data/fuxi_ci_workspace/612d9ff956bed87ff117ab16/pkg/querier/worker/frontend_processor.go:98 +0x16a

closed time in 5 days

nous23