profile
viewpoint

CarterCommunity/Carter 770

Carter is framework that is a thin layer of extension methods and functionality over ASP.NET Core allowing code to be more explicit and most importantly more enjoyable.

ctolkien/SodaPop.ConfigExplorer 35

Displays diagnostic information on all the properties registered with configuration

ctolkien/SodaPop.RazorPagesSitemap 3

Generates a sitemap based on the layout of your Razor Pages website.

poke/AspNetCore-RazorBlazor 3

RazorBlazor combination example

Felixomni/gw2wiki-android 2

Guild Wars 2 Wiki app for Android

poke/angular-oauth2-oidc 0

Support for OAuth 2 and OpenId Connect (OIDC) in Angular.

poke/anticontainer 0

DownThemAll! AntiContainer

poke/aspnet-logging-issue697 0

FileLoadException for System.Runtime.InteropServices.RuntimeInformation on old-style .csproj test projects

poke/aspnet-mvc-issue3196 0

https://github.com/aspnet/Mvc/issues/3196

issue commentAzureAD/passport-azure-ad

adfs axample?

For those looking for bearer authentication to protect an API with a JWT that was issued by a local ADFS, this is my setup:

const bearerOptions = {
  // metadata endpoint for the local ADFS
  identityMetadata: 'https://adfs.example.com/adfs/.well-known/openid-configuration',

  // issuer address (`access_token_issuer` property in the metadata)
  issuer: 'http://adfs.example.com/adfs/services/trust',
  validateIssuer: true,

  // client id and token audience (“Relying Party Identifier“ from the “Web API” in the ADFS application group)
  clientID: 'https://api.example.com',
};

passport.use(new BearerStrategy(bearerOptions,
  function(token, done) {
    console.log('Received the following claims in the token:', token);
    return done(null, token);
  }
));
mosharov

comment created time in 3 days

issue commentdotnet/sdk

UserSecretsId attribute not generated when M.E.C.UserSecrets reference transitively

@explorer14

Sorry, but this is not really a "fix"

Nobody mentioned anything about a fix. The bug is known and this issue is open to track a proper fix.

Since this issue is where people are being pointed when they encounter the problem, it is a useful thing to document the workarounds for it. Which is what was asked for and what I did.

If its in code then at least it wouldn't be removed without somebody noticing it

The same could be said about explicitly adding the user secret id to the AssemblyInfo.cs (which is usually redundant because things can be specified through the project file) or to the AddUserSecrets call (which is redundant because user secrets are already configured through the default host builder).

anurse

comment created time in 4 days

issue commentdotnet/sdk

UserSecretsId attribute not generated when M.E.C.UserSecrets reference transitively

The easiest workaround, which doesn’t require you to change any of your code, is to add an explicit package reference to the user secrets package.

So in addition to the default reference Microsoft.Extensions.Hosting, also explicitly add Microsoft.Extensions.Configuration.UserSecrets in your .csproj to trigger the mechanism that makes the default host builder setup find your user secrets:

<ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Hosting" Version="3.1.8" />
    <PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="3.1.8" />
</ItemGroup>
anurse

comment created time in 5 days

startedpatriksvensson/duck

started time in 5 days

startedspectresystems/spectre.console

started time in 5 days

startedwieslawsoltes/BatchEncoder

started time in 5 days

PullRequestReviewEvent

pull request commentctolkien/SodaPop.RazorPagesSitemap

Support ASP.NET Core 3.1

LGTM although I don’t know much about this RazorProjectFileSystem thing.

ctolkien

comment created time in 7 days

issue commentdotnet/runtime

Finalize logging analyzers

Hey, is there any chance that we could publish a preview version of the logging analyzers on NuGet? I’m totally fine with the current feature set and would just like to consume them, ideally without having to rely on a separate nightly feed.

pakrym

comment created time in 2 months

issue commentdotnet/aspnetcore

Allow generic type constraints

In that case, maybe no need for changes because a person should use partial classes anyways.

I wouldn't agree with that since there are plenty examples of components that require a generic constraint but do not really need a code-behind.

It's good that we can achieve what we need right now, so this isn't a pressing issue. The end goal however should be that we can do this without code-behind. I'm totally fine if that comes later with 6.0.

rkone

comment created time in 2 months

issue commentdotnet/aspnetcore

Allow generic type constraints

@joshlang You may need to explicitly specify the type argument when you use your generic component. E.g.

<Fancy TItem="ItemType" Item="someItem"></Fancy>
rkone

comment created time in 2 months

issue commentdotnet/aspnetcore

Kestrel port binding default to 80 or 443 / No error/warn/info/debug when "{abc}" provided

Digging a bit deeper, it seems that this part of BindingAddress.Parse is responsible:

https://github.com/dotnet/aspnetcore/blob/4aa5e03207a005d7310ba792c76f5339d74c3364/src/Http/Http/src/BindingAddress.cs#L131-L138

portString is correctly determined as "{abc}" but then there is an attempt to parse it which will obviously fail. Since there is no port, the default scheme port will be used and the :{abc} will be understood as part of the host.

To be honest, I don’t really understand why the logic was done like this. I would expect the parsing to fail when the identified portString does not end up being a number. After all, it existing means that there is a colon before, so the original string is a:b where b is not a number. I only see two options where a colon would be valid as part of the authority of an URI though:

  • As part of the user info, although this would require an @ before the host name. And for the address binder, this wouldn’t really make any sense.
  • Or for IPv6 addresses. Although then the part after the colon would be required to be a hexadecimal number, so curly braces definitely wouldn’t be allowed.

While supporting IPv6 addresses is obviously required in some way, I would expect the parsing to actually fail with some kind of error instead of blindly accepting the :{abc} here. Maybe we can fine tune this just a little bit so inputs like these would throw an error.

tebeco

comment created time in 2 months

issue commentdotnet/aspnetcore

Kestrel port binding default to 80 or 443 / No error/warn/info/debug when "{abc}" provided

This appears to be a problem with BindingAdress.Parse which gets called early in the AddressBinder. Since the binder is not able to produce a better result from the input, it will eventually fall back to just binding on the port that the BindingAdress contains:

https://github.com/dotnet/aspnetcore/blob/4aa5e03207a005d7310ba792c76f5339d74c3364/src/Servers/Kestrel/Core/src/Internal/AddressBinder.cs#L135-L139

Unfortunately, BindingAddress.Parse does not appear to parse the input very well:

BindingAddress.Parse producing a port 443

Calling BindingAddress.Parse("https://*:{abc}") will recognize *:{abc} as the host and assume the default HTTPS port 443.

tebeco

comment created time in 2 months

fork poke/PnP-Sites-Core

Office 365 Dev PnP Core component (.NET) targeted for increasing developer productivity with CSOM based solutions.

fork in 2 months

startedmeziantou/Meziantou.Analyzer

started time in 2 months

issue comment0xd4d/dnSpy

Releases are no longer accessable.

@ril3y From the Actions page click on the latest successful action (or look for an action with a tagged version for more stability). Then, on the action detail page, it looks like this:

Artifacts

Those artifacts are clickable links—but only if you are logged in.

ril3y

comment created time in 2 months

issue comment0xd4d/dnSpy

Releases are no longer accessable.

I just had problems accessing the releases as well. Yes, they are available from within the Actions but apparently you can only access Action artifacts if you are logged into GitHub. This is somewhat a problem because I just had to log into my GitHub account on a remote machine just to download dnSpy. While I totally get why this was moved to Actions, this is somewhat suboptimal.

ril3y

comment created time in 2 months

more