PR opened woocommerce/woocommerce-ios
Fixes #1479
Testing
- Enable dark mode
- Navigate to an order which contains shipping details
- Check that everything is ok like in the screenshot
| Before | After |
|---|---|
 |
 |
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr created time in 2 days
create barnchwoocommerce/woocommerce-ios
branch : issue/1479-dark-mode-shipping-method-order-details
created branch time in 2 days
delete branch woocommerce/woocommerce-ios
delete branch : issue/1475-cell-selection-style-in-reviews
delete time in 3 days
push eventwoocommerce/woocommerce-ios
commit sha 0750888b5f4e9b860b47569a61edbf1eb58e7029
Fixed cell selection style.
commit sha cb831f523a902ca4889d6f372273d097c79a32f1
Merge pull request #1476 from woocommerce/issue/1475-cell-selection-style-in-reviews Fixed cell selection style in Reviews with dark mode enabled
push time in 3 days
PR merged woocommerce/woocommerce-ios
Fixes https://github.com/woocommerce/woocommerce-ios/issues/1475
This should be the last PR for just making the app usable in Dark mode when building the codebase with the release version of Xcode 11 on iOS 13.
Testing
- Enable dark mode
- Navigate to product reviews
- Make sure that cell selection background is grey and not black
Screenshots
| Before | After |
|---|---|
 |
 |
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 3 days
issue closedwoocommerce/woocommerce-ios
Xcode 11 + Dark Mode: cell selection style in Reviews
In Reviews screen, when you tap a cell with dark mode enabled it becomes dark.
Screenshots
closed time in 3 days
pmusolino
delete branch woocommerce/woocommerce-ios
delete branch : issue/1465-settings-cells-selection-style-dark-mode
delete time in 3 days
push eventwoocommerce/woocommerce-ios
commit sha a2ede6c1eb8ffee3dc01048c157091c219e3ebac
Fixed background appearance when selected
commit sha 7a6907d318361b8c7c952f7eb455cccef2308cd8
Updated release notes
commit sha e07981c8ce2356da85fb55c64ab42ba78701e153
Merge pull request #1474 from woocommerce/issue/1465-settings-cells-selection-style-dark-mode Fixed Settings cells selection style with dark mode enabled
push time in 3 days
PR merged woocommerce/woocommerce-ios
Fixes https://github.com/woocommerce/woocommerce-ios/issues/1465
Testing
- Enable dark mode
- Navigate to settings
- Make sure that cell selection background is grey and not black
Screenshots
| Before | After |
|---|---|
 |
 |
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 3 days
issue closedwoocommerce/woocommerce-ios
Xcode 11 + Dark mode: Settings cells selection style
When you try to run the app with Xcode 11 & iOS 13 with dark mode enabled, Settings screen appears like that when you try to select a cell.
closed time in 3 days
pmusolino
delete branch woocommerce/woocommerce-ios
delete branch : issue/1415-product-list-update-sorting
delete time in 3 days
push eventwoocommerce/woocommerce-ios
commit sha 97fa539e703d9890b1fdf2de556d55e6f11bc003
Now products are sorted by Product title
commit sha 7ac76d7cd098915bb2c70188693c7166110cbdc9
Merge pull request #1477 from woocommerce/issue/1415-product-list-update-sorting Updated sorting in Product List
push time in 3 days
PR merged woocommerce/woocommerce-ios
Fixes #1415
Now the product list is sorted Alphabetically by product title, like in Android.
Testing
- Go to Product List
- Check that product are sorted alphabetically
- Check that product in search are sorted alphabetically
Screenshot
<img src="https://user-images.githubusercontent.com/495617/68863950-98946080-06f0-11ea-9dc8-2f7d6a93855f.png" data-canonical-src="https://user-images.githubusercontent.com/495617/68863950-98946080-06f0-11ea-9dc8-2f7d6a93855f.png" width="350" />
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 3 days
issue closedwoocommerce/woocommerce-ios
Right now it's sorted by last modified date, and from our Product meeting we are updating the order to be the same as in core:
- publish date
- last modified date
closed time in 3 days
jaclync
PR opened woocommerce/woocommerce-ios
Fixes #1415
Now the product list is sorted Alphabetically by product title, like in Android.
Testing
- Go to Product List
- Check that product are sorted alphabetically
- Check that product in search are sorted alphabetically
Screenshot
<img src="https://user-images.githubusercontent.com/495617/68863950-98946080-06f0-11ea-9dc8-2f7d6a93855f.png" data-canonical-src="https://user-images.githubusercontent.com/495617/68863950-98946080-06f0-11ea-9dc8-2f7d6a93855f.png" width="350" />
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr created time in 3 days
create barnchwoocommerce/woocommerce-ios
branch : issue/1415-product-list-update-sorting
created branch time in 3 days
issue commentwoocommerce/woocommerce-ios
After some discussions, we decided to go for the same order used by Android, where they sort products by Title.
comment created time in 3 days
PR opened woocommerce/woocommerce-ios
Fixes https://github.com/woocommerce/woocommerce-ios/issues/1475
This should be the last PR for just making the app usable in Dark mode when building the codebase with the release version of Xcode 11 on iOS 13.
Testing
- Enable dark mode
- Navigate to product reviews
- Make sure that cell selection background is grey and not black
Screenshots
| Before | After |
|---|---|
|
|
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr created time in 3 days
create barnchwoocommerce/woocommerce-ios
branch : issue/1475-cell-selection-style-in-reviews
created branch time in 3 days
issue openedwoocommerce/woocommerce-ios
Xcode 11 + Dark Mode: cell selection style in Reviews
In Reviews screen, when you tap a cell with dark mode enabled it becomes dark.
Screenshots
created time in 3 days
PR opened woocommerce/woocommerce-ios
Fixes https://github.com/woocommerce/woocommerce-ios/issues/1465
Testing
- Enable dark mode
- Navigate to settings
- Make sure that cell selection background is grey and not black
Screenshots
| Before | After |
|---|---|
|
|
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr created time in 3 days
push eventwoocommerce/woocommerce-ios
commit sha 7a6907d318361b8c7c952f7eb455cccef2308cd8
Updated release notes
push time in 3 days
create barnchwoocommerce/woocommerce-ios
branch : issue/1465-settings-cells-selection-style-dark-mode
created branch time in 3 days
issue openedwoocommerce/woocommerce-ios
Bug: Switching store doesn't work like expected
If you try to change the store from Settings, but you don't press continue after choosing it, you will see that the default store of the app changed, and the store name in settings is the old one (as long as you don't change screen). This bug can be reproduced systematically.
To Reproduce
- Make sure you have more than one store on your account.
- Go to Settings
- Press Switch Store
- Tap on a store, and press Dismiss (not continue)
- You will see that the store tapped is now configured in all the app, and the selected store, as long as you don't change the screen, is the old one.
Screenshots
Mobile Environment
- Device: Simulator
- iOS version: iOS 13.1
- Woo app version: 2.9 & 3.0
created time in 4 days
issue openedwoocommerce/woocommerce-ios
Xcode 11 + Dark mode: Settings cells selection style
When you try to run the app with Xcode 11 & iOS 13 with dark mode enabled, Settings screen appears like that when you try to select a cell.
created time in 4 days
issue commentwoocommerce/woocommerce-ios
:wave: Jaclyn!
I noticed while testing product list that now products are sorted by last modified date, but the last modified is at the end of the list. So if I edit a product, and I go back, I expect to find it on top of the list. So if we sort by publish date, we risk losing the product that we edited. Right? Maybe the good order can be sorted by the last modified date (descending), where if the parameter is not available we can use the publish date. Sounds good to you?
comment created time in 4 days
delete branch woocommerce/woocommerce-ios
delete branch : issue/1445-wrong-spacing-between-sections-in-order-detail
delete time in 4 days
delete branch woocommerce/woocommerce-ios
delete branch : issue/1385-fix-dark-mode-in-reviews
delete time in 4 days
delete branch woocommerce/woocommerce-ios
delete branch : issue/1455-wrong-spacing-between-sections-in-order-detail
delete time in 4 days
push eventwoocommerce/woocommerce-ios
commit sha de8498b119bc877d4970280a1a57649347ca432b
Fixed header and footer spaces
commit sha 9b8c564d0a3346d433456f1fd178a3e0059295c7
Fixed Trailing Whitespace Violation and Opening Brace Spacing Violation
commit sha cb1e4fdf13a02fc62890e52162aca160b85f1862
Updated Release Notes
commit sha a268b6fd3fc387b5fe7c920b443f6e21c0f04c63
Merge pull request #1459 from woocommerce/issue/1455-wrong-spacing-between-sections-in-order-detail Order Detail: fixed wrong spacing between sections
push time in 4 days
PR merged woocommerce/woocommerce-ios
Fixes #1455
Testing
- Navigate to an order detail
- Check that the first section on the Order Screen with the customer name and status doesn't have any space above it
- Check that the spacing between sections looks like in Fulfill order screen.
Screenshots
| Before | After |
|---|---|
 |
 |
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 4 days
issue closedwoocommerce/woocommerce-ios
Order Detail: wrong spacing between sections
Two UI problems on Order Detail screen.
-
The first section on the Order Screen with the customer name and status shouldn't have any space above it
-
The spacing between sections looks very inconsistent, we should have consistent spacing throughout the app. The right spacing is the one used on Fulfill screen.
| Wrong spacing | Right spacing |
|---|---|
 |
 |
closed time in 4 days
pmusolino
push eventwoocommerce/woocommerce-ios
commit sha cf92d1f9f4e48b02bc3e885c482b50dd7bd8fa90
Fixed Opening Brace Spacing Violation, Trailing Whitespace Violation and other violations of Hound-CI
commit sha 9de9c1df031042e544d757302c371777604662fa
Fix space
commit sha 0695e242cae8eadf6b5bf577f24e03926273e8ea
Fix space
commit sha f56030cdd5a633ceb80378248ba6831c9d940015
Fix hound ci warning
commit sha daa14edf1183fc96872f574c05e21005ce909d39
Merge branch 'develop' into issue/hounds-ci
commit sha 13f9e92d9fe4ad379fa61f21381beab12fb6fbc9
Merge pull request #1460 from woocommerce/issue/hounds-ci Fixed Hound-CI violations
push time in 4 days
PR merged woocommerce/woocommerce-ios
Since Hound-CI was re-enabled on the project, we had some issues to resolve.
The meaning of this PR is to fix all the errors that Hound-CI could generate, like Opening Brace Spacing Violation, Trailing Whitespace Violation and other things.
Testing
- Check the code
Update release notes:
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 4 days
push eventwoocommerce/woocommerce-ios
commit sha cb1e4fdf13a02fc62890e52162aca160b85f1862
Updated Release Notes
push time in 4 days
push eventwoocommerce/woocommerce-ios
commit sha 3938126fc72b51fdd81f9db0f201e6e076439724
Add a color palette
commit sha 2683cc2fa0a343f76edc386bd4e0bbe394d970ee
Update color palette with WooCommerce Purple
commit sha 01cc1a46349619e1722f34d11235dcb84441f7ce
Remove a color extension that seems to be unused
commit sha bb943216c2203916e0d2f29ae2b69a805f728fd2
Add MurielPalette, and initializers for colors
commit sha 3e751cb68f9937cb1a237605177447fce505bed4
Merge branch 'develop' into issue/1431-dark-mode
commit sha af7b78362e16d0b41824bff0fca45b7ce3ab5fab
Start moving colors to the Muriel Palette
commit sha 398f34ba3a7bc08c3fbbf522a927f33f715b000a
Merge branch 'develop' into issue/1431-dark-mode
commit sha 8f14920739d24252c819e16464895eaa4f687c5a
Apply some more colors
commit sha f8b8577d443148e6df3d8f01144c0cc76e283ec0
At this point, I don’t know what I’m doing. I am going to set a breakpoint here, and start from scratch
commit sha e42458b428177e95c77872b8a5ebdd77d181f1da
Remove some redundancy in colors
commit sha 39985efbaa669a66fb15303a6271adb4c08cfe03
Merge branch 'develop' into issue/1431-dark-mode
commit sha 0e5492726f1c5fdf3bccb834d4d3f1a8f8f60d37
Undo changes to Style
commit sha ab0d14e4ef8bcc4bf79901223fd70234193f75cd
Merge branch 'develop' into issue/1431-dark-mode
commit sha e89525e4f2e90fc72b62c15f7c1083e921100190
First iteration of Muriel-based colours
commit sha 9fd763eab2f9144f1b22d6eec9ebb80db467878b
Start testing MurielColor And complete tests
commit sha c9f73dff52949432be095eff9b53f93fd6ce925d
Setup for testing color assets
commit sha 14e2e3e78347849d4d7d9f5b31b3b665d284543e
Test all pure colors
commit sha 98c03bb37663deebe5fe2766080c976b36207cea
Test all shades of muriel colors
commit sha e72bbcc36e54f3509cb9ee78613506cea209ddf3
Add some whitespacing
commit sha ece52fcf7960e8e6096ae2b92a98efb08e61f7da
More whitespacing
push time in 4 days
push eventwoocommerce/woocommerce-ios
commit sha f56030cdd5a633ceb80378248ba6831c9d940015
Fix hound ci warning
push time in 4 days
push eventwoocommerce/woocommerce-ios
commit sha 0695e242cae8eadf6b5bf577f24e03926273e8ea
Fix space
push time in 4 days
push eventwoocommerce/woocommerce-ios
commit sha 9de9c1df031042e544d757302c371777604662fa
Fix space
push time in 4 days
PR opened woocommerce/woocommerce-ios
Since Hound-CI was re-enabled on the project, we had some issues to resolve.
The meaning of this PR is to fix all the errors that Hound-CI could generate, like Opening Brace Spacing Violation, Trailing Whitespace Violation and other things.
Testing
- Check the code
Update release notes:
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr created time in 5 days
push eventwoocommerce/woocommerce-ios
commit sha 9b8c564d0a3346d433456f1fd178a3e0059295c7
Fixed Trailing Whitespace Violation and Opening Brace Spacing Violation
push time in 5 days
PR opened woocommerce/woocommerce-ios
Fixes #1455
Testing
- Navigate to an order detail
- Check that the first section on the Order Screen with the customer name and status doesn't have any space above it
- Check that the spacing between sections looks like in Fulfill order screen.
Screenshots
| Before | After |
|---|---|
|
|
Update release notes:
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr created time in 5 days
create barnchwoocommerce/woocommerce-ios
branch : issue/1455-wrong-spacing-between-sections-in-order-detail
created branch time in 5 days
create barnchwoocommerce/woocommerce-ios
branch : issue/1445-wrong-spacing-between-sections-in-order-detail
created branch time in 5 days
delete branch woocommerce/woocommerce-ios
delete branch : issue/1447-order-details-navigation-dark-mode
delete time in 5 days
push eventwoocommerce/woocommerce-ios
commit sha 81d71620bdee3b9b63165f520123f4246c11ce3c
Fixed StatusListTableViewCell background color when selected with Dark Mode enabled
commit sha db11c3e0303a98f910537030371def264b3a9f0f
Fixed WooBasicTableViewCell background color when selected with Dark Mode enabled
commit sha 82cfa572cd9dbf55e44ea1fcb65110f043efb7e7
Fixed LeftImageTableViewCell background color when selected with Dark Mode enabled
commit sha e8c3c8c365acab23fac6c4dd7e36769cb613b449
Fixed ProductDetailsTableViewCell background color when selected with Dark Mode enabled
commit sha 2c35bd9f0a6a7f7088ab00c7cc7f7fc1fdc07c6f
Fixed PickListTableViewCell background color when selected with Dark Mode enabled
commit sha 4fdd3561fe7110315914df0041a1d5c302a3d683
Minor changes in PickListTableViewCell
commit sha 41b22a85d8ce9c72747f88667e012d21b89993a0
Fixed BillingAddressTableViewCell background color when Dark Mode is enabled
commit sha 083754c463282006e830375bad11862aa310faca
Minor fix on CellPickTableViewCell
commit sha 1555686361781d99ffaa325dec2bdd2d1fbd1c3d
Updated RELEASE-NOTES
commit sha 27e8ebcfa4fb7e326d3b502d8965ac269cecd654
Updated release notes
commit sha 1c243549e0e6bc90aa67b73b5fadd41b27014425
Improved condition of image download
commit sha 788007f3b5422d4af8f678f8ea2bf4a7b5c76871
Merge branch 'develop' into issue/1447-order-details-navigation-dark-mode
commit sha 8a3dc59c91a16f8137d3ff9a96bf5d3560eee0dc
Merge pull request #1452 from woocommerce/issue/1447-order-details-navigation-dark-mode Order detail flow: fixed UI appearance with Dark mode enabled
push time in 5 days
PR merged woocommerce/woocommerce-ios
Fixes #1447
I fixed all the issues on Order Detail and Order Fulfillment when dark mode is enabled (also some cell selection styles not mentioned on issue #1447).
TODO
- [x] Edit Order status
- [x] Processing Order: Product > Begin Fulfillment
- [x] Completed Order: Product > Details
- [x] Customer > View Billing Information
Testing
- Enable dark mode from device settings.
- Navigate to an order detail.
- Tap on every cell and check that every selection style it's ok.
- Navigate on every sub-flow, and check that appearance of these sections it's ok.
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 5 days
issue closedwoocommerce/woocommerce-ios
Order details navigation Dark mode issues
This issue fixes the Dark Mode issues before we support Dark Mode for these screens navigated from the Order Details screen:
- [x] Edit Order status
- [x] Processing Order: Product > Begin Fulfillment
- [x] Completed Order: Product > Details
- [x] Customer > View Billing Information
Moved Rachel's comment here:
I see similar issues when I tap from the OrderDetai ls screen to edit the order status, or view the Billing Information or Product Details:
closed time in 5 days
jaclync
delete branch woocommerce/woocommerce-ios
delete branch : issue/1362-add-order-shipping-method
delete time in 5 days
push eventwoocommerce/woocommerce-ios
commit sha 09e479ec79e6a8b0478f9faf7c1d291e87e56803
Implemented a new type of cell
commit sha 52a6db1671fd896bf7c9c9baf1078e7d89d11111
New color for background notice icon
commit sha da250b4f2f051f5ec43c8fecc767088cc243624f
added LeftImageMultilineTableViewCell in project.pbxproj
commit sha 02e249d9f91d8d734e253eed715d6452075d2aef
Implemented shipping notice cell into Order Detail
commit sha 60789838f81e00e79c2733538c00603e77ad4ed7
Shipping notice section now is working
commit sha f2cf365cf74b57c93dc88fcc43303e4eeb03a716
Added Shipping Method UI in Order Detail
commit sha f11cc7ed7de95cda835a6816539834cdc3961ea1
Updated RELEASE-NOTES.txt
commit sha 9a915414c36a8e88c7ac38f12237f24ff35d89a7
OrderDetailsDataSource code optimizations
commit sha 323d6f24b5fc2b63678f610e24efa1149e0107bd
Clean and code optimizations in OrderDetailsDataSource
commit sha b7bf24d18c3d6e03ea55509c5bc0ecba5782ae4f
Added shipping method details in Fulfill screen
commit sha 2d2c5840c13e9a3d6b6ed2d395b59ef76b498a8b
Fix space
commit sha 8a88e6338acda7626a1bbc3462d8b17111757cfb
Improved comment in NSLocalizedString
commit sha c1011968dfc7dc3a5a58a24195b963f1c9234939
Improved comments in NSLocalizedString
commit sha 0349c57b8d855211a71480ea29e8cc0efd8acde6
Refactoring LeftImageMultilineTableViewCell
commit sha 9ae4948d46be7ff2bafc3c62bc74b48fedba83e0
Unit test for notice image
commit sha 6e0423bde869359de0ec4a969cac20463fcbaac4
Cleaned code about virtual products
commit sha 6cba05a87747943b0b4ceb9f4c1d9f991fa8294e
Fix accessibilityHint
commit sha b0f13bb66142ccd9e8e9d933c5d4253b558aedbf
Merge branch 'develop' into issue/1362-add-order-shipping-method
commit sha 69b5bcae314d1b577f33806908f0bafa89cb01cc
Unified cell to show shipping notice in order detail
commit sha da7f4087e83c31b76de73703ffd4a2a93e69d319
Merge pull request #1434 from woocommerce/issue/1362-add-order-shipping-method Issue/1362 Add Order Shipping Method
push time in 5 days
PR merged woocommerce/woocommerce-ios
Fixes #1362. This PR adds the shipping method details to the Order detail and order Fulfill screen.
Changes
- Adds the shipping method below the shipping address details in Order detail and order fulfill screen.
- The shipping card is only displayed for orders containing at least one virtual product. It should not be displayed for virtual products.
- There are plugins that allow multiple shipping methods for an order. It was decided that we would display a warning notice to the user, if an order contains multiple shipping methods. This warning notice will be displayed only on the Order Detail page.
- Only the first shipping method of an order will be displayed (if there are multiple shipping methods).
Note
The shipping method text is localized with the language configured inside the store.
Screenshots
Physical product with single shipping methods in an order
(LEFT: Order Detail . RIGHT: Order Fulfill)
. 
Physical product with multiple shipping methods in an order
Testing
- Order with only virtual products - should not display warning - should not display shipping method or warning notice.
- Order with physical + virtual products with single shipping methods - display the shipping method but the shipping warning should not be displayed.
- Order with physical + virtual products with multiple shipping methods - display the shipping method and the shipping warning notice.
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 5 days
issue closedwoocommerce/woocommerce-ios
Order Detail: Add shipping method to the shipping details section
As discussed, it would be nice to add the shipping method of an order in the Order Detail and Order Fulfillment screen.
Ref. p99K0U-1IW-p2
closed time in 5 days
anitaa1990
push eventwoocommerce/woocommerce-ios
commit sha 69b5bcae314d1b577f33806908f0bafa89cb01cc
Unified cell to show shipping notice in order detail
push time in 5 days
push eventwoocommerce/woocommerce-ios
commit sha 88bfec18e4d25d3fc68ad4cb80a8a5b69a99f8c1
Merge branch 'develop' into issue/1099-read-only-refunds-ui
commit sha edaacd25e0409913b0b7e0ac58bedbac32a00b28
Nit: spelling error in code documentation
commit sha b35c0d43288e6cf9dce1b8e33b254fc2e4422e84
Add missing method to RefundsRemote - request refunds by refundIDs
commit sha 228e4e61dbb79178238c936e9971ea590806d38b
Yosemite: define RefundAction and RefundStore No actions were previously created. No refund store was previously created.
commit sha a38992b20dc09db11b17803d459db28c85e22722
Update StorageType+Extensions to include methods for RefundStore
commit sha 3ed4715eb51164cb0383177ae9f4c6e59d0ca9b0
Add the OrderItemTax to the OrderStore. Update unit tests.
commit sha b2e06fff322a9bdb8c24d0240d355b84466140b2
Update a comment for clarity
commit sha bb25874d49a14e51de16ecf2ff94e63d2accc418
Re-generate OrderItem+CoreDataProperties
commit sha cd2f395030875a4b0ddfbdcf3425349cb1368f33
Broken unit tests (not broken code) - correct the order item taxes so that unit tests are valid
commit sha 5c85ad74de1f36e35635034c7c47add660d2131e
Merge branch 'develop' into issue/1099-read-only-refunds-ui
commit sha b40bcd0ea199b677b62b1f1630a344a5707810ac
Add RefundStoreTests file and first unit test for syncing refunds
commit sha e83f0e815b34375da781db19291abd4521e7282e
RefundStoreTests: add unit test to check all Refund fields are persisted
commit sha dd0dee749e7f80b652b87d675f65c515514bcc24
Add tests to check for error responses when requesting to sync refunds
commit sha 5c4197c3ab51f8fbec6bded9b5c436cf1866a507
Test that retrieving a single refund works (Hint: nope, it's broken)
commit sha 24a84856b6c548308db3921bd68ef6466342ac0f
Fix the broken refund API request path
commit sha 6616e9e42214268d8c93ca4926c05fd7b652f814
Add a unit test helper method to RefundStore
commit sha bc0f472199e78ee4a66b6c0d8ac6cf6325781119
Test refund fields and related objects persist properly
commit sha d23f252387bfdb8dee34ca887734e63a8fa75f6d
Test error and empty responses when requesting a single refund
commit sha d0ff074582059e2b11241b4da7f7c787899c605b
Test that a refund is deleted when the response returns 404 not found
commit sha 0d248cdbfd83c7d92403d6b6d4f61712d72e9fef
Test resetting the stored refunds deletes the cache
push time in 5 days
push eventwoocommerce/woocommerce-ios
commit sha 1c243549e0e6bc90aa67b73b5fadd41b27014425
Improved condition of image download
push time in 5 days
push eventwoocommerce/woocommerce-ios
commit sha 27e8ebcfa4fb7e326d3b502d8965ac269cecd654
Updated release notes
push time in 5 days
push eventwoocommerce/woocommerce-ios
commit sha 6d148ff6d714692618d1710eed3bf2afc0d5b267
Fixed dark mode appearance in NoteDetailsCommentTableViewCell
commit sha 95246e97379028f4a382791d0791478765093484
Fixed dark mode appearance in NoteDetailsHeaderPlainTableViewCell
commit sha 4da86f842f183de7787d09291e80c6f0cf4bb53d
Updated RELEASE-NOTES
commit sha e2d8c8f710d2241172c76d6a53f7c7024539dc36
Merge branch 'develop' into issue/1385-fix-dark-mode-in-reviews
commit sha efd424b1641b7be78a1cc454e42607be52ce4a17
Fixed ProductReviewTableViewCell background
commit sha 9f25a35954a950260036eab3eda158baec1b8359
Updated RELEASE-NOTES
commit sha a63ec21ef8a067dd452fd56f8a826e8d140f6adb
Fixed single space in NoteDetailsHeaderPlainTableViewCell before pragma mark
commit sha be8630ef93208a1992bfb51ebd1790bc361ae303
Merge pull request #1445 from woocommerce/issue/1385-fix-dark-mode-in-reviews Reviews: fixed dark mode appearance
push time in 5 days
PR merged woocommerce/woocommerce-ios
Fixes #1385
The scope of the PR is limited to just making the Reviews screen usable in Dark mode when building the codebase with the release version of Xcode 11. The dark mode appearance on "Loading review list" screen and "Review list" screen was already fixed.
Testing
- Activate dark mode
- Navigate to Product reviews
- Navigate from to a Review detail
- Check that everything is visually ok (readable, and without dark background)
Screenshots
| Before | After |
|---|---|
 |
 |
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 5 days
issue closedwoocommerce/woocommerce-ios
| Loading review list | Review list | Review details |
|---|---|---|
 |
 |
 |
closed time in 5 days
jaclync
push eventwoocommerce/woocommerce-ios
commit sha a63ec21ef8a067dd452fd56f8a826e8d140f6adb
Fixed single space in NoteDetailsHeaderPlainTableViewCell before pragma mark
push time in 5 days
push eventwoocommerce/woocommerce-ios
commit sha 9f25a35954a950260036eab3eda158baec1b8359
Updated RELEASE-NOTES
push time in 5 days
issue commentpmusolino/Wormholy
Hi there. Which version are you using? We fixed a memory leak in version 1.4.1. Try to install the latest version (1.5.0) and let me know.
Thanks
comment created time in 5 days
push eventpmusolino/Wormholy
commit sha 24ac1ee677ed35e05411cdac66b17604d2706157
Bump version to v.1.5.1
push time in 5 days
push eventwoocommerce/woocommerce-ios
commit sha 163e4f8ccc4ca7636c4ba77c77eb210d53cf0f65
Remove featureflag
commit sha 4caf4f6f5d70209bc8108aed6ed45aebd461e048
remove unused code
commit sha 6ba40af599c75813b2e97ae228f4e56adff03af8
Update release notes
commit sha 03f2eff1a9acc37a20e2ce29448c6d408fa5d013
Merge branch 'develop' into issue/1318-reviews-release # Conflicts: # WooCommerce/Classes/ViewRelated/Notifications/NotificationsViewController.swift
commit sha 9e08e669d777567338fd3e3b7bf040ffcc48e0a2
Networking layer: update Product description.
commit sha 67014779721aa10eb02a3828e9469323b8278e87
Yosemite layer: update Product description.
commit sha dfe05913297db767e36ba14ec3217a3775de78a3
Minor polishes.
commit sha 3e303adf481475d43a6234aec543ed0e5e3f4afe
Rename `updateProduct` to `updateProductDescription`.
commit sha 3149c1fc66d3da32818b48151153fddfecc603d0
Merge branch 'develop' into issue/1318-reviews-release
commit sha cc4d6e827185fd591fb85effa468018eb2ecd845
Merge branch 'develop' into issue/1421-product-description-backend
commit sha da80a1e579be5837858dbc23109aa26280056b8f
Merge pull request #1426 from woocommerce/issue/1421-product-description-backend Networking & Yosemite layers: update Product description
commit sha add69ab40ee509c61ea14aaad16974c6b9469ce5
Merge branch 'develop' into issue/1318-reviews-release
commit sha 617d5f81a6700e627dad0749f9952b84e941c72d
Create `KeyboardFrameObserver`.
commit sha 309b5721adf458a530c9afb902f25c09c3bb3acf
Handle keyboard height adjustment with `KeyboardFrameObserver` in `ManualTrackingViewController`.
commit sha 57944e122b2288978cfc62b6256d5a78d6b19018
Handle keyboard height adjustment with `KeyboardFrameObserver` in `ShipmentProvidersViewController`.
commit sha 80237e89f41ab8611eadf28d972ca75bbc2499c2
Handle keyboard height adjustment with `KeyboardFrameObserver` in `SearchViewController`.
commit sha 0bbfdf20d3d8fdac65bbb3bc4a600d406efb1063
Update class to struct.
commit sha 251328372bbbc72cfefdb299c251656c1f9dd285
Create `KeyboardScrollable` protocol that adjusts the scroll view with keyboard height.
commit sha 99ba6bc99d50c3987a239a698923818ef4130c22
Add Aztec pod.
commit sha e00745d746f94955bdca43c42f5e782026caed8b
v0 `AztecEditorViewController` and `EditorFactory` from Spike.
push time in 6 days
Pull request review commentwoocommerce/woocommerce-ios
Order detail flow: fixed UI appearance with Dark mode enabled
final class PickListTableViewCell: UITableViewCell { super.awakeFromNib() selectionStyle = .none-+ configureBackground() setupImageView() setupNameLabel() setupQuantityLabel() setupSkuLabel() }+}+++/// MARK: - Public Methods+///+extension PickListTableViewCell {+ func configure(item: OrderItemViewModel) {+ if item.productHasImage,+ let imageURL = item.imageURL {+ productImageView.downloadImage(from: imageURL,+ placeholderImage: UIImage.productPlaceholderImage)+ } else {+ productImageView.image = .productPlaceholderImage+ }++ name = item.name+ quantity = item.quantity+ sku = item.sku
Is there any reason to unwrap item.imageURL?
It seems that downloadImage() allows optional URL, so if imageURL is nil, it automatically shows the placeholder.
The whole condition can thus be rewritten
productImageView.downloadImage(from: item.imageURL,
placeholderImage: UIImage.productPlaceholderImage)
Maybe it can be further improved when we will implement the Image Caching https://github.com/woocommerce/woocommerce-ios/issues/1432
comment created time in 6 days
issue openedwoocommerce/woocommerce-ios
Order Detail: wrong spacing between sections
Two UI problems on Order Detail screen.
-
The first section on the Order Screen with the customer name and status shouldn't have any space above it
-
The spacing between sections looks very inconsistent, we should have consistent spacing throughout the app. The right spacing is the one used on Fulfill screen.
| Wrong spacing | Right spacing |
|---|---|
|
|
created time in 6 days
pull request commentwoocommerce/woocommerce-ios
Issue/1362 Add Order Shipping Method
- The images on the fulfil screen look stretched
This was fixed in another PR https://github.com/woocommerce/woocommerce-ios/pull/1438
- Across both screens the spacing between sections looks very inconsistent, we should have consistent spacing throughout the app
You are right. The problem is also present in the current release of the app. The right spacing seems to be the one used on the Fulfill screen. I'm going to open a new issue for that.
- The first section on the order screen with the customer name and status shouldn't have any space above it
Like above, the problem is also present in the current release of the app. I'm going to open a new issue for that.
comment created time in 6 days
delete branch woocommerce/woocommerce-ios
delete branch : issue/1453-dark-mode-product-list-cells
delete time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha bab4aa14a89190c47e056c94f4974093d593a3f4
Fixed Product List background cell when dark mode is enabled
commit sha 2d6564ce240d0a24401359c5ee54df5e4517338f
Merge pull request #1454 from woocommerce/issue/1453-dark-mode-product-list-cells Product List: fixed dark mode appearance
push time in 6 days
PR merged woocommerce/woocommerce-ios
Fixes #1453
The scope of the PR is limited to just making the Product List screen usable in Dark mode when building the codebase with the release version of Xcode 11.
Testing
- Activate dark mode
- Navigate to Product List
- Check that everything is visually ok (readable, and without dark background)
| Before | After | With the cell selected |
|---|---|---|
 |
 |
 |
Update release notes:
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 6 days
issue closedwoocommerce/woocommerce-ios
Xcode 11 + Dark mode: Product List
When you try to run the app with Xcode 11 & iOS 13 with dark mode enabled, Product List appears like that.
closed time in 6 days
pmusolino
PR opened woocommerce/woocommerce-ios
Fixes #1453
The scope of the PR is limited to just making the Product List screen usable in Dark mode when building the codebase with the release version of Xcode 11.
Testing
- Activate dark mode
- Navigate to Product List
- Check that everything is visually ok (readable, and without dark background)
| Before | After | With the cell selected |
|---|---|---|
|
|
|
Update release notes:
- [ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr created time in 6 days
create barnchwoocommerce/woocommerce-ios
branch : issue/1453-dark-mode-product-list-cells
created branch time in 6 days
issue openedwoocommerce/woocommerce-ios
Xcode 11 + Dark mode: Product List
When you try to run the app with Xcode 11 & iOS 13 with dark mode enabled, Product List appears like that.
created time in 6 days
issue closedwoocommerce/woocommerce-ios
Xcode 11. Dark mode and Order cells
Building release/2.7 with Xcode 11 has some interesting effects in the cells rendering orders when the device is set to dark mode
<img src="https://user-images.githubusercontent.com/2722505/66043384-47088b80-e51f-11e9-810a-1201a345c681.png" width="350"/>
Fully supporting Dark Mode for the Orders tab is out of scope of this ticket. This issue is only to make sure that the app is usable on devices running dark mode when built using Xcode 11.
closed time in 6 days
ctarda
issue commentwoocommerce/woocommerce-ios
Xcode 11. Dark mode and Order cells
On release 3.0 I'm no more able to replicate this issue.
comment created time in 6 days
PR opened woocommerce/woocommerce-ios
Fixed #1447
I fixed all the issues on Order Detail and Order Fulfillment when dark mode is enabled (also some cell selection styles not mentioned on issue #1447).
TODO
- [x] Edit Order status
- [x] Processing Order: Product > Begin Fulfillment
- [x] Completed Order: Product > Details
- [x] Customer > View Billing Information
Testing
- Enable dark mode from device settings.
- Navigate to an order detail.
- Tap on every cell and check that every selection style it's ok.
- Navigate on every sub-flow, and check that appearance of these sections it's ok.
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr created time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha 1555686361781d99ffaa325dec2bdd2d1fbd1c3d
Updated RELEASE-NOTES
push time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha 083754c463282006e830375bad11862aa310faca
Minor fix on CellPickTableViewCell
push time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha 41b22a85d8ce9c72747f88667e012d21b89993a0
Fixed BillingAddressTableViewCell background color when Dark Mode is enabled
push time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha 4fdd3561fe7110315914df0041a1d5c302a3d683
Minor changes in PickListTableViewCell
push time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha 2c35bd9f0a6a7f7088ab00c7cc7f7fc1fdc07c6f
Fixed PickListTableViewCell background color when selected with Dark Mode enabled
push time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha e8c3c8c365acab23fac6c4dd7e36769cb613b449
Fixed ProductDetailsTableViewCell background color when selected with Dark Mode enabled
push time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha 82cfa572cd9dbf55e44ea1fcb65110f043efb7e7
Fixed LeftImageTableViewCell background color when selected with Dark Mode enabled
push time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha db11c3e0303a98f910537030371def264b3a9f0f
Fixed WooBasicTableViewCell background color when selected with Dark Mode enabled
push time in 6 days
create barnchwoocommerce/woocommerce-ios
branch : issue/1447-order-details-navigation-dark-mode
created branch time in 6 days
delete branch woocommerce/woocommerce-ios
delete branch : issue/1360-fix-skewed-images-in-fulfill-order
delete time in 6 days
delete branch woocommerce/woocommerce-ios
delete branch : issue/1397-order-list-cells-become-dark-when-tapped
delete time in 6 days
delete branch woocommerce/woocommerce-ios
delete branch : issue/1389-fix-dark-mode-in-order-detail-cells
delete time in 6 days
pull request commentwoocommerce/woocommerce-ios
Reviews: fixed dark mode appearance
Loading review list always OK
comment created time in 6 days
pull request commentwoocommerce/woocommerce-ios
Reviews: fixed dark mode appearance
@ctarda just merged the new Reviews tab to develop, let's merge develop to here and test again!
Merged and fixed the new list.
| Before | After |
|---|---|
 |
 |
comment created time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha efd424b1641b7be78a1cc454e42607be52ce4a17
Fixed ProductReviewTableViewCell background
push time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha 163e4f8ccc4ca7636c4ba77c77eb210d53cf0f65
Remove featureflag
commit sha 4caf4f6f5d70209bc8108aed6ed45aebd461e048
remove unused code
commit sha 6ba40af599c75813b2e97ae228f4e56adff03af8
Update release notes
commit sha 03f2eff1a9acc37a20e2ce29448c6d408fa5d013
Merge branch 'develop' into issue/1318-reviews-release # Conflicts: # WooCommerce/Classes/ViewRelated/Notifications/NotificationsViewController.swift
commit sha 3149c1fc66d3da32818b48151153fddfecc603d0
Merge branch 'develop' into issue/1318-reviews-release
commit sha add69ab40ee509c61ea14aaad16974c6b9469ce5
Merge branch 'develop' into issue/1318-reviews-release
commit sha 022748e67a7f92e01bfdb4e49105c0a711849e2e
Bump version number
commit sha 5ef07a4f9d98bf11407b6bbace5b90e24d3529f0
Update release notes.
commit sha abe34a60bfbe3be5f1084f54002fbc3384de2894
update release notes
commit sha 7ac577749066bdd4b40a7972b3b936ce94a137de
Merge branch 'develop' into issue/1318-reviews-release
commit sha 00bfcfb55b9c3b0eb6d0b0499a5c8f2df5d51ec7
Fix dark mode appearance in some cells used in Order Detail screen
commit sha 7cc721ff2544645d1b74b232edc2ed2a151b43ec
Updated RELEASE-NOTES
commit sha cdd47981df454a3b14d355a3082d09fb8f46570b
Added new color Apple Light Gray
commit sha edfd0ef71d9be96a55df975224f5c21fd2e5737f
Fixed order list cell that become dark when tapped with dark mode enabled
commit sha 660298caec2f15838471445d6f44226e2ca9b27f
Updated RELEASE-NOTES
commit sha 6c4f676839c074c9186e1b51d00bd907781f1d3a
Introduced color tableViewCellSelectionStyle
commit sha 957b26b56603507e748a0146a2e0ac119b61ed06
Fix color tableViewCellSelectionStyle
commit sha f5cf588ce3102f817c415a121e6efbc7f6bcc7f6
update release notes
commit sha b2edc4166add9724b63f6d916682e5a3d936089b
Update metadata strings
commit sha 8cb4ef2133b86f8e84a7174ec3f760ed471f1966
Merge pull request #1437 from woocommerce/release/3.0 Merge 3.0 into develop
push time in 6 days
push eventwoocommerce/woocommerce-ios
commit sha cdd47981df454a3b14d355a3082d09fb8f46570b
Added new color Apple Light Gray
commit sha edfd0ef71d9be96a55df975224f5c21fd2e5737f
Fixed order list cell that become dark when tapped with dark mode enabled
commit sha 660298caec2f15838471445d6f44226e2ca9b27f
Updated RELEASE-NOTES
commit sha 6c4f676839c074c9186e1b51d00bd907781f1d3a
Introduced color tableViewCellSelectionStyle
commit sha 957b26b56603507e748a0146a2e0ac119b61ed06
Fix color tableViewCellSelectionStyle
commit sha 903aa57a1dda7165fcb6c6530f6cab0689234c59
Merge branch 'develop' into issue/1397-order-list-cells-become-dark-when-tapped
commit sha 123ed8501f1116f053bd0e3075e19eb8e2a8284d
Merge pull request #1444 from woocommerce/issue/1397-order-list-cells-become-dark-when-tapped Order List: fixed cells that become dark when tapped
push time in 6 days
PR merged woocommerce/woocommerce-ios
Fixes #1397
The scope of the PR is limited to just making the Order Detail screen usable in Dark mode when building the codebase with the release version of Xcode 11.
Changes
I introduced a new color inside StyleManager, which uses the D1D1D5 color. By default is the background color used by cells when they are tapped with light mode enabled.
Testing
- Activate dark mode
- Navigate to Order List
- Tap a cell. Check that everything is visually ok (readable, and without dark background)
Screenshots
| Before | After |
|---|---|
 |
 |
Update release notes:
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
pr closed time in 6 days
issue closedwoocommerce/woocommerce-ios
Xcode 11 + Dark mode: orders cells become dark when tapped
Device with dark mode enabled. Order list screen: when I tap a cell, it becomes dark, with unreadable content.
Related issue: https://github.com/woocommerce/woocommerce-ios/issues/1324
Screenshots
Mobile Environment
- Device: iPhone X
- iOS version: 13
- WooCommerce iOS version: 2.8
closed time in 6 days
pmusolino