profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/pmusolino/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Paolo Musolino pmusolino Automattic Inc. Rome Full remote iOS Software Engineer with more than 8 years of experience in the iOS platform. Heart and soul in every line of code.

dekatotoro/SlideMenuControllerSwift 3287

iOS Slide Menu View based on Google+, iQON, Feedly, Ameba iOS app. It is written in pure swift.

pmusolino/PMAlertController 2367

PMAlertController is a great and customizable alert that can substitute UIAlertController

pmusolino/awesome-swift 2

A collaborative list of awesome swift resources. Feel free to contribute!

pmusolino/BitfinexMonitor 2

The app display a live BTC/USD order book from Bitfinex

pmusolino/iOS-Goodies 2

Your favorite iOS Newsletter, now open source.

pmusolino/awesome-ios 1

A curated list of awesome iOS ecosystem, including Objective-C and Swift Projects

pmusolino/DWTagList 1

Create a list of tags from an NSArray to be show in a view with customisable fonts, colors etc.

pmusolino/NVActivityIndicatorView 1

Collection of nice loading animations

pmusolino/Activello 0

WordPress Bootstrap blog theme with doeznes of options using WordPress Customizer

pmusolino/AndroidSSH 0

Simple SSH and SFTP client for Android

issue commentwoocommerce/woocommerce-ios

Offline banner: it will not be dismissed when the internet connection is back

Tagging you @itsmeichigo because you worked on this feature, and maybe you know the reason.

pmusolino

comment created time in 2 hours

issue openedwoocommerce/woocommerce-ios

Offline banner: it will not be dismissed when the internet connection is back

It happened to me on the simulator (iPhone 13 Pro, iOS 15.0), while I was testing the shipping labels, that my connection stopped working. The wifi was connected, but the internet was not surfing.

The offline banner was displayed correctly in the order list, in the order detail, and in shipping label form screens, but when the connection returned and everything was back to normal, the banner was not dismissed. Even closing the view, and reopening it, the banner was still there, visible, as if I were still offline for it.

<img src="https://user-images.githubusercontent.com/495617/134661388-f7a7775d-c2e9-49a7-b472-da784ec8b779.png" width=300 />

created time in 2 hours

issue openedwoocommerce/woocommerce-ios

Shipping Labels: impossible to digit more than two or three digits in phone number

I discovered a serious bug (a regression) in Shipping Labels. This happens both on International and local shipping labels. It seems that if the Ship From address has the phone missing, it's impossible to add a phone number with more than 3 digits.

After typing 3 digits, the keyboard will be dismissed, the field is no more selectable and the done button will be enabled but by pressing it nothing will happen.

This issue happens also on Ship To address form, but the limit of digits will be 2 instead of 3.

The only way to remedy this problem is to copy and paste a number with ten digits.

Video: https://user-images.githubusercontent.com/495617/134660430-eb4000c5-e010-4f3d-bced-97aad90538b2.mp4

created time in 2 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue commentwoocommerce/woocommerce-ios

iOS 15: tab bar black in light mode, and "My Store" menu no more visible during the first loading

So, thank you both! 👯 @jaclync @momo-ozawa

pmusolino

comment created time in 4 hours

issue commentwoocommerce/woocommerce-ios

iOS 15: tab bar black in light mode, and "My Store" menu no more visible during the first loading

Sounds good. Thanks for investigating on this @jaclync 🙌 💯

pmusolino

comment created time in 5 hours

push eventwoocommerce/woocommerce-ios

Paolo Musolino

commit sha 87ebad5af02da4af1a28e1aa6e08c08f9f917475

fix: select default value for paper size in shipping label print screen

view details

Paolo Musolino

commit sha cc6cebccac50e2e67b8ee8d389c81d83e2f789a3

update: RELEASE-NOTES

view details

Paolo Musolino

commit sha d7ccb52a987483d8dcd0654749805c3b21e1cd0f

Merge branch 'develop' into issue/5014-select-default-value-for-paper-size-in-Print-screen

view details

Paolo Musolino

commit sha fb25492561c0d5bc16ab148b314969583880b886

Merge pull request #5035 from woocommerce/issue/5014-select-default-value-for-paper-size-in-Print-screen Select default value for paper size in Shipping Label print screen

view details

push time in a day

delete branch woocommerce/woocommerce-ios

delete branch : issue/5014-select-default-value-for-paper-size-in-Print-screen

delete time in a day

PR merged woocommerce/woocommerce-ios

Select default value for paper size in Shipping Label print screen type: enhancement feature: shipping labels

Fixes #5014

On Print Shipping Label screen, no paper size is selected by default and the Print button is disabled. There is no emphasis that the paper size should be selected for the Print button to be enabled, so this is not good in terms of discoverability. In this PR I fixed this behavior, selecting a default value for paper size. This also matches with the behavior on Android.

Testing

  1. Make sure your test store has WCShip plugin installed and set up packages for shipping in WPAdmin > WooCommerce > Settings > Shipping.
  2. Select an order eligible for creating shipping label and select Create Shipping Label.
  3. Proceed through the form to purchase a label.
  4. After purchase succeeds, notice that you've navigated to Print Shipping Label screen, and the Print button is enabled with a paper size selected.

<img src="https://user-images.githubusercontent.com/495617/134344335-a2f7d664-2396-4d74-88e2-4a4255eca189.png" width=300 />

Update release notes:

  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
+4 -1

2 comments

2 changed files

pmusolino

pr closed time in a day

issue closedwoocommerce/woocommerce-ios

Shipping Labels: Select default value for paper size in Print screen

Describe the bug On Print Shipping Label screen, no paper size is selected by default and the Print button is disabled. There is no emphasis that the paper size should be selected for the the Print button to be enabled, so this is not good in terms of discoverability.

To Reproduce Steps to reproduce the behavior:

  1. Make sure your test store has WCShip plugin installed and set up packages for shipping in WPAdmin > WooCommerce > Settings > Shipping.
  2. Select an order eligible for creating shipping label and select Create Shipping Label.
  3. Proceed through the form to purchase a label.
  4. After purchase succeeds, notice that you're navigated to Print Shipping Label screen, and the Print button is disabled.

Screenshots image

Expected behavior A default value for paper size should be selected so that the Print button can be enabled. This also matches with the behavior on Android.

Mobile Environment

  • WooCommerce iOS version: 7.5

closed time in a day

itsmeichigo

push eventwoocommerce/woocommerce-ios

Paolo Musolino

commit sha a22d182253b1b33784cdcad6db3fe7aa3871b91c

feat: new button add another credit card in Shipping Labels Payments screen

view details

Paolo Musolino

commit sha fb26110057da63ff14586737d310ffa54f96b320

fix: managed the case when there are no payments methods in Shipping Labels

view details

Paolo Musolino

commit sha a5416f29071d40271f486e7410b8bd6cede574ed

feat: started the implementation of `AuthenticatedWebView` in SwiftUI for opening a WPCom session

view details

Paolo Musolino

commit sha bbd5f99f865dba716e6d231021d899b255841248

feat: showAddPaymentWebView action

view details

Paolo Musolino

commit sha 4069f4c5d7e41aae8ba1f4a1e81c97e064cbbdc9

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels # Conflicts: # WooCommerce/WooCommerce.xcodeproj/project.pbxproj

view details

Paolo Musolino

commit sha 5faca9484644e60843ec1b843d812bae6bdf1600

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels # Conflicts: # WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/Create Shipping Label Form/Payment Methods/ShippingLabelPaymentMethods.swift

view details

Paolo Musolino

commit sha 9fd8f243980405fd101b2f7544d89b3e6c7d1daf

feat: split webview as separate view in payment methods

view details

Paolo Musolino

commit sha d18c74013c549f43d933f1656bf1f4b88b1b28d6

feat: implemented AuthenticatedWebViewDelegate

view details

Paolo Musolino

commit sha e0df54badc6ecfdafa77ce446083496714f18d52

fix: removed comments

view details

Paolo Musolino

commit sha ebcf1eed9d5e3c2069a08a35f469fbdac0c655e9

feat: handled navigation in AuthenticatedWebView

view details

Paolo Musolino

commit sha 49556c679737fbe329250a1d8ccae1c5b7fe0834

feat: cookie set in debug for AuthenticatedWebView

view details

Paolo Musolino

commit sha 87e57a6f41df5c8b6d43d19debfbc4acee0226e6

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels

view details

Paolo Musolino

commit sha 533ea27cd2fc9f949b5ce899a943a9d6c81d02fa

feat: final configuration for testing the authenticated web view in a sandbox environment

view details

Paolo Musolino

commit sha 53012e82a9b9573939b7707bc6993c06bd3aeb24

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels

view details

Paolo Musolino

commit sha 43cad0d2e392b9601b12e39021bedbbda2eb597b

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels

view details

Huong Do

commit sha d4adc5abe9a2ceaabd28a278d2724dd7b8539fed

Add lightning image

view details

Huong Do

commit sha 56010426721fd75fa135892596a0d1c64ae63c37

Update IconsTests for lightning image

view details

Huong Do

commit sha b21d1961b8f948f42dba6600709b9c52636bbf45

Add extension for UIViewController to configure offline banner

view details

Huong Do

commit sha 2ee175f06c1939b654cbca091a09e8be1d77f7e6

Update navigation controller toolbar visibility only when view controller is on screen

view details

Huong Do

commit sha fbf1c12b87cbf9efc2f447b1e5da2f2f6450d63b

Merge branch 'issue/4384-connectivity-service' into issue/4384-offline-banners

view details

push time in a day

issue openedwoocommerce/woocommerce-ios

Shipping Labels: API for getting the origin address from the last shipping label

As discussed here C026HH75ECA/p1632316480025600 it would be great to have a way for obtaining the last origin address used for creating a Shipping Label (WCShip plugin).

Currently, the behavior is different between mobile (iOS/Android) and the web. On the web, after having purchased a Shipping Label, the "Ship From" address will be the last used for purchasing a shipping label. On mobile, the address that will populate the "Ship From" form will be always the address of the store, because we don't have an API for accessing that information.

I also noticed that after buying a shipping label from mobile, when I try to create a new shipping label from the web, the "Ship From" address will be the one of the last shipping label purchased (also if it happened from mobile), so I imagine that the origin address is stored somewhere in the DB.

What do we want to accomplish?

The changes I make on the "Ship From" address aren't persisting between labels. We need an API for fetching the last origin address used in a Shipping Label. Ideally, it will return the address of the store if there are no existing shipping labels.

It would be great to follow this JSON format for the address (that we already use in the app, and it's the same format currently used in Orders, ShippingLabels, etc...):

"data": {
            "first_name": "Johnny",
            "last_name": "Appleseed",
            "company": "",
            "address_1": "234 70th Street",
            "address_2": "",
            "city": "Niagara Falls",
            "state": "NY",
            "postcode": "14304",
            "country": "US",
            "email": "scrambled@scrambled.com",
            "phone": "333-333-3333"
}

created time in 2 days

push eventwoocommerce/woocommerce-ios

Paolo Musolino

commit sha a22d182253b1b33784cdcad6db3fe7aa3871b91c

feat: new button add another credit card in Shipping Labels Payments screen

view details

Paolo Musolino

commit sha fb26110057da63ff14586737d310ffa54f96b320

fix: managed the case when there are no payments methods in Shipping Labels

view details

Paolo Musolino

commit sha a5416f29071d40271f486e7410b8bd6cede574ed

feat: started the implementation of `AuthenticatedWebView` in SwiftUI for opening a WPCom session

view details

Paolo Musolino

commit sha bbd5f99f865dba716e6d231021d899b255841248

feat: showAddPaymentWebView action

view details

Paolo Musolino

commit sha 4069f4c5d7e41aae8ba1f4a1e81c97e064cbbdc9

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels # Conflicts: # WooCommerce/WooCommerce.xcodeproj/project.pbxproj

view details

Paolo Musolino

commit sha 5faca9484644e60843ec1b843d812bae6bdf1600

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels # Conflicts: # WooCommerce/Classes/ViewRelated/Orders/Order Details/Shipping Labels/Create Shipping Label Form/Payment Methods/ShippingLabelPaymentMethods.swift

view details

Paolo Musolino

commit sha 9fd8f243980405fd101b2f7544d89b3e6c7d1daf

feat: split webview as separate view in payment methods

view details

Paolo Musolino

commit sha d18c74013c549f43d933f1656bf1f4b88b1b28d6

feat: implemented AuthenticatedWebViewDelegate

view details

Paolo Musolino

commit sha e0df54badc6ecfdafa77ce446083496714f18d52

fix: removed comments

view details

Paolo Musolino

commit sha ebcf1eed9d5e3c2069a08a35f469fbdac0c655e9

feat: handled navigation in AuthenticatedWebView

view details

Paolo Musolino

commit sha 49556c679737fbe329250a1d8ccae1c5b7fe0834

feat: cookie set in debug for AuthenticatedWebView

view details

Paolo Musolino

commit sha 87e57a6f41df5c8b6d43d19debfbc4acee0226e6

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels

view details

Paolo Musolino

commit sha 533ea27cd2fc9f949b5ce899a943a9d6c81d02fa

feat: final configuration for testing the authenticated web view in a sandbox environment

view details

Paolo Musolino

commit sha 53012e82a9b9573939b7707bc6993c06bd3aeb24

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels

view details

Paolo Musolino

commit sha 43cad0d2e392b9601b12e39021bedbbda2eb597b

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels

view details

Paolo Musolino

commit sha 0015712e44183ef53b734662ca198a1525a7ed92

Merge branch 'develop' into issue/4598-add-payment-method-in-shipping-labels

view details

Paolo Musolino

commit sha 34f5c3c475bed65fe59162c2554184e4a2f34c70

fix: exit url path that will trigger the exit from the webview in shipping label add new payment method

view details

Paolo Musolino

commit sha 1a3529dec7d3842cbbd7384c596edfff87425573

feat: clean code

view details

Paolo Musolino

commit sha ba2718eda1905690ce272cede3c4e794aedd13ff

fix: space

view details

Paolo Musolino

commit sha 85662427fbfba685c73607b74f03356373f132c3

feat: re-sync account settings when adding a new payment method

view details

push time in 2 days

issue closedwoocommerce/woocommerce-ios

Add payment methods in Shipping Labels

We need to allow shop owners to add new payment methods.

Make sure to follow the release order: #4595

Feel free to split this issue into more subtasks.

Tasks:

  • [x] Implement the button "Add another credit card". It should become "Add credit card" if there are no existing credit cards.
  • [x] Only show Add Payment Button if the current user is the store owner.
  • [x] We should open a web view that points to https://wordpress.com/me/purchases/add-credit-card since this functionality is not supported by API at the moment. Related PR on Android https://github.com/woocommerce/woocommerce-android/pull/4234
  • [x] Tracks events
  • [x] Display a notice Payment method added when a new payment method was added.

Before releasing this functionality, we should make sure those two PRs are merged: https://github.com/Automattic/wp-calypso/pull/54181 & https://github.com/Automattic/wp-calypso/pull/54189

Schermata 2021-07-13 alle 15 49 27

closed time in 2 days

pmusolino

delete branch woocommerce/woocommerce-ios

delete branch : issue/4598-add-payment-method-in-shipping-labels

delete time in 2 days

PR merged woocommerce/woocommerce-ios

Shipping Labels: add a new payment method type: task feature: shipping labels

Closes #4598

Description

This PR adds support for adding new payment methods from the app in the Shipping Labels. The implementation relies on a WebView that opens the URL https://wordpress.com/me/purchases/add-payment-method, using a new SwiftUI component called AuthenticatedWebView that handles authenticating the user to their WordPress.com automatically.

Testing

Important testing notes:

  1. During the implementation of this functionality, I discovered that the 2-factor authentication is always shown. This happens only if you are under the Automattic Proxy. So, for testing this PR I suggest you disable the proxy on your Mac. More info here: pMz3w-bAI#comment-80199
  2. For configuring your sandbox environment on the app, you should search for Store Sandbox Cookie Secret from the Secret Store, and put it under AuthenticatedWebView, substituting the string [secret]. Otherwise, you will not be able to test it with a fake credit card.
  3. You can use one of the fake credit cards included in the post called Testing the Store under the Field Guide.

Case 1: Add another payment method

  1. Make sure your WordPress.com account has some payment methods.
  2. Open an order eligible for shipping label creation.
  3. Click on Create shipping label.
  4. Pass all steps until you reach the payment step.
  5. Click on edit.
  6. Click on Add another credit card.
  7. Make sure the event shipping_label_add_payment_method_tapped was fired correctly in the console log.
  8. Enter the card details and save.
  9. Notice that the webview will be closed.
  10. Notice that the "payment method" screen will get refreshed with the new payment method.
  11. Make sure the event shipping_label_payment_method_added was fired correctly in the console log.
  12. Select the new payment method.
  13. Click on done.

Case 2: Add first payment method

  1. Delete all credit cards from your WordPress.com account.
  2. Open an order eligible for shipping label creation.
  3. Click on Create shipping label.
  4. Pass all steps until you reach the payment step.
  5. Click on Continue.
  6. Notice the placement of "Add a credit card" button.
  7. Click on "Add a credit card".
  8. Make sure the event shipping_label_add_payment_method_tapped was fired correctly in the console log.
  9. Enter the card details and save.
  10. Notice that the webview will be closed.
  11. Notice that the "payment method" screen will get refreshed with the new payment method.
  12. Make sure the event shipping_label_payment_method_added was fired correctly in the console log.
  13. Click on done.

Screenshots

Add another credit card button WebView
Simulator Screen Shot - iPhone 13 Pro - 2021-09-20 at 16 41 22 Simulator Screen Shot - iPhone 13 Pro - 2021-09-20 at 16 43 13

Update release notes:

  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
+267 -13

5 comments

9 changed files

pmusolino

pr closed time in 2 days

push eventwoocommerce/woocommerce-ios

Paolo Musolino

commit sha f65d240c1fb474b805de1f8c5a7ec87c1a5f57c2

fix: localized string

view details

push time in 2 days

pull request commentwoocommerce/woocommerce-ios

Shipping Labels: add a new payment method

Thank you @itsmeichigo for your second review!

Most of your suggestions to make an improvement make sense to me. Just to not block this PR and since they can be implemented later, I created a new issue here to track them: https://github.com/woocommerce/woocommerce-ios/issues/5037

It looks like the web view does not look good in landscape mode when the keyboard is showing. I don't really have a good suggestion to get around this though.

It would be interesting, but I think that even if the view was native here, we could hardly find a way to improve the user experience. The height of the screen is occupied more by the keyboard, and there is no way to make it smaller. The same problem exists also in Safari, but also in our native views with forms in landscape.

pmusolino

comment created time in 2 days

issue openedwoocommerce/woocommerce-ios

Shipping Labels: improvements to add a new payment method

As suggested by @itsmeichigo here https://github.com/woocommerce/woocommerce-ios/pull/5023 it would be great to have some enhancement (especially on the UI side) on the add a new payment method in the Shipping Label.

  • [ ] In portrait mode the empty view does not stay at the center of the screen. I think it's worth it to consider the optional scroll view introduced in #5009 or the ScrollableVStack mentioned in that discussion (just a suggestion, should be tested). <img src="https://user-images.githubusercontent.com/5533851/134277555-2a68921f-5913-4819-80d5-050f3c4d371c.png" width=350 />

  • [ ] Should we show a loading view when syncing user account? That way we can avoid showing the empty view if it takes a while to load new data: https://user-images.githubusercontent.com/5533851/134277722-1b87d210-fa22-4fe9-be72-64ee9c782a8c.mp4

  • [ ] It would be great to select the newly added payment method as the selected method automatically. Currently it seems that the old method is still selected, I think it'd be nice if the new one gets selected instead.

  • [ ] Is it necessary to disable Done button when payment method is not updated? In the case when I have no payment method, after adding a card the card is selected automatically and the Done button is disabled. I was so confused and thought something was wrong 😅. My suggestion is that we only disable the Done button when there's no method to choose from.

created time in 2 days

Pull request review commentwoocommerce/woocommerce-ios

Shipping Labels: add a new payment method

 private extension ShippingLabelPaymentMethods {                                 + " %1$@ is a placeholder for the account display name."                                 + " %2$@ is a placeholder for the username."                                 + " %3$@ is a placeholder for the WordPress.com email address.")+        static let addCreditCardButton = NSLocalizedString("Add credit card",+                                                           comment: "Button title in the Shipping Label Payment Method screen")+        static let addAnotherCreditCardButton = NSLocalizedString("Add another credit card",+                                                                  comment: "Button title in the Shipping Label Payment Method" ++                                                                    " screen if there is an existing payment method")+        static let paymentMethodWebviewTitle = NSLocalizedString("Payment method",+                                                            comment: "Title of the webview of adding a payment method in Shipping Labels")+        static let doneButtonAddPayment = NSLocalizedString("Done",+                                                            comment: "Done navigation button in Shipping Label add payment webview")+        static let paymentMethodAddedNotice = NSLocalizedString("Payment method added",+                                                                comment: "Notice that will be displayed after adding a new Shipping Label payment method")+        static let pleaseAddPaymentMethodMessage = NSLocalizedString("Please, add a new payment method",

I'll do that in this PR before merging it 👍

pmusolino

comment created time in 2 days

PullRequestReviewEvent

pull request commentwoocommerce/woocommerce-ios

Enable push notifications for all stores behind a feature flag

Thanks for opening this PR @jaclync! Before reviewing this PR, I need to request a new sandbox environment (the old one is was closed), just give me the time to have it enabled 😃

jaclync

comment created time in 2 days

issue closedwoocommerce/woocommerce-ios

Shipping Labels: Address validation issues

Currently address validation on Edit Address screen is having several issues:

  • Phone validation is checking for US phone number requirement regardless of the selected country. Other countries should not be applied the same check with US.
  • Validation errors require tapping on action buttons to be cleared. Local validation should be handled on value changes instead.
  • When switching country, state field is empty but the address's state is not actually updated. So when switching from US to Australia, new state is required but tapping on "Use Address as Entered" allows the address to keep the US state.

Internal reference: p5T066-2En-p2#comment-9902

closed time in 2 days

itsmeichigo

issue commentwoocommerce/woocommerce-ios

Shipping Labels: Address validation issues

I'm closing this issue since it was fixed in release 7.5.

itsmeichigo

comment created time in 2 days

push eventwoocommerce/woocommerce-ios

Paolo Musolino

commit sha cc6cebccac50e2e67b8ee8d389c81d83e2f789a3

update: RELEASE-NOTES

view details

push time in 2 days

PR opened woocommerce/woocommerce-ios

Reviewers
Select default value for paper size in Shipping Label print screen type: enhancement feature: shipping labels

Fixes #5014

On Print Shipping Label screen, no paper size is selected by default and the Print button is disabled. There is no emphasis that the paper size should be selected for the Print button to be enabled, so this is not good in terms of discoverability. In this PR I fixed this behavior, selecting a default value for paper size. This also matches with the behavior on Android.

Testing

  1. Make sure your test store has WCShip plugin installed and set up packages for shipping in WPAdmin > WooCommerce > Settings > Shipping.
  2. Select an order eligible for creating shipping label and select Create Shipping Label.
  3. Proceed through the form to purchase a label.
  4. After purchase succeeds, notice that you've navigated to Print Shipping Label screen, and the Print button is enabled with a paper size selected.

<img src="https://user-images.githubusercontent.com/495617/134344335-a2f7d664-2396-4d74-88e2-4a4255eca189.png" width=300 />

Update release notes:

  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.
+3 -0

0 comment

1 changed file

pr created time in 2 days

Pull request review commentwoocommerce/woocommerce-ios

Shipping Labels: Add Move button and action sheet for moving order items to different package

 final class ShippingLabelPackagesFormViewModel: ObservableObject {         selectedPackages.count > 1     } +    /// Message displayed on the Move Item action sheet.+    ///+    @Published private(set) var moveItemActionSheetMessage: String = ""

Q: Why not using an optional string here? Also if it needs to be unwrapped, it's more clear in my opinion.

itsmeichigo

comment created time in 2 days

PullRequestReviewEvent