profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/ploxiln/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

ploxiln/fab-classic 48

Simple, Pythonic remote execution - Fork of Fabric 1.x

ploxiln/mawk-2 12

Mike Brennan's new development of his original "mawk" - https://github.com/mikebrennan000/mawk-2

jayridge/rtsprelay 9

RTSP Relay Server

ploxiln/docker-memcached 3

mini docker image for running memcached

ploxiln/ctags 1

Universal Ctags, but with releases

ploxiln/dablooms 1

scaling, counting, bloom filter library

ploxiln/http-parser 1

http-parser fork adding RTSP support

ploxiln/carbon 0

Carbon is one of the components of Graphite, and is responsible for receiving metrics over the network and writing them down to disk using a storage backend.

ploxiln/cerbero 0

Cerbero build system used to build the official upstream GStreamer 1.0 SDK binaries

ploxiln/count-digits 0

a humble experiment

pull request commentnsqio/nsq

nsqd: update go-diskqueue to v1.1.0

squashed once more, ready to go

ploxiln

comment created time in a day

push eventploxiln/nsq

Pierce Lopez

commit sha 60ae5badfa37c88f23026b1fd89540b9974c7262

nsqd: update dependencies go-nsq v1.1.0 go-diskqueue v1.1.0 golang/snappy v0.0.4 BurntSushi/toml v0.4.1

view details

Pierce Lopez

commit sha e6b949db33785f518e05ee44ff7f28230c5832b5

nsqlookupd: less flaky protocol test NSQLookupd.New() listens on TCPAddress and HTTPAddress, which NewOptions() gives default values of 4160 and 4161, and sometimes this conflicts with other tests running concurrently.

view details

push time in a day

push eventploxiln/nsq

Pierce Lopez

commit sha d73ae481ad057739b7d4a3df042fa787041c0f0b

update toml dependency this is the last of the updatable dependencies, they're all updated

view details

push time in a day

push eventploxiln/nsq

Pierce Lopez

commit sha 7f8a4dd0ff88d586bb1484c4422699aaa2331dab

update go-nsq to v1.1.0 also update snappy to v0.0.4

view details

push time in a day

issue commentnsqio/pynsq

Client configured with deflate=true loses connection on Tornado 6

This may be because the DeflateSocket recv_into() method is a bit hacky, and may stash additional data for the next read, while the raw underlying socket has been fully read and does not indicate readyness for the ioloop.

https://github.com/nsqio/pynsq/pull/232/files#diff-f72976af2d2f01c6df1f82088ee1ef75b85384a2da757593fd505bdc25306758R27-R36

ayamnikovx

comment created time in a day

pull request commentnsqio/nsq

nsqd: update go-diskqueue to v1.1.0

I think you're supposed to ensure all WaitGroup.Add() is strictly before WaitGroup.Wait()

ploxiln

comment created time in a day

Pull request review commentnsqio/nsq

nsqd: update go-diskqueue to v1.1.0

 func testIOLoopReturnsClientErr(t *testing.T, fakeConn test.FakeNetConn) { 	opts := NewOptions() 	opts.Logger = test.NewTestLogger(t) 	opts.LogLevel = LOG_DEBUG+	opts.TCPAddress = "127.0.0.1:0"+	opts.HTTPAddress = "127.0.0.1:0"

ah, I see. there's also bootstrapNSQCluster() which also does :0 for listening addresses

ploxiln

comment created time in a day

PullRequestReviewEvent

pull request commentnsqio/nsq

nsqd: update go-diskqueue to v1.1.0

Updated, squashed a bit.

The race detector caught another unrelated thing (under go-1.14) but a re-test alleviated the problem for now

WARNING: DATA RACE
Write at 0x00c000303d20 by goroutine 135:
  internal/race.Write()
      /usr/local/go/src/internal/race/race.go:41 +0x114
  sync.(*WaitGroup).Wait()
      /usr/local/go/src/sync/waitgroup.go:128 +0x115
  github.com/nsqio/nsq/nsqd.(*NSQD).Exit()
      /__w/nsq/nsq/go/src/github.com/nsqio/nsq/nsqd/nsqd.go:451 +0x364
  github.com/nsqio/nsq/nsqd.TestEmptyCommand()
      /__w/nsq/nsq/go/src/github.com/nsqio/nsq/nsqd/protocol_v2_test.go:447 +0x31d
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1050 +0x1eb

Previous read at 0x00c000303d20 by goroutine 94:
  internal/race.Read()
      /usr/local/go/src/internal/race/race.go:37 +0x1e8
  sync.(*WaitGroup).Add()
      /usr/local/go/src/sync/waitgroup.go:71 +0x1fb
  github.com/nsqio/nsq/internal/util.(*WaitGroupWrapper).Wrap()
      /__w/nsq/nsq/go/src/github.com/nsqio/nsq/internal/util/wait_group_wrapper.go:12 +0x43
  github.com/nsqio/nsq/nsqd.(*NSQD).Main()
      /__w/nsq/nsq/go/src/github.com/nsqio/nsq/nsqd/nsqd.go:253 +0x241
  github.com/nsqio/nsq/nsqd.mustStartNSQD.func1()
      /__w/nsq/nsq/go/src/github.com/nsqio/nsq/nsqd/protocol_v2_test.go:49 +0x38

Goroutine 135 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1095 +0x537
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:1339 +0xa6
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1050 +0x1eb
  testing.runTests()
      /usr/local/go/src/testing/testing.go:1337 +0x594
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:1252 +0x2ff
  main.main()
      _testmain.go:286 +0x223

Goroutine 94 (running) created at:
  github.com/nsqio/nsq/nsqd.mustStartNSQD()
      /__w/nsq/nsq/go/src/github.com/nsqio/nsq/nsqd/protocol_v2_test.go:48 +0x171
  github.com/nsqio/nsq/nsqd.TestEmptyCommand()
      /__w/nsq/nsq/go/src/github.com/nsqio/nsq/nsqd/protocol_v2_test.go:435 +0x126
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1050 +0x1eb
==================
--- FAIL: TestEmptyCommand (0.00s)
    logger.go:16: INFO: nsqd v1.2.1 (built w/go1.14.15)
    logger.go:16: INFO: ID: 581
    logger.go:16: INFO: NSQ: persisting topic/channel metadata to /tmp/nsq-test-274671300/nsqd.dat
    logger.go:16: INFO: NSQ: closing topics
    logger.go:16: INFO: NSQ: stopping subsystems
    logger.go:16: INFO: LOOKUP: closing
    logger.go:16: INFO: QUEUESCAN: closing
    logger.go:16: INFO: HTTP: listening on 127.0.0.1:45063
    logger.go:16: INFO: HTTP: closing 127.0.0.1:45063
    logger.go:16: INFO: TCP: listening on 127.0.0.1:34935
    logger.go:16: INFO: TCP: closing 127.0.0.1:34935
    logger.go:16: INFO: NSQ: bye
    testing.go:965: race detected during execution of test
ploxiln

comment created time in a day

push eventploxiln/nsq

Pierce Lopez

commit sha f9a14223c84946453860b710e76e5c8fbd0e1453

nsqd: update go-diskqueue to v1.1.0 and go mod tidy

view details

Pierce Lopez

commit sha 5ad79d14c9669d4c6c6010c1ed9213de40f7a8d3

nsqlookupd: less flaky protocol test NSQLookupd.New() listens on TCPAddress and HTTPAddress, which NewOptions() gives default values of 4160 and 4161, and sometimes this conflicts with other tests running concurrently.

view details

push time in a day

push eventploxiln/nsq

Pierce Lopez

commit sha e4ecc3580ee092386e145935fb0843985c7e4f6e

nsqlookupd: less flaky protocol test NSQLookupd.New() listens on TCPAddress and HTTPAddress, which NewOptions() gives default values of 4160 and 4161, and sometimes this conflicts with other tests running concurrently.

view details

push time in a day

push eventploxiln/go-nsq

Pierce Lopez

commit sha 9205a845e60c0a41caedbd967c9458199a1b282e

bump version to 1.1.0 and update ChangeLog

view details

Matt Reiferson

commit sha 259dc590b2e791e4b11ad7496bc312ec81d1004b

Merge pull request #340 from ploxiln/bump_110 bump version to 1.1.0 and update ChangeLog

view details

push time in a day

Pull request review commentnsqio/nsq

nsqd: update go-diskqueue to v1.1.0

 func testIOLoopReturnsClientErr(t *testing.T, fakeConn test.FakeNetConn) { 	opts := NewOptions() 	opts.Logger = test.NewTestLogger(t) 	opts.LogLevel = LOG_DEBUG+	opts.TCPAddress = "127.0.0.1:14163" // avoid possible conflict with other tests+	opts.HTTPAddress = "127.0.0.1:14164"

this started happening persistently, though just for the go-1.17 test run:

--- FAIL: TestIOLoopReturnsClientErrWhenSendSucceeds (0.00s)
    logger.go:16: INFO: nsqlookupd v1.2.1 (built w/go1.17.2)
    assertions.go:31: lookup_protocol_v1_test.go:40:
        
        	   <nil> (expected)
        
        	!= &errors.errorString{s:"listen (0.0.0.0:4161) failed - listen tcp 0.0.0.0:4161: bind: address already in use"} (actual)

The default ports of 4160/4161 were being used.

does it not handle the :0 "random free port"?

Somehow I had forgotten about that old common unix feature ... will update to do that

ploxiln

comment created time in a day

PullRequestReviewEvent

release nsqio/go-nsq

v1.1.0

released time in a day

created tagnsqio/go-nsq

tagv1.1.0

The official Go package for NSQ

created time in a day

pull request commentnsqio/go-nsq

bump version to 1.1.0 and update ChangeLog

I'll go ahead and push up the tag now

ploxiln

comment created time in a day

issue commentparamiko/paramiko

Paramiko not working with Openssh 8.8p1

This is probably because you are using an RSA key to authenticate. OpenSSH-8.8 disables support for RSA keys/signatures using SHA-1 hash by default. Paramiko does not yet support RSA keys/signatures using SHA-2 hashes. You'll need something like https://github.com/paramiko/paramiko/pull/1643 and probably some additional tweaks. Or, use an ECDSA or ED25519 key instead.

flavius

comment created time in 2 days

pull request commentnsqio/nsq

nsqd: update go-diskqueue to v1.1.0

I tried putting the lowest supported go version in go.mod, but the result was:

nsqadmin/static.go:10:3: go:embed requires go1.16 or later (-lang was set to go1.14; check go.mod)

(declaring "go 1.16" seems to work fine with previous versions anyway, and "go 1.17" also worked fine I guess ...)

ploxiln

comment created time in 2 days

push eventploxiln/nsq

Pierce Lopez

commit sha 759b129045652140bc47868a5cc5b54f21759c21

nsqlookupd: less flaky protocol test NSQLookupd.New() listens on Options.TCPAddress and Options.HTTPAddress and sometimes multiple tests are doing this at the same time

view details

push time in 2 days

push eventploxiln/nsq

Pierce Lopez

commit sha 7ae8eb0f941ae8a0eb2e96817e56c1b651b6f73a

go mod tidy

view details

push time in 2 days

PR opened nsqio/nsq

Reviewers
nsqd: update go-diskqueue to v1.1.0
+3 -1

0 comment

2 changed files

pr created time in 2 days

create barnchploxiln/nsq

branch : diskqueue_110

created branch time in 2 days

push eventploxiln/nsq

Péter Szilágyi

commit sha 3fa175cb899a47bf64c1b69f35f4bea4d7ebae81

nsqd: enable support for TLS1.3 Currently NSQD is capped at TLS1.2. TLS1.3 has been stabilized since Go 1.14, released almost 2 years ago. Might as well bump it.

view details

Péter Szilágyi

commit sha 2c2c2a2990783d01d254816b35681e6f95856d5f

nsqd: allow disable both HTTP and HTTPS interfaces NSQD by defaults opens both the HTTP and well as the HTTPS interface by default (if TLS is set). This is fine as a default behavior, but it's valuable to be able to disable one interface or another to raise the security guarantees (e.g. if TCP is enough, there is no reason to keep 2 more ports open just to have to lock them down in some other way). This commits allows disabling the HTTP interface the same way the HTTPS one could be disabled until now (set it to ""). In addition, it makes a few code cleanups.

view details

Pierce Lopez

commit sha 427d89391b822d542c04b72effb541d5175818d3

Merge pull request #1385 from karalabe/support-tls13 nsqd: enable support for TLS1.3

view details

Pierce Lopez

commit sha 802306e80cae7ab93a5f771a24810dc6f8a1268b

Merge pull request #1384 from karalabe/disable-http nsqd: allow disable both HTTP and HTTPS interfaces

view details

push time in 2 days

PR opened nsqio/go-nsq

Reviewers
bump version to 1.1.0 and update ChangeLog

I bumped to 1.1.0 because it's been a while, and there are a couple API additions:

  • SetLoggerLevel() and SetLoggerForLevel() in #275
  • Config.LookupdPollTimeout and SetLookupdHttpClient() in #333

ChangeLog is roughly chronological but with docs/cosmetic/project stuff moved to the end.

+29 -1

0 comment

2 changed files

pr created time in 2 days

push eventploxiln/go-nsq

Pierce Lopez

commit sha 9205a845e60c0a41caedbd967c9458199a1b282e

bump version to 1.1.0 and update ChangeLog

view details

push time in 2 days

create barnchploxiln/go-nsq

branch : bump_110

created branch time in 2 days

push eventploxiln/go-nsq

Péter Szilágyi

commit sha c4f8b83b818cb7fad89dd46ba3d4745e3bea7f93

producer: fix shutdown logs to be uniform with others

view details

Pierce Lopez

commit sha 54583b581cf3a568a114d37ea9e0e172e9f7ed2a

Merge pull request #336 from karalabe/producer-log-tagging producer: fix shutdown logs to be uniform with others

view details

push time in 2 days

issue closednsqio/go-nsq

the tag of v1.0.8, and the file of doc.go line 65, the value name p is error, in fact, it is producer.

the tag of v1.0.8, and the file of doc.go line 65, the value name p is error, in fact, it is producer.

closed time in 2 days

weirubo

issue commentnsqio/go-nsq

the tag of v1.0.8, and the file of doc.go line 65, the value name p is error, in fact, it is producer.

fixed in https://github.com/nsqio/go-nsq/pull/294 (just awaiting another release tag)

weirubo

comment created time in 2 days