profile
viewpoint

pkaminski/digest-hud 112

Digest performance analysis HUD for AngularJS.

pkaminski/firebase-http-server 12

a simple zero-configuration command-line http server

pkaminski/firebase-on-error 8

Adds onError and onSlowWrite to Firebase, and helps debug permission errors.

pkaminski/fireworker 5

Firebase in a web worker

pkaminski/altfire 3

Alternative AngularJS bindings for Firebase

pkaminski/fireband 1

Firebase bandwidth analyzer

pkaminski/fix-firebase-transaction 1

Monkeypatch some broken semantics of Firebase transactions

push eventReviewable/Reviewable

Piotr Kaminski

commit sha d745bdc29ce662a0e7e03bdf878f4aec72984a3b

Update changelog.md

view details

push time in 5 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 2c6c4b4454edc6389ea4313e6a1b6e456ba7bc46

Update changelog.md

view details

push time in 7 days

issue commentReviewable/Reviewable

Option: do not consider base commit changes as worth reviewing

Yeah, fair enough. I added author and committer info to the condition input structure. It will only be present when GitHub has successfully mapped these users to GitHub accounts (which should always be the case for you, I believe), and will only be present for revisions captured going forward (no backfill).

misha-ridge

comment created time in 12 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha ea7ac4a7bdea684304a7be70663db08d963907c1

Update changelog.md

view details

push time in 13 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha df87efe8b86c5ac2654d18b77f1250c7811aa42a

Update changelog.md

view details

push time in 13 days

issue commentReviewable/Reviewable

Option: do not consider base commit changes as worth reviewing

The "API" is the review completion condition, where you can mark any given file-revision as reviewed (or not). Do you have enough information in there to make the marks you want? If not, could the bot set some label to indicate that the latest commits are no-ops perhaps, that you could then key off in the condition?

misha-ridge

comment created time in 14 days

issue closedReviewable/Reviewable

Option: do not consider base commit changes as worth reviewing

Our project has a workflow with PRs being merged only if they are up-to-date with master, have been reviewed and pass tests.

However it results in the following situation:

  • A review is performed and CI is finished successfully.
  • A bot kicks in that brings PR up-to-date with master. This causes some files to be marked in Reviewable as unreviewed due to "base commit changes". CI still passes.
  • The PR now waits for additional manual review. However in practice this review is perfunctory, as we rely on CI to ensure nothing breaks.

Would it be possible to optionally do not consider "base commit changes"—and only them—as significant?

closed time in 14 days

misha-ridge

issue commentReviewable/Reviewable

Option: do not consider base commit changes as worth reviewing

This is unfortunately impossible, as Reviewable only computes diffs on the client and a "this revision is superfluous" decision would need to be taken on the server. This is an early architectural decision that it is far too late to go back on.

BTW, I think #622 is adjacent to your request, but that one is feasible since the comparison the server needs to make is at the SHA level rather than an actual (three-way) diff.

misha-ridge

comment created time in 14 days

created tagReviewable/hubkit

tag2.0.4

GitHub API library for JavaScript, promise-based, for both Node and the browser.

created time in 14 days

push eventReviewable/hubkit

Bogdan Muranets

commit sha f7097bea6f30f578d0122a34f9df6fe652715cf9

avoid axios transformResponse for 'raw' media (#10) * avoid axios transformResponse for 'raw' media

view details

push time in 14 days

issue closedReviewable/Reviewable

Reviews button in the top bar is broken

Recent regression.

Expected: Reviewable button in the top bar on a review page links to My Reviews Actual: the button links to the current review itself

closed time in 15 days

feldgendler

issue commentReviewable/Reviewable

Reviews button in the top bar is broken

This should be fixed as of a week ago.

feldgendler

comment created time in 15 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha f0ece179c1dbecbb13f1eb79b4a626c714aed284

Update changelog.md

view details

push time in 15 days

push eventReviewable/firecrypt

Piotr Kaminski

commit sha 2125ed6f8e7039d51681261f862201c7412ad92b

Update dependency declarations.

view details

push time in 19 days

created tagReviewable/firecrypt

tag2.0.8

Transparent at-rest AES encryption for Firebase.

created time in 19 days

created tagReviewable/firetruss-worker

tag2.0.2

Web worker component for pkaminski/firetruss

created time in 19 days

push eventReviewable/firetruss-worker

Piotr Kaminski

commit sha 25fcbc45b1bddd6d176071a2764fbc965735d989

Update moved dependencies.

view details

Piotr Kaminski

commit sha 6d99b3ceb89727f573205c155b1c01e2bcf86ae8

Declare compatibility with more recent versions of the Firebase SDK.

view details

Piotr Kaminski

commit sha ebea7749a38af09b9c2c6d315762ed6f094db5c6

release 2.0.2

view details

push time in 19 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha ca1029960aeff21ca5e0abe5dccda7b701e36094

Update changelog.md

view details

push time in 19 days

push eventReviewable/hubkit

Piotr Kaminski

commit sha 9a1c48dc86c7c39b3143d201ed35dc1359e94e0f

Support paginating through files property (used when fetching a commit).

view details

push time in 19 days

created tagReviewable/hubkit

tag2.0.3

GitHub API library for JavaScript, promise-based, for both Node and the browser.

created time in 19 days

push eventReviewable/firecrypt

Piotr Kaminski

commit sha c9c37fb9158c52c8b0362ea4d50d034a89e905c1

Tweak format of dependency version spec in case it matters.

view details

push time in 19 days

push eventReviewable/nodefire

Piotr Kaminski

commit sha a0f8e0693628c3cb687418c5a38d61c6a5c21f01

Bump supported versions of firebase-admin.

view details

push time in 19 days

push eventReviewable/firefight

Piotr Kaminski

commit sha 46c4787a26c2d954e51116667d5c2967795effa7

Bump supported firebase-admin versions.

view details

push time in 19 days

push eventReviewable/firebase-childrenkeys

Piotr Kaminski

commit sha f9697cf78eceb2094d2869c8021384033fa2c600

Bump firebase-admin supported versions.

view details

push time in 19 days

push eventReviewable/hubkit

Piotr Kaminski

commit sha f24463f0add403267c483d7e0873500f7142e386

Capture response headers in errors correctly. Capture more information about failed multi-page requests.

view details

push time in 19 days

created tagReviewable/hubkit

tag2.0.2

GitHub API library for JavaScript, promise-based, for both Node and the browser.

created time in 19 days

PR opened MidLevel/MLAPI

Reviewers
feat(lag): add method to simulate a subset of tracked objects.
+17 -6

0 comment

1 changed file

pr created time in 19 days

create barnchpkaminski/MLAPI

branch : simulation

created branch time in 19 days

PR opened MidLevel/MLAPI

Reviewers
fix(core): don't smear network time adjustment on initial connection sync.

We need to hard-reset the network time offset every time the client connects, since there's no guarantee that it's connecting to the same server or that the server hasn't restarted. This PR forces a hard sync on connection approval, but retains smearing of any adjustments while the connection remains up.

+3 -8

0 comment

1 changed file

pr created time in 19 days

create barnchpkaminski/MLAPI

branch : reset-time-sync

created branch time in 19 days

push eventpkaminski/MLAPI

GarethPikPok

commit sha 28e1436733bdddbbd5e7d2579948dc6056f8e924

perf: Prioritize non-weak streams over weak referenced streams. (#304) If we prioritize pulling from the overflow streams (as it was before), it's possible for us to retain the weak references for a lot longer than is desirable as we will keep accessing them. It's therefore preferable to return a stream from the normal queue to allow the GC time to clean the weak references, and only return an overflow value if there is no other option.

view details

Albin Corén

commit sha bb6b8c8761a6afdd43e2e8c1f3dea0a8a0826317

ci: Upgraded node version to 12

view details

Albin Corén

commit sha f3cff31e8e874bf79528b6850a3af19a9ef4ef2e

ci: Added npm installation script

view details

Albin Corén

commit sha cb2b911fa6f18d2439923669a268ab4e905a9ec4

ci: Fixed install script not running

view details

push time in 19 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 83a8a04f60f18b50f61046c88ce0515451c462cf

Update changelog.md

view details

push time in 19 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 0b89f6443c6d8740e493a3bef94d4d5b14db2274

Update changelog.md

view details

push time in 19 days

PR closed MidLevel/MLAPI

Reviewers
feat(core): pass NetworkedBehaviour instance into custom netvar permission callbacks

@TwoTenPvP, as discussed in chat.

<!-- Reviewable:start -->

This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+95 -110

3 comments

9 changed files

pkaminski

pr closed time in 19 days

pull request commentMidLevel/MLAPI

feat(core): pass NetworkedBehaviour instance into custom netvar permission callbacks

I messed up my branches so I'm moving this PR to #312 instead.

pkaminski

comment created time in 19 days

PR opened MidLevel/MLAPI

Reviewers
feat(core): pass NetworkedVar instance into custom permission callbacks

Also switch INetworkedVar to an abstract NetworkedVarBase class.

+95 -110

0 comment

9 changed files

pr created time in 19 days

create barnchpkaminski/MLAPI

branch : permission-callbacks

created branch time in 19 days

push eventpkaminski/MLAPI

Piotr Kaminski

commit sha f070aa69beedef1b2be26e3fc62d4fc5dda3e8eb

Switch to an abstract netvar class and pass it to permission callbacks instead.

view details

push time in 20 days

push eventReviewable/hubkit

Bogdan Muranets

commit sha 308535a08d973a23ee86a877a5a8d13834356328

correct nocache comment (#8) * correct nocache comment

view details

push time in 21 days

PR merged Reviewable/hubkit

correct nocache comment

<!-- Reviewable:start --> This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+2 -4

0 comment

1 changed file

badz0

pr closed time in 21 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 32b74b4c93b2a881ade1ac241209348752408009

Update changelog.md

view details

push time in 22 days

created tagReviewable/hubkit

tag2.0.1

GitHub API library for JavaScript, promise-based, for both Node and the browser.

created time in 22 days

push eventReviewable/hubkit

Bogdan Muranets

commit sha 90cfb1e1f1ba6ead1ae6c09118e35c4281abf2eb

remove access_token from query, fix raw media check condition (#7) * remove access_token from query, fix raw media check condition

view details

push time in 22 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha d618b4a394668fa0b007d359faff5b33a88dd2a0

Update changelog.md

view details

push time in 22 days

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 42397768f1b103b9f5a84a29582160d92b65b130

Update changelog.md

view details

push time in 23 days

created tagReviewable/hubkit

tag2.0.0

GitHub API library for JavaScript, promise-based, for both Node and the browser.

created time in 25 days

push eventReviewable/hubkit

Bogdan Muranets

commit sha 023acda459e6f7bfba656442a41240ef8c37df7a

move to axios (#6) * move to axios * review fixes

view details

push time in 25 days

PR merged Reviewable/hubkit

move to axios

<!-- Reviewable:start --> This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+138 -213

0 comment

5 changed files

badz0

pr closed time in 25 days

issue commentReviewable/Reviewable

Reviews button in the top bar is broken

Thanks! @badz0 I think that beforeDestroy may be racing with openPullRequestUrl in dashboard.vue, could you take a look please?

feldgendler

comment created time in a month

issue closedReviewable/Reviewable

The difference between blocking and non-blocking comments is too subtle

I find it quite hard to notice the difference between blocking and non-blocking (disposition: discussing) comment threads in reviews while working on a PR: former has a "Resolve", latter has "Done" buttons, and that's all.

closed time in a month

misha-ridge

issue commentReviewable/Reviewable

The difference between blocking and non-blocking comments is too subtle

OK, let's merge this issue with #714 and continue the discussion there, as it's pretty much the same concern and I made more substantive comments there already. I'll reopen it if needed.

misha-ridge

comment created time in a month

issue commentReviewable/Reviewable

The difference between blocking and non-blocking comments is too subtle

You can always check by unrolling the participant dispositions widget (hover over the circle in the lower-right corner). However, I'm curious what workflow you're using where this distinction is important up front, rather than at the point where you're ready to resolve the issue (when the button label indicates what will happen)?

misha-ridge

comment created time in a month

issue commentReviewable/Reviewable

Italic and bold format bug

This is an issue in highlight.js, which Reviewable uses for rendering source code. I poked around a bit but couldn't see an obvious way to fix it, so I opened an issue over there and hopefully somebody will help out.

gaborvolczer

comment created time in a month

issue openedhighlightjs/highlight.js

Combined bold + italic styling doesn't work in Markdown mode

Observe how GitHub renders the following markdown:

  • _Italic_ or *Italic*: Italic
  • __Bold__ or **Bold**: Bold
  • *Is __Combined__*: Is Combined

In highlight.js 9.18.0, the last Combined word is only bolded but should also be italicized.

created time in a month

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 606d6557398856bf44764664e68c6cf642118547

Update changelog.md

view details

push time in a month

push eventpkaminski/sample

Piotr Kaminski

commit sha bf648b0a49918c1bd4635bda837cd1aa0bd299ce

Rollback test (#63) * Named function. * Rename to qux

view details

Piotr Kaminski

commit sha 76aa9b224d255821f80a72033d08c83d8c1d1fe0

Merge branch 'work' into pkaminski-patch-11

view details

push time in a month

issue closedReviewable/Reviewable

Suggestion: show reviewer's disposition more visibly

Hello!

I've been using Reviewable to perform code review in my CS courses, and I was planning on introducing next term the use of comment-level dispositions (Blocking/Discussing/Informing) to indicate to my students what issues they must fix, which they may fix if they want to, and what is merely an informational comment.

Our tutorial for code reviews on Reviewable explains about these three dispositions, and shows —together with appropriate explanations in Spanish— the three icons from Font Awesome that represent each of them.

What seems to happen —and I hadn't much realized before— is that the icon representing the disposition of the reviewer (in this case, me) is less visible than I would expect (or like?) once the PR authors (my students) open the pull request on Reviewable. In particular, it seems the bottom-right corner shows one's disposition by default (initially, for them, just Following), and the icon must be hovered over to show the reviewer's avatar and disposition. (This is something I hadn't paid much attention to on my own reviews, but became very noticeable when thinking on the workflow for my students.)

So, TL;DR: do you think it would make sense to display the disposition of a commenter (for a particular comment) in a more visible manner? Perhaps in the author's avatar on the left? I'm not sure whether it'd be too much to do it for every comment, but it seems useful to me at least for the opening comment in a thread (for the reasons explained above). Is there something that I missed? Is there an easier way to check a disposition for a particular thread that I'm not aware of?

Many thanks for considering! (or commenting).

P.S.: Alternatively, it just crossed my mind: if it's better not to touch the current UI (which I'd understand completely) is there or there could be an emoji-like shortcut that I could type to display the icon that represents a particular disposition? Without UI changes, I guess I could take the work to include the appropriate icon as the first thing in each comment. (Of course, in the absence of icons, I'd just use text, but having a way to show the exact same icons would yield a prettier result, that's all.) Thanks for reading!

closed time in a month

dato

issue commentReviewable/Reviewable

Suggestion: show reviewer's disposition more visibly

I definitely see where you're coming from but there are both philosophical and structural reasons why your suggestions won't work. Philosophically, whether a discussion is unresolved is supposed to be the ultimate indicator of whether the issue needs to be / has been addressed. I also believe that every comment deserves a reply (or at least an acknowledgement), which is why the discussion counter prioritizes counting unreplied discussions. Once all have replies pending, though, it switches to tracking unresolved ones -- which are also indicated by an icon in the top-left corner of the discussion UI.

Structurally, Reviewable doesn't track per-comment disposition but just the current one, so automatically displaying a per-comment indicator would require adjusting a lot of stuff. Also, it's possible to change one's disposition without writing a comment, in which case there would be nowhere to display the new icon. As for giving access to the FA icons via custom emojis, that could work and there is precedent with the :lgtm: emojis, but I consider those a failed experiment and would rather not entrench the idea further. (They make parsing and rendering messages much more complicated, can only be rendered in ugly raster formats rather than clean vector ones, and don't even consistently render in every outside context.)

Finally, I did give some thought to changing the bottom right corner disposition to showing a sort of "worst case" common denominator of all dispositions on the discussion. This would be more useful for the author, particularly in multi-party reviews. However, I think seeing your own disposition is much more useful for the reviewer and changing how the display works based on role would be very confusing (especially since it's possible to hold a dual author/reviewer role!).

All that said, I think your proposed workaround is the best you can do for your proposed workflow -- sorry. Closing as suggested.

dato

comment created time in a month

pull request commentMidLevel/MLAPI

feat(core): pass NetworkedBehaviour instance into custom netvar permission callbacks

Hey, so I didn't quite understand your comment in chat -- could you perhaps comment in the PR instead so with the right line context I can figure out what you mean? Thanks.

pkaminski

comment created time in a month

push eventReviewable/Reviewable

Piotr Kaminski

commit sha c2beb5a06c1df589259bb606ac33a4ff177e5d99

Update changelog.md

view details

push time in a month

IssuesEvent

issue commentReviewable/Reviewable

Missing reviewers synchronization on server-side actions

Yeah, I agree this is awkward. However, while I'm OK defaulting an easily visible checkbox to true, I don't want to default a very hidden setting to true (especially when this has historically been false). I think the right solution is to replace both the per-publish checkbox and the completion flag with a visible repo-level setting that takes the place of both (and removes control from individual reviewers).

I'll reopen this issue to track this but don't know when I'll have time to implement it.

feldgendler

comment created time in a month

issue commentReviewable/Reviewable

Suggestion: show reviewer's disposition more visibly

Hey there! So the way this is typically addressed -- in both Reviewable and other review systems -- is that there's a sort of de facto standard for wording comments. For example, a comment that starts with "Nit:" is usually considered of low importance, while one that starts with "FYI" is fully optional. Reviewable understands these keywords and automatically sets the corresponding disposition on the comment (see https://docs.reviewable.io/#/discussions?id=change-disposition). The default assumption is that a comment is blocking, which lines up well with Reviewable's defaulting to Blocking disposition on comments that start a new discussion.

Do you think this would address your concerns?

dato

comment created time in a month

PR opened MidLevel/MLAPI

Reviewers
feat(core): pass NetworkedBehaviour instance into custom netvar permission callbacks

@TwoTenPvP, as discussed in chat.

+13 -12

0 comment

5 changed files

pr created time in a month

push eventpkaminski/MLAPI

Piotr Kaminski

commit sha c40264510ff92f2fad6488becae2b569213a60b2

feat(core): pass NetworkedBehaviour instance into custom netvar permission callbacks.

view details

push time in a month

issue commentReviewable/Reviewable

Reviews button in the top bar is broken

I assume you mean the leftmost button in the header bar, with the bunny logo? It seems to work for me, though it links to the home page (as intended). The Reviews button works too FWIW. What exact sequence of clicks (starting with a fresh page load) are you following? Which browser?

@badz0 can you repro?

feldgendler

comment created time in a month

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 3bda64f9ea582e0f9212fcd873145347f8bc100b

Update changelog.md

view details

push time in 2 months

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 99c6feb55f1425571596ba59015711f352c5bfb7

Update syncRequestedReviewers docs.

view details

push time in 2 months

issue closedReviewable/Reviewable

Missing reviewers synchronization on server-side actions

When a PR is created and gets its Reviewable button, and when commits are pushed to an existing PR, the custom completion function is evaluated. However, the pendingReviewers it returns are not synchronized to GitHub Reviewers even if syncRequestedReviewers is set.

This seems to cause long-term mismatches between pendingReviewers and GitHub reviewers.

closed time in 2 months

feldgendler

issue commentReviewable/Reviewable

Missing reviewers synchronization on server-side actions

I pushed a build that will attempt to respect syncRequestedReviewers on the server. This only works if the repo is connected and the request will appear to come from one of the repo admins (usually the one who connected the repo, but not necessarily). Note that this sync is not necessarily retroactive: old PRs will not be automatically updated, but if something else triggers an update then reviewers will be requested. New PRs should be fine.

Let me know how it goes! I may need to temporarily roll back if I spot anything weird, though.

feldgendler

comment created time in 2 months

push eventpkaminski/MLAPI.Transports

Petter Vernersson

commit sha a54e70cc9d77e4393322cb3fca25baf0177e2579

Added SteamP2PTransport.

view details

Piotr Kaminski

commit sha 7017969e8f78bcb13d7856d724fd3c7ddd539fd7

Add LiteNetLib transport.

view details

Albin Corén

commit sha 82c237c51a56d7a9883780737c58bd71ed823a60

Added IsSupported support to transports

view details

Albin Corén

commit sha ba589a646e151844c9e640f0683de85a8e725cc3

Added LiteNetLib project to solution

view details

Albin Corén

commit sha 8653090b15bc8a46b2e344f9330da87cb9693a35

Updated LiteNetLib style

view details

Albin Corén

commit sha d82b88c0534812c86da3d2c59e86d359a9d26c88

Merge pull request #6 from pkaminski/litenetlib Add LiteNetLib transport.

view details

Albin Corén

commit sha a90c5a9f829cbd0f7ac97a9a20363a6ec3a2f19a

Fixed ENET compilation

view details

Albin Corén

commit sha ac5d4eb8f91c285f28d00f567d5826f2456f5011

Update artifact_paths.json

view details

Albin Corén

commit sha c021495f0ccfbe02b7eb0963b9dde7e4163a0273

Added required_build_targets docs

view details

Albin Corén

commit sha 67f12c1acf192f1421c5071ef27d038ea7ff5c66

Finalized SteamP2P addition

view details

Albin Corén

commit sha d615d2114a0ca94d7fd70c448bc153ebacd470ed

Merge branch 'feat/steamp2p' of https://github.com/jaglitegrann/MLAPI.Transports into jaglitegrann-feat/steamp2p

view details

Albin Corén

commit sha 9eb7520f45d4cc4ef244a5ff3ca14a81a911f659

Merge branch 'jaglitegrann-feat/steamp2p'

view details

Albin Corén

commit sha 410956efaf391685c0f82b9db415b03b94020b5b

Improved EnetTransport delivery flags inspector Fixes: #7

view details

Albin Corén

commit sha 08e21c219dee5910d31c4b597eb3e4d376fee73f

Made SteamP2PTransport source based (Steamworks.NET is source based)

view details

Albin Corén

commit sha 29d92f0dc74356e579a0fbba131041572d7c7a52

Added powershell build scripts

view details

Albin Corén

commit sha 2f077c9b51221fc5dd27e73300d63b40e7c7f77b

Respected DISABLESTEAMWORKS

view details

Eris Koleszar

commit sha 4c8436cd341e7be9ac449c6390a75654eb352f7e

Call PollEvents on Update so Send/Receive works.

view details

Albin Corén

commit sha a3201feac337ea0d591b2938e5284f567f3b4228

Merge pull request #9 from bellicapax/master LiteNetLib - Call PollEvents on Update so MLAPI can access events.

view details

Albin Corén

commit sha d03b1a15e3561fe80b854acfd8de8c6ac92e3312

Updated all transports to MLAPI 11 (full task support is not yet added)

view details

Albin Corén

commit sha f564732973604aba1814130b09819f38425a6d02

Added enet dylib

view details

push time in 2 months

push eventpkaminski/MLAPI

Albin Corén

commit sha e81e767ceed6b215400e8fc01b7c1409e99418e6

fix: Added scene buffering for scene switches Fixes: #267

view details

Albin Corén

commit sha 173aeaf6b9b5d9366d606856589035a264cada9b

feat: Added buffering of all message types

view details

Albin Corén

commit sha 44fed186cc983046db79311be6de8f9e1c925b72

fix: Added recursion checks to buffering to ensure we only buffer once (rare)

view details

Albin Corén

commit sha 8359d44fc183d9739ee93237f05560cfa0315eaa

fix: Fixed weakreference logic for pooled memory

view details

Albin Corén

commit sha c3019000dbc459df1f1f2043e9064ffeaacbe0a4

Merge branch 'master' into pooled-scene-buffering

view details

Albin Corén

commit sha 678d0ba5b823af2b983d5c5ca40ae837bc7314e8

feat: Added instanceId and prefabHash to inspector

view details

Albin Corén

commit sha 2448a1d95a70f77dadbc7066781228f42ef4212e

Merge pull request #273 from MidLevel/pooled-scene-buffering fix: Added scene buffering for scene switches

view details

Albin Corén

commit sha 5c0ab7d375f1df76a0cce639d7d7114230a25d7e

ci: Changed publish message

view details

Albin Corén

commit sha a3517c83109bdb0d7166fbbf36738b10eea3867d

docs: Fixed last name spelling

view details

Albin Corén

commit sha 2903d931cb37426e3a412e43e98788f1ff0877ce

docs(wiki): Removed release disclaimer

view details

Albin Corén

commit sha bc2c1a9d02be20572211abb5eb45520e7d6c043e

docs(wiki): Added explanation to connection approval

view details

Albin Corén

commit sha fc4e7c89d94d42ff5788d9e6e3e34028583ad5c3

docs(website): Added disclaimer to improve the page at the top of the wiki

view details

Albin Corén

commit sha 16dd12c0e4ee49d23ad5e128a0f9a94cbcc90202

docs(website): Hid panel for small devices

view details

Albin Corén

commit sha fe3577fafd504083b9b02a9a2a9edf873e70506e

docs: Updated ConnectionApproval example to use a event delegate

view details

Albin Corén

commit sha a3513e4e53d64bea9729d7bea352d005073909ca

fix: Fixed WeakReference object alive checking

view details

Albin Corén

commit sha 93a67f8872bf519ebedabd28c343e35a30193411

docs: Updated funding links to GitHub

view details

Albin Corén

commit sha d06f6f8dd98ddddb8960e6ff1bd66bb1882688b3

Merge branch 'master' of https://github.com/MidLevel/MLAPI

view details

Albin Corén

commit sha 7d264784294142a9adab3ee0a23a89a8d2b3d434

fix: Fixed an issue that caused overflown memory to not be reset before being provided to the user Special thanks to @jaglitegrann for finding and assisting with this issue

view details

Albin Corén

commit sha 7b791dd8029cccc60dd0b4a74579a528016c25b6

docs: Moved github templates to .github

view details

Albin Corén

commit sha 77a7648229d1c236b6e74c030ef888d8ca3cc576

Merge pull request #300 from pkaminski/master feat(core): add NetworkedBehaviour.HasNetworkedObject getter

view details

push time in 2 months

pull request commentMidLevel/MLAPI

feat(core): add NetworkedBehaviour.HasNetworkedObject getter

Ping @TwoTenPvP

pkaminski

comment created time in 2 months

push eventReviewable/Reviewable

Piotr Kaminski

commit sha bd55d2b6d4ec1942aef1e3c8f11505d6bb9755a4

Release 2227.3878

view details

push time in 2 months

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 5db06fad0ae83416cd374c581094f0a4c12bd54a

Update changelog.md

view details

push time in 2 months

PR closed Reviewable/Reviewable

Reviewers
Update introduction.md

<!-- Reviewable:start --> This change is <img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/> <!-- Reviewable:end -->

+1 -5

0 comment

1 changed file

Lenny33

pr closed time in 2 months

push eventReviewable/firetruss

Piotr Kaminski

commit sha f6b8aa020558670defd2e828d95b15aa29f120b7

Throw an early error for operations on path /undefined. These should always be mistakes, but can be difficult to track back to the originating code if we wait until they trigger a permission denied error.

view details

Piotr Kaminski

commit sha 9e99344bd27c44bcbcea3bf1579e92eac8feea64

release 3.0.4

view details

push time in 2 months

created tagReviewable/firetruss

tag3.0.4

Advanced data sync layer for Firebase and Vue.js

created time in 2 months

issue commentReviewable/Reviewable

TypeError seen when viewing diff

Gah, Firefox made such a mess of this. :( I added some user-agent sniffing to Reviewable's bootstrap sequence to force shared workers off for FF71. Please let me know if that helped.

aedelstein

comment created time in 3 months

issue closedReviewable/Reviewable

Renamed GitHub user does not update name on /repositories page

I have renamed my GitHub account several days ago.

However https://reviewable.io/repositories still shows the old name (see the picture). Screenshot 2019-12-09 at 12 53 47

closed time in 3 months

misha-ridge

issue commentReviewable/Reviewable

Renamed GitHub user does not update name on /repositories page

Please sign out and back in again to force a refresh of cached account data. (Reviewable will refresh of its own accord every so often, but as it caches hundreds of thousands of users and information changes pretty rarely, it's not very aggressive about it.)

misha-ridge

comment created time in 3 months

issue closedReviewable/Reviewable

The page crashes

Since this morning (maybe because I updated to Firefox 71), Reviewable keeps crashing for me:

2019-12-05-121925

It seems it's not related to a particular PR because it happened on all PRs I tried.

Reviewable seems to work fine on Chromium.

closed time in 3 months

DamienCassou

issue commentReviewable/Reviewable

The page crashes

Sounds like a minor version update fixed some FF regression. Thanks for figuring this out!

DamienCassou

comment created time in 3 months

PR closed Reviewable/enterprise-tools

Reviewers
Bump lodash from 3.10.1 to 4.17.15 dependencies

Bumps lodash from 3.10.1 to 4.17.15. <details> <summary>Release notes</summary>

Sourced from lodash's releases.

4.0.0

lodash v4.0.0

2015 was big year! Lodash became the most depended on npm package, passed 1 billion downloads, & its v3 release saw massive adoption!

The year was also one of collaboration, as discussions began on merging Lodash & Underscore. Much of Lodash v4 is proofing out the ideas from those discussions. Lodash v4 would not be possible without the collaboration & contributions of the Underscore core team. In the spirit of merging our teams have blended with several members contributing to both libraries.

For 2016 & lodash v4.0.0 we wanted to cut loose, push forward, & take things up a notch!

Modern only

With v4 we’re breaking free from old projects, old environments, & dropping old IE < 9 support!

4 kB Core

Lodash’s kitchen-sink size will continue to grow as new methods & functionality are added. However, we now offer a 4 kB (gzipped) core build that’s compatible with Backbone v1.2.4 for folks who want Lodash without lugging around the kitchen sink.

More ES6

We’ve continued to embrace ES6 with methods like _.isSymbol, added support for cloning & comparing array buffers, maps, sets, & symbols, converting iterators to arrays, & iterable _(…).

In addition, we’ve published an es-build & pulled babel-plugin-lodash into core to make tree-shaking a breeze.

More Modular

Pop quiz! 📣

What category path does the bindAll method belong to? Is it

A) require('lodash/function/bindAll') B) require('lodash/utility/bindAll') C) require('lodash/util/bindAll')

Don’t know? Well, with v4 it doesn’t matter because now module paths are as simple as

var bindAll = require('lodash/bindAll');

We’ve also reduced module complexity making it easier to create smaller bundles. This has helped Lodash adoption with libraries like Async & Redux!

1st Class FP

With v3 we introduced lodash-fp. We learned a lot & with v4 we decided to pull it into core.

Now you can get immutable, auto-curried, iteratee-first, data-last methods as simply as

var _ = require('lodash/fp');
var object = { 'a': 1 };
</tr></table> ... (truncated)

</details> <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 months

push eventReviewable/enterprise-tools

Piotr Kaminski

commit sha ef1dd660fcbb6ff1495a499cf08a972e7fc4685a

Remove RSA key rotation script, as it's now built into the production servers.

view details

push time in 3 months

push eventReviewable/Reviewable

Piotr Kaminski

commit sha f595603892b7c914d2587acc45deae5f637f18cb

Update RSA key rotation instructions.

view details

push time in 3 months

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 81903494136adec7106701b57383e24b0301130d

Update changelog.md

view details

push time in 3 months

issue commentReviewable/Reviewable

The page crashes

I'm not sure what's going on then. However, it may not be worth investigating since Firefox 71 has another regression that makes it less than ideal for Reviewable: see https://changelog.reviewable.io/regression-in-firefox-71-124418. Are you able to check if this issue repros in Firefox 72 on Fedora as well by any chance?

DamienCassou

comment created time in 3 months

issue commentReviewable/Reviewable

TypeError seen when viewing diff

Yup, it should also be fixed in Firefox 72.

aedelstein

comment created time in 3 months

PR opened MidLevel/MLAPI

feat(core): add NetworkedBehaviour.HasNetworkedObject getter

I know this looks weird and useless, but in my project I derive all behaviors from (subclasses of) NetworkedBehaviour for convenience, even when they're not attached to a NetworkedObject. It's thus useful to be able to check in those abstract superclasses whether the behavior is really networked or not without raising and catching an exception.

+13 -0

0 comment

1 changed file

pr created time in 3 months

push eventpkaminski/MLAPI

Piotr Kaminski

commit sha 4d832d09d029874ab9d76cb8db44339eaabaf212

feat(core): add NetworkedBehaviour.HasNetworkedObject getter

view details

push time in 3 months

push eventpkaminski/MLAPI

Albin Corén

commit sha fa530100185f5b30ec2eefdbdb689f199cb60fce

fix: Fixes WebGL UNET Transport AddHost bug (Unity Bug)

view details

Albin Corén

commit sha be60c829ef14fb0e036d5330758b6dfda3c87987

docs: Updated features page (#292)

view details

Albin Corén

commit sha 32a59c5321f02d768405a62e1952b59b968c28e4

fix: Fixed invalid ownership assignment

view details

Albin Corén

commit sha a4ea6e91a73e6aed8450f0505b50b47f2a505ae3

feat: Added unregister custom message and fixed pre singleton registration

view details

Albin Corén

commit sha 7cee329b0cb97fafd975391b8b47f9289e0f6f06

fix: Ensured CustomMessageManager is persistant across sessions

view details

Albin Corén

commit sha bdfa94a9c8b131195cdd03b360fc68d0e36a8702

fix: Compilation

view details

Albin Corén

commit sha 3013cab9eff5dc3143e3227fcce3fdbaf1f20ca9

Merge branch 'master' of https://github.com/MidLevel/MLAPI

view details

Albin Corén

commit sha 3dd19851f81a65a0f1c1fe4d082d01a2f76c0b44

feat: Added support for address reports

view details

Albin Corén

commit sha 7ead4e6b3918929456fb4c5662bec48aa260da73

Merge branch 'master' of https://github.com/MidLevel/MLAPI

view details

Albin Corén

commit sha 70ee6a9a308a2c665f24250b5ba71ec5753273b6

fix: Relay port reading

view details

Albin Corén

commit sha 8e11b4b73e5ec72813a85cd7e9c394f149a4dea2

feat: Added SyncedVars

view details

Albin Corén

commit sha c8e91d18308776d96f1a9d6f089e262ff3964a9d

feat: Added pre init channel registration

view details

Albin Corén

commit sha 19d048e6389b78e4275b9ab8142fb6dac828eda3

feat: Added send rate to SyncedVar

view details

Albin Corén

commit sha 86b4979d7b39cc9e31cc0f668a82c8d25a0c3a78

fix: SyncedVar loop running on client

view details

Albin Corén

commit sha 271218d7272b070adae0e1848d6ad699ee62b421

docs: Added documnetation for SyncedVar

view details

Albin Corén

commit sha 06ce0ad48fb57ce21e3679c9c787bd9d4d93b619

feat: Added exception messaging when accessing NetworkedBehaviour without object

view details

GarethPikPok

commit sha 2379b764c7e0c4a5bb2aed9fb65983c79c316432

Fixed incorrect stream usage in NetworkedBehaviour (#295) The code previously was not doing what the comment implied - it was sending the current stream, not the shortened stream containing only user data. This effectively meant that the else block was redundant and adding additional overhead.

view details

Albin Corén

commit sha f939d31450e82c64a6159bdc2665acc9cc9c3dc4

Merge pull request #298 from MidLevel/syncedvar feat: SyncedVar

view details

Albin Corén

commit sha fcf9f6a02dfd328ee65e474b3fe2e55770954f6f

fix: Fixed transport delegate invocation

view details

Albin Corén

commit sha 9f819cf5f9b603e96a7304e327e30d18866f61aa

fix: Fixed relay exception

view details

push time in 3 months

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 745b4305efd63eed31e24a0de5f18ccae3802bb7

Update changelog.md

view details

push time in 3 months

push eventReviewable/Reviewable

Piotr Kaminski

commit sha 2db67e271bda940b30bb0e422112fefe32c7269a

Update changelog.md

view details

push time in 3 months

issue commentReviewable/Reviewable

The page crashes

Hi Damien,

Thanks for reporting this. I did push a minor new release last night but I only see it happening to you and one other person in your office, and can't reproduce it locally in Firefox 71.0b12 or 72.0b2, so there's a fair chance it's something specific to your environment. Could you please try with extensions disabled?

If that doesn't help, the error message points to an issue with Indexed DB, which is only used by the Firebase library. Their release notes don't show any relevant changes in the recent past. As the DB is only used to store session information, you can try deleting the firebaseLocalStorageDb Indexed DB for https://reviewable.io and see if things improve when it gets automatically recreated on the next page load. (You can wipe local and session storage at the same time for completeness, as some parts of the session get stored there as well.)

Let me know how it goes.

Thanks,

-- P.

On Thu, Dec 5, 2019 at 3:24 AM Damien Cassou notifications@github.com wrote:

Since this morning (maybe because I updated to Firefox 71), Reviewable keeps crashing for me:

[image: 2019-12-05-121925] https://user-images.githubusercontent.com/217543/70230887-935b8c00-1759-11ea-97ad-fc7c72dad0a2.png

It seems it's not related to a particular PR because it happened on all PRs I tried.

Reviewable seems to work fine on Chromium.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Reviewable/Reviewable/issues/708?email_source=notifications&email_token=AAMSCMHMA6SQS2YZKT5XQNLQXDQIFA5CNFSM4JVYCQEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6JL5BQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMSCMEO5KFRQIMR3EE5MSLQXDQIFANCNFSM4JVYCQEA .

DamienCassou

comment created time in 3 months

issue commentReviewable/Reviewable

No horizontal scrolling on per-file revision bar

This looks normal to me. The file header will rise over the toolbar while scrolling, then "bed in" and get properly truncated once it has scrolled high enough.

misha-tectonic

comment created time in 3 months

issue closedReviewable/Reviewable

No horizontal scrolling on per-file revision bar

In review UI one can scroll horizontally the list of files/revisions, but not the list of revisions for individual files.

It makes it harder to do reviews with many revisions.

See the https://photos.app.goo.gl/5XJYoHvWcAyGPPbL6 for the illustration.

closed time in 3 months

misha-tectonic
more