profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/phlax/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

envoyproxy/envoyproxy.github.io 31

Envoy Proxy website

phlax/aio 5

aio is a minimal application framework for python3's asyncio module.

phlax/aio.http.server 1

HTTP server for the aio asyncio framework

phlax/aio.web.page 1

Web page templates for the aio asyncio framework

issue commentenvoyproxy/envoy-build-tools

Current build image fails with missing `'@envoy_build_tools//toolchains:configs/windows/versions.bzl'`

any eta for a resolution on this ?

currently, im blocked from landing the packaging code waiting for the build image to be updated

phlax

comment created time in 17 hours

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_latest_release(dep, repo, metadata_version, release_date):         print(             f'{Fore.YELLOW}*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>: '             f'{latest_release.tag_name}@<{latest_release.created_at}>{Style.RESET_ALL}')+        # check for --cron flag, To run this only on github action schedule+        # and it does not bloat CI on every push+        if create_issue:+            create_issues(dep, repo, metadata_version, release_date, latest_release)+++# create issue for stale dependency+def create_issues(dep, repo, metadata_version, release_date, latest_release):+    """Create issues in GitHub.++    Args:+        dep : name of the deps+        repo : BaseURL of the repo+        metadata_version :+        release_date : old release_date+        latest_release : latest_release (name and date )+    """+    access_token = os.getenv('GITHUB_TOKEN')+    git = github.Github(access_token)+    repo = git.get_repo('envoyproxy/envoy')+    # Find GitHub label objects for LABELS.+    labels = []+    for label in repo.get_labels():+        if label.name in LABELS:+            labels.append(label.name)+    if len(labels) != len(LABELS):+        raise DependencyUpdateError('Unknown labels (expected %s, got %s)' % (LABELS, labels))+    body = f'*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>:{latest_release.tag_name}@<{latest_release.created_at}>'+    title = f'{dep} has a newer release {latest_release.tag_name}'+    exists = repo.legacy_search_issues('open', title) or repo.legacy_search_issues('closed', title)+    # TODO(htuch): Figure out how to do this without legacy and faster.+    if exists:+        print("Issue with %s already exists" % title)+        print('  >> Issue already exists, not posting!')+        return+    print('Creating issues...')+    try:+        repo.create_issue(title, body=body, labels=LABELS)+    except github.GithubException as e:+        print(f'unable to create issue, Getting Error: {e}. Add them to the Envoy proxy org')

and remove capitalization on Error

ME-ON1

comment created time in 17 hours

PullRequestReviewEvent

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_latest_release(dep, repo, metadata_version, release_date):         print(             f'{Fore.YELLOW}*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>: '             f'{latest_release.tag_name}@<{latest_release.created_at}>{Style.RESET_ALL}')+        # check for --cron flag, To run this only on github action schedule+        # and it does not bloat CI on every push+        if create_issue:+            create_issues(dep, repo, metadata_version, release_date, latest_release)+++# create issue for stale dependency+def create_issues(dep, repo, metadata_version, release_date, latest_release):+    """Create issues in GitHub.++    Args:+        dep : name of the deps+        repo : BaseURL of the repo+        metadata_version :+        release_date : old release_date+        latest_release : latest_release (name and date )+    """+    access_token = os.getenv('GITHUB_TOKEN')+    git = github.Github(access_token)+    repo = git.get_repo('envoyproxy/envoy')+    # Find GitHub label objects for LABELS.+    labels = []+    for label in repo.get_labels():+        if label.name in LABELS:+            labels.append(label.name)+    if len(labels) != len(LABELS):+        raise DependencyUpdateError('Unknown labels (expected %s, got %s)' % (LABELS, labels))+    body = f'*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>:{latest_release.tag_name}@<{latest_release.created_at}>'+    title = f'{dep} has a newer release {latest_release.tag_name}'+    exists = repo.legacy_search_issues('open', title) or repo.legacy_search_issues('closed', title)+    # TODO(htuch): Figure out how to do this without legacy and faster.+    if exists:+        print("Issue with %s already exists" % title)+        print('  >> Issue already exists, not posting!')+        return+    print('Creating issues...')+    try:+        repo.create_issue(title, body=body, labels=LABELS)+    except github.GithubException as e:+        print(f'unable to create issue, Getting Error: {e}. Add them to the Envoy proxy org')

also perhaps replace Getting with received

ME-ON1

comment created time in 17 hours

PullRequestReviewEvent

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_release_dates(repository_locations, github_instance):   if __name__ == '__main__':-    if len(sys.argv) != 2:+    # github action will have 3 args and CI will have 2 args+    if len(sys.argv) < 1 or len(sys.argv) > 3:

if you add argparse you should be able to remove this altogether

ME-ON1

comment created time in 18 hours

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_release_dates(repository_locations, github_instance):   if __name__ == '__main__':-    if len(sys.argv) != 2:+    # github action will have 3 args and CI will have 2 args+    if len(sys.argv) < 1 or len(sys.argv) > 3:         print('Usage: %s <path to repository_locations.bzl>' % sys.argv[0])         sys.exit(1)+    # parsing location and github_action flag with argparse+    parser = argparse.ArgumentParser()+    parser.add_argument('location', type=str)+    parser.add_argument('--cron', action='store_true')

also, can we make this consistent throughout, currently it changes from cron -> cron_action -> create_issue

and this is then used by a function called create_issues

ME-ON1

comment created time in 18 hours

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_latest_release(dep, repo, metadata_version, release_date):         print(             f'{Fore.YELLOW}*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>: '             f'{latest_release.tag_name}@<{latest_release.created_at}>{Style.RESET_ALL}')+        # check for --cron flag, To run this only on github action schedule+        # and it does not bloat CI on every push+        if create_issue:+            create_issues(dep, repo, metadata_version, release_date, latest_release)+++# create issue for stale dependency+def create_issues(dep, repo, metadata_version, release_date, latest_release):+    """Create issues in GitHub.++    Args:+        dep : name of the deps+        repo : BaseURL of the repo+        metadata_version :+        release_date : old release_date+        latest_release : latest_release (name and date )+    """+    access_token = os.getenv('GITHUB_TOKEN')+    git = github.Github(access_token)+    repo = git.get_repo('envoyproxy/envoy')+    # Find GitHub label objects for LABELS.+    labels = []+    for label in repo.get_labels():+        if label.name in LABELS:+            labels.append(label.name)+    if len(labels) != len(LABELS):+        raise DependencyUpdateError('Unknown labels (expected %s, got %s)' % (LABELS, labels))+    body = f'*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>:{latest_release.tag_name}@<{latest_release.created_at}>'+    title = f'{dep} has a newer release {latest_release.tag_name}'+    exists = repo.legacy_search_issues('open', title) or repo.legacy_search_issues('closed', title)+    # TODO(htuch): Figure out how to do this without legacy and faster.+    if exists:+        print("Issue with %s already exists" % title)+        print('  >> Issue already exists, not posting!')+        return+    print('Creating issues...')+    try:+        repo.create_issue(title, body=body, labels=LABELS)+    except github.GithubException as e:+        print(f'unable to create issue, Getting Error: {e}. Add them to the Envoy proxy org')

nit capitalize unable

ME-ON1

comment created time in 18 hours

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_latest_release(dep, repo, metadata_version, release_date):         print(             f'{Fore.YELLOW}*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>: '             f'{latest_release.tag_name}@<{latest_release.created_at}>{Style.RESET_ALL}')+        # check for --cron flag, To run this only on github action schedule+        # and it does not bloat CI on every push+        if create_issue:+            create_issues(dep, repo, metadata_version, release_date, latest_release)+++# create issue for stale dependency+def create_issues(dep, repo, metadata_version, release_date, latest_release):+    """Create issues in GitHub.++    Args:+        dep : name of the deps+        repo : BaseURL of the repo+        metadata_version :+        release_date : old release_date+        latest_release : latest_release (name and date )+    """+    access_token = os.getenv('GITHUB_TOKEN')+    git = github.Github(access_token)+    repo = git.get_repo('envoyproxy/envoy')+    # Find GitHub label objects for LABELS.+    labels = []+    for label in repo.get_labels():+        if label.name in LABELS:+            labels.append(label.name)+    if len(labels) != len(LABELS):+        raise DependencyUpdateError('Unknown labels (expected %s, got %s)' % (LABELS, labels))+    body = f'*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>:{latest_release.tag_name}@<{latest_release.created_at}>'+    title = f'{dep} has a newer release {latest_release.tag_name}'+    exists = repo.legacy_search_issues('open', title) or repo.legacy_search_issues('closed', title)

i would suggest factoring out the exists algo to check existing issues to a separate function

ME-ON1

comment created time in 18 hours

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_latest_release(dep, repo, metadata_version, release_date):         print(             f'{Fore.YELLOW}*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>: '             f'{latest_release.tag_name}@<{latest_release.created_at}>{Style.RESET_ALL}')+        # check for --cron flag, To run this only on github action schedule+        # and it does not bloat CI on every push+        if create_issue:+            create_issues(dep, repo, metadata_version, release_date, latest_release)+++# create issue for stale dependency+def create_issues(dep, repo, metadata_version, release_date, latest_release):+    """Create issues in GitHub.++    Args:+        dep : name of the deps+        repo : BaseURL of the repo+        metadata_version :+        release_date : old release_date+        latest_release : latest_release (name and date )+    """+    access_token = os.getenv('GITHUB_TOKEN')+    git = github.Github(access_token)+    repo = git.get_repo('envoyproxy/envoy')+    # Find GitHub label objects for LABELS.+    labels = []+    for label in repo.get_labels():+        if label.name in LABELS:+            labels.append(label.name)+    if len(labels) != len(LABELS):+        raise DependencyUpdateError('Unknown labels (expected %s, got %s)' % (LABELS, labels))+    body = f'*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>:{latest_release.tag_name}@<{latest_release.created_at}>'+    title = f'{dep} has a newer release {latest_release.tag_name}'+    exists = repo.legacy_search_issues('open', title) or repo.legacy_search_issues('closed', title)

im also really uncomfortable with using legacy_search_issues - quick search suggests it could go away fairly soon (it has been deprecated since 2018)

this is the relevant API section on the correct way to search https://docs.github.com/en/github/searching-for-information-on-github/searching-on-github/searching-issues-and-pull-requests#search-by-the-title-body-or-comments

and pygithub is here https://pygithub.readthedocs.io/en/latest/github.html#github.MainClass.Github.search_issues

ME-ON1

comment created time in 18 hours

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_latest_release(dep, repo, metadata_version, release_date):         print(             f'{Fore.YELLOW}*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>: '             f'{latest_release.tag_name}@<{latest_release.created_at}>{Style.RESET_ALL}')+        # check for --cron flag, To run this only on github action schedule+        # and it does not bloat CI on every push+        if create_issue:+            create_issues(dep, repo, metadata_version, release_date, latest_release)+++# create issue for stale dependency+def create_issues(dep, repo, metadata_version, release_date, latest_release):+    """Create issues in GitHub.++    Args:+        dep : name of the deps+        repo : BaseURL of the repo+        metadata_version :+        release_date : old release_date+        latest_release : latest_release (name and date )+    """+    access_token = os.getenv('GITHUB_TOKEN')+    git = github.Github(access_token)+    repo = git.get_repo('envoyproxy/envoy')+    # Find GitHub label objects for LABELS.+    labels = []+    for label in repo.get_labels():+        if label.name in LABELS:+            labels.append(label.name)+    if len(labels) != len(LABELS):+        raise DependencyUpdateError('Unknown labels (expected %s, got %s)' % (LABELS, labels))+    body = f'*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>:{latest_release.tag_name}@<{latest_release.created_at}>'+    title = f'{dep} has a newer release {latest_release.tag_name}'

To make the issues more immediately obvious as to what type of issue it is i would avoid putting the changeable part at the beginning of the title, eg something like

Newer release available ({dep}): {tag_name}

ME-ON1

comment created time in 19 hours

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_release_dates(repository_locations, github_instance):   if __name__ == '__main__':-    if len(sys.argv) != 2:+    # github action will have 3 args and CI will have 2 args+    if len(sys.argv) < 1 or len(sys.argv) > 3:         print('Usage: %s <path to repository_locations.bzl>' % sys.argv[0])         sys.exit(1)+    # parsing location and github_action flag with argparse+    parser = argparse.ArgumentParser()+    parser.add_argument('location', type=str)+    parser.add_argument('--cron', action='store_true')

I find the name of this flag confusing, and not overly helpful

could we change it to something like --create-issues

ME-ON1

comment created time in 18 hours

Pull request review commentenvoyproxy/envoy

create issue via github action for stale deps #16705

 def verify_and_print_latest_release(dep, repo, metadata_version, release_date):         print(             f'{Fore.YELLOW}*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>: '             f'{latest_release.tag_name}@<{latest_release.created_at}>{Style.RESET_ALL}')+        # check for --cron flag, To run this only on github action schedule+        # and it does not bloat CI on every push+        if create_issue:+            create_issues(dep, repo, metadata_version, release_date, latest_release)+++# create issue for stale dependency+def create_issues(dep, repo, metadata_version, release_date, latest_release):+    """Create issues in GitHub.++    Args:+        dep : name of the deps+        repo : BaseURL of the repo+        metadata_version :+        release_date : old release_date+        latest_release : latest_release (name and date )+    """+    access_token = os.getenv('GITHUB_TOKEN')+    git = github.Github(access_token)+    repo = git.get_repo('envoyproxy/envoy')+    # Find GitHub label objects for LABELS.+    labels = []+    for label in repo.get_labels():+        if label.name in LABELS:+            labels.append(label.name)+    if len(labels) != len(LABELS):+        raise DependencyUpdateError('Unknown labels (expected %s, got %s)' % (LABELS, labels))+    body = f'*WARNING* {dep} has a newer release than {metadata_version}@<{release_date}>:{latest_release.tag_name}@<{latest_release.created_at}>'+    title = f'{dep} has a newer release {latest_release.tag_name}'+    exists = repo.legacy_search_issues('open', title) or repo.legacy_search_issues('closed', title)+    # TODO(htuch): Figure out how to do this without legacy and faster.+    if exists:+        print("Issue with %s already exists" % title)+        print('  >> Issue already exists, not posting!')+        return+    print('Creating issues...')+    try:+        repo.create_issue(title, body=body, labels=LABELS)

if LABELS is a global, no need to pass it around

ME-ON1

comment created time in 18 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue commentgoogle/rpmpack

Unable to install the built rpm (without force)

as a ~simple workaround, i added something to strip all of the directories from the tarball

phlax

comment created time in a day

pull request commentenvoyproxy/envoy

create issue via github action for stale deps #16705

im happy to look over this PR but im OOO most of today

ME-ON1

comment created time in 2 days

push eventenvoyproxy/envoyproxy.github.io

phlax

commit sha 317cd82e27c6274e74975a73975423df993a7c77

docs: Use full commit hash to retrieve version (#203) Signed-off-by: Ryan Northey <ryan@synca.io>

view details

push time in 2 days

push eventphlax/envoyproxy.github.io

Ryan Northey

commit sha 9c379a1298d1586250aa7a0ad55465f50ff76c71

docs: Use full commit hash to retrieve version Signed-off-by: Ryan Northey <ryan@synca.io>

view details

push time in 2 days

push eventphlax/envoyproxy.github.io

Ryan Northey

commit sha 485d4805600f840b2013c1fc86fde5a737ac44f0

docs: Use full commit hash to retrieve version Signed-off-by: Ryan Northey <ryan@synca.io>

view details

push time in 2 days

push eventphlax/envoyproxy.github.io

Ryan Northey

commit sha eb4d6cfae79f6b0559effc94212fe9d79f6707be

docs: Use full commit hash to retrieve version Signed-off-by: Ryan Northey <ryan@synca.io>

view details

push time in 2 days

push eventphlax/envoyproxy.github.io

Ryan Northey

commit sha 11b37aa59452f05371ab6d38882a776018ca3842

docs: Use full commit hash to retrieve version

view details

push time in 2 days

create barnchphlax/envoyproxy.github.io

branch : version-fix

created branch time in 2 days

push eventenvoyproxy/pytooling

Ryan Northey

commit sha 123815385a90a932410f8e9f83bd6d6bf871bc9e

libs: Add envoy.docs.abstract Signed-off-by: Ryan Northey <ryan@synca.io>

view details

push time in 2 days

push eventenvoyproxy/pytooling

Ryan Northey

commit sha dd77fb147ccfa4c6666ef3f1859eb3e2d45d02ab

libs: Add envoy.docs.abstract Signed-off-by: Ryan Northey <ryan@synca.io>

view details

push time in 2 days

push eventenvoyproxy/pytooling

Ryan Northey

commit sha 65f158dd95705a260d853be089aa1ed1f8e67812

libs: Add envoy.docs.abstract Signed-off-by: Ryan Northey <ryan@synca.io>

view details

push time in 2 days

push eventenvoyproxy/pytooling

Ryan Northey

commit sha e08925e516ef754b42e357fe19aa6f3ddf744c26

libs: Add envoy.docs.abstract Signed-off-by: Ryan Northey <ryan@synca.io>

view details

push time in 2 days

push eventenvoyproxy/pytooling

Ryan Northey

commit sha 249165a2aa616494220c766fab9b55fb40420202

more

view details

push time in 2 days