profile
viewpoint
Philippe Normand philn @Igalia https://base-art.net Find me on the gitlabs too. Same username.

philn/glide 105

Linux/macOS media player based on GStreamer and GTK+

philn/gnome-shell-gajim-extension 18

[UNMAINTAINED] Gajim IM integration in GNOME Shell

Igalia/webkit-flatpak-sdk 6

A Flatpak SDK and Runtime for WebKit developers

philn/gnome-shell-grilo-search-extension 1

Search for media on the web thanks to Grilo, from the GNOME Shell

philn/async-tungstenite 0

Async binding for Tungstenite, the Lightweight stream-based WebSocket implementation

philn/atk 0

Atk binding in rust

philn/cog 0

WPE launcher and webapp container

philn/dav1d-rs 0

Rust bindings for the dav1d library

philn/dav1d-rs-1 0

libdav1d rust bindings

push eventphiln/webkit

zalan@apple.com

commit sha 26eb917be6707d19cdd6d02f858b507c7feef45e

[LFC][IFC] Remove fully collapsed trailing run https://bugs.webkit.org/show_bug.cgi?id=217653 Reviewed by Antti Koivisto. Source/WebCore: We don't attach fully collapsible runs to the line. When Line::appendText sees an inline item that would generate such run (e.g. <div>foobar <span> <span></div> - the inline text item inside the <span> would generate fully collapsed run) it simply ignores it and will not generate a run for it. In this patch when the trailing trimmable run is fully collapsed, we should not only collapse it, but also remove it from the line. Test: fast/layoutformattingcontext/replaced-and-trailing-trimmable-content.html * layout/inlineformatting/InlineLine.cpp: (WebCore::Layout::Line::TrimmableTrailingContent::addFullyTrimmableContent): (WebCore::Layout::Line::TrimmableTrailingContent::addPartiallyTrimmableContent): (WebCore::Layout::Line::TrimmableTrailingContent::remove): * layout/inlineformatting/InlineLine.h: (WebCore::Layout::Line::TrimmableTrailingContent::isEmpty const): (WebCore::Layout::Line::TrimmableTrailingContent::reset): LayoutTests: * fast/layoutformattingcontext/replaced-and-trailing-trimmable-content-expected.html: Added. * fast/layoutformattingcontext/replaced-and-trailing-trimmable-content.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

commit-queue@webkit.org

commit sha af46efaa5afd526adb239ad1357218c6c463de50

[SOUP] webkit_web_view_get_https_status() broken with service workers https://bugs.webkit.org/show_bug.cgi?id=216038 Patch by Michael Catanzaro <mcatanzaro@gnome.org> on 2020-10-13 Reviewed by Carlos Garcia Campos. This implements CertificateInfo::isolatedCopy for libsoup ports. This is impossible to do completely, because we cannot copy the private key portion of the GTlsCertificate, because it is a write-only property, because it might be backed by a hardware token and therefore really impossible to write software to get it. If we were to implement g_tls_certificate_copy() in GLib -- which I will probably do eventually, because I need this outside WebKit as well -- then GTlsCertificate implementations could copy the private key or PKCS#11 handle or whatever. But anyway, let not perfect be the enemy of the good. We only need this for service workers currently. (Probably that's all we'll *ever* need it for.) So we are only working with server certificates, and the private portion of the certificate is guaranteed to not exist (because servers don't send us their private keys), and we can just forget about it. As long as nobody tries to copy a client certificate in the future -- where we really would need the private key portion of the certificate -- this will be perfectly fine. Actually copying the certificate is kind of annoying, because a chain of certificates is represented by having the main (server) certificate keep a reference to its issuer, which is not referenced anywhere else, so we have to reconstruct the chain in reverse order starting from the final certificate, working back towards the server cert. Fun. Let's also be careful to construct a completely new GByteArray rather than expecting the GTlsCertificate implementation to copy it for us. Because GTlsCertificate is implemented by an extension point and applications and system administrators can -- and do -- implement their own, implementations could do anything, including keep a reference to the GByteArray that we pass in. It would be nice to have a test for this, but writing tests is hard. Also, I don't really want to learn what service workers are. :) Drive-by fix: also remove explicit from a constructor that doesn't need it. * platform/network/soup/CertificateInfo.h: (WebCore::CertificateInfo::isolatedCopy const): * platform/network/soup/CertificateInfoSoup.cpp: (WebCore::createCertificate): (WebCore::CertificateInfo::isolatedCopy const): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

lmoura@igalia.com

commit sha 912c96fea0712154cc2a659b1c7e0641dde367c2

REGRESSION(r268267) [webkitpy] Add missing deps for pytest when running webdriver tests https://bugs.webkit.org/show_bug.cgi?id=217650 Reviewed by Jonathan Bedard. scandir (needed as os.scandir was added only in py 3.5) Also fixed more_itertools autoinstall declaration so the package name, with underscore, is the name of the webkitcorepy package and the dash is used for the pypi package name. With these changes the script does not error anymore, although there seems to be some issues with the executor when running tests. They happen to only start and stop the webserver but not actually being run. To be investigated in a separate bug. * Scripts/webkitpy/__init__.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

youenn@apple.com

commit sha ca2e37971d843a1e432f4f7bd3965675663005fe

Improve computation of default audio input and output devices https://bugs.webkit.org/show_bug.cgi?id=217652 <rdar://problem/69857857> Reviewed by Eric Carlson. Add support for computation of the default audio output device. Fix a bug in the computation of the default device on the first call to refreshAudioCaptureDevices. Refactor the code as follows to make it easier to read: - for each case we want to refresh devices, compute a Vector of audio devices, first microphones, then speakers. - make sure to put in that list the default microphone first in the list and the default speaker just after the last microphone in the list. - check whether the list is equal to the current list of audio devices. If it is equal, abort. - update microphone and speaker lists and send notification of device change. Minor refactoring to make CoreAudioCaptureDevice isAlive a private method. Manually tested. * platform/mediastream/mac/CoreAudioCaptureDevice.cpp: (WebCore::CoreAudioCaptureDevice::CoreAudioCaptureDevice): * platform/mediastream/mac/CoreAudioCaptureDevice.h: * platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp: (WebCore::getDefaultCaptureOutputDevice): (WebCore::CoreAudioCaptureDeviceManager::coreAudioCaptureDevices): (WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

peng.liu6@apple.com

commit sha 5a7d7f32c208330a7ee2bde9941ecea902786039

Clean up the API tests of CARingBuffer https://bugs.webkit.org/show_bug.cgi?id=217633 Reviewed by Simon Fraser. Remove unused private functions and enable the tests for iOS. * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream): Deleted. (TestWebKitAPI::CARingBufferTest::configureBufferListForStream): Deleted. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

youenn@apple.com

commit sha 192d2fef01e5731a1d0f44ee6449373928f2b27a

Webcam video from navigator.mediaDevices.getUserMedia() to 2D canvas fails on Safari on iPhone https://bugs.webkit.org/show_bug.cgi?id=217578 <rdar://problem/70183875> Reviewed by Eric Carlson. It is unneeded for MediaStream video backends to enqueue samples to the display layer if the video element is hidden. In iOS, the samples may never be flushed which might cause capture failing after enqueuing too many camera samples. To avoid that, we no longer enqueue samples to the display layer when the player is not visible. In case of canvas painting, other backends need to be made visible for canvas painting to work. For MediaStream backend, we do not need that since we always keep the last sample. For that reason, we keep the backend as not visible even if canvas happens. We do so by introducing a setVisibleForCanvas that is a no-op for MediaStream backend and similar to setVisible for other backends. For good measure, we now flush the MediaStream display layer whenever visibility changed. Manually tested. * html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::paintCurrentFrameInContext): * platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setVisibleForCanvas): * platform/graphics/MediaPlayer.h: * platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setVisibleForCanvas): * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisible): (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisibleForCanvas): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

zalan@apple.com

commit sha a032536913dc0af1912f776d88f76099f9efb4eb

[LFC][IFC] Introduce InlineLevelBox::LineBreakBox and GenericInlineLevelBox https://bugs.webkit.org/show_bug.cgi?id=217646 Reviewed by Antti Koivisto. This is in preparation for adding support for https://www.w3.org/TR/css-inline-3/#layout-bounds. * layout/inlineformatting/InlineFormattingContextGeometry.cpp: (WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes): Cleaning up a bit and moving adjustVerticalGeometryForNonEmptyInlineBox to a dedicated function. constructInlineLevelBoxes was getting a bit too busy. * layout/inlineformatting/InlineLineBox.cpp: (WebCore::Layout::LineBox::InlineLevelBox::InlineLevelBox): * layout/inlineformatting/InlineLineBox.h: (WebCore::Layout::LineBox::InlineLevelBox::createRootInlineBox): (WebCore::Layout::LineBox::InlineLevelBox::createAtomicInlineLevelBox): (WebCore::Layout::LineBox::InlineLevelBox::createInlineBox): (WebCore::Layout::LineBox::InlineLevelBox::createLineBreakBox): (WebCore::Layout::LineBox::InlineLevelBox::createGenericInlineLevelBox): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

weinig@apple.com

commit sha e6adf608b47e88ce29a592a3db29db32d2586bca

[Testing] Rename test header commands to match names in WebPreferences*.yaml https://bugs.webkit.org/show_bug.cgi?id=217654 Reviewed by Simon Fraser. Tools: Renames all the test header commands (e.g. useAcceleratedDrawing) to match name in WebPreferences*.yaml files (e.g. AcceleratedDrawingEnabled). Also splits up TestFeatures into test runner specific features (e.g. runSingly) that don't have a WebPreferences counterpart, and WebPreferences specific features. This will allow future patches to support arbritrary WebPreferences more easily. * DumpRenderTree/TestOptions.cpp: * DumpRenderTree/TestOptions.h: * DumpRenderTree/mac/DumpRenderTree.mm: (setWebPreferencesForTestOptions): * TestRunnerShared/TestFeatures.cpp: * TestRunnerShared/TestFeatures.h: * WebKitTestRunner/TestController.cpp: * WebKitTestRunner/TestOptions.cpp: * WebKitTestRunner/TestOptions.h: * WebKitTestRunner/cocoa/TestControllerCocoa.mm: * WebKitTestRunner/gtk/TestControllerGtk.cpp: * WebKitTestRunner/mac/TestControllerMac.mm: * WebKitTestRunner/wpe/TestControllerWPE.cpp: LayoutTests: Update test header commands to match names in the WebPreferences*.yaml configuration files. * accessibility/attachment-element.html: * accessibility/content-changed-notification-causes-crash.html: * accessibility/contenteditable-table-check-causes-crash.html: * accessibility/duplicate-axrenderobject-crash.html: * accessibility/ios-simulator/attributed-string-for-range.html: * accessibility/ios-simulator/has-touch-event-listener-with-shadow.html: * accessibility/ios-simulator/media-with-aria-label.html: * accessibility/mac/attachment-element-replacement-character.html: * accessibility/mac/video-tag-hit-test.html: * accessibility/mac/video-volume-slider-accessibility.html: * accessibility/media-element.html: * accessibility/media-emits-object-replacement.html: * accessibility/media-with-aria-label.html: * animations/resume-after-page-cache.html: * compositing/accelerated-layers-after-back.html: * compositing/iframes/page-cache-layer-tree.html: * compositing/page-cache-back-crash.html: * compositing/show-composited-iframe-on-back-button.html: * compositing/video/poster-expected.html: * compositing/video/poster.html: * css3/color-filters/color-filter-animation.html: * css3/color-filters/color-filter-apple-invert-lightness.html: * css3/color-filters/color-filter-backgrounds-borders.html: * css3/color-filters/color-filter-box-shadow.html: * css3/color-filters/color-filter-brightness.html: * css3/color-filters/color-filter-caret-color.html: * css3/color-filters/color-filter-color-property-list-item.html: * css3/color-filters/color-filter-color-property.html: * css3/color-filters/color-filter-color-text-decorations.html: * css3/color-filters/color-filter-column-rule.html: * css3/color-filters/color-filter-composition-underline-color-expected.html: * css3/color-filters/color-filter-composition-underline-color.html: * css3/color-filters/color-filter-contrast.html: * css3/color-filters/color-filter-current-color.html: * css3/color-filters/color-filter-filter-list.html: * css3/color-filters/color-filter-gradients.html: * css3/color-filters/color-filter-grayscale.html: * css3/color-filters/color-filter-hue-rotate.html: * css3/color-filters/color-filter-ignore-semantic-expected.html: * css3/color-filters/color-filter-ignore-semantic.html: * css3/color-filters/color-filter-inherits.html: * css3/color-filters/color-filter-invert.html: * css3/color-filters/color-filter-opacity.html: * css3/color-filters/color-filter-outline.html: * css3/color-filters/color-filter-parsing.html: * css3/color-filters/color-filter-saturate.html: * css3/color-filters/color-filter-sepia.html: * css3/color-filters/color-filter-text-decoration-shadow.html: * css3/color-filters/color-filter-text-emphasis.html: * css3/color-filters/color-filter-text-shadow.html: * css3/color-filters/color-filter-text-stroke.html: * css3/color-filters/svg/color-filter-inline-svg.html: * editing/async-clipboard/clipboard-change-data-while-reading.html: * editing/async-clipboard/clipboard-change-data-while-writing.html: * editing/async-clipboard/clipboard-do-not-read-text-from-platform-if-text-changes.html: * editing/async-clipboard/clipboard-read-text-from-platform.html: * editing/async-clipboard/clipboard-read-text-same-origin.html: * editing/async-clipboard/clipboard-read-while-pasting.html: * editing/async-clipboard/sanitize-when-reading-markup.html: * editing/execCommand/set-backColor-with-color-filter-from-scripts.html: * editing/execCommand/set-foreColor-with-color-filter-from-scripts.html: * editing/mac/attributed-string/attrib-string-colors-with-color-filter.html: * editing/mac/attributed-string/attrib-string-range-with-color-filter.html: * editing/mac/attributed-string/attribute-string-for-copy-with-color-filter.html: * editing/mac/attributed-string/attributed-string-for-typing-with-color-filter.html: * editing/mac/input/unconfirmed-text-navigation-with-page-cache.html: * editing/pasteboard/copy-paste-attachment.html: * editing/pasteboard/dom-paste/dom-paste-confirmation.html: * editing/pasteboard/dom-paste/dom-paste-consecutive-confirmations.html: * editing/pasteboard/dom-paste/dom-paste-rejection.html: * editing/pasteboard/dom-paste/dom-paste-requires-user-gesture.html: * editing/pasteboard/dom-paste/dom-paste-same-origin.html: * editing/pasteboard/drag-file-promises-to-editable-element-as-URLs.html: * editing/pasteboard/drag-file-promises-to-editable-element-as-attachment.html: * editing/pasteboard/drag-files-to-editable-element-as-URLs.html: * editing/pasteboard/drag-files-to-editable-element-as-attachment.html: * editing/pasteboard/entries-api/DirectoryEntry-getFile-back-forward-cache.html: * editing/pasteboard/entries-api/DirectoryReader-readEntries-back-forward-cache.html: * editing/pasteboard/paste-dark-mode-color-filtered.html: * editing/selection/selection-change-in-disconnected-frame-crash.html: * editing/style/inverse-color-filter.html: * editing/style/set-backColor-with-color-filter.html: * editing/style/set-foreColor-with-color-filter.html: * fast/attachment/attachment-action-expected.html: * fast/attachment/attachment-action.html: * fast/attachment/attachment-border-should-stay-inside-attachment.html: * fast/attachment/attachment-borderless-expected-mismatch.html: * fast/attachment/attachment-borderless.html: * fast/attachment/attachment-default-icon-expected.html: * fast/attachment/attachment-default-icon.html: * fast/attachment/attachment-dom.html: * fast/attachment/attachment-dynamic-type.html: * fast/attachment/attachment-folder-icon-expected.html: * fast/attachment/attachment-folder-icon.html: * fast/attachment/attachment-icon-from-file-extension-expected.html: * fast/attachment/attachment-icon-from-file-extension.html: * fast/attachment/attachment-label-highlight.html: * fast/attachment/attachment-progress.html: * fast/attachment/attachment-rendering.html: * fast/attachment/attachment-respects-css-size.html: * fast/attachment/attachment-select-on-click-inside-user-select-all.html: * fast/attachment/attachment-select-on-click.html: * fast/attachment/attachment-subtitle-resize.html: * fast/attachment/attachment-subtitle.html: * fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html: * fast/attachment/attachment-title-with-rtl-expected.html: * fast/attachment/attachment-title-with-rtl.html: * fast/attachment/attachment-title.html: * fast/attachment/attachment-type-attribute-expected.html: * fast/attachment/attachment-type-attribute.html: * fast/attachment/attachment-uti-expected.html: * fast/attachment/attachment-uti.html: * fast/attachment/attachment-wrapping-action-expected-mismatch.html: * fast/attachment/attachment-wrapping-action.html: * fast/block/float/float-not-removed-from-first-letter.html: * fast/block/float/split-inline-sibling-of-float-crash.html: * fast/canvas/2d.currentPoint.html: * fast/canvas/2d.getPath.modification.html: * fast/canvas/2d.getPath.newobject.html: * fast/canvas/2d.setPath.html: * fast/canvas/webgl/canvas-webgl-page-cache.html: * fast/css/fontloader-page-cache.html: * fast/css/has-attachment.html: * fast/css/pseudo-required-optional-unapplied.html: * fast/dom/DeviceMotion/no-page-cache.html: * fast/dom/DeviceOrientation/event-after-navigation.html: * fast/dom/DeviceOrientation/no-page-cache.html: * fast/dom/HTMLFormElement/associated-elements-after-index-assertion-fail1.html: * fast/dom/HTMLKeygenElement/keygen-keytype.html: * fast/dom/HTMLKeygenElement/keygen.html: * fast/dom/Window/timer-resume-on-navigation-back.html: * fast/dom/adopt-node-crash-2.html: * fast/dom/attribute-set-before-element-in-tree.html: * fast/dom/domstring-attribute-reflection.html: * fast/dom/set-custom-validity-with-too-few-arguments.html: * fast/dom/tabindex-defaults.html: * fast/dom/wrapper-classes.html: * fast/dynamic/insertAdjacentHTML-allowed-parents.html: * fast/events/ios/do-not-show-keyboard-when-focusing-after-blur.html: * fast/events/ios/pdf-modifer-key-down-crash.html: * fast/events/ios/rotation/do-not-shrink-to-fit-content-after-rotation.html: * fast/events/onunload-back-to-page-cache.html: * fast/events/pagehide-timeout.html: * fast/events/pagehide-xhr-open.html: * fast/events/pageshow-pagehide-on-back-cached-with-frames.html: * fast/events/pageshow-pagehide-on-back-cached.html: * fast/events/suspend-timers.html: * fast/files/file-reader-back-forward-cache.html: * fast/flexbox/crash-button-keygen.html: * fast/forms/ValidityState-001.html: * fast/forms/autocomplete-off-with-default-value-does-not-clear.html: * fast/forms/autofocus-keygen.html: * fast/forms/checkValidity-001.html: * fast/forms/fieldset/fieldset-elements-htmlcollection.html: * fast/forms/fieldset/fieldset-elements.html: * fast/forms/form-associated-element-crash3.html: * fast/forms/form-attribute.html: * fast/forms/form-collection-elements-order.html: * fast/forms/form-collection-elements.html: * fast/forms/form-collection-radio-node-list.html: * fast/forms/ios/no-scrolling-when-moving-focus-between-adjacent-fields.html: * fast/forms/label/labelable-elements.html: * fast/forms/label/labels-add-htmlFor-label.html: * fast/forms/label/labels-add-parent-label.html: * fast/forms/label/labels-change-htmlFor-attribute.html: * fast/forms/label/labels-multiple-sibling-labels.html: * fast/forms/label/labels-parent-and-sibling-labels.html: * fast/forms/label/labels-remove-htmlFor-attribute.html: * fast/forms/label/labels-remove-htmlFor-label.html: * fast/forms/label/labels-remove-parent-label.html: * fast/forms/large-parts.html: * fast/forms/scrollheight-with-mutation-crash.html: * fast/forms/setCustomValidity-arguments.html: * fast/forms/setCustomValidity-existence.html: * fast/forms/setCustomValidity-null-parameter.html: * fast/forms/state-restore-skip-stateless.html: * fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html: * fast/forms/validationMessage.html: * fast/forms/willvalidate.html: * fast/frames/frame-crash-with-page-cache.html: * fast/frames/frame-unload-navigate-and-setTimeout-assert-fail.html: * fast/frames/page-hide-document-open.html: * fast/frames/restoring-page-cache-should-not-run-scripts-via-style-update.html: * fast/frames/restoring-page-cache-should-not-run-scripts.html: * fast/harness/page-cache-crash-on-data-urls.html: * fast/harness/use-page-cache.html: * fast/hidpi/video-controls-in-hidpi.html: * fast/history/back-forward-cache-visibility-state.html: * fast/history/back-from-page-with-focused-iframe.html: * fast/history/go-back-to-iframe-with-plugin.html: * fast/history/go-back-to-object-subframe.html: * fast/history/history-back-while-pdf-in-pagecache.html: * fast/history/multiple-back-forward-navigations.html: * fast/history/page-cache-MessagePort-pending-message.html: * fast/history/page-cache-active-fetch-request-blobReadAsBlob.html: * fast/history/page-cache-active-fetch-request-blobReadAsReadableStream.html: * fast/history/page-cache-active-fetch-request-blobReadAsText.html: * fast/history/page-cache-active-fetch-response-blobReadAsBlob.html: * fast/history/page-cache-after-window-open.html: * fast/history/page-cache-back-navigation-crash.html: * fast/history/page-cache-clearing.html: * fast/history/page-cache-closed-audiocontext.html: * fast/history/page-cache-createImageBitmap.html: * fast/history/page-cache-createObjectURL-using-open-panel.html: * fast/history/page-cache-createObjectURL.html: * fast/history/page-cache-destroy-document.html: * fast/history/page-cache-element-state-focused.html: * fast/history/page-cache-execute-script-during-restore.html: * fast/history/page-cache-geolocation-active-oneshot.html: * fast/history/page-cache-geolocation-active-watcher.html: * fast/history/page-cache-geolocation.html: * fast/history/page-cache-gpu-canvas-context.html: * fast/history/page-cache-iframe-js-url.html: * fast/history/page-cache-indexed-closed-db.html: * fast/history/page-cache-indexed-opened-db.html: * fast/history/page-cache-media-recorder.html: * fast/history/page-cache-media-source-closed-2.html: * fast/history/page-cache-media-source-closed.html: * fast/history/page-cache-media-source-opened.html: * fast/history/page-cache-navigate-during-restore.html: * fast/history/page-cache-notification-showing.html: * fast/history/page-cache-notification-suspendable.html: * fast/history/page-cache-removed-source-buffer.html: * fast/history/page-cache-running-audiocontext.html: * fast/history/page-cache-subframes-with-provisional-load.html: * fast/history/page-cache-suspended-audiocontext.html: * fast/history/page-cache-webdatabase-no-transaction-db.html: * fast/history/page-cache-webdatabase-pending-transaction.html: * fast/history/page-cache-with-opener.html: * fast/history/pagehide-remove-iframe-crash.html: * fast/history/resources/page-cache-window-with-iframe.html: * fast/history/resources/page-cache-window-with-opener.html: * fast/history/timed-refresh-in-cached-frame.html: * fast/html/clone-keygen.html: * fast/html/keygen.html: * fast/html/marquee-reparent-check.html: * fast/html/menuitem-element.html: * fast/images/animated-gif-restored-from-bfcache.html: * fast/invalid/residual-style-expected.html: * fast/invalid/residual-style.html: * fast/layers/video-layer.html: * fast/loader/data-url-load-denied.html: * fast/loader/frames-with-unload-handlers-in-page-cache.html: * fast/loader/image-in-page-cache.html: * fast/loader/input-element-page-cache-crash.html: * fast/loader/navigate-with-new-target-after-back-forward-navigation.html: * fast/loader/navigate-with-post-to-new-target-after-back-forward-navigation.html: * fast/loader/scroll-position-restored-on-back.html: * fast/loader/stateobjects/no-popstate-when-back-to-stateless-entry-with-page-cache.html: * fast/loader/stateobjects/popstate-fires-with-page-cache.html: * fast/loader/unschedule-relayout-after-unload.html: * fast/loader/window-properties-restored-from-page-cache.html: * fast/mediastream/MediaStream-video-element-video-tracks-disabled.html: * fast/mediastream/RTCPeerConnection-page-cache.html: * fast/mediastream/captureInGPUProcess.html: * fast/mediastream/media-stream-track-interrupted.html: * fast/multicol/span/positioned-child-not-removed-crash.html: * fast/overflow/horizontal-scroll-after-back.html: * fast/ruby/float-object-doesnt-crash.html: * fast/sandbox/ios/sandbox-mach-lookup-attachment-element.html: * fast/scrolling/iframe-scrollable-after-back.html: * fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html: * fast/scrolling/ios/scroll-events-back-forward.html: * fast/scrolling/ios/touch-scroll-back-forward.html: * fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-hovered.html: * fast/scrolling/mac/scrollbars/overflow-in-iframe-overlay-scrollbar-reveal.html: * fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-hovered.html: * fast/scrolling/mac/scrollbars/overflow-overlay-scrollbar-reveal.html: * fast/scrolling/mac/scrollbars/overlay-scrollbar-hovered.html: * fast/scrolling/mac/scrollbars/overlay-scrollbar-reveal.html: * fast/scrolling/mac/scrollbars/overlay-scrollbar-state.html: * fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered.html: * fast/scrolling/mac/scrollbars/select-overlay-scrollbar-reveal.html: * fast/scrolling/overflow-scrollable-after-back.html: * fast/scrolling/page-cache-back-overflow-scroll-restore.html: * fast/scrolling/rtl-scrollbars-animation-property.html: * fast/shadow-dom/keygen-shadow-manipulation.html: * fast/table/crash-splitColumn-2.html: * fast/table/multiple-captions-crash3-expected.html: * fast/table/multiple-captions-crash3.html: * fast/text-autosizing/ios/text-autosizing-after-back.html: * fast/viewport/ios/ignore-minimum-device-width-for-page-with-viewport-device-width.html: * fast/viewport/ios/minimum-scale-after-changing-view-scale.html: * fast/viewport/ios/resources/go-back.html: * fast/viewport/ios/shrink-to-fit-content-constant-width.html: * fast/viewport/ios/shrink-to-fit-content-large-constant-width.html: * fast/viewport/ios/shrink-to-fit-content-large-width-breakpoint.html: * fast/viewport/ios/shrink-to-fit-content-no-viewport.html: * fast/viewport/ios/shrink-to-fit-content-responsive-viewport-with-horizontal-overflow.html: * fast/viewport/ios/shrink-to-fit-content-temporary-overflow.html: * fast/viewport/ios/shrink-to-fit-for-page-without-viewport-meta.html: * fast/viewport/ios/shrink-to-fit-large-content-width.html: * fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta.html: * fast/viewport/ios/viewport-shrink-to-fit-on-new-navigation.html: * fast/viewport/viewport-128.html: * fast/workers/worker-page-cache.html: * fullscreen/video-controls-drag.html: * fullscreen/video-controls-override.html: * fullscreen/video-controls-rtl.html: * fullscreen/video-controls-timeline.html: * http/tests/cache-storage/page-cache-domcache-pending-promise.html: * http/tests/cache-storage/page-cache-domcachestorage-pending-promise.html: * http/tests/cache/display-image-unset-allows-cached-image-load.html: * http/tests/eventsource/eventsource-page-cache-connected.html: * http/tests/eventsource/eventsource-page-cache-connecting.html: * http/tests/loading/main-resource-delegates-on-back-navigation.html: * http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html: * http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html: * http/tests/media/hls/video-controls-live-stream.html: * http/tests/media/hls/video-duration-accessibility.html: * http/tests/media/reload-after-dialog.html: * http/tests/media/video-auth-with-allowCrossOriginSubresourcesToAskForCredentials.html: * http/tests/misc/resources/check-keygen-post.php: * http/tests/misc/submit-post-keygen.html: * http/tests/navigation/go-back-to-error-page.html: * http/tests/navigation/https-in-page-cache.html: * http/tests/navigation/https-no-store-subframe-in-page-cache.html: * http/tests/navigation/image-load-in-pagehide-handler.html: * http/tests/navigation/page-cache-failed-xhr.html: * http/tests/navigation/page-cache-fontfaceset.html: * http/tests/navigation/page-cache-fragment-referrer.html: * http/tests/navigation/page-cache-getUserMedia-pending-promise.html: * http/tests/navigation/page-cache-iframe-no-current-historyItem.html: * http/tests/navigation/page-cache-iframe-provisional-load-async-delegates.html: * http/tests/navigation/page-cache-iframe-provisional-load.html: * http/tests/navigation/page-cache-mediakeysession.html: * http/tests/navigation/page-cache-mediastream.html: * http/tests/navigation/page-cache-pending-image-load-cache-partition.html: * http/tests/navigation/page-cache-pending-image-load.html: * http/tests/navigation/page-cache-pending-load.html: * http/tests/navigation/page-cache-pending-ping-load-cross-origin.html: * http/tests/navigation/page-cache-pending-ping-load-same-origin.html: * http/tests/navigation/page-cache-requestAnimationFrame.html: * http/tests/navigation/page-cache-video.html: * http/tests/navigation/page-cache-xhr-in-loading-iframe.html: * http/tests/navigation/page-cache-xhr-in-pagehide.html: * http/tests/navigation/page-cache-xhr.html: * http/tests/navigation/resources/https-in-page-cache-3.html: * http/tests/navigation/subframe-pagehide-handler-starts-load.html: * http/tests/navigation/subframe-pagehide-handler-starts-load2.html: * http/tests/paymentrequest/page-cache-closed-payment-request.https.html: * http/tests/paymentrequest/page-cache-completed-payment-response.https.html: * http/tests/paymentrequest/page-cache-created-payment-request.https.html: * http/tests/paymentrequest/page-cache-created-payment-response.https.html: * http/tests/paymentrequest/page-cache-interactive-payment-request.https.html: * http/tests/paymentrequest/page-cache-retried-payment-response.https.html: * http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html: * http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html: * http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html: * http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html: * http/tests/security/credentials-iframes-allowCrossOriginSubresourcesToAskForCredentials.html: * http/tests/security/cross-origin-window-open-insert-script.html: * http/tests/security/cross-origin-window-open-javascript-url.html: * http/tests/security/mixedContent/insecure-basic-auth-image-allowCrossOriginSubresourcesToAskForCredentials.https.html: * http/tests/security/mixedContent/insecure-image-redirects-to-basic-auth-secure-image-allowCrossOriginSubresourcesToAskForCredentials.html: * http/tests/security/mixedContent/secure-redirect-to-insecure-redirect-to-basic-auth-secure-image-allowCrossOriginSubresourcesToAskForCredentials.https.html: * http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-insecure-image-allowCrossOriginSubresourcesToAskForCredentials.https.html: * http/tests/security/mixedContent/secure-redirect-to-secure-redirect-to-basic-auth-secure-image-allowCrossOriginSubresourcesToAskForCredentials.https.html: * http/tests/security/navigate-when-restoring-cached-page.html: * http/tests/security/xss-DENIED-click-and-form-submission-from-inactive-domwindow.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html: * http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html: * http/tests/ssl/applepay/page-cache-active-apple-pay-session.html: * http/tests/ssl/applepay/page-cache-inactive-apple-pay-session.html: * http/tests/websocket/tests/hybi/closed-when-entering-page-cache.html: * http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html: * http/tests/workers/service/client-added-to-clients-when-restored-from-page-cache.html: * http/tests/workers/service/client-removed-from-clients-while-in-page-cache.html: * http/tests/workers/service/page-cache-service-worker-pending-promise.https.html: * http/tests/workers/service/page-caching.html: * http/wpt/beacon/support/sendBeacon-onpagehide-window.html: * http/wpt/fetch/resources/fetch-in-pagehide-window.html: * http/wpt/notifications/constructor-basic-bfcache.html: * http/wpt/service-workers/mac/throttleable.https.html: * http/wpt/service-workers/service-worker-spinning-activate.https.html: * http/wpt/service-workers/service-worker-spinning-fetch.https.html: * http/wpt/service-workers/service-worker-spinning-install.https.html: * http/wpt/service-workers/service-worker-spinning-message.https.html: * imported/blink/fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html: * imported/blink/fast/dom/shadow/shadowdom-for-keygen-only-shadow.html: * imported/blink/fast/text/international-iteration-simple-text.html: * inspector/css/pseudo-element-matches.html: * intersection-observer/intersection-observer-entry-interface.html: * intersection-observer/intersection-observer-interface.html: * intersection-observer/root-element-deleted.html: * intersection-observer/root-element-moved.html: * intersection-observer/target-deleted.html: * js/dom/regress-157246.html: * loader/go-back-cached-main-resource.html: * loader/go-back-to-different-window-size.html: * media/accessibility-closed-captions-has-aria-owns.html: * media/adopt-node-crash.html: * media/airplay-allows-buffering.html: * media/airplay-autoplay.html: * media/audio-as-video-fullscreen.html: * media/audio-controls-do-not-fade-out.html: * media/audio-controls-rendering.html: * media/audio-controls-timeline-in-media-document.html: * media/audio-delete-while-slider-thumb-clicked.html: * media/audio-repaint.html: * media/click-placeholder-not-pausing.html: * media/click-volume-bar-not-pausing.html: * media/controls-after-reload.html: * media/controls-drag-timebar.html: * media/controls-right-click-on-timebar.html: * media/controls-strict.html: * media/controls-styling.html: * media/controls-without-preload.html: * media/controls/airplay-controls.html: * media/controls/airplay-picker.html: * media/controls/basic.html: * media/controls/elementOrder.html: * media/controls/forced-tracks-only.html: * media/controls/fullscreen-button-inline-layout.html: * media/controls/inline-elements-dropoff-order.html: * media/controls/picture-in-picture.html: * media/controls/pip-placeholder-without-video-controls.html: * media/controls/showControlsButton.html: * media/controls/statusDisplay.html: * media/controls/statusDisplayBad.html: * media/controls/track-menu.html: * media/crash-closing-page-with-media-as-plugin-fallback.html: * media/mac/controls-panel-not-clipped-out-expected.html: * media/mac/controls-panel-not-clipped-out.html: * media/media-captions-no-controls.html: * media/media-controller-drag-crash.html: * media/media-controls-accessibility.html: * media/media-controls-cancel-events.html: * media/media-controls-clone.html: * media/media-controls-drag-timeline-set-controls-property.html: * media/media-controls-timeline-updates-after-playing.html: * media/media-controls-timeline-updates-when-hovered.html: * media/media-controls-timeline-updates.html: * media/media-document-audio-controls-visible.html: * media/media-document-audio-repaint.html: * media/media-fullscreen-loop-inline.html: * media/media-fullscreen-pause-inline.html: * media/media-fullscreen-return-to-inline.html: * media/media-source/media-source-page-cache.html: * media/nodesFromRect-shadowContent.html: * media/progress-events-generated-correctly.html: * media/require-user-gesture-to-load-video.html: * media/restore-from-page-cache.html: * media/tab-focus-inside-media-elements.html: * media/track/track-cue-rendering-horizontal.html: * media/track/track-cue-rendering-snap-to-lines-not-set.html: * media/track/track-cue-rendering-vertical.html: * media/track/track-cues-cuechange.html: * media/track/track-cues-enter-exit.html: * media/track/track-in-band-duplicate-tracks-when-source-changes.html: * media/track/track-manual-mode.html: * media/video-click-dblckick-standalone.html: * media/video-controls-audiotracks-trackmenu.html: * media/video-controls-captions-trackmenu-localized.html: * media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html: * media/video-controls-captions-trackmenu-sorted.html: * media/video-controls-captions-trackmenu.html: * media/video-controls-drop-and-restore-timeline.html: * media/video-controls-in-media-document.html: * media/video-controls-no-display-with-text-track.html: * media/video-controls-rendering.html: * media/video-controls-show-on-kb-or-ax-event.html: * media/video-controls-toggling.html: * media/video-controls-transformed.html: * media/video-controls-visible-audio-only.html: * media/video-controls-visible-exiting-fullscreen.html: * media/video-controls-zoomed.html: * media/video-display-toggle.html: * media/video-empty-source.html: * media/video-fullscreen-only-controls.html: * media/video-fullscreen-only-playback.html: * media/video-initially-hidden-volume-slider-up.html: * media/video-no-audio.html: * media/video-play-audio-require-user-gesture.html: * media/video-play-require-user-gesture.html: * media/video-trackmenu-selection.html: * media/video-volume-slider-drag.html: * media/video-volume-slider.html: * media/video-zoom-controls.html: * media/volume-bar-empty-when-muted.html: * platform/ios/ios/fixed/fixed-back-forward.html: * platform/ios/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html: * platform/ios/mediastream/audio-muted-in-background-tab-gpu-process.html: * platform/ios/mediastream/audio-muted-in-background-tab.html: * platform/ios/mediastream/getUserMedia-single-capture-gpu-process.html: * platform/ios/mediastream/getUserMedia-single-capture.html: * platform/ipad/fast/viewport/meta-viewport-ignored.html: * platform/ipad/fast/viewport/viewport-overriden-by-minimum-effective-width-if-ignore-meta-viewport.html: * plugins/crash-restoring-plugin-page-from-page-cache.html: * plugins/frameset-with-plugin-frame.html: * plugins/netscape-plugin-page-cache-works.html: * requestidlecallback/requestidlecallback-in-page-cache.html: * storage/indexeddb/IDBRequest-page-cache.html: * storage/indexeddb/IDBTransaction-page-cache.html: * svg/dom/css-animate-input-foucs-crash.html: * swipe/basic-cached-back-swipe.html: * swipe/main-frame-pinning-requirement.html: * swipe/pushState-cached-back-swipe.html: * swipe/pushState-programmatic-back-while-swiping-crash.html: * swipe/pushstate-with-manual-scrollrestoration.html: * tiled-drawing/scrolling/null-parent-back-crash.html: * tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html: * webanimations/animation-page-cache.html: * webrtc/datachannel/datachannel-page-cache-send.html: * webrtc/datachannel/datachannel-page-cache.html: * webrtc/peerconnection-new-candidate-page-cache.html: * webrtc/peerconnection-page-cache-long.html: * webrtc/peerconnection-page-cache.html: * webrtc/video-rotation-no-cvo.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

commit-queue@webkit.org

commit sha 418a6507ab29effab0467f274b0cd45c55e50760

Allow legacy custom scheme registration on non-main threads https://bugs.webkit.org/show_bug.cgi?id=217656 <rdar://problem/70228036> Patch by Alex Christensen <achristensen@webkit.org> on 2020-10-13 Reviewed by Brady Eidson. r267802 was quite necessary, but it exposed an internal client calling our API on a background thread, which crashes now. Make it not crash. There is a race condition in their registration, but there already was. * UIProcess/API/Cocoa/WKBrowsingContextController.mm: (+[WKBrowsingContextController registerSchemeForCustomProtocol:]): (+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

lmoura@igalia.com

commit sha c0385655f849783d8b007af2512d234bf7d8e46d

webkitpy: Log and report webdriver harness errors https://bugs.webkit.org/show_bug.cgi?id=217659 Reviewed by Jonathan Bedard. * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: (WebDriverTestRunner.process_results): Report failed harness tests, not just subtests. * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py: (WebDriverTestRunnerW3C.run): Print to error log when a test run fails, not just subtests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

tsavell@apple.com

commit sha c17eb68ea26b8829a45fa28476a26f7b9f1b4d83

REGRESSION: [ Mac iOS ] fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html is flaky timeout https://bugs.webkit.org/show_bug.cgi?id=217618 Unreviewed test Gardening. * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

tsavell@apple.com

commit sha 15ac8f9d26770a3e3b7098a3f0dc9d18f5158e54

REGRESSION: [ Mac ] inspector/audit/basic-async.htm is flaky timeout https://bugs.webkit.org/show_bug.cgi?id=217620 Unreviewed test gardening. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

cdumez@apple.com

commit sha cdc3b462060f8a5e886f48a983ef0940d7039c56

'parameters' argument to AudioWorkletProcessor.process() is not spec-compliant https://bugs.webkit.org/show_bug.cgi?id=217637 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline WPT tests that are now passing. * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audioworklet-connections.https-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-audioworklet.https-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam-size.https-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-audioparam.https-expected.txt: * web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-channel-count.https-expected.txt: Source/WebCore: 'parameters' argument to AudioWorkletProcessor.process() is not spec-compliant: - https://www.w3.org/TR/webaudio/#dom-audioworkletprocessor-process-inputs-outputs-parameters-parameters Its type should not be a JS Map, as evidenced by how WPT tests use it. We now pass a generic JS Object, as Blink is doing. Also, as per the specification, if no automation is scheduled during the render quantum, the array may have length 1 with the array element being the constant value of the AudioParam for the render quantum. No new tests, rebaselined existing tests. * Modules/webaudio/AudioParam.cpp: (WebCore::AudioParam::hasSampleAccurateValues): * Modules/webaudio/AudioParam.h: * Modules/webaudio/AudioParamTimeline.cpp: (WebCore::AudioParamTimeline::hasValues const): * Modules/webaudio/AudioParamTimeline.h: This is an optimization to avoid calculating sample accurate values if the first timeline event is still in the future. At some point, we should consider improving the logic to do so when all events are in the past, similarly to what Blink is doing. * Modules/webaudio/AudioWorkletNode.cpp: (WebCore::AudioWorkletNode::initializeAudioParameters): Do not initialize memory for the AudioFloatArrays of each AudioParam yet since we won't know until process() is called if size will be 1 or renderQuantumSize and since the size can change dynamically. (WebCore::AudioWorkletNode::process): As per the specification, if there is no timeline event, we pass an array that has length 1 and whose element is the constant value. * Modules/webaudio/AudioWorkletProcessor.cpp: (WebCore::constructFrozenKeyValueObject): (WebCore::AudioWorkletProcessor::process): Instead of passing the parameters as a JS map, we now use a simple frozen object. We also make sure the Float32Array we pass JS has length 1 if the input array constains a constant value. This behavior is consistent with what Blink is doing. * Modules/webaudio/DelayDSPKernel.cpp: (WebCore::DelayDSPKernel::DelayDSPKernel): * Modules/webaudio/RealtimeAnalyser.cpp: (WebCore::RealtimeAnalyser::setFftSize): * platform/audio/AudioArray.h: (WebCore::AudioArray::AudioArray): (WebCore::AudioArray::resize): (WebCore::AudioArray::at): (WebCore::AudioArray::zero): (WebCore::AudioArray::zeroRange): (WebCore::AudioArray::copyToRange): (WebCore::AudioArray::containsConstantValue const): * platform/audio/Biquad.cpp: (WebCore::Biquad::Biquad): * platform/audio/ReverbConvolverStage.cpp: (WebCore::ReverbConvolverStage::ReverbConvolverStage): * platform/audio/ios/AudioFileReaderIOS.cpp: (WebCore::AudioFileReader::createBus): * platform/audio/mac/AudioFileReaderMac.cpp: (WebCore::AudioFileReader::createBus): Rename AudioArray::allocate() to AudioArray::resize() for clarity since it can be called multiple times after construction of the AudioArray. Make it a no-op if the new size is the same as the old one. Also add a utility function to check if the array constains a constant value. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

Hironori.Fujii@sony.com

commit sha 6977cf18603d20d2a7846881a669fd45205b520b

[WinCairo][MediaFoundation] Many test cases are timing out by waiting for events https://bugs.webkit.org/show_bug.cgi?id=217463 Reviewed by Don Olmstead. Source/WebCore: The ended event wasn't dispatched because MediaFoundation winds back currentTime to 0 at the end of play back. The currentTime should keep the position. Added m_sessionEnded to return the duration in currentTime() if m_sessionEnded is true. currentTime() didn't work for audio elements because m_presenter is available only for videos. Use IMFMediaSession::GetClock instead. seek() started play back even if it is paused. Added m_seeking to remember it is seeking and pause the session in onSessionStarted if m_seeking and m_paused are true. Update NetworkState properly. Return NetworkState::FormatError on MF_E_TOPO_CODEC_NOT_FOUND, NetworkState::DecodeError on MEError event. MEError event with MF_E_NOT_INITIALIZED status was dispatch if SetVideoPosition is called while the session is not started. Deffer calling SetVideoPosition to onSessionStarted. * platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp: (WebCore::MediaPlayerPrivateMediaFoundation::MediaPlayerPrivateMediaFoundation): (WebCore::MediaPlayerPrivateMediaFoundation::play): (WebCore::MediaPlayerPrivateMediaFoundation::seeking const): (WebCore::MediaPlayerPrivateMediaFoundation::seek): (WebCore::MediaPlayerPrivateMediaFoundation::currentTime const): (WebCore::MediaPlayerPrivateMediaFoundation::buffered const): (WebCore::MediaPlayerPrivateMediaFoundation::setSize): (WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource): (WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent): (WebCore::MediaPlayerPrivateMediaFoundation::updateReadyState): (WebCore::MediaPlayerPrivateMediaFoundation::onTopologySet): (WebCore::MediaPlayerPrivateMediaFoundation::onSessionStarted): (WebCore::MediaPlayerPrivateMediaFoundation::onSessionEnded): (WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::currentTime): Deleted. * platform/graphics/win/MediaPlayerPrivateMediaFoundation.h: LayoutTests: * platform/wincairo/TestExpectations: Unskip media tests. Marked failing tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

simon.fraser@apple.com

commit sha 962b8cf5a7afdd715706a27d28142321d1f43897

Plumb OptionSet<WheelEventProcessingSteps> through the wheel event handling code https://bugs.webkit.org/show_bug.cgi?id=217660 Reviewed by Tim Horton. Source/WebCore: Async scrolling in passive wheel event regions will require that the main thread event handling code knows that the scrolling thread did the scrolling. To propagate this information, plumb OptionSet<WheelEventProcessingSteps> through. No behavior change. * page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::passWheelEventToWidget): * page/EventHandler.h: * page/ios/EventHandlerIOS.mm: (WebCore::EventHandler::wheelEvent): (WebCore::EventHandler::passWheelEventToWidget): * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::wheelEvent): (WebCore::EventHandler::passWheelEventToWidget): * page/scrolling/ScrollingTree.cpp: (WebCore::ScrollingTree::determineWheelEventProcessing): (WebCore::ScrollingTree::handleWheelEvent): * page/scrolling/ScrollingTree.h: (WebCore::WheelEventHandlingResult::handled): (WebCore::WheelEventHandlingResult::unhandled): (WebCore::ScrollingTree::handleWheelEvent): * page/scrolling/ThreadedScrollingTree.cpp: (WebCore::ThreadedScrollingTree::handleWheelEvent): * page/scrolling/ThreadedScrollingTree.h: * platform/PlatformWheelEvent.cpp: (WebCore::operator<<): * replay/UserInputBridge.cpp: (WebCore::UserInputBridge::handleWheelEvent): * replay/UserInputBridge.h: Source/WebKit: Async scrolling in passive wheel event regions will require that the main thread event handling code knows that the scrolling thread did the scrolling. To propagate this information, plumb OptionSet<WheelEventProcessingSteps> through. No behavior change. * WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::wheelEvent): (WebKit::EventDispatcher::dispatchWheelEventViaMainThread): (WebKit::EventDispatcher::dispatchWheelEvent): * WebProcess/WebPage/EventDispatcher.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::handleWheelEvent): (WebKit::WebPage::wheelEvent): * WebProcess/WebPage/WebPage.h: Source/WebKitLegacy/win: * WebView.cpp: (WebView::mouseWheel): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

krollin@apple.com

commit sha 3a9b5c3b056fd67b4d419be073b4fb397e11ed1c

Remove leftover MACOSX_DEPLOYMENT_TARGET_macosx support https://bugs.webkit.org/show_bug.cgi?id=217649 <rdar://problem/70236877> Reviewed by Darin Adler. Bug 42796 introduced MACOSX_DEPLOYMENT_TARGET_<PLATFORM> as "support for compiling WebKit against iOS SDKs". Support for the iOS part of this feature was later removed in several changes, including Bug 139212, Bug 139463 and Bug 144762. However, vestiges have remained for five or six years in the form of MACOSX_DEPLOYMENT_TARGET_macosx. The inclusion of the platform in MACOSX_DEPLOYMENT_TARGET is no longer needed and can be removed. This changes brings most projects in conformance with other projects that don't support including the platform in MACOSX_DEPLOYMENT_TARGET, including WebEditingTester, gtest, WebKitTestRunner, MiniBrowser, and TestWebKitAPI. Along the way, remove a couple of left-over references to macOS 10.16, and a couple of places where [sdk=macosx*] was still being used. With this change, initialization of MACOSX_DEPLOYMENT_TARGET should be consistent across all projects, with two exceptions: WebKitLauncher (which hardcodes it to 10.12) and libwebrtc's copy of googletest (which hardcodes it to 10.4). The reasons for these hard-coded values is not apparent, so leave them be. PerformanceTests: * DecoderTest/Configurations/DebugRelease.xcconfig: * MediaTime/Configurations/DebugRelease.xcconfig: Source/bmalloc: * Configurations/DebugRelease.xcconfig: Source/JavaScriptCore: * Configurations/DebugRelease.xcconfig: Source/ThirdParty/ANGLE: * Configurations/DebugRelease.xcconfig: Source/ThirdParty/libwebrtc: * Configurations/DebugRelease.xcconfig: Source/WebCore: No new tests -- no changed functionality. * Configurations/DebugRelease.xcconfig: Source/WebCore/PAL: * Configurations/DebugRelease.xcconfig: Source/WebInspectorUI: * Configurations/DebugRelease.xcconfig: Source/WebKit: * Configurations/DebugRelease.xcconfig: Source/WebKitLegacy/mac: * Configurations/DebugRelease.xcconfig: Source/WTF: * Configurations/DebugRelease.xcconfig: Tools: * ContentExtensionTester/Configurations/DebugRelease.xcconfig: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * ImageDiff/cg/Configurations/DebugRelease.xcconfig: * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

pvollan@apple.com

commit sha e3ad4ac9645927289944d27d0fd0348d916d7c9c

[iOS 14] Hang in -[WKUserDefaults _notifyObserversOfChangeFromValuesForKeys:toValuesForKeys:] https://bugs.webkit.org/show_bug.cgi?id=217183 <rdar://problem/69916673> Reviewed by Geoffrey Garen. Dispatch this work on a non-main thread, in order to avoid blocking the main thread. * UIProcess/Cocoa/PreferenceObserver.mm: (-[WKUserDefaults _notifyObserversOfChangeFromValuesForKeys:toValuesForKeys:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

rackler@apple.com

commit sha ebfe8ec99118e780c3d047c15d52539f1712e4ec

REGRESSION (iOS 14): [ iOS wk2 ] service-workers-spinning tests are flaky failures https://bugs.webkit.org/show_bug.cgi?id=217669 Unreviewed test gardening. * platform/ios-simulator-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

cdumez@apple.com

commit sha 9a7ea8d1cd0c2f19cc1752e499b7275e0d0af760

WebAudio tests are crashing in debug when enabling the GPU process https://bugs.webkit.org/show_bug.cgi?id=217663 Reviewed by Geoff Garen. Source/WebCore: No new tests, unskipped existing tests. * WebCore.xcodeproj/project.pbxproj: * platform/audio/PushPullFIFO.h: Export PushPullFIFO so that it can be used at WebKit layer. Source/WebKit: WebAudio tests were crashing in debug when enabling the GPU process because it did audio processing on the WebContent process's main thread. To address the issue, I made RemoteAudioDestinationProxy a ThreadMessageReceiver so that it receives IPC on an audio thread instead of the main thread. IPC messages are processed directly on the AudioWorklet thread when active or on an audio thread constructed by RemoteAudioDestinationProxy otherwise. * GPUProcess/media/RemoteAudioDestinationManager.cpp: (WebKit::RemoteAudioDestination::RemoteAudioDestination): Use a PushPullFIFO structure in render() to avoid hanging the audio rendering thread on a semaphore. Hanging the rendering thread was terrible for performance and was also a source of deadlock since the underlying framework is holding a lock while render() is called. We could process a RemoteAudioDestination::CreateAudioDestination sync IPC on the main thread and deadlock on that lock. * GPUProcess/webrtc/LibWebRTCCodecsProxy.h: * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h: * GPUProcess/webrtc/RemoteSampleBufferDisplayLayerManager.h: * NetworkProcess/IndexedDB/WebIDBServer.h: * NetworkProcess/webrtc/NetworkRTCProvider.h: * WebProcess/Network/webrtc/LibWebRTCNetwork.h: * WebProcess/cocoa/RemoteCaptureSampleManager.h: Use ThreadMessageReceiverRefCounted instead of ThreadMessageReceiver since those classes do not provide their own RefCounting. * Platform/IPC/Connection.cpp: (IPC::Connection::addWorkQueueMessageReceiver): (IPC::Connection::removeWorkQueueMessageReceiver): (IPC::Connection::addThreadMessageReceiver): (IPC::Connection::removeThreadMessageReceiver): (IPC::Connection::processIncomingMessage): (IPC::Connection::dispatchMessageToWorkQueueReceiver): (IPC::Connection::dispatchMessageToThreadReceiver): * Platform/IPC/Connection.h: (IPC::Connection::ThreadMessageReceiver::ref): (IPC::Connection::ThreadMessageReceiver::deref): - Add support for passing a destinationID when registering a WorkQueueMessageReceiver or a ThreadMessageReceiver, similarly to regular MessageReceivers. This was needed here since The GPUProcess sends IPC messages to the RemoteAudioDestinationProxy with a given destinationID and since RemoteAudioDestinationProxy is now a ThreadMessageReceiver. - Stop having ThreadMessageReceiver subclass ThreadSafeRefCounted since RemoteAudioDestinationProxy already subclasses ThreadSafeRefCounted indirectly. A new ThreadMessageReceiverRefCounted class was added for convenience for existing code that relied on its refcounting. * WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp: (WebKit::RemoteAudioDestinationProxy::RemoteAudioDestinationProxy): (WebKit::RemoteAudioDestinationProxy::~RemoteAudioDestinationProxy): (WebKit::RemoteAudioDestinationProxy::start): (WebKit::RemoteAudioDestinationProxy::stop): (WebKit::RemoteAudioDestinationProxy::renderBuffer): (WebKit::RemoteAudioDestinationProxy::didChangeIsPlaying): (WebKit::RemoteAudioDestinationProxy::dispatchToThread): * WebProcess/GPU/media/RemoteAudioDestinationProxy.h: Use a PushPullFIFO container in render() to avoid handing the audio rendering thread on a semaphore while the Render IPC is getting processed by the WebProcess. Source/WTF: * wtf/CrossThreadQueue.h: (WTF::CrossThreadQueue<DataType>::waitForMessage): If CrossThreadQueue::kill() gets called while another thread is waiting on a CrossThreadQueue::waitForMessage() call, make it so that waitForMessage() returns a default-constructed DataType instead of crashing trying to dequeue (since the queue is empty). LayoutTests: Unskip webaudio tests when the GPU process is enabled. * gpu-process/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

cdumez@apple.com

commit sha f7974cbb98c3221ed82d63dc0fcd7349c099e05f

It should be possible to create an AudioWorkletNode for a context that has finished rendering https://bugs.webkit.org/show_bug.cgi?id=217666 Reviewed by Eric Carlson. LayoutTests/imported/w3c: Rebaseline WPT test that is now passing. * web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/suspended-context-messageport.https-expected.txt: Source/WebCore: It should be possible to create an AudioWorkletNode for a context that has finished rendering. We were previously throwing an exception when trying to create an AudioWorkletNode for a context whose state is "closed" (OfflineAudioContext's state becomes closed as soon as rendering finishes). This was causing us to fail a WPT test and did not match Blink's behavior. No new tests, rebaselined existing test. * Modules/webaudio/AudioWorkletNode.cpp: (WebCore::AudioWorkletNode::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

push time in 4 days

issue commentIgalia/meta-webkit

Failed to render on the iMX8

There might be a way to upstream this without ifdef. The player has some code already detecting imxvpudec at runtime (look for ImxVPU in the player), so the sink could perhaps dynamically add those elements... It might require a pad probe, I think...

pcjustin

comment created time in 7 days

push eventphiln/libwpe

Philippe Normand

commit sha 50b2751bbf6a3cf5fb8a7e4af911426fe9482590

wip

view details

push time in 7 days

push eventphiln/libwpe

Philippe Normand

commit sha feb43d6bba773e6fdb6d6f39a3dad521cbc43cb4

wip

view details

push time in 7 days

push eventphiln/libwpe

Philippe Normand

commit sha a058cd4d6242e8148106baafb3f6316f3e6fa47a

wip

view details

push time in 7 days

push eventphiln/libwpe

Philippe Normand

commit sha 901c1a74aca86b4b626aebcf5262a8b6ec6eaca5

wip

view details

push time in 7 days

push eventphiln/libwpe

Philippe Normand

commit sha aaa9b696c5d6ad9c741debb1ba83a3b315f283d7

wip

view details

push time in 7 days

push eventphiln/libwpe

Philippe Normand

commit sha 26178b4430c62c2f51805c3069ae52fbfaaa665b

boom

view details

push time in 7 days

create barnchIgalia/WPEBackend-fdo

branch : philn/boom

created branch time in 7 days

create barnchphiln/libwpe

branch : philn/boom

created branch time in 7 days

issue commentIgalia/meta-webkit

Failed to render on the iMX8

Might fit behind ifdefs in WebKit's GL video sink bin.

pcjustin

comment created time in 9 days

push eventphiln/glide

Ezequiel Garcia

commit sha 02386804c084586d8aff1373d080bbe32802abe2

scripts: Require bash for bash extension [[ (#33) We need a Bash shell for the [[ syntax. See https://www.gnu.org/software/bash/manual/html_node/Conditional-Constructs.html#index-_005b_005b. Fixes #24

view details

push time in 11 days

PR merged philn/glide

scripts: Require bash for bash extension [[

We need a Bash shell for the [[ syntax. See https://www.gnu.org/software/bash/manual/html_node/Conditional-Constructs.html#index-_005b_005b.

Fixes #24

+1 -1

0 comment

1 changed file

ezequielgarcia

pr closed time in 11 days

issue closedphiln/glide

Problem with shell scripts on Debian

The build scripts start:

#!/bin/sh

but use Bash features such as [[. This fails on Debian since /bin/sh is Dash and not Bash:

|> ninja
[0/1] Generating cargo-build with a custom command.
/home/Checkouts/Git/Glide/scripts/cargo.sh: 5: /home/Checkouts/Git/Glide/scripts/cargo.sh: [[: not found
RELEASE MODE
    Updating crates.io index
  Downloaded serde_json v1.0.38
…

closed time in 11 days

russel

issue commentIgalia/cog

i.MX6QDL video render issue

Why do I see an avdec_vp9 decoder in your pipeline then? :)

otavio

comment created time in 13 days

issue commentIgalia/cog

i.MX6QDL video render issue

Try to download this video with youtube-dl, pick the VP9 version and try to play it with gst-play-1.0 as I commented before. Compare the pipelines too, specifically the video decoder being used and downstream converters.

otavio

comment created time in 13 days

issue commentIgalia/cog

i.MX6QDL video render issue

The same asset plays fine in gst-play then?

Can you provide a pipeline dump? See https://github.com/Igalia/meta-webkit/wiki/Providing-useful-GStreamer-Zero-copy-issue-reports

otavio

comment created time in 13 days

issue commentIgalia/cog

i.MX6QDL video render issue

No issue with gst-play-1.0 --videosink glimagesink <url> ?

otavio

comment created time in 13 days

PR opened Igalia/wpewebkit.org

WIP: about: architecture docs

This is WIP and request for feedback, please don't merge yet.

+58 -3

0 comment

2 changed files

pr created time in 14 days

create barnchIgalia/wpewebkit.org

branch : arch-doc

created branch time in 14 days

PR opened Igalia/wpewebkit.org

Reviewers
about: Add more Flatpak-related docs

Fixes #38

+92 -1

0 comment

2 changed files

pr created time in 14 days

create barnchIgalia/wpewebkit.org

branch : flatpak

created branch time in 14 days

issue commentsonnyp/Tangram

Can't add more than 1 tab

Problem appears because https://twitter.com/manifest.json doesn't reply with content-length HTTP header anymore.

Checking here with curl -v, I do see a content-length response header.

Kekun

comment created time in 16 days

create barnchphiln/webkit

branch : media-recorder

created branch time in 16 days

push eventphiln/glide

Philippe Normand

commit sha 32d22616a28f6d1bdc46fb434541c2ad4ebf148a

README: Add Flatpak instructions

view details

push time in 17 days

push eventphiln/glide

Artem Polishchuk

commit sha 59df2173d979dd65976544bc569a8e3de673125a

Add Fedora installation instructions (#32) Add Fedora installation instructions

view details

push time in 17 days

PR merged philn/glide

Add Fedora installation instructions

Packaged in COPR for Fedora.

+10 -2

0 comment

1 changed file

tim77

pr closed time in 17 days

Pull request review commentphiln/glide

Add Fedora installation instructions

 encouraged to file issues on the Github bug tracker of course. Installation ------------ -Currently Glide isn't packaged for any Linux distribution or macOS-package manager. So the only way to install it is with Cargo:+Install it is with Cargo:

s/is//

tim77

comment created time in 17 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentsonnyp/Tangram

Can't add more than 1 tab

I wasn't able to add Twitter either. Have no FB, so haven't tried. IIRC there's a GJS stack-trace reported in the journal about Twitter.

Kekun

comment created time in 17 days

delete branch Igalia/WPEBackend-fdo

delete branch : libwpe-fallback

delete time in 17 days

delete branch philn/libwpe

delete branch : meson-dep

delete time in 17 days

push eventIgalia/WPEBackend-fdo

Philippe Normand

commit sha e06b535d711ad97df6834d49b1e55283a3f65d5b

meson: Allow fallback to libwpe subproject WPEBackend-FDO currently doesn't provide Meson subprojects, but the fallback could be used from a Meson "super-project" that could provide a libwpe.wrap file. Also bump required version to 1.6.0, 1.5.90 was a pre-release.

view details

push time in 17 days

PR opened Igalia/WPEBackend-fdo

Reviewers
WIP: meson: Add libwpe as subproject

Depends on https://github.com/WebPlatformForEmbedded/libwpe/pull/72

+6 -1

0 comment

3 changed files

pr created time in 17 days

create barnchIgalia/WPEBackend-fdo

branch : libwpe-fallback

created branch time in 17 days

pull request commentWebPlatformForEmbedded/libwpe

meson: Expose dependency for use as subproject

r? @aperezdc

philn

comment created time in 17 days

PR opened WebPlatformForEmbedded/libwpe

meson: Expose dependency for use as subproject

This is needed so that WPEBackend-FDO and/or gst-build could fallback to build libwpe as subproject if its version on the host system is too old.

+5 -0

0 comment

1 changed file

pr created time in 17 days

create barnchphiln/libwpe

branch : meson-dep

created branch time in 17 days

fork philn/libwpe

General-purpose library specifically developed for the WPE-flavored port of WebKit.

fork in 17 days

push eventphiln/playwright

Darío Kondratiuk

commit sha ff2c2b299f094bfb9b777c84f4e412f23c0fd77a

test: Fix insertText test title (#3386)

view details

Dmitry Gozman

commit sha 9697ad635fc67cce667dc14d658fcdedba9ede47

fix(chromium): handle the case when new pending comes before old commit (#3370)

view details

Pavel Feldman

commit sha bfdb59eadaf7f4c90bb18edcaf12eb18e851060f

test: make mocha runner work in parallel (#3383)

view details

Andrey Lushnikov

commit sha 2db97e3b2d1f46b93f100213f2779e6c3f8a9ce7

feat(firefox): migrate to protocol-based proxy implementation (#3362) This migrates Firefox to the protocol-based proxy implementation. Benefits: - supports secure web proxies (already supported by Chromium) - unlocks support for SOCKS proxies with authentication

view details

Yury Semikhatsky

commit sha 812d7eefe9333cf286fff55e4015879cf77e340e

feat(webkit): bump to 1325 (#3388)

view details

Joel Einbinder

commit sha 55a78482e40484f80138f9c2a29bae317215e03e

fix(types): fix type generation to make ts tests work (#3385)

view details

Arjun Attam

commit sha 9375cc62b8d846b9f4b7060dee8864c48e40d47c

docs: introduce docs for page object models (#3391)

view details

Joel Einbinder

commit sha 6054f1479472a745c96537b9d4ab65fa01aa2778

chore(tests): convert all tests to typescript (#3384)

view details

Dmitry Gozman

commit sha da95b73b59c7728e4e0fabf2df43286caac0a5e1

browser(firefox): emit iframe lifecycle when initial navigation fails (#3389)

view details

Pavel Feldman

commit sha 4061bc696ad58a423eae91e1f8e44d5920c466dc

test: make fit run single test (#3394)

view details

Andrey Lushnikov

commit sha c035560389c1c75e8aaab2a9c83dd333138cc28c

fix: full path to `ldconfig` in linux (#3401)

view details

Joel Einbinder

commit sha 1ef199f512f0d6da0d3fadd883c4b8efede3c0f3

fix(launchDoctor): add sudo to install missing packages hint (#3402)

view details

Andrey Lushnikov

commit sha 915902c8588bc77cfd1afdaf7a4440511f7787ff

browser(firefox): roll Firefox to roughly July, 15 (#3411)

view details

Yury Semikhatsky

commit sha 16b471fac60a6f432633e15464e3d3e85c0aad3d

test(screencast): video recording during cros-process navigation (#3396)

view details

Ross Wollman

commit sha 079b6e0a66d21ea2ddfc4e559bd96053281db396

docs: add getting help section (#3410) The Playwright Community is awesome and responsive! <3 Let's make the community as a resource more prominent in the docs. (Currently they just appear in a footer, but this change calls it out explicitly.)

view details

Pavel Feldman

commit sha 7e07634cc6c36a330b5e74f3d7bc4e5faf720e6f

test: use mocha in ci/cd (#3406)

view details

Pavel Feldman

commit sha 962ddc09c437109c7186b8b365f96453b242a668

test: consolidate runner files (#3415)

view details

Arjun Attam

commit sha be7db4d2c6d5179678110bacaca2228b31383607

docs(ci): add sample config for jenkins (#3398)

view details

Dmitry Shcherbakov

commit sha 22d1be32fb71d3e537ece66d84687b07c34af985

docs: add showcase how to use allure-report and jest-circus with playwright (#3408)

view details

Dmitry Gozman

commit sha adfeaa49edf50eba0f656fa285ac0ad71469504a

feat(firefox): bump to 1157 (#3395)

view details

push time in 17 days

issue commentsonnyp/Tangram

Slack web sockets aren't working

Fix: https://trac.webkit.org/changeset/267620/webkit will be shipped in 2.30.2.

mmstick

comment created time in 21 days

issue commentIgalia/meta-webkit

Failed to render on the iMX8

If this works and playbin plugs the vivante plugin, it work the same way in WPE... gst-play-1.0 --videosink glimagesink /path/to/video.mp4 By setting this var GST_DEBUG_DUMP_DOT_DIR=/tmp you will get graphviz pipeline dumps that you can inspect to check the pipeline topology includes the decoder you want. or not.

pcjustin

comment created time in 21 days

create barnchphiln/webkit

branch : libportal

created branch time in 25 days

push eventphiln/webkit

pvollan@apple.com

commit sha 6f5a05d28688789fc552ed62b7bcc1ce3b49f332

[macOS] Start collecting telemetry from a set of XPC services <https://bugs.webkit.org/show_bug.cgi?id=216797> Reviewed by Brent Fulgham. * WebProcess/com.apple.WebProcess.sb.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

peng.liu6@apple.com

commit sha 1afe3c5e237c48c1d5a7995ab9629ef1ab4601c4

[Media in GPU Process] Implement caption support in video fullscreen and PiP https://bugs.webkit.org/show_bug.cgi?id=208752 Reviewed by Eric Carlson. Source/WebCore: Export TextTrackRepresentation so that WebKit can use it. Also, update the interface of VideoLayerManagerObjC related to text track representation to use PlatformLayer* instead of TextTrackRepresentation*. Manually tested. * WebCore.xcodeproj/project.pbxproj: Change target membership of TextTrackRepresentation.h. * platform/graphics/avfoundation/objc/VideoLayerManagerObjC.h: * platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm: (WebCore::VideoLayerManagerObjC::setTextTrackRepresentationLayer): (WebCore::VideoLayerManagerObjC::setTextTrackRepresentation): Deleted. Replace setTextTrackRepresentation() with setTextTrackRepresentationLayer(). * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::setTextTrackRepresentation): Use VideoLayerManagerObjC::setTextTrackRepresentationLayer() instead of VideoLayerManagerObjC::setTextTrackRepresentation(). * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setTextTrackRepresentation): Ditto. Source/WebKit: * GPUProcess/media/RemoteMediaPlayerProxy.cpp: (WebKit::RemoteMediaPlayerProxy::syncTextTrackBounds): Deleted. * GPUProcess/media/RemoteMediaPlayerProxy.h: * GPUProcess/media/RemoteMediaPlayerProxy.messages.in: Remove syncTextTrackBounds() because the GPU process does not need to deal with the text track bounds. * WebProcess/GPU/GPUProcessConnection.cpp: (WebKit::GPUProcessConnection::dispatchMessage): Add a missing IPC message receiver. * WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::setVideoFullscreenLayer): Set the flag m_requiresTextTrackRepresentation when changing video presentation mode. (WebKit::MediaPlayerPrivateRemote::requiresTextTrackRepresentation const): Deleted. (WebKit::MediaPlayerPrivateRemote::setTextTrackRepresentation): Deleted. (WebKit::MediaPlayerPrivateRemote::syncTextTrackBounds): Deleted. Move the implementation of those functions to MediaPlayerPrivateRemoteCocoa. * WebProcess/GPU/media/MediaPlayerPrivateRemote.h: Add the flag m_requiresTextTrackRepresentation and add a reference to the layer used to render text track (in fullscreen or picture-in-picture). * WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm: (WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame): (WebKit::MediaPlayerPrivateRemote::setTextTrackRepresentation): (WebKit::MediaPlayerPrivateRemote::syncTextTrackBounds): Those functions share a similar implementation as VideoLayerManagerObjC. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

aakash_jain@apple.com

commit sha 9a2f96ccd6a179a94cfb906e15e5ffd61e9a62b0

Notify igalia team about pre-existing test failures and build failures for JSC queues https://bugs.webkit.org/show_bug.cgi?id=216889 Reviewed by Jonathan Bedard. * BuildSlaveSupport/ews-build/steps.py: (AnalyzeCompileWebKitResults.send_email_for_preexisting_build_failure): Send email for pre-existing jsc build failures. (AnalyzeJSCTestsResults.send_email_for_pre_existing_failure): Send email for pre-existing jsc test failure. * BuildSlaveSupport/ews-build/send_email.py: * BuildSlaveSupport/ews-build/emails.json: Added email address of igalia jsc team. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

aakash_jain@apple.com

commit sha ea64dd02c10cf5f752149254d61079c3adbebf5f

Limit number of emails to send for flaky and pre-existing API and layout test failures https://bugs.webkit.org/show_bug.cgi?id=216876 Reviewed by Jonathan Bedard. * BuildSlaveSupport/ews-build/steps.py: (ReRunWebKitTests): Simply limit the flaky failures immediately after they are calculated, since we don't display the count of flaky failures. Flaky failures are displayed only to help bot-watchers in noticing flaky tests. (AnalyzeLayoutTestsResults.report_pre_existing_failures): Limit pre-existing and flaky test failures just before sending emails. (AnalyzeAPITestsResults.analyzeResults): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

zalan@apple.com

commit sha fcb4da1eeaa411e331310d9d71acd5384692a234

[LFC][IFC] Precompute the collapsible trailing width for LineBreaker https://bugs.webkit.org/show_bug.cgi?id=216881 Reviewed by Antti Koivisto. Let's just compute the collapsible trailing width while adding inline content to LineCandidate instead of reverse looping through the runs in LineBreaker. This is also in preparation for reducing the number of RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled calls. * layout/inlineformatting/InlineLineBreaker.cpp: (WebCore::Layout::ContinuousContent::hasTrailingCollapsibleContent const): (WebCore::Layout::ContinuousContent::isFullyCollapsible const): (WebCore::Layout::LineBreaker::shouldKeepEndOfLineWhitespace const): (WebCore::Layout::LineBreaker::shouldWrapInlineContent): (WebCore::Layout::LineBreaker::tryWrappingInlineContent const): (WebCore::Layout::ContinuousContent::ContinuousContent): (WebCore::Layout::ContinuousContent::nonCollapsibleLogicalWidth const): (WebCore::Layout::ContinuousContent::isTrailingContentFullyCollapsible const): Deleted. (WebCore::Layout::ContinuousContent::TrailingCollapsibleContent::reset): Deleted. * layout/inlineformatting/InlineLineBreaker.h: * layout/inlineformatting/InlineLineBuilder.cpp: (WebCore::Layout::LineCandidate::InlineContent::collapsibleTrailingWidth const): (WebCore::Layout::LineCandidate::InlineContent::appendInlineItem): (WebCore::Layout::LineCandidate::InlineContent::reset): (WebCore::Layout::LineBuilder::handleFloatsAndInlineContent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

tzagallo@apple.com

commit sha 9ffdc920e72e263787701a2861863b2a54296f51

Missing scope release in JSDOMBuiltinConstructorBase https://bugs.webkit.org/show_bug.cgi?id=216851 <rdar://problem/69144642> Reviewed by Yusuke Suzuki. Source/WebCore: In JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments, we should release the ThrowScope before calling into JavaScript since we don't intend to handle the exception. Test: js/transform-stream.html * bindings/js/JSDOMBuiltinConstructorBase.cpp: (WebCore::JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments): LayoutTests: * js/script-tests/transform-stream.js: Added. * js/transform-stream-expected.txt: Added. * js/transform-stream.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

pvollan@apple.com

commit sha 6c7b7614f796536b3f3e924b9ea7dbdec23b5bc4

[macOS] Change name of client decoder entitlement https://bugs.webkit.org/show_bug.cgi?id=216670 <rdar://problem/69101997> Reviewed by Darin Adler. The client decoder entitlement landed in <https://trac.webkit.org/changeset/266613/webkit> has changed name, and should be updated. * Scripts/process-entitlements.sh: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

Hironori.Fujii@sony.com

commit sha 25f85eb2180cb737f9628768785cefe201cc5480

Remove ENABLE_SVG_FONTS macro https://bugs.webkit.org/show_bug.cgi?id=216850 Reviewed by Don Olmstead. .: No ports have this disabled, so remove it. * Source/cmake/OptionsFTW.cmake: * Source/cmake/OptionsMac.cmake: * Source/cmake/OptionsWin.cmake: * Source/cmake/WebKitFeatures.cmake: * Source/cmake/tools/vsprops/FeatureDefines.props: * Source/cmake/tools/vsprops/FeatureDefinesCairo.props: Source/WebCore: * CMakeLists.txt: * css/CSSFontFace.cpp: (WebCore::CSSFontFace::appendSources): (WebCore::CSSFontFace::hasSVGFontFaceSource const): * css/CSSFontFace.h: * css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::CSSFontFaceSource): (WebCore::CSSFontFaceSource::load): (WebCore::CSSFontFaceSource::font): (WebCore::CSSFontFaceSource::isSVGFontFaceSource const): * css/CSSFontFaceSource.h: * css/CSSFontFaceSrcValue.cpp: (WebCore::CSSFontFaceSrcValue::isSVGFontTarget const): (WebCore::CSSFontFaceSrcValue::isSupportedFormat const): * css/CSSFontFaceSrcValue.h: * inspector/agents/InspectorPageAgent.cpp: (WebCore::InspectorPageAgent::inspectorResourceType): * loader/LinkLoader.cpp: (WebCore::createLinkPreloadResourceClient): * loader/ResourceLoadInfo.cpp: (WebCore::ContentExtensions::toResourceType): * loader/SubresourceLoader.cpp: (WebCore::logResourceLoaded): * loader/cache/CachedResource.cpp: (WebCore::CachedResource::defaultPriorityForResourceType): (WebCore::CachedResource::isCORSSameOrigin const): * loader/cache/CachedResource.h: * loader/cache/CachedResourceLoader.cpp: (WebCore::createResource): (WebCore::CachedResourceLoader::requestFont): (WebCore::contentTypeFromResourceType): (WebCore::CachedResourceLoader::checkInsecureContent const): (WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const): (WebCore::CachedResourceLoader::shouldUpdateCachedResourceWithCurrentRequest): (WebCore::destinationForType): * loader/cache/CachedSVGFont.cpp: * loader/cache/CachedSVGFont.h: * loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::getStatistics): * rendering/svg/SVGTextLayoutEngineSpacing.cpp: * style/StyleResolver.cpp: (WebCore::Style::Resolver::addCurrentSVGFontFaceRules): * svg/SVGAltGlyphDefElement.cpp: * svg/SVGAltGlyphDefElement.h: * svg/SVGAltGlyphDefElement.idl: * svg/SVGAltGlyphElement.cpp: * svg/SVGAltGlyphElement.h: * svg/SVGAltGlyphElement.idl: * svg/SVGAltGlyphItemElement.cpp: * svg/SVGAltGlyphItemElement.h: * svg/SVGAltGlyphItemElement.idl: * svg/SVGDocumentExtensions.cpp: * svg/SVGDocumentExtensions.h: * svg/SVGElement.cpp: (WebCore::SVGElement::childShouldCreateRenderer const): * svg/SVGFontElement.cpp: * svg/SVGFontElement.h: * svg/SVGFontElement.idl: * svg/SVGFontFaceElement.cpp: * svg/SVGFontFaceElement.h: * svg/SVGFontFaceElement.idl: * svg/SVGFontFaceFormatElement.cpp: * svg/SVGFontFaceFormatElement.h: * svg/SVGFontFaceFormatElement.idl: * svg/SVGFontFaceNameElement.cpp: * svg/SVGFontFaceNameElement.h: * svg/SVGFontFaceNameElement.idl: * svg/SVGFontFaceSrcElement.cpp: * svg/SVGFontFaceSrcElement.h: * svg/SVGFontFaceSrcElement.idl: * svg/SVGFontFaceUriElement.cpp: * svg/SVGFontFaceUriElement.h: * svg/SVGFontFaceUriElement.idl: * svg/SVGGlyphElement.cpp: * svg/SVGGlyphElement.h: * svg/SVGGlyphElement.idl: * svg/SVGGlyphRefElement.cpp: * svg/SVGGlyphRefElement.h: * svg/SVGGlyphRefElement.idl: * svg/SVGHKernElement.cpp: * svg/SVGHKernElement.h: * svg/SVGHKernElement.idl: * svg/SVGMissingGlyphElement.cpp: * svg/SVGMissingGlyphElement.h: * svg/SVGMissingGlyphElement.idl: * svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::rendererIsNeeded): * svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::childShouldCreateRenderer const): (WebCore::SVGTSpanElement::rendererIsNeeded): * svg/SVGTests.cpp: (WebCore::supportedSVGFeatures): * svg/SVGTextElement.cpp: (WebCore::SVGTextElement::childShouldCreateRenderer const): * svg/SVGTextPositioningElement.cpp: (WebCore::SVGTextPositioningElement::elementFromRenderer): * svg/SVGToOTFFontConversion.cpp: * svg/SVGVKernElement.cpp: * svg/SVGVKernElement.h: * svg/SVGVKernElement.idl: * svg/svgtags.in: Source/WebKit: * WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::maximumBufferingTime): Source/WTF: * wtf/PlatformEnable.h: Tools: * Scripts/webkitperl/FeatureList.pm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

pvollan@apple.com

commit sha 68b5f616cb00a9a8df6e32a8188ef39e29f7bb76

[macOS] Issue sandbox extension for the diagnostic daemon https://bugs.webkit.org/show_bug.cgi?id=216834 <rdar://problem/58496834> Reviewed by Brent Fulgham. * Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode): * Shared/WebProcessCreationParameters.h: * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::isInternalInstall): (WebKit::agxCompilerClasses): (WebKit::diagnosticServices): (WebKit::WebProcessPool::platformInitializeWebProcess): * WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess): * WebProcess/com.apple.WebProcess.sb.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

timothy_horton@apple.com

commit sha 822b090ef53084f8b7e6c3bf6250a23fab47fcf7

Fix some typo'd wheel event listener logging https://bugs.webkit.org/show_bug.cgi?id=216892 Reviewed by Wenson Hsieh. * rendering/EventRegion.cpp: (WebCore::EventRegion::uniteEventListeners): Wheel is passive, NonPassiveWheel is active. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

ysuzuki@apple.com

commit sha ced7b30a084445c4e0f5704b0bf086761c5f5c65

[JSC] Intl spec update: handle awkward rounding behavior https://bugs.webkit.org/show_bug.cgi?id=216760 Reviewed by Ross Kirsling. JSTests: * stress/intl-numberformat.js: * test262/expectations.yaml: Source/JavaScriptCore: This patch supports new spec change of "handle awkward rounding behavior"[1]. This changes minimumFractionDigits / maximumFractionDigits calculation when the specified ones are less than currency-digits. [1]: https://github.com/tc39/ecma402/pull/471 * runtime/CommonIdentifiers.h: * runtime/IntlNumberFormat.cpp: (JSC::IntlNumberFormat::resolvedOptions const): * runtime/IntlNumberFormatInlines.h: (JSC::setNumberFormatDigitOptions): * runtime/IntlPluralRules.cpp: (JSC::IntlPluralRules::resolvedOptions const): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

jbedard@apple.com

commit sha 6890ade0af780fb0f9825a17ffbac8f4670a55a7

Force SYSTEM_VERSION_COMPAT=0 in Webkit scripts https://bugs.webkit.org/show_bug.cgi?id=216895 <rdar://problem/69454393> Reviewed by Dewei Zhu. * Scripts/configure-xcode-for-embedded-development: * Scripts/webkitpy/__init__.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

commit-queue@webkit.org

commit sha 14d46a4b3c5601857da366e722ae9a2e7ea60b63

[GTK][WPE] Move TLS errors API from WebKitContext to WebKitWebsiteDataManager https://bugs.webkit.org/show_bug.cgi?id=216822 Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-09-23 Reviewed by Alex Christensen. Source/WebCore: Make ignoreTLSErrors a member of SoupNetworkSession, instead of being global. * platform/network/soup/SoupNetworkSession.cpp: (WebCore::SoupNetworkSession::setIgnoreTLSErrors): (WebCore::SoupNetworkSession::checkTLSErrors): (WebCore::SoupNetworkSession::setShouldIgnoreTLSErrors): Deleted. * platform/network/soup/SoupNetworkSession.h: * testing/InternalSettings.cpp: (WebCore::InternalSettings::setAllowsAnySSLCertificate): Do not use SoupNetworkSession in the web process. Source/WebKit: Make TLS errors policy per session instead of global to the network process. The web context API now simply forwards the request to the website data manager. The website data manager created for an ephemeral web view will inherit the network settings from the web context website data manager. This ensures backwards compatibility, but it's also convenient, since it's the desired behavior in most of the cases. Apps can still change the network settings of the web view by getting the website data manager. * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkProcess.messages.in: * NetworkProcess/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode const): (WebKit::NetworkProcessCreationParameters::decode): * NetworkProcess/NetworkProcessCreationParameters.h: * NetworkProcess/NetworkSessionCreationParameters.cpp: (WebKit::NetworkSessionCreationParameters::encode const): (WebKit::NetworkSessionCreationParameters::decode): * NetworkProcess/NetworkSessionCreationParameters.h: * NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::tlsConnectionAcceptCertificate): * NetworkProcess/soup/NetworkProcessSoup.cpp: (WebKit::NetworkProcess::platformInitializeNetworkProcess): (WebKit::NetworkProcess::setIgnoreTLSErrors): * NetworkProcess/soup/NetworkSessionSoup.cpp: (WebKit::NetworkSessionSoup::NetworkSessionSoup): (WebKit::webSocketAcceptCertificateCallback): (WebKit::webSocketMessageNetworkEventCallback): (WebKit::NetworkSessionSoup::createWebSocketTask): (WebKit::NetworkSessionSoup::setIgnoreTLSErrors): * NetworkProcess/soup/NetworkSessionSoup.h: * UIProcess/API/glib/WebKitAutomationSession.cpp: (webkitAutomationSessionCreate): * UIProcess/API/glib/WebKitWebContext.cpp: (webkitWebContextConstructed): (webkit_web_context_set_tls_errors_policy): (webkit_web_context_get_tls_errors_policy): * UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewConstructed): (webkit_web_view_class_init): (webkitWebViewLoadFailedWithTLSErrors): * UIProcess/API/glib/WebKitWebsiteDataManager.cpp: (webkitWebsiteDataManagerConstructed): (webkitWebsiteDataManagerGetDataStore): (webkit_website_data_manager_set_tls_errors_policy): (webkit_website_data_manager_get_tls_errors_policy): * UIProcess/API/gtk/WebKitWebContext.h: * UIProcess/API/gtk/WebKitWebsiteDataManager.h: * UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: * UIProcess/API/wpe/WebKitWebContext.h: * UIProcess/API/wpe/WebKitWebsiteDataManager.h: * UIProcess/API/wpe/docs/wpe-1.0-sections.txt: * UIProcess/WebProcessPool.h: * UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::ignoreTLSErrors const): * UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp: (WebKit::WebsiteDataStore::setIgnoreTLSErrors): * UIProcess/soup/WebProcessPoolSoup.cpp: (WebKit::WebProcessPool::platformInitializeNetworkProcess): (WebKit::WebProcessPool::setIgnoreTLSErrors): Deleted. Tools: Update tests to use the new API instead of the deprecated one. Also update the TLSErrorsPolicy test to also check that ephemeral web views inherit the network settings from its web context. * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: (testSSL): (testInsecureContent): (testTLSErrorsPolicy): (testTLSErrorsRedirect): (testTLSErrorsHTTPAuth): (testLoadFailedWithTLSErrors): (testSubresourceLoadFailedWithTLSErrors): (testWebSocketTLSErrors): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

obrufau@igalia.com

commit sha 444906e0d0b7f0388b9b3cc4a2a203e438113af9

[css-grid] Clear the override width for computing percent margins https://bugs.webkit.org/show_bug.cgi?id=209461 Reviewed by Manuel Rego Casasnovas. LayoutTests/imported/w3c: Update test expectations. The 2 grid-items-percentage-paddings tests are now expected to have some failures because of bug 191964. In fact they were already failing before this patch, as can be seen in wpt.fyi: https://wpt.fyi/results/css/css-grid/grid-items?q=grid-items-percentage-paddings-vertical-%20-002.html It's just that the bug that is being fixed made the test runner think that the tests were passing, probably some racy condition or such. * web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages-expected.txt: * web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-contribution-001-expected.txt: * web-platform-tests/css/css-grid/grid-items/grid-items-minimum-height-orthogonal-001-expected.txt: * web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002-expected.txt: * web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002-expected.txt: Source/WebCore: When calculating the min-content contribution of a grid item of an auto sized grid track we must consider the grid item's margin. When the grid item's area is indefinite, a percent margin is resolved to zero. However, when performing a relayout, the percent margin may be solved against the previously computed grid area, since the grid item has already an OverrideContainingBlockLogicalWidth value. In order to re-compute the percent margin properly, we need to clear the previously override value. It's important to be careful of not clearing the override value set during intrinsic size, since we need it for the actual layout phase. Hence, we only reset the 'override' value when we are executing a definite strategy. This is a reland of r261841, which was reverted because it broke spotify. This problem is now avoided thanks to bug 210089. Tests: imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-minimum-contribution-with-percentages.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-dynamic-min-contribution-001.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-minimum-height-orthogonal-001.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-003.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-004.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-005.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-006.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-007.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-008.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-009.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-margins-010.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-005.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-006.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-009.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-010.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-lr-002.html imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-percentage-paddings-vertical-rl-002.html * rendering/GridTrackSizingAlgorithm.cpp: (WebCore::hasRelativeMarginOrPaddingForChild): (WebCore::hasRelativeOrIntrinsicSizeForChild): (WebCore::shouldClearOverrideContainingBlockContentSizeForChild): (WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const): (WebCore::GridTrackSizingAlgorithmStrategy::minLogicalSizeForChild const): (WebCore::DefiniteSizeStrategy::minLogicalSizeForChild const): (WebCore::DefiniteSizeStrategy::minContentForChild const): * rendering/GridTrackSizingAlgorithm.h: LayoutTests: Update test expectations. * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

cdumez@apple.com

commit sha 30567fc15ed390971e31eb121a5423bfbe04fe67

Turn off the legacy prefixed WebAudio API https://bugs.webkit.org/show_bug.cgi?id=216886 Reviewed by Sam Weinig. LayoutTests/imported/w3c: * web-platform-tests/webaudio/historical-expected.txt: Rebaseline test that is now passing. Source/WebCore: Turn off the legacy prefixed WebAudio API, now that the modern unprefixed API has been enabled in r267488. No new tests, rebaselined existing tests. * Modules/webaudio/AudioBufferSourceNode.idl: Make sure legacy constants get unexposed if the PrefixedWebAudio setting is disabled. * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): (GetRuntimeEnabledStaticProperties): * bindings/scripts/test/JS/JSTestConditionalIncludes.cpp: (WebCore::JSTestConditionalIncludesConstructor::initializeProperties): (WebCore::JSTestConditionalIncludesPrototype::finishCreation): * bindings/scripts/test/JS/JSTestEnabledBySetting.cpp: (WebCore::JSTestEnabledBySettingConstructor::prototypeForStructure): (WebCore::JSTestEnabledBySettingConstructor::initializeProperties): (WebCore::JSTestEnabledBySettingPrototype::finishCreation): * bindings/scripts/test/TestEnabledBySetting.idl: Add support for using [EnabledBySetting=X] on constants. Source/WebKit: Turn off the legacy prefixed WebAudio API, now that the modern unprefixed API has been enabled in r267488. * Shared/WebPreferencesInternal.yaml: Source/WebKitLegacy/mac: Turn off the legacy prefixed WebAudio API, now that the modern unprefixed API has been enabled in r267488. * WebView/WebView.mm: (-[WebView _preferencesChanged:]): LayoutTests: Port existing layout tests from the prefixed WebAudio API to the new unprefixed version. * fast/history/page-cache-closed-audiocontext.html: * fast/history/page-cache-running-audiocontext.html: * fast/history/page-cache-suspended-audiocontext.html: * fast/mediastream/getUserMedia-webaudio.html: * fast/mediastream/media-devices-enumerate-devices.html: * fast/mediastream/mediastreamtrack-audio-clone.html: * fast/mediastream/mock-media-source-webaudio.html: * http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html: * http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin.html: * http/wpt/mediarecorder/MediaRecorder-onremovetrack.html: * http/wpt/webaudio/resources/audiocontext-stopped-iframe.html: * platform/ios/webaudio/realtimeanalyser-fft-sizing-expected.txt: * resources/testharnessreport.js: * webaudio/analyser-exception.html: * webaudio/audiobuffer-crash-expected.txt: * webaudio/audiobuffer-crash.html: * webaudio/audiobuffer-expected.txt: * webaudio/audiobuffer-neuter.html: * webaudio/audiobuffer.html: * webaudio/audiobuffersource-channels-expected.txt: * webaudio/audiobuffersource-channels.html: * webaudio/audiobuffersource-ended.html: * webaudio/audiobuffersource-multi-channels.html: * webaudio/audiobuffersource-negative-playbackrate-interpolated-loop.html: * webaudio/audiobuffersource-negative-playbackrate-interpolated.html: * webaudio/audiobuffersource-negative-playbackrate-loop.html: * webaudio/audiobuffersource-negative-playbackrate.html: * webaudio/audiobuffersource-not-gced-until-ended.html: * webaudio/audiobuffersource-playbackState-expected.txt: Removed. * webaudio/audiobuffersource-playbackState.html: Removed. * webaudio/audiobuffersource-playbackrate.html: * webaudio/audiobuffersource-start.html: * webaudio/audiobuffersource.html: * webaudio/audiobuffersourcenode-legacy-api-expected.txt: * webaudio/audiobuffersourcenode-legacy-api.html: * webaudio/audiochannelmerger-basic.html: * webaudio/audiochannelmerger-stereo.html: * webaudio/audiochannelsplitter.html: * webaudio/audiocontext-promise-throwing-expected.txt: * webaudio/audiocontext-promise-throwing.html: * webaudio/audiocontext-promise.html: * webaudio/audiocontext-restriction-audiobuffersourcenode-start.html: * webaudio/audiocontext-restriction.html: * webaudio/audiocontext-state-interrupted.html: * webaudio/audiocontext-state.html: * webaudio/audionode-connect-order.html: * webaudio/audionode.html: * webaudio/audioparam-connect-audioratesignal.html: * webaudio/audioparam-summingjunction.html: * webaudio/audioprocessingevent.html: * webaudio/automatic-pull-node.html: * webaudio/convolution-mono-mono.html: * webaudio/convolver-channels.html: * webaudio/convolver-setBuffer-different-samplerate.html: * webaudio/convolver-setBuffer-null.html: * webaudio/createMediaStreamSource-null-expected.txt: * webaudio/createMediaStreamSource-null.html: * webaudio/decode-audio-data-basic-expected.txt: * webaudio/decode-audio-data-basic.html: * webaudio/decode-audio-data-too-short.html: * webaudio/delaynode-max-default-delay.html: * webaudio/delaynode-max-nondefault-delay.html: * webaudio/delaynode-maxdelay.html: * webaudio/delaynode-maxdelaylimit.html: * webaudio/delaynode-scheduling.html: * webaudio/delaynode.html: * webaudio/distance-exponential.html: * webaudio/distance-inverse.html: * webaudio/distance-linear.html: * webaudio/dynamicscompressor-basic.html: * webaudio/finished-audio-buffer-source-nodes-should-be-collectable.html: * webaudio/gain-basic.html: * webaudio/gain.html: * webaudio/mediaelementaudiosourcenode-expected.txt: * webaudio/mediaelementaudiosourcenode-gc.html: * webaudio/mediaelementaudiosourcenode.html: * webaudio/mixing.html: * webaudio/offlineaudiocontext-gc.html: * webaudio/offlineaudiocontext-restriction.html: * webaudio/oscillatornode-legacy-api-expected.txt: * webaudio/oscillatornode-legacy-api.html: * webaudio/page-canstartmedia.html: * webaudio/panner-equalpower-stereo.html: * webaudio/panner-equalpower.html: * webaudio/prefixed-pannernode-basic-expected.txt: Removed. * webaudio/prefixed-pannernode-basic.html: Removed. * webaudio/realtimeanalyser-fft-sizing-expected.txt: * webaudio/realtimeanalyser-fft-sizing.html: * webaudio/resources/audio-codec-test.js: (runDecodingTest): * webaudio/resources/audiobuffersource-ended-detached-frame-iframe.html: * webaudio/resources/audioparam-testing-legacy.js: (createAudioGraphAndTest): * webaudio/resources/compatibility.js: Removed. * webaudio/resources/javascriptaudionode-testing.js: (runJSNodeTest): * webaudio/resources/oscillator-testing-legacy.js: (generateExponentialOscillatorSweep): * webaudio/sample-accurate-scheduling.html: * webaudio/silence-after-playback.html: * webaudio/silent-audio-interrupted-in-background.html: * webaudio/stereo2mono-down-mixing.html: * webaudio/test-basic.html: * webaudio/up-mixing-mono-51.html: * webaudio/up-mixing-mono-stereo.html: * webaudio/up-mixing-stereo-51.html: * webaudio/waveshaper.html: * webaudio/web-audio-is-playing.html: * webaudio/webaudio-gc.html: * webaudio/webkitofflineaudiocontext-startRendering-crash-expected.txt: * webaudio/webkitofflineaudiocontext-startRendering-crash.html: * webrtc/audio-peer-connection-g722.html: * webrtc/audio-peer-connection-webaudio.html: * webrtc/clone-audio-track.html: * webrtc/getUserMedia-webaudio-autoplay.html: * webrtc/peer-connection-audio-mute.html: * webrtc/peer-connection-audio-mute2.html: * webrtc/peer-connection-createMediaStreamDestination.html: * webrtc/peer-connection-remote-audio-mute.html: * webrtc/peer-connection-remote-audio-mute2.html: * webrtc/routines.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

cdumez@apple.com

commit sha 7ccdc88e94d09ac55ffb803a2f423676559ece81

Use less explicit ref() / deref() calls in WebAudio code https://bugs.webkit.org/show_bug.cgi?id=216894 Reviewed by Darin Adler. * Modules/webaudio/BaseAudioContext.cpp: (WebCore::BaseAudioContext::clearPendingActivity): (WebCore::BaseAudioContext::makePendingActivity): * Modules/webaudio/MediaElementAudioSourceNode.cpp: (WebCore::MediaElementAudioSourceNode::setFormat): (WebCore::MediaElementAudioSourceNode::process): * Modules/webaudio/MediaElementAudioSourceNode.h: * Modules/webaudio/OfflineAudioDestinationNode.cpp: (WebCore::OfflineAudioDestinationNode::startRendering): * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaEngineWasUpdated): (WebCore::HTMLMediaElement::createMediaPlayer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

cdumez@apple.com

commit sha b74a3950da79626d4e8fc15055f8902c584aa22e

web audio api outputs silence for 302 redirected resource in safari https://bugs.webkit.org/show_bug.cgi?id=214932 <rdar://problem/66300050> Reviewed by Darin Adler. Source/WebCore: If the resource is redirected to another origin, treat it as tainted only if the crossorigin attribute is not set. This is done for consistency with Blink: - https://github.com/chromium/chromium/blob/master/media/blink/webmediaplayer_impl.cc (see WouldTaintOrigin()) The new behavior also seems to match Firefox. Tests: http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html * Modules/webaudio/MediaElementAudioSourceNode.cpp: (WebCore::MediaElementAudioSourceNode::wouldTaintOrigin): LayoutTests: Add layout test coverage. Update existing test to reflect the fact that the frequency returned by the AnalyserNode is -Infinity when input is silent, not minDecibels (this has changed fairly recently). * http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect-expected.txt: Added. * http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-redirect.html: Copied from LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html. * http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html: * http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect-expected.txt: Added. * http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-redirect.html: Copied from LayoutTests/http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

jbedard@apple.com

commit sha d6a819d44f64f74db3ce40be97c62e9bb105473c

webkitpy: Make sw_vers the source of truth for the MacOS version https://bugs.webkit.org/show_bug.cgi?id=216903 <rdar://problem/69462735> Reviewed by Dewei Zhu. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo.__init__): Use sw_vers instead of platform.mac_ver(). * Scripts/webkitpy/common/system/platforminfo_unittest.py: (fake_executive): Set a valid return value for sw_vers by default. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

simon.fraser@apple.com

commit sha 4b5d5005389d6404ed9f16c28778c26f3cc9836c

[LFC Display] Add the beginnings of a CSS display box hierarchy and CSS painter https://bugs.webkit.org/show_bug.cgi?id=216752 Reviewed by Zalan Bujtas. Add some Display::Box subclasses to display/css, a Display::Tree class to own the display tree, and a DisplayTreeBuilder. Also add css/DisplayCSSPainter which is the beginnings of a class that knows how to paint a CSS stacking context. This code other than DisplayCSSPainter is deliberately vague about how much is CSS specific. It's likely that some box classes will be shared with SVG painting. * CMakeLists.txt: * Headers.cmake: * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * display/DisplayLayerController.cpp: (WebCore::Display::LayerController::RootLayerClient::paintContents): (WebCore::Display::LayerController::RootLayerClient::deviceScaleFactor const): (WebCore::Display::LayerController::prepareForDisplay): (WebCore::Display::LayerController::ensureRootLayer): (WebCore::Display::LayerController::updateRootLayerGeometry): * display/DisplayLayerController.h: * display/DisplayTree.cpp: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::Tree::Tree): * display/DisplayTree.h: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::Tree::rootBox const): * display/DisplayTreeBuilder.cpp: Added. (WebCore::Display::TreeBuilder::TreeBuilder): (WebCore::Display::TreeBuilder::build const): (WebCore::Display::TreeBuilder::recursiveBuildDisplayTree const): (WebCore::Display::TreeBuilder::displayBoxForRootBox const): (WebCore::Display::TreeBuilder::displayBoxForLayoutBox const): (WebCore::Display::outputDisplayBox): (WebCore::Display::outputDisplayTree): (WebCore::Display::showDisplayTree): * display/DisplayTreeBuilder.h: Copied from Source/WebCore/display/DisplayView.h. * display/DisplayView.cpp: (WebCore::Display::View::prepareForDisplay): (WebCore::Display::View::deviceScaleFactor const): * display/DisplayView.h: * display/css/DisplayBox.cpp: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::Box::Box): (WebCore::Display::Box::setNextSibling): (WebCore::Display::Box::debugDescription const): * display/css/DisplayBox.h: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::Box::Box): (WebCore::Display::Box::style const): (WebCore::Display::Box::borderBoxFrame const): (WebCore::Display::Box::isContainerBox const): (WebCore::Display::Box::isImageBox const): (WebCore::Display::Box::isReplacedBox const): (WebCore::Display::Box::nextSibling const): * display/css/DisplayCSSPainter.cpp: Added. (WebCore::Display::CSSPainter::paintBoxDecorations): (WebCore::Display::CSSPainter::paintBoxContent): (WebCore::Display::CSSPainter::paintBox): (WebCore::Display::CSSPainter::recursivePaintDescendants): (WebCore::Display::CSSPainter::paintStackingContext): (WebCore::Display::CSSPainter::isStackingContextPaintingBoundary): (WebCore::Display::CSSPainter::recursiveCollectLayers): (WebCore::Display::CSSPainter::paintTree): * display/css/DisplayCSSPainter.h: Copied from Source/WebCore/display/DisplayView.h. * display/css/DisplayContainerBox.cpp: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::ContainerBox::ContainerBox): (WebCore::Display::ContainerBox::setFirstChild): (WebCore::Display::ContainerBox::debugDescription const): * display/css/DisplayContainerBox.h: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::ContainerBox::firstChild const): * display/css/DisplayImageBox.cpp: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::ImageBox::ImageBox): (WebCore::Display::ImageBox::setImage): (WebCore::Display::ImageBox::debugDescription const): * display/css/DisplayImageBox.h: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::ImageBox::image const): * display/css/DisplayReplacedBox.cpp: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::ReplacedBox::ReplacedBox): * display/css/DisplayReplacedBox.h: Copied from Source/WebCore/display/DisplayView.h. (WebCore::Display::ReplacedBox::replacedContentRect const): * display/css/DisplayStyle.cpp: Copied from Source/WebCore/display/DisplayView.cpp. (WebCore::Display::Style::Style): (WebCore::Display::Style::hasBackground const): (WebCore::Display::Style::hasVisibleBorder const): * display/css/DisplayStyle.h: Added. (WebCore::Display::Style::backgroundColor const): (WebCore::Display::Style::hasBackgroundImage const): (WebCore::Display::Style::borderLeft const): (WebCore::Display::Style::borderRight const): (WebCore::Display::Style::borderTop const): (WebCore::Display::Style::borderBottom const): (WebCore::Display::Style::zIndex const): (WebCore::Display::Style::isStackingContext const): (WebCore::Display::Style::isPositioned const): (WebCore::Display::Style::isFloating const): (WebCore::Display::Style::participatesInZOrderSorting const): (WebCore::Display::Style::setIsPositioned): (WebCore::Display::Style::setIsFloating): * layout/displaytree/DisplayBox.cpp: Removed. * layout/displaytree/DisplayBox.h: Removed. * layout/layouttree/LayoutIterator.h: Unified sources build fix. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

jlewis3@apple.com

commit sha b28b316ad184ae0d1e8e91574e3547556d8f66f7

Update iOS, watchOS and tvOS builders and tester with new SDKs https://bugs.webkit.org/show_bug.cgi?id=216658 Reviewed by Jonathan Bedard. Bumped the versions on iOS, tvOS, and watchOS in config, dashboard and main CSS. Also, added the updated images for the queues. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Device.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Device@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Simulator.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS14Simulator@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS14.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS14@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS14Simulator.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS14Simulator@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS7.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS7@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator7.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator7@2x.png: Added. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.ios-simulator-14 img.logo): (table.queue-grid tr.platform.ios-14 img.logo): (table.queue-grid tr.platform.tvos-simulator-14 img.logo): (table.queue-grid tr.platform.tvos-14 img.logo): (table.queue-grid tr.platform.watchos-simulator-7 img.logo): (table.queue-grid tr.platform.watchos-7 img.logo): (table.queue-grid tr.platform.ios-simulator-13 img.logo): Deleted. (table.queue-grid tr.platform.ios-13 img.logo): Deleted. (table.queue-grid tr.platform.tvos-simulator-13 img.logo): Deleted. (table.queue-grid tr.platform.tvos-13 img.logo): Deleted. (table.queue-grid tr.platform.watchos-simulator-6 img.logo): Deleted. (table.queue-grid tr.platform.watchos-6 img.logo): Deleted. * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

push time in 25 days

issue commentcontainers/podman

unable to run rootless container: error with setrlimit RLIMIT_NPROC

for anyone out there still having this issue, you have to recreate the affected containers

Sorry what does it mean? Can I recreate the containers keeping all theirs data?

FWIW, I managed to backup my containers in F32, then rebase on F33 and restore the backups using this tutorial: https://fedoramagazine.org/backup-and-restore-toolboxes-with-podman/

vrischmann

comment created time in a month

issue commentcontainers/toolbox

Can't enter any toolbox containers

and #557

larsks

comment created time in a month

issue commentcontainers/toolbox

Failed to start container

I've rebased to F33 and now hitting this very same issue for the containers I had created on F32 with the old shell impl of toolbox. Reading the backlog here I'm not sure if I now have to ditch my old containers or if there's a way to fix them :(

zapateo

comment created time in a month

delete branch Igalia/WPEBackend-fdo

delete branch : audio-additions

delete time in a month

push eventIgalia/WPEBackend-fdo

Philippe Normand

commit sha a7fccf78cc1a4cd759ba69d770481cb798d44228

Bump to 1.9.0 development version

view details

Philippe Normand

commit sha 3d29d2c002f15f74899e33a9de921167cf6d652b

audio: Add null pointer checks

view details

Philippe Normand

commit sha ca2b668fbc930b5ee9bd9c7d4e41960e025ed1a7

audio: Add wpe_audio_source_has_receiver() API This function will be used in WebKit to determine if external audio rendering should be enabled or not. If no receiver was registered on client side, we shall not enable client-side rendering of audio frames.

view details

push time in a month

Pull request review commentIgalia/WPEBackend-fdo

Audio extension fixes and additions

 cmake_minimum_required(VERSION 3.3) set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake") include(VersioningUtils) -SET_PROJECT_VERSION(1 7 1)+SET_PROJECT_VERSION(1 9 1)

Thanks for review! Indeed I wasn't sure what to do with those numbers and if they should be updated at the beginning of the cycle or just before the final release, so I didn't touch them :)

philn

comment created time in a month

PullRequestReviewEvent

create barnchIgalia/WPEBackend-fdo

branch : audio-additions

created branch time in a month

issue commentphiln/glide

Wayland support

@reagentoo Make sure you have this GStreamer element gtkglsink. gst-inspect-1.0 gtkglsink.

philn

comment created time in a month

push eventphiln/glide

Philippe Normand

commit sha cd12682dd4e2105558510a397ed91250b8eda381

Create FUNDING.yml

view details

push time in a month

issue commentflathub/net.baseart.Glide

gst-libav and gstreamer-vaapi are available in org.gnome.Platform

gstreamer-vaapi was added in the runtime, then removed, then some idea of an extension appeared, but https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/merge_requests/1750 was never merged...

Erick555

comment created time in a month

delete branch flathub/net.baseart.Glide

delete branch : gnome-3.38

delete time in a month

push eventflathub/net.baseart.Glide

Philippe Normand

commit sha e0845c2c3cdb7ed1456f44d8ed093d5d0703e4c4

Bump to 0.5.8 A new release is needed in order to migrate to the 3.38 GNOME runtime.

view details

Philippe Normand

commit sha f8a8da2f06a0763d95e416328c9721fcf222f5c9

Update to GNOME 3.38 runtime

view details

push time in a month

push eventflathub/net.baseart.Glide

Philippe Normand

commit sha 310c5bdd2832c2cb2bc4552e22fb2ac105a8ff69

Bump to 0.5.8 A new release is needed in order to migrate to the 3.38 GNOME runtime.

view details

Philippe Normand

commit sha 84d1bd3d36ae87b473ddff87796a3f7a9b029527

Update to GNOME 3.38 runtime

view details

push time in a month

release philn/glide

0.5.8

released time in a month

delete tag philn/glide

delete tag : 0.5.7.1

delete time in a month

created tagphiln/glide

tag0.5.8

Linux/macOS media player based on GStreamer and GTK+

created time in a month

push eventphiln/glide

Philippe Normand

commit sha 66d912fe473d894a63909051ae6bbb0195cd1005

Bump to 0.5.8

view details

push time in a month

push eventphiln/glide

Philippe Normand

commit sha a7729fe84b4d9202b5f0f981098d0a19620be82d

appdata: Fix markup...

view details

Philippe Normand

commit sha 95a5d5c62874042b91eaea218f0098a5e33f3cf4

Bump to 0.5.7.1

view details

push time in a month

created tagphiln/glide

tag0.5.7.1

Linux/macOS media player based on GStreamer and GTK+

created time in a month

release philn/glide

0.5.7

released time in a month

push eventphiln/glide

Philippe Normand

commit sha e0674a8c1fdb23f96cc0a667e95a4b230d56f764

Cargo.lock: Bump to 0.5.7

view details

push time in a month

push eventphiln/glide

Philippe Normand

commit sha 1d44c45e77e6b9092e78f534a8676f47e92b00b9

Update dependencies

view details

Philippe Normand

commit sha b591a0b459bf714030f747416c08cbc4805b651d

Bump to 0.5.7

view details

push time in a month

created tagphiln/glide

tag0.5.7

Linux/macOS media player based on GStreamer and GTK+

created time in a month

pull request commentflathub/net.baseart.Glide

Update to GNOME 3.38 runtime

Time for a new Glide release :)

philn

comment created time in a month

pull request commentflathub/net.baseart.Glide

Update to GNOME 3.38 runtime

Filed https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/330

philn

comment created time in a month

pull request commentflathub/net.baseart.Glide

Update to GNOME 3.38 runtime

So 3.38 switched to Meson for the GTK component, which doesn't seem to have an equivalent of the --enable-debug=minimum autoconf option, AFAICT.

philn

comment created time in a month

pull request commentflathub/net.baseart.Glide

Update to GNOME 3.38 runtime

Sigh.

$ flatpak run --env=RUST_BACKTRACE=1 net.baseart.Glide//test
thread 'main' panicked at 'libgtk-3 was configured with `--enable-debug=no`. See https://github.com/gtk-rs/gtk/issues/270 for details', /run/build/glide/vendor/gtk/src/rt.rs:137:13
stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>
   8: <unknown>
   9: <unknown>
  10: <unknown>
  11: <unknown>
  12: <unknown>
  13: __libc_start_main
  14: <unknown>
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
philn

comment created time in a month

create barnchflathub/net.baseart.Glide

branch : gnome-3.38

created branch time in a month

push eventphiln/webkit

simon.fraser@apple.com

commit sha 9f6fcf55eab296fc9506642adfa0031707530e24

ASSERTION FAILED: &formattingContextRoot == m_rootContainer.get() in WebCore::Layout::LayoutState::establishedInlineFormattingState https://bugs.webkit.org/show_bug.cgi?id=216668 Reviewed by Zalan Bujtas. Display::View didn't unparent the GraphicsLayers when Document::documentWillBecomeInactive() was called, so a layer pointing to an old LayoutState would try to paint. Fix by plumbing setIsInWindow() through to Display::View and using it to detach the root layer. * dom/Document.cpp: (WebCore::Document::documentWillBecomeInactive): The ASSERT_IMPLIES() is there to ensure that this isn't a behavior change; we used to go to RenderView directly, and now go via FrameView. * layout/display/DisplayLayerController.cpp: (WebCore::Display::LayerController::detachRootLayer): (WebCore::Display::LayerController::setIsInWindow): * layout/display/DisplayLayerController.h: * layout/display/DisplayView.cpp: (WebCore::Display::View::setIsInWindow): * layout/display/DisplayView.h: * page/FrameView.cpp: (WebCore::FrameView::setIsInWindow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

weinig@apple.com

commit sha b7635198682b57da3fc9bf46537571d1446d689b

Remove runtime setting for enabling/disabling the CrossOriginResourcePolicy API https://bugs.webkit.org/show_bug.cgi?id=216561 Reviewed by Darin Adler. Remove runtime setting for enabling/disabling CrossOriginResourcePolicy. It has been enabled by default for a while and there are no known reasons one would need to disable it. Source/WebCore: * page/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::setCrossOriginResourcePolicyEnabled): Deleted. (WebCore::RuntimeEnabledFeatures::crossOriginResourcePolicyEnabled const): Deleted. Source/WebKit: * Shared/WebPreferences.yaml: * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetCrossOriginResourcePolicyEnabled): (WKPreferencesGetCrossOriginResourcePolicyEnabled): * UIProcess/API/C/WKPreferencesRef.h: * WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

weinig@apple.com

commit sha bd1abdae67a1caf967a7936e1fae462045d5a0d2

Add support for Settings equivilent of RuntimeConditionallyReadWrite https://bugs.webkit.org/show_bug.cgi?id=216697 Reviewed by Darin Adler. Adds a new extended attribute, [SettingsConditionallyReadWrite] to allow users of [RuntimeConditionallyReadWrite] to convert from RuntimeEnabledFeatures to Settings. * bindings/scripts/CodeGeneratorJS.pm: (NeedsRuntimeReadWriteCheck): (GeneratePropertiesHashTable): (GenerateRuntimeEnableConditionalString): (GenerateImplementation): * bindings/scripts/IDLAttributes.json: Adds new extended attribute. * bindings/scripts/test/DOMWindowConstructors.idl: * bindings/scripts/test/JS/JSDOMWindow.cpp: * bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp: Added. * bindings/scripts/test/JS/JSTestConditionallyReadWrite.h: Added. * bindings/scripts/test/JS/JSTestObj.cpp: * bindings/scripts/test/SupplementalDependencies.dep: * bindings/scripts/test/TestConditionallyReadWrite.idl: Added. * bindings/scripts/test/TestObj.idl: Move conditionally read-write tests to a new test, TestConditionallyReadWrite.idl and update results. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

darin@apple.com

commit sha e5cc17f3a3677e0cae057abbfb2e20335fd8cb0c

Selection API: Extend lifetime of selection live range to preserve expando properties https://bugs.webkit.org/show_bug.cgi?id=216721 Reviewed by Ryosuke Niwa. Source/WebCore: Test: editing/selection/expando.html * dom/Range.cpp: (WebCore::Range::window): Added. Returns window if range is associated with selection. * dom/Range.h: Added window. * dom/Range.idl: Added GenerateIsReachable=ReachableFromDOMWindow. * editing/FrameSelection.cpp: (WebCore::FrameSelection::disassociateLiveRange): Removed a FIXME comment about the need for this fix. (WebCore::FrameSelection::updateAssociatedLiveRange): Added a comment explaining why an associated live range might not be contained in the document. LayoutTests: * editing/selection/expando-expected.txt: Added. * editing/selection/expando.html: Added. * TestExpectations: Skip the new test since DumpRenderTree doesn't support enabling internal properties. * platform/wk2/TestExpectations: Unskip the new test since WebKitTestRunner does. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

weinig@apple.com

commit sha 3d17554ab9161a5c835a36b2e194bb95452d727a

Resync web-platform-tests/hr-time from upstream https://bugs.webkit.org/show_bug.cgi?id=216724 Reviewed by Darin Adler. LayoutTests/imported/w3c: Resync web-platform-tests/hr-time from upstream. * web-platform-tests/hr-time/META.yml: Added. * web-platform-tests/hr-time/OWNERS: Removed. * web-platform-tests/hr-time/idlharness-expected.txt: Removed. * web-platform-tests/hr-time/idlharness.any-expected.txt: Added. * web-platform-tests/hr-time/idlharness.any.html: Added. * web-platform-tests/hr-time/idlharness.any.js: Added. * web-platform-tests/hr-time/idlharness.any.worker-expected.txt: Added. * web-platform-tests/hr-time/idlharness.any.worker.html: Added. * web-platform-tests/hr-time/idlharness.html: Removed. * web-platform-tests/hr-time/monotonic-clock.any.js: * web-platform-tests/hr-time/performance-tojson-expected.txt: Added. * web-platform-tests/hr-time/performance-tojson.html: Added. * web-platform-tests/hr-time/resources/unload-a.html: Added. * web-platform-tests/hr-time/resources/unload-b.html: Added. * web-platform-tests/hr-time/resources/unload-c.html: Added. * web-platform-tests/hr-time/resources/unload.js: Added. * web-platform-tests/hr-time/resources/w3c-import.log: * web-platform-tests/hr-time/timeOrigin-expected.txt: * web-platform-tests/hr-time/w3c-import.log: * web-platform-tests/hr-time/window-worker-timeOrigin.window-expected.txt: Added. * web-platform-tests/hr-time/window-worker-timeOrigin.window.html: Added. LayoutTests: * platform/ios/TestExpectations: * platform/mac/TestExpectations: Update paths in expectations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

zalan@apple.com

commit sha 7bf8a95f96f6e6a74e0876512d3e79b8aed625d0

[LFC][IFC] InlineFormattingContext::computeGeometryForLineContent should not construct Display::Lines https://bugs.webkit.org/show_bug.cgi?id=216723 Reviewed by Antti Koivisto. Display::Lines construction should live in the display builder. However currently we don't yet have a real builder, so let's just use the integration layer. This is also in preparation for removing all the Display::InlineContent code from the Layout namespace. * layout/displaytree/DisplayPainter.cpp: (WebCore::Display::paintInlineContent): * layout/inlineformatting/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent): * layout/integration/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::layout): (WebCore::LayoutIntegration::LineLayout::constructDisplayContent): * layout/integration/LayoutIntegrationLineLayout.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

weinig@apple.com

commit sha 2cc0d6f0d437cda3927d6a1e72558d1bbe8a914d

Performance and PerformanceNavigation interfaces are missing toJSON operations https://bugs.webkit.org/show_bug.cgi?id=216728 Reviewed by Darin Adler. LayoutTests/imported/w3c: Update results now that we pass more subtests. * web-platform-tests/hr-time/idlharness.any-expected.txt: * web-platform-tests/hr-time/idlharness.any.worker-expected.txt: * web-platform-tests/hr-time/performance-tojson-expected.txt: Source/WebCore: Add missing toJSON operations to Performance and PerformanceNavigation and update comments in related IDLs. Updates results for existing tests, more of which now pass. * page/Performance.idl: * page/PerformanceMark.idl: * page/PerformanceMeasure.idl: * page/PerformanceNavigation.idl: * page/PerformanceTiming.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

andresg_22@apple.com

commit sha 48a268e9f669228b1b7123b61725ed1a60b903ad

Implementation for AXIsolatedObject::nextSibling and previousSibling. https://bugs.webkit.org/show_bug.cgi?id=216710 Reviewed by Chris Fleizach. Implementation for AXIsolatedObject::previousSibling and nextSibling which are invoked by VoiceOver in Safari Reader mode. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::previousSibling const): - Fixed crash caused by dereferencing m_renderer->parent() which can be null. - Added check for the AXObjectCache that can become null. (WebCore::AccessibilityRenderObject::nextSibling const): - Code style cleanup. * accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeAttributeData): - Added caching of next/previousSiblling objects. (WebCore::AXIsolatedObject::previousSibling const): Inlined in header.. (WebCore::AXIsolatedObject::nextSibling const): Inlined in header. * accessibility/isolatedtree/AXIsolatedObject.h: * accessibility/isolatedtree/AXIsolatedTree.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

darin@apple.com

commit sha 9e7fc04542b55c7811015d699d440da234cbafd0

Selection API: Update some more tests so they don't accidentally rely on flaws in WebKit's old implementation https://bugs.webkit.org/show_bug.cgi?id=216737 Reviewed by Sam Weinig. Like the three tests I modified in r267220, these tests are accidentally depending on the fact that our selection object implementation currently allows invalid indexes. It's clear that these are mistakes in the tests, not intentional, and fixing these does not change the test expectations, only the tests themselves. * accessibility/mac/select-text-should-match-whole-words.html: Set the selection with separate calls to the collapse function. The old code tried to reuse the same range to set the selection back to an old value, but that won't work if the selection updates the range (as it is supposed to do). * editing/execCommand/indent-selection.html: Pass a valid index, 1, instead of an invalid one, 2. * editing/pasteboard/paste-visible-script.html: Ditto. * editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html: Pass a valid index, 0, instead of an invalid one, 10500000000. Also fixed line endings in this file, which were all Windows-style CR/LF pairs to be Unix-style LF like most of our other files. * editing/pasteboard/testcase-9507.html: Use childNodes.length to compute a valid index instead of passing 5, which was an invalid one. * editing/style/apply-style-crash2.html: Pass a valid index, 0, instead of an invalid one, 4. * editing/style/query-typing-style.html: Pass a valid index, 0, instead of an invalid one, 1. * editing/undo/undo-paste-when-caret-is-not-in-range.html: Pass valid index 1 instead of invalid ones, 3 and 4. * fast/block/float/float-list-changed-before-layout-crash.html: Pass a valid index, 0, instead of an invalid one, 1. * fast/dynamic/checkbox-selection-crash.html: Use childNodes.length to compute a valid index instead of passing 1000, which was an invalid one. * fast/repaint/selection-gap-absolute-child.html: Pass a valid index, 0, instead of an invalid one, 1. * fast/repaint/selection-gap-fixed-child.html: Ditto. * fast/repaint/selection-gap-flipped-absolute-child.html: Ditto. * fast/repaint/selection-gap-flipped-fixed-child.html: Ditto. * fast/repaint/selection-gap-transformed-absolute-child.html: Ditto. * fast/repaint/selection-gap-transformed-fixed-child.html: Ditto. * fast/replaced/selection-rect.html: Select the image with a range in its parent node with valid indices instead of relying WebKit's quirky way of expressing selections of replaced elements, which involves an invalid index of 1 for an image element with no children. This test has nothing to do with the particular selection range technique used, so it's fine to change it. * http/tests/security/resources/foreign-domain-iframe-for-selection-test.html: Use childNodes.length to compute a valid index instead of passing 10, which was an invalid one. * imported/blink/editing/apply-inline-style-to-element-with-no-renderer-crash.html: Use a valid index, 0, instead of an invalid one, 4. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

lmoura@igalia.com

commit sha 48466ada7bad140a3bbb0963a4d30949cb6e9f95

[GLIB] Unreviewed gardening. * platform/glib/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

lmoura@igalia.com

commit sha fb696d9dbd1b276e5fc368489ea1383493ba8d04

[GLIB] Merge API test expectations Unreviewed test gardening. Two TestUIClient sections were causing the first one to be ignored. * TestWebKitAPI/glib/TestExpectations.json: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

ysuzuki@apple.com

commit sha 605689eac62d2a1716e6f2a9f884024e6c5fb693

Unreviewed, use RELEASE_AND_RETURN to suppress exception verification failure https://bugs.webkit.org/show_bug.cgi?id=216686 <rdar://problem/69157632> * runtime/JSModuleNamespaceObject.cpp: (JSC::JSModuleNamespaceObject::defineOwnProperty): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

zalan@apple.com

commit sha b70d73dc90e880eaefe2b3c0cf6856d57faa34cd

[LFC][IFC] InlineFormattingState should not store display lines and runs https://bugs.webkit.org/show_bug.cgi?id=216742 Reviewed by Antti Koivisto. Source/WebCore: In this patch, 1. Display related structures are completely moved out from Layout namespace - InlineFormattingContext does not generate display structures. - InlineFormattingState only stores layout data. - Layout tree verification works on layout geometry. - Layout structures do not embed Display types. 2. LayoutIntegration creates and maintains the required Display structures for painting and hittesting. 3. Display::Run does not use Layout types (InlineLayoutRect, InlineLayoutUnit). FIXME: We need to start constructing display content for the Display::Painter. * WebCore.xcodeproj/project.pbxproj: * layout/Verification.cpp: (WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded): (WebCore::Layout::checkForMatchingNonTextRuns): (WebCore::Layout::checkForMatchingTextRuns): (WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded): (WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree): * layout/displaytree/DisplayInlineContent.h: (WebCore::Display::InlineContent::shrinkToFit): * layout/displaytree/DisplayLine.h: (WebCore::Display::Line::horizontalAlignmentOffset const): (WebCore::Display::Line::Line): * layout/displaytree/DisplayPainter.cpp: (WebCore::Display::paintInlineContent): * layout/displaytree/DisplayRun.h: (WebCore::Display::Run::TextContent::start const): (WebCore::Display::Run::TextContent::end const): (WebCore::Display::Run::TextContent::length const): (WebCore::Display::Run::TextContent::content const): (WebCore::Display::Run::TextContent::needsHyphen const): (WebCore::Display::Run::rect const): (WebCore::Display::Run::inkOverflow const): (WebCore::Display::Run::Run): (WebCore::Display::Run::TextContent::TextContent): (WebCore::Display::Run::TextContent::setNeedsHyphen): Deleted. (WebCore::Display::Run::TextContent::expand): Deleted. (WebCore::Display::Run::TextContent::shrink): Deleted. (WebCore::Display::Run::topLeft const): Deleted. (WebCore::Display::Run::left const): Deleted. (WebCore::Display::Run::right const): Deleted. (WebCore::Display::Run::top const): Deleted. (WebCore::Display::Run::bottom const): Deleted. (WebCore::Display::Run::width const): Deleted. (WebCore::Display::Run::height const): Deleted. (WebCore::Display::Run::moveVertically): Deleted. * layout/flexformatting/FlexFormattingContext.cpp: (WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems): * layout/inlineformatting/InlineFormattingContext.cpp: (WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent): * layout/inlineformatting/InlineFormattingState.h: (WebCore::Layout::InlineFormattingState::lineRuns const): (WebCore::Layout::InlineFormattingState::lineRuns): (WebCore::Layout::InlineFormattingState::addLineRun): (WebCore::Layout::InlineFormattingState::clearLineAndRuns): (WebCore::Layout::InlineFormattingState::shrinkToFit): (WebCore::Layout::InlineFormattingState::displayInlineContent const): Deleted. (WebCore::Layout::InlineFormattingState::ensureDisplayInlineContent): Deleted. (WebCore::Layout::InlineFormattingState::shrinkDisplayInlineContent): Deleted. * layout/inlineformatting/InlineLine.h: (WebCore::Layout::Line::Run::textContent const): (WebCore::Layout::Line::Run::expansion const): * layout/inlineformatting/InlineLineGeometry.h: (WebCore::Layout::InlineLineGeometry::horizontalAlignmentOffset const): (WebCore::Layout::InlineLineGeometry::InlineLineGeometry): * layout/integration/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::layout): (WebCore::LayoutIntegration::LineLayout::constructDisplayContent): (WebCore::LayoutIntegration::LineLayout::ensureDisplayInlineContent): (WebCore::LayoutIntegration::LineLayout::paint): (WebCore::LayoutIntegration::LineLayout::displayInlineContent const): Deleted. * layout/integration/LayoutIntegrationLineLayout.h: (WebCore::LayoutIntegration::LineLayout::displayInlineContent const): * layout/layouttree/LayoutTreeBuilder.cpp: (WebCore::Layout::outputInlineRuns): * layout/tableformatting/TableFormattingContext.cpp: (WebCore::Layout::TableFormattingContext::setUsedGeometryForCells): * rendering/line/LineLayoutTraversalDisplayRunPath.h: (WebCore::LineLayoutTraversal::DisplayRunPath::rect const): LayoutTests: This directory is about verifying layout correctness by calling LayoutContext::verifyAndOutputMismatchingLayoutTree on every layout frame and assert in case of mismatching trees. The test coverage does not suffer by [ ImageOnlyFailure ] it. (We need to start generating display boxes for the Display::Painter.) * TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

simon.fraser@apple.com

commit sha 9d8f85fe4fed75a88fabde604a7eeb95415d25e3

Sort the project file. * WebKit.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

darin@apple.com

commit sha 93b88c4f6dcf3578511f8b5afd0370f05cac3ee4

Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node https://bugs.webkit.org/show_bug.cgi?id=216741 Reviewed by Ryosuke Niwa. This is covered by tests, but the fix itself is only testable when live range selection is enabled. So for now the other tests are simply checking that no regression or behavior change was introduced by accident. * page/DOMSelection.cpp: (WebCore::DOMSelection::selectAllChildren): Return the value returned by setBaseAndExtent so we don't discard any exception it might throw. In practice, that's only this one. * page/DOMSelection.h: Updated return type so we can throw an exception. * page/DOMSelection.idl: Added MayThrowException. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

simon.fraser@apple.com

commit sha 7b17bd937b221f3e11e54e36c4745a5f7849cb1a

[LFC Display] Move LFC Display infrastructure files into a new 'display' directory https://bugs.webkit.org/show_bug.cgi?id=216747 Reviewed by Zalan Bujtas. WebCore/Source/display will become the home for all the LFC painting code; move DisplayView and DisplayLayerController into it. Also fix some unified build include issues. * CMakeLists.txt: * Headers.cmake: * Sources.txt: * WebCore.xcodeproj/project.pbxproj: * display/DisplayLayerController.cpp: Renamed from Source/WebCore/layout/display/DisplayLayerController.cpp. * display/DisplayLayerController.h: Renamed from Source/WebCore/layout/display/DisplayLayerController.h. * display/DisplayView.cpp: Renamed from Source/WebCore/layout/display/DisplayView.cpp. * display/DisplayView.h: Renamed from Source/WebCore/layout/display/DisplayView.h. * layout/flexformatting/FlexFormattingContext.cpp: * layout/inlineformatting/InlineLineBox.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

darin@apple.com

commit sha baba54db7da3d2a2e413d61ba52c0ebd16547c61

Selection API: Further improvements to VisibleSelection, FrameSelection, and DOMSelection to preserve anchor and focus https://bugs.webkit.org/show_bug.cgi?id=216739 Reviewed by Ryosuke Niwa. Source/WebCore: If done correctly, these changes should have almost no effect unless live range selection is enabled. This adds a feature where VisibleSelection tracks the original points, before the VisiblePosition-style canonicalization. It also starts a transition from the base/extent terminology to the slightly-easier-to-understand anchor/focus terminology that is used in the selection specification. New functions name them anchor and focus, even though we still have some old ones that call them base and extent. In addition, made some other small related improvements to live range selection mode, without changing behavior when not in that mode. Have been testing these locally by turning on that mode and running various tests. * editing/FrameSelection.cpp: (WebCore::FrameSelection::isInDocumentTree const): Added. Used by DOMSelection to correctly handle cases where the selection is in a shadow tree without requiring it actually create the associated live range just to query. (WebCore::FrameSelection::associatedLiveRange): Use the new VisibleSelection::range, which gives us non-canonicalized points, rather than the deprecated VisibleSelection::firstRange, which we will eventually be renaming or deleting. (WebCore::FrameSelection::updateFromAssociatedLiveRange): Use makeContainerOffsetPosition instead of implicitly using makeDeprecatedLegacyPosition. Also removed the FIXME about normalization of endpoints, which is what this patch mostly addresses; no need to track with a comment now. (WebCore::FrameSelection::updateAssociatedLiveRange): Use VisibleSelection::range for the same reason as above. * editing/FrameSelection.h: Added isInDocumentTree. * editing/VisibleSelection.cpp: (WebCore::VisibleSelection::VisibleSelection): Updated the primary constructor to set m_anchor/focus and let the validate function set m_base/extent/start/end/baseIsFirst. Changed most other constructors to call that primary one. (WebCore::VisibleSelection::anchor const): Added. This is a non-canonicalized position. (WebCore::VisibleSelection::focus const): Ditto. (WebCore::VisibleSelection::uncanonicalizedStart const): Added. This non-canonicalized version of start is used by new DOMSelection code, but eventually should be used elsewhere as well, and we may eventually eliminate the canonicalized version. (WebCore::VisibleSelection::uncanonicalizedEnd const): Ditto. (WebCore::VisibleSelection::range const): Added. This non-canonicalized version of firstRange has many of the same considerations as the other four functions above. (WebCore::VisibleSelection::setBase): Set m_anchor instead of m_base. Eventually we will want to rename this function, too, but there is no need to do that now. (WebCore::VisibleSelection::setExtent): Ditto. (WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents): Rewrote to take m_anchor and m_focus as inputs and now m_base and m_extent are pure outputs. May want to rename this later, because "deep equivalents" is a funny way to say that this function sets base and extent to canonicalized values. (WebCore::VisibleSelection::adjustSelectionRespectingGranularity): Renamed from setStartAndEndFromBaseAndExtentRespectingGranularity. This now takes m_start/end as input as well as output, because the validate function needs to check if the function changes m_start/end so it can update m_anchor/focus. Also did a tiny bit of refactoring to use std::swap. (WebCore::VisibleSelection::validate): Refined the code to handle canonicalization differently from expanding due to granularity. Canonicalization is done preserving the original m_anchor/focus as it mostly always has been. But expansion due to granularity now changes m_anchor/focus/base/extent rather than just m_start/end. This makes sense because granularity changes actually affect what is selected, while canonicalization just changes how the selection is expressed and tracked. (WebCore::VisibleSelection::setWithoutValidation): Set m_anchor/focus. In the future, we can probably get rid of this eventually, because the "validation" talked about here is the unwanted canonicalization. But that's a refinement for the future. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Update m_focus, not just m_extent, if we have to adjust. Also removed an unnnecessary null check from the start of the function. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Ditto. Also removed the assertions because these situations can indeed arise and it's not necessarily an indication of a bug in editing code. * editing/VisibleSelection.h: Rearranged constructors to make it slightly more clear which is the main one and that the others are simply convenience shorthands. Might want to come back later and remove some unused ones. Added uncanonicalizedStart, uncanonicalizedEnd, anchor, focus, and range. Renamed the private function called setStartAndEndFromBaseAndExtentRespectingGranularity to the new name adjustSelectionRespectingGranularity. Added m_anchor and m_focus and refined the comments about the position data members. We should eventually be able to cut down on the number of these again, but it's fine to have two more for now. * page/DOMSelection.cpp: (WebCore::DOMSelection::range const): Use range rather than firstRange when live range selection is enabled, for proper round-tripping of selection endpoints, unaffected by canonicalization. The other changes below are for the same reason. (WebCore::DOMSelection::anchorPosition const): Use anchor. (WebCore::DOMSelection::focusPosition const): Use focus. (WebCore::DOMSelection::basePosition const): Use anchor. (WebCore::DOMSelection::extentPosition const): Use focus. (WebCore::DOMSelection::type const): Use isInDocumentTree and range rather than isNone/isCaret/isRange when live range selection is enabled, because this needs to report "Caret" when the range is not collapsed, even if the canonicalized range is collapsed and "None" when the selection is in a shadow tree. (WebCore::DOMSelection::rangeCount const): Use isInDocumentTree to check if there is a selection rather than isNone to correctly handle the shadow tree case. (WebCore::DOMSelection::collapseToEnd): Use uncanonicalizedEnd. (WebCore::DOMSelection::collapseToStart): Use uncanonicalizedStart. (WebCore::DOMSelection::containsNode const): Updated the comment for clarity. LayoutTests: * editing/execCommand/insert-list-nested-with-orphaned-expected.txt: This test result reflected incorrrect behavior where the selection changed from a range to a caret in a certain unusual case. The new behavior of leaving the text selected is consistent with how the command works in normal cases, and was an accidental progression from the improvements to the selection code. Was able to reproduce this all in Safari and after experimenting with different selections, it's clear this is an improvement. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

ysuzuki@apple.com

commit sha 81d04bdc59ccc6be00b672782c15e7c29a031db9

[JSC] Drop Options::useBigInt https://bugs.webkit.org/show_bug.cgi?id=216743 Reviewed by Darin Adler. JSTests: * bigIntTests.yaml: Removed. * stress/big-int-add-wrapped-value.js: * stress/big-int-addition-basic.js: * stress/big-int-addition-jit.js: * stress/big-int-addition-memory-stress.js: * stress/big-int-addition-string-coercion.js: * stress/big-int-addition-to-primitive-precedence.js: * stress/big-int-addition-to-primitive.js: * stress/big-int-addition-type-error.js: * stress/big-int-arithmetic-return-big-int.js: * stress/big-int-as-key.js: * stress/big-int-as-property-name.js: * stress/big-int-bit-not-general.js: * stress/big-int-bitwise-and-general.js: * stress/big-int-bitwise-and-jit.js: * stress/big-int-bitwise-and-memory-stress.js: * stress/big-int-bitwise-and-to-primitive-precedence.js: * stress/big-int-bitwise-and-type-error.js: * stress/big-int-bitwise-and-wrapped-value.js: * stress/big-int-bitwise-not-jit.js: * stress/big-int-bitwise-not-wrapped-value.js: * stress/big-int-bitwise-or-general.js: * stress/big-int-bitwise-or-jit-untyped.js: * stress/big-int-bitwise-or-jit.js: * stress/big-int-bitwise-or-memory-stress.js: * stress/big-int-bitwise-or-to-primitive-precedence.js: * stress/big-int-bitwise-or-type-error.js: * stress/big-int-bitwise-or-wrapped-value.js: * stress/big-int-bitwise-xor-general.js: * stress/big-int-bitwise-xor-jit.js: * stress/big-int-bitwise-xor-memory-stress.js: * stress/big-int-bitwise-xor-to-primitive-precedence.js: * stress/big-int-bitwise-xor-type-error.js: * stress/big-int-bitwise-xor-untyped.js: * stress/big-int-bitwise-xor-wrapped-value.js: * stress/big-int-boolean-proven-type.js: * stress/big-int-branch-usage.js: * stress/big-int-constructor-gc.js: * stress/big-int-constructor-oom.js: * stress/big-int-constructor-properties.js: * stress/big-int-constructor-prototype-prop-descriptor.js: * stress/big-int-constructor-prototype.js: * stress/big-int-constructor.js: * stress/big-int-div-jit-osr.js: * stress/big-int-div-jit-untyped.js: * stress/big-int-div-jit.js: * stress/big-int-div-memory-stress.js: * stress/big-int-div-to-primitive.js: * stress/big-int-div-type-error.js: * stress/big-int-div-wrapped-value.js: * stress/big-int-division.js: * stress/big-int-equals-basic.js: * stress/big-int-equals-to-primitive-precedence.js: * stress/big-int-equals-wrapped-value.js: * stress/big-int-exp-basic.js: * stress/big-int-exp-jit-osr.js: * stress/big-int-exp-jit-untyped.js: * stress/big-int-exp-jit.js: * stress/big-int-exp-negative-exponent.js: * stress/big-int-exp-to-primitive.js: * stress/big-int-exp-type-error.js: * stress/big-int-exp-wrapped-value.js: * stress/big-int-function-apply.js: * stress/big-int-greater-than-general.js: * stress/big-int-greater-than-jit.js: * stress/big-int-greater-than-or-equal-jit.js: * stress/big-int-greater-than-or-equal-order-of-evaluation.js: * stress/big-int-greater-than-or-equal-wrapped-values.js: * stress/big-int-greater-than-or-equal.js: * stress/big-int-greater-than-order-of-evaluation.js: * stress/big-int-greater-than-wrapped-values.js: * stress/big-int-json-stringify-to-json.js: * stress/big-int-json-stringify.js: * stress/big-int-left-shift-general.js: * stress/big-int-left-shift-range-error.js: * stress/big-int-left-shift-type-error.js: * stress/big-int-left-shift-untyped.js: * stress/big-int-left-shift-wrapped-value.js: * stress/big-int-length.js: * stress/big-int-less-than-general.js: * stress/big-int-less-than-jit.js: * stress/big-int-less-than-or-equal-general.js: * stress/big-int-less-than-or-equal-jit.js: * stress/big-int-less-than-or-equal-order-of-evaluation.js: * stress/big-int-less-than-or-equal-wrapped-values.js: * stress/big-int-less-than-order-of-evaluation.js: * stress/big-int-less-than-wrapped-values.js: * stress/big-int-literal-inside-literal-object.js: * stress/big-int-literal-line-terminator.js: * stress/big-int-literals.js: * stress/big-int-logical-and.js: * stress/big-int-logical-not.js: * stress/big-int-logical-or.js: * stress/big-int-mod-jit.js: * stress/big-int-mod-memory-stress.js: * stress/big-int-mod-osr.js: * stress/big-int-mod-to-primitive-precedence.js: * stress/big-int-mod-to-primitive.js: * stress/big-int-mod-type-error.js: * stress/big-int-mod-wrapped-value.js: * stress/big-int-mod.js: * stress/big-int-mul-jit-osr.js: * stress/big-int-mul-jit-untyped.js: * stress/big-int-mul-jit.js: * stress/big-int-mul-to-primitive-precedence.js: * stress/big-int-mul-to-primitive.js: * stress/big-int-mul-type-error.js: * stress/big-int-mul-wrapped-value.js: * stress/big-int-multiplication.js: * stress/big-int-multiply-memory-stress.js: * stress/big-int-negate-basic.js: * stress/big-int-no-conversion-to-number.js: * stress/big-int-operations-error.js: * stress/big-int-out-of-memory-tests.js: * stress/big-int-prop-descriptor.js: * stress/big-int-proto-constructor.js: * stress/big-int-proto-name.js: * stress/big-int-prototype-properties.js: * stress/big-int-prototype-proto.js: * stress/big-int-prototype-symbol-to-string-tag.js: * stress/big-int-prototype-to-string-apply.js: * stress/big-int-prototype-to-string-cast-overflow.js: * stress/big-int-prototype-to-string-exception.js: * stress/big-int-prototype-to-string-wrong-values.js: * stress/big-int-prototype-value-of.js: * stress/big-int-right-shift-general.js: * stress/big-int-right-shift-jit-osr.js: * stress/big-int-right-shift-jit-untyped.js: * stress/big-int-right-shift-jit.js: * stress/big-int-right-shift-type-error.js: * stress/big-int-right-shift-wrapped-value.js: * stress/big-int-spec-to-primitive.js: * stress/big-int-spec-to-this.js: * stress/big-int-strict-equals-jit.js: * stress/big-int-strict-spec-to-this.js: * stress/big-int-sub-wrapped-value.js: * stress/big-int-subtraction-basic.js: * stress/big-int-subtraction-jit.js: * stress/big-int-subtraction-type-error.js: * stress/big-int-to-object.js: * stress/big-int-to-string.js: * stress/big-int-type-of-proven-type-non-constant-including-symbol.js: * stress/big-int-type-of-proven-type-non-constant.js: * stress/big-int-type-of-proven-type.js: * stress/big-int-type-of.js: * stress/big-int-unary-plus.js: * stress/big-int-value-op-update-gc-rules.js: * stress/big-int-white-space-trailing-leading.js: * stress/bigint-toLocaleString.js: * stress/bitwise-not-fixup-rules.js: * stress/delete-property-inline-cache.js: * stress/inc-osr-exit-from-big-int.js: * stress/inc-osr-exit-to-big-int.js: * stress/left-shift-to-primitive-precedence.js: * stress/numeric-literal-separators.js: * stress/object-create-non-object-properties-parameter.js: * stress/proxy-call-apply-handler-to-this.js: * stress/right-shift-to-primitive-precedence.js: * stress/value-add-big-int-and-string.js: * stress/value-add-big-int-prediction-propagation.js: * stress/value-add-big-int-untyped.js: * stress/value-bit-and-ai-rule.js: * stress/value-bit-lshift-ai-rule.js: * stress/value-bit-not-ai-rule.js: * stress/value-bit-or-ai-rule.js: * stress/value-bit-xor-ai-rule.js: * stress/value-div-fixup-int32-big-int.js: * stress/value-mul-fixup-int32-big-int.js: * stress/value-sub-big-int-prediction-propagation.js: * stress/value-sub-big-int-untyped.js: * test262/config.yaml: Source/JavaScriptCore: Now BigInt is shipped. Let's just remove Options::useBigInt. * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitEqualityOpImpl): * parser/Lexer.cpp: (JSC::Lexer<T>::parseHex): (JSC::Lexer<T>::parseBinary): (JSC::Lexer<T>::parseOctal): (JSC::Lexer<T>::parseDecimal): * runtime/JSGlobalObject.h: * runtime/OptionsList.h: Tools: * Scripts/run-jsc-benchmarks: * Scripts/run-jsc-stress-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

weinig@apple.com

commit sha 3c7630ff0aa491e59ed31d798c88850e3977d178

Using [Exposed=Window] with [Default] object toJSON() doesn't work https://bugs.webkit.org/show_bug.cgi?id=216731 Reviewed by Simon Fraser. Fixes filtering an attribute out of [Default] toJSON operation based on which which global objects it is exposed to by ensuring we always pass a global object pointer accessor function to GenerateRuntimeEnableConditionalStringForExposed. For good measure, we now always pass the global object object pointer to GenerateRuntimeEnableConditionalString as well so that it is always explicit. This is needed to support filtering out Performance.navigation and Performance.timing from the Performance interface's toJSON implementation which will be addressed in a separate change. * bindings/scripts/CodeGeneratorJS.pm: (GenerateRuntimeEnableConditionalStringForExposed): (GenerateRuntimeEnableConditionalString): Remove implicit global object accessor string construction by always requiring it to be passed. * bindings/scripts/test/DOMWindowConstructors.idl: * bindings/scripts/test/JS/JSDOMWindow.cpp: * bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp: Added. * bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.h: Added. * bindings/scripts/test/JS/JSWorkerGlobalScope.cpp: * bindings/scripts/test/SupplementalDependencies.dep: * bindings/scripts/test/TestDefaultToJSONFilteredByExposed.idl: Added. * bindings/scripts/test/WorkerGlobalScopeConstructors.idl: Add new test for updated behavior. I couldn't add it to the existing TestDefaultToJSON.idl test as that test requires the interface only be exposed to Window to support testing EnabledBySetting. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

ysuzuki@apple.com

commit sha 07fb3b11aecf473a4b606cc4d24b14a0be448843

Test262 update https://bugs.webkit.org/show_bug.cgi?id=216753 Reviewed by Darin Adler. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

push time in a month

push eventphiln/webkit

Philippe Normand

commit sha 8226526ad57759ddd2af4131d8b5aecc51d53f98

Common: Add GstStructure to JSON support

view details

Philippe Normand

commit sha 528be4e86596d74c0092562db083fcf01b9b6cba

[GStreamer] Alternative WebRTC backend based on GstWebRTC

view details

Philippe Normand

commit sha 9ad5e7edf0596a61851c96cd498a103053212826

MediaStream: MediaConstraints serialization to JSON

view details

Philippe Normand

commit sha 618baeea0699b4edc3a191b42e77aadc09dc0bac

RealtimeVideoSource: proxy more methods from underlying capture source

view details

Philippe Normand

commit sha 2496f6bf5d3ea6a7cdc793f26128239f1106ec9c

GStreamerVideoEncoder: Make h264 less laggy

view details

Philippe Normand

commit sha 702f59ccf4633b118a6f0b2b7edfff187e937113

GStreamerVideoEncoder: Failed attempt at configuring VP9

view details

Philippe Normand

commit sha e72bc1de358ec300f769b2b16fe4ae3e00528690

MockVideoSource: Simplify sample creation a bit

view details

Philippe Normand

commit sha f594582635b208a957bca381d4f63b50772e68f0

portal wip

view details

push time in a month

push eventphiln/webkit

Philippe Normand

commit sha b6ad05a25b67953a4232a542b25bc65f3794265d

fixup! GStreamerVideoEncoder: Failed attempt at configuring VP9

view details

push time in a month

push eventphiln/webkit

hector_i_lopez@apple.com

commit sha 714064f48c8edd48fe635b3ffd64486c85072455

[ macOS wk1 ] fast/overflow/horizontal-scroll-after-back.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=215778 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

jond@apple.com

commit sha 18ca004b78b6fae8cb361413065abff417a59ca2

Disable unused RPC services https://bugs.webkit.org/show_bug.cgi?id=215779 Reviewed by Alexey Proskuryakov. * .htaccess: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

hector_i_lopez@apple.com

commit sha 59b3bd4bf74696340da48892a326512df5bac463

[ iOS wk2 Debug ] imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/moving-between-documents/before-prepare-iframe-fetch-error-external-module.html is a flaky failure https://bugs.webkit.org/show_bug.cgi?id=215783 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

commit-queue@webkit.org

commit sha 40d906c62c1a003f53562b8b9981911f2c4e58ef

Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory https://bugs.webkit.org/show_bug.cgi?id=213048 Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-24 Reviewed by Youenn Fablet. Source/WebCore/PAL: * pal/spi/cf/CFNetworkSPI.h: Source/WebKit: This uses CFNetwork SPI introduced in rdar://problem/50109631 to allow HSTS storage per NSURLSession. To be complete, I also deprecated our UI process HSTS state removal attempt SPIs, WKContextResetHSTSHosts and WKContextResetHSTSHostsAddedAfterDate, which had their last use removed in rdar://problem/64220838. I manually verified that this new SPI puts HSTS data in the specified location, and I also verified that HSTS state querying and removal works with the new CFNetwork SPI as it did with the old one. * NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::fetchWebsiteData): (WebKit::NetworkProcess::deleteWebsiteData): (WebKit::NetworkProcess::deleteWebsiteDataForOrigins): (WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains): (WebKit::NetworkProcess::registrableDomainsWithWebsiteData): * NetworkProcess/NetworkProcess.h: * NetworkProcess/NetworkSessionCreationParameters.cpp: (WebKit::NetworkSessionCreationParameters::encode const): (WebKit::NetworkSessionCreationParameters::decode): * NetworkProcess/NetworkSessionCreationParameters.h: * NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::hostNamesWithHSTSCache const): (WebKit::NetworkProcess::deleteHSTSCacheForHostNames): (WebKit::NetworkProcess::clearHSTSCache): (WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted. * NetworkProcess/cocoa/NetworkSessionCocoa.h: * NetworkProcess/cocoa/NetworkSessionCocoa.mm: (WebKit::NetworkSessionCocoa::hstsStorage const): (WebKit::NetworkSessionCocoa::NetworkSessionCocoa): * NetworkProcess/soup/NetworkProcessSoup.cpp: (WebKit::NetworkProcess::hostNamesWithHSTSCache const): (WebKit::NetworkProcess::deleteHSTSCacheForHostNames): (WebKit::NetworkProcess::clearHSTSCache): (WebKit::NetworkProcess::getHostNamesWithHSTSCache): Deleted. * UIProcess/API/C/mac/WKContextPrivateMac.h: * UIProcess/API/C/mac/WKContextPrivateMac.mm: (WKContextResetHSTSHosts): (WKContextResetHSTSHostsAddedAfterDate): * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h: * UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm: (-[_WKWebsiteDataStoreConfiguration hstsStorageDirectory]): (-[_WKWebsiteDataStoreConfiguration setHSTSStorageDirectory:]): * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::privateBrowsingSession): Deleted. (WebKit::WebProcessPool::resetHSTSHosts): Deleted. (WebKit::WebProcessPool::resetHSTSHostsAddedAfterDate): Deleted. * UIProcess/WebProcessPool.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary): (WebKit::WebsiteDataStore::parameters): * UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::resolvedHSTSStorageDirectory const): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.cpp: (WebKit::WebsiteDataStoreConfiguration::copy const): * UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: Source/WTF: * wtf/PlatformHave.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

commit-queue@webkit.org

commit sha fa136df2274b69a8cf465f638b3ac25e9c9ac155

Implement Request/Response consuming as FormData https://bugs.webkit.org/show_bug.cgi?id=215671 Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-24 Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/fetch/api/abort/general.any-expected.txt: * web-platform-tests/fetch/api/abort/general.any.worker-expected.txt: * web-platform-tests/fetch/api/request/request-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers. * web-platform-tests/fetch/api/request/request-consume-expected.txt: * web-platform-tests/fetch/api/request/request-init-002-expected.txt: * web-platform-tests/fetch/api/response/response-consume-empty-expected.txt: This remaining failing test now fails similarly in all browsers. * web-platform-tests/fetch/api/response/response-consume-expected.txt: * web-platform-tests/fetch/api/response/response-error-from-stream-expected.txt: This change makes the formData failures in this file look like all the other failures in this file, which should be fixed together in a separate patch. * web-platform-tests/fetch/api/response/response-init-002-expected.txt: * web-platform-tests/url/urlencoded-parser.any-expected.txt: * web-platform-tests/url/urlencoded-parser.any.worker-expected.txt: * web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https-expected.txt: Source/WebCore: Covered by many newly passing WPT tests, for most of which Safari was the only failing browser. * Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::formData): (WebCore::FetchBody::consume): (WebCore::FetchBody::consumeFormData): * Modules/fetch/FetchBody.h: * Modules/fetch/FetchBodyConsumer.cpp: (WebCore::formDataFromData): (WebCore::resolveWithTypeAndData): (WebCore::FetchBodyConsumer::resolve): * Modules/fetch/FetchBodyConsumer.h: Source/WebKit: * WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: (WebKit::WebServiceWorkerFetchTaskClient::didReceiveFormDataAndFinish): Add a fast path that allows non-blob FormData responses from service workers to not hang. This part is covered by this layout test: imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-custom-response.https.html Source/WTF: In order to be compatible with other browsers, we need a verson of String::fromUTF8 that uses U8_NEXT_OR_FFFD instead of U8_NEXT, but changing that across the board will break other things. Leave everything else as it is, use templates and constexpr to not add any branches, but add String::fromUTF8ReplacingInvalidSequences to allow me to make our FormData consuming compatible with other browsers. * wtf/text/WTFString.cpp: (WTF::fromUTF8Helper): (WTF::String::fromUTF8): (WTF::String::fromUTF8ReplacingInvalidSequences): * wtf/text/WTFString.h: * wtf/unicode/UTF8Conversion.cpp: (WTF::Unicode::convertUTF8ToUTF16Impl): (WTF::Unicode::convertUTF8ToUTF16): (WTF::Unicode::convertUTF8ToUTF16ReplacingInvalidSequences): * wtf/unicode/UTF8Conversion.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

aakash_jain@apple.com

commit sha e8c030ba17b9fdce03813204906a133405f88570

[ews] set references header in email so as to group similar emails together https://bugs.webkit.org/show_bug.cgi?id=215777 Reviewed by Jonathan Bedard. * BuildSlaveSupport/ews-build/send_email.py: (send_email): Add support for setting references header. (send_email_to_patch_author): (send_email_to_bot_watchers): * BuildSlaveSupport/ews-build/steps.py: (AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Set references header appropriately. (ReRunWebKitTests.send_email_for_flaky_failure): Ditto. (AnalyzeLayoutTestsResults.send_email_for_flaky_failure): Ditto. (AnalyzeLayoutTestsResults.send_email_for_pre_existing_failure): Ditto. (AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

aakash_jain@apple.com

commit sha b853e1c9949dcfc7305c58612c94a2d0e5be1f7b

[ews] enable email notifications to patch authors for build or layout test failures on their patch https://bugs.webkit.org/show_bug.cgi?id=215776 Reviewed by Jonathan Bedard. * BuildSlaveSupport/ews-build/steps.py: (AnalyzeCompileWebKitResults.analyzeResults): Send email notification to patch authors for build failure due to their patch. (AnalyzeLayoutTestsResults.report_failure): Send email notification to patch authors for layout test failure. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

wenson_hsieh@apple.com

commit sha b399f54afa5567a1e51e24ecba225a8b2e39ea96

Unreviewed, fix the internal iOS 13.4 build Source/WebKit: The -_selectionClipRect SPI method isn't declared in any private headers on iOS 13.4 and prior. This isn't a problem when building with a non-internal SDK since the SPI is declared in the `!USE(APPLE_INTERNAL_SDK)` section in `UIKitSPI.h`, but on internal builds of iOS 13.4, this declaration is absent from both the internal SDK and `UIKitSPI.h`. To fix the build, simply declare it in the IPI section — once we stop supporting iOS 13.4 as a build target, this can be moved back into the non-internal section only. * Platform/spi/ios/UIKitSPI.h: Tools: See Source/WebKit/ChangeLog. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::clipSelectionViewRectToContentView): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

keith_miller@apple.com

commit sha c17ee8b9812327422d313894fd1f85d50119c6b4

Update test262 (mid Aug 2020 edition) https://bugs.webkit.org/show_bug.cgi?id=215784 Rubber-stamped by Saam Barati and Yusuke Suzuki. * test262/expectations.yaml: * test262/latest-changes-summary.txt: * test262/test/built-ins/String/prototype/split/limit-touint32-error.js: Added. (ExpectedError): (ExpectedError.prototype.toString): (nonStringableSeparator.Symbol.toPrimitive): (nonStringableSeparator.toString): (nonStringableSeparator.valueOf): (nonNumberableLimit.Symbol.toPrimitive): * test262/test/built-ins/String/prototype/split/separator-tostring-error.js: Added. (ExpectedError): (ExpectedError.prototype.toString): (nonStringableSeparator.toString): * test262/test/built-ins/String/prototype/split/separator-undef-limit-zero.js: * test262/test/built-ins/String/prototype/split/this-value-tostring-error.js: Added. (ExpectedError): (ExpectedError.prototype.toString): (nonStringableReceiver.toString): (splitter.Symbol.split): (catch): (nonStringableSeparator.Symbol.toPrimitive): (nonStringableSeparator.toString): (nonStringableSeparator.valueOf): * test262/test/language/module-code/export-default-asyncfunction-declaration-binding-exists.js: Added. (A): (export.default.async A): * test262/test/language/module-code/export-default-asyncfunction-declaration-binding.js: Added. (export.default.async A): * test262/test/language/module-code/export-default-asyncgenerator-declaration-binding-exists.js: Added. (AG): (export.default.async AG): * test262/test/language/module-code/export-default-asyncgenerator-declaration-binding.js: Added. (export.default.async AG): * test262/test/language/module-code/export-default-function-declaration-binding-exists.js: Added. (F): (export.default.F): * test262/test/language/module-code/export-default-function-declaration-binding.js: Added. (export.default.F): * test262/test/language/module-code/export-default-generator-declaration-binding-exists.js: Added. (G): (export.default.G): * test262/test/language/module-code/export-default-generator-declaration-binding.js: Added. (export.default.G): * test262/test262-Revision.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

rackler@apple.com

commit sha f02647b0f32938a05927ec81916697fb50f81b22

rdar://67706887 (REGRESSION (r264950): [ iOS 13 WK2 ] imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml.html is a constant failure) Unreviewed test gardening. * platform/ios-13/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

hector_i_lopez@apple.com

commit sha 6e2d0a59284505d5db6449edee799d5417ec1485

[ macOS ] Tests expectations changed as test passing but expected to fail https://bugs.webkit.org/show_bug.cgi?id=215786 Unreviewed test gardening. * TestExpectations: * platform/ios-wk2/TestExpectations: * platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

keith_miller@apple.com

commit sha 99edca3d8c118d5e80547cc7953cb50c3aab1568

Remove MovHintRemoval phase https://bugs.webkit.org/show_bug.cgi?id=215785 Reviewed by Saam Barati. The MovHintRemoval phase doesn't play nicely with our OSR Availability. Specifically, it needs to do a tricky dance where it marks all the live ranges of the ZombieHints as not exitOK. There's also an issue because we treated unused locals as kill in this block, which is wrong for SSA when a MovHint is used in another block. Since removing MovHintRemoval isn't a performance regression, we are removing it rather than fixing bugs related to it. Relatedly, since the only place we produce ZombieHints is MovHintRemoval this patch also removes that node type. * Sources.txt: * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): * dfg/DFGClobberize.h: (JSC::DFG::clobberize): * dfg/DFGClobbersExitState.cpp: (JSC::DFG::clobbersExitState): * dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): * dfg/DFGMayExit.cpp: * dfg/DFGMovHintRemovalPhase.cpp: Removed. * dfg/DFGMovHintRemovalPhase.h: Removed. * dfg/DFGNode.h: (JSC::DFG::Node::containsMovHint): (JSC::DFG::Node::hasUnlinkedOperand): * dfg/DFGNodeType.h: * dfg/DFGOSRAvailabilityAnalysisPhase.cpp: (JSC::DFG::LocalOSRAvailabilityCalculator::executeNode): * dfg/DFGPhantomInsertionPhase.cpp: * dfg/DFGPlan.cpp: (JSC::DFG::Plan::compileInThreadImpl): * dfg/DFGPredictionPropagationPhase.cpp: * dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileMovHint): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGVarargsForwardingPhase.cpp: * ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile): * ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::validateAIState): (JSC::FTL::DFG::LowerDFGToB3::compileNode): * runtime/OptionsList.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

mmaxfield@apple.com

commit sha 26530b39537d5b861d7fe7ba4c6adf81a20b8084

[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing <rdar://problem/66861801> Unreviewed test gardening. * platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

mmaxfield@apple.com

commit sha 9ebc774f218727e5b17981c891633e1db3068227

[macOS Big Sur] svg/W3C-I18N/tspan-direction-rtl.svg is failing <rdar://problem/66861801> Unreviewed test gardening. platform/mac-bigsur/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed property svn:keywords. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

achristensen@apple.com

commit sha 6166246661ac6206ddc279970c71c7a05c8f0103

Update iOS layout test results after r266087 https://bugs.webkit.org/show_bug.cgi?id=215671 * web-platform-tests/fetch/content-encoding/bad-gzip-body.any.worker-expected.txt: Apparently there's a newly passing test here, too. I wonder why macOS isn't affected by this change. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

beidson@apple.com

commit sha 2d21563fb9350c3d6fc04060e4ec3a1245858893

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::PDFPlugin::createScrollbar <rdar://problem/67473335> and https://bugs.webkit.org/show_bug.cgi?id=215787 Reviewed by Tim Horton. To quote Tim from r264945: No new tests; timing is such that I can't reproduce without inserting intentional delays into the main thread hops, which is further than I'm willing to go for a test. This is a speculative fix due to the aforementioned reproducibility issue. * WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::receivedNonLinearizedPDFSentinel): Check on the main thread whenever this is called, instead of when deciding to dispatch to the main thread. (WebKit::PDFPlugin::threadEntry): We can't do this check on the background thread when considering the dispatch to the main thread, as the flag might've changed by then. Let's *just* check it on the main thread. (WebKit::PDFPlugin::adoptBackgroundThreadDocument): We can't do the check on the background thread when (WebKit::PDFPlugin::updateScrollbars): This is where the crash itself is. All of the Obj-C code in here is safe to do after destroy(), up until the very end when we get into pluginView() derefencing. So it seems prudent to add another check here. (WebKit::PDFPlugin::documentDataDidFinishLoading): In addition to receivedNonLinearizedPDFSentinel and adoptBackgroundThreadDocument, this is the final of the (3) calls that end up calling installPDFDocument, so for added coverage it seems like a prudent place to add the check. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

commit-queue@webkit.org

commit sha e0bcf11e2bf919e05f3556f487a61b8908be6e21

Make TLSVersion.DefaultBehavior more robust https://bugs.webkit.org/show_bug.cgi?id=215791 Patch by Alex Christensen <achristensen@webkit.org> on 2020-08-24 Reviewed by Darin Adler. After r265573 sometimes it would assert, which is not a problem because it was failing the first connection then succeeding the second connection as intended and as happens in the real internet. Use HTTPServer which accepts a variable number of connections to keep the test coverage. * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: (TestWebKitAPI::TEST): * TestWebKitAPI/cocoa/HTTPServer.h: * TestWebKitAPI/cocoa/HTTPServer.mm: (TestWebKitAPI::HTTPServer::respondWithChallengeThenOK): (TestWebKitAPI::HTTPServer::respondWithOK): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

keith_miller@apple.com

commit sha b20e30b9e19da2ed69d88520c955df8d6002b83a

DFG should always run CFG Simplification after Constant Folding. https://bugs.webkit.org/show_bug.cgi?id=215286 Reviewed by Robin Morisset. We didn't do this originally because LICM, many years ago, was unsound if the CFG didn't have exactly the right shape around loops. This is no longer true so we don't have to worry about changing the CFG anymore. While, this doesn't appear to be a speedup on JetStream 2 CFG, probably because we'd eventually simplify the graph in B3, CFG Simplification is very cheap and make other DFG optimizations easier in the future. Also, remove unecessary validation rule that no exitOKs can come before any Phi nodes in DFG. This isn't required and fails after merging two basic blocks where the latter block has a Phi. * dfg/DFGCFGSimplificationPhase.cpp: (JSC::DFG::CFGSimplificationPhase::run): * dfg/DFGPlan.cpp: (JSC::DFG::Plan::compileInThreadImpl): * dfg/DFGValidate.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

achristensen@apple.com

commit sha e60f4e4bea282588ef27c0cdb5a20748857f00b6

Fix TLSVersion.DefaultBehavior on Mojave https://bugs.webkit.org/show_bug.cgi?id=215791 * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: HTTPServer::Protocol::HttpsWithLegacyTLS uses tls_protocol_version_t, so this test times out on Mojave. Enable it for newer OSes. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

carlosgc@webkit.org

commit sha ff7199d15d19fca14d677cb3d3ad0aea6bfa80fa

[GTK] Implement rendering frames timeline panel for GTK+ port https://bugs.webkit.org/show_bug.cgi?id=150392 <rdar://problem/23200510> Reviewed by Brian Burg. Source/WebCore: Use new RunLoop API to observe the run loop events when the GLib event loop is used. * inspector/agents/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::internalStart): (WebCore::InspectorTimelineAgent::internalStop): * inspector/agents/InspectorTimelineAgent.h: Source/WTF: Add API to observe RunLoop events for GLib event loop implementation. * wtf/RunLoop.h: * wtf/glib/RunLoopGLib.cpp: (WTF::RunLoop::RunLoop): Use RunLoopSource struct and initialize the RunLoop. (WTF::RunLoop::observe): Add the given observer to the set. (WTF::RunLoop::notify): Notife observers of the given event. (WTF::RunLoop::TimerBase::TimerBase): Use RunLoopSource struct and initialize the RunLoop. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@266103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

view details

push time in a month

startedsonnyp/Tangram

started time in a month

push eventphiln/philn

Philippe Normand

commit sha 52772f7b755465dfd901dff0fbde6ea41e510862

Update README.md

view details

push time in a month

issue commentmozilla/sccache

Distributed compilation jobs fail because scheduler thinks that assign_job request times out

Can you rollback the update please? I won't have time to work on this, my apologies.

mstange

comment created time in a month

push eventphiln/philn

Philippe Normand

commit sha 2f75064de5b96ff829dca27320a786c66ad22078

Update README.md

view details

push time in 2 months

startednurdism/neko

started time in 2 months

push eventphiln/glide

Philippe Normand

commit sha 7d6ebd1f61c4fc7836f8757b10ee483a498635aa

Add file drag&drop support Fixes #31

view details

push time in 2 months

issue closedphiln/glide

Open files by drag and drop

It would be a useful feature to allow opening video files by simply drag and drop them into the playback area.

closed time in 2 months

City-busz

push eventphiln/glide

Philippe Normand

commit sha 8aadbaefc2f0786b73fffd041166c4709e1b8c75

ui_context: Get rid of deprecated screen get_{width,height} API

view details

push time in 2 months

push eventflathub/net.baseart.Glide

Philippe Normand

commit sha 933e89ad8d93d13f3ed91dc25f5acc4483d5b58f

Update to GNOME 3.36 runtime 3.34 is EOL.

view details

push time in 2 months

PR merged flathub/net.baseart.Glide

Update to GNOME 3.36 runtime

3.34 is EOL.

+29 -1

2 comments

2 changed files

philn

pr closed time in 2 months

push eventphiln/glide

Philippe Normand

commit sha aafeb2b45d174bca9fd4690c63a8c9b7785ecc6c

appdata: Fix launchable tag This should now be compliant with version 0.12 of the spec...

view details

Philippe Normand

commit sha 906e30d5a3d1be32978531769c856fb973541437

Update dependencies

view details

push time in 2 months

PR opened flathub/net.baseart.Glide

Update to GNOME 3.36 runtime

3.34 is EOL.

+29 -1

0 comment

2 changed files

pr created time in 2 months

create barnchflathub/net.baseart.Glide

branch : gnome-3.36

created branch time in 2 months

push eventphiln/glide

Philippe Normand

commit sha 1e4ffdcbd954e34546936e1b5214c3e4f56b8dd5

Update dependencies

view details

push time in 2 months

delete branch flathub/net.baseart.Glide

delete branch : gnome-3.34

delete time in 2 months

issue openedIgalia/wpewebkit.org

Flatpak install docs

one part could be dedicated to the wpe-releases repo Zan maintains and in a second part we could document how to install binaries coming from the buildbots using the dev SDK, for those who want to test bleeding edge

created time in 2 months

issue closedIgalia/wpe-flatpak

Missing 2.28.2 commits + bump to 2.28.3?

@zdobersek do you have local un-pushed commits for this repo?

$ flatpak run org.wpe.Cog --version
0.6.0 (WPE WebKit 2.28.2)
$ flatpak info org.wpe.Platform
WPE Application Platform version stable - Shared libraries used by WPE
applications

          ID: org.wpe.Platform
         Ref: runtime/org.wpe.Platform/x86_64/stable
        Arch: x86_64
      Branch: stable
     License: GPL-2.0+
      Origin: wpe-releases
  Collection: 
Installation: user
   Installed: 843.5 MB

      Commit: fa972185e479422facdeccbea685bf41fef42879033938b3b12606859b021818
      Parent: 867ffa28ce52e613ed32e91e7586c7bcfe58fa8b594a17a4de38a6a7a037ef5a
     Subject: org.wpe flatpak runtime, Wed 29 Apr 2020 08:57:09 PM CEST
        Date: 2020-04-29 19:08:00 +0000

But the current SDK definitions refer to 2.28.0.

closed time in 2 months

philn

pull request commentTencent/rapidjson

Fix build warnings emitted by GCC 10 on Aarch64

The value of unsigned vars can't be higher than 255 though. Instead of a pragma this might need some rework.

philn

comment created time in 2 months

PR opened Tencent/rapidjson

Fix build warnings emitted by GCC 10 on Aarch64
+3 -3

0 comment

2 changed files

pr created time in 2 months

more