profile
viewpoint
Pierre Gayvallet pgayvallet elastic.co Lausanne Kibana Platform @ elastic.co

pgayvallet/infini-table 1

Customizable table directive for angular.js

pgayvallet/kubernetes 1

minimal and immutable Kubernetes images built with LinuxKit

pgayvallet/linuxkit 1

A toolkit for building secure, portable and lean operating systems for containers

pgayvallet/vpnkit 1

A toolkit for embedding VPN capabilities in your application

pgayvallet/wro4j-extension-less-java5 1

Less Css compiler extension for wro4j, from the original wro4j-extensions project, adapted to compile to java 5

guillaumerose/docker-ce-engine 0

Tracker for directory docker/docker-ce components/engine

pgayvallet/apiserver-builder 0

apiserver-builder implements libraries and tools to quickly and easily build Kubernetes apiservers to support custom resource types

pgayvallet/app 0

Make your Docker Compose applications reusable, and share them on Docker Hub

push eventpgayvallet/kibana

Pierre Gayvallet

commit sha 04aaba80f727ed9b71a744abd7bb60ca2f64c782

[GS] add savedObjects result provider (#68619) * create server-side skeleton * add base implementation & tests * add unit test for provider * remove useless contracts * add preference search option * implement score from find results * fix types * add FTR test * fix test plugin types * address ome review comments * add multi results test * use `getVisibleTypes`

view details

Tim Roes

commit sha cb302689a54ec986f34193cbc221c40fc8c92b1d

Remove IE11 mention from PR template [skip ci] (#70486) * Remove IE11 mention from PR template * Add link to browser matrix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

patrykkopycinski

commit sha 226b4e70677c70864703bda5f8413a29a0fb4fd7

[Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (#69345)

view details

Vadim Dalecky

commit sha 2c27bad7c9f06a1c7d73dcd98f09191e6a34efc5

test: 💍 delete a flaky test (#70785)

view details

pgayvallet

commit sha 725e1979cdd225654757b94368eedeaa0ac403c5

Merge remote-tracking branch 'upstream/master' into kbn-35508-rename-legacy-mocks

view details

push time in 16 hours

issue closedelastic/kibana

Generic UI search API

To power Global Search (#57576) and future features like ChatOps, we should provide a general framework for searching for various objects, apps, and other locations in the UI that a user may want to find quickly.

This framework should allow plugins to provide different "data sources" of which may be backed by Elasticsearch indices or other items (eg. application links).

The search framework should be able to take a search inputs, call each data source, and aggregate results into something sensible.

Tasks

  • [x] GS API RFC - https://github.com/elastic/kibana/pull/64284
  • [x] GS API implementation - https://github.com/elastic/kibana/pull/66293
  • [x] implement SavedObject result provider - https://github.com/elastic/kibana/issues/65222
  • [x] implement Application result provider - https://github.com/elastic/kibana/issues/65633

closed time in 16 hours

joshdover

issue commentelastic/kibana

Generic UI search API

Closing as all sub tasks have been addressed.

joshdover

comment created time in 16 hours

push eventelastic/kibana

Pierre Gayvallet

commit sha 1dd665e27c8d61c7e0116f26f2a348fabf0c9202

[GS] add savedObjects result provider (#68619) (#70787) * create server-side skeleton * add base implementation & tests * add unit test for provider * remove useless contracts * add preference search option * implement score from find results * fix types * add FTR test * fix test plugin types * address ome review comments * add multi results test * use `getVisibleTypes`

view details

push time in 16 hours

PR merged elastic/kibana

[7.x] [GS] add savedObjects result provider (#68619) backport

Backports the following commits to 7.x:

  • [GS] add savedObjects result provider (#68619)
+1382 -7

1 comment

18 changed files

pgayvallet

pr closed time in 16 hours

issue commentelastic/kibana

Automatically extend plugin config schema with `enabled`

Depends on #59083

The chosen implementation for #59083 do not allow consumers to check if a specific key is present in a given instance of ObjectType, meaning that 'adding a key if not present' is not possible atm.

joshdover

comment created time in 16 hours

PR opened elastic/kibana

Rename HttpServerInfo.host to hostname

Summary

Fix https://github.com/elastic/kibana/issues/69373

Rename HttpServerInfo.host to HttpServerInfo.hostname

Checklist

  • [x] Documentation was added for features that require explanation or tutorials
+15 -28

0 comment

14 changed files

pr created time in 17 hours

create barnchpgayvallet/kibana

branch : kbn-69373-serverinfo-hostname

created branch time in 17 hours

push eventpgayvallet/kibana

Victor Martinez

commit sha 564e91fdecedbe47d59ab0f6be1e87ba332b5ed4

[APM-UI] e2e speed up build (#70704)

view details

Pierre Gayvallet

commit sha 2a43b48ac77d832134d8f6dcc8ae5f391170fd98

remove snapshot from disabled test suite. (#70769)

view details

Pierre Gayvallet

commit sha 04aaba80f727ed9b71a744abd7bb60ca2f64c782

[GS] add savedObjects result provider (#68619) * create server-side skeleton * add base implementation & tests * add unit test for provider * remove useless contracts * add preference search option * implement score from find results * fix types * add FTR test * fix test plugin types * address ome review comments * add multi results test * use `getVisibleTypes`

view details

Tim Roes

commit sha cb302689a54ec986f34193cbc221c40fc8c92b1d

Remove IE11 mention from PR template [skip ci] (#70486) * Remove IE11 mention from PR template * Add link to browser matrix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

patrykkopycinski

commit sha 226b4e70677c70864703bda5f8413a29a0fb4fd7

[Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (#69345)

view details

push time in 18 hours

Pull request review commentelastic/kibana

[KP] Separate onPreAuth & onPreRouting http interceptors

 describe('OnPreResponse', () => {     await supertest(innerServer.listener).get('/').expect(200);   }); });++describe('run interceptors in the right order', () => {+  it('with Auth registered', async () => {

👍 , was gonna ask to add such a test.

restrry

comment created time in 18 hours

Pull request review commentelastic/kibana

[KP] Separate onPreAuth & onPreRouting http interceptors

 describe('OnPreResponse', () => {     await supertest(innerServer.listener).get('/').expect(200);   }); });++describe('run interceptors in the right order', () => {+  it('with Auth registered', async () => {+    const {+      registerOnPreRouting,+      registerOnPreAuth,+      registerAuth,+      registerOnPostAuth,+      registerOnPreResponse,+      server: innerServer,+      createRouter,+    } = await server.setup(setupDeps);++    const router = createRouter('/');++    const executionOrder: string[] = [];+    registerOnPreRouting((req, res, t) => {+      executionOrder.push('onOpeRouting');+      return t.next();

NIT (I think?) onOpe -> onPre (multiple occurences)

restrry

comment created time in 18 hours

Pull request review commentelastic/kibana

[KP] Separate onPreAuth & onPreRouting http interceptors

 describe('setup contract', () => {     });   }); -  describe('#registerOnPreAuth', () => {+  describe('#registerOnPreRouting', () => {     test('does not throw if called after stop', async () => {-      const { registerOnPreAuth } = await server.setup(config);+      const { registerOnPreRouting } = await server.setup(config);

NIT: not that these tests are really of any significant use, but for consistency maybe add one for the 'new' registerOnPreAuth?

restrry

comment created time in 18 hours

Pull request review commentelastic/kibana

[KP] Separate onPreAuth & onPreRouting http interceptors

 export interface HttpServerSetup { /** @internal */ export type LifecycleRegistrar = Pick<   HttpServerSetup,-  'registerAuth' | 'registerOnPreAuth' | 'registerOnPostAuth' | 'registerOnPreResponse'+  'registerAuth' | 'registerOnPreRouting' | 'registerOnPostAuth' | 'registerOnPreResponse'

NIT: maybe add instead of replace?

restrry

comment created time in 18 hours

PR opened elastic/kibana

[7.x] [GS] add savedObjects result provider (#68619)

Backports the following commits to 7.x:

  • [GS] add savedObjects result provider (#68619)
+1382 -7

0 comment

18 changed files

pr created time in 18 hours

create barnchpgayvallet/kibana

branch : backport/7.x/pr-68619

created branch time in 18 hours

push eventelastic/kibana

Pierre Gayvallet

commit sha 04aaba80f727ed9b71a744abd7bb60ca2f64c782

[GS] add savedObjects result provider (#68619) * create server-side skeleton * add base implementation & tests * add unit test for provider * remove useless contracts * add preference search option * implement score from find results * fix types * add FTR test * fix test plugin types * address ome review comments * add multi results test * use `getVisibleTypes`

view details

push time in 18 hours

PR merged elastic/kibana

[GS] add savedObjects result provider Team:Platform release_note:skip v7.9.0 v8.0.0

Summary

Fix https://github.com/elastic/kibana/issues/65222

Checklist

+1382 -7

5 comments

18 changed files

pgayvallet

pr closed time in 18 hours

issue closedelastic/kibana

[GS] SavedObject results provider

This issue is to discuss the concrete implementation of the SavedObject result provider needed for the GlobalSearch MVP: https://github.com/elastic/kibana/issues/58049

Related issues:

  • GS meta issue: https://github.com/elastic/kibana/issues/57576
  • GS plugin API: https://github.com/elastic/kibana/issues/61657
  • GS API RFC: https://github.com/elastic/kibana/pull/64284

From https://github.com/elastic/kibana/issues/58049, the types of SO we would need to return would be:

  • Dashboards
  • Visualizations
  • Saved searches
  • Canvas workpads
  • Maps
  • Graphs
  • ML jobs (future)
  • SIEM Timelines

Questions:

How exactly will we perform the query / which fields should we search by

It's still unclear which fields we should search by. The base SavedObject type do not even have a title field in the base implementation, and I'm not sure all types actually declare one in their mappings.

Second point, when calling for example gs.find('dash'), should we search on the type field and return all dashboard objects? The type field being a keyword, is this doable?

Is our current find API sufficient, or will we need to create a new one

Directly depends on the first point. I feel like we will need to add a new API to answer the GS needs, even if ideally this would be avoided.

Is it technically possible to retrieve all SO in a single query

For performances, it would be best if we could retrieve all types of saved objects in a single query, instead of performing x (= nb types) queries. Would this be a possibility?

closed time in 18 hours

pgayvallet

pull request commentelastic/kibana

Initial server-side support for sharing saved-objects phase 1.5

Code owners except for kibana-security may be interested in waiting until a final PR is opened against master.

Do you want a first look review from the platform team now, or are we good waiting until the final PR?

jportner

comment created time in 20 hours

push eventpgayvallet/kibana

Victor Martinez

commit sha 564e91fdecedbe47d59ab0f6be1e87ba332b5ed4

[APM-UI] e2e speed up build (#70704)

view details

Pierre Gayvallet

commit sha 2a43b48ac77d832134d8f6dcc8ae5f391170fd98

remove snapshot from disabled test suite. (#70769)

view details

pgayvallet

commit sha 88ae35020d33c6eeb04951877678a472340d2716

Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new-es-client

view details

push time in 20 hours

push eventpgayvallet/kibana

Victor Martinez

commit sha 564e91fdecedbe47d59ab0f6be1e87ba332b5ed4

[APM-UI] e2e speed up build (#70704)

view details

Pierre Gayvallet

commit sha 2a43b48ac77d832134d8f6dcc8ae5f391170fd98

remove snapshot from disabled test suite. (#70769)

view details

pgayvallet

commit sha 62748e57baf6bfad356d7b61bc7fe114ae1f4464

Merge remote-tracking branch 'upstream/master' into kbn-35508-rename-legacy-mocks

view details

push time in 20 hours

push eventpgayvallet/kibana

Victor Martinez

commit sha 564e91fdecedbe47d59ab0f6be1e87ba332b5ed4

[APM-UI] e2e speed up build (#70704)

view details

Pierre Gayvallet

commit sha 2a43b48ac77d832134d8f6dcc8ae5f391170fd98

remove snapshot from disabled test suite. (#70769)

view details

pgayvallet

commit sha eb483765edb1e97ebef570e17338a33fc3b9bb04

Merge remote-tracking branch 'upstream/master' into kbn-65222-gs-so-provider

view details

push time in 20 hours

create barnchpgayvallet/kibana

branch : backport/7.x/pr-70769

created branch time in 20 hours

PR opened elastic/kibana

[7.x] remove snapshot from disabled test suite. (#70769)

Backports the following commits to 7.x:

  • remove snapshot from disabled test suite. (#70769)
+0 -66

0 comment

1 changed file

pr created time in 20 hours

create barnchpgayvallet/kibana

branch : pushing-to-master-kill-kittens-3

created branch time in 21 hours

Pull request review commentelastic/kibana

Add @elastic/safer-lodash-set as an alternative to lodash.set

+/*+ * Elasticsearch B.V licenses this file to you under the MIT License.+ * See `packages/elastic-safer-lodash-set/LICENSE` more information.+ */++const set = require('../lodash/set');+const { cloneDeep, curry } = require('lodash');++module.exports = curry((b, c, a) => set(cloneDeep(a), b, c));

Why the cloneDeep in the fp version of our set / setWith methods? Hard code to follow, but I did not find such behavior in https://github.com/lodash/lodash/blob/npm/fp/_baseConvert.js?

watson

comment created time in 21 hours

Pull request review commentelastic/kibana

Add @elastic/safer-lodash-set as an alternative to lodash.set

+/*+ * This file is forked from the DefinitlyTyped project (https://github.com/DefinitelyTyped/DefinitelyTyped),+ * and may include modifications made by Elasticsearch B.V.+ * Elasticsearch B.V. licenses this file to you under the MIT License.+ * See `packages/elastic-safer-lodash-set/LICENSE` more information.+ */++export = SaferLodashSet;+export as namespace SaferLodashSet;++type Many<T> = T | readonly T[];+type PropertyName = string | number | symbol;+type PropertyPath = Many<PropertyName>;+type SetWithCustomizer<T> = (nsValue: any, key: string, nsObject: T) => any;++declare const SaferLodashSet: SaferLodashSet.SaferLoDashStatic;+declare namespace SaferLodashSet {+  interface SaferLoDashStatic {+    /**+     * Sets the value at path of object. If a portion of path doesn’t exist it’s+     * created. Arrays are created for missing index properties while objects+     * are created for all other missing properties. Use SaferLodashSet.setWith+     * to customize path creation.+     *

Probably a naive question, but did we tried to discuss with upstream whereas they would be interested with this behavioral change (or not) before forking these methods?

watson

comment created time in 21 hours

Pull request review commentelastic/kibana

Search across spaces

 export class SpacesClient {        if (authorized.length === 0) {         this.debugLogger(-          `SpacesClient.getAll(), using RBAC. returning 403/Forbidden. Not authorized for any spaces.`+          `SpacesClient.getAll(), using RBAC. returning 403/Forbidden. Not authorized for any spaces for ${purpose} purpose.`

From the GS perspective, you shouldn't have to figure this out yourself.

Not yet 100% sure on that one. We need to distinguish the results from the current namespace vs the others. We may only need to perform a single query and apply logic depending on the active namespace for that, but we might also want to have some specific search criteria for both searches (current vs other), therefor having a search call for the current NS and another the the others.

Thanks for the snippet btw.

legrego

comment created time in a day

issue closedelastic/kibana

Saved objects table doesn't stretch to the right width

Kibana version: 6.4 Elasticsearch version: 6.3 Server OS version: macOS 10.13.6 Browser version: Chrome Version 67.0.3396.99 (Official Build) (64-bit) Browser OS version: macOS 10.13.6 Original install method (e.g. download page, yum, from source, etc.): from source Describe the bug: Saved objects table doesn't stretch to the right width Steps to reproduce:

  1. Go to management
  2. Click on Saved Objects

Expected behavior: Table width will change according to screen size or at least according to upper bar Screenshots (if relevant): image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

closed time in a day

yaronp68

issue commentelastic/kibana

Saved objects table doesn't stretch to the right width

Closing, fixed on 7.x: the table follow the guidelines of stretching up to the given maximum container width.

yaronp68

comment created time in a day

issue commentelastic/kibana

'@kbn-plugin-helpers build' does not include kibana.json to the build

Will be fixed by https://github.com/elastic/kibana/issues/70412

martijnrondeel

comment created time in a day

issue commentelastic/kibana

Plugin bundle is not created for external new platform plugins resulting in 404

Will be fixed by https://github.com/elastic/kibana/pull/66687

martijnrondeel

comment created time in a day

push eventpgayvallet/kibana

Xavier Mouligneau

commit sha 78fc9fb585b2fe34e65f10afe5f5b522b70c02fa

[SECURITY] Bug fix for topN on draggables (#70450) * back to normal * add unit test * hover issue + indexToAdd issue * fix unit test * review II * fix bug + review * simplification * do not update state when component is unmounted * fix hover action on field name Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Lee Drengenberg

commit sha c3cacba7e2dead10efdf32303873b3c10daa345c

logout from transform_poweruser user in after method of transform tests (#70644) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Dmitry Lemeshko

commit sha fd152689f8caeacfb1d3389739d80b9ac66d7106

[functional tests] test url field formatter on dashboard and discover (#70736) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Madison Caldwell

commit sha e429670c3574188676e2ea69a7272134fa04b203

[Security Solution][Endpoint] Update to new manifest format (without compression) (#70752) * Stateless exception list translation with improved runtime checks * use flatMap and reduce to simplify logic * Update to new manifest format * Fix test fixture SO data type * Fix another test fixture data type * Fix sha256 reference in artifact_client

view details

Tiago Costa

commit sha 86672a7b0764cdcb27a9d5af9e53743c03c3f4be

skip flaky suite (#70762)

view details

Tiago Costa

commit sha c96d9b4ba313f1e2a6aa56b83ce8081db4c92936

skip flaky suite (#70764)

view details

push time in a day

push eventpgayvallet/kibana

kaiyan-sheng

commit sha e1da6a1f8fbc4fd34d7d5454d45af6d02f1ea45b

Add googlecloud metricbeat module to Kibana Home (#70652)

view details

renovate[bot]

commit sha 97ca7bfc2ea0586fcc873b075fda8230f29f9537

Update dependency @elastic/charts to v19.7.0 (#69791) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Kerry Gallagher

commit sha 7ec48fd9662ad7c8898fe3d9162533f8dbafcfc7

[Logs UI] Reorganise log rate anomaly table (#69516) * Remove top level chart Remove top level anomalies chart * Refactor table columns to accomodate new formatting * Tyical vs actual stats in expanded row * Format message based on actual vs typical * Start fleshing out log rate examples endpoint and lib methods * Use the real document ID for expanded rows so React doesn't re-render content * Add all data fetching resources for log entry rate examples * Move log entry example and severity indicator components to a shared location * Render examples for log rate * Add severity indicator * Styling tweaks * Move horizontal button popover menu to a shared components so log rate table can use it * Revert "Move horizontal button popover menu to a shared components so log rate table can use it" This reverts commit f80db5984d74b0e2203d0f7a09ed5ee59d9a39a8. * Add "view in stream" and "view in anomaly explorer" links * Hook links into the new context menu component * Add log column headers and add styling tweaks etc * Fix translations * Tweak comments * Chart tweaks * Update x-pack/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/expanded_row.tsx Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> * PR amendments - Pass href to context menu items - Fix start and end times used for example logs - Use "fewer" rather than "less" * Update x-pack/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> * Update x-pack/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/log_entry_example.tsx Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> * Update x-pack/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/log_entry_example.tsx Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> * Update x-pack/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> * Update x-pack/plugins/infra/server/routes/log_analysis/results/log_entry_rate_examples.ts Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> * Update x-pack/plugins/infra/server/routes/log_analysis/results/log_entry_rate_examples.ts Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> * Update x-pack/plugins/infra/server/routes/log_analysis/results/log_entry_rate_examples.ts Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> * Update x-pack/plugins/infra/server/routes/log_analysis/results/log_entry_rate_examples.ts Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com> * PR amendments - Fix typechecking - Add an empty log example column header to account for the context menu - Add anomaly start time to rows Co-authored-by: Felix Stürmer <weltenwort@users.noreply.github.com>

view details

Xavier Mouligneau

commit sha 78fc9fb585b2fe34e65f10afe5f5b522b70c02fa

[SECURITY] Bug fix for topN on draggables (#70450) * back to normal * add unit test * hover issue + indexToAdd issue * fix unit test * review II * fix bug + review * simplification * do not update state when component is unmounted * fix hover action on field name Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Lee Drengenberg

commit sha c3cacba7e2dead10efdf32303873b3c10daa345c

logout from transform_poweruser user in after method of transform tests (#70644) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Dmitry Lemeshko

commit sha fd152689f8caeacfb1d3389739d80b9ac66d7106

[functional tests] test url field formatter on dashboard and discover (#70736) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Madison Caldwell

commit sha e429670c3574188676e2ea69a7272134fa04b203

[Security Solution][Endpoint] Update to new manifest format (without compression) (#70752) * Stateless exception list translation with improved runtime checks * use flatMap and reduce to simplify logic * Update to new manifest format * Fix test fixture SO data type * Fix another test fixture data type * Fix sha256 reference in artifact_client

view details

Tiago Costa

commit sha 86672a7b0764cdcb27a9d5af9e53743c03c3f4be

skip flaky suite (#70762)

view details

Tiago Costa

commit sha c96d9b4ba313f1e2a6aa56b83ce8081db4c92936

skip flaky suite (#70764)

view details

pgayvallet

commit sha 3f1d9bdfa1792792a19ed3843ae60990ea5a5733

Merge remote-tracking branch 'upstream/master' into kbn-35508-add-new-es-client

view details

push time in a day

push eventpgayvallet/kibana

Tiago Costa

commit sha 7d63cafd5d15ce5e85ba551472f6565f361b39d8

chore(NA): disable alerts_detection_rules cypress suites (#70577)

view details

Eric Davis

commit sha 7b74094e0fa33bd4803dbe105b2a4ea3843ef170

Update docs for api authentication usage (#66819) Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

view details

Jonathan Buttner

commit sha c081caa6341143eb094a9ef00963eaada7d1c72c

[Security_Solution][Endpoint] Leveraging msearch and ancestry array for resolver (#70134) * Refactor generator for ancestry support * Adding optional ancestry array * Refactor the pagination since the totals are not used anymore * Updating the queries to not use aggregations for determining the totals * Refactoring the children helper to handle pagination without totals * Pinning the seed for the resolver tree generator service * Splitting the fetcher into multiple classes for msearch * Updating tests and api for ancestry array and msearch * Adding more comments and fixing type errors * Fixing resolver test import * Fixing tests and type errors * Fixing type errors and tests * Removing useAncestry field * Fixing test * Removing useAncestry field from tests * An empty array will be returned because that's how ES will do it too

view details

Dario Gieselaar

commit sha 429805d1b878919c0b7be081f425d5dc0ec67c09

[APM] Don't fetch dynamic index pattern in setupRequest (#70308) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Joe Reuter

commit sha 3f808688e10864e2d12737844ff4387ae0a2aa27

redirect to default app if hash can not be forwarded (#70417)

view details

Thomas Neirynck

commit sha 9c76f1918649ead38fcc640495bc923c390236bd

[Maps] Add styling and tooltip support to mapbox mvt vector tile sources (#64488) * tmp commit * rename * more boilerpalte * more boiler * more boilerpalte * typing * fix import * boilerplate * more boiler * enable custom palettes * fix label text and orientation * fix merge errors * remove dupe import * stash commit * tmp commit * debounce settings * return null * slight rearrangement * tooltip guard * minor tweaks * feedback * ts fixes * ts fixes * more ts fixes * ts fixes * jest test * fix typo * spacing * fix typing * add unit test * add more tests * add snapshot test * add snapshot * add field editor snapshot test * fix snapshot * add snapshot * remove unused import * test stub for mvt layer fix optional param more checks * add snapshot test more unit tests more unit tests ts fixes * add data syncing unit test * fix autorefactor * fix merge and replace snapshots * field editor changes * field editor changes * ts fixes * update snapshots * fix things * fix names * fix tooltip * add more error handling * improve copy * styling changes * style option box a little better * ts fixes * fix console error * remove mbProperties from interface * remove unused method * remove cruft * rename for consistency * remove unused param * feedback * feedback * ensure properties are always present * handle possible null values * feedback * typo * update SIEM * feedback * remove cruft * remove unused translations * feedback * improve readability * fix brittle test * fix snapshot after master merge * remove unused method * feedback * revert some feedback * remove micro-optimization * initialize in constructor * simplify wording * add snapshot * naming * add clarifying comment * remove unused import * sanitize tooltips * remove cruft * feedback * fix typo * remove export * Design fixes * clean up supportsAutoDomain * remove patch.txt * cleanup * clean-up * Merge in styling changes * Tweak message format * fix broken import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: miukimiu <elizabet.oliveira@elastic.co> Co-authored-by: Nathan Reese <reese.nathan@gmail.com>

view details

Jean-Louis Leysens

commit sha 0066c4b5b05879328e247fa5d6576ea3322c8ed2

[S&R] Support data streams (#68078) * Sort endpoint responses into indices and datastreams The server endpoint for policies now returns data streams and filters out backing indices from the indices array it returned previously * Refactor indices switch and field out of the step settings file * Fix indices field form behaviour * WiP on UI. Added the second table per mockup for add and edit. * add support for creating a policy that backs up data streams end to end * wip on restore flow - added data streams to server response * add logic for detecting whether an index is part of a data stream * fix public jest tests * fix server side jest tests * pivot to different solution in UI while we do not have data streams nicely separated * added data stream to snapshot summary details * move the data streams badge file closer to where it used * add data stream badge when restoring snapshots too * update restore copy * fix pattern specification in indices and data streams field * first iteration of complete policy UX * First iteration that is ready for review Given the contraints on working with data streams and indices in policies at the moment the simplest implementation is to just include data streams with indices and have the user select them there for now. The way snapshotting behaviour is currently implemented relies entirely on what is specified inside of "indices", this is also where data streams must be placed. This unfortunately means that capture patterns defined in indices will capture entire data streams too. * delete unused import * fix type issue in tests * added logic for rendering out previous selection as custom pattern * refactor indices fields to make component smaller * added CIT for data streams badge * Data streams > indices * updates to relevant pieces of copy * more copy updates * fix types and remove unused import * removed backing indices from restore view * Added data stream restore warning message * restore CITs * first round of copy feedback * refactor help text to provide clearer feedback, for both restore and policy forms * Restore updates - added spacer between title and data streams callout - added copy to the restore settings tab to indicate that settings also apply to backing indices * further copy refinements * second round of copy feedback * fix i18n * added comment to mock * line spacing fixes and created issue for tracking backing index discovery in snaphots * refactor collapsible list logic and tests * refactor editing managed policy check * refactor copy to be clearer about pluralisation of data streams * refactor file structure in components for data stream badge * added tests for indices and data streams field helper * refactored types and fixed i18n id per guidelines Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Rudolf Meijering

commit sha c6867197ffc2808b8127d25a796c4fd21b51fd5e

Allow Saved Object type mappings to set a field's `doc_values` property (#70433) * Allow doc_values to be disabled * Make doc_values optional * doc_values type for CoreFieldMapping * doc_values not doc_value * Update docs Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Nick Partridge

commit sha f8ba824ebc7e3d551b791ba7b8c04f31cddcaf10

Fix discover, tsvb and Lens chart theming issues (#69695)

view details

Nicolas Ruflin

commit sha 335c9bb1481fd35dafc3fa379a94b0d6f94b6525

[Ingest Manager] Update asset paths to use _ instead of - (#70320) In https://github.com/elastic/package-registry/issues/517 the naming of the file paths inside a package is standardised to only use `_` and not `-`. This adjusts the paths for `ilm-policy`, `component-template`, `index-template` to the correct path. An additional change here is to get rid of assets we don't support yet, like rollup jobs and ml jobs. We will reintroduce these when we support them.

view details

Dima Arnautov

commit sha 854e7a5204502ea1977382c89457c160ee7767b3

[ML] Anomaly Explorer swim lane pagination (#70063) * [ML] use explorer service * [ML] WIP pagination * [ML] add to dashboard without the limit * [ML] WIP * [ML] loading states * [ML] viewBySwimlaneDataLoading on field change * [ML] fix dashboard control * [ML] universal swim lane container, embeddable pagination * [ML] fix css issue * [ML] rename anomalyTimelineService * [ML] rename callback * [ML] rename container component * [ML] empty state, increase pagination margin * [ML] check for loading * [ML] fix i18n * [ML] fix unit test * [ML] improve selected cells * [ML] fix overall selection with changing job selection * [ML] required props for pagination component * [ML] move RESIZE_IGNORED_DIFF_PX * [ML] jest tests * [ML] add test subject * [ML] SWIM_LANE_DEFAULT_PAGE_SIZE * [ML] change empty state styling * [ML] fix agg size for influencer filters * [ML] remove debounce * [ML] SCSS variables, rename swim lane class * [ML] job selector using context * [ML] set padding for embeddable panel * [ML] adjust pagination styles * [ML] replace custom time range subject with timefilter * [ML] change loading indicator to mono * [ML] use swim lane type constant * [ML] change context naming * [ML] update jest snapshot * [ML] fix tests

view details

Andrea Villaverde

commit sha 3c56371153cad2c99d94511299b2aba7dd4225ea

Update known-plugins.asciidoc (#69370) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

CJ Cenizal

commit sha 59ece7992b29597b83f2acc78268c51fc1675de5

Make Index Management functional and API integration tests robust against side effects introduced by Ingest Manager. (#70533)

view details

Michael Hirsch

commit sha 8a09f247e30987eff89824fc007953b815670fa3

[ML] Updates APM Module to Work with Service Maps (#70361) * updates apm integration job to work with service maps * rename apm job in setup_module test * modifies detector description Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

patrykkopycinski

commit sha 55922cb9a083007f7f14775d18873478ac09d1ae

[Security Solution] Reposition EuiPopovers on scroll (#69433) * [Security Solution] Reposition EuiPopovers on scroll * update snapshots Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Tyler Smalley

commit sha 0b6674edf5bf201064fdd9787e93ca479fbd0e8c

Adds FOSSA CLI configuration file (#70137) FOSSA analysis by default checks for dependencies in the following order: 1. Parse output from `npm ls --json --production` - Runs if npm exists on the system and provides an accurate list of all dependencies needed to build the production project. 2. Parse `package.json` - Runs if `package.json` can be successfully parsed into a dependency graph. 3. Run yarn list --json - This command verifies through yarn what the actual dependencies which are installed on the system are. This strategy runs with `NODE_ENV=production` by default to find production dependencies. 4. Parse `yarn.lock` - Detects dependencies based on the yarn lockfile. 5. Parse `npm-shrinkwrap.json` - Detects dependencies based on the lockfile. 6. Parse `package-lock.json` - Detects dependencies based on the lockfile. Since our dependencies specified in `package.json` use compatible version matching (`^`), the reported version would often not be what the `yarn.lock` is currently specified to use. Because of this, we are defining a single module with a strategy on `yarn.lock`. Our `yarn.lock` file includes all dependencies. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

view details

Tre

commit sha 12460b456cc9faa1c64e6a50eaaa873d08f8754d

[QA] [Code Coverage] Add Three Dot Compare Url (#70525)

view details

Melissa Alvarez

commit sha 67067ec9a9ace63632a36dbf91b7089b46852f5f

update reg evaluate property names (#70604)

view details

Luca Belluccini

commit sha d3c35c751895e997e41ab02d455385e7df1fd391

[DOC] CSV Reporting settings (#67742) * [DOC] CSV Reporting settings We have some undocumented CSV reporting settings. Those should be backported to 7.3+ probably. * Update docs/settings/reporting-settings.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/settings/reporting-settings.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/settings/reporting-settings.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Apply suggestions from code review Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>

view details

Jonathan Budzenski

commit sha 0e008e30e98f760c5e08db0e5847e103eff49ca6

skip fleet agent flow tests

view details

push time in a day

push eventpgayvallet/kibana

Aaron Caldwell

commit sha 1192c904aeefd3274b4aeb1897918c8416eeffe5

Remove injected vars from maps legacy (#69744) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Tyler Smalley

commit sha 97924a6d86b243e477b1e310e7c79440934adf10

Revert "[eslint][ts] Enable prefer-ts-expect-error (#70022)" (#70474) This reverts commit f3c393eaaffc688ce0d8a17277501207692dd816.

view details

CJ Cenizal

commit sha 91b8e7de24cc521629562082265808ce9c24cdc0

Use modern mount context in Dev Tools and Console (#70379) * Use modern mount context in Dev Tools and Console, and clean up plugin definitions of Grok Debugger, Search Profiler, and Painless Lab. * Remove return value from Console lifecycle method. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Spencer

commit sha ab450c7000e96e648cd6cb9b63ac3c3e57ea9303

skip flaky suite (#70493)

view details

Dave Snider

commit sha f2833f6d00bce8c51da803de5f54d6e72dd32993

More permissive with IE warning (#70388) Show the IE11 warning regardless of if the user supresses the warning

view details

Paul Tavares

commit sha 3305b22d4f44c35f5ee7e31c9bf57471591ec73d

[ENDPOINT][SIEM] Display dismissible Endpoint notice on Overview page if no endpoints are deployed (#70122)

view details

Shahzad

commit sha ba48a9facfbdebead7df4988aa8091d530dcfa47

[RUM Dashboard] Added service name filter (#70349) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Sandra Gonzales

commit sha 80ae5648adbd5c69200cf10aa71439ae06fc3fcc

[Ingest Manager] remove requirements component (#70462) * remove requirements component * fix ts error Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

nnamdifrankie

commit sha eedb5f71155042d6eed6669dc106148913aaee4b

[SECURITY-ENDPOINT] use ingest manager unenroll services to remove unenrolled endpoint (#70393) [SECURITY-ENDPOINT] EMT-451 - use ingest manager unenroll services to remove unenrolled endpoint

view details

Angela Chuang

commit sha 341f38577f6877456f1bfacaf65eceefd2b066f8

fix export response (#70473) * fix export response * update unit tests

view details

Zacqary Adam Xeper

commit sha 515b5dc66c224fb566ae8b0ba7e11b4c69a7e408

[Metrics UI] Fix asynchronicity and error handling in Snapshot API (#70503) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

spalger

commit sha 0f418bb7f0860db2d8e5e33aee5e40ff83b0bbdb

skip suites blocking es snapshot promomotion (#70532)

view details

Jen Huang

commit sha 4f7da59a51859dc7a7dc795ff3112f5148544a66

[Ingest Manager] Rename data sources to package configs (#70259) * Rename `datasource` saved object to `package_config` (SO type `ingest-datasource` to `ingest-package-config`) and adjust mappings: - Remove unused `processors` field on input & stream levels - Remove unnecessary `enabled` field on package config & input levels - Rename `agent_stream` field to `compiled_stream` - Reorder other fields so that important fields are closer to top & similar fields are grouped together Also, - Remove 7.9.0 migrations as we are not supporting an upgrade path from experimental to beta release * Pluralize `ingest-package-configs` for consistency * Rename `Datasource`-related types to `PackageConfig`, update all references (does not include actual type definition changes yet) * Rename `Datasource` schemas and rest spec typings to `PackageConfig` (does not include actual schema changes yet) * Change `datasources` on agent config typings and schemas to `package_configs` and update all references * Add back `enabled` field on package config and input levels. They are needed for current & future UI features. Also: - Match types and schemas with saved object mappings (`agent_stream` to `compiled_stream`, removal of `processors`) - Set `namespace` to be a required property on agent config and package config types, add validation support for it on UI * Rename server-side datasource references in file names, variable names, and routes * Update spec file and schema file * Update doc wording * Rename all instances of datasource in file paths and variable names on client sides, and for Endpoint too * Minor copy adjustments, fix i18n check * Replace datasource references in tests and fixtures; remove unused `ingest/policies` es archiver data * Fix tests * Fix test field name * Fix test fixtures fields again * Fix i18n

view details

Yara Tercero

commit sha 6581450449c092c25a6deebb02b1f56fce3f244d

[SIEM][Exceptions] - Exception builder component (#67013) ### Summary This PR creates the bulk functionality of the exception builder. The exception builder is the component that will be used to create exception list items. It does not deal with the actual API creation/deletion/update of exceptions, it does contain an `onChange` handler that can be used to access the exceptions. The builder is able to: - accept `ExceptionListItem` and render them correctly - allow user to add exception list item and exception list item entries - accept an `indexPattern` and use it to fetch relevant field and autocomplete field values - disable `Or` button if user is only allowed to edit/add to exception list item (not add additional exception list items) - displays `Add new exception` button if no exception items exist - An exception item can be created without entries, the `add new exception` button will show in the case that an exception list contains exception list item(s) with an empty `entries` array (as long as there is one exception list item with an item in `entries`, button does not show) - debounces field value autocomplete searches - bubble up exceptions to parent component, stripping out any empty entries

view details

John Dorlus

commit sha b21e43d848df2fbdedcc4e2960195f546f406fed

Fixed assertion in hybrid index pattern test to iterate through indices (#70130) * Fixed assertion to check through all indices before making assertion. * Restored yarn.lock file. * Removed only from describe. * Fixed linting issue. * Fixed nits that were in the PR conversation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

nnamdifrankie

commit sha e9b81f72ca7f8222c1a97fdad965f441f224e0b7

SECURITY-ENDPOINT: add fields for events to metadata document (#70491) SECURITY-ENDPOINT: EMT-492 add fields for events to metadata document

view details

Garrett Spong

commit sha 591e10355aa5e9fe590361fd22483257d146b9ba

[Security] Adds field mapping support to rule creation (#70288) ## Summary Resolves: https://github.com/elastic/kibana/issues/65941, https://github.com/elastic/kibana/issues/66317, and `Add support for "building block" alerts` This PR is `Part I` and adds additional fields to the `rules schema` in supporting the ability to map and override fields when generating alerts. A few bookkeeping fields like `license` and `author` have been added as well. The new fields are as follows: ``` ts export interface TheseAreTheNewFields { author: string[]; building_block_type: string; // 'default' license: string; risk_score_mapping: Array< { field: string; operator: string; // 'equals' value: string; } >; rule_name_override: string; severity_mapping: Array< { field: string; operator: string; // 'equals' value: string; severity: string; // 'low' | 'medium' | 'high' | 'critical' } >; timestamp_override: string; } ``` These new fields are exposed as additional settings on the `About rule` section of the Rule Creation UI. ##### Default collapsed view, no severity or risk score override specified: <p align="center"> <img width="500" src="https://user-images.githubusercontent.com/2946766/86090417-49c0ee80-ba67-11ea-898f-a43af6d9383f.png" /> </p> ##### Severity & risk score override specified: <p align="center"> <img width="500" src="https://user-images.githubusercontent.com/2946766/86091165-a8d33300-ba68-11ea-86ac-89393a7ca3f5.png" /> </p> ##### Additional fields in Advanced settings: <p align="center"> <img width="500" src="https://user-images.githubusercontent.com/2946766/86091256-cbfde280-ba68-11ea-9b63-acf2524039bd.png" /> </p> Note: This PR adds the fields to the `Rules Schema`, the `signals index mapping`, and creates the UI for adding these fields during Rule Creation/Editing. The follow-up `Part II` will add the business logic for mapping fields during `rule execution`, and also add UI validation/additional tests. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - Syncing w/ @benskelker - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [x] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)

view details

Madison Caldwell

commit sha 0f7afd4402e50f2a42f8951c94ea2fae7c422906

[SIEM][Security Solution][Endpoint] Endpoint Artifact Manifest Management + Artifact Download and Distribution (#67707) * stub out task for the exceptions list packager * Hits list code and pages * refactor * Begin adding saved object and type definitions * Transforms to endpoint exceptions * Get internal SO client * update messaging * cleanup * Integrating with task manager * Integrated with task manager properly * Begin adding schemas * Add multiple OS and schema version support * filter by OS * Fixing sort * Move to security_solutions * siem -> securitySolution * Progress on downloads, cleanup * Add config, update artifact creation, add TODOs * Fixing buffer serialization problem * Adding cleanup to task * Handle HEAD req * proper header * More robust task management * single -> agnostic * Fix OS filtering * Scaffolding digital signatures / tests * Adds rotue for creating endpoint user * Cleanup * persisting user * Adding route to fetch created user * Addings tests for translating exceptions * Adding test for download API * Download tweaks + artifact generation fixes * reorganize * fix imports * Fixing test * Changes id of SO * integration tests setup * Add first integration tests * Cache layer * more schema validation * Set up for manifest update * minor change * remove setup code * add manifest schema * refactoring * manifest rewrite (partial) * finish scaffolding new manifest logic * syntax errors * more refactoring * Move to endpoint directory * minor cleanup * clean up old artifacts * Use diff appropriately * Fix download * schedule task on interval * Split up into client/manager * more mocks * config interval * Fixing download tests and adding cache tests * lint * mo money, mo progress * Converting to io-ts * More tests and mocks * even more tests and mocks * Merging both refactors * Adding more tests for the convertion layer * fix conflicts * Adding lzma types * Bug fixes * lint * resolve some type errors * Adding back in cache * Fixing download test * Changing cache to be sized * Fix manifest manager initialization * Hook up datasource service * Fix download tests * Incremental progress * Adds integration with ingest manager for auth * Update test fixture * Add manifest dispatch * Refactoring to use the same SO Client from ingest * bug fixes * build renovate config * Fix endpoint_app_context_services tests * Only index the fields that are necessary for searching * Integ test progress * mock and test city * Add task tests * Tests for artifact_client and manifest_client * Add manifest_manager tests * minor refactor * Finish manifest_manager tests * Type errors * Update integ test * Type errors, final cleanup * Fix integration test and add test for invalid api key * minor fixup * Remove compression * Update task interval * Removing .text suffix from translated list * Fixes hashes for unit tests * clean up yarn.lock * Remove lzma-native from package.json * missed updating one of the tests Co-authored-by: Alex Kahan <alexander.kahan@elastic.co>

view details

MadameSheema

commit sha 257c115f6694e38cffd933269dfd6e2f151cbc1b

[SIEM] Reenabling Cypress tests (#70397) * reenabling cypress * skips Overview tests * skips search bar test * skips URL test

view details

Spencer

commit sha eca4cc5d3e2b02342977e839844a426cd2ea1b82

Skip failing endgame tests (#70548) Co-authored-by: spalger <spalger@users.noreply.github.com>

view details

push time in a day

issue closedelastic/kibana

Reactify route-based errors

We currently have three errors which are surfaced via individual Angular routes:

We'll need to convert this code to React. As part of this process, we should consider removing the need for specialized routes altogether since the UX of allowing a user to navigate to an error page when there's no error doesn't make sense. It also seems unhelpful to navigate out of the context which caused the error. As an alternative we could display a large modal. We should also ask our copywriting team to take a look over the copy while we're at it.

closed time in a day

cjcenizal

issue commentelastic/kibana

Reactify route-based errors

Closing. Url overflow error page has been migrated to KP, the two others are no longer a thing.

cjcenizal

comment created time in a day

issue commentelastic/kibana

Get rid of createLegacyClass

Only remaining usages are in the legacy state_management (src/legacy/ui/public/state_management). I guess this would be resolved when we complete legacy removal.

timroes

comment created time in a day

issue commentelastic/kibana

Plugin bundle is not created for external new platform plugins resulting in 404

@spalger https://github.com/elastic/kibana/issues/70412 is on platform's scope but this one is probably directly related to the optimizer?

martijnrondeel

comment created time in 4 days

push eventpgayvallet/kibana

Dario Gieselaar

commit sha 429805d1b878919c0b7be081f425d5dc0ec67c09

[APM] Don't fetch dynamic index pattern in setupRequest (#70308) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Joe Reuter

commit sha 3f808688e10864e2d12737844ff4387ae0a2aa27

redirect to default app if hash can not be forwarded (#70417)

view details

Thomas Neirynck

commit sha 9c76f1918649ead38fcc640495bc923c390236bd

[Maps] Add styling and tooltip support to mapbox mvt vector tile sources (#64488) * tmp commit * rename * more boilerpalte * more boiler * more boilerpalte * typing * fix import * boilerplate * more boiler * enable custom palettes * fix label text and orientation * fix merge errors * remove dupe import * stash commit * tmp commit * debounce settings * return null * slight rearrangement * tooltip guard * minor tweaks * feedback * ts fixes * ts fixes * more ts fixes * ts fixes * jest test * fix typo * spacing * fix typing * add unit test * add more tests * add snapshot test * add snapshot * add field editor snapshot test * fix snapshot * add snapshot * remove unused import * test stub for mvt layer fix optional param more checks * add snapshot test more unit tests more unit tests ts fixes * add data syncing unit test * fix autorefactor * fix merge and replace snapshots * field editor changes * field editor changes * ts fixes * update snapshots * fix things * fix names * fix tooltip * add more error handling * improve copy * styling changes * style option box a little better * ts fixes * fix console error * remove mbProperties from interface * remove unused method * remove cruft * rename for consistency * remove unused param * feedback * feedback * ensure properties are always present * handle possible null values * feedback * typo * update SIEM * feedback * remove cruft * remove unused translations * feedback * improve readability * fix brittle test * fix snapshot after master merge * remove unused method * feedback * revert some feedback * remove micro-optimization * initialize in constructor * simplify wording * add snapshot * naming * add clarifying comment * remove unused import * sanitize tooltips * remove cruft * feedback * fix typo * remove export * Design fixes * clean up supportsAutoDomain * remove patch.txt * cleanup * clean-up * Merge in styling changes * Tweak message format * fix broken import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: miukimiu <elizabet.oliveira@elastic.co> Co-authored-by: Nathan Reese <reese.nathan@gmail.com>

view details

Jean-Louis Leysens

commit sha 0066c4b5b05879328e247fa5d6576ea3322c8ed2

[S&R] Support data streams (#68078) * Sort endpoint responses into indices and datastreams The server endpoint for policies now returns data streams and filters out backing indices from the indices array it returned previously * Refactor indices switch and field out of the step settings file * Fix indices field form behaviour * WiP on UI. Added the second table per mockup for add and edit. * add support for creating a policy that backs up data streams end to end * wip on restore flow - added data streams to server response * add logic for detecting whether an index is part of a data stream * fix public jest tests * fix server side jest tests * pivot to different solution in UI while we do not have data streams nicely separated * added data stream to snapshot summary details * move the data streams badge file closer to where it used * add data stream badge when restoring snapshots too * update restore copy * fix pattern specification in indices and data streams field * first iteration of complete policy UX * First iteration that is ready for review Given the contraints on working with data streams and indices in policies at the moment the simplest implementation is to just include data streams with indices and have the user select them there for now. The way snapshotting behaviour is currently implemented relies entirely on what is specified inside of "indices", this is also where data streams must be placed. This unfortunately means that capture patterns defined in indices will capture entire data streams too. * delete unused import * fix type issue in tests * added logic for rendering out previous selection as custom pattern * refactor indices fields to make component smaller * added CIT for data streams badge * Data streams > indices * updates to relevant pieces of copy * more copy updates * fix types and remove unused import * removed backing indices from restore view * Added data stream restore warning message * restore CITs * first round of copy feedback * refactor help text to provide clearer feedback, for both restore and policy forms * Restore updates - added spacer between title and data streams callout - added copy to the restore settings tab to indicate that settings also apply to backing indices * further copy refinements * second round of copy feedback * fix i18n * added comment to mock * line spacing fixes and created issue for tracking backing index discovery in snaphots * refactor collapsible list logic and tests * refactor editing managed policy check * refactor copy to be clearer about pluralisation of data streams * refactor file structure in components for data stream badge * added tests for indices and data streams field helper * refactored types and fixed i18n id per guidelines Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Rudolf Meijering

commit sha c6867197ffc2808b8127d25a796c4fd21b51fd5e

Allow Saved Object type mappings to set a field's `doc_values` property (#70433) * Allow doc_values to be disabled * Make doc_values optional * doc_values type for CoreFieldMapping * doc_values not doc_value * Update docs Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Nick Partridge

commit sha f8ba824ebc7e3d551b791ba7b8c04f31cddcaf10

Fix discover, tsvb and Lens chart theming issues (#69695)

view details

Nicolas Ruflin

commit sha 335c9bb1481fd35dafc3fa379a94b0d6f94b6525

[Ingest Manager] Update asset paths to use _ instead of - (#70320) In https://github.com/elastic/package-registry/issues/517 the naming of the file paths inside a package is standardised to only use `_` and not `-`. This adjusts the paths for `ilm-policy`, `component-template`, `index-template` to the correct path. An additional change here is to get rid of assets we don't support yet, like rollup jobs and ml jobs. We will reintroduce these when we support them.

view details

Dima Arnautov

commit sha 854e7a5204502ea1977382c89457c160ee7767b3

[ML] Anomaly Explorer swim lane pagination (#70063) * [ML] use explorer service * [ML] WIP pagination * [ML] add to dashboard without the limit * [ML] WIP * [ML] loading states * [ML] viewBySwimlaneDataLoading on field change * [ML] fix dashboard control * [ML] universal swim lane container, embeddable pagination * [ML] fix css issue * [ML] rename anomalyTimelineService * [ML] rename callback * [ML] rename container component * [ML] empty state, increase pagination margin * [ML] check for loading * [ML] fix i18n * [ML] fix unit test * [ML] improve selected cells * [ML] fix overall selection with changing job selection * [ML] required props for pagination component * [ML] move RESIZE_IGNORED_DIFF_PX * [ML] jest tests * [ML] add test subject * [ML] SWIM_LANE_DEFAULT_PAGE_SIZE * [ML] change empty state styling * [ML] fix agg size for influencer filters * [ML] remove debounce * [ML] SCSS variables, rename swim lane class * [ML] job selector using context * [ML] set padding for embeddable panel * [ML] adjust pagination styles * [ML] replace custom time range subject with timefilter * [ML] change loading indicator to mono * [ML] use swim lane type constant * [ML] change context naming * [ML] update jest snapshot * [ML] fix tests

view details

Andrea Villaverde

commit sha 3c56371153cad2c99d94511299b2aba7dd4225ea

Update known-plugins.asciidoc (#69370) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

CJ Cenizal

commit sha 59ece7992b29597b83f2acc78268c51fc1675de5

Make Index Management functional and API integration tests robust against side effects introduced by Ingest Manager. (#70533)

view details

Michael Hirsch

commit sha 8a09f247e30987eff89824fc007953b815670fa3

[ML] Updates APM Module to Work with Service Maps (#70361) * updates apm integration job to work with service maps * rename apm job in setup_module test * modifies detector description Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

patrykkopycinski

commit sha 55922cb9a083007f7f14775d18873478ac09d1ae

[Security Solution] Reposition EuiPopovers on scroll (#69433) * [Security Solution] Reposition EuiPopovers on scroll * update snapshots Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Tyler Smalley

commit sha 0b6674edf5bf201064fdd9787e93ca479fbd0e8c

Adds FOSSA CLI configuration file (#70137) FOSSA analysis by default checks for dependencies in the following order: 1. Parse output from `npm ls --json --production` - Runs if npm exists on the system and provides an accurate list of all dependencies needed to build the production project. 2. Parse `package.json` - Runs if `package.json` can be successfully parsed into a dependency graph. 3. Run yarn list --json - This command verifies through yarn what the actual dependencies which are installed on the system are. This strategy runs with `NODE_ENV=production` by default to find production dependencies. 4. Parse `yarn.lock` - Detects dependencies based on the yarn lockfile. 5. Parse `npm-shrinkwrap.json` - Detects dependencies based on the lockfile. 6. Parse `package-lock.json` - Detects dependencies based on the lockfile. Since our dependencies specified in `package.json` use compatible version matching (`^`), the reported version would often not be what the `yarn.lock` is currently specified to use. Because of this, we are defining a single module with a strategy on `yarn.lock`. Our `yarn.lock` file includes all dependencies. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

view details

Tre

commit sha 12460b456cc9faa1c64e6a50eaaa873d08f8754d

[QA] [Code Coverage] Add Three Dot Compare Url (#70525)

view details

Melissa Alvarez

commit sha 67067ec9a9ace63632a36dbf91b7089b46852f5f

update reg evaluate property names (#70604)

view details

Luca Belluccini

commit sha d3c35c751895e997e41ab02d455385e7df1fd391

[DOC] CSV Reporting settings (#67742) * [DOC] CSV Reporting settings We have some undocumented CSV reporting settings. Those should be backported to 7.3+ probably. * Update docs/settings/reporting-settings.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/settings/reporting-settings.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/settings/reporting-settings.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Apply suggestions from code review Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>

view details

Jonathan Budzenski

commit sha 0e008e30e98f760c5e08db0e5847e103eff49ca6

skip fleet agent flow tests

view details

liza-mae

commit sha 52f8d3a58b4989541e532f6b9e5dde067f7ff303

Build docker image for elasticsearch snapshot (#70482) * Build docker image for elasticsearch snapshot * Consolidate statements * Update .ci/es-snapshots/Jenkinsfile_build_es Co-authored-by: Brian Seeders <seeders@gmail.com> * Update find * Use larger worker Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Brian Seeders <seeders@gmail.com>

view details

Nicolas Ruflin

commit sha 5b8fb95d0015ed98877edbbbe7b7b03229d5f497

Remove the base package from the default packages (#70437) As the base assets will be shipped by ES directly, the base package is not needed anymore. https://github.com/elastic/elasticsearch/pull/57629 In the future we might reintroduce it to update the installed assets.

view details

Chris Cowan

commit sha a3e9f39aff523de911a7d6f9eaa2932a6b6077f9

[Metrics UI] Register function for Observability homepage (#70529) * [Metrics UI] Register function for Observability homepage * Updating types; removing relative path from appLink Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

push time in 4 days

pull request commentelastic/kibana

New Workplace Search Kibana plugin WIP

Please create Draft PR for WIPs. That will avoid sending review requests to the respective code owners

Screenshot 2020-07-03 at 18 14 46

scottybollinger

comment created time in 4 days

issue commentelastic/kibana

Problem with outdated lodash isFunction

@timroes I guess this can be closed then?

timroes

comment created time in 4 days

issue closedelastic/kibana

6.6.1 Navbar icons missing on /status page

Kibana version: 6.6.1

Elasticsearch version: n/a

Server OS version: Ubuntu 18.04 / Ubuntu 16.04

Browser version: Chrome 72.0.3626.119 / Firefox 65.0.1

Browser OS version: OSX 10.14.3

Original install method (e.g. download page, yum, from source, etc.): Apt

Describe the bug: Navbar is missing icons when viewing /status page. Particularly troublesome if Navbar is collapsed :)

Steps to reproduce:

  1. Browse to http://[kibana_host]/status

Expected behavior: Icons should be visible on Navbar

Screenshots (if relevant): image

closed time in 4 days

ceeeekay

issue commentelastic/kibana

6.6.1 Navbar icons missing on /status page

Closing as stale. Please reopen is still present on 7.x

ceeeekay

comment created time in 4 days

issue closedelastic/kibana

logout not found

<!-- GitHub is reserved for bug reports and feature requests. The best place to ask a general question is at the Elastic Discourse forums at https://discuss.elastic.co. If you are in fact posting a bug report or a feature request, please include one and only one of the below blocks in your new issue. -->

<!-- If you are filing a bug report, please remove the below feature request block and provide responses for all of the below items. -->

Kibana version: 6.7 development

Elasticsearch version: 6.7

Server OS version: Centos 7

Browser version: 65.0.2 (64bit)

Browser OS version: Firefox

Original install method (e.g. download page, yum, from source, etc.): yum

Description of the problem including expected versus actual behavior: no logout redirect. Steps to reproduce:

  1. login to Kibana
  2. Change to K7 desing in advanced settings
  3. Logout

Errors in browser console (if relevant): log out not found

Provide logs and/or server output (if relevant):

<!-- If you are filing a feature request, please remove the above bug report block and provide responses for all of the below items. -->

Describe the feature:

closed time in 4 days

webmasterThomas

issue commentelastic/kibana

logout not found

Closing as stale. Please reopen if still present on 7.x

webmasterThomas

comment created time in 4 days

issue closedelastic/kibana

Remove unused merge_duplicate_requests logic

Relates to https://github.com/elastic/kibana/issues/14493. @Stacey-Gammon, @lukasolson, and I learned that the logic in https://github.com/elastic/kibana/blob/master/src/ui/public/courier/fetch/merge_duplicate_requests.js is never used to actually merge duplicate requests, since search source IDs are unique even in dashboards with duplicate panels. We should remove this file, as well as the DUPLICATE enum, and possibly the _uniq property on SearchSource if it's not used elsewhere.

closed time in 4 days

cjcenizal

issue commentelastic/kibana

Remove unused merge_duplicate_requests logic

Closing as it's likely already been done during migration as I can't find any occurrence of courier/fetch in the filesystem.

cjcenizal

comment created time in 4 days

issue closedelastic/kibana

[new platform] Explicitly define service setup types

Explicitly define service setup types instead of using the pattern type ReturnType<MyService['setup']>;

src/core/public:

  • [x] BasePathSetup https://github.com/elastic/kibana/pull/34817
  • [x] I18nSetup https://github.com/elastic/kibana/pull/34817
  • [x] InjectedMetadataSetup https://github.com/elastic/kibana/pull/34817
  • [x] FatalErrorsSetup https://github.com/elastic/kibana/pull/34817
  • [ ] NotificationsSetup
  • [x] HttpSetup (assigned to @eliperelman)
  • [ ] UiSettingsSetup
  • [ ] ChromeSetup (part of #38175)

src/core/server:

  • [ ]

closed time in 4 days

rudolf

issue commentelastic/kibana

[new platform] Explicitly define service setup types

Closing, as we are no longer using the ReturnType syntax in any of the listed services.

rudolf

comment created time in 4 days

Pull request review commentelastic/kibana

Add new elasticsearch client

+/*+ * Licensed to Elasticsearch B.V. under one or more contributor+ * license agreements. See the NOTICE file distributed with+ * this work for additional information regarding copyright+ * ownership. Elasticsearch B.V. licenses this file to you under+ * the Apache License, Version 2.0 (the "License"); you may+ * not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *    http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied.  See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */++import { Client } from '@elastic/elasticsearch';+import { Logger } from '../../logging';+import { GetAuthHeaders, isRealRequest, Headers } from '../../http';+import { ensureRawRequest, filterHeaders } from '../../http/router';+import { ScopeableRequest } from '../types';+import { ElasticSearchClient } from './types';+import { configureClient } from './configure_client';+import { ElasticsearchClientConfig } from './client_config';+import { ScopedClusterClient, IScopedClusterClient } from './scoped_cluster_client';++const noop = () => undefined;++/**+ * Represents an Elasticsearch cluster API client created by the platform.+ * It allows to call API on behalf of the internal Kibana user and+ * the actual user that is derived from the request headers (via `asScoped(...)`).+ *+ * @public+ **/+export interface IClusterClient {+  /**+   * Returns a {@link ElasticSearchClient | client} to be used to query the ES cluster on behalf of the Kibana internal user+   */+  asInternalUser: () => ElasticSearchClient;+  /**+   * Creates a {@link IScopedClusterClient | scoped cluster client} bound to given {@link ScopeableRequest | request}+   */+  asScoped: (request: ScopeableRequest) => IScopedClusterClient;+}++/**+ * See {@link IClusterClient}+ *+ * @public+ */+export interface ICustomClusterClient extends IClusterClient {+  /**+   * Closes the cluster client. After that client cannot be used and one should+   * create a new client instance to be able to interact with Elasticsearch API.+   */+  close: () => void;+}++/** @internal **/+export class ClusterClient implements IClusterClient, ICustomClusterClient {+  private readonly internalClient: Client;+  private readonly rootScopedClient: Client;++  private isClosed = false;++  constructor(+    private readonly config: ElasticsearchClientConfig,+    logger: Logger,+    private readonly getAuthHeaders: GetAuthHeaders = noop+  ) {+    this.internalClient = configureClient(config, { logger });+    this.rootScopedClient = configureClient(config, { logger, scoped: true });+  }++  asInternalUser() {+    return this.internalClient;+  }++  asScoped(request: ScopeableRequest) {+    const scopedHeaders = this.getScopedHeaders(request);+    const scopedClient = this.rootScopedClient.child({+      headers: scopedHeaders,+    });+    return new ScopedClusterClient(this.internalClient, scopedClient);+  }++  public close() {+    if (this.isClosed) {+      return;+    }++    this.isClosed = true;+    this.internalClient.close();+    this.rootScopedClient.close();+  }

https://github.com/elastic/kibana/pull/69905/commits/a764b10db4343b0ac799eb4260aa7dd4baccf390

pgayvallet

comment created time in 4 days

push eventpgayvallet/kibana

Stratoula Kalafateli

commit sha f86afd4b070b219595dc444b43e86f24364ae30d

[Visualizations] Each visType returns its supported triggers (#70177) * Refactor hardcoded supportedTriggers function with a callback function of visType * use typescript to check if function exists * Remove brush event from heatmap Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Daniil Suleiman

commit sha dc2737b8686f6f96b357fcea91d3e1060683fb9a

Filter out error when calculating a label (#69934) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Cauê Marcondes

commit sha 6aeda644c8a31fdd58ae43f1f0ea3f1e569476b1

[APM] Show transaction rate per minute on Observability Overview page (#70336) * changing transaction count to transaction rate per second * sanity check coordinates before calculate the mean * sanity check coordinates before calculate the mean * removing extend_bounds to return empty when no data is available

view details

Jean-Louis Leysens

commit sha 83beede50cb57f012411cc31952692d8cd888d52

[Ingest Pipelines] Error messages (#70167) * improved error messages * traverse recursive error struct * add check for object with keys * update button position and copy * size adjustments * Refactor i18n texts and change wording Also added missing translation and refactored maximum errors in collapsed state to external constant * use io-ts, add CIT and unit tests * refactor error utilities to separate file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Rudolf Meijering

commit sha a0e263038c6c7cf077386a1a3da18d6fc6b92def

Use dynamic: false for config saved object mappings (#70436)

view details

Daniil Suleiman

commit sha a8347fad1c9c6ef47436cb947154f935615ea1d5

[Visualize] Add missing advanced settings and custom label for pipeline aggs (#69688) * Show advanced settings in pipeline aggs * Add functional tests * Make sub metric in sibling pipeline to have custom label Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Pierre Gayvallet

commit sha 1cfc9356bd36c54b8005089decc36970c11c101d

add getVisibleTypes API to SO type registry (#70559) * add getVisibleTypes API * doc nit * fix mocking in tests

view details

Tiago Costa

commit sha 7d63cafd5d15ce5e85ba551472f6565f361b39d8

chore(NA): disable alerts_detection_rules cypress suites (#70577)

view details

Eric Davis

commit sha 7b74094e0fa33bd4803dbe105b2a4ea3843ef170

Update docs for api authentication usage (#66819) Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

view details

Jonathan Buttner

commit sha c081caa6341143eb094a9ef00963eaada7d1c72c

[Security_Solution][Endpoint] Leveraging msearch and ancestry array for resolver (#70134) * Refactor generator for ancestry support * Adding optional ancestry array * Refactor the pagination since the totals are not used anymore * Updating the queries to not use aggregations for determining the totals * Refactoring the children helper to handle pagination without totals * Pinning the seed for the resolver tree generator service * Splitting the fetcher into multiple classes for msearch * Updating tests and api for ancestry array and msearch * Adding more comments and fixing type errors * Fixing resolver test import * Fixing tests and type errors * Fixing type errors and tests * Removing useAncestry field * Fixing test * Removing useAncestry field from tests * An empty array will be returned because that's how ES will do it too

view details

Dario Gieselaar

commit sha 429805d1b878919c0b7be081f425d5dc0ec67c09

[APM] Don't fetch dynamic index pattern in setupRequest (#70308) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Joe Reuter

commit sha 3f808688e10864e2d12737844ff4387ae0a2aa27

redirect to default app if hash can not be forwarded (#70417)

view details

Thomas Neirynck

commit sha 9c76f1918649ead38fcc640495bc923c390236bd

[Maps] Add styling and tooltip support to mapbox mvt vector tile sources (#64488) * tmp commit * rename * more boilerpalte * more boiler * more boilerpalte * typing * fix import * boilerplate * more boiler * enable custom palettes * fix label text and orientation * fix merge errors * remove dupe import * stash commit * tmp commit * debounce settings * return null * slight rearrangement * tooltip guard * minor tweaks * feedback * ts fixes * ts fixes * more ts fixes * ts fixes * jest test * fix typo * spacing * fix typing * add unit test * add more tests * add snapshot test * add snapshot * add field editor snapshot test * fix snapshot * add snapshot * remove unused import * test stub for mvt layer fix optional param more checks * add snapshot test more unit tests more unit tests ts fixes * add data syncing unit test * fix autorefactor * fix merge and replace snapshots * field editor changes * field editor changes * ts fixes * update snapshots * fix things * fix names * fix tooltip * add more error handling * improve copy * styling changes * style option box a little better * ts fixes * fix console error * remove mbProperties from interface * remove unused method * remove cruft * rename for consistency * remove unused param * feedback * feedback * ensure properties are always present * handle possible null values * feedback * typo * update SIEM * feedback * remove cruft * remove unused translations * feedback * improve readability * fix brittle test * fix snapshot after master merge * remove unused method * feedback * revert some feedback * remove micro-optimization * initialize in constructor * simplify wording * add snapshot * naming * add clarifying comment * remove unused import * sanitize tooltips * remove cruft * feedback * fix typo * remove export * Design fixes * clean up supportsAutoDomain * remove patch.txt * cleanup * clean-up * Merge in styling changes * Tweak message format * fix broken import Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: miukimiu <elizabet.oliveira@elastic.co> Co-authored-by: Nathan Reese <reese.nathan@gmail.com>

view details

Jean-Louis Leysens

commit sha 0066c4b5b05879328e247fa5d6576ea3322c8ed2

[S&R] Support data streams (#68078) * Sort endpoint responses into indices and datastreams The server endpoint for policies now returns data streams and filters out backing indices from the indices array it returned previously * Refactor indices switch and field out of the step settings file * Fix indices field form behaviour * WiP on UI. Added the second table per mockup for add and edit. * add support for creating a policy that backs up data streams end to end * wip on restore flow - added data streams to server response * add logic for detecting whether an index is part of a data stream * fix public jest tests * fix server side jest tests * pivot to different solution in UI while we do not have data streams nicely separated * added data stream to snapshot summary details * move the data streams badge file closer to where it used * add data stream badge when restoring snapshots too * update restore copy * fix pattern specification in indices and data streams field * first iteration of complete policy UX * First iteration that is ready for review Given the contraints on working with data streams and indices in policies at the moment the simplest implementation is to just include data streams with indices and have the user select them there for now. The way snapshotting behaviour is currently implemented relies entirely on what is specified inside of "indices", this is also where data streams must be placed. This unfortunately means that capture patterns defined in indices will capture entire data streams too. * delete unused import * fix type issue in tests * added logic for rendering out previous selection as custom pattern * refactor indices fields to make component smaller * added CIT for data streams badge * Data streams > indices * updates to relevant pieces of copy * more copy updates * fix types and remove unused import * removed backing indices from restore view * Added data stream restore warning message * restore CITs * first round of copy feedback * refactor help text to provide clearer feedback, for both restore and policy forms * Restore updates - added spacer between title and data streams callout - added copy to the restore settings tab to indicate that settings also apply to backing indices * further copy refinements * second round of copy feedback * fix i18n * added comment to mock * line spacing fixes and created issue for tracking backing index discovery in snaphots * refactor collapsible list logic and tests * refactor editing managed policy check * refactor copy to be clearer about pluralisation of data streams * refactor file structure in components for data stream badge * added tests for indices and data streams field helper * refactored types and fixed i18n id per guidelines Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Rudolf Meijering

commit sha c6867197ffc2808b8127d25a796c4fd21b51fd5e

Allow Saved Object type mappings to set a field's `doc_values` property (#70433) * Allow doc_values to be disabled * Make doc_values optional * doc_values type for CoreFieldMapping * doc_values not doc_value * Update docs Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Nick Partridge

commit sha f8ba824ebc7e3d551b791ba7b8c04f31cddcaf10

Fix discover, tsvb and Lens chart theming issues (#69695)

view details

Nicolas Ruflin

commit sha 335c9bb1481fd35dafc3fa379a94b0d6f94b6525

[Ingest Manager] Update asset paths to use _ instead of - (#70320) In https://github.com/elastic/package-registry/issues/517 the naming of the file paths inside a package is standardised to only use `_` and not `-`. This adjusts the paths for `ilm-policy`, `component-template`, `index-template` to the correct path. An additional change here is to get rid of assets we don't support yet, like rollup jobs and ml jobs. We will reintroduce these when we support them.

view details

Dima Arnautov

commit sha 854e7a5204502ea1977382c89457c160ee7767b3

[ML] Anomaly Explorer swim lane pagination (#70063) * [ML] use explorer service * [ML] WIP pagination * [ML] add to dashboard without the limit * [ML] WIP * [ML] loading states * [ML] viewBySwimlaneDataLoading on field change * [ML] fix dashboard control * [ML] universal swim lane container, embeddable pagination * [ML] fix css issue * [ML] rename anomalyTimelineService * [ML] rename callback * [ML] rename container component * [ML] empty state, increase pagination margin * [ML] check for loading * [ML] fix i18n * [ML] fix unit test * [ML] improve selected cells * [ML] fix overall selection with changing job selection * [ML] required props for pagination component * [ML] move RESIZE_IGNORED_DIFF_PX * [ML] jest tests * [ML] add test subject * [ML] SWIM_LANE_DEFAULT_PAGE_SIZE * [ML] change empty state styling * [ML] fix agg size for influencer filters * [ML] remove debounce * [ML] SCSS variables, rename swim lane class * [ML] job selector using context * [ML] set padding for embeddable panel * [ML] adjust pagination styles * [ML] replace custom time range subject with timefilter * [ML] change loading indicator to mono * [ML] use swim lane type constant * [ML] change context naming * [ML] update jest snapshot * [ML] fix tests

view details

Andrea Villaverde

commit sha 3c56371153cad2c99d94511299b2aba7dd4225ea

Update known-plugins.asciidoc (#69370) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

CJ Cenizal

commit sha 59ece7992b29597b83f2acc78268c51fc1675de5

Make Index Management functional and API integration tests robust against side effects introduced by Ingest Manager. (#70533)

view details

push time in 4 days

Pull request review commentelastic/kibana

Add new elasticsearch client

+/*+ * Licensed to Elasticsearch B.V. under one or more contributor+ * license agreements. See the NOTICE file distributed with+ * this work for additional information regarding copyright+ * ownership. Elasticsearch B.V. licenses this file to you under+ * the Apache License, Version 2.0 (the "License"); you may+ * not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *    http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied.  See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */++import { Client } from '@elastic/elasticsearch';+import { Logger } from '../../logging';+import { GetAuthHeaders, isRealRequest, Headers } from '../../http';+import { ensureRawRequest, filterHeaders } from '../../http/router';+import { ScopeableRequest } from '../types';+import { ElasticSearchClient } from './types';+import { configureClient } from './configure_client';+import { ElasticsearchClientConfig } from './client_config';+import { ScopedClusterClient, IScopedClusterClient } from './scoped_cluster_client';++const noop = () => undefined;++/**+ * Represents an Elasticsearch cluster API client created by the platform.+ * It allows to call API on behalf of the internal Kibana user and+ * the actual user that is derived from the request headers (via `asScoped(...)`).+ *+ * @public+ **/+export interface IClusterClient {+  /**+   * Returns a {@link ElasticSearchClient | client} to be used to query the ES cluster on behalf of the Kibana internal user+   */+  asInternalUser: () => ElasticSearchClient;+  /**+   * Creates a {@link IScopedClusterClient | scoped cluster client} bound to given {@link ScopeableRequest | request}+   */+  asScoped: (request: ScopeableRequest) => IScopedClusterClient;+}++/**+ * See {@link IClusterClient}+ *+ * @public+ */+export interface ICustomClusterClient extends IClusterClient {+  /**+   * Closes the cluster client. After that client cannot be used and one should+   * create a new client instance to be able to interact with Elasticsearch API.+   */+  close: () => void;+}++/** @internal **/+export class ClusterClient implements IClusterClient, ICustomClusterClient {+  private readonly internalClient: Client;+  private readonly rootScopedClient: Client;++  private isClosed = false;++  constructor(+    private readonly config: ElasticsearchClientConfig,+    logger: Logger,+    private readonly getAuthHeaders: GetAuthHeaders = noop+  ) {+    this.internalClient = configureClient(config, { logger });+    this.rootScopedClient = configureClient(config, { logger, scoped: true });+  }++  asInternalUser() {+    return this.internalClient;+  }++  asScoped(request: ScopeableRequest) {+    const scopedHeaders = this.getScopedHeaders(request);+    const scopedClient = this.rootScopedClient.child({+      headers: scopedHeaders,+    });+    return new ScopedClusterClient(this.internalClient, scopedClient);+  }++  public close() {+    if (this.isClosed) {+      return;+    }++    this.isClosed = true;+    this.internalClient.close();+    this.rootScopedClient.close();+  }

missed that it was async. Will address.

pgayvallet

comment created time in 4 days

Pull request review commentelastic/kibana

Add new elasticsearch client

+/*+ * Licensed to Elasticsearch B.V. under one or more contributor+ * license agreements. See the NOTICE file distributed with+ * this work for additional information regarding copyright+ * ownership. Elasticsearch B.V. licenses this file to you under+ * the Apache License, Version 2.0 (the "License"); you may+ * not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *    http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied.  See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */++import { ClientFacade } from './client_facade';++/**+ * Serves the same purpose as the normal {@link ClusterClient | cluster client} but exposes+ * an additional `asCurrentUser` method that doesn't use credentials of the Kibana internal+ * user (as `asInternalUser` does) to request Elasticsearch API, but rather passes HTTP headers+ * extracted from the current user request to the API instead.+ *+ * @public+ **/+export interface IScopedClusterClient {+  /**+   * Returns a {@link ClientFacade | client facade} to be used to query the elasticsearch cluster+   * on behalf of the internal Kibana user.+   */+  asInternalUser: () => ClientFacade;+  /**+   * Returns a {@link ClientFacade | client facade} to be used to query the elasticsearch cluster+   * on behalf of the user that initiated the request to the Kibana server.+   */+  asCurrentUser: () => ClientFacade;+}++/** @internal **/+export class ScopedClusterClient implements IScopedClusterClient {+  constructor(+    private readonly internalClient: ClientFacade,+    private readonly scopedClient: ClientFacade+  ) {}++  asInternalUser() {+    return this.internalClient;+  }++  asCurrentUser() {

addressed in https://github.com/elastic/kibana/pull/69905/commits/83b72462453d2dada9425ce8cb460da5282cc059

pgayvallet

comment created time in 4 days

push eventpgayvallet/kibana

pgayvallet

commit sha 83b72462453d2dada9425ce8cb460da5282cc059

use direct properties instead of accessors

view details

push time in 4 days

push eventpgayvallet/kibana

pgayvallet

commit sha 56db6c43c7105078491240171438a1c707c4d732

log queries even in case of error

view details

pgayvallet

commit sha d6f1c9dcdb63b50842072df070fbd525aa3d42c7

nits

view details

push time in 4 days

push eventpgayvallet/kibana

pgayvallet

commit sha f956fb4450fdcb914d67d7976c67b5eb1fcfd500

Remove generated facade, use ES Client directly

view details

push time in 4 days

push eventpgayvallet/kibana

pgayvallet

commit sha 1a68ea19d8b719760ec721003b64bfc7b1259a7a

move response mocks to mocks.ts

view details

pgayvallet

commit sha 76b67594422d09369da6fb931f56f177066fc903

Remove generated facade, use ES Client directly

view details

push time in 4 days

Pull request review commentelastic/kibana

Add new elasticsearch client

+/*+ * Licensed to Elasticsearch B.V. under one or more contributor+ * license agreements. See the NOTICE file distributed with+ * this work for additional information regarding copyright+ * ownership. Elasticsearch B.V. licenses this file to you under+ * the Apache License, Version 2.0 (the "License"); you may+ * not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *    http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied.  See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */++import { stringify } from 'querystring';+import { Client } from '@elastic/elasticsearch';+import { Logger } from '../../logging';+import { parseClientOptions, ElasticsearchClientConfig } from './client_config';++export const configureClient = (+  config: ElasticsearchClientConfig,+  { logger, scoped = false }: { logger: Logger; scoped?: boolean }+): Client => {+  const clientOptions = parseClientOptions(config, scoped);++  const client = new Client(clientOptions);+  addLogging(client, logger, config.logQueries);++  return client;+};++const addLogging = (client: Client, logger: Logger, logQueries: boolean) => {+  client.on('response', (err, event) => {+    if (err) {+      logger.error(`${err.name}: ${err.message}`);

process.emitWarning seems way too aggressive imho. Being able to get them using the event emitter API is fine.

pgayvallet

comment created time in 4 days

Pull request review commentelastic/kibana

Add new elasticsearch client

+/*+ * Licensed to Elasticsearch B.V. under one or more contributor+ * license agreements. See the NOTICE file distributed with+ * this work for additional information regarding copyright+ * ownership. Elasticsearch B.V. licenses this file to you under+ * the Apache License, Version 2.0 (the "License"); you may+ * not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *    http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied.  See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */++import { stringify } from 'querystring';+import { Client } from '@elastic/elasticsearch';+import { Logger } from '../../logging';+import { parseClientOptions, ElasticsearchClientConfig } from './client_config';++export const configureClient = (+  config: ElasticsearchClientConfig,+  { logger, scoped = false }: { logger: Logger; scoped?: boolean }+): Client => {+  const clientOptions = parseClientOptions(config, scoped);++  const client = new Client(clientOptions);+  addLogging(client, logger, config.logQueries);++  return client;+};++const addLogging = (client: Client, logger: Logger, logQueries: boolean) => {+  client.on('response', (err, event) => {+    if (err) {+      logger.error(`${err.name}: ${err.message}`);

I took https://github.com/elastic/kibana/pull/69905#discussion_r445524499 as a 'yes', as warning are per-request and can now be handled by the consumers. but we can decide to log them on our own. I don't really have an opinion on that one.

pgayvallet

comment created time in 4 days

Pull request review commentelastic/kibana

Add new elasticsearch client

+/*+ * Licensed to Elasticsearch B.V. under one or more contributor+ * license agreements. See the NOTICE file distributed with+ * this work for additional information regarding copyright+ * ownership. Elasticsearch B.V. licenses this file to you under+ * the Apache License, Version 2.0 (the "License"); you may+ * not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *    http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied.  See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */++import { ClientFacade } from './client_facade';++/**+ * Serves the same purpose as the normal {@link ClusterClient | cluster client} but exposes+ * an additional `asCurrentUser` method that doesn't use credentials of the Kibana internal+ * user (as `asInternalUser` does) to request Elasticsearch API, but rather passes HTTP headers+ * extracted from the current user request to the API instead.+ *+ * @public+ **/+export interface IScopedClusterClient {+  /**+   * Returns a {@link ClientFacade | client facade} to be used to query the elasticsearch cluster+   * on behalf of the internal Kibana user.+   */+  asInternalUser: () => ClientFacade;

Flagging as resolved as it's likely the facade will just disappear.

pgayvallet

comment created time in 5 days

Pull request review commentelastic/kibana

Add new elasticsearch client

+/*+ * Licensed to Elasticsearch B.V. under one or more contributor+ * license agreements. See the NOTICE file distributed with+ * this work for additional information regarding copyright+ * ownership. Elasticsearch B.V. licenses this file to you under+ * the Apache License, Version 2.0 (the "License"); you may+ * not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ *+ *    http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied.  See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */++import { ClientFacade } from './client_facade';++/**+ * Serves the same purpose as the normal {@link ClusterClient | cluster client} but exposes+ * an additional `asCurrentUser` method that doesn't use credentials of the Kibana internal+ * user (as `asInternalUser` does) to request Elasticsearch API, but rather passes HTTP headers+ * extracted from the current user request to the API instead.+ *+ * @public+ **/+export interface IScopedClusterClient {+  /**+   * Returns a {@link ClientFacade | client facade} to be used to query the elasticsearch cluster+   * on behalf of the internal Kibana user.+   */+  asInternalUser: () => ClientFacade;+  /**+   * Returns a {@link ClientFacade | client facade} to be used to query the elasticsearch cluster+   * on behalf of the user that initiated the request to the Kibana server.+   */+  asCurrentUser: () => ClientFacade;+}++/** @internal **/+export class ScopedClusterClient implements IScopedClusterClient {+  constructor(+    private readonly internalClient: ClientFacade,+    private readonly scopedClient: ClientFacade+  ) {}++  asInternalUser() {+    return this.internalClient;+  }++  asCurrentUser() {

Yea, as I said, no strong technical reasons. I don't mind switching to property access on this one

pgayvallet

comment created time in 5 days

issue closedelastic/kibana

Optimize the optimizer

To dramatically decrease the file count and improve startup performance we should bundle the optimizer into a single is file.

closed time in 5 days

spalger

issue commentelastic/kibana

Optimize the optimizer

Closing, no longer relevant as the optimizer will no longer be shipped after the legacy platform removal is complete.

spalger

comment created time in 5 days

issue closedelastic/kibana

Use Boom.boomify over Boom.wrap

Original comment by @archanid:

LINK REDACTED in x-pack-kibana where we're currently using Boom.wrap, which is deprecated in Boom 5.2.0.

closed time in 5 days

elasticmachine

issue commentelastic/kibana

Use Boom.boomify over Boom.wrap

Closing. Outdated and Boom usages are to be avoided in Kibana Platform.

elasticmachine

comment created time in 5 days

push eventpgayvallet/kibana

Shahzad

commit sha 518e88cf287ee8fdfefc51ae5040765371d8065b

update (#70424)

view details

Jason Rhodes

commit sha 1d1051b1e988e80599f0375d8efad39113537a57

Changes observability plugin codeowner (#70439) The observability plugin is now code-owned by a new observability-ui GH team to avoid pinging 4 separate teams for mandatory reviews when that plugin changes.

view details

Josh Dover

commit sha 7ed1fe05d7935689871939ff68acd34fe5c02e3f

Move logger configuration integration test to jest (#70378)

view details

Ahmad Bamieh

commit sha 2212beba6847051bd42f759ec2530d7c9521e64d

[i18n] integrate new translations + new i18n check #70193 (#70423) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Sandra Gonzales

commit sha 275fb9731df36c0dd1954963f3af420c7f601564

[Ingest Manager] add _meta field to index templates (#70319) * add _meta field to index templates * fix typescript issue * make package an object Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Spencer

commit sha bc802c38ee515c7a891e5bb1b9bdbdcf1638779d

skip flaky suite (#66389)

view details

Ryland Herrick

commit sha d8d24be3fb8bcbfc82120e2a74f45797b6bdc248

[Security Solution][Lists] More composable hooks/utilities (#70372) * Add wrapper function to make an AbortSignal arg optional Components commonly do not care about aborting a request, but are required to pass `{ signal: new AbortController().signal }` anyway. This addresses that use case. * Adds hook for retrieving the component's mount status This is useful for dealing with asynchronous tasks that may complete after the invoking component has been unmounted. Using this hook, callbacks can determine whether they're currently unmounted, i.e. whether it's safe to set state or not. * Add our own implemetation of useAsync This does not suffer from the Typescript issues that the react-use implementation had, and is generally a cleaner hook than useAsyncTask as it makes no assumptions about the underlying function. * Update exported Lists API hooks to use useAsync and withOptionalSignal Removes the now-unused useAsyncTask as well. * Add some JSDoc for our new functions

view details

Charlie Pichette

commit sha 9438f13939ba99387f4dd1a67d9d6deeab43a778

Issue 63621 Fix Flaky Tests (#70344)

view details

Robert Austin

commit sha 652b11f270e560046e9ccba4150d84eaab561b57

Remove old endpoint routes redux (#70458) Remove the legacy Endpoint Alerts feature

view details

Chris Cowan

commit sha b7f33b94a85f6e8405addb9b985221f60e682305

[Metrics UI] Enhance Inventory View Tooltips (#69757) * [Metrics UI] Enhance Inventory View Tooltips * Fixing typos * Removing toMetricOpt Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

James Gowdy

commit sha eafd2af6aa496e7e857b9f3070ab9687465ac30d

[ML] Adding capabilities checks to shared functions (#70069) * [ML] Adding capabilities checks to shared functions * small refactor * disabling capabilities checks for functions called by SIEM alerting * testing git * removing comment * using constant for ml app id * tiny type clean up * removing check in ml_capabilities * fixing types * removing capabilities checks from ml_capabilities endpoint * updating types * better error handling * improving capabilities check * adding custom errors Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Nathan Reese

commit sha 006670244af90e7a9373bfa8ccd75e8b33e08e39

[Maps] convert GeojsonFileSource to typescript (#70365) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Shahzad

commit sha 9ff68e4c8caa83225a0d0000db9148844cec8821

[RUM Dashboard] Update rum title to be consistent with APM (#70460)

view details

Spencer

commit sha 481dccdb6f20daf3bbb65d239dca5a1f5a579d9c

[ui-shared-deps/theme] implement auto-switching theme vars module (#70274) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Melissa Alvarez

commit sha 2c40db8ac7fdfe2108b4424f848c3397c84a856f

[ML] DF Analytics: ensure failed job state handled (#70456) * handle failed job state in progress bar. skip reg test * skip classification functional tests for now as well * translate default callout message

view details

Robert Austin

commit sha bc66737085577fc98eae107ec4bd6273ab6486df

fix styling for the SIEM Resolver integration (#70464)

view details

Lukas Olson

commit sha ee621d0b413d38cb8f306174defabcd78f145810

Update KQL/filter bar suggestions to cancel when navigating away (#69769) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Melissa Alvarez

commit sha edad01724699b01e4d7ff15f837f7e6c7fdde442

update mse to access value property (#70438)

view details

Nick Partridge

commit sha b37b6ed4a26e5578d69b6fad1facdc72fb525ffa

Add more detailed unmet deps logging (#70098)

view details

Jonathan Buttner

commit sha 37d7d788d912a5cc93cd94986e5fb858e696ee1a

[Security_Solution][Endpoint] Refactor resolver generator for ancestry array (#70129) * Refactor generator for ancestry support * Adding optional ancestry array * Fixing tests and type errors * Removing useAncestry field * Fixing test * An empty array will be returned because that's how ES will do it too Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

push time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 export class SpacesClient {        if (authorized.length === 0) {         this.debugLogger(-          `SpacesClient.getAll(), using RBAC. returning 403/Forbidden. Not authorized for any spaces.`+          `SpacesClient.getAll(), using RBAC. returning 403/Forbidden. Not authorized for any spaces for ${purpose} purpose.`

Unrelated to the review, but asking for GS: what is the best way to retrieve the list of spaces a user is allowed to access from a Request?

legrego

comment created time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 export default function ({ getService }: FtrProviderContext) {   const esArchiver = getService('esArchiver');    const { addTests, createTestDefinitions } = findTestSuiteFactory(esArchiver, supertest);-  const createTests = (spaceId: string) => {-    const { normalTypes, hiddenAndUnknownTypes, allTypes } = createTestCases(spaceId);+  const createTests = (spaceId: string, user: TestUser) => {+    const currentSpaceCases = createTestCases(spaceId, []);++    const explicitCrossSpace = createTestCases(spaceId, ['default', 'space_1', 'space_2']);+    const wildcardCrossSpace = createTestCases(spaceId, ['*']);++    if (user.username === 'elastic') {+      return {+        currentSpace: createTestDefinitions(currentSpaceCases.allTypes, false, { user }),+        crossSpace: createTestDefinitions(explicitCrossSpace.allTypes, false, { user }),+      };+    }++    const authorizedAtCurrentSpace =+      user.authorizedAtSpaces.includes(spaceId) || user.authorizedAtSpaces.includes('*');++    const authorizedExplicitCrossSpaces = ['default', 'space_1', 'space_2'].filter(+      (s) =>+        user.authorizedAtSpaces.includes('*') ||+        (s !== spaceId && user.authorizedAtSpaces.includes(s))+    );++    const authorizedWildcardCrossSpaces = ['default', 'space_1', 'space_2'].filter(+      (s) => user.authorizedAtSpaces.includes('*') || user.authorizedAtSpaces.includes(s)+    );++    const explicitCrossSpaceDefinitions =+      authorizedExplicitCrossSpaces.length > 0+        ? [+            createTestDefinitions(explicitCrossSpace.normalTypes, false, { user }),+            createTestDefinitions(+              explicitCrossSpace.hiddenAndUnknownTypes,

I swear I tried, multiple times, but I'm still drowning in your security/spaces integration tests 😅

legrego

comment created time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 export default function ({ getService }) {             }));       }); +      describe('unknown namespace', () => {+        it('should return 200 with empty response', async () =>+          await supertest+            .get('/api/saved_objects/_find?type=visualization&namespaces=foo')+            .expect(200)+            .then((resp) => {+              expect(resp.body).to.eql({+                page: 1,+                per_page: 20,+                total: 0,+                saved_objects: [],+              });+            }));+      });++      describe('known namespace', () => {+        it('should return 200 with individual responses', async () =>+          await supertest+            .get('/api/saved_objects/_find?type=visualization&fields=title&namespaces=default')+            .expect(200)+            .then((resp) => {+              expect(resp.body).to.eql({+                page: 1,+                per_page: 20,+                total: 1,+                saved_objects: [+                  {+                    type: 'visualization',+                    id: 'dd7caf20-9efd-11e7-acb3-3dab96693fab',+                    version: 'WzIsMV0=',+                    attributes: {+                      title: 'Count of requests',+                    },+                    migrationVersion: resp.body.saved_objects[0].migrationVersion,+                    namespaces: ['default'],+                    score: 0,+                    references: [+                      {+                        id: '91200a00-9efd-11e7-acb3-3dab96693fab',+                        name: 'kibanaSavedObjectMeta.searchSourceJSON.index',+                        type: 'index-pattern',+                      },+                    ],+                    updated_at: '2017-09-21T18:51:23.794Z',+                  },+                ],+              });+              expect(resp.body.saved_objects[0].migrationVersion).to.be.ok();+            }));+      });++      describe('wildcard namespace', () => {+        it('should return 200 with individual responses from the default namespace', async () =>

A little misleading, as it doesn't seem to match your description:

A wildcard to search against all available spaces e.g.: /api/saved_objects/_find?namespaces=*

But I guess as we are in OSS test suite, we can't really do better.

legrego

comment created time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 export class SavedObjectsRepository {         // When method == 'index' the bulkResponse doesn't include the indexed         // _source so we return rawMigratedDoc but have to spread the latest         // _seq_no and _primary_term values from the rawResponse.-        return this._serializer.rawToSavedObject({+        return this._rawToSavedObject({

Don't see anything wrong here, but as it's probably one of the most sensible part of our team's review, could you take a look @rudolf ?

legrego

comment created time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 export class SecureSavedObjectsClientWrapper implements SavedObjectsClientContra   }    public async find<T = unknown>(options: SavedObjectsFindOptions) {-    await this.ensureAuthorized(options.type, 'find', options.namespace, { options });+    if (+      this.getSpacesService() == null &&+      Array.isArray(options.namespaces) &&+      options.namespaces.length > 0+    ) {+      throw this.errors.createBadRequestError(+        `_find across namespaces is not permitted when the Spaces plugin is disabled.`+      );+    }+    await this.ensureAuthorized(options.type, 'find', options.namespaces, { options });

Not my scope, but +1 with joe here.

legrego

comment created time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 export interface SavedObjectStatusMeta {  *  * @public  */-export interface SavedObjectsFindOptions extends SavedObjectsBaseOptions {+export interface SavedObjectsFindOptions extends Omit<SavedObjectsBaseOptions, 'namespace'> {

Probably this extends is no longer necessary:

export interface SavedObjectsBaseOptions {
  /** Specify the namespace for this operation */
  namespace?: string;
}
legrego

comment created time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 export default function ({ getService }) {                     dashboard: resp.body.saved_objects[1].migrationVersion.dashboard,                   },                   references: [],+                  namespaces: ['default'],

So we are adding the namespaces property to all SO APIs even if it's only relevant for find atm?

legrego

comment created time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 export function getQueryParams({   kueryNode, }: QueryParams) {   const types = getTypes(mappings, type);++  const normalizedNamespaces = namespaces+    ? Array.from(+        new Set(namespaces.map((namespace) => (namespace === '*' ? 'default' : namespace)))

That part is hard to follow, but is that namespace === '*' ? 'default' : namespace right? isn't * supposed to match every namespaces?

legrego

comment created time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 export const registerFindRoute = (router: IRouter) => {           ),           fields: schema.maybe(schema.oneOf([schema.string(), schema.arrayOf(schema.string())])),           filter: schema.maybe(schema.string()),+          namespaces: schema.maybe(+            schema.oneOf([schema.string(), schema.arrayOf(schema.string())])+          ),         }),       },     },     router.handleLegacyErrors(async (context, req, res) => {       const query = req.query;++      let namespaces: string[] | undefined;+      if (Array.isArray(req.query.namespaces)) {+        namespaces = req.query.namespaces;+      } else if (typeof req.query.namespaces === 'string') {+        namespaces = [req.query.namespaces];+      }

NIT: inline

let namespaces = typeof req.query.namespaces === 'string' ? [req.query.namespaces] : req.query.namespaces

legrego

comment created time in 5 days

Pull request review commentelastic/kibana

Search across spaces

 function getFieldsForTypes(types: string[], searchFields?: string[]) {  */ function getClauseForType(   registry: ISavedObjectTypeRegistry,-  namespace: string | undefined,+  namespaces: string[] | undefined = ['default'],

NIT: namespaces?: string[] = ['default'],

legrego

comment created time in 5 days

push eventelastic/kibana

Pierre Gayvallet

commit sha 289652d7172be70945397b77ff76e0f3ed074e74

add getVisibleTypes API to SO type registry (#70559) (#70578) * add getVisibleTypes API * doc nit * fix mocking in tests

view details

push time in 5 days

PR merged elastic/kibana

[7.x] add getVisibleTypes API to SO type registry (#70559) backport

Backports the following commits to 7.x:

  • add getVisibleTypes API to SO type registry (#70559)
+70 -16

1 comment

10 changed files

pgayvallet

pr closed time in 5 days

pull request commentelastic/kibana

Search across spaces

@pgayvallet, I'd love your input on this PR since you're our Global Search Expert ™️. I want to make sure this will suit your needs going forward.

Sorry, was kinda busy with the ES client this week, did not find time to review this. Will try to do it before EOW

legrego

comment created time in 5 days

issue commentelastic/kibana

Nested structure for Kibana App plugins

Moving saved_objects_management under a management folder/section SGTM

timroes

comment created time in 5 days

issue commentelastic/kibana

[discuss] new elasticsearch client version management

I don't think it should be a problem installing from GitHub during the development phase

For our master branch, now that locks are a thing, pointing to @master may not be an issue (even if AFAIK we are not doing that with any other library)

For our 7.x branch, pointing to @next may be more difficult, as:

  • we would need to change the version when creating the next branch (i.e 7.9) from 7.x, so this means adapting the release script/process
  • the @elastic/elasticsearch:7.9.0 would be REQUIRED to be release before we cut the 7.9 branch
  • even if it should, we can't be 100% sure that when switching, @next and v7.9.0 will be the exact same version, which could cause failures when creating the Kibana release branch
pgayvallet

comment created time in 5 days

Pull request review commentelastic/kibana

[Discover] Add caused_by.type and caused_by.reason to error toast modal

 import { } from '@elastic/eui'; import { EuiSpacer } from '@elastic/eui'; import { FormattedMessage } from '@kbn/i18n/react';--import { OverlayStart } from '../../overlays';+import { OverlayStart } from 'kibana/public'; import { I18nStart } from '../../i18n';  interface ErrorToastProps {   title: string;-  error: Error;+  error: RequestError;

I would: 1/ keep Error in ErrorToastProps as RequestError does not reflect the real type (is can be any kind of error) 2/ add a typeguard for RequestError: isRequestError = (e: Error): e is RequestError => error.body?.attributes?.error?.caused_by !== undefined

Use it in the block

if (isRequestError(error)) {
    text += `${error.body.attributes.error.caused_by.type}\n`;
    text += `${error.body.attributes.error.caused_by.reason}\n\n`;
  }
kertal

comment created time in 5 days

push eventpgayvallet/kibana

Stratoula Kalafateli

commit sha f86afd4b070b219595dc444b43e86f24364ae30d

[Visualizations] Each visType returns its supported triggers (#70177) * Refactor hardcoded supportedTriggers function with a callback function of visType * use typescript to check if function exists * Remove brush event from heatmap Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Daniil Suleiman

commit sha dc2737b8686f6f96b357fcea91d3e1060683fb9a

Filter out error when calculating a label (#69934) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Cauê Marcondes

commit sha 6aeda644c8a31fdd58ae43f1f0ea3f1e569476b1

[APM] Show transaction rate per minute on Observability Overview page (#70336) * changing transaction count to transaction rate per second * sanity check coordinates before calculate the mean * sanity check coordinates before calculate the mean * removing extend_bounds to return empty when no data is available

view details

Jean-Louis Leysens

commit sha 83beede50cb57f012411cc31952692d8cd888d52

[Ingest Pipelines] Error messages (#70167) * improved error messages * traverse recursive error struct * add check for object with keys * update button position and copy * size adjustments * Refactor i18n texts and change wording Also added missing translation and refactored maximum errors in collapsed state to external constant * use io-ts, add CIT and unit tests * refactor error utilities to separate file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Rudolf Meijering

commit sha a0e263038c6c7cf077386a1a3da18d6fc6b92def

Use dynamic: false for config saved object mappings (#70436)

view details

Daniil Suleiman

commit sha a8347fad1c9c6ef47436cb947154f935615ea1d5

[Visualize] Add missing advanced settings and custom label for pipeline aggs (#69688) * Show advanced settings in pipeline aggs * Add functional tests * Make sub metric in sibling pipeline to have custom label Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

pgayvallet

commit sha 11caf687bd4ea0b10f73208cbfa98c78c2c00736

add multi results test

view details

Pierre Gayvallet

commit sha 1cfc9356bd36c54b8005089decc36970c11c101d

add getVisibleTypes API to SO type registry (#70559) * add getVisibleTypes API * doc nit * fix mocking in tests

view details

pgayvallet

commit sha 3ba6e89ba086ad3ae3498174146de05832975887

Merge remote-tracking branch 'upstream/master' into kbn-65222-gs-so-provider

view details

pgayvallet

commit sha 63e7c2d9580f10964108d4326f122406bc3cdbe2

use `getVisibleTypes`

view details

push time in 5 days

create barnchpgayvallet/kibana

branch : backport/7.x/pr-70559

created branch time in 5 days

PR opened elastic/kibana

[7.x] add getVisibleTypes API to SO type registry (#70559)

Backports the following commits to 7.x:

  • add getVisibleTypes API to SO type registry (#70559)
+70 -16

0 comment

10 changed files

pr created time in 5 days

push eventelastic/kibana

Pierre Gayvallet

commit sha 1cfc9356bd36c54b8005089decc36970c11c101d

add getVisibleTypes API to SO type registry (#70559) * add getVisibleTypes API * doc nit * fix mocking in tests

view details

push time in 5 days

PR merged elastic/kibana

add getVisibleTypes API to SO type registry Team:Platform release_note:skip v7.9.0 v8.0.0

Summary

Fix https://github.com/elastic/kibana/issues/66818

Checklist

+70 -16

2 comments

10 changed files

pgayvallet

pr closed time in 5 days

issue closedelastic/kibana

Add SavedObjectTypeRegistry.getVisibleTypes API

We currently have a getAllTypes API exposed from the registry that returns all types, including the hidden ones. Even if accessing all type is necessary in some situations, the most common use case is to only access the list of visible types. This currently requires to manually filter the returned types from getAllTypes

We should add a getVisibleType API to the registry, and update the jsdoc about getAllTypes to make it clear that hidden types are also returned.

closed time in 5 days

pgayvallet

Pull request review commentelastic/kibana

[Audit Logging] Add AuditTrail service

 export class ElasticsearchService     return new ClusterClient(       config,       this.coreContext.logger.get('elasticsearch', type),+      this.getAuditorFactory,       getAuthHeaders     );   }++  private getAuditorFactory = () => {+    if (!this.auditorFactory) {

Oh right, that's only for scoped clients.

restrry

comment created time in 5 days

Pull request review commentelastic/kibana

[GS] add savedObjects result provider

 export class GlobalSearchTestPlugin             reduce((memo, results) => [...memo, ...results])           )           .toPromise(),+      findReal: (term) =>+        globalSearch+          .find(term, {})+          .pipe(+            map((batch) => batch.results),+            // remove test types+            map((results) => results.filter((r) => !r.type.startsWith('test_'))),

flatMap would emit an individual event for each result. Could be replace with flatMap + toArray, but map + reduce is probably more explicit.

pgayvallet

comment created time in 5 days

push eventpgayvallet/kibana

pgayvallet

commit sha 163a73f1459a85b24e35e7f9c165ef8ea7217ba9

fix mocking in tests

view details

push time in 5 days

push eventpgayvallet/kibana

Alison Goryachev

commit sha b00deeb7543512c7af59619ad07a00776d58e274

[IM] Move template wizard steps to shared directory + update legacy details panel (#69559)

view details

Alexey Antonov

commit sha 6cc8ea1861fa087199193b337db03c9144fc7687

Migrate dashboard mode (#69305) Closes: #67469 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Cauê Marcondes

commit sha 572d006d9fdc0c544e7188125f10e5d6113b8455

[Observability]Adding specific Return APIs for each plugin (#69257) * Adding specific apis for each plugin * adding metric hosts stat * addressing PR comment * addressing PR comments * changing series to key/value * exporting interfaces * adding label to stat * refactoring types Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Dima Arnautov

commit sha 43ed4e20432bd620ff94048c5ebe294afe75c19d

[ML] fix ml api services (#69681)

view details

Matthias Wilhelm

commit sha cc893f3da4ad92c6ec10cfc96d5a2ad362789775

[Discover] Unskip context navigation functional test (#68771)

view details

Dario Gieselaar

commit sha 8956a33e4c6abcbff31b6d178aaeadce38b6b513

[APM] Use asPercent to format breakdown chart (#69384) Co-authored-by: Søren Louv-Jansen <sorenlouv@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Lisa Cawley

commit sha 0e2f9fc3651d3eb81a2ea76aea6fee8d02d7d447

Updates swim lane UI text (#69454)

view details

Marco Liberati

commit sha 65c3114abc0c12bafbccb90959c9d80d8f5832e5

Fix Advanced Settings Panel number editing in Graph (#69672)

view details

Devon Thomson

commit sha 98a897736bbd1dd0af78585db7350dd44509acf1

Remove App communication from URL (#67064) Removed all inter-app communication via url in favour of a new service in the embeddable start contract called the state transfer service.

view details

Jonathan Buttner

commit sha 5fb206f67ffcd953934d330ff1ebaea9bfd02c15

[Security_Solution] Split up indices (#69589) * Fixing resolver alert generation * Splitting indices up * Removing tests that could randomly fail because of the generation code * Adding support for multiple indices * Updating archives with the new index names * Removing alerts data stream * Switching to process instead of fake Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

MadameSheema

commit sha 1cdeec07b2c517c16ab12d80d716c17dd7158688

completes top-level navigation tests (#69694)

view details

Brian Seeders

commit sha 1ad18794efe546e58412c62fdc8dd7be7465a070

[CI] Record Github commit statuses outside of PRs (#69432)

view details

Pierre Gayvallet

commit sha 41f085adccd54b5d3673777ab829651726e00f4c

Document workaround for using HashRouter (#69140) * add section on hashrouter * review comments

view details

Yuliia Naumenko

commit sha 29714aa61476972083100a35c9eaecd234b9089f

Disabled multiple select for preconfigured connectors to avoid requesting bulk delete on them (#69459)

view details

Clint Andrew Hall

commit sha f3fbf31f3a0aa653344f13359f0aa8610f26d701

[chore] TS 3.9: convert ts-ignore to ts-expect-error (#69541) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Chris Roberson

commit sha b2d3833313c7b4ccc33fa57ebdd4017af394a10f

[Monitoring] Love for APM (#69052) * Fix broken colors for APM * Use default derivative * Fix UI issues with APM * Add new charts * Fix tests * Use EUI color palette * Remove old translations * PR feedback * Fix tests * Fix up overview page Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Quynh Nguyen

commit sha 1158be92643a83cd1ac0905d06a30db3b719d727

[ML] Transform: Table enhancements (#69307) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Quynh Nguyen

commit sha 22d09a3bbd02851bcfe2e7a4e32d752f399ed400

[ML] Transform: Enable force delete if one of the transforms failed (#69472) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

view details

Melissa Alvarez

commit sha e87a4b2a31c2d7c5397e25d0d720e4607df71408

fix link to analytics results from management (#69550)

view details

MadameSheema

commit sha 71d54c8caed0dda26d80e8e1f1c38f212e212dc8

adds kibana navigation tests (#69733)

view details

push time in 5 days

Pull request review commentelastic/kibana

[GS] add savedObjects result provider

+/*+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one+ * or more contributor license agreements. Licensed under the Elastic License;+ * you may not use this file except in compliance with the Elastic License.+ */++import { from } from 'rxjs';+import { map, takeUntil } from 'rxjs/operators';+import { GlobalSearchResultProvider } from '../../../../global_search/server';+import { mapToResults } from './map_object_to_result';++export const createSavedObjectsResultProvider = (): GlobalSearchResultProvider => {+  return {+    id: 'savedObjects',+    find: (term, { aborted$, maxResults, preference }, { core }) => {+      const { typeRegistry, client } = core.savedObjects;++      const searchableTypes = typeRegistry+        .getAllTypes()+        .filter((type) => !typeRegistry.isHidden(type.name))

https://github.com/elastic/kibana/pull/70559

pgayvallet

comment created time in 5 days

push eventpgayvallet/kibana

pgayvallet

commit sha 1f005bd90f67f60b360fad734d7b242aff197109

doc nit

view details

push time in 5 days

PR opened elastic/kibana

add getVisibleTypes API to SO type registry

Summary

Fix https://github.com/elastic/kibana/issues/66818

Checklist

+66 -9

0 comment

9 changed files

pr created time in 5 days

create barnchpgayvallet/kibana

branch : kbn-66818-get-visible-types

created branch time in 5 days

Pull request review commentelastic/kibana

[GS] add savedObjects result provider

+/*+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one+ * or more contributor license agreements. Licensed under the Elastic License;+ * you may not use this file except in compliance with the Elastic License.+ */++import { from } from 'rxjs';+import { map, takeUntil } from 'rxjs/operators';+import { GlobalSearchResultProvider } from '../../../../global_search/server';+import { mapToResults } from './map_object_to_result';++export const createSavedObjectsResultProvider = (): GlobalSearchResultProvider => {+  return {+    id: 'savedObjects',+    find: (term, { aborted$, maxResults, preference }, { core }) => {+      const { typeRegistry, client } = core.savedObjects;++      const searchableTypes = typeRegistry+        .getAllTypes()+        .filter((type) => !typeRegistry.isHidden(type.name))

Decision was to do it: https://github.com/elastic/kibana/issues/66818. Will do it now in a separate PR and then adapt this one.

pgayvallet

comment created time in 5 days

more