profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/pez-globo/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Pez Globo pez-globo https://www.pez-globo.org Fighting COVID-19 with open-source ventilator design

pez-globo/pufferfish-electronics 1

Circuit schematics and PCB layouts for the Pufferfish ventilator.

pez-globo/pufferfish-software 0

All software for the Pufferfish ventilator.

pez-globo/vent-plotting 0

Plots of ventilator test data

PR opened pez-globo/pufferfish-software

Refactor icons and controllers to feature folders domain: frontend stage: dev type: fix

This PR includes:

  • decompose icons from a top-level folder into feature folders
  • move Controllers to shared/values
  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes
  2. Were any of these contributions also part of work you did for an employer or a client? No
  3. Does this work include, or is it based on, any third-party work which you did not create? No
+44 -82

0 comment

48 changed files

pr created time in 4 days

push eventpez-globo/pufferfish-software

rohan

commit sha 6f1154c83b562aaa896c466dd4de79bc0007e5ea

fix build errors

view details

push time in 4 days

push eventpez-globo/pufferfish-software

Rohan Purohit

commit sha 6b40c3527e6fb6f3b67743ae35ed0faef6cc4096

Restructure frontend files into feature folders (#441) * move toolbar alarms to its folder * move shared files to shared feature folder * fix imports * move carousel to app/landing page * move units from info/ to shared/ * remane settings/containers folder to tabs * move more files to shared * fix imports * move rotary files into shared/rotary * resolve a couple of TODO's related to organizing * fix imports * fix eslint errors * move some files out of top level folders * fix imports * fix eslint errors

view details

push time in 4 days

delete branch pez-globo/pufferfish-software

delete branch : feature/frontend-file-structure

delete time in 4 days

PR merged pez-globo/pufferfish-software

Reviewers
Restructure frontend files into feature folders domain: frontend stage: dev type: chore

This PR includes:

  • Move alarms.tsx from alarms to app/toolbar
  • move shared components to top-level shared folder
  • move Carousel component to app/landing-page
  • rename modules/logs to modules/event-logs
  • remove ModesPage (it's deprecated)
  • move ModesDropDown to app (as this shows the current HFNC mode in some screens, therefore not removed, but needs to be deprecated later)
  • move rotary encoder related files to shared/rotary
  • move multistep wizard into a separate folder in app

TODO (for future PR):

  • decompose icons from top-level folder into feature folders
  • move Controllers to shared/values
+81 -329

3 comments

59 changed files

rohanpurohit

pr closed time in 4 days

push eventpez-globo/pufferfish-software

rohan

commit sha d6aac6ea3f4488247e06d354ebf1de1ad96d4019

fix eslint errors

view details

push time in 4 days

pull request commentpez-globo/pufferfish-software

Restructure frontend files into feature folders

Tested the frontend and accessed standard features on the backend simulator and everything looks good to me. since these were just file restructuring and the content inside the files hasn't changed, I'll be merging this in.

rohanpurohit

comment created time in 4 days

push eventpez-globo/pufferfish-software

Raavi

commit sha 964ac3611a7a798e087a813632902ab3328f66f4

Unit test for Util (#425) * Unit test for Util 1.EnumMap 2.EnumSet 3.OrderedMap 4.RingBuffer * Unit Test cases for 1. EnumMap 2.EnumSet 3.OrderedMap * Additional test cases for 1.EnumMap 2.EnumSet 3.OrderedMap 4.RingBuffer 5.Vector Solved an issue for vector initializer list in Vector.h file * Catch2-clang-tidy fixes * Catch2-clang-tidy fixes * Catch2-clang-tidy * Catch2-clang-tidy fix * More unit tests for 1. EnumMap 2. EnumSet 3. OrderedMap 4. RingBuffer 5. Vector * Catch2-clang-tidy fixes * Catch2-clang-tidy * Catch2-Clang-Tidy fixes * Clang-tidy fix * Added tests in EnumMap for struct and cpp check error * Test cases for RingBuffer Fixed clang-tidy error * Clang-tidy fix * Clang-tidy fixes * Clang-tidy fix * Cpp-check error fix * Additional test for 1.EnumMap 2.EnumSet 3.OrderedMap 4.RingBuffer

view details

Raavi

commit sha 9109acee99fdbc158d4d822145c564578e9bfa7f

Unit Test case for SFM3019 Device (#437) * Unit Test case for SFM3019 * SFM3019 Device Unit Test * Clang-tidy fixes * More test for SFM3019 Device.cpp file * More Test cases for Device.h * Catch-clang-tidy fixes * Catch2-clang-tidy fixes * Format fixes * Additional tests and structural changes for Device.txt file * Catch2-clang-tidy fixes * Additional test in read_conversion factor and read_sample read_product_id is spilt into request_product_id and read_product_id * clang-tidy fixes * Format fixes * Structure changes in Device.txt file * Catch2-clang-tidy fixes * Structrural changes in request_conversion_factors and read_conversion_factors and read_sample function in txt file * Device.txt file small changes for typos

view details

Rohan Purohit

commit sha f09087d83d3598e5974413fdb17f3d8b354f199b

Reorganize some selectors and reducers (#442) * restructure selectors and reducers * rename updateState to receive message * make screen lock a request/response * fix pylint errors * fix eslint errors * fix build error * add screen lock simulator in the firmware * add screen_status_request to mc ouptut sched

view details

rohan

commit sha 22c998009b94a7f065cf1f1cba2e1291793827fc

Merge branch 'develop' into feature/frontend-file-structure

view details

rohan

commit sha 2449c925ffacf803133476d9a82294f89a1c9fa4

fix imports

view details

push time in 4 days

push eventpez-globo/pufferfish-software

Rohan Purohit

commit sha f09087d83d3598e5974413fdb17f3d8b354f199b

Reorganize some selectors and reducers (#442) * restructure selectors and reducers * rename updateState to receive message * make screen lock a request/response * fix pylint errors * fix eslint errors * fix build error * add screen lock simulator in the firmware * add screen_status_request to mc ouptut sched

view details

push time in 5 days

delete branch pez-globo/pufferfish-software

delete branch : feature/frontend-redux-restructure

delete time in 5 days

PR merged pez-globo/pufferfish-software

Reorganize some selectors and reducers domain: frontend stage: dev type: chore

This PR includes:

  • Resolves some TODO'S in redux store
  • implement screen lock in the simulator
  • implement screen lock in the firmware
+900 -615

4 comments

59 changed files

rohanpurohit

pr closed time in 5 days

pull request commentpez-globo/pufferfish-software

Reorganize some selectors and reducers

Tested this branch on the backend simulator, while checking the redux console for any regressions and accessed standard features of the frontend and there are no regressions that I faced, merging this now.

rohanpurohit

comment created time in 5 days

issue closedpez-globo/pufferfish-software

Backend AlarmMuteRequest KeyError exception

Backend prints an exception for AlarmMuteRequest:

  • The cause is unclear
  • frontend seems to have no side effects from this exception

Steps to reproduce:

  • random

This issue was split off from #386 comment

exception log:

021-06-10 14:35:32,522 ventserver.integration._trio INFO     Initializing from file: ParametersRequest
2021-06-10 14:35:32,524 ventserver.integration._trio INFO     Initializing from file: AlarmLimitsRequest
2021-06-10 14:35:32,527 ventserver.integration._trio INFO     Initializing from file: AlarmMuteRequest
2021-06-10 14:35:32,530 ventserver.integration._trio INFO     Initializing from file: SystemSettingRequest
2021-06-10 14:35:32,537 ventserver.protocols.devices.file.ReceiveFilter ERROR    MessageSender:
Traceback (most recent call last):
  File "/home/pi/pufferfish-software/backend/ventserver/protocols/transport/messages.py", line 65, in parse
    self.payload = message_object.parse(body_payload)
  File "/home/pi/.pyenv/versions/3.7.7/envs/ventserver/lib/python3.7/site-packages/betterproto/__init__.py", line 760, in parse
    parsed.wire_type, meta, field, parsed.value
  File "/home/pi/.pyenv/versions/3.7.7/envs/ventserver/lib/python3.7/site-packages/betterproto/__init__.py", line 701, in _postprocess_single
    fmt = _pack_fmt(meta.proto_type)
  File "/home/pi/.pyenv/versions/3.7.7/envs/ventserver/lib/python3.7/site-packages/betterproto/__init__.py", line 288, in _pack_fmt
    }[proto_type]
KeyError: 'uint64'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/pi/pufferfish-software/backend/ventserver/protocols/devices/file.py", line 90, in output
    message = self._message_receiver.output()
  File "/home/pi/pufferfish-software/backend/ventserver/protocols/transport/messages.py", line 118, in output
    message.parse(body, self.message_classes)
  File "/home/pi/pufferfish-software/backend/ventserver/protocols/transport/messages.py", line 70, in parse
    ) from exc
ventserver.protocols.exceptions.ProtocolDataError: Unparseable payload: b'\x15\x00\x00\xf0B'
2021-06-10 14:35:32,539 ventserver.protocols.backend.server.ReceiveFilter ERROR    The state type NoneType data in the file does not match the filename AlarmMuteRequest.

closed time in 6 days

rohanpurohit

issue commentpez-globo/pufferfish-software

Backend AlarmMuteRequest KeyError exception

We've been unable to reproduce this, so I'll close it; we can reopen it if we see similar problems in the future.

rohanpurohit

comment created time in 6 days

delete branch pez-globo/pufferfish-software

delete branch : feature/firmware-driver-i2c-SFM3019

delete time in 9 days

push eventpez-globo/pufferfish-software

Raavi

commit sha 9109acee99fdbc158d4d822145c564578e9bfa7f

Unit Test case for SFM3019 Device (#437) * Unit Test case for SFM3019 * SFM3019 Device Unit Test * Clang-tidy fixes * More test for SFM3019 Device.cpp file * More Test cases for Device.h * Catch-clang-tidy fixes * Catch2-clang-tidy fixes * Format fixes * Additional tests and structural changes for Device.txt file * Catch2-clang-tidy fixes * Additional test in read_conversion factor and read_sample read_product_id is spilt into request_product_id and read_product_id * clang-tidy fixes * Format fixes * Structure changes in Device.txt file * Catch2-clang-tidy fixes * Structrural changes in request_conversion_factors and read_conversion_factors and read_sample function in txt file * Device.txt file small changes for typos

view details

push time in 9 days

PR merged pez-globo/pufferfish-software

Unit Test case for SFM3019 Device domain: firmware stage: test type: testing

Unit Test case for SFM3019 Device file

+1656 -17

3 comments

11 changed files

raavilagoo

pr closed time in 9 days

PullRequestReviewEvent

pull request commentpez-globo/pufferfish-software

Reorganize some selectors and reducers

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
  2. Were any of these contributions also part of work you did for an employer or a client? No.
  3. Does this work include, or is it based on, any third-party work which you did not create? No.
rohanpurohit

comment created time in 10 days

pull request commentpez-globo/pufferfish-software

Restructure frontend files into feature folders

  1. This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? Yes.
  2. Were any of these contributions also part of work you did for an employer or a client? No.
  3. Does this work include, or is it based on, any third-party work which you did not create? No.
rohanpurohit

comment created time in 10 days

PullRequestReviewEvent

pull request commentpez-globo/pufferfish-software

Unit Test case for SFM3019 Device

For records-keeping:

This project is licensed under Apache License v2.0 for any software, and Solderpad Hardware License v2.1 for any hardware - do you agree that your contributions to this project will be under these licenses, too? - Yes Were any of these contributions also part of work you did for an employer or a client? - No Does this work include, or is it based on, any third-party work which you did not create? - No

raavilagoo

comment created time in 11 days

pull request commentpez-globo/pufferfish-software

Restructure frontend files into feature folders

TODO: just a simple test to make sure everything works, and then approve

rohanpurohit

comment created time in 11 days

pull request commentpez-globo/pufferfish-software

Unit Test case for SFM3019 Device

@ethanjli This pull request is ready for review.

raavilagoo

comment created time in 11 days

push eventpez-globo/pufferfish-software

Raavi

commit sha 5f371c73358c95832ad24a042f0ba53b0821d81e

Device.txt file small changes for typos

view details

push time in 11 days

push eventpez-globo/pufferfish-software

Raavi

commit sha 964ac3611a7a798e087a813632902ab3328f66f4

Unit test for Util (#425) * Unit test for Util 1.EnumMap 2.EnumSet 3.OrderedMap 4.RingBuffer * Unit Test cases for 1. EnumMap 2.EnumSet 3.OrderedMap * Additional test cases for 1.EnumMap 2.EnumSet 3.OrderedMap 4.RingBuffer 5.Vector Solved an issue for vector initializer list in Vector.h file * Catch2-clang-tidy fixes * Catch2-clang-tidy fixes * Catch2-clang-tidy * Catch2-clang-tidy fix * More unit tests for 1. EnumMap 2. EnumSet 3. OrderedMap 4. RingBuffer 5. Vector * Catch2-clang-tidy fixes * Catch2-clang-tidy * Catch2-Clang-Tidy fixes * Clang-tidy fix * Added tests in EnumMap for struct and cpp check error * Test cases for RingBuffer Fixed clang-tidy error * Clang-tidy fix * Clang-tidy fixes * Clang-tidy fix * Cpp-check error fix * Additional test for 1.EnumMap 2.EnumSet 3.OrderedMap 4.RingBuffer

view details

push time in 12 days

delete branch pez-globo/pufferfish-software

delete branch : feature/firmware-unit-test-util

delete time in 12 days