profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/pdehaan/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Peter deHaan pdehaan @mozilla Errington, BC, Canada http://about.me/peterdehaan The pinnacle of mediocrity.

felixge/node-style-guide 4800

A guide for styling your node.js / JavaScript code. Fork & adjust to your taste.

mozilla/fathom 1914

A framework for extracting meaning from web pages

mozilla/multi-account-containers 1781

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.

mozilla/contain-facebook 843

Facebook Container isolates your Facebook activity from the rest of your web activity in order to prevent Facebook from tracking you outside of the Facebook website via third party cookies.

mozilla/fx-private-relay 768

Keep your email safe from hackers and trackers. Make an email alias with 1 click, and keep your address to yourself.

mozilla/blurts-server 470

Firefox Monitor arms you with tools to keep your personal information safe. Find out what hackers already know about you and learn how to stay a step ahead of them.

mozilla/notes 458

A notepad for Firefox

mozilla/activity-stream 184

A refreshed "new tab page" for Firefox

bwinton/SnoozeTabs 144

An add-on to let you snooze your tabs for a while.

mozilla/gcp-ingestion 50

Documentation and implementation of telemetry ingestion on Google Cloud Platform

Pull request review commentmozilla/experimenter

fix 6308 - Validate targeting configs for desktop on CI.

+from urllib.parse import urlparse+ import pytest+import requests+from nimbus.pages.browser import Browser from nimbus.pages.experimenter.summary import SummaryPage from nimbus.pages.remote_settings.dashboard import Dashboard from nimbus.pages.remote_settings.login import Login  +def load_data():+    apps = []+    data = requests.post(+        "https://nginx/api/v5/graphql",+        json={+            "operationName": "getConfig",+            "variables": {},+            "query": "\nquery getConfig {\n  nimbusConfig "+            "{\n    targetingConfigs {\n      "+            "label\n      value\n      applicationValues\n    "+            "}\n  }\n}\n",+        },+        verify=False,+    ).json()+    for item in data["data"]["nimbusConfig"]["targetingConfigs"]:+        if "DESKTOP" in item["applicationValues"]:+            apps.append(item["value"])+    return apps

Not sure if you want to do this or not. I'm indifferent to syntax if you think one is better or more legible than the other option.

jrbenny35

comment created time in 17 hours

Pull request review commentmozilla/experimenter

fix 6308 - Validate targeting configs for desktop on CI.

 class SummaryPage(ExperimenterBase):      _page_wait_locator = (By.CSS_SELECTOR, "#PageSummary")     _approve_request_button_locator = (By.CSS_SELECTOR, "#approve-request-button")+    _launch_to_preview = (By.CSS_SELECTOR, "#launch-to-preview-button")

nit: should this have a _locator suffix for consistency?

jrbenny35

comment created time in 17 hours

Pull request review commentmozilla/experimenter

fix 6308 - Validate targeting configs for desktop on CI.

+Components.utils.import("resource://gre/modules/components-utils/FilterExpressions.jsm");+Components.utils.import("resource://gre/modules/components-utils/ClientEnvironment.jsm");++// Targeting++async function remoteSettings(arguments) {++    const TargetingContext = ChromeUtils.import(+        "resource://messaging-system/targeting/Targeting.jsm"+    )++    _experiment = JSON.parse(arguments[1])+    const targetingContext = new TargetingContext.TargetingContext(_experiment);+    let result = false;+    try {+        result = await targetingContext.evalWithDefault(arguments[0]);

What will this return? A Boolean true or false or throw an error which gets caught below on L17?

jrbenny35

comment created time in 17 hours

Pull request review commentmozilla/experimenter

fix 6308 - Validate targeting configs for desktop on CI.

+"""Browser Model"""+++class Browser:+    def execute_script(selenium, *args, script=None, context=None):+        if "chrome" in context:

Python Q: Is context a string, or array/object? I see one usage below which seems to specify "chrome" exact string, but curious why the in instead of exact string matching here.

jrbenny35

comment created time in 17 hours

Pull request review commentmozilla/experimenter

fix 6308 - Validate targeting configs for desktop on CI.

+Components.utils.import("resource://gre/modules/components-utils/FilterExpressions.jsm");+Components.utils.import("resource://gre/modules/components-utils/ClientEnvironment.jsm");++// Targeting++async function remoteSettings(arguments) {++    const TargetingContext = ChromeUtils.import(+        "resource://messaging-system/targeting/Targeting.jsm"+    )

nit: missing semi-colon. I wonder if these are getting linted by ESLint. Possibly not if they're new .js files in a new location.

Same nit would apply to L12, L18, and L23 below.

jrbenny35

comment created time in 17 hours

Pull request review commentmozilla/experimenter

fix 6308 - Validate targeting configs for desktop on CI.

+Components.utils.import("resource://gre/modules/components-utils/FilterExpressions.jsm");+Components.utils.import("resource://gre/modules/components-utils/ClientEnvironment.jsm");++// Targeting++async function remoteSettings(arguments) {++    const TargetingContext = ChromeUtils.import(+        "resource://messaging-system/targeting/Targeting.jsm"+    )++    _experiment = JSON.parse(arguments[1])

Not sure if you want to add any JavaScript comments around here on what arguments[1] (and arguments[0] indexes represent below). Ie: One's an expression, one's the data/context or whatever.

jrbenny35

comment created time in 17 hours

Pull request review commentmozilla/experimenter

fix 6308 - Validate targeting configs for desktop on CI.

 -k KLAR -m run_per_app -k FOCUS -m run_per_app -k DESKTOP -m run_once+-k DESKTOP -m run_parallel -n 2

Fasinating! Per above:

parallelism: 7 # This should match the number of entries in parallel_pytest_args.txt

Does "-n 2" mean we should increase parallelism by another level? (so 8 instead of 7). Or maybe I'm not fully grasping what -n is doing here.

jrbenny35

comment created time in 17 hours

PullRequestReviewEvent
PullRequestReviewEvent

issue openedmozilla/experimenter

A couple "Incomplete string escaping or encoding" warnings found via CodeQL

https://github.com/mozilla/experimenter/security/code-scanning

It's confusing, but both seem to be related to a not-very-recent https://github.com/mozilla/experimenter/pull/4855 PR, which is a couple super-simple docs links.

But CodeQL seems to think that they're suspicious and points to https://github.com/mozilla/experimenter/blob/df51d5e6cd62674e680cda9aedd0b3cdad5f3069/app/experimenter/docs/swagger-ui-bundle.js#L79-L79 which appears to be a minified production build of React 16.8.6.

Not sure why it's suspicious, if it's due to the emoji-in-link usage, or the fact it's a bold link.

created time in 18 hours

pull request comment11ty/11ty-website

Create 11ty-SASS.json

Thanks!

NikitaZanella

comment created time in 20 hours

push event11ty/11ty-website

NikitaZanella

commit sha 5dc4166bcdbcaad1474710fff90cd31f8c1f89ae

Create 11ty-SASS.json

view details

NikitaZanella

commit sha 2152f224051ed72f573794cc0607e6f32a733761

Update 11ty-SASS.json

view details

Peter deHaan

commit sha dd43a32e1a87c751900b14722d3564caa4e61667

Merge pull request #1171 from NikitaZanella/patch-1

view details

push time in 20 hours

PR merged 11ty/11ty-website

Create 11ty-SASS.json
+7 -0

0 comment

1 changed file

NikitaZanella

pr closed time in 20 hours

PullRequestReviewEvent

Pull request review comment11ty/11ty-website

Create 11ty-SASS.json

+{+	"url": "https://github.com/NikitaZanella/11ty-SASS",+	"name": "11ty-SASS",+	"description": "11ty blog starter template with SASS and Dark Mode",+	"author": "NikitaZanella",

Sorry, to confirm. Is this your Twitter handle? I think the 11ty site uses your Twitter handle (not GitHub or other) to resolve avatars.

NikitaZanella

comment created time in 20 hours

PullRequestReviewEvent

pull request comment11ty/11ty-website

Add eleventy-plugin-torchlight

Thanks!

timkley

comment created time in a day

push event11ty/11ty-website

Tim

commit sha a1ebabebae3f335dc73e036ad5d2cf03b70c8604

add plugin

view details

Peter deHaan

commit sha 9252794e066a4fca31a04fda549a5bd25155c406

Merge pull request #1163 from timkley/add-torchlight-plugin Add eleventy-plugin-torchlight

view details

push time in a day

PullRequestReviewEvent

pull request comment11ty/11ty-website

Create 11ty-midnight

Thanks!

sidswork

comment created time in a day

push event11ty/11ty-website

sid

commit sha 757ef8a5ba508eeaf4164ea225dee87a1834956d

Create 11ty-midnight Demo- https://11ty-midnight.netlify.app Github - https://github.com/sidswork/11ty-midnight.git

view details

Peter deHaan

commit sha fdef9475aa766f5e4cdbecfc260c82be0f825a0f

Rename 11ty-midnight to 11ty-midnight.json

view details

Peter deHaan

commit sha b24f0f49af15c3f29b6625ef96ac843b8b462e30

Merge pull request #1167 from sidswork/patch-1 Create 11ty-midnight

view details

push time in a day

push eventsidswork/11ty-website

Peter deHaan

commit sha fdef9475aa766f5e4cdbecfc260c82be0f825a0f

Rename 11ty-midnight to 11ty-midnight.json

view details

push time in a day

PullRequestReviewEvent

pull request comment11ty/11ty-website

nho.io is now nho.link

No, no, thank you!

nhoizey

comment created time in a day

push event11ty/11ty-website

David Darnes

commit sha 0eaac319fafd062b38e29b6d0bddef07c927d3c4

Add my site and flag myself as available for business

view details

Peter deHaan

commit sha 596200c541bd72c930321c04ad003bb49feacc99

Merge pull request #1168 from daviddarnes/patch-1

view details

push time in a day

PullRequestReviewEvent

Pull request review comment11ty/11ty-website

Add my site and flag myself as available for business

+{+	"name": "David Darnes",+	"url": "https://darn.es/",+	"description": "The personal portfolio and blog of David Darnes",+	"twitter": "daviddarnes",+	"authoredBy": ["daviddarnes"],+  "business": {+		"cta": "https://darn.es/#contact",+    "availability": "2021-12-01"

Oh interesting! I didn't know that was a supported field. https://github.com/11ty/11ty-website/blob/d0a28dbb6d4b6f459273e71c66e63993101bae6d/src/blog/2021-02-26-espbn.md

daviddarnes

comment created time in a day