profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/pat270/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

pat270/clay-paver 8

Live Browser Based Customizer for Liferay Clay

pat270/alloy-ui 0

AlloyUI is a framework built on top of YUI3 that provides a simple API for building high scalable applications.

pat270/alloyui.com 0

Website for AlloyUI

PR opened liferay/clay

fix(@clayui/css): Alerts allow better customization of alert variant components

fixes #4304

  • Make same changes to Cadmin
  • Adds Sass maps $alert-primary, $alert-secondary, $alert-info, $alert-warning, $alert-danger, $alert-light, $alert-dark
  • Use clay-alert-variant mixin to generate alert variant styles
  • Mixins Alerts adds clay-alert-variant mixin and deprecate Bootstrap's alert-variant mixin
+971 -345

0 comment

6 changed files

pr created time in 4 hours

create barnchpat270/lexicon

branch : clay-4304

created branch time in 4 hours

pull request commentliferay-frontend/liferay-portal

LPS-138088 blogs-web info-bar unstyled due to cadmin

ci:forward

pat270

comment created time in 5 hours

issue openedliferay/clay

@clayui/css: Alert Variants convert to using new Sass map pattern

Alert Variant variables can be simplified to something like:

$alert-primary: () !default;
$alert-primary: map-deep-merge((
    background-color: $primary,
    color: $white,
    alert-close: (),
    alert-link: (),
    alert-btn: (),
), $alert-primary);

created time in 3 days

push eventliferay/clay

Patrick Yeo

commit sha 9b93ca0852c4e50b14a3e8ce4c07ff5e3b0235be

fix(@clayui/css): Global Variables deprecate Bootstrap's `$escaped-characters` variable

view details

Patrick Yeo

commit sha e8ffa5d3bb17cc0cb2e163dd5c3217c7dcb31b53

fix(@clayui/css): Global Functions deprecate Bootstrap's `escape-svg` function

view details

Patrick Yeo

commit sha c1cd8a2105a1fd759a1c36e18942f2de20d84bb8

fix(@clayui/css): Carousel, Custom Forms convert variables using Bootstrap's `url("data:image/svg+xml,<svg></svg>")` to use `clay-svg-url` Bootstrap's `url("data:image/svg+xml,<svg></svg>")` pattern will no longer be supported in the next major release.

view details

Patrick Yeo

commit sha 54d39f92a3971fec4300e3987cb0be5a6348f7bd

fix(@clayui/css): Global Variables deprecate Bootstrap 4 `$enable-hover-media-query`, `$caret-width`, `$caret-vertical-align`, `$caret-spacing`, `$emphasized-link-hover-darken-percentage`

view details

Patrick Yeo

commit sha eef416b4c1ee31fb4960fc886f4bbe0156f03071

Merge pull request #4280 from pat270/clay-4279 fix(@clayui/css): Global Variables deprecate unused Bootstrap 4 variables

view details

push time in 3 days

issue closedliferay/clay

@clayui/css: Document Deprecated Global Variables

There are a lot of variables from Bootstrap that aren't being officially used. We should deprecate them. This one is for Global Variables. Some examples:

$escaped-characters: (('<', '%3c'), ('>', '%3e'), ('#', '%23')) !default;
$enable-hover-media-query: false !default;
$caret-width: 0.3em !default;
$caret-vertical-align: $caret-width * 0.85 !default;
$caret-spacing: $caret-width * 0.85 !default;

closed time in 3 days

pat270

Pull request review commentliferay/clay

fix(@clayui/css): Cards and Panels remove decision making if statements from border-radius and border-width

 	position: relative; 	word-wrap: break-word; -	@if ($card-border-radius > 0) {-		.autofit-col {-			&:first-child {-				@include border-left-radius($card-inner-border-radius);-			}+	.autofit-col {+		&:first-child {+			@include border-left-radius($card-inner-border-radius);+		} -			&:last-child {-				@include border-right-radius($card-inner-border-radius);-			}+		&:last-child {+			@include border-right-radius($card-inner-border-radius);

@matuzalemsteles yes, I tried to save some CSS a long time ago. It doesn't really work well.

pat270

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentliferay/clay

feat(@clayui/css): Form Validation adds `$input-danger`, `$input-warning`, `$input-success`, `$input-danger-select`, `$input-warning-select`, `$input-success-select` Sass maps with `clay-form-control-variant` and `clay-select-variant` for more customization options

 $form-feedback-font-weight: $font-weight-semi-bold !default;  $form-feedback-indicator-margin-x: 0 !default; -// Input Variants+// .has-error .form-control  $input-danger-bg: $danger-l2 !default; $input-danger-border-color: $danger-l1 !default; // Will need to be revisited if https://github.com/twbs/bootstrap/pull/24821 merge error is fixed $input-danger-box-shadow: 0 0 rgba(0, 0, 0, 0) !default;-$input-danger-focus-box-shadow: $input-focus-box-shadow !default; $input-danger-color: $input-color !default; +$input-danger-focus-box-shadow: $input-focus-box-shadow !default;++$input-danger: () !default;+$input-danger: map-deep-merge(+	(+		background-color: $input-danger-bg,+		border-color: $input-danger-border-color,+		box-shadow: $input-danger-box-shadow,+		color: $input-danger-color,+		focus: (+			box-shadow: $input-danger-focus-box-shadow,+		),+	),+	$input-danger+);++// .has-error .form-control[readonly]+ $input-danger-readonly: () !default; $input-danger-readonly: map-deep-merge( 	(-		bg:+		background-color: 			setter( 				map-get($input-readonly, bg), 				map-get($input-readonly, background-color) 			), 		border-color: map-get($input-readonly, border-color),-		focus-border-color: $input-focus-border-color,+		focus: (+			border-color: $input-focus-border-color,+		),

@matuzalemsteles it gets handled by the clay-form-control-variant mixin. The alias is only done here because we are using the $input-readonly map directly and not processing it through a mixin.

pat270

comment created time in 3 days

PullRequestReviewEvent

PR opened liferay/clay

fix(@clayui/css): Forms `fieldset[disabled] .form-control` should use values from the `$input` Sass map and move rule-set closer to the `.form-control` rule-set

fixes #4285

This also fixes a similar issue with fieldset[disabled] label. Forms label.disabled should use properties declared in $input-label map and move the label.disabled rule-set closer to the label rule-set.

+58 -56

0 comment

4 changed files

pr created time in 3 days

create barnchpat270/lexicon

branch : clay-4285

created branch time in 3 days

push eventpat270/lexicon

Patrick Yeo

commit sha 2db8435bf806f2b829906eda7df1d9985d56d976

chore(clayui.com): Adds Sassdoc package

view details

Patrick Yeo

commit sha f4c5f4849be9fde84d745e5f88df3b222fb1cc0c

chore(clayui.com): Properly serve HTML files from the static directory

view details

Patrick Yeo

commit sha 41daa74fb01328f4561d832969eaa1ea5c3da95d

chore(clayui.com): Adds code to generate docs from scss files

view details

Patrick Yeo

commit sha 2e0b1f45970dbef92af1746f8dbe33f0aef08c75

docs(clayui.com): Generate Sass docs

view details

Patrick Yeo

commit sha b77c9392d370ad6b1168334e85dc9de45d1c3095

chore(clayui.com): Updates yarn.lock

view details

Patrick Yeo

commit sha ce92f0d8f8374f1e8ec91e6030f30f27b41c30ac

chore(clayui.com): SF

view details

Patrick Yeo

commit sha b1b309daf895f17d3d2ee4eb69ff50092ecb5f4c

fix(@clayui/css): Base Theme Global variables move settings toward the top of the file.

view details

Patrick Yeo

commit sha acb598ea5cef5577a6a50ade9d873d4129a30e9c

fix(@clayui/css): Atlas Global Variables define all global variables for easier copy and paste for those extending Clay CSS. This should help reduce undefined variable errors when reusing globals. fix(@clayui/css): Atlas Global Variables order should match Base Theme Global Variable order.

view details

Patrick Yeo

commit sha ece0b5bb0ccf6ad08a853fdf437495e62fc3d621

fix(@clayui/css): Buttons and Cadmin Buttons `.btn-monospaced` icons are off center by a pixel, use `display: inline-flex` to center and remove padding. If you need items to display inline in `.btn-monospaced` wrap them in a `span` tag.

view details

Patrick Yeo

commit sha a201f07e6c0551b36e343e6408c70f55ee64cdf1

chore(clayui.com): Rename Scss Api link to Sass Api and add link to home page nav

view details

Julien Castelain

commit sha b3df5681a157cf88963055c785b7b2272eb9743c

Merge pull request #4277 from pat270/clay-4274 fix(@clayui/css): Buttons and Cadmin Buttons `.btn-monospaced` icons …

view details

edalgrin

commit sha 0e254358a0854650dc9abfd093a98562737a52b6

feat(@clayui/css): Move .hide from liferay-portal to clay-css

view details

Matuzalém Teles

commit sha d64a41567ae7f7be55dd7cf83419f1372247c2e3

Merge pull request #4286 from edalgrin/LPS-134071 feat(@clayui/css): Move .hide from liferay-portal to clay-css

view details

Patrick Yeo

commit sha 94d21428a5b92bd901bf492f7d878fb7277ee294

Merge pull request #4272 from pat270/clay-4185 docs(clayui.css): Adds Scss API Documentation

view details

Matuzalém Teles

commit sha 187f1ef1f0cad070597c8b9888fb082f9c09cec4

fix(@clyaui/tooltip): fixes error when not forcing Tooltip repositioning when X axis is modified

view details

Matuzalém Teles

commit sha f29681e5232ec00dfd8b9f8e61953b6c20dc3def

fix(@clayui/drop-down): fixes the values of the `width` property of the Menu Adds a more detailed description about the API and removes the `auto` value that doesn't exist for `width` and adds the `full` that was missing.

view details

Matuzalém Teles

commit sha ece1061e709dae1f2431f356516fb99089272d7b

feat(@clayui/autocomplete): adds `closeOnClickOutside` API support to DropDown

view details

Julien Castelain

commit sha a5a5683fe3e0ce6ca4ebc0ec72c2a7df0bee4793

Merge pull request #4290 from matuzalemsteles/issue-4289 fix(@clyaui/tooltip): fixes error when not forcing Tooltip repositioning when X axis is modified

view details

Julien Castelain

commit sha 6c2b18e9f9af41bead48bfdeee102e813369a38a

Merge pull request #4276 from pat270/clay-4195-atlas fix(@clayui/css): Atlas Global Variables define all global variables for easier copy and paste for those extending Clay CSS

view details

Julien Castelain

commit sha b81ea21d56d93bd9d7e0b2fcc397be642678142e

Merge pull request #4291 from matuzalemsteles/issue-4288 fix(@clayui/drop-down): fixes the values of the `width` property of the Menu

view details

push time in 3 days

PR opened liferay/clay

fix(@clayui/css): Cadmin Form Validation adds missing styles for `.fo…

…rm-feedback-group,.form-feedback-item,.form-feedback-indicator, and.form-text`

fixes #4298

+38 -0

0 comment

2 changed files

pr created time in 4 days

push eventpat270/lexicon

Patrick Yeo

commit sha db260165b6eba3044061687e6190058d1d5d4550

fix(@clayui/css): Cadmin Form Validation adds missing styles for `.form-feedback-group`, `.form-feedback-item`,`.form-feedback-indicator`, and `.form-text` fixes #4298

view details

push time in 4 days

create barnchpat270/lexicon

branch : clay-4298

created branch time in 4 days

create barnchpat270/lexicon

branch : clay-4296

created branch time in 4 days

issue openedliferay/clay

@clayui/css: Cadmin Form Validation .form-feedback-item styles are missing

cadmin-form-feedback

It should have font-weight: 600 among other things.

created time in 4 days

PR opened liferay/clay

fix(@clayui/css): Cards and Panels remove decision making if statements from border-radius and border-width

fixes #4295

  • Global Functions math-sign should return a negative calc value if a CSS custom property is passed in
  • Inverse Sass variable values should use the math-sign function
+220 -295

0 comment

37 changed files

pr created time in 4 days

push eventpat270/lexicon

Patrick Yeo

commit sha 677e80440bb9866222d005dbda8a1d58cc08ff82

fix(@clayui/css): Cadmin Cards and Panels remove decision making if statements from border-radius and border-width. They were used to save a few bytes of CSS, not worth. fix(@clayui/css): Cadmin inverse Sass variable values should use the `math-sign` function

view details

push time in 4 days

create barnchpat270/lexicon

branch : clay-4295

created branch time in 4 days

issue openedliferay/clay

@clayui/css: Form Validation .form-control and select.form-control convert to using Sass map pattern

Provide more customization options and better CSS variable support by adding maps:

$input-danger: () !default;
$input-danger-select: () !default;
$input-success: () !default;
$input-success-select: () !default;
$input-warning: () !default;
$input-warning-select: !default;

created time in 4 days

issue commentliferay/clay

[Alert] Inline Actions

@drakonux It sounds like there are two types of alerts we need to modify?

https://clayui.com/docs/components/alert.html#using-with-claybutton We just need to remove <ClayAlert.Footer> from that example and get the spacing correct.

https://clayui.com/docs/components/alert.html#using-with-toastcontainer If we are able to remove/customize the class alert-notifications from https://github.com/liferay/clay/blob/e91895f788381be22112ad3e98a755a7992ff448/packages/clay-alert/src/ToastContainer.tsx#L30 Toast Alerts will grow based on the content inside. It will max out at the edge of the browser window and break to new line if the content is too long.

I think we already have the components to do what they want. We just need to mix, match, and add a little CSS to work out all the details. The contents of https://clayui.com/docs/components/alert/markup.html#css-alert-lists looks like what is outlined in the confluence doc.

drakonux

comment created time in 4 days

Pull request review commentliferay/clay

fix(@clayui/css): Global Variables deprecate unused Bootstrap 4 variables

 $custom-control-indicator-indeterminate-border-color: $custom-checkbox-indicator $custom-checkbox-indicator-indeterminate-box-shadow: none !default; $custom-checkbox-indicator-indeterminate-color: $custom-control-indicator-checked-color !default; -$custom-checkbox-indicator-icon-indeterminate: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' width='4' height='4' viewBox='0 0 4 4'><path stroke='#{$custom-checkbox-indicator-indeterminate-color}' d='M0 2h4'/></svg>") !default;+$custom-checkbox-indicator-icon-indeterminate: clay-svg-url(+	"<svg xmlns='http://www.w3.org/2000/svg' width='4' height='4' viewBox='0 0 4 4'><path stroke='#{$custom-checkbox-indicator-indeterminate-color}' d='M0 2h4'/></svg>"+) !default; $custom-checkbox-indicator-icon-indeterminate-bg-size: null !default;  // Custom Radio  $custom-radio-indicator-border-radius: 50% !default; -$custom-radio-indicator-icon-checked: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' width='12' height='12' viewBox='-4 -4 8 8'><circle r='3' fill='#{$custom-control-indicator-checked-color}'/></svg>") !default;+$custom-radio-indicator-icon-checked: clay-svg-url(+	"<svg xmlns='http://www.w3.org/2000/svg' width='12' height='12' viewBox='-4 -4 8 8'><circle r='3' fill='#{$custom-control-indicator-checked-color}'/></svg>"+) !default;

@matuzalemsteles I left the escape-svg() functions inside the components. We can run clay-svg-url through escape-svg without any errors. I tried to remove all uses of it, but I think we need to wait until the next major version.

pat270

comment created time in 5 days

PullRequestReviewEvent

push eventpat270/lexicon

Patrick Yeo

commit sha 70e256e71e7827983e6d096e550bbdeb23b9c4f0

fix(@clayui/css): Carousel, Custom Forms convert variables using Bootstrap's `url("data:image/svg+xml,<svg></svg>")` to use `clay-svg-url` Bootstrap's `url("data:image/svg+xml,<svg></svg>")` pattern will no longer be supported in the next major release.

view details

Patrick Yeo

commit sha 387f75ac04a6d1f0448f7d28eff7ccbccc406900

fix(@clayui/css): Global Variables deprecate Bootstrap 4 `$enable-hover-media-query`, `$caret-width`, `$caret-vertical-align`, `$caret-spacing`, `$emphasized-link-hover-darken-percentage`

view details

push time in 5 days

Pull request review commentliferay/clay

fix(@clayui/css): Atlas Global Variables define all global variables for easier copy and paste for those extending Clay CSS

 $c-unset: $clay-unset !default;  $clay-unset-placeholder: clay-unset-placeholder !default; +// Settings+

Can't think of another way other than documenting copy paste https://github.com/liferay/clay/blob/master/packages/clay-css/src/scss/atlas/variables/_globals.scss and https://github.com/liferay/clay/blob/master/packages/clay-css/src/scss/variables/_globals.scss at the top of your _clay_variables.scss file. It would result in duplicates for them.

Inserting _clay_variables.scss later in the import chain will cause the !default pattern not to work if they want to make their theme extendable or if they created a variable theme based on it due to Clay using it.

pat270

comment created time in 5 days