profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/pabigot/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Peter A. Bigot pabigot Peter Bigot Consulting, LLC Tucson, AZ, US http://www.pabigot.com/

pabigot/bsp430 35

Board Support Package for MSP430 microcontrollers

pabigot/FatFs 14

ELM-ChaN FAT file system release mirror

pabigot/buffer-layout 13

Node.js support for translating between JavaScript values and Buffers

pabigot/bspacm 9

A development environment for ARM Cortex-M Devices

pabigot/cc3000 7

Texas Instruments CC3000 Host Driver with mspgcc support

pabigot/embtextf 6

Embedded System Text Formatting

pabigot/fragpool 2

Variable-sized packet memory management for embedded applications

pabigot/eslint-plugin-pabigot 1

Rules and other ESLint extensions that suit my style

pabigot/AMQP-CPP 0

C++ library for asynchronous non-blocking communication with RabbitMQ

pabigot/amqp091-go 0

An AMQP 0-9-1 Go client maintained by the RabbitMQ team. Originally by @streadway: `streadway/amqp`

delete branch pabigot/cgo

delete branch : master

delete time in 17 days

create barnchpabigot/cgo

branch : master

created branch time in 17 days

PR closed nrfconnect/sdk-nrf

Reviewers
[draft, DNM] mass conversion of k_work API DNM

Use coccinelle to do a blanket translation from the deprecated API to the replacement API.

Conversions have been grouped into areas for convenience. There is no guarantee of bisectability between the resulting commits, as conversions in one commit may depend on conversions in another commit. Conversions of remaining time API are not optimized.

NOTE: These commits are not tested and not intended to be merged as is or via this PR. Area maintainers can cherry-pick or split the commits to create new PRs that change the API and address any relevant race conditions or other problems. See zephyrproject-rtos/zephyr#33104 and the documentation update in zephyrproject-rtos/zephyr#34466 for details on the API change and best practices to avoid mis-use of the work API.

+622 -620

3 comments

100 changed files

pabigot

pr closed time in 17 days

PR opened rabbitmq/amqp091-go

connection: clarify documented behavior of NotifyClose

The documentation for NotifyClose() differs between Channel:

The chan provided will be closed when the Channel is closed and on a graceful close, no error will be sent.

and Connection:

On normal shutdowns, the chan will be closed.

The latter wording suggests that on abnormal shutdowns the chan will remain open, with two expected features:

  • A non-blocking chan could be registered and the error notification would still be available to the application; and
  • a new Connection could pass that same chan to NotifyClose() so an existing select statement need not update the chan it monitors.

In fact the logic for maintaining close notifiers appears identical for both Channel and Connection: both are closed as a result of the underlying object being closed.

This PR updates to use the Channel description in the Connection function to avoid the misleading interpretation.

+2 -1

0 comment

1 changed file

pr created time in 19 days

create barnchpabigot/amqp091-go

branch : issue/20210830a

created branch time in 19 days

fork pabigot/amqp091-go

An AMQP 0-9-1 Go client maintained by the RabbitMQ team. Originally by @streadway: `streadway/amqp`

fork in 19 days

issue openedrabbitmq/amqp091-go

copyright issue?

It's great that this project is being actively maintained. While investigating a race condition I noticed that 65f6e252100da62430f7fa5074d7985f8e2f45d2 updated the source code link in the code files, but simultaneously replaced the existing copyright in the code files with one for VMWare or affiliates, rather than just adding the new claim.

Based on changes in other commits such as 34291f5dde8296e3863cab64b3d5486969ff8cd5 I believe the VMWare copyright should have been added to the files, leaving the existing copyright in place. Unless the original contributors to this project have formally transferred their rights to VMWare?

created time in 19 days

Pull request review commentzephyrproject-rtos/zephyr

Use ssize_t and off_t definitions from sys/types.h

 void main(void) 	!(FSTAB_ENTRY_DT_MOUNT_FLAGS(PARTITION_NODE) & FS_MOUNT_FLAG_AUTOMOUNT) 	rc = fs_mount(mp); 	if (rc < 0) {-		printk("FAIL: mount id %u at %s: %d\n",-		       (unsigned int)mp->storage_dev, mp->mnt_point,+		printk("FAIL: mount id %llu at %s: %d\n",+		       (unsigned long long)mp->storage_dev, mp->mnt_point,

Agree; C pointers should only be converted to integer types via[u]intptr_t casts.

de-nordic

comment created time in a month

PullRequestReviewEvent

delete branch pabigot/zephyr

delete branch : issue/11626

delete time in a month

issue commentzephyrproject-rtos/zephyr

power rail management in low-power devices

@Snevzor https://github.com/zephyrproject-rtos/zephyr/issues/24416#issuecomment-618478101 has a summary related to that old plan. There was related content in the mass of work around #29644, but as of last April when I stopped working on Zephyr there was no plan to actually manage instance-specific device initialization order based on dependencies or code annotations.

pabigot

comment created time in a month

delete branch pabigot/telegraf

delete branch : issue9489

delete time in 2 months

issue closedinfluxdata/telegraf

rabbitmq plugin 1.19.1 api/federation-links failure

<!-- Please redirect any questions about Telegraf usage to the InfluxData Community site: https://community.influxdata.com

Check the documentation for the related plugin including the troubleshooting section if available. -->

Relevant telegraf.conf:

<!-- Place config in the toml code section. -->

# Reads metrics from RabbitMQ servers via the Management Plugin
[[inputs.rabbitmq]]
  queues = ["collate", "influxdb.write", "wsn.asrpdu", "wsn.signal"]
  exchanges = ["amq.topic", "influxdb", "openweather", "tasmota", "wsn"]
  queue_name_exclude = ["amq.gen-*", "mqtt-subscription-DVES_*"]

System info:

<!-- Include Telegraf version, operating system, and other relevant details -->

central20[7]$ uname -a
Linux central20 5.4.0-77-generic #86-Ubuntu SMP Thu Jun 17 02:35:03 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
central20[8]$ dpkg -l | grep telegraf
ii  telegraf                             1.19.1-1                                    amd64        Plugin-driven server agent for reporting metrics into InfluxDB.
central20[9]$ cat /etc/os-release 
NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.2 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Steps to reproduce:

<!-- Describe the steps to reproduce the bug. -->

Update from telegraph 1.19.0 to 1.19.1

Expected behavior:

<!-- Describe what you expected to happen when you performed the above steps. -->

Removal of unmarshal errors due to incorporation of #9443

Actual behavior:

<!-- Describe what actually happened when you performed the above steps. -->

While #9443 fixed part of the problem, https://github.com/influxdata/telegraf/issues/9383#issuecomment-869687723 notes that /api/federation-links in at least some installations does not exist, a problem that was masked by the unmarshal bug. My installation is now repeatedly complaining:

Jul 11 02:59:40 central20 telegraf[1353]: 2021-07-11T02:59:40Z E! [inputs.rabbitmq] Error in plugin: getting "/api/federation-links" failed: 404 Not Found
Jul 11 02:59:50 central20 telegraf[1353]: 2021-07-11T02:59:50Z E! [inputs.rabbitmq] Error in plugin: getting "/api/federation-links" failed: 404 Not Found

closed time in 2 months

pabigot

issue commentinfluxdata/telegraf

rabbitmq plugin 1.19.1 api/federation-links failure

This problem can be worked around as described in https://github.com/influxdata/telegraf/pull/9505#issuecomment-880451815

pabigot

comment created time in 2 months

PR closed influxdata/telegraf

Make rabbitmq federation plugin optional enhancement

Required for all PRs:

<!-- Complete the tasks in the following list. Change [ ] to [x] to show completion. -->

  • [x] Updated associated README.md.
  • [x] Wrote appropriate unit tests.

<!-- Link to issues that describe the need for the change. Issues should include context that will help reviewers understand why the change is needed.

Make sure to link issues and using a keyword like "resolves #1234". https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword -->

resolves #9489

<!-- Finally, include a summary of the code change itself. This description should tell reviewers how the issues were resolved.

example: Fixed an off by one error in counter variable in type FooBar.

example: Added an input plugin to gather yak shaving metrics using golang library yaktech/shaver. -->

Do not record an error for a 404 return for api/federation-links.

+12 -7

3 comments

3 changed files

pabigot

pr closed time in 2 months

pull request commentinfluxdata/telegraf

Make rabbitmq federation plugin optional

I wonder why you can't use metric_include or metric_exclude introduced in PR #9443

Because I didn't know about it. That feature isn't mentioned anywhere in #9383, nor in the commit message that resolved it, and my scan of the changes to the source didn't pick it up.

It does work, though. Thanks.

pabigot

comment created time in 2 months

push eventpabigot/telegraf

Peter A. Bigot

commit sha 79ba092ef08b29896832b7a8fcc693ed0c5900a2

Make rabbitmq federation plugin optional (#9505)

view details

push time in 2 months

PR opened influxdata/telegraf

Make rabbitmq federation plugin optional

Required for all PRs:

<!-- Complete the tasks in the following list. Change [ ] to [x] to show completion. -->

  • [x] Updated associated README.md.
  • [x] Wrote appropriate unit tests.

<!-- Link to issues that describe the need for the change. Issues should include context that will help reviewers understand why the change is needed.

Make sure to link issues and using a keyword like "resolves #1234". https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword -->

resolves #9489

<!-- Finally, include a summary of the code change itself. This description should tell reviewers how the issues were resolved.

example: Fixed an off by one error in counter variable in type FooBar.

example: Added an input plugin to gather yak shaving metrics using golang library yaktech/shaver. -->

Do not record an error for a 404 return for api/federation-links.

+12 -7

0 comment

3 changed files

pr created time in 2 months

push eventpabigot/telegraf

Peter A. Bigot

commit sha b8ebb0db7ac85195278bf6678aa02f0d0c987a95

Make rabbitmq federation plugin optional

view details

push time in 2 months

create barnchpabigot/telegraf

branch : issue9489

created branch time in 2 months

issue commentinfluxdata/telegraf

rabbitmq plugin 1.19.1 api/federation-links failure

It appears #6283 is based on an expectation that the federation plugin is enabled, although the module is opt-in (and not useful in a single-broker installation). There seems to be no way to opt out of attempting to collect the data, or to indicate that absence of the plugin is not an error.

What's the right solution? @jacquesh?

pabigot

comment created time in 2 months

issue openedinfluxdata/telegraf

rabbitmq plugin 1.19.1 api/federation-links failure

<!-- Please redirect any questions about Telegraf usage to the InfluxData Community site: https://community.influxdata.com

Check the documentation for the related plugin including the troubleshooting section if available. -->

Relevant telegraf.conf:

<!-- Place config in the toml code section. -->

# Reads metrics from RabbitMQ servers via the Management Plugin
[[inputs.rabbitmq]]
  queues = ["collate", "influxdb.write", "wsn.asrpdu", "wsn.signal"]
  exchanges = ["amq.topic", "influxdb", "openweather", "tasmota", "wsn"]
  queue_name_exclude = ["amq.gen-*", "mqtt-subscription-DVES_*"]

System info:

<!-- Include Telegraf version, operating system, and other relevant details -->

central20[7]$ uname -a
Linux central20 5.4.0-77-generic #86-Ubuntu SMP Thu Jun 17 02:35:03 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
central20[8]$ dpkg -l | grep telegraf
ii  telegraf                             1.19.1-1                                    amd64        Plugin-driven server agent for reporting metrics into InfluxDB.
central20[9]$ cat /etc/os-release 
NAME="Ubuntu"
VERSION="20.04.2 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.2 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Steps to reproduce:

<!-- Describe the steps to reproduce the bug. -->

Update from telegraph 1.19.0 to 1.19.1

Expected behavior:

<!-- Describe what you expected to happen when you performed the above steps. -->

Removal of unmarshal errors due to incorporation of #9443

Actual behavior:

<!-- Describe what actually happened when you performed the above steps. -->

While #9443 fixed part of the problem, https://github.com/influxdata/telegraf/issues/9383#issuecomment-869687723 notes that /api/federation-links in at least some installations does not exist, a problem that was masked by the unmarshal bug. My installation is now repeatedly complaining:

Jul 11 02:59:40 central20 telegraf[1353]: 2021-07-11T02:59:40Z E! [inputs.rabbitmq] Error in plugin: getting "/api/federation-links" failed: 404 Not Found
Jul 11 02:59:50 central20 telegraf[1353]: 2021-07-11T02:59:50Z E! [inputs.rabbitmq] Error in plugin: getting "/api/federation-links" failed: 404 Not Found

created time in 2 months

issue commentpabigot/buffer-layout

Add typescript definitions

I don't know; I did play with TypeScript a while back, but not enough to use it. Depends on how much of a maintenance impact it has.

jstarry

comment created time in 2 months

PR merged pabigot/buffer-layout

Improve browser compatibility for Buffer usage

Fixes: https://github.com/pabigot/buffer-layout/issues/28

Changes

  1. Explicitly require buffer module so that bundlers can polyfill it for browser apps but use the global Buffer if available.
  2. Loosened type checks from Buffer.isBuffer to instanceof Uint8Array to improve API for browser apps
+94 -21

9 comments

2 changed files

jstarry

pr closed time in 2 months

push eventpabigot/buffer-layout

Justin Starry

commit sha 94d0cef64bd2cc52d6a1f27f13217a4d07a47153

Layout: Select Buffer implementation based on environment Use the presence of a variable defined in browser environments to select whether the Buffer implementation is built in to the environment or needs to be retrieved from a (potentially external) module. This allows use of the package in Node.js, pure ECMAScript, and browser environments. Signed-off-by: Justin Starry <justin@solana.com>

view details

Justin Starry

commit sha 0ccc8682fff58e39bf33695fe52079661310c328

Layout: Accept Uint8Array type wherever the API expects a Buffer Loosen Buffer type checks to accept the Uint8Array base class. Uint8Array is preferred over Buffer due to its presence in both Node.js and browser environments. When Buffer methods are needed, create a new Buffer instance which uses the same underyling memory of the Uint8Array parameter. Signed-off-by: Justin Starry <justin@solana.com>

view details

push time in 2 months

pull request commentpabigot/buffer-layout

Improve browser compatibility for Buffer usage

This is a big change; I don't want to publish a version that claims to work in a browser without confirmation it works in that environment. Can you install it in the environment you need it in and confirm that this specific code (not just your original version) works there? I agree automated testing is highly desirable, but I don't even know how to do it manually.

jstarry

comment created time in 2 months

pull request commentpabigot/buffer-layout

Improve browser compatibility for Buffer usage

This looks fine. Please confirm that this branch works as intended in a browser environment, since there's currently nothing in place to confirm that.

jstarry

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentpabigot/buffer-layout

Improve browser compatibility for Buffer usage

  ## [1.2.2] - 2021-07-05 -* Improve [browser compatibility][pr#26] by eliminating a dependence on+* Improve [browser compatibility][pr#27] by eliminating a dependence on

The CHANGELOG modification seems to still be present; I can remove it in next after merging or you can update your commit. (Not sure why github thinks there are 13 commits in your PR; the targeting to next looks right, and the first 11 are already in that branch. Weird.)

Also, could you do npm run eslint and fix the things it diagnoses?

jstarry

comment created time in 2 months