profile
viewpoint
Gray Zhang otakustay Long lives alien! Shanghai China http://www.otakustay.com

baidu/san 4228

A fast, portable, flexible JavaScript component framework

otakustay/danmaku-to-ass 79

A站B站弹幕转字幕文件

ecomfe/react-suspense-boundary 53

A boundary component working with suspense and error

baidu/san-update 52

Object immutable update utility for san solution

baidubce/bce-sdk-js 48

Baidu Cloud Engine JavaScript SDK

ecomfe/react-track 36

A declarative, component based solution to track page views and user events with react & react-router

otakustay/alfred-workflow-bilibili 32

A alfred2 workflow to search videos in bilibili.tv

otakustay/CSS3UsabilityReport 20

Report & Chart for usability of new features in CSS3

issue commentwebpack-contrib/worker-loader

Add a worker implementation based on fetch

When publicPath is set to an external domain like http://cdn.my-app.com/assets/, worker-loader generated worker script can fail to load, just as documented: https://github.com/webpack-contrib/worker-loader#cross-origin-policy

To address this, document suggests inline option but this increase bundle size impressively

There is a way to get rid of the CORS issue and having worker scripts in a separated bundle if worker-loader can generate its content to a custom blob and a importScripts call according to this article: https://benohead.com/blog/2017/12/06/cross-domain-cross-browser-web-workers/

otakustay

comment created time in 11 hours

issue commentwebpack-contrib/worker-loader

Add a worker implementation based on fetch

It seems credentials option does not address cors issues, worker doesn't support cors script no matter what credentials is.

otakustay

comment created time in 20 hours

issue commentotakustay/react-diff-view

Add support for drag-start and drag-end events

For gutters only, I think we have already exposed renderGutter function prop so that you can render it with draggable and droppable hocs, if any functionality should be supported, please have a more detailed description

If it is a problem about the total complexity using renderGutter, we may support this via document or demo sandbox

siddhant1

comment created time in 2 days

issue commentotakustay/react-diff-view

Inline-block may cause Chrome's built-in search to fail to match the corresponding content

https://bugs.chromium.org/p/chromium/issues/detail?id=1094588&q=search%20inline-block&can=2

colorpeach

comment created time in 9 days

push eventotakustay/react-diff-view

otakustay

commit sha 049892c6494874dd118daeb8c2f9a6581c0151b0

chore: add stale bot

view details

push time in 9 days

issue closedotakustay/react-diff-view

Does it support both word diff and line diff highligiting?

I see it highlights a line for xml file compare, but not seeing word diff highlighting within a line.

closed time in 9 days

paul777888

issue closedotakustay/react-diff-view

Support two table difference

Can we compare data of two different tables

closed time in 9 days

dollychhabriya

issue closedotakustay/react-diff-view

有中文文档吗

closed time in 9 days

Lcj-space

issue openedotakustay/react-diff-view

Built-in virtual list support

Yes, theoretically react-diff-view supports virtual list, users can manipulate diff objects into many many hunks and have each hunk loaded by scroll, however this is not perfect:

  1. Manipulating hunks isn't an easy work, this involves finding a good split point and remaining left and right side relations, especially difficult when nearbySequences: 'zip' is not enabled.
  2. Guessing hunk's rendered height is still difficult, this is not a must, but a more friendly scroll height is always welcome

API

I'm planning to have a <Virtualized> component wrapping current <Diff> to enable this behavior:

<Virtualized>
  {/* Supports multiple diffs */}
  <Diff {...props} />
  <Diff {...props} />
</Virtualized>

This makes least migration efforts from previous usage.

Inside implement

Before creating a virtual list, Diff could first have a look at its hunks and all changes inside, for a diff with little code to render, just disable virtual list by default.

When a diff contains a large amount of hunks, virtual list first works on top of hunks, if a hunk contains an affordable count of changes, it is rendered with out any lazy strategies.

Only when a hunk contains a lot of changes, virtual list is enabled on change level which will behaves as a lazy render of <tr> elements.

created time in 9 days

issue commentotakustay/react-diff-view

Inline-block may cause Chrome's built-in search to fail to match the corresponding content

But why we are using inline-block, just can't remember, any idea @dancerphil ?

colorpeach

comment created time in 9 days

issue commentotakustay/react-diff-view

Inline-block may cause Chrome's built-in search to fail to match the corresponding content

Aware of this issue, but currently I can't find an appropriate solution, inline-flex also breaks search

colorpeach

comment created time in 9 days

push eventecomfe/react-hooks

otakustay

commit sha 9570f4be24927bfeb2932f257cd1a469eb0fd4ec

refractor: move to new reskript tools

view details

push time in 9 days

PR merged ecomfe/react-hooks

upgrade to new reskript tools
+3420 -3404

0 comment

130 changed files

otakustay

pr closed time in 9 days

push eventecomfe/react-hooks

Chen Zhouji

commit sha 7373649bfe05eae0f3545a822e8d6e8e142ffc4c

docs(optimistic): fix code in tutorial

view details

push time in 9 days

PR merged ecomfe/react-hooks

update docs
+1 -1

0 comment

1 changed file

ice-zjchen

pr closed time in 9 days

PR opened ecomfe/react-hooks

upgrade to new reskript tools
+3420 -3404

0 comment

130 changed files

pr created time in 10 days

create barnchecomfe/react-hooks

branch : reskript

created branch time in 10 days

issue closedecomfe/react-hooks

useTransitionState的返回类型错误

没有返回正常的tuple,变成一个混合数组了

closed time in 10 days

otakustay

delete branch ecomfe/react-hooks

delete branch : fix-transition-state-type

delete time in 10 days

push eventecomfe/react-hooks

otakustay

commit sha fe5e5f118b619771ea825f52fe8bb10d81802418

fix(transition-state): incorrect return type of useTransitionState (#42)

view details

push time in 10 days

create barnchotakustay/minimal-package-json

branch : master

created branch time in 15 days

created repositoryotakustay/minimal-package-json

A small package to minimize package.json content

created time in 15 days

issue commentbaidubce/bce-sdk-js

关于TS类型的一些问题

另外BosEndpoint这个类型感觉没必要,就用string类型就好了

原因是endpoint很多时候是用配置拼出来的,比如这样:

endpoint: `https://${process.env.BCE_REGION}.bcebos.com`

TS是无法推导这个类型到BosEndpoint上面去的,不得不用as BosEndpoint去搞定,没啥意思

otakustay

comment created time in 16 days

issue openedbaidubce/bce-sdk-js

关于TS类型的一些问题

第一个问题是package.json中没有types字段,所以解析不到:

image

第二个问题是代码库用了export =导出整个,但实际上我觉得应该是named export更合适些?

created time in 16 days

create barnchecomfe/react-hooks

branch : fix-transition-state-type

created branch time in 16 days

issue closedecomfe/react-hooks

useInputValue与TextArea不兼容

const comment = useInputValue('');
<Input.TextArea {...comment} />

以上代码会有类型问题

closed time in 16 days

otakustay

issue commentecomfe/react-hooks

useInputValue与TextArea不兼容

Fixed in https://github.com/ecomfe/react-hooks/commit/8d37350e351ec0115a143b1f80f1c359e7a97b34

otakustay

comment created time in 16 days

delete branch ecomfe/react-hooks

delete branch : fix

delete time in 16 days

push eventecomfe/react-hooks

otakustay

commit sha 8d37350e351ec0115a143b1f80f1c359e7a97b34

fix(input-value): make useInputValue type compatible to textarea

view details

push time in 16 days

issue openedecomfe/react-hooks

useTransitionState的返回类型错误

没有返回正常的tuple,变成一个混合数组了

created time in 16 days

startedjeffbski/wait-on

started time in 20 days

startedfrancisrstokes/super-expressive

started time in 20 days

startedgalio-org/galio

started time in 20 days

startedttalvitie/browservice

started time in 24 days

issue commentwebpack/webpack

webpack 5 beta feedback

Created #1154

sokra

comment created time in a month

issue openedwebpack/webpack

Export more types from types.d.ts

<!-- Please don't delete this template or we'll close your issue -->

Feature request

webpack@5's bult-in types have less types exported than @types/webpack, some of them are quite useful to implement a custom build too.

Some types can be inferred from existing ones but requires a lot of work like this:

import {RuleSetRule} from 'webpack';

type RuleSetUse = Exclude<RuleSetRule['use'], undefined>;

type LoaderFactory = (context: OurCustomBuildContext) => RuleSetUse | null;

<!-- Issues which contain questions or support requests will be closed. --> <!-- Before creating an issue please make sure you are using the latest version of webpack. --> <!-- Check if this feature need to be implemented in a plugin or loader instead --> <!-- If yes: file the issue on the plugin/loader repo --> <!-- Features related to the development server should be filed on this repo instead -->

What is the expected behavior?

I'm currently missing these types:

  • RuleSetCondition
  • RuleSetConditionAbsolute
  • RuleSetUse
  • RuleSetUseItem
  • RuleSetLoader (the object structure of module.rules.use)

What is motivation or use case for adding/changing the behavior?

By exporting more types, developers can create more robust build tools with typescript.

How should this be implemented in your opinion?

Yes

Are you willing to work on this yourself?

I can try to create a PR to export types above.

created time in a month

issue openedant-design/ant-design

Named import from json will be deprecated from webpack 5

  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://github.com/ant-design/ant-design/blob/3.x-stable/components/version/index.tsx

Steps to reproduce

  1. import {Button} from 'antd';
  2. build it with webpack@5

What is expected?

No warning or error is produced

What is actually happening?

Getting a warning message:

 warning  in ./node_modules/antd/es/version/index.js

Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon)
Environment Info
antd 3.26.18
React 16.13.1
System macOS
Browser Chrome

It seems webpack@5 is planning to depreacted named import from json files, we'd better change import {version} from '../../package.json to `import packageInfo from '../../package.json'

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->

created time in a month

issue commentwebpack/webpack

webpack 5 beta feedback

Also I'd like to suggest exporting more types like RuleSetRule, RuleSetUse from types.d.ts, for example we have a "loader factory" type which is currently implemented like this:

import {RuleSetRule} from 'webpack';

type RuleSetUse = Exclude<RuleSetRule['use'], undefined>;

type LoaderFactory = (context: OurCustomBuildContext) => RuleSetUse | null;

It can be simplified when RuleSetUse is directly exported. We are missing:

  • RuleSetCondition
  • RuleSetConditionAbsolute
  • RuleSetUse
  • RuleSetUseItem
  • RuleSetLoader (the object structure of module.rules.use)
sokra

comment created time in a month

issue commentwebpack/webpack

webpack 5 beta feedback

@types/mini-css-extract-plugin, @types/webpack-dev-server and @types/webpackbar all breaks, this is a long error log from my workspace:

../../node_modules/@types/mini-css-extract-plugin/index.d.ts:9:10 - error TS2724: Module '"../../webpack/types"' has no exported member 'compilation'. Did you mean 'Compilation'?

9 import { compilation, Plugin } from 'webpack';
           ~~~~~~~~~~~

../../node_modules/@types/mini-css-extract-plugin/index.d.ts:9:23 - error TS2305: Module '"../../webpack/types"' has no exported member 'Plugin'.

9 import { compilation, Plugin } from 'webpack';
                        ~~~~~~

../../node_modules/@types/webpack-dev-server/index.d.ts:295:25 - error TS2694: Namespace 'exports' has no exported member 'Options'.

295         stats?: webpack.Options.Stats;
                            ~~~~~~~

../../node_modules/@types/webpack-dev-server/index.d.ts:340:32 - error TS2694: Namespace 'exports' has no exported member 'WatchOptions'.

340         watchOptions?: webpack.WatchOptions;
                                   ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:32:3 - error TS2305: Module '"../../tapable/tapable"' has no exported member 'Tapable'.

32   Tapable,
     ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:992:23 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

992             resolver: SyncWaterfallHook;
                          ~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:993:22 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

993             factory: SyncWaterfallHook;
                         ~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:994:28 - error TS2314: Generic type 'AsyncSeriesWaterfallHook<T>' requires 1 type argument(s).

994             beforeResolve: AsyncSeriesWaterfallHook;
                               ~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:995:27 - error TS2314: Generic type 'AsyncSeriesWaterfallHook<T>' requires 1 type argument(s).

995             afterResolve: AsyncSeriesWaterfallHook;
                              ~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:996:27 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

996             createModule: SyncBailHook;
                              ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:997:21 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

997             module: SyncWaterfallHook;
                        ~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:998:27 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

998             createParser: HookMap;
                              ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1000:30 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1000             createGenerator: HookMap;
                                  ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1001:24 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1001             generator: HookMap;
                            ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1010:33 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1010                 evaluateTypeof: HookMap;
                                     ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1011:27 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1011                 evaluate: HookMap;
                               ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1012:37 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1012                 evaluateIdentifier: HookMap;
                                         ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1013:44 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1013                 evaluateDefinedIdentifier: HookMap;
                                                ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1014:47 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1014                 evaluateCallExpressionMember: HookMap;
                                                   ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1015:28 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1015                 statement: SyncBailHook;
                                ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1016:30 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1016                 statementIf: SyncBailHook;
                                  ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1017:24 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1017                 label: HookMap;
                            ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1018:25 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1018                 import: SyncBailHook;
                             ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1019:34 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1019                 importSpecifier: SyncBailHook;
                                      ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1020:25 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1020                 export: SyncBailHook;
                             ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1021:31 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1021                 exportImport: SyncBailHook;
                                   ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1022:36 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1022                 exportDeclaration: SyncBailHook;
                                        ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1023:35 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1023                 exportExpression: SyncBailHook;
                                       ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1024:34 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1024                 exportSpecifier: SyncBailHook;
                                      ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1025:40 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1025                 exportImportSpecifier: SyncBailHook;
                                            ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1026:33 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1026                 varDeclaration: SyncBailHook;
                                     ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1027:36 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1027                 varDeclarationLet: HookMap;
                                        ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1028:38 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1028                 varDeclarationConst: HookMap;
                                          ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1029:36 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1029                 varDeclarationVar: HookMap;
                                        ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1030:28 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1030                 canRename: HookMap;
                                ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1031:25 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1031                 rename: HookMap;
                             ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1032:27 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1032                 assigned: HookMap;
                               ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1033:25 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1033                 typeof: HookMap;
                             ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1034:29 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1034                 importCall: SyncBailHook;
                                 ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1035:23 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1035                 call: HookMap;
                           ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1036:32 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1036                 callAnyMember: HookMap;
                                    ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1037:22 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1037                 new: HookMap;
                          ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1038:29 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1038                 expression: HookMap;
                                 ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1039:38 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1039                 expressionAnyMember: HookMap;
                                          ~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1040:48 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1040                 expressionConditionalOperator: SyncBailHook;
                                                    ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1041:44 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1041                 expressionLogicalOperator: SyncBailHook;
                                                ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1042:26 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1042                 program: SyncBailHook;
                              ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1051:28 - error TS2314: Generic type 'AsyncSeriesWaterfallHook<T>' requires 1 type argument(s).

1051             beforeResolve: AsyncSeriesWaterfallHook;
                                ~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1052:27 - error TS2314: Generic type 'AsyncSeriesWaterfallHook<T>' requires 1 type argument(s).

1052             afterResolve: AsyncSeriesWaterfallHook;
                               ~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1053:33 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1053             contextModuleFiles: SyncWaterfallHook;
                                     ~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1054:27 - error TS2314: Generic type 'AsyncSeriesWaterfallHook<T>' requires 1 type argument(s).

1054             alternatives: AsyncSeriesWaterfallHook;
                               ~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1074:21 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1074             unseal: SyncHook;
                         ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1075:19 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1075             seal: SyncHook;
                       ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1077:40 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1077             optimizeDependenciesBasic: SyncBailHook<Module[]>;
                                            ~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1078:35 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1078             optimizeDependencies: SyncBailHook<Module[]>;
                                       ~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1079:43 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1079             optimizeDependenciesAdvanced: SyncBailHook<Module[]>;
                                               ~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1082:23 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1082             optimize: SyncHook;
                           ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1084:35 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1084             optimizeModulesBasic: SyncBailHook<Module[]>;
                                       ~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1085:30 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1085             optimizeModules: SyncBailHook<Module[]>;
                                  ~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1086:38 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1086             optimizeModulesAdvanced: SyncBailHook<Module[]>;
                                          ~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1094:27 - error TS2314: Generic type 'AsyncSeriesHook<T>' requires 1 type argument(s).

1094             optimizeTree: AsyncSeriesHook<Chunk[], Module[]>;
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1101:27 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1101             shouldRecord: SyncBailHook;
                               ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1120:25 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1120             beforeHash: SyncHook;
                             ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1121:24 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1121             afterHash: SyncHook;
                            ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1127:33 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1127             beforeModuleAssets: SyncHook;
                                     ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1128:40 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1128             shouldGenerateChunkAssets: SyncBailHook;
                                            ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1129:32 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1129             beforeChunkAssets: SyncHook;
                                    ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1134:31 - error TS2314: Generic type 'AsyncSeriesHook<T>' requires 1 type argument(s).

1134             additionalAssets: AsyncSeriesHook;
                                   ~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1140:33 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1140             needAdditionalSeal: SyncBailHook;
                                     ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1141:24 - error TS2314: Generic type 'AsyncSeriesHook<T>' requires 1 type argument(s).

1141             afterSeal: AsyncSeriesHook;
                            ~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1149:33 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1149             needAdditionalPass: SyncBailHook;
                                     ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1150:28 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1150             childCompiler: SyncHook;
                                ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1154:43 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1154             optimizeExtractedChunksBasic: SyncBailHook<Chunk[]>;
                                               ~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1155:38 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1155             optimizeExtractedChunks: SyncBailHook<Chunk[]>;
                                          ~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1156:46 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1156             optimizeExtractedChunksAdvanced: SyncBailHook<Chunk[]>;
                                                  ~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1169:27 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1169             jsonpScript?: SyncWaterfallHook<string, Chunk, string>;
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1170:22 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1170             require: SyncWaterfallHook<string, Chunk, string>;
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1171:32 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1171             requireExtensions: SyncWaterfallHook<string, Chunk, string>;
                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1172:28 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1172             requireEnsure: SyncWaterfallHook<string, Chunk, string>;
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1173:24 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1173             localVars: SyncWaterfallHook<string, Chunk, string>;
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1174:27 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1174             afterStartup: SyncWaterfallHook<string, Chunk, string>;
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1188:22 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1188             content: SyncWaterfallHook;
                          ~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1189:21 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1189             module: SyncWaterfallHook;
                         ~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1190:21 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1190             render: SyncWaterfallHook;
                         ~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1191:22 - error TS2314: Generic type 'SyncWaterfallHook<T>' requires 1 type argument(s).

1191             package: SyncWaterfallHook;
                          ~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1192:19 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1192             hash: SyncHook;
                       ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1279:25 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1279             shouldEmit: SyncBailHook<Compilation>;
                             ~~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1281:29 - error TS2314: Generic type 'AsyncSeriesHook<T>' requires 1 type argument(s).

1281             additionalPass: AsyncSeriesHook;
                                 ~~~~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1297:25 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1297             watchClose: SyncHook;
                             ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1298:26 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1298             environment: SyncHook;
                              ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1299:31 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1299             afterEnvironment: SyncHook;
                                   ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1302:26 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1302             entryOption: SyncBailHook;
                              ~~~~~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1322:25 - error TS2707: Generic type 'SyncHook<T, R>' requires between 1 and 2 type arguments.

1322             watchClose: SyncHook;
                             ~~~~~~~~

../../node_modules/@types/webpack/index.d.ts:1389:24 - error TS2314: Generic type 'SyncBailHook<T, R>' requires 2 type argument(s).

1389         _pluginCompat: SyncBailHook<compilation.Compilation>;
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

../../node_modules/@types/webpackbar/index.d.ts:8:10 - error TS2305: Module '"../../webpack/types"' has no exported member 'Plugin'.

8 import { Plugin, ProgressPlugin } from 'webpack';
sokra

comment created time in a month

issue commentwebpack/webpack

DefinePlugin with Persistent cache

I'm using webpack@5.0.0-beta.14 currently, we are doing things like:

const baseConfiguration = {
    // entry, devtool, module...
};

const stable = {
    ...baseConfiguration,
    output: {
        filename: '[name]-stable.[chunkhash].js',
    },
    plugins: [
        ...baseConfiguration.plugins,
        new DefinePlugin({
            foo: DefinePlugin.runtimeValue(() => 1),
            bar: DefinePlugin.runtimeValue(() => 1),
        }),
    ],
};

// First build initializes persistent cache
webpack(stable, () => {
    const insiders = {
        ...baseConfiguration,
        output: {
            filename: '[name]-insiders.[chunkhash].js',
        },
        plugins: [
            ...baseConfiguration.plugins,
            // new values
            new DefinePlugin({
                foo: DefinePlugin.runtimeValue(() => 2),
                bar: DefinePlugin.runtimeValue(() => 2),
            }),
        ],
    };

    webpack(insiders, () => {
        console.log('done');
    });
});

Comparing to build stable and insiders together at the same time, this can reduce build speed around 40% in webpack@5, so I'd not like DefinePlugin to break cache version and slow down build speed.

vankop

comment created time in a month

issue commentwebpack/webpack

DefinePlugin with Persistent cache

We're relying on an identical cache version to ensure performance between multiple builds with different DefinePlugin inputs.

In our build, we first build a stable version with several "feature values" injected via DefinePlugin, then have a second insiders build using different "feature values". Since the first build creates a persitent cache, the second build can be very fast.

I'm afraid that using different cache versions can break this and results in a much slower build, so it is better not to have DefinePlugin related to version.

vankop

comment created time in a month

issue commentwebpack/webpack

DefinePlugin with Persistent cache

From previous issues it is said DefinePlugin.runtimeValue can solve this problem?

vankop

comment created time in a month

issue commentwebpack/webpack

webpack 5 beta feedback

We found webpack 5's built-in typescript definitions are completely incompatible with @types/webpack, most of current community ecosystems are relying on @types/webpack and they all breaks after webpack is upgraded to 5.x

I don't know how to handle this problem, can I force typescript to look into @types/webpack instead of webpack/webpack.d.ts?

sokra

comment created time in a month

issue openedrozbo/hexo-neat

Wrong version specified for clean-css

In current package.json clean-css is required >4.2.3, however the latest clean-css version is 4.2.3, install fails for the reason that no version satisfied >4.2.3 specifier.

[2020-07-09 12:04:31] npm ERR! code ETARGET
[2020-07-09 12:04:31] npm ERR! notarget No matching version found for clean-css@>4.2.3.
[2020-07-09 12:04:31] npm ERR! notarget In most cases you or one of your dependencies are requesting
[2020-07-09 12:04:31] npm ERR! notarget a package version that doesn't exist.
[2020-07-09 12:04:31] npm ERR! notarget 
[2020-07-09 12:04:31] npm ERR! notarget It was specified as a dependency of 'hexo-neat'
[2020-07-09 12:04:31] npm ERR! notarget 

This should be fixed to >=4.2.3 or ~4.2.3

created time in a month

pull request commentitsmepetrov/classnames-loader

Support ES module exported class names

Is there anyone can review this? thanks

otakustay

comment created time in a month

delete branch baidu/san-website

delete branch : feature-i18n

delete time in a month

delete branch baidu/san-website

delete branch : hattle-doc-fix

delete time in a month

push eventbaidu/san-website

Jun Yang

commit sha 5b72a439523a2dc93311414834a7e43f1154ab33

translate: updateMode, parseComponentTemplate, aNode and aPack (#130) Co-authored-by: otakustay <otakustay@gmail.com>

view details

push time in a month

PR opened harttle/san-website

translate: fix translation
+8 -8

0 comment

3 changed files

pr created time in a month

create barnchbaidu/san-website

branch : hattle-doc-fix

created branch time in a month

issue commentumijs/dumi

bug: fails to work in yarn workspace

https://github.com/otakustay/issues

dumi分支

yarn
cd packages/dumi
dumi dev

Starting the development server...

✖ Webpack
  Compiled with some errors in 2.76s

 ERROR  Failed to compile with 22 errors                                                                                                              4:36:53 PM

These dependencies were not found:

* react in /Users/otakustay/Develop/test/dumi/node_modules/@umijs/bundler-webpack/lib/webpackHotDevClient/webpackHotDevClient.js, /Users/otakustay/Develop/test/dumi/node_modules/@umijs/bundler-webpack/lib/webpackHotDevClient/handlers.js and 19 others
* react-dom in /Users/otakustay/Develop/test/dumi/node_modules/@umijs/renderer-react/dist/index.js

To install them, you can run: npm install --save react react-dom
otakustay

comment created time in a month

create barnchotakustay/issues

branch : dumi

created branch time in a month

created repositoryotakustay/issues

created time in a month

issue commentotakustay/react-diff-view

有中文文档吗

评论看这个:https://codesandbox.io/s/nifty-herschel-3w9s8

Lcj-space

comment created time in a month

issue commentotakustay/react-diff-view

有中文文档吗

如果你想展开相同的代码,就必须有左边那份的源文件。因为在diff文本里是没有那些相同行的代码的,没有这个源文件自然就不知道能显示啥了

源文件还有很多其它用处,比如在代码高亮的时候,你传一个oldSource过去,因为有了每一行的上下文,高亮就会变精准(比如多行注释在只有一部分的时候可能就不被当注释),这个我在demo里没写,你可以加上感受下

Lcj-space

comment created time in a month

issue commentotakustay/react-diff-view

有中文文档吗

https://codesandbox.io/s/react-diff-view-with-code-expansion-hzqzj

你可以参考一下这个sandbox,我加了高亮和代码展开的功能。我不建议把原本diff的3行相同代码也给隐藏了,用户会失去看diff的上下文的,只提供展开功能就行了

Lcj-space

comment created time in a month

issue commentotakustay/react-diff-view

有中文文档吗

github这个就是你可以一个按钮展开(其实再收起也行)

这个功能可能比你想象的还复杂一些,正常的diff里最多只有上下3行的相同行,为了能完整地展开更多的行,你需要左边代码的源文件(加上diff算出右边代码),然后有一大堆的逻辑

这个逻辑我已经通过几个hook提供了,比如useSourceExpansion就是干这个的,但文档确实不完善

你真的需要这个展开源码的功能的话,明天抽时间写个demo给你……

其实你要完整实现github的效果,远不止这些:

  1. 代码高亮
  2. 展开相同行
  3. 行可以选中,甚至可以选择多行,并会在URL中表现出来
  4. 代码上有引用跳转,点个函数名可以跳到定义
  5. 能添加评论

这些功能基于这个组件都能实现,就是要在外层加逻辑(各种变着法的折腾hunks数组)。我们内部使用就有全部这些能力,另外还有在行号前面显示单元测试覆盖之类的……

Lcj-space

comment created time in a month

issue commentotakustay/react-diff-view

有中文文档吗

想了一想,没这么简单,如果把normal的行删掉,会涉及到oldStartoldLinesnewStartnewLines变化,也有可能2个变化的行中间夹着一些相同的行,这个时候一个hunk就要拆成2个了

这个逻辑能实现,但并不简单,老实说没有相同行并不好看……你实在要的话我明天试试能不能写出来

Lcj-space

comment created time in a month

issue commentotakustay/react-diff-view

有中文文档吗

一般git的diff会生成3行相同的代码,一个办法是生成diff的时候用git diff --unified=0把相同行干掉

第二个方案是在parse以后,遍历每个hunk.changes然后把里面type === 'normal'change删掉,就不会有相同行了

如果你不仅仅是想要他们消失,而是要实现用户点个啥按钮可以收起展开,那你得按照第二个方案,生成一个删了normal change的,一个没删的,来回替换

Lcj-space

comment created time in a month

issue commentotakustay/react-diff-view

有中文文档吗

这个组件只负责展示一个文件的代码diff的部分,并不是一个完事的github diff功能的实现

文件树你得自己实现一把,比如用antd的Tree组件,或者用react-infinite-tree做个性能更好的

Lcj-space

comment created time in a month

push eventecomfe/react-suspense-boundary

Yuxuan Huo

commit sha 5581935e33c20916db76aa1bd106fcba232b7716

fix: withBoundary hoc type improve (#8)

view details

push time in a month

startedpshihn/rough-notation

started time in 2 months

created tagecomfe/react-suspense-boundary

tagv1.1.2

A boundary component working with suspense and error

created time in 2 months

push eventecomfe/react-suspense-boundary

otakustay

commit sha e9c0bf9dbf51da6a5ee5b26dbd6605a958a16557

fix: use undefined to check query data

view details

otakustay

commit sha 38961fe7d108501a4beb5d318f4d11c65c7af8f8

1.1.2

view details

push time in 2 months

push eventecomfe/react-suspense-boundary

LeuisKen

commit sha b696f6bba5958db3e8a67149cf3d280a146475eb

fix: error throwed when query.data === null

view details

push time in 2 months

PR merged ecomfe/react-suspense-boundary

fix: error throwed when query.data === null

Case like following will cause error.

'Unexpected suspense state without data, pending and error';

const getLocalNote: () => Promise<string | null> = () => AsyncStorage.getItem('localNote');
const [result] = useResource(getLocalNote, undefined);
+1 -1

0 comment

1 changed file

LeuisKen

pr closed time in 2 months

created tagecomfe/eslint-config

tagv4.0.0

eslint shareable config for efe

created time in 2 months

push eventecomfe/eslint-config

otakustay

commit sha b370ccaf744c005ac21b422c94107418b1290913

4.0.0

view details

push time in 2 months

push eventecomfe/eslint-config

Chen Zhouji

commit sha cafdf18228584350559268ff88b71992b954dbf8

feat: support typescript-eslint v3.0 rules changes (#10) BREAKING CHANGE: upgraded typescript-eslint to 3.x Co-authored-by: chenzhouji <chenzhouji@baidu.com>

view details

push time in 2 months

issue commentotakustay/react-diff-view

hightlight=true,css in js 解析问题

@dancerphil 这个事情是不是refractor的BUG?

lunalusy

comment created time in 2 months

issue commentbaidubce/bce-sdk-js

`BosClient`升级计划

@otakustay 麻烦贴下 as any 大法的片段 我也继续hack

也没啥代码啊,直接const client = new BosClient(config) as any了哈哈

mudio

comment created time in 2 months

issue commentbaidubce/bce-sdk-js

`BosClient`升级计划

我给个建议,不完善的types不如干脆别发布types,覆盖它的类型比没有类型还难受

所以我用了as any大法

mudio

comment created time in 2 months

create barnchecomfe/react-hooks

branch : fix

created branch time in 2 months

issue closedecomfe/react-hooks

useArray的remove方法无法用于非基础类型

const [items, {remove}] = useArray(dataSource); // dataSource为对象数组
remove(someItem);

以上代码会失败,因为在immer的作用下都是Proxy,没办法引用判断相等

closed time in 2 months

otakustay

issue commentecomfe/react-hooks

useArray的remove方法无法用于非基础类型

误判,非Bug

otakustay

comment created time in 2 months

issue openedecomfe/react-hooks

useArray的remove方法无法用于非基础类型

const [items, {remove}] = useArray(dataSource); // dataSource为对象数组
remove(someItem);

以上代码会失败,因为在immer的作用下都是Proxy,没办法引用判断相等

created time in 2 months

issue openedecomfe/react-hooks

useInputValue与TextArea不兼容

const comment = useInputValue('');
<Input.TextArea {...comment} />

以上代码会有类型问题

created time in 2 months

push eventecomfe/react-track

Chen Zhouji

commit sha 8241f76fc246d9d16cf3ba3b57603514b56d7008

fix: path字段加上basename (#29)

view details

push time in 2 months

PR merged ecomfe/react-track

fix: path字段加上basename
+12 -3

0 comment

2 changed files

ice-zjchen

pr closed time in 2 months

push eventecomfe/react-suspense-boundary

otakustay

commit sha 0ab8e39d218a77545413d6de042a1afd80fcff09

fix: refresh should be async

view details

otakustay

commit sha 35ba4fbb8697e4a2026d0f11ac841e46fd5f469d

1.1.1

view details

push time in 2 months

created tagecomfe/react-suspense-boundary

tagv1.1.1

A boundary component working with suspense and error

created time in 2 months

created tagecomfe/react-track

tagv1.5.0

A declarative, component based solution to track page views and user events with react & react-router

created time in 2 months

created tagecomfe/react-track

tagv1.6.0

A declarative, component based solution to track page views and user events with react & react-router

created time in 2 months

push eventecomfe/react-track

otakustay

commit sha fb3d5884bd7057b2b678e2ac6ec8ed07e27a1686

1.6.0

view details

push time in 2 months

PR closed ecomfe/react-track

Bump acorn from 5.7.3 to 5.7.4 dependencies

Bumps acorn from 5.7.3 to 5.7.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/acornjs/acorn/commit/6370e90067552022710190319cbbbd8c43001957"><code>6370e90</code></a> Mark version 5.7.4</li> <li><a href="https://github.com/acornjs/acorn/commit/fbc15b1344f6dfb992f67b4bbf1357436247c8a0"><code>fbc15b1</code></a> More rigorously check surrogate pairs in regexp validator</li> <li>See full diff in <a href="https://github.com/acornjs/acorn/compare/5.7.3...5.7.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

PR closed ecomfe/react-track

增加百度统计标签功能
+86 -1

0 comment

5 changed files

Xooone47

pr closed time in 2 months

push eventecomfe/react-track

Chen Zhouji

commit sha 7b8a026ba4c653757b29ffec1c6b1510dcea22a8

feat: add a collect `basename` #27 (#28) Co-authored-by: chenzhouji <chenzhouji@baidu.com>

view details

push time in 2 months

issue commentotakustay/react-diff-view

I wanted to use the lazy loading, Can I achieve this ?

I have investigated your sandbox, however I really need your 100K diff to exactly reproduce this issue in order to give you an accurate solution

Neeraj-swarnkar

comment created time in 2 months

pull request commentecomfe/react-track

pref: collect增加info参数, info.href字段包含hisotry中basename #27

我觉得这个是很妥的,直接有一个basename collect就够了

ice-zjchen

comment created time in 2 months

delete branch ecomfe/react-hooks

delete branch : request-doc

delete time in 2 months

push eventecomfe/react-hooks

Gray Zhang

commit sha 1e285e20800c4f991e7f204efc5be3d8ee9611d2

docs(request): add recommendation on conditional request (#38)

view details

push time in 2 months

more