profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/orta/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Orta Therox orta Microsoft on TypeScript Huddersfield / NYC / Dublin https://orta.io I help people build dev ecosystems. Current: TypeScript. Contributed to: Shiki, Shiki Twoslash, Danger, CocoaPods, Jest, GraphQL, RxSwift & Svelte.

danger/danger 4581

🚫 Stop saying "you forgot to …" in code review (in Ruby)

BendingSpoons/tempura-swift 636

A holistic approach to iOS development, inspired by Redux and MVVM

ashfurrow/Nimble-Snapshots 303

Nimble matchers for FBSnapshotTestCase.

dblock/ARTiledImageView 225

Display, pan and deep zoom with tiled images on iOS.

ashfurrow/second_curtain 128

Upload failing iOS snapshot tests cases to S3

dblock/ios-snapshot-test-case-expecta 95

Expecta matchers for ios-snapshot-test-case.

ashfurrow/Forgeries 83

Helper methods for testing iOS code

bamlab/dev-standards 78

https://bamtech.gitbooks.io/dev-standards/

alloy/AxeMode 62

:monkey::wrench: for Xcode

pull request commentmicrosoft/TypeScript

ES private field check

IF you do a fresh rebase, this should green - I fixed main earlier 👋🏻

acutmore

comment created time in 8 hours

pull request commentDefinitelyTyped/DefinitelyTyped

Add framework agnostic MDX types

I think my gut says that here in DT probably a better call. With a bit of import trickery that could also mean JS users get the changes without having to add the dependency via ATA

remcohaszing

comment created time in 8 hours

Pull request review commentDefinitelyTyped/DefinitelyTyped

Add framework agnostic MDX types

+{+    "compilerOptions": {+        "module": "commonjs",+        "lib": [+            "es6"+        ],+        "jsx": "react-jsx",+        "noImplicitAny": true,+        "noImplicitThis": true,+        "strictNullChecks": true,+        "strictFunctionTypes": true,+        "baseUrl": "../",+        "typeRoots": [+            "../"+        ],+        "types": [],+        "noEmit": true,+        "forceConsistentCasingInFileNames": true+    },+    "files": [+        "index.d.ts",+        "md.d.ts",

md.d.ts won't get picked up by the TypeScript file resolver unless it's referenced somewhere, other files means someone might import it via module/filename in their code

remcohaszing

comment created time in 8 hours

PullRequestReviewEvent

push eventorta/TypeScript

Orta

commit sha aa99b9727a54424ddce491089e6224a8217ff8ec

Revert code change

view details

push time in 12 hours

push eventorta/TypeScript

Orta

commit sha 1652936711963143fd1c0cd0121abd3f22743b54

Update v1 lockfile

view details

push time in 12 hours

push eventorta/TypeScript

Orta

commit sha 5b6f39b8731348a6042367ebcc119c7860d1e906

Lock to v2

view details

push time in 13 hours

PR opened microsoft/TypeScript

Update pr_owners.txt for the TypeScript repo bot

Updates the team

+2 -1

0 comment

1 changed file

pr created time in 13 hours

create barnchmicrosoft/TypeScript

branch : orta-patch-3

created branch time in 13 hours

create barnchmicrosoft/TypeScript

branch : orta-patch-2

created branch time in 13 hours

pull request commentmicrosoft/TypeScript

Fix main by using '.default' on the new ms release

Hrm, looks like it ships ?. JS which isn't as backwards compatible as our CI - maybe I should just lock it to v2 instead

orta

comment created time in 13 hours

pull request commentmicrosoft/TypeScript

Fix main by using '.default' on the new ms release

should unblock https://github.com/microsoft/TypeScript/pull/45905

orta

comment created time in 13 hours

PR opened microsoft/TypeScript

Fix main by using '.default' on the new ms release

Fixes main - because we update the lockfile, we now use ms v3 which is re-written in TypeScript but has a different export style.

+1 -2

0 comment

2 changed files

pr created time in 13 hours

create barnchorta/TypeScript

branch : main_fix

created branch time in 13 hours

issue commentmicrosoft/TypeScript

Use the width of a type to add newlines in type assignment error messages

Yeah, exactly, I don't disagree - just pining for a better way to visually distinguish between type and message e.g.

orta

comment created time in 14 hours

issue commentmicrosoft/TypeScript

Use the width of a type to add newlines in type assignment error messages

Sure, first read the READMEs/contributing guides - I think all of the changes will probably live inside reportRelationError(message: DiagnosticMessage | undefined, source: Type, target: Type in checker.ts - somewhere around lines 17790.

sourceType and targetType are the strings, you need to use the length of to determine what to do

orta

comment created time in 16 hours

push eventorta/TypeScript-Website

Orta

commit sha 3202c678f2b6cc8e436e43fd45c30eeb1c9c6cb4

Fix ATA tests

view details

push time in 16 hours

push eventorta/TypeScript-Website

Orta

commit sha 8467d4e9191b3b62ac4e7dace61b1c786bdb02bd

Release polish

view details

push time in 16 hours

issue commentElderjs/elderjs

[Seeking Help] Adding Typescript Support

Re: esbuild background process - you can use esbuild/swc via the JavaScript API, so when you see 'routes.ts' instead of 'routes.js', you can do:

const esbuild = require('esbuild')
const jsversion = esbuild.transformSync(fs.readFileSync("routes.js"), { loader: 'ts' })

Then it can live in your existing build pipeline which has to do something like that for svelte files anyway

nickreese

comment created time in 16 hours

push eventorta/TypeScript-Website

Laurence Rowe

commit sha c0593d77e232f5be6abb27b4b294e16b2ccfd979

Link to Tuple Types section of Object Types page A search for 'tuple' on the website has the deprecated handbook basic types page as the only documentation result. That deprecated page links back to this one so there was is no way to find the current Tuple Types documentation in Object Types from the website. Unfortunately a search for 'tuple types' shows no documentation results. Perhaps documentation sections (rather than just pages) could be indexed in Algolia.

view details

Orta Therox

commit sha 613e48364f5d3368603f94e2bdca005d4555556e

Apply suggestions from code review

view details

Orta

commit sha 4c8db095993f75e26c375f3e5f8579ac062b52ee

Typo fix

view details

Orta Therox

commit sha 840779ff9070672a4b5e7e8dbab66d484c758d37

Merge pull request #1996 from lrowe/patch-1 Link to Tuple Types section of Object Types page

view details

immeëmosol

commit sha 1d3e66779bc027d6117ec0bda63c65cd2e7dc77f

Update target.md

view details

immeëmosol

commit sha 11399bf62aa17457391523bd3371f215886515b1

Update lib.md

view details

Orta Therox

commit sha b576400b61bfbbb2bc6ee3174270e0479959b582

Merge pull request #1999 from imme-emosol/patch-2 Update lib.md

view details

Orta Therox

commit sha ca2bcbdf8ae73262a6b1b71a52a325c1cf64a132

Merge pull request #1998 from imme-emosol/patch-1 Update target.md

view details

Orta Therox

commit sha 50a8621b544297f7808bbd55561c636fd132bcda

Set the error beind to 0 be invisible

view details

Orta Therox

commit sha 5d78db457cc084f6863f12169d0ee20bb5ec5b6c

Merge branch 'v2' of https://github.com/microsoft/TypeScript-website into v2

view details

Gabriel Goller

commit sha 336d4d89e74417e3ab273246cf637217d1faa92e

Fixed typo in TypeScript 4.2.md

view details

谭九鼎

commit sha 2e5161fe2e3e616da5dfb3e719c51dd920ee0abb

Update links: remove en-us from MS Docs url

view details

Orta Therox

commit sha 5d56c59eb5ae1a702ac791e3a0d235d159c79bce

Merge pull request #2002 from kaffarell/patch-1 Fixed typo in TypeScript 4.2.md

view details

Orta Therox

commit sha 3b74925693ac63fbf77988e48297b2ed9e099c5e

Merge pull request #2003 from imba-tjd/v2 Update links: remove en-us from MS Docs url

view details

Orta

commit sha bb5ca5a8218cd927b9d01d21ea61dfc619906d84

Prepare docs for 4.4 final release

view details

Orta

commit sha 91e90aa63ce270da7b9105c4d6634d1729b4e49d

Bring back scheduler

view details

Orta

commit sha 9ab34f7b0197c11fc99a517bf6c2e71070e382ff

Update twoslash snapshots for new TS version

view details

Orta Therox

commit sha 3798d092a15342fae6ee2e497ae08f4826a96c4f

Merge pull request #2004 from microsoft/_44_final Prepare docs for 4.4 final release

view details

Pouya Kary ✨

commit sha e752e598debc0859fb396105267d782473df91f6

better alignment for the popover

view details

Orta Therox

commit sha 363a1dbcb6c3ed787b3e9b02cbd0cdd9d6f97d1a

Merge pull request #2005 from pouyakary/pouya/twoslash-shiki-popover-fixie better alignment for the popover

view details

push time in 17 hours

pull request commentmicrosoft/TypeScript

Adds more Intl.ResolvedDateTimeFormatOptions, and hooks up Intl for ES2021

https://github.com/vercel/ms just got updated to typescript which is what is causing the reds

orta

comment created time in 17 hours

push eventorta/TypeScript

Orta

commit sha c2db6bf276ca0fab65a367553fe43ae0f5cd7535

Fix tests

view details

push time in 18 hours

push eventorta/TypeScript

Orta

commit sha 6d680ffe7e71c7efc8c5cc0924ff5a74c8d0eb78

Fix tests

view details

push time in 19 hours

push eventorta/TypeScript

Orta

commit sha c3734b7388ce3b450e7671288ac86a9e95b8aded

Adds more ResolvedDateTimeFormatOptions to the Intl APIs

view details

push time in 19 hours

PR opened microsoft/TypeScript

Adds more Intl.ResolvedDateTimeFormatOptions, and hooks up Intl for ES2021
  1. Looks like if you were on target: es2021 the file es2021.intl wasn't added to your globals, so some of #45647 wasn't applied
  2. I added the properties raised in #45420

fixes #45420

+193 -4

0 comment

13 changed files

pr created time in 20 hours

create barnchorta/TypeScript

branch : 2021_intl

created branch time in 20 hours

issue commentmicrosoft/TypeScript

Intl.ResolvedDateTimeFormatOptions is missing properties

Yep, I agree 👍🏻

BPScott

comment created time in 20 hours

IssuesEvent

issue openedmicrosoft/TypeScript

Use the width of a type to add newlines in type assignment error messages

Today we ship a one-type-fits-all style for printing type is not assignable to type messages. We'd like to improve this in a pretty simple manner: by occasionally adding newlines. For example with this arbitrary comparison:

let a = { b: { c: { e: { f: 123 } } } };
let b = { b: { c: { e: { f: "123" } } } };
a = b;

Looks like this today:

src/vendor/ata/index.ts(12,1): error TS2322: Type '{ b: { c: { e: { f: string; }; }; }; }' is not assignable to type '{ b: { c: { e: { f: number; }; }; }; }'.
The types of 'b.c.e.f' are incompatible between these types.
    Type 'string' is not assignable to type 'number'.

I propose that because both of the printed types are longer than 20-30 chars, then we switch to:

src/vendor/ata/index.ts(12,1): error TS2322: Type: 
{ b: { c: { e: { f: string; }; }; }; }

is not assignable to type:
{ b: { c: { e: { f: number; }; }; }; }

The types of 'b.c.e.f' are incompatible between these types.
    Type 'string' is not assignable to type 'number'.

Key details

  • Strip the quotes around the type
  • Add colons and newlines if the type is over a certain size. Let's call it 30 characters for now, and make it easy to change and we can experiment at the final stages of review.

Some Examples

No changes

let a = 123
let b = "abc"
a = b
  • Before: src/index.ts(21,1): error TS2322: Type 'string' is not assignable to type 'number'.
  • After: src/index.ts(21,1): error TS2322: Type 'string' is not assignable to type 'number'.

No change! (Though a part of me does really want to drop the quotes for primitives)

window = {}
Type '{}' is not assignable to type 'Window & typeof globalThis'.
  Type '{}' is missing the following properties from type 'Window': clientInformation, closed, customElements, devicePixelRatio, and 189 more. (2322)

No change! {} and Window & typeof globalThis are too small.

Changing one

window = addEventListener
src/index.ts(1,1): error TS2322: Type '{ <K extends keyof WindowEventMap>(type: K, listener: (this: Window, ev: WindowEventMap[K]) => any, options?: boolean | AddEventListenerOptions | undefined): void; (type: string, listener: EventListenerOrEventListenerObject, options?: boolean | ... 1 more ... | undefined): void; }' is not assignable to type 'Window & typeof globalThis'.
   Type '{ <K extends keyof WindowEventMap>(type: K, listener: (this: Window, ev: WindowEventMap[K]) => any, options?: boolean | AddEventListenerOptions | undefined): void; (type: string, listener: EventListenerOrEventListenerObject, options?: boolean | ... 1 more ... | undefined): void; }' is missing the following properties from type 'Window': HTMLDocument, closed, customElements, devicePixelRatio, and 187 more.
src/vendor/ata/index.ts(12,1): error TS2322: Type: 
{ <K extends keyof WindowEventMap>(type: K, listener: (this: Window, ev: WindowEventMap[K]) => any, options?: boolean | AddEventListenerOptions | undefined): void; (type: string, listener: EventListenerOrEventListenerObject, options?: boolean | ... 1 more ... | undefined): void; }

is not assignable to type:
Window & typeof globalThis

  Type '{ <K extends keyof WindowEventMap>(type: K, listener: (this: Window, ev: WindowEventMap[K]) => any, options?: boolean | AddEventListenerOptions | undefined): void; (type: string, listener: EventListenerOrEventListenerObject, options?: boolean | ... 1 more ... | undefined): void; }' is missing the following properties from type 'Window': HTMLDocument, closed, customElements, devicePixelRatio, and 187 more.

Changing both

Animation = AnalyserNode
index.ts(12,1) Type '{ new (context: BaseAudioContext, options?: AnalyserOptions | undefined): AnalyserNode; prototype: AnalyserNode; }' is not assignable to type '{ new (effect?: AnimationEffect | null | undefined, timeline?: AnimationTimeline | null | undefined): Animation; prototype: Animation; }'.
  Types of property 'prototype' are incompatible.
    Type 'AnalyserNode' is missing the following properties from type 'Animation': currentTime, effect, finished, id, and 18 more.
index.ts(12,1) Type:
{ new (context: BaseAudioContext, options?: AnalyserOptions | undefined): AnalyserNode; prototype: AnalyserNode; }

is not assignable to type:
{ new (effect?: AnimationEffect | null | undefined, timeline?: AnimationTimeline | null | undefined): Animation; prototype: Animation; }

  Types of property 'prototype' are incompatible.
    Type 'AnalyserNode' is missing the following properties from type 'Animation': currentTime, effect, finished, id, and 18 more.

created time in a day

push eventmicrosoft/TypeScript

Orta Therox

commit sha b2f9432c4064c68862f992b750d7b40c64f194b4

Support resolving `@typescript/[lib]` in node modules (#45771) * Support resolving @typescript/x for libs * Baselines * Tightens up the PR * Fix the build * Add cache * Better naming * Fixes the lookup path

view details

push time in a day