profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/onyb/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Anirudha Bose onyb @brave Paris https://anirudha.co I work on magic internet money.

brave/brave-browser 10571

Next generation Brave browser for Android, Linux, macOS, Windows.

btcsuite/btcd 4429

An alternative full node bitcoin implementation written in Go (golang)

brave/brave-core 1367

Core engine for the Brave browser for Android, Linux, macOS, Windows. For issues https://github.com/brave/brave-browser/issues

LedgerHQ/satstack 99

Bitcoin full node with Ledger Live

brave/ethereum-remote-client 38

Integrated customization of MetaMask for use in Brave

esowc/ecPoint-Calibrate 17

Interactive GUI (developed in Python) for calibration and conditional verification of numerical weather prediction model outputs.

brave/dnode 1

turtles all the way down rpc

PullRequestReviewEvent

Pull request review commentbrave/brave-core

Implemented Router Paths in the Crypto Wallet

 function Container (props: Props) {         selectedButton={view}         onSubmit={navigateTo}       /> */}-      <WalletSubViewLayout>-        {renderWallet}-        {/* {view === 'crypto' ? (-          renderWallet-        ) : (-          <div style={{ flex: 1, alignItems: 'center', justifyContent: 'center' }}>-            <h2>{view} view</h2>-          </div>-        )} */}-      </WalletSubViewLayout>+      <Switch>+        <WalletSubViewLayout>+          <Route path={WalletRoutes.Restore} exact={true}>+            {isWalletLocked &&+              <OnboardingRestore+                onRestore={restoreWallet}+                toggleShowRestore={onToggleShowRestore}+                hasRestoreError={restorError}+              />+            }+          </Route>+          <Route path={WalletRoutes.Onboarding} exact={true}>+            <Onboarding+              recoveryPhrase={recoveryPhrase}+              onPasswordProvided={passwordProvided}+              onSubmit={completeWalletSetup}+              onShowRestore={onToggleShowRestore}+              // Pass a boolean if either wallet is detected+              braveLegacyWalletDetected={false}+              metaMaskWalletDetected={false}+              // Pass a boolean if it failed to import+              hasImportError={false}+              onImportBraveLegacy={onImportBraveLegacy}+              onImportMetaMask={onImportMetaMask}+            />+          </Route>+          <Route path={WalletRoutes.Unlock} exact={true}>+            {isWalletLocked &&+              <LockScreen+                onSubmit={unlockWallet}+                disabled={inputValue === ''}+                onPasswordChanged={handlePasswordChanged}+                hasPasswordError={hasIncorrectPassword}+                onShowRestore={onToggleShowRestore}+              />+            }+          </Route>+          <Route path={WalletRoutes.Backup} exact={true}>+            <BackupWallet+              isOnboarding={false}+              onCancel={onHideBackup}+              onSubmit={onBackupWallet}+              recoveryPhrase={recoveryPhrase}+            />+          </Route>+          <Route path={WalletRoutes.CryptoPage}>+            {(isWalletCreated && !setupStillInProgress) && !isWalletLocked && walletLocation !== WalletRoutes.Backup &&

Why is the walletLocation !== WalletRoutes.Backup required here? Similarly for !isWalletLocked. I thought it was handled by the other <Route ... > blocks, is it not?

Douglashdaniel

comment created time in a day

Pull request review commentbrave/brave-core

Implemented Router Paths in the Crypto Wallet

 const CryptoView = (props: Props) => {     onToggleAddModal()   } +  const selectAsset = (asset: TokenInfo) => {+    if (asset) {+      history.push(`${WalletRoutes.Portfolio}/${asset.symbol}`)+    } else {+      onSelectAsset(asset)+      history.push(WalletRoutes.Portfolio)+    }+  }++  const goBack = () => {+    setSelectedAccount(undefined)+    history.push(WalletRoutes.Accounts)+    setHideNav(false)+  }++  const onSelectAccount = (account: WalletAccountType) => {

account may be undefined, so type should reflect this I think.

Douglashdaniel

comment created time in a day

Pull request review commentbrave/brave-core

Implemented Router Paths in the Crypto Wallet

 function Container (props: Props) {     // Logic Here to add a custom Token   } -  const renderWallet = React.useMemo(() => {+  React.useEffect(() => {+    // Creates a list of Accepted Portfolio Routes+    const acceptedPortfolioRoutes = userVisibleTokensInfo.map((token) => {+      return `${WalletRoutes.Portfolio}/${token.symbol}`+    })+    // Creates a list of Accepted Account Routes+    const acceptedAccountRoutes = accounts.map((account) => {+      return `${WalletRoutes.Accounts}/${account.address}`+    })     if (!hasInitialized) {-      return null-    }-    if (showIsRestoring) {-      return (-        <OnboardingRestore-          onRestore={restoreWallet}-          toggleShowRestore={onToggleShowRestore}-          hasRestoreError={restorError}-        />-      )+      return     }-    if (!isWalletCreated || setupStillInProgress) {-      return (-        <Onboarding-          recoveryPhrase={recoveryPhrase}-          onPasswordProvided={passwordProvided}-          onSubmit={completeWalletSetup}-          onShowRestore={onToggleShowRestore}-          // Pass a boolean if either wallet is detected-          braveLegacyWalletDetected={false}-          metaMaskWalletDetected={false}-          // Pass a boolean if it failed to import-          hasImportError={false}-          onImportBraveLegacy={onImportBraveLegacy}-          onImportMetaMask={onImportMetaMask}-        />-      )-    } else {-      return (-        <>-          {isWalletLocked ? (-            <LockScreen-              onSubmit={unlockWallet}-              disabled={inputValue === ''}-              onPasswordChanged={handlePasswordChanged}-              hasPasswordError={hasIncorrectPassword}-              onShowRestore={onToggleShowRestore}-            />-          ) : (-            <>-              {showRecoveryPhrase ? (-                <BackupWallet-                  isOnboarding={false}-                  onCancel={onHideBackup}-                  onSubmit={onBackupWallet}-                  recoveryPhrase={recoveryPhrase}-                />-              ) : (-                <CryptoView-                  onLockWallet={lockWallet}-                  needsBackup={!isWalletBackedUp}-                  onShowBackup={onShowBackup}-                  accounts={accounts}-                  networkList={networkList}-                  onChangeTimeline={onChangeTimeline}-                  onSelectAsset={onSelectAsset}-                  portfolioBalance={fullPortfolioBalance}-                  selectedAsset={selectedAsset}-                  selectedUSDAssetPrice={selectedUSDAssetPrice}-                  selectedBTCAssetPrice={selectedBTCAssetPrice}-                  selectedAssetPriceHistory={formatedPriceHistory}-                  portfolioPriceHistory={portfolioPriceHistory}-                  selectedTimeline={selectedTimeline}-                  selectedPortfolioTimeline={selectedPortfolioTimeline}-                  transactions={transactions}-                  userAssetList={userAssetList}-                  fullAssetList={fullTokenList}-                  onConnectHardwareWallet={onConnectHardwareWallet}-                  onAddHardwareAccounts={onAddHardwareAccounts}-                  getBalance={getBalance}-                  onCreateAccount={onCreateAccount}-                  onImportAccount={onImportAccount}-                  isLoading={isFetchingPriceHistory}-                  showAddModal={showAddModal}-                  onToggleAddModal={onToggleAddModal}-                  onUpdateAccountName={onUpdateAccountName}-                  onUpdateVisibleTokens={onUpdateVisibleTokens}-                  fetchFullTokenList={fetchFullTokenList}-                  userWatchList={userVisibleTokens}-                  selectedNetwork={selectedNetwork}-                  onSelectNetwork={onSelectNetwork}-                  isFetchingPortfolioPriceHistory={isFetchingPortfolioPriceHistory}-                  onRemoveAccount={onRemoveAccount}-                  privateKey={privateKey ?? ''}-                  onDoneViewingPrivateKey={onDoneViewingPrivateKey}-                  onViewPrivateKey={onViewPrivateKey}-                  onImportAccountFromJson={onImportAccountFromJson}-                  onSetImportError={onSetImportError}-                  hasImportError={importError}-                  onAddCustomToken={onAddCustomToken}-                  transactionSpotPrices={transactionSpotPrices}-                  userVisibleTokensInfo={userVisibleTokensInfo}-                />-              )}-            </>-          )}-        </>-      )+    // If wallet is not yet created will Route to Onboarding+    if ((!isWalletCreated || setupStillInProgress) && walletLocation !== WalletRoutes.Restore) {+      history.push(WalletRoutes.Onboarding)+      // If wallet is created will Route to login+    } else if (isWalletLocked && walletLocation !== WalletRoutes.Restore) {+      history.push(WalletRoutes.Unlock)+      // Allowed Private Routes if a wallet is unlocked else will redirect back to Portfolio+    } else if (+      !isWalletLocked &&+      hasInitialized &&+      walletLocation !== WalletRoutes.Backup &&+      walletLocation !== WalletRoutes.Accounts &&+      acceptedAccountRoutes.length !== 0 &&+      !acceptedAccountRoutes.includes(walletLocation) &&+      walletLocation !== WalletRoutes.Portfolio &&+      acceptedPortfolioRoutes.length !== 0 &&+      !acceptedPortfolioRoutes.includes(walletLocation)+    ) {+      history.push(WalletRoutes.Portfolio)

I feel this is hard to understand, and we might forget to update this block as newer routes are introduced. Is there a way to rewrite this in a better way?

I'm thinking about it too, but if we don't find a good way now, we can deal with it later on.

Douglashdaniel

comment created time in a day

PullRequestReviewEvent

Pull request review commentbrave/brave-core

Implemented Router Paths in the Crypto Wallet

 const CryptoView = (props: Props) => {     onToggleAddModal()   } +  const selectAsset = (asset: TokenInfo) => {+    if (asset) {+      history.push(`${WalletRoutes.Portfolio}/${asset.symbol}`)+    } else {+      onSelectAsset(asset)+      history.push(WalletRoutes.Portfolio)+    }+  }

If asset can be null or undefined, shouldn't this be reflected in the type in the function arguments?

Douglashdaniel

comment created time in a day

Pull request review commentbrave/brave-core

Implemented Router Paths in the Crypto Wallet

 type Props = { }  function Container (props: Props) {+  let history = useHistory()+  const walletLocation = useLocation().pathname

Minor style nit: const { pathname: walletLocation } = useLocation().

Please ignore if you don't prefer this syntax. :)

Douglashdaniel

comment created time in a day

PullRequestReviewEvent

Pull request review commentbrave/brave-core

Implemented Router Paths in the Crypto Wallet

 export enum WalletOnboardingSteps {   OnboardingImportMetaMask = 3,   OnboardingImportBraveLegacy = 4 }++export enum WalletRoutes {+  Unlock = '/crypto/unlock',+  Onboarding = '/crypto/onboarding',+  Restore = '/crypto/restore-wallet',+  Portfolio = '/crypto/portfolio',+  PortfolioSub = '/crypto/portfolio/:id?',+  Accounts = '/crypto/accounts',+  AccountsSub = '/crypto/accounts/:id?',+  Backup = '/crypto/backup-wallet',+  CryptoPage = '/crypto/:category/:id?'+}

It seems all routes have the /crypto/ prefix, which makes it superfluous. Is there any case where the prefix is something else? If not, why not drop it altogether and have routes like /unlock, /onboarding, etc, since there's already the global /wallet prefix?

Douglashdaniel

comment created time in a day

PullRequestReviewEvent

PR opened brave/brave-core

Reviewers
feat(wallet): add asset icons in wallet UI

This PR brings ERC-20 token metadata and logos to the wallet. We use @metamask/contract-metadata for this purpose to maintain parity with ethereum-remote-client. In future, this information may be maintained by us in brave-core.

⚠️ Resource IDs have been adjusted to account for the new logos being dynamically imported. See browser/resources/resource_ids.

⚠️ One difference in swap assets between ethereum-remote-client and native wallet is that we're using the same list for both Send as well as Swap. Instead of maintaining two separate lists, we'll display an appropriate warning if 0x has no liquidity for the chosen asset.

Resolves https://github.com/brave/brave-browser/issues/17645.

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have requested one
  • [x] There is a ticket for my issue
  • [x] Used Github auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [z] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [z] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [x] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Demo

https://user-images.githubusercontent.com/3684187/133795779-aa93901f-1bf8-4c8c-9ec3-98b33bdc883b.mov

+75 -247

0 comment

5 changed files

pr created time in 4 days

create barnchbrave/brave-core

branch : f/wallet/assets

created branch time in 4 days

push eventbrave/brave-core

Anirudha Bose

commit sha 340cc182f8dffe9b514eb5dca64749f54015fecb

feat(wallet): use Fuse.js for fuzzy-search in select-assets list

view details

Anirudha Bose

commit sha b22106ddace4871d5a4a5f29c8d9f8b4b3e4ba42

Merge pull request #10123 from brave/f/wallet/fuse feat(wallet): use Fuse.js for fuzzy-search in select-assets list

view details

push time in 5 days

delete branch brave/brave-core

delete branch : f/wallet/fuse

delete time in 5 days

issue closedbrave/brave-browser

Add fuzzy-search to SelectAsset list

The current way of searching through assets list in the wallet works fine, but has limitations when the list gets long or the users' search terms are approximate (ex, etherium vs ethereum). Use fuse.js instead.

closed time in 5 days

onyb

PR merged brave/brave-core

Reviewers
feat(wallet): use Fuse.js for fuzzy-search in select-assets list feature/wallet

Allow fuzzy search in assets list search bar, making it convenient when the number of assets us too large. Also added a small optimisation to prevent the filterAssetList callback from being recreated on every render.

Resolves https://github.com/brave/brave-browser/issues/18162.

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have requested one
  • [x] There is a ticket for my issue
  • [x] Used Github auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [x] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [x] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [x] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Demo

https://user-images.githubusercontent.com/3684187/133668395-c9213117-08e2-4289-a34f-0b07468dcef5.mov

+47 -32

0 comment

4 changed files

onyb

pr closed time in 5 days

PullRequestReviewEvent

Pull request review commentbrave/brave-core

Implemented Transactions List in UI

 const Portfolio = (props: Props) => {     }   }, [portfolioHistory, portfolioBalance]) +  const selectedAssetTransactions = React.useMemo((): TransactionInfo[] => {+    const list = transactions.map((account) => {+      return account?.transactions+    })+    const combinedList = [].concat.apply([], list)+    if (selectedAsset?.symbol === selectedNetwork.symbol) {+      return combinedList.filter((tx: TransactionInfo) => tx.txType === TransactionType.ETHSend || tx.txType === TransactionType.ERC20Approve)+    } else {+      return combinedList.filter((tx: TransactionInfo) => tx.txData.baseData.to.toLowerCase() === selectedAsset?.contractAddress.toLowerCase())+    }+  }, [selectedAsset, transactions])++  const findAccount = (address: string): WalletAccountType | undefined => {+    return accounts.find((account) => address.toLowerCase() === account.address.toLowerCase())+  }

Could this be memoized?

Douglashdaniel

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

issue openedbrave/brave-browser

Add fuzzy-search to SelectAsset list

The current way of searching through assets list in the wallet works fine, but has limitations when the list gets long or the users' search terms are approximate (ex, etherium vs ethereum). Use fuse.js instead.

created time in 5 days

PR opened brave/brave-core

Reviewers
feat(wallet): use Fuse.js for fuzzy-search in select-assets list feature/wallet

Allow fuzzy search in assets list search bar, making it convenient when the number of assets us too large. Also added a small optimisation to prevent the filterAssetList callback from being recreated on every render.

Submitter Checklist:

  • [x] I confirm that no security/privacy review is needed, or that I have requested one
  • [ ] There is a ticket for my issue
  • [ ] Used Github auto-closing keywords in the PR description above
  • [x] Wrote a good PR/commit description
  • [x] Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • [x] Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • [x] Ran git rebase master (if needed)

Reviewer Checklist:

  • [ ] A security review is not needed, or a link to one is included in the PR description
  • [ ] New files have MPL-2.0 license header
  • [ ] Adequate test coverage exists to prevent regressions
  • [ ] Major classes, functions and non-trivial code blocks are well-commented
  • [ ] Changes in component dependencies are properly reflected in gn
  • [ ] Code follows the style guide
  • [ ] Test plan is specified in PR before merging

After-merge Checklist:

  • [ ] The associated issue milestone is set to the smallest version that the changes has landed on
  • [ ] All relevant documentation has been updated, for instance:
    • [ ] https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
    • [ ] https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
    • [ ] https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
    • [ ] https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
    • [ ] https://github.com/brave/brave-browser/wiki/Custom-Headers
    • [ ] https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
    • [ ] https://github.com/brave/brave-browser/wiki/QA-Guide
    • [ ] https://github.com/brave/brave-browser/wiki/P3A

Demo

https://user-images.githubusercontent.com/3684187/133668395-c9213117-08e2-4289-a34f-0b07468dcef5.mov

+47 -32

0 comment

4 changed files

pr created time in 5 days

create barnchbrave/brave-core

branch : f/wallet/fuse

created branch time in 5 days

push eventbrave/brave-core

Aleksey Seren

commit sha 1e54f6646ef5835af205d3613cbdae66983274c8

Feature param for custom ad notification dark mode background color. fix https://github.com/brave/brave-browser/issues/17528

view details

Simon Hong

commit sha 2d94955a901083b6e2c5a809800af892cdef7bf4

Added don't ask checkbox to crash report permission ask dialog fix https://github.com/brave/brave-browser/issues/18103 User will not see this dialog anymore after checking this checkbox.

view details

Simon Hong

commit sha 4a75322a08ed00aa57ec226c6e42869c88a007bb

Changed prefs to kDontAskForCrashReporting to prevent double negative

view details

Simon Hong

commit sha d37f2cccb76f648287fd6292d4e2d6fc6fba690f

Disable crash reporting permission dialog on android We don't need to enable this feature on android.

view details

Simon Hong

commit sha 25f4916460aab33a78efd3ab3e4873acecfa7f34

Use build guard for crash dialog code

view details

Anthony Tseng

commit sha adf55bb43b5dbfcf2de5f321658446856c4c8a99

Fix wrong default service name and account name are used when getting keychain password. Also fix getting correct keychain password when importing from chrome, brave and chromium

view details

Brian Clifton

commit sha 2fbc6674a1b8191628c4d04a90cb9dcd410510ff

Merge pull request #10093 from brave/add_dont_ask_checkbox_to_crash_report_permission_ask_dialog Added don't ask checkbox to crash report permission ask dialog

view details

Terry Mancey

commit sha e7227b6967ecffe651b322b7dda16ab5837e4d84

Merge pull request #10041 from brave/issues/17528 Feature param for custom ad notification dark mode background color.

view details

brave-builds

commit sha 9e8dc444c1403b651a4e23cec9075b8ae99ba292

1.31.45

view details

Anthony Tseng

commit sha 623c3e2b9f08ac219d344c410d33841ee1a53121

Merge pull request #10108 from brave/keychain_mac_fix Fix wrong default service name and account name are used when getting

view details

brave-builds

commit sha 4838dc619f98da6e9831f0e4724c8c664d0a9f52

1.31.46

view details

Simon Hong

commit sha d035fb6b3a9aa226564f6d878e10864ef6c57dba

Notify connecting/disconnecting state from vpn connection on Win fix https://github.com/brave/brave-browser/issues/17883

view details

Simon Hong

commit sha 24ba022b30c720e246166aabe6fb3937276015d7

Use NULL for Win32 API instead of nullptr

view details

Mikhail

commit sha 222d80bc2822665b7acbd28c5ca5c86d6681d331

Replace ninja to autoninja in build scripts (#10036)

view details

Simon Hong

commit sha 6e2c6b55c923b3e7f43c1e29dc9f60109996646d

Merge pull request #10097 from brave/brave_vpn_notification_win Notify connecting/disconnecting state from vpn connection on Win

view details

Anirudha Bose

commit sha 1ebb33ea9e61fc71c24c230e21031f5a2cfd7281

wip swap

view details

push time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentbrave/brave-core

Implemented a Method to Reduce Long Account Names

+export const reduceAccountDisplayName = (name: string, reduceBy: number) => {

Are really doing a reduceBy? Looks like maxLength would be more appropriate. Also maybe we should take into account the .. and discount it in the maxLength, so you may have to adjust the values used in different places accordingly.

Douglashdaniel

comment created time in 5 days

PullRequestReviewEvent

delete branch brave/ethereum-remote-client

delete branch : ledger-eip1559

delete time in 5 days

push eventbrave/ethereum-remote-client

Anirudha Bose

commit sha 67d953c40c7387927b2c1b066d152c12b6454584

feat(eip1559): enable EIP-1559 transaction signing on Ledger HW

view details

Anirudha Bose

commit sha cf5120ee4e8f7635505affac4b59772323bc62be

Merge pull request #272 from brave/ledger-eip1559 feat(eip1559): enable EIP-1559 transaction signing on Ledger HW

view details

push time in 5 days