profile
viewpoint
Jakub Olejník olejnjak @AckeeCZ Prague iOS developer at @AckeeCZ

AckeeCZ/iOS-MVVM-ProjectTemplate 78

Project template to use as a starting point for new iOS apps

AckeeCZ/ACKReactiveExtensions 15

Set of useful extensions for ReactiveSwift & ReactiveCocoa

AckeeCZ/ACKLocalization 14

Localize your Cocoa apps from Google Spreadsheet

olejnjak/BetterLabel 6

BetterLabel simplifies setting general styling properties which should normally be handled by NSAttributedString

olejnjak/InfiniteScroller 3

Microlibrary which simplifies implementation of infinite scroll in UIScrollView

AckeeCZ/load-xcode-version 2

GitHub action for loading Xcode version from shared storage

olejnjak/DependencyManagersComparison 2

Compare performance of various Cocoa dependency managers

olejnjak/WindowTransitions 2

Set of basic UIWindow transitions

AckeeCZ/ios-crash-demo 1

Demo project with iOS crash reporting symbolication issue

olejnjak/Interpolator 1

Swift implementation of Android interpolators

pull request commenttuist/tuist

Don't generate empty copy phases

Hi @kwridan,

is there any update SPM dependencies handling since? I have run into an issue when I have a framework that links only SPM dependencies, it is uncompilable. The cause is empty Embed frameworks build phase, if it is removed it compiles without any issues. Also creating framework target using Xcode doesn't create the empty Embed frameworks build phase and also, if last embedded framework is removed in General tab, the build phase is removed...

It is easily reproducible by this Project.swift

kalkwarf

comment created time in 21 hours

PullRequestReviewEvent

pull request commentAckeeCZ/ACKImagePicker

Xcode 12

Right now I realized that we cannot update the Xcode version to 12.X because of Carthage... so I downgraded the version back to 11.7

Well we can use Xcode 12 and skip creating Carthage binary, binary created using old Xcode is almost as useless as no binary...

LukasHromadnik

comment created time in a day

startedmarmelroy/PhoneNumberKit

started time in 4 days

issue commentiziz/libPhoneNumber-iOS

Push new version 1.0.3

Please before addressing this, check #331 as I think that merging #326 just made the header import reappear

alexey1312

comment created time in 5 days

Pull request review commentiziz/libPhoneNumber-iOS

Address #317: Add x86_64 for simulator build

 		940725B624BF90290011AE05 /* NBShortNumberMetadataHelper.m in Sources */ = {isa = PBXBuildFile; fileRef = 940725B424BF90290011AE05 /* NBShortNumberMetadataHelper.m */; }; 		9439832824CB545000CF8CB4 /* README.md in Resources */ = {isa = PBXBuildFile; fileRef = 9439832724CB545000CF8CB4 /* README.md */; }; 		9439832D24CB569100CF8CB4 /* README.md in Resources */ = {isa = PBXBuildFile; fileRef = 9439832C24CB569100CF8CB4 /* README.md */; };-		944B9B022497ED79007E17B5 /* NBGeocoderMetadataHelper.h in Headers */ = {isa = PBXBuildFile; fileRef = 944B9B002497ED79007E17B5 /* NBGeocoderMetadataHelper.h */; settings = {ATTRIBUTES = (Public, ); }; };

Effectively I think, that this change made other schemes uncompilable

jrabek

comment created time in 5 days

PullRequestReviewEvent

PR opened iziz/libPhoneNumber-iOS

Fix header import

It looks like merging #326 made libPhoneNumberGeocoding and libPhoneNumberShortNumber uncompilable. This effectively means that Carthage distribution have become useless as it always compiles all shared schemes.

This PR updates header imports to make all schemes compile again. If you can think about better solution I will be more than happy to help to make the project fully functional again.

+4 -2

0 comment

3 changed files

pr created time in 5 days

create barncholejnjak/libPhoneNumber-iOS

branch : fix/imports

created branch time in 5 days

fork olejnjak/libPhoneNumber-iOS

iOS port from libphonenumber (Google's phone number handling library)

fork in 5 days

Pull request review commenttuist/tuist

Add support for CLI tool target

 import TSCBasic import TuistSupport  /// Model of a provisioning profile-struct ProvisioningProfile: Equatable {+public struct ProvisioningProfile: Equatable {

olejnjak

comment created time in 5 days

PullRequestReviewEvent

push eventtuist/tuist

Jakub Olejnik

commit sha e062b845f493b5f1924ed0404de220e7e19cd29b

Revert some more changes caused by incorrect swiftformat version

view details

push time in 5 days

push eventtuist/tuist

Jakub Olejnik

commit sha d60980d44f3bfa80335c47670c013846eaa5d5a1

Make `ProvisioningProfile` internal again

view details

push time in 5 days

push eventtuist/tuist

Jakub Olejnik

commit sha 66a2ab5889fb69b2cec5bd282ce3153de1c3020b

Revert 52e6b6c7528baf22d322d7bf471cd39ba3b0e8c8

view details

push time in 5 days

push eventtuist/tuist

Jakub Olejnik

commit sha fe26bf656a56cc18c9ebbd91906511c91490d82a

Re-run swiftformat

view details

push time in 5 days

push eventtuist/tuist

Jakub Olejnik

commit sha 1e201ef31f5db1742b1bc8036c86d728ee81e78f

Fix `ProvisioningProfile` accessors

view details

push time in 5 days

push eventtuist/tuist

ldindu

commit sha 8141ba11028ed668b4bbf755dbe02eb8e5641433

Fix missing profile scheme arguments when specified in manifest (#1938) * Fix missing profile scheme arguments when specified in manifest * Update changelog

view details

Facundo Menzella

commit sha 44e5e4506eb5cb7fed1f7da55d39e4caac65a39c

Deleting extra code (#1940)

view details

Pedro Piñera Buendía

commit sha 67a88fc0ef6db775cd44a9345a3591f2f6bb5353

Some renames to remove some ambiguity in file names (#1942) * Delete Generator * Rename WorkspaceGenerator to WorkspaceDescriptorGenerator * Rename ProjectGenerator to ProjectDescriptorGenerator * Rename SchemesGenerator to SchemeDescriptorsGenerator * Rename ProjectGenerator to Generator * Update README

view details

Jakub Olejnik

commit sha 5e2dcf903b15396e22ea4b53677a1a793409851d

Merge branch 'master' into cli_tool # Conflicts: # Sources/TuistGenerator/Generator/SchemeDescriptorsGenerator.swift

view details

Jakub Olejnik

commit sha c63dcca0faee11b03a56a9c6a8edda5beafe5d29

Update changelog

view details

Jakub Olejnik

commit sha defe4faa33b6270bfe99b5a4f462ca457e37f431

Run swiftformat

view details

push time in 5 days

create barnchAckeeCZ/ACKategories

branch : fix/fc_threading

created branch time in 5 days

push eventtuist/tuist

Jakub Olejnik

commit sha 52e6b6c7528baf22d322d7bf471cd39ba3b0e8c8

Run swiftformat

view details

push time in 6 days

PR opened tuist/tuist

Add support for CLI tool target

Resolves https://github.com/tuist/tuist/issues/1224

Short description 📝

Adds support for generating CLI tool targets.

Solution 📦

Just added commandLineTool as Product type and altered related properties and tests.

Implementation 👩‍💻👨‍💻

  • [x] add commandLineTool as Product type
  • [x] fix missing cases errors generated by compiler
  • [x] update runnable and forPlatform(_:) bodies
  • [x] update related tests
+22 -3

0 comment

7 changed files

pr created time in 6 days

push eventtuist/tuist

Jakub Olejnik

commit sha 50862c16f8e8770fc4481f31984bee25fe6402a7

Update product tests

view details

push time in 6 days

create barnchtuist/tuist

branch : cli_tool

created branch time in 6 days

delete branch tuist/XcodeProj

delete branch : public_settings_init

delete time in 7 days

create barnchtuist/XcodeProj

branch : public_settings_init

created branch time in 7 days

issue closedAckeeCZ/iOS-MVVM-ProjectTemplate

Plist parameter is not passed in project template

When creating are project using our project template func, we do not forward the infoPlist parameter and that is a source of pretty bad and hard to find bugs.

https://github.com/AckeeCZ/iOS-MVVM-ProjectTemplate/blob/6a4e10c00246f496e31811c269437b1edecb3070/Tuist/ProjectDescriptionHelpers/Project%2BTemplates.swift#L46

closed time in 16 days

olejnjak
MemberEvent

push eventAckeeCZ/iOS-MVVM-ProjectTemplate

Jakub Olejnik

commit sha 51ce7c10c5d1ad96b05d1b3dee06564e203d671e

⬆️ Update ACKLocalization

view details

Jakub Olejnik

commit sha c32ed76864f9dcb52ea29b7e3dbe34a40a417421

➖ Remove Smartling.i18n

view details

Jakub Olejnik

commit sha e11ffdbbccd341b98ce97baef89669fb36110298

✨ Add real spreadsheet for localization

view details

Jakub Olejnik

commit sha 7db181de7c9c9685233152cd9d538524efd94c7d

🔥 Remove code that requires Smartlin.i18n

view details

Jakub Olejnik

commit sha b427826a2d497f7e531df1c39bd0ab50dfdf7242

✨ Add dummy service account for localization

view details

Jakub Olejnik

commit sha 1d37de2ab2b30613319d4d559e0f69ed998719e1

🌐 Update localizations from sheet

view details

Jakub Olejnik

commit sha c6a26f95fec9b190a54ffb705211e5871506e5a7

📝 Update changelog

view details

Jakub Olejník

commit sha 0afe84be582ac4f5119f3e3d4c5577d79d35fdd6

Merge pull request #66 from AckeeCZ/update_localization Update ACKLocalization

view details

push time in 16 days

delete branch AckeeCZ/iOS-MVVM-ProjectTemplate

delete branch : update_localization

delete time in 16 days

PR merged AckeeCZ/iOS-MVVM-ProjectTemplate

Reviewers
Update ACKLocalization

Updates ACKLocalization to 1.1, removes Smartling.i18n.

It was necessary to add API key or service account to communicate with Google Sheets API (see https://github.com/AckeeCZ/ACKLocalization/issues/21), so we use dummy service account, which will obviously don't work, this is already mentioned on wiki so until this PR is merged it is quite inconsistent.

I also created a spreadsheet that illustrates how it should look like, it is read-only for public.

Closes #56.

Checklist

<!-- DO NOT REMOVE THIS CHECKLIST OR YOU'LL BURN IN HELL 🔥🧨💣 -->

  • [x] Updated CHANGELOG.md.
+29 -29

1 comment

8 changed files

olejnjak

pr closed time in 16 days

issue closedAckeeCZ/iOS-MVVM-ProjectTemplate

Update ACKLocalization

Update ACKLocalization to ~> 1.1 as it has much nicer API and it supports native stringsdicts. This means that Smartling.i18n can be removed from dependencies.

https://github.com/AckeeCZ/iOS-MVVM-ProjectTemplate/blob/08a08cbac9bcebdfc85f451750d43eb08e9a01f5/Podfile#L16

closed time in 16 days

olejnjak

issue openedAckeeCZ/iOS-MVVM-ProjectTemplate

Plist parameter is not passed in project template

When creating are project using our project template func, we do not forward the infoPlist parameter and that is a source of pretty bad and hard to find bugs.

https://github.com/AckeeCZ/iOS-MVVM-ProjectTemplate/blob/6a4e10c00246f496e31811c269437b1edecb3070/Tuist/ProjectDescriptionHelpers/Project%2BTemplates.swift#L46

created time in 16 days

issue commentCarthage/Carthage

Carthage builds fail at xcrun lipo on Xcode 12 beta (3,4,5...)

Has anyone checked with xCode 12.1 GM?

Not yet, but as it supports Apple Sillicon Macs as all 12.x versions, it will be the same.

Okay, thanks. I am nervous about using Carthage now... and I'm a little confused about what is happening. Is this something Carthage can fix on their end, and if so, why are they not fixing it? Should we be looking for something else to replace Carthage?

Just go through this issue, everything is written here...yes it can be fixed on Carthage side, work is in progress (#2881), but as you surely know, Carthage is opensource, there is nothing like Carthage team, that will only take care of it, people do that in their free time, after work, etc.

Replacing Carthage (especially with SPM) would be probably be the only fully reliable solution as it is maintained by Apple, so they do have such dedicated team, even though it is OSS as well.

sam-w

comment created time in 16 days

issue commentCarthage/Carthage

Carthage builds fail at xcrun lipo on Xcode 12 beta (3,4,5...)

Has anyone checked with xCode 12.1 GM?

Not yet, but as it supports Apple Sillicon Macs as all 12.x versions, it will be the same.

sam-w

comment created time in 16 days

issue openedtuist/tuist

`tuist local` with branch name containing slash

Describe the bug

If we use tuist from custom branch, that has name containing a slash e.g. bugfix/transitive_app_extension, running tuist local successfully creates .tuist.version file with correct branch name but running tuist bundle then fails. Well all call to tuist require new compilation and then fail (if .tuist-bin is not present obviously).

To Reproduce

  1. run tuist local bugfix/transitive_app_extension
  2. run tuist bundle
  3. see error
olejnjak@Jakub-MacBook project % tuist bundle
Bundling the version bugfix/transitive_app_extension in the directory /Users/olejnjak/project/.tuist-bin
Version bugfix/transitive_app_extension not available locally. Installing...
Pulling source code
Cloning into '/var/folders/0g/y_6j5jd50s75h7m568jhpzrm0000gn/T/TemporaryDirectory.hzudhk'...
Updating files: 100% (2167/2167), done.
Building using Swift (it might take a while)
Version bugfix/transitive_app_extension installed
We received an error that we couldn't handle:
    - Localized description: The file “TemporaryDirectory.WeVAUV” doesn’t exist.
    - Error: Error Domain=NSCocoaErrorDomain Code=4 "The file “TemporaryDirectory.WeVAUV” doesn’t exist." UserInfo={NSSourceFilePathErrorKey=/var/folders/0g/y_6j5jd50s75h7m568jhpzrm0000gn/T/TemporaryDirectory.WeVAUV, NSUserStringVariant=(
    Copy
), NSDestinationFilePath=/Users/olejnjak/.tuist/Versions/bugfix/transitive_app_extension, NSFilePath=/var/folders/0g/y_6j5jd50s75h7m568jhpzrm0000gn/T/TemporaryDirectory.WeVAUV, NSUnderlyingError=0x7fd871e045b0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}"

Expected behavior

Well this is a good point, in the best scenario I would love tuist to just work with such named branches, but I can imagine that the complexity of this behavior is too high. So I can think about a few solutions:

  1. convert / in branch names to different character, which might be tricky
  2. when running tuist local with such branch name warn user that it is not recommended or fail with error and suggest to use commit hash instead as that works just fine
  3. support nested directories in .tuist/Versions

Desktop (please complete the following information):

  • OS: macOS Big Sur (20A5384c)
  • Tuist Version: 1.21.0

Additional context Well I'd like to discuss the possible solutions so I can implement it right away. For me the candidate is 2. as it is clear, simple and makes sense.

Thanks in advance!

created time in 18 days

delete branch olejnjak/Carthage

delete branch : xcode12_workaround_guide

delete time in 21 days

PR opened Carthage/Carthage

Xcode 12 workaround guide

As #3019 issue contains lot of questions "how can I make this workaround work" I created a page where it is all summarized and can be easily linked, instead of linking to one of 300 comments in the issue.

The script that is contained in the guide is one of the last versions mentioned in the issue and I use it successfully on my projects, so it should be fine to use.

+57 -0

0 comment

1 changed file

pr created time in 21 days

create barncholejnjak/Carthage

branch : xcode12_workaround_guide

created branch time in 21 days

fork olejnjak/Carthage

A simple, decentralized dependency manager for Cocoa

fork in 21 days

issue commentCarthage/Carthage

Carthage builds fail at xcrun lipo on Xcode 12 beta (3,4,5...)

@clausjoergensen some of those comments say that it will be solved by implementing support of XCFrameworks (#2881, #2801)

sam-w

comment created time in 25 days

issue commentfirebase/firebase-ios-sdk

Firebase ID token has expired.

We are currently deploying solution that will incorporate such logging as mentioned by @samhorlbeck.

IgorRosocha

comment created time in 25 days

startedDevUtilsApp/DevUtils-app

started time in a month

created tagAckeeCZ/load-xcode-version

tag1.0.1

GitHub action for loading Xcode version from shared storage

created time in a month

release AckeeCZ/load-xcode-version

1.0.1

released time in a month

push eventAckeeCZ/load-xcode-version

dependabot[bot]

commit sha cb9bb2ecbacb7d8240e9c0a4ad4609855f7c93a1

Bump @actions/core from 1.2.3 to 1.2.6 Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.3 to 1.2.6. - [Release notes](https://github.com/actions/toolkit/releases) - [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jakub Olejník

commit sha 20a0ba6abe5ab727da1975eaf80c1fe820808280

Merge pull request #1 from AckeeCZ/dependabot/npm_and_yarn/actions/core-1.2.6 Bump @actions/core from 1.2.3 to 1.2.6

view details

push time in a month

PR merged AckeeCZ/load-xcode-version

Bump @actions/core from 1.2.3 to 1.2.6 dependencies

Bumps @actions/core from 1.2.3 to 1.2.6. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md">@actions/core's changelog</a>.</em></p> <blockquote> <h3>1.2.6</h3> <ul> <li><a href="https://github-redirect.dependabot.com/actions/toolkit/pull/571">Update <code>exportVariable</code> and <code>addPath</code> to use environment files</a></li> </ul> <h3>1.2.5</h3> <ul> <li><a href="https://github-redirect.dependabot.com/actions/toolkit/pull/548">Correctly bundle License File with package</a></li> </ul> <h3>1.2.4</h3> <ul> <li><a href="https://github-redirect.dependabot.com/actions/toolkit/pull/405">Be more lenient in accepting non-string command inputs</a></li> <li><a href="https://github-redirect.dependabot.com/actions/toolkit/pull/411">Add Echo commands</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/actions/toolkit/commits/HEAD/packages/core">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~thboop">thboop</a>, a new releaser for @actions/core since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -4

0 comment

2 changed files

dependabot[bot]

pr closed time in a month

pull request commentAckeeCZ/iOS-MVVM-ProjectTemplate

Update ACKLocalization

As you mentioned the wiki, I'd take the opportunity and update the following comment:

As requests to Google Sheets API require authentication (API key or service account) we cannot provide that so the service account we provide is just dummy, so we have some.

I'd just rephrase it as this is, at least for me, quite hard to read and understand what it is the documentation is trying to say

Rephrased to

We cannot provide working service account for you, but authentication is required by Google Sheets API, that means that all calls to ACKLocalization will fail. To make it work, you need to provide your own service account or API key.

olejnjak

comment created time in a month

GollumEvent

create barnchAckeeEDU/bi-ios-2020

branch : 03-views

created branch time in a month

created tagAckeeCZ/ACKImagePicker

tag0.3.0

created time in a month

push eventAckeeCZ/ACKImagePicker

Jakub Olejnik

commit sha d72f4551b5b93063a4783debbec8a6b14eb03d80

🔧 Use Xcode 11.7

view details

Jakub Olejnik

commit sha eb1d1307b3e9876b07cdb2224c5b113d5ab888c7

🔖 Bump version

view details

push time in a month

push eventAckeeCZ/ACKImagePicker

Lukáš Hromadník

commit sha 672610db2a860ea124b728a79bd46e9783f538bb

🎨 Add some documentation and update code style

view details

Lukáš Hromadník

commit sha a0503e733866e8b08bbe064da31701f56ca37854

✨ Add CircularProgressView

view details

Lukáš Hromadník

commit sha 314f52bf7985c59c450ef039e32ca638391f3321

🎨 Finalize CircularProgressView implementation

view details

Lukáš Hromadník

commit sha c76cdc4404db7117a744dc8dca407e93ba487142

✨ Add ProgressViewController instead of views

view details

Lukáš Hromadník

commit sha 5a41c1c5d323712eccf9d8aa273d3b1996f0604c

🎨 Update the overlay behavior

view details

Lukáš Hromadník

commit sha 6774ca481a94d075055f49854be0e25b23bcb0dc

💡 Explain progress in asyncAfter

view details

Lukáš Hromadník

commit sha 738bec27bca9e6aa5e91655506b330aa84321b1f

📚 Add translations

view details

Lukáš Hromadník

commit sha 20f7f281a9eaa8988068a2b6202e003f0734b300

🐛 Fix loading label alignment

view details

Lukáš Hromadník

commit sha 54e36e7684b480a4bcaf3c456c3a00aed29df05a

🎨 Improve progress handling

view details

Lukáš Hromadník

commit sha 8a072cfec0428ad802e7d9ea34a203cf426b1d4c

📄 Update CHANGELOG

view details

Lukáš Hromadník

commit sha 1a53e78049b3a67917c0d9db0a07f979aac6197d

👌 Fix typo

view details

Lukáš Hromadník

commit sha d1a3e61fd4b1a6afc3f4cd3cb1e7ee326cff79f3

🚨 Swiftlint autocorrect

view details

Jakub Olejník

commit sha 0315c537883e0dfb6907b8efae5e0bbe8d028ec3

Merge pull request #13 from AckeeCZ/feature/new-download-progress New download progress

view details

push time in a month

delete branch AckeeCZ/ACKImagePicker

delete branch : feature/new-download-progress

delete time in a month

PR merged AckeeCZ/ACKImagePicker

New download progress

The previous progress UI was not as intutive as we want so we decided to create a new one much nicer progress UI. User can see now the percentage of the download progress.

Also translations were updated.

Simulator Screen Shot - iPhone 11 - 2020-09-01 at 10 05 11

Checklist

  • [x] Added tests (if applicable)
+422 -346

3 comments

27 changed files

LukasHromadnik

pr closed time in a month

PullRequestReviewEvent

startednicklockwood/Chess

started time in a month

GollumEvent

PR opened AckeeCZ/iOS-MVVM-ProjectTemplate

Reviewers
Update ACKLocalization

Updates ACKLocalization to 1.1, removes Smartling.i18n.

It was necessary to add API key or service account to communicate with Google Sheets API (see https://github.com/AckeeCZ/ACKLocalization/issues/21), so we use dummy service account, which will obviously don't work, this will be mentioned on wiki.

Checklist

<!-- DO NOT REMOVE THIS CHECKLIST OR YOU'LL BURN IN HELL 🔥🧨💣 -->

  • [x] Updated CHANGELOG.md.
+29 -29

0 comment

8 changed files

pr created time in a month

push eventAckeeCZ/iOS-MVVM-ProjectTemplate

Jakub Olejnik

commit sha b427826a2d497f7e531df1c39bd0ab50dfdf7242

✨ Add dummy service account for localization

view details

Jakub Olejnik

commit sha 1d37de2ab2b30613319d4d559e0f69ed998719e1

🌐 Update localizations from sheet

view details

Jakub Olejnik

commit sha c6a26f95fec9b190a54ffb705211e5871506e5a7

📝 Update changelog

view details

push time in a month

issue closedAckeeCZ/ACKLocalization

Unable to fetch public sheet

It can be usual use case that user might want to fetch localizations from public spreadsheet so no API key nor service account will be provided.

Right now we fail with error but this should be allowed.

❌ Either apiKey or serviceAccount must be provided in localization.json

closed time in a month

olejnjak

issue commentAckeeCZ/ACKLocalization

Unable to fetch public sheet

Okay, this issue is invalid as all requests to Google APIs have to be authorized at least by API key so Google is able to identify which app did the request

olejnjak

comment created time in a month

issue commentAckeeCZ/iOS-MVVM-ProjectTemplate

Update ACKLocalization

For now this issue is blocked by https://github.com/AckeeCZ/ACKLocalization/issues/21 as we would need to fetch localization form public read-only spreadsheet so we do not have to provide apiKey or serviceAccount in localization.json file.

olejnjak

comment created time in a month

create barnchAckeeCZ/iOS-MVVM-ProjectTemplate

branch : update_localization

created branch time in a month

issue openedAckeeCZ/ACKLocalization

Unable to fetch public sheet

It can be usual use case that user might want to fetch localizations from public spreadsheet so no API key nor service account will be provided.

Right now we fail with error but this should be allowed.

❌ Either apiKey or serviceAccount must be provided in localization.json

created time in a month

push eventAckeeCZ/iOS-MVVM-ProjectTemplate

Jakub Olejnik

commit sha f2e254641404d03ccb3894d0cefafd65ee6ee15d

⬆️ Update Carthage dependencies

view details

Jakub Olejnik

commit sha 537f0d722b6e0ab4a928ec06559fb0be67af4ab4

⬆️ Update bundle

view details

Jakub Olejnik

commit sha 6f5cfd85582500934a5d2bfa47a6cbb84ad9b7f2

⬆️ Update pods

view details

Jakub Olejnik

commit sha 19e6fb2f716862e0e16bef7c8433a48cb50053b0

⬆️ Update pods

view details

Jakub Olejnik

commit sha a3ed17eb91436166eb4dd245f79e4f9773a40036

🔥 Remove pluggable app delegates

view details

Jakub Olejnik

commit sha 8241eb74d2fd67360408439402a4e4b0e1a7c49b

📝 Update changelog

view details

Jakub Olejnik

commit sha b60da5538be372174cb41c1132b213448abca374

🔥 Remove extra app delegates

view details

Jakub Olejník

commit sha 6a4e10c00246f496e31811c269437b1edecb3070

Merge pull request #65 from AckeeCZ/remove_pluggable_delegates Remove pluggable delegates

view details

push time in a month

delete branch AckeeCZ/iOS-MVVM-ProjectTemplate

delete branch : remove_pluggable_delegates

delete time in a month

PR merged AckeeCZ/iOS-MVVM-ProjectTemplate

Remove pluggable delegates

Remove pluggable app delegates as we no more use them as most of logic it should be used for has moved to flow coordinators.

Closes #64.

Checklist

<!-- DO NOT REMOVE THIS CHECKLIST OR YOU'LL BURN IN HELL 🔥🧨💣 -->

  • [x] Updated CHANGELOG.md.
+87 -553

1 comment

11 changed files

olejnjak

pr closed time in a month

issue closedAckeeCZ/iOS-MVVM-ProjectTemplate

Remove pluggable application delegates

As we no more need pluggable app delegates, we should remove them also from template.

https://github.com/AckeeCZ/iOS-MVVM-ProjectTemplate/blob/08a08cbac9bcebdfc85f451750d43eb08e9a01f5/ProjectTemplate/AppDelegates/Base/PluggableApplicationDelegate.swift#L13

closed time in a month

olejnjak
GollumEvent
GollumEvent

pull request commentAckeeCZ/iOS-MVVM-ProjectTemplate

Remove pluggable delegates

❓ What about FirebaseAppDelegate? Is it still in the project?

Removed ✅

olejnjak

comment created time in a month

Pull request review commentAckeeCZ/iOS-MVVM-ProjectTemplate

Remove pluggable delegates

 PODS:   - ACKLocalization (0.3.3)   - LicensePlist (2.16.0)   - Smartling.i18n (1.0.14)-  - SwiftGen (6.2.0)-  - SwiftLint (0.39.2)+  - SwiftGen (6.3.0)+  - SwiftLint (0.40.3)  DEPENDENCIES:   - ACKLocalization (~> 0.3)   - LicensePlist (~> 2.14)   - Smartling.i18n (~> 1.0)

This will be separate MR considering #56.

olejnjak

comment created time in a month

PullRequestReviewEvent

push eventAckeeCZ/iOS-MVVM-ProjectTemplate

Jakub Olejnik

commit sha b60da5538be372174cb41c1132b213448abca374

🔥 Remove extra app delegates

view details

push time in a month

PR opened AckeeCZ/iOS-MVVM-ProjectTemplate

Reviewers
Remove pluggable delegates

Remove pluggable app delegates as we no more use them as most of logic it should be used for has moved to flow coordinators.

Closes #64.

Checklist

<!-- DO NOT REMOVE THIS CHECKLIST OR YOU'LL BURN IN HELL 🔥🧨💣 -->

  • [x] Updated CHANGELOG.md.
+83 -540

0 comment

10 changed files

pr created time in a month

push eventAckeeCZ/iOS-MVVM-ProjectTemplate

Jakub Olejnik

commit sha 8241eb74d2fd67360408439402a4e4b0e1a7c49b

📝 Update changelog

view details

push time in a month

create barnchAckeeCZ/iOS-MVVM-ProjectTemplate

branch : remove_pluggable_delegates

created branch time in a month

issue commentfirebase/firebase-ios-sdk

Firebase ID token has expired.

Would it be possible that if multiple calls to getIDToken(completion:) are made, we would receive one token for the first time, which will be invalidated with subsequent calls?

IgorRosocha

comment created time in a month

issue commentrealm/realm-cocoa

Xcode12 beta5 Carthage build fail

Thanks for quick update 🙂 is there any hint where to start when trying to fix this issue? I'm open to contribution but it would be nice to know where to start 🙂

AlexanderPan

comment created time in a month

issue commentrealm/realm-cocoa

Xcode12 beta5 Carthage build fail

Any progress on this? Or any hints how this could be fixed? 🙂

AlexanderPan

comment created time in a month

issue openedAckeeCZ/ACKReactiveExtensions

Use `MappingError` in Marshal extensions

As we do not like the force cast of error, we should use generic MappingError also for Marshal extensions (in the same way we do it for Codable)

https://github.com/AckeeCZ/ACKReactiveExtensions/blob/d7ced4c5e685a56099187d31542a302f9109a0fa/ACKReactiveExtensions/Marshal/MarshalMapping.swift#L61

created time in a month

created tagAckeeCZ/ACKLocalization

tag1.1.2

Localize your Cocoa apps from Google Spreadsheet

created time in a month

push eventAckeeCZ/ACKLocalization

Jakub Olejnik

commit sha 6c9cfce2dc611b946dba7b5d4eeb6e507ed679e2

🔖 Bump version 1.1.2

view details

push time in a month

GollumEvent

push eventAckeeCZ/ACKategories

Karel Leinhäupl

commit sha 39881b97e77b8b8a3c9c4e6291f87b4453a538f0

✨ Add SelfSizingTableHeaderFooterView

view details

Karel Leinhäupl

commit sha 5688fe8cb8365a47afc435d9610edf988f944e20

🗑 Make TableHeaderFooterView deprecated

view details

Karel Leinhäupl

commit sha 555917cf1bc3bd1dc95567158140fd11675058b0

💬 Update changelog

view details

Karel Leinhäupl

commit sha c8f5e9a130348b6dd8dc7917a9f0af8094f64ad7

👌 Use private modifier instead of fileprivate

view details

Jakub Olejník

commit sha 8878b6cfffea23a1b7a4cbd0dbd0eb9771cecee9

Merge pull request #92 from leinhauplk/fix/deprecate_tableheaderfooterview Deprecate TableHeaderFooterView

view details

push time in 2 months

issue closedAckeeCZ/ACKategories

TableHeaderFooterView should inherit from UITableViewHeaderFooterView

As TableHeaderFooterView inherits from UIView and not UITableViewHeaderFooterView, its readableContentGuide behaves differently from UITableViewCells.

It should definitely inherit from UITableViewHeaderFooterView but I think it would be better to make this change somehow breaking as UITableViewHeaderFooterView has e.g. defined background color. We should think about good breaking change that would force everyone to think about it.

https://github.com/AckeeCZ/ACKategories/blob/66874990bf1298523d520fe8c0f94e273d516e83/ACKategories-iOS/TableHeaderFooterView.swift#L4

closed time in 2 months

olejnjak

push eventAckeeCZ/ACKLocalization

Jakub Olejnik

commit sha b614b344103cb8d46c7b5bafea79f9ad01f76ca6

🐛 Fix creation of empty files

view details

Jakub Olejnik

commit sha 89f62a63111ad48dbb6e9af3e07421f9d6fc31ac

📝 Update CHANGELOG

view details

Jakub Olejník

commit sha b372a33f9a9e4d8ab98445965f9df7d6694de752

Merge pull request #20 from AckeeCZ/fix/empty_files 🐛 Fix creation of empty files

view details

push time in 2 months

delete branch AckeeCZ/ACKLocalization

delete branch : fix/empty_files

delete time in 2 months

PR merged AckeeCZ/ACKLocalization

🐛 Fix creation of empty files

Check if we are not creating empty files before writing data. This cannot be simply tested as we should improve dependency injection to write tests for that (#19).

Resolves #18.

Checklist

  • [ ] Added tests (if applicable)
+12 -5

0 comment

2 changed files

olejnjak

pr closed time in 2 months

issue closedAckeeCZ/ACKLocalization

Spreadsheet without plurals creates empty stringsdict file

If spreadsheet doesn't contain any plurals, stringsdict file is still created. This can break the iOS localization system.

I assume it will be the same issue if spreadsheet will contain only plurals. Check this case too, even though it will not be that frequent.

closed time in 2 months

olejnjak
PullRequestReviewEvent

PR opened AckeeCZ/ACKLocalization

Reviewers
🐛 Fix creation of empty files

Check if we are not creating empty files before writing data. This cannot be simply tested as we should improve dependency injection to write tests for that (#19).

Resolves #18.

Checklist

  • [ ] Added tests (if applicable)
+12 -5

0 comment

2 changed files

pr created time in 2 months

push eventAckeeCZ/ACKLocalization

Jakub Olejnik

commit sha 89f62a63111ad48dbb6e9af3e07421f9d6fc31ac

📝 Update CHANGELOG

view details

push time in 2 months

issue openedAckeeCZ/ACKLocalization

Improve dependency injection to improve testability

Right e.g. writing data to files can (and should be) extracted to separate service/object so it can be tested.

And also part of this issue should be writing those tests.

created time in 2 months

create barnchAckeeCZ/ACKLocalization

branch : fix/empty_files

created branch time in 2 months

issue openedAckeeCZ/ACKLocalization

Spreadsheet without plurals creates empty stringsdict file

If spreadsheet doesn't contain any plurals, stringsdict file is still created. I assume it will be the same issue if spreadsheet will contain only plurals. Check this case too.

created time in 2 months

pull request commentAckeeCZ/ACKategories

Deprecate TableHeaderFooterView

Just please update changelog, otherwise I think we are fine 🙂

leinhauplk

comment created time in 2 months

created tagAckeeCZ/ACKLocalization

tag1.1.1

Localize your Cocoa apps from Google Spreadsheet

created time in 2 months

push eventAckeeCZ/ACKLocalization

Jakub Olejnik

commit sha b3807aa76ef1830280e0003a5fec89d601cc8145

🔖 Bump version to 1.1.1

view details

push time in 2 months

delete branch AckeeCZ/ACKLocalization

delete branch : fix/default-stringsdict

delete time in 2 months

more