profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/olehermanse/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ole Herman Schumacher Elgesem olehermanse @cfengine Oslo, Norway https://oleherman.com/

ifimikro/mikrorobot 9

Mikros robotprosjekt

cfengine/cf-remote 4

Deploy CFEngine to remote hosts

cfengine/starter_pack 4

A starting point for new CFEngine (Enterprise) developers

cfengine/libntech 3

Lightweight C library of basic utilities used in CFEngine

cf-bottom/self 2

__init__

cfengine/cfbs 2

WIP CFEngine Build System

olehermanse/cocoa-python 2

Python wrapper around Objective-C runtime

olehermanse/dotfiles 2

Files I use to configure shells/terminals on unix systems

olehermanse/core 1

CFEngine Community

PullRequestReviewEvent

push eventcfengine/cfbs-index

Ole Herman Schumacher Elgesem

commit sha 7302ae64e3a9ac162affbf9184c939164a748b24

Added version number to autorun module

view details

push time in 35 minutes

PullRequestReviewEvent

Pull request review commentcfengine/masterfiles

Add a test for a custom promise using the 'handle' attribute

+######################################################+#+#  Basic test of custom promise using the 'handle' attribute+#+#####################################################+body common control+{+        inputs => { "../default.cf.sub" };+        bundlesequence  => { default("$(this.promise_filename)") };+        version => "1.0";+}++#######################################################++bundle common python_check+{+  classes:+    "python_version_compatible_with_cfengine_library"+      expression => returnszero("/usr/bin/python3 -c 'import sys; assert sys.version_info >= (3,6)'", "useshell");+@if minimum_version(3.17)+    "cfengine_supports_custom_promises" expression => "any";+@endif+}++bundle agent init+{+  meta:+      "test_skip_unsupported" string => "!python_version_compatible_with_cfengine_library|!cfengine_supports_custom_promises";++  files:+      "$(this.promise_dirname)/cfengine.py"+      copy_from => local_cp("$(this.promise_dirname)/../../../modules/promises/cfengine.py");+}++#######################################################++@if minimum_version(3.17)+promise agent multiline_insert+{+        interpreter => "/usr/bin/python3";+        path => "$(this.promise_dirname)/multiline_insert.py";+}++bundle agent test+{+  meta:+      "description" -> { "CFE-3439" }+        string => "Test a custom promise using the 'handle' attribute";++  multiline_insert:+      "$(G.testfile)"+        lines => { "handle is:", "$(this.handle)" },+        handle => "example_handle";

Every time I've seen handle used, it's for another promise to use in depends_on, so I would do that here or add another test. You could say that then you are testing depends_on as well, but I would say without it you are not testing the most important part of handle.

  multiline_insert:
      "$(G.testfile)"
        lines => { "handle is:", "$(this.handle)" },
        handle => "example_handle_1";
  classes:
    "found_example_handle_1" # Should be defined
      depends_on => "example_handle_1";
    "found_example_handle_2" # Shouldn't be defined
      depends_on => "example_handle_2";
vpodzime

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

push eventcfengine/core

Nick Anderson

commit sha a08082b21b835b5a607cb0706d9e0adcbec49639

Changed IRC channel reference from freenode to libera.chat Ticket: ENT-7627 Changelog: None

view details

Ole Herman Schumacher Elgesem

commit sha 64fe9f0fc71bf0bbdd0fa7ba6cd171adec349c28

Merge pull request #4796 from nickanderson/ENT-7627/master ENT-7627: Changed IRC channel reference from freenode to libera.chat

view details

push time in 2 days

PR merged cfengine/core

ENT-7627: Changed IRC channel reference from freenode to libera.chat

Ticket: ENT-7627 Changelog: None

+2 -2

0 comment

1 changed file

nickanderson

pr closed time in 2 days

push eventcfengine/core

Nick Anderson

commit sha 093bc32cbfa7ae7cc1695dcc5a21c6772ad3bd7b

Changed IRC channel reference from freenode to libera.chat Ticket: ENT-7627 Changelog: None (cherry picked from commit a08082b21b835b5a607cb0706d9e0adcbec49639)

view details

Ole Herman Schumacher Elgesem

commit sha 66f27ca5bcc7a30b2384eb999df9fd30447952be

Merge pull request #4798 from nickanderson/ENT-7627/3.15.x ENT-7627: Changed IRC channel reference from freenode to libera.chat (3.15)

view details

push time in 2 days

PR merged cfengine/core

ENT-7627: Changed IRC channel reference from freenode to libera.chat (3.15)

Ticket: ENT-7627 Changelog: None (cherry picked from commit a08082b21b835b5a607cb0706d9e0adcbec49639)

+5 -6

0 comment

1 changed file

nickanderson

pr closed time in 2 days

push eventcfengine/core

Nick Anderson

commit sha f03555f92f7f0a44f1385f5c6cdb8f9283e3896d

Changed IRC channel reference from freenode to libera.chat Ticket: ENT-7627 Changelog: None (cherry picked from commit a08082b21b835b5a607cb0706d9e0adcbec49639)

view details

Ole Herman Schumacher Elgesem

commit sha a46b6e6e5dabbab55230c7f444859db01a325bb1

Merge pull request #4797 from nickanderson/ENT-7627/3.18.x ENT-7627: Changed IRC channel reference from freenode to libera.chat (3.18)

view details

push time in 2 days

PR merged cfengine/core

ENT-7627: Changed IRC channel reference from freenode to libera.chat (3.18)

Ticket: ENT-7627 Changelog: None (cherry picked from commit a08082b21b835b5a607cb0706d9e0adcbec49639)

+2 -2

0 comment

1 changed file

nickanderson

pr closed time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

delete branch cfengine/cfbs

delete branch : pretty

delete time in 2 days

push eventcfengine/cfbs

Ole Herman Schumacher Elgesem

commit sha d9865d1efc84c4cb28c3792522b70bc406634124

Fixed issue with escaping special characters in JSON string pretty printing Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>

view details

Ole Herman Schumacher Elgesem

commit sha c90682043ff8cfd05dc1057ba6b88f802e6a55dc

Merge pull request #19 from cfengine/pretty Fixed issue with escaping special characters in JSON string pretty printing

view details

push time in 2 days

PR opened cfengine/cfbs

Reviewers
Fixed issue with escaping special characters in JSON string pretty printing
+20 -1

0 comment

2 changed files

pr created time in 3 days

create barnchcfengine/cfbs

branch : pretty

created branch time in 3 days

push eventcfengine/cfbs

Craig Comstock

commit sha 30e389d7be553d162f5132592b95428f803e2a1e

Make invalid json error easier to read Ticket: CFE-3757

view details

Ole Herman Schumacher Elgesem

commit sha 176173d13969c0c815ffd941899b8c0bcc80273b

Merge pull request #18 from craigcomstock/CFE-3757 CFE-3757: Make invalid json error easier to read

view details

push time in 3 days

PR merged cfengine/cfbs

CFE-3757: Make invalid json error easier to read

Ticket: CFE-3757

+3 -0

1 comment

1 changed file

craigcomstock

pr closed time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentcfengine/masterfiles

Make sure systemd service info is always fresh

 body action fresh_systemd_state     ifelapsed => "0"; @endif +    background => "false"; # Needed for versions 3.15.x and older that did not+                           # support empty bodies. When 3.15.x is no longer+                           # supported, this can be removed.

I am 90% sure you can just add

any::

To make the body not empty.

vpodzime

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentmendersoftware/mender-python-client

Fix deadlock after reconnection

 def download_and_resume(                         fh.write(data)                         offset += len(data)                         fh.flush()-                        t_difference = datetime.now() - date_past-                        t_diff_millis = (-                            t_difference.seconds * 1000-                            + t_difference.microseconds / 1000-                        )                         speed = (-                            DOWNLOAD_CHUNK_SIZE_BYTES * 8 / t_diff_millis * 1000 / 1024+                            DOWNLOAD_CHUNK_SIZE_BYTES+                            * 8+                            / millisec_diff_now(date_past)+                            * 1000+                            / 1024                         )                         log.debug(                             f"chunk: {chunk_no} data length: {len(data)}"-                            + f"time passed: {t_diff_millis:.0f} millis speed {speed:.1f} Kbit/s"+                            + f"time passed: {millisec_diff_now(date_past):.0f} milliseconds."+                            + f"Speed {speed:.1f} Kbit/s"                         )                         date_past = datetime.now()                         chunk_no += 1                 # Download completed in one go, return-                t_difference = datetime.now() - date_start-                t_diff_millis = (-                    t_difference.seconds * 1000 + t_difference.microseconds / 1000-                )                 log.debug(                     f"Got EOF. Wrote {offset} bytes. Total is {content_length}."-                    + "Time {t_diff_millis/1000:.2f} seconds"+                    + "Time {t_difference.seconds:.2f} seconds"

You removed t_difference.

oleorhagen

comment created time in 10 days

PullRequestReviewEvent