profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/oldtinroof/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

oldtinroof/js-assessment 1

A test-driven approach to assessing JS skills

oldtinroof/fastify-session 0

session plugin for fastify

oldtinroof/react-native-youtube 0

A <YouTube/> component for React Native.

oldtinroof/svelte-navigator 0

Simple, accessible routing for Svelte

issue commentfastify/help

How to implement "remember me" with fastify session?

Ah great, thanks for the clarification! I'm happy to put a PR together with the working changes if that helps?

oldtinroof

comment created time in a month

issue commentfastify/help

How to implement "remember me" with fastify session?

Nope, it doesn't seem to do anything... I think the original issue on the old repo mentioned that too.

oldtinroof

comment created time in a month

issue openedfastify/help

How to implement "remember me" with fastify session?

This was already raised on the old repo for fastify-session: https://github.com/SerayaEryn/fastify-session/issues/106, but the person who raised it solved it for their own custom session store, with no other answers.

What are you trying to achieve, or the steps to reproduce?

I'd like to be able to control the age of the cookie programatically to only return a long lived cookie if a user selects a "remember me" option.

I took the above persons suggestion for amending the session constructor and applied this with patch-package which works for now:

this[maxAge] = prevSession.expires ? new Date(prevSession.expires).getTime() : cookieOpts.maxAge```

Then setting the max age of the cookie in my auth route with:

```if (remember) {
      req.session.cookie.maxAge = COOKIE_AGE;
    }```

I'm using connect-pg-simple for my session store, and wondered if there was a way to handle changing the maxAge of the cookie within a route without patching?

#### Context

node version: 14.6.1
fastify version: 3.14.2
@fastify/session version: 6.1.0

created time in a month

issue commentmui-org/material-ui-x

[X-Grid] Clicking header to sort when sortModel applied is broken

Thanks for the clarification @m4theushw - I've had a look at the docs, and it looks like the latest version now includes the update too. Cheers :)

oldtinroof

comment created time in a month

issue openedmui-org/material-ui-x

[X-Grid] Clicking header to sort when sortModel applied is broken

I've just updated our app to use the latest alpha (v36) of x-grid, and the table sorting no longer works if a sortModel prop is supplied.

From what I can tell, the bug first appeared in the v34 alpha release.

  • [x] The issue is present in the latest release.
  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When I apply a simple sortModel (as per the documentation) to a grid, it applies the sorting required, but when you click a column header to sort the grid, it doesn't do anything.

Expected Behavior 🤔

When I click the column header I expect the grid to sort by that column, whether there's an initial sortModel provided or not.

Steps to Reproduce 🕹

<!-- Provide a link to a live example (you can use codesandbox.io) and an unambiguous set of steps to reproduce this bug. Include code to reproduce, if relevant (which it most likely is).

You should use the official codesandbox template as a starting point: https://material-ui.com/r/issue-template-latest

If you have an issue concerning TypeScript please start from this TypeScript playground: https://material-ui.com/r/ts-issue-template

Issues without some form of live example have a longer response time. -->

https://codesandbox.io/s/quizzical-ritchie-febcb?file=/src/Demo.tsx

Steps:

  1. Create grid with sortModel
  2. Click a header cell to sort
  3. Nothing happens
  4. ...

Context 🔦

Trying to keep up with the updates :)

Your Environment 🌎

<!-- Run npx @material-ui/envinfo and post the results. If you encounter issues with TypeScript please include the used tsconfig. --> <details> <summary>npx @material-ui/envinfo</summary> In latest Chrome.

 System:
    OS: macOS 11.5
  Binaries:
    Node: 14.16.1 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.10.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 92.0.4515.131
    Edge: Not Found
    Firefox: 90.0.2
    Safari: 14.1.2
  npmPackages:
    @material-ui/core: 4.12.3 => 4.12.3 
    @material-ui/icons: 4.11.2 => 4.11.2 
    @material-ui/lab: 4.0.0-alpha.60 => 4.0.0-alpha.60 
    @material-ui/pickers: 3.3.10 => 3.3.10 
    @material-ui/styles:  4.11.4 
    @material-ui/system: 4.12.1 => 4.12.1 
    @material-ui/types:  5.1.0 
    @material-ui/utils:  4.11.2 
    @material-ui/x-grid: 4.0.0-alpha.36 => 4.0.0-alpha.36 
    @material-ui/x-license:  4.0.0-alpha.36 
    @types/react: ^16.9.19 => 16.14.12 
    react: ^16.13.1 => 16.14.0 
    react-dom: ^16.12.0 => 16.14.0 
    styled-components: 5.1.0 => 5.1.0 

</details>

Order id 💳

23124 <!-- The Pro plan comes with priority over the Community/MIT plan. Providing your order id will help us give your problem the attention it deserves. -->

created time in a month