profile
viewpoint

amitzur/debugger.html 0

An experimental debugger interface.

ohana54/angular-contenteditable 0

angular model for the "contenteditable" attribute

ohana54/angular-strap 0

Bootstrap directives for Angular

ohana54/awesome-vscode 0

🎨 A curated list of delightful VS Code packages and resources.

ohana54/bs-faker 0

Faker.js bindings for BuckleScript in Reason

ohana54/bs-let 0

A PPX for async/await (and general monadic binding) in ReasonML.

ohana54/debugger.html 0

The Firefox debugger that works anywhere :boom:

create barnchohana54/yoshi

branch : fix-ci-build-info-serverless

created branch time in a day

push eventohana54/yoshi

Artem Yavorsky

commit sha 53dabf6aa95d09ec7d02fd3664bdee1b05d40aee

Fix test for checking nvmrc files (#2785)

view details

wix-renovate

commit sha 4ac742807cada8501d228bbd8b1aa196df5b2eb1

Update dependency jest-teamcity to v1.8.0 (#2767) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

Amir Yonatan

commit sha 3545b95d723f6cf3534d7d80f9e47c73545d77c6

fixed a small bug with certificates on legacy cdn (#2788)

view details

Yaniv Efraim

commit sha 6ac166079ad2cf0d4ae5099c11fb521378b571c9

Yoshi Serverless Client: temporary replace `isomorphic-unfetch` (#2786)

view details

Artem Yavorsky

commit sha ba669f1ad38ddbe894b558f59bc6d8ebb8422ef6

Mobile settings support for editor flow (#2782) * Add mobile settings support * Add docs for settings * Fix tests * trigger CI * Update yarn lock * Fix isMobile for html * Add mobile option to docs * Update docs

view details

Tomer Ohana

commit sha 0f7c9cf38c6b2a2df41f11fe985baea907fe3692

Use the ci-build-info library (#2784)

view details

Ran Yitzhaki

commit sha 299b9021368a586242ee1eb6877a3333cd445c32

v4.126.0

view details

Amit Dahan

commit sha 0501cd8c5b3b3918c8a27d2e32c711214a8f3e77

Add Fedops integration to BM Flow (#2736)

view details

Amit Dahan

commit sha f9c2b305f69d5fcb65f9210bb7ed63135f3f28a2

Remove stripOrg from pkgName (#2794)

view details

Ran Yitzhaki

commit sha 65e7c2e43cd94132f423416ce0b2dcc8bc956b09

v4.127.0

view details

Amit Dahan

commit sha ff9e6bc4e0ace5ebb8b6434b92d646b315c9a409

Add "App Loaded" inntegration to Flow BM (#2739) Co-authored-by: Ran Yitzhaki <ranyitz@users.noreply.github.com>

view details

Netanel Gilad

commit sha 6b30a429bfec00c95be72f56945aa419d2be6071

upgrade ci-build-info to ^1.0.30 (#2795)

view details

Ran Yitzhaki

commit sha bd030e1097905f5793c29a2bb2cd8baefbf0d2df

v4.128.0

view details

Kobi

commit sha 69b2ca1a18ec2ef506093f5a5f6df75b95b56830

fix docs structure (#2793)

view details

Artem Yavorsky

commit sha 5a31f0067cf9e0eca4299ac5b356ee86d0268e0d

Extend controller with flowAPI features. (#2791) * Fix lint issue * Pass flow data correctly * Refactor user controller wrapping to pass needed props to components * Move controller wrapper

view details

Amit Dahan

commit sha fa4d9ac26cd76f34ca0c12a98bdbb81589ad8a75

Bump react & react-dom for BM projects (#2737)

view details

Artem Yavorsky

commit sha f3da3661067af3d8ed7d5fcb97797c9b8193b133

Add `react-custom-scroll` to be transpiled for editor flow projects. (#2801) * Add controller url to dev center * Fix react-custom-scroll * add a comment * remove dev center changes

view details

Carmel Cohen

commit sha 55bb67ee68df4f80b45771a16f7e7fcdc6a8e4ff

add dependency_test_mapping per FED policy checks (#2792)

view details

Artem Yavorsky

commit sha 8a2a9c7ff88b13c92421c68aca1dd2d9029bad81

Add controller url to dev center

view details

Artem Yavorsky

commit sha 1e98ff7f1788a69d98d5756791bb01e1764c3090

v4.129.0

view details

push time in a day

push eventohana54/yoshi

Tomer Ohana

commit sha 3703b4dfd8ad59c90991aaf8d913ff3e920abcd6

Fix ci-build-info monorepo support

view details

push time in 6 days

create barnchohana54/yoshi

branch : fix-ci-build-info-monorepo

created branch time in 6 days

push eventohana54/yoshi

Tomer Ohana

commit sha b4c964487b463d051ea38e0918ac94639c9f2cdf

Use the ci-build-info library

view details

push time in 10 days

push eventohana54/yoshi

Tomer Ohana

commit sha 0adbec851d41155f9b45cea607d0de2521edb87d

Use the ci-build-info library

view details

push time in 10 days

push eventohana54/yoshi

Tomer Ohana

commit sha f63a6420a04f3af4102a625795fe5111773d9aa5

Use the ci-build-info library

view details

push time in 11 days

PR opened wix/yoshi

Use the ci-build-info library

This is the second attempt of #2699, which had a bug not supporting node<12

+223 -157

0 comment

27 changed files

pr created time in 12 days

create barnchohana54/yoshi

branch : use-ci-build-info-v2

created branch time in 12 days

push eventohana54/yoshi

Ran Yitzhaki

commit sha 7cdadef6d5588997ec7d2c7eb50b9761d9d66615

Remove a comment which is no longer relevant (#2712)

view details

Kobi

commit sha 00e504aeddb28fe8fc5bb6fc572884954b801fb4

add auto release script (#2726)

view details

Amit Dahan

commit sha d7ba41103b7246d80171640c6cca73b8278a007a

Fix BI integration for exported-components in BM flow (#2729) * Fix BI integration for exported-components * Use named export for clarity

view details

wix-renovate

commit sha b048ee7597cf9af84b76194b17a4ddffcc756ef8

Update babel monorepo (#2703) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 11804a997c326486e3a12f32deedf6852250abbd

Update dependency chrome-launcher to v0.13.4 (#2710) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 5484064b05450b59316ebb91c36a35d32a370c06

Update dependency autoprefixer to v9.8.5 (#2709) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 1cf812023b99d046e3ca62ae335d676d507f7164

Update dependency @types/lodash to v4.14.157 (#2706) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 5a76792420dbf2122c05a065e469fc25f1a6e9b0

Update dependency @types/babel__traverse to v7.0.13 (#2704) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 612e996ceb285ad748c2c5711faa89bc5a7dcd1d

Update dependency @types/express to v4.17.7 (#2705) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 01fda881ede4e6ceac69f3eda6f707df55bd995f

Update dependency eslint-plugin-import to v2.22.0 (#2711) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 1931591155a3bf88a38ebee7a158d509e99769de

Update dependency eslint-plugin-react to v7.20.3 (#2713) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha d7fab0dbe0c332d6c015fa29fa90e64488df9b6d

Update dependency fp-ts to v2.7.0 (#2714) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha f8038fa96ae8440a485a39fd32f72fd9ee39ff2a

Update dependency graphql to v14.7.0 (#2715) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 4e7680674726df489b328d233b4fcadb332b657b

Update dependency io-ts to v2.2.9 (#2717) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha c5a790857159ed72620dc781e23e5e7a277b6476

Update dependency petri-specs to v1.3.288 (#2720) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 385903b3e76ecda6a8fdf5a0f9d208145ca8411c

Update dependency react-module-container to v1.0.2320 (#2721) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha b56bba3b8d651d9b033d7ddd7c811f05b9d47126

Update dependency type-fest to v0.16.0 (#2722) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 94760e2c51471f143e767f5d67bef7307eeaefeb

Update dependency lodash to v4.17.19 (#2718) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha 73526830f4a6993610459540ee709e3cd43d9fa1

Update dependency graphql-tag to v2.10.4 (#2716) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

wix-renovate

commit sha f22f072abb901cd2d8de1a44d5ffbdf5076b6915

Update dependency typescript to v3.9.7 (#2741) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amit Dahan <amitda@wix.com>

view details

push time in 12 days

push eventohana54/yoshi

Tomer Ohana

commit sha de357b5545b968771479d865458686f49fe2e14c

Remove redundant parameter

view details

push time in 14 days

Pull request review commentwix/yoshi

Use the ci-build-info library

 describe('monorepo', () => {   it('selective build', async () => {     rimraf.sync(path.join(scripts.testDirectory, 'packages/*/dist')); -    await scripts.build({}, ['monorepo-app']);+    await scripts.build(localEnv, ['monorepo-app']);

I thought that was the purpose of prod, which is basically build in CI env, no? build seems like a low-level function being used by dev and prod, so let me know what you want to do with it - I think it's important that the env will be explicit, as before it was affected by the environment that it ran in (for example, I couldn't run this test locally in a simulated CI env). Thoughts?

ohana54

comment created time in 14 days

Pull request review commentwix/yoshi

Use the ci-build-info library

 export default class Scripts {     callback: TestCallbackWithResult = async () => {},     opts: ScriptOpts & { staticsDir?: string } = {},   ) {-    const buildResult = await this.build({ ...ciEnv, ...opts.env }, opts.args);+    const buildResult = await this.build(+      { ...ciEnv, ...opts.env, ...this.ciBuildInfoEnv },

It depends on the context - start for example, is not relevant in a CI environment, so it might be confusing/wrong to apply it to everything by default. Does that make sense?

ohana54

comment created time in 15 days

Pull request review commentwix/yoshi

Use the ci-build-info library

 export default class Scripts {       testDirectory: featureDir,       isMonorepo,       projectType,+      packageName: newPackageJSONfileContents.name,

You're not missing anything, I forgot to remove it in one of the refactors :)

ohana54

comment created time in 15 days

delete branch ohana54/re-logger

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 15 days

push eventohana54/re-logger

dependabot[bot]

commit sha a76765f09b0cdee15aa8589e9be45b8a46ca4346

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 15 days

PR merged ohana54/re-logger

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 15 days

pull request commentwix/yoshi

Use the ci-build-info library

Thanks Ran, the test "complication" makes total sense for this type of project, we're in the same situation. I did love that there is great coverage for the use cases, it gave me a lot of confidence doing this refactor, so well done!

ohana54

comment created time in 15 days

delete branch ohana54/yoshi

delete branch : test-branch

delete time in 17 days

create barnchohana54/yoshi

branch : test-branch

created branch time in 17 days

pull request commentwix/yoshi

make shouldDeployToCDN using ciBuild info

@ranyitz I continued the work in #2699, so this can be closed.

justame

comment created time in 17 days

push eventohana54/yoshi

Tomer Ohana

commit sha a5a961a695afc3934e21e5006a4abd0520171484

Use the ci-build-info library This replaces the current implementation which has knowledge about internal CI implementation details

view details

push time in 17 days

push eventohana54/yoshi

Tomer Ohana

commit sha 776ed9abc891ebc306266ba1dfb6c3f9b9b049eb

Use the ci-build-info library This replaces the current implementation which has knowledge about internal CI implementation details

view details

push time in 18 days

push eventohana54/yoshi

Tomer Ohana

commit sha e84bbd3fd57b67f7427f3a1ab84a84f4834fdda5

Use the ci-build-info library This replaces the current implementation which has knowledge about internal CI implementation details

view details

push time in 18 days

push eventohana54/yoshi

Tomer Ohana

commit sha 78a63fe780c91fcaf29950461346118db6f8766a

Switch to using the testkit

view details

Tomer Ohana

commit sha 2cacc05da639647beb976e16e651c91df6839607

Attempt to fix serverless

view details

push time in 18 days

push eventohana54/yoshi

Tomer Ohana

commit sha 32e0581ca7a1eedbf025c1ba95b793a4ca0c9d13

Switch to using the testkit

view details

push time in 18 days

push eventohana54/yoshi

Kobi

commit sha e4454cfd1fe92fc5f96917a89e6213d74d5a76da

feat: add isAnalyze to web worker webpack config (#2683)

view details

Kobi

commit sha bdd62eacae0697527cf6c11a1121a2ac16a48c2e

v4.118.0

view details

Kobi

commit sha 1ccf52293beae4cf6aa560b2d2aa9c7b290032fd

Revert "v4.118.0" This reverts commit bdd62eac

view details

Roy Sommer

commit sha b32341dfdb51532b8ba6e56d5ece9e0e6259999d

Added `YOSHI_PUBLIC_PATH` documentation (#2692)

view details

Artem Yavorsky

commit sha 05f6cd1c35f37ec65a35bf1bbee4c8761fca4981

Fix `generate-bi-types` call (#2690) * Fix generate bi types call * trigger CI

view details

Kobi

commit sha f5828f538fb80bf4d4adf2945e72abd3c4a8fa1e

changelog for v4.119.0

view details

Kobi

commit sha 47bf9c5ed3a971da1e7c38abf69885b90d7304d8

v4.119.0

view details

Yaniv Efraim

commit sha b04a71c18fb0574ec8b8b9764512103531aefbdf

Yoshi serverless: handle errors (#2688)

view details

Roy Miloh

commit sha e606fd5414ed43470ba41c1bb29eadd6b9aec9c3

reprint initial server logs (#2694)

view details

Yaniv Efraim

commit sha 4fcdf162855a9ba23f9306ab6e59ac999f42cc8f

Yoshi Serverless: add `requireHttps` by default (#2695)

view details

Yaniv Efraim

commit sha 504a5236480a8e387bfcb3d76a013a3cd7012fcc

Yoshi Serverless: fix flaky test (#2698)

view details

Amit Dahan

commit sha 1142dc7a005d1d37027b517c9e45f2d52d2e3d5d

Add a `files` module "hook" in BM Flow (#2679)

view details

Amit Dahan

commit sha 6011f2f0f50235a9a6894179f665495b3e29b651

Reconfigure Renovate to use its base preset (#2701)

view details

Amit Dahan

commit sha cc77c0c1af133d56e95c22dfbfc27351d7f27496

Add a `resolve` module "hook" in BM Flow (#2685) Co-authored-by: Ran Yitzhaki <ranyitz@users.noreply.github.com>

view details

Ran Yitzhaki

commit sha f9a76b8c774557c1c4c26a209de18198bd9d001f

run fork-ts-checker-webpack-plugin only on client debug compilation (#2700)

view details

Artem Yavorsky

commit sha 4061e6ae3aff3ea0d81e343d4561d0ad14632065

Add `getSiteOwnerId`to settings e2e test mock (#2691) * Add `getSiteOwnerId`to settings e2e test mock * trigger CI * trigger CI * trigger CI * trigger CI

view details

Amit Dahan

commit sha 0df90bb2922b03769925a26b07408fcd21067873

Add BI Logger integration to BM Flow (#2693)

view details

Tomer Ohana

commit sha b70bd676b88aee4fa34a62a125a9409e04273027

Use the ci-build-info library This replaces the current implementation which has knowledge about internal CI implementation details

view details

Tomer Ohana

commit sha 6a7a6056b5bd2da3f0fd00969b2839a38cc69cb3

Switch to using the testkit

view details

push time in 19 days

push eventohana54/yoshi

Kobi

commit sha e4454cfd1fe92fc5f96917a89e6213d74d5a76da

feat: add isAnalyze to web worker webpack config (#2683)

view details

Kobi

commit sha bdd62eacae0697527cf6c11a1121a2ac16a48c2e

v4.118.0

view details

Kobi

commit sha 1ccf52293beae4cf6aa560b2d2aa9c7b290032fd

Revert "v4.118.0" This reverts commit bdd62eac

view details

Roy Sommer

commit sha b32341dfdb51532b8ba6e56d5ece9e0e6259999d

Added `YOSHI_PUBLIC_PATH` documentation (#2692)

view details

Artem Yavorsky

commit sha 05f6cd1c35f37ec65a35bf1bbee4c8761fca4981

Fix `generate-bi-types` call (#2690) * Fix generate bi types call * trigger CI

view details

Kobi

commit sha f5828f538fb80bf4d4adf2945e72abd3c4a8fa1e

changelog for v4.119.0

view details

Kobi

commit sha 47bf9c5ed3a971da1e7c38abf69885b90d7304d8

v4.119.0

view details

Yaniv Efraim

commit sha b04a71c18fb0574ec8b8b9764512103531aefbdf

Yoshi serverless: handle errors (#2688)

view details

Roy Miloh

commit sha e606fd5414ed43470ba41c1bb29eadd6b9aec9c3

reprint initial server logs (#2694)

view details

Yaniv Efraim

commit sha 4fcdf162855a9ba23f9306ab6e59ac999f42cc8f

Yoshi Serverless: add `requireHttps` by default (#2695)

view details

Yaniv Efraim

commit sha 504a5236480a8e387bfcb3d76a013a3cd7012fcc

Yoshi Serverless: fix flaky test (#2698)

view details

Amit Dahan

commit sha 1142dc7a005d1d37027b517c9e45f2d52d2e3d5d

Add a `files` module "hook" in BM Flow (#2679)

view details

Amit Dahan

commit sha 6011f2f0f50235a9a6894179f665495b3e29b651

Reconfigure Renovate to use its base preset (#2701)

view details

Amit Dahan

commit sha cc77c0c1af133d56e95c22dfbfc27351d7f27496

Add a `resolve` module "hook" in BM Flow (#2685) Co-authored-by: Ran Yitzhaki <ranyitz@users.noreply.github.com>

view details

Ran Yitzhaki

commit sha f9a76b8c774557c1c4c26a209de18198bd9d001f

run fork-ts-checker-webpack-plugin only on client debug compilation (#2700)

view details

Artem Yavorsky

commit sha 4061e6ae3aff3ea0d81e343d4561d0ad14632065

Add `getSiteOwnerId`to settings e2e test mock (#2691) * Add `getSiteOwnerId`to settings e2e test mock * trigger CI * trigger CI * trigger CI * trigger CI

view details

Amit Dahan

commit sha 0df90bb2922b03769925a26b07408fcd21067873

Add BI Logger integration to BM Flow (#2693)

view details

push time in 19 days

push eventohana54/yoshi

Tomer Ohana

commit sha f4f796c25326df67583e3be8deb9aef041731bc1

Use the ci-build-info library This replaces the current implementation which has knowledge about internal CI implementation details

view details

push time in 19 days

push eventohana54/yoshi

Tomer Ohana

commit sha a3189f8889ba9ca4fe1dac5b483a524f70b3ed16

Use the ci-build-info library This replaces the current implementation which has knowledge about internal CI implementation details

view details

push time in 19 days

push eventohana54/yoshi

Tomer Ohana

commit sha 484fba25e2f633d2e364af0138764ffc4296dbba

Use the ci-build-info library This replaces the current implementation which has knowledge about internal CI implementation details

view details

push time in 19 days

push eventohana54/yoshi

Tomer Ohana

commit sha bab3be9d94eb054a80263706d277b2aa6aa27ad1

Use the ci-build-info library This replaces the current implementation which has knowledge about internal CI implementation details

view details

push time in 20 days

PR opened wix/yoshi

Use the ci-build-info library

This replaces the current implementation which has knowledge about internal CI implementation details.

+122 -76

0 comment

17 changed files

pr created time in 20 days

create barnchohana54/yoshi

branch : use-ci-build-info

created branch time in 20 days

push eventohana54/yoshi

Amit Dahan

commit sha c5baccf9da8762d0bc7b1549900359401e91caa0

Add types to `methods` & `moduleInit` in BM flow (#2606)

view details

Amit Dahan

commit sha 433c22e61b2dc55b3aad5535a1107cd14e75253e

Let wallaby know not to build `spec-setup.ts` (#2629)

view details

Yaniv Efraim

commit sha 7eed4ad02bf467da11ff6ec3f0961baa8d763ad5

Yoshi serverless - import fresh with _non_webpack_require (#2645)

view details

Serhii Sydoruk

commit sha 3bc81488c4879a261cbe9606b1856453b02a1723

Update migration-guide.md (#2655)

view details

Tzach Bonfil

commit sha 649f2353fae40511b98e2730f1492df6d3854639

Jest connection error message (#2642) * feat(jest-preset-connection-error): handle 404 or 503 * chore(jest-represet-errors): rename feature name * fix: remove devtools flag * fix: update test description + change to toMatch * test: mock console.warn

view details

Serhii Sydoruk

commit sha 1390ef0a67dd3bec4334d2ae2270322969e319b0

Update `migration-guide.md` (source) (#2656)

view details

Amit Dahan

commit sha 3333161ac2f324a38608fd2e97c76600ce562173

Add bm-flow migration guide (#2496)

view details

Yaniv Efraim

commit sha 3bb49bc6fa25806e4311f819eee1ed33536ac5a4

Yoshi serverless tests (#2623)

view details

Ronen Amiel

commit sha 1ea79b72749c36d11af4432167470a6a78d22dfa

add support for experimental stylable loader under a flag (#2659)

view details

Ronen Amiel

commit sha 371199e0d9baf9458815e49734db4ab1d9a92f01

changelog for v4.111.0

view details

Ronen Amiel

commit sha e215e8da42ae47e9126a5f9430c8e7c98b295f54

v4.111.0

view details

Maor Yosef

commit sha 83304fe7040e79fad662d268fbdaa706bd2fde0a

Bump bob-widget-services version (#2661)

view details

Ran Yitzhaki

commit sha f4bb04f889fd8e4d5fa3bd5e3fcfea6e35c96151

add-business-manager-migration-guide-to-docs-version-4

view details

Artem Yavorsky

commit sha c0d890f12ea20cf842e0ffe3872bcc9c0527fdc8

Fix multilingual for settings. (#2664)

view details

Tzach Bonfil

commit sha 74ca9f8c3201d43e697dbcfc2819d792aa5a6047

fix: requestfinished event -> check for response (#2665) * fix: requestfinished event -> check for response * chore: logging for response variable * Update packages/jest-yoshi-preset/jest-environment-yoshi-puppeteer/index.js Co-authored-by: Ran Yitzhaki <ranyitz@users.noreply.github.com>

view details

Ran Yitzhaki

commit sha 3b205c067744f8f14847b7a7d8962d92fca5d70c

changelog for v4.112.0

view details

Ran Yitzhaki

commit sha 0b0eecce7f1169a2d724797662b4e87fba8f2795

v4.112.0

view details

Amit Dahan

commit sha 40e251c2547641a1f8b5d2c501844d0d598b0b7c

Fix BM method call without `{ module, moduleParams }` (#2653)

view details

Amit Dahan

commit sha 276d4fd6482a70bf5649d65abb7b773007ebd406

Add `legacyBundle` config option to pages & exported-components in BM Flow (#2624)

view details

wix-renovate

commit sha 6ad0c1f7de7a0bee4673589c09193c8d968b4321

Update stylable to v3.7.2 (#2667) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 22 days

issue commentbluelovers/ws-ts-type

Dependencies field became required instead of optional

Thanks!!

ohana54

comment created time in 24 days

issue openedbluelovers/ws-ts-type

Dependencies field became required instead of optional

Hi, I think due to this commit the dependencies fields became required.

Code to reproduce:

  const packageJson: IPackageJson = {
    name: 'test',
  }

Error:

Type '{ name: string; }' is not assignable to type 'IPackageJson<any>'.
  Type '{ name: string; }' is missing the following properties from type 'Record<IPackageJsonDependenciesField, IDependency>':
dependencies, devDependencies, optionalDependencies, peerDependencies

created time in 25 days

issue commentitereshchenkov/jest-teamcity

TypeError: Cannot read property 'push' of undefined

Might be related to the latest lodash release

ohana54

comment created time in a month

issue openeditereshchenkov/jest-teamcity

TypeError: Cannot read property 'push' of undefined

When having a describe block with the name "constructor", the above error appears. This is due to how we collect suites: https://github.com/itereshchenkov/jest-teamcity/blob/f1c956b5351b69037e65513a0fec9cff53665751/lib/formatter.js#L110

I'm guessing it's trying to set the object constructor, when path includes the word "constructor", instead of adding a new key with the name "constructor".

created time in a month

pull request commentbluelovers/ws-ts-type

Allow using true/false strings in package.json private field

Finally my 2 PRs in other repos were merged, so I opened a new PR to update the schema - #2

ohana54

comment created time in a month

PR opened bluelovers/ws-ts-type

Update package-json schema

json-schema-to-typescript was fixed so we're finally able to update the schema.

+34 -17

0 comment

2 changed files

pr created time in a month

create barnchohana54/ws-ts-type

branch : update-package-dts

created branch time in a month

push eventohana54/ws-ts-type

Tomer Ohana

commit sha fac38f5af8e2c8886ddb5dfc5702c7b4a4ff3318

Allow using true/false strings in package.json private field

view details

bluelovers

commit sha 4a1af3794a8fcc50cf696c4b22e3a9826e0d10cd

Merge pull request #1 from ohana54/allow-private-as-string Allow using true/false strings in package.json private field

view details

bluelovers

commit sha fef62817e53e3744df623e8ceaa86e14e27beec7

feat: Allow using true/false strings in package.json private field https://github.com/bluelovers/ws-ts-type/pull/1 https://github.com/bluelovers/ws-ts-type/pull/1

view details

bluelovers

commit sha 515ba48ac24078c5caf3d92cd8795b6d4613ebe7

build: update schemas

view details

bluelovers

commit sha c61da17123ae9b6a5b710fb01f7ca204f355ee99

feat: update package.json type https://segmentfault.com/a/1190000016365409

view details

bluelovers

commit sha 77f4b4d9a484ed96241c93da4b95932f34494ad7

feat: update script

view details

bluelovers

commit sha c3e73d78aede722bcef49b556cee88411051f74e

chore: update deps

view details

bluelovers

commit sha 9f7dbd2f5bce976484d6350d78c1921c7bbb254d

build: update schemas

view details

bluelovers

commit sha 1abb8bde1b4b7b66c07220205e9e012668abae6f

chore: update deps

view details

bluelovers

commit sha 2b483bcc6bab2a5fbe0b0cfe2a27f736bf5db793

chore(release): publish - @ts-type/package-dts@1.0.9 - typed-http-headers@1.0.7 - ts-type@1.2.17

view details

bluelovers

commit sha e100dc973392d035313f27214085b9ca913c03e5

fix: use ITSOverwrite for fix https://github.com/bluelovers/ws-ts-type/pull/1

view details

bluelovers

commit sha f5a9cc853510e72417094399bc4249e32b7f743e

chore(release): publish - @ts-type/package-dts@1.0.10

view details

bluelovers

commit sha 9f180ed98bbba2a7df6564eee101bf4fc052f7cb

feat: ITSWriteableDeep

view details

bluelovers

commit sha 7f9eb3771e20c1949bb0dc54521ee4dc807a2cf3

feat: ITSWriteableDeep

view details

bluelovers

commit sha e8fddb1e12e1dd9286583cd3ca53eabe349220eb

chore(release): publish - @ts-type/package-dts@1.0.11 - ts-type@1.2.18

view details

bluelovers

commit sha 025c65372acc333ae4b4ee1eba499ff55c270cc4

.

view details

bluelovers

commit sha ca1bb6b1dd10971b638ba9f591276ac0b0da94e7

chore(release): publish - @ts-type/package-dts@1.0.12 - ts-type@1.2.19

view details

bluelovers

commit sha 12dca09b9d3f345da48dbee3111282a047a67f37

.

view details

bluelovers

commit sha bfd2e92011416de8d9e0e4cb8999f43201cd1cb2

chore(release): publish - @ts-type/package-dts@1.0.13

view details

bluelovers

commit sha c10a0f3a05c99b7b46ee214aeb5fc8c3667193a4

.

view details

push time in a month

issue commentwix/yoshi

Libraries should have GAed version be synced with NPM version

use_npm_version is not working correctly all the time, I suggest not to use it. In falcon-ci version sync is on by default. cc @netanelgilad

amitdahan

comment created time in a month

issue commentwix/yoshi

can't ran yoshi testing in parallel with other yoshi tests

I think Noam is one of our ways to contribute :D :D (wix-answers are helping us move forward as first customers and partners)

Noam3kCH

comment created time in a month

pull request commentbcherny/json-schema-to-typescript

Fix 'cannot use in operator' error

Thank you @bcherny!

ohana54

comment created time in a month

push eventohana54/yoshi

wix-renovate

commit sha 8663931bb401094341cd6cb4e3e403af2cda23b3

Lock file maintenance (#2615) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Yaniv Efraim

commit sha fd0a09233b1aa84ba028fcbca84f86e1b2ed87d7

Yoshi Serverless Client (#2616)

view details

Ronen Amiel

commit sha c8766c461247c2c1372697b92499441d30b22a94

fix --debug option not being passed over to dev-environment (#2619)

view details

Ronen Amiel

commit sha 9b5df10fbf3e384393da4359fc2b0c2b410ae512

changelog for v4.107.0

view details

Ronen Amiel

commit sha b8888da8fd4bd80b6710af7d2ed25d47044062ea

v4.107.0

view details

Amit Dahan

commit sha 62247811362b454b7e6b96ecdcb9835a3d365ce6

Clean BM Flow template (#2602)

view details

Ronen Amiel

commit sha 5a0c8a86a305f48a7539ae5481c457d80f72b18f

[Experimental] Use `babel-loader` with cache enabled to transpile TypeScript files (#2617)

view details

Ronen Amiel

commit sha fd97bdcf5ba558d4b520452319db79eb6f0386a0

changelog for v4.107.1

view details

Ronen Amiel

commit sha 7d6ad4e87762fb2d94b1ad1c6ff9317358dcc8df

v4.107.1

view details

Valerii Sorokobatko

commit sha 6b0539d8896833f4b569893fca9cc55dc8a656f9

monorepoflow – remove stripOrganization from the error logs (#2618) * monorepoflow – remove stripOrganization from the error lgos * Update start.ts

view details

Artem Yavorsky

commit sha be2e9bdde5be60de18ca51bfb59491edf06b2442

Move TpaComponentsProvider and ExperimentsProvider from user's side (#2613) * Implement automatic translations solution * Don’t break Widget in case of errors in controllers. * Fix error handling for translations * Update snapshots * Update docs with translations feature * Fix types deps * Proxy translate, provider * Fix translation setProps * Fix dep * Fix broken library * Update index.ts * Update yarn lock * Move providers to flow side except bi * Pass experiments hoc from editor flow * Update snapshots * Add docs for experiments * Update yarn lock * Remove unused InjectedTranslateProps

view details

Ronen Amiel

commit sha d5190a3e12bc86e3dccbd14dd339924b8ed66afd

Don't create `serverless.js` for projects that didn't opt-into yoshi-serverless (#2622)

view details

Ronen Amiel

commit sha 1213c2514e9c48c4901908e781597d944fd29288

changelog for v4.108.0

view details

Ronen Amiel

commit sha 416696675f0906ed5ac148498f2526a1fc706a00

v4.108.0

view details

Amit Dahan

commit sha c6254bbc190da9c3b2d052ca018a945d0875b228

Refactor `yoshi/types.d.ts` to be shared across the different flows (#2604)

view details

Artem Yavorsky

commit sha d5ee86b0cbd340f3650bd1e505210e286db402ff

Mock auto-release module (#2625) * Fix setup autorelease only for ooi * Mock auto release * Requrie setupAutoRelease by demand

view details

Artem

commit sha 11fab949a76d01adca048d2cb0cbb6fcf9d4cba0

Intagrate tpa-settings v0 (#2621) * Add tpa-settings as dep * chore(yoshi-flow-editor|template): Add tpa settings and tabs to template * fix lint issues * fix conflicts * Move layout tab to design tab Co-authored-by: Artem Yavorsky <aqson@me.com>

view details

Artem Yavorsky

commit sha 412cfa39463e304900d0ff221b7252e87ab31b26

Fix for translations to include default values during build time (#2626) * translations fix * Include default translations on the build time * Refactor default translations

view details

Artem Yavorsky

commit sha 6f52086892fc3d18b9a13892276550f8b09b95f6

changelog for v4.109.0

view details

Artem Yavorsky

commit sha 56c66381e8e19b5c72d5f9f8323dc001bcfcb581

v4.109.0

view details

push time in a month

pull request commentwix/yoshi

Replace jest-teamcity-reporter with jest-teamcity

Opened an issue: https://github.com/itereshchenkov/jest-teamcity/issues/12

ohana54

comment created time in a month

issue openeditereshchenkov/jest-teamcity

Test suite failures are not reported

Hi, We switched to this library from jest-teamcity-reporter, and noticed that general test suite failures are not being reported. The other library indeed reports them as a "fake" test: https://github.com/winterbe/jest-teamcity-reporter/blob/2ebc892673611123abe34328a97a37900e277092/index.js#L25

I believe something similar should be done here. I won't have time this week to submit a PR, so I'm opening this issue in case someone else wants to take it. Thanks!

created time in a month

pull request commentwix/yoshi

Replace jest-teamcity-reporter with jest-teamcity

Indeed it looks like the new reporter doesn't account for suite failures.

ohana54

comment created time in a month

pull request commentwix/yoshi

Replace jest-teamcity-reporter with jest-teamcity

Maybe the new reporter doesn't report test suites failures correctly, you can try to use the old reporter and verify. I'll check their code as well

ohana54

comment created time in a month

pull request commentwix/yoshi

Replace jest-teamcity-reporter with jest-teamcity

This is what I said - "Test suite failed to run"

ohana54

comment created time in a month

pull request commentwix/yoshi

Replace jest-teamcity-reporter with jest-teamcity

I think it's because the entire test suite failed, and not specific tests

ohana54

comment created time in a month

pull request commentwix/yoshi

Replace jest-teamcity-reporter with jest-teamcity

According to the build log you're running jest yourself, not through Yoshi, so not sure it's related

ohana54

comment created time in a month

issue commentyarnpkg/yarn

more Extracting tar content of undefined failed woes in yarn 1.17.3

FYI, I attempted to solve one of the root causes for this issue in #8182, still waiting for someone to review it.

dagda1

comment created time in a month

pull request commentyarnpkg/yarn

Fix concurrent tarball resolution race condition

@arcanis We would really appreciate any feedback on the PR. Thanks!

ohana54

comment created time in a month

push eventohana54/yoshi

wix-renovate

commit sha 90c3678f74e46a004e0edcf714a5b6c4c5eae2b2

Update stylable to v3.6.2 (#2509) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Tomer Ohana

commit sha 7897557ddcefe6c063b43ad70328ccc02f54e627

Replace jest-teamcity-reporter with jest-teamcity (#2510)

view details

Ran Yitzhaki

commit sha 257eae30f7b8f723da8e026da12f4ed3aa887638

Improve contributing section - sort, arrange and ensure it's up to date (#2517)

view details

Amit Dahan

commit sha 151f1cb5578b3a3c5bcaa4868655d92462d63f56

changelog for v4.86.0

view details

Amit Dahan

commit sha a6f00e062cdf84959de0a6e2dae1c05cc653cb8e

v4.86.0

view details

Amit Dahan

commit sha d443beca472cae6bad12527fa5b216d39e5c1639

documentation for version 4.x

view details

Artem Yavorsky

commit sha 995f16bfb78f5f1cda44e2c2dd0cfe6b99086904

Make viewer.app.ts and editor.app.ts optional. Generate a bundle for it in any case. (#2507)

view details

Dalius Dobravolskas

commit sha a4052e57fbabdf5e668d813fcc11004966759e49

Pass unused arguments to jest in library-flow (#2519)

view details

Ran Yitzhaki

commit sha 7b131de6018afa3662c77b4051c20591a9de0529

Endorse starting from wix-serverless when creating a server project (#2514)

view details

Artem Yavorsky

commit sha 7f154a177e9b68b12a94e38bbf6f75b3ce69224b

Init flowAPI even if no viewer.app.ts was created (#2521) * Init flowAPI even if no viewer.app.ts was created * Fix override script and update snapshot

view details

Dalius Dobravolskas

commit sha 58f42142e6e2b3a7fcdf899f74dd3632f525080a

Add warning about global installation (#2522) Closes #2481

view details

Ran Yitzhaki

commit sha d14389df84b4495b5b71bebd7ec855f0de46779f

fix a bug with server process and --debug argv (#2523)

view details

Ronen Amiel

commit sha 220d002711452b1bcf043240f1af7e61f0f1d941

support configuring webworker compilation's resolve.alias (#2526)

view details

Ronen Amiel

commit sha c1e7b36c54b616800607d7975fd4b86d3be99325

changelog for v4.87.0

view details

Ronen Amiel

commit sha 77c84de9d82f24b2d303d30670baa337b813ff2a

v4.87.0

view details

Dalius Dobravolskas

commit sha 72c77755890288f412cd26ddf09e7742534fa57b

Do not show progress bar if `DEBUG=true` (#2525) Closes #2350.

view details

Artem Yavorsky

commit sha f32ff0708645e0abdc7516d94ad756e46d31f6e4

Create Sentry logs automatically (#2513) * Catch errors from editor flow * Log all worker errors under the hood. * Remove logs * Add docs to explain automatic error handling * Update snapshot * Add inEditor to the mock * Update website/docs/editor-flow/runtime-API.md Co-authored-by: Ran Yitzhaki <ranyitz@users.noreply.github.com> * Update snapshot * Add few comments Co-authored-by: Ran Yitzhaki <ranyitz@users.noreply.github.com>

view details

Ran Yitzhaki

commit sha 8aa3eed0e7fd73b846b403e8ce5d5dc7b822d09c

Publish yoshi's packages to http://npm.dev.wixpress.com/ (#2529)

view details

Yaniv Efraim

commit sha ca912e0b6f16464ccc448a37403a74f5b1108b9f

Yoshi Serverless POC (#2490)

view details

yanivefraim

commit sha ccc46c7814b8cc030a0fc0c1a5f0b7d31665f4ef

changelog for v4.88.0

view details

push time in a month

pull request commentbcherny/json-schema-to-typescript

Fix 'cannot use in operator' error

@bcherny Hi, could you please take a look at this PR when you have some time? Thanks!

ohana54

comment created time in a month

pull request commentwix/yoshi

Make library flow template deploy a tar.gz file to parastorage

@ranyitz as Amit is on vacation, we'd love your opinion here. There's a good chance I misunderstood the implications, so please correct me :)

amitdahan

comment created time in 2 months

pull request commentwix/yoshi

Make library flow template deploy a tar.gz file to parastorage

@amitdahan question - should this be the default? NPM packages at Wix are not published by default in the public registry, meaning the code stays private. With this change, if I understand correctly - every npm package will be uploaded to parastorage, making the code public. This also affects the load on CI and Media Platform. WDYT?

cc @liricooli @netanelgilad

amitdahan

comment created time in 2 months

push eventohana54/yarn

Tomer Ohana

commit sha 7b02add34768dedb0018af48a35c16deade547bc

fix lint

view details

push time in 2 months

Pull request review commentyarnpkg/yarn

Fix concurrent tarball resolution race condition

 export default class TarballResolver extends ExoticResolver {     return false;   } -  async resolve(): Promise<Manifest> {+  resolve(): Promise<Manifest> {+    const resolutionsInProgress = TarballResolver.resolutionsInProgress;+    const cached = resolutionsInProgress.get(this.url);+    if (cached) {+      return cached;+    }++    const fetchPromise = this.doResolve();+    resolutionsInProgress.set(this.url, fetchPromise);+    fetchPromise.then(() => resolutionsInProgress.delete(this.url));

Done, thank you!!

ohana54

comment created time in 2 months

push eventohana54/yarn

Tomer Ohana

commit sha 3a72943bc909b745d49f4606fa5f28c2ea15f3c3

Use a stable ref Co-authored-by: Mark Molinaro <mamolin@microsoft.com>

view details

push time in 2 months

issue commentyarnpkg/yarn

Spurious "Extracting tar content of undefined failed"

@markjm I'm not sure it will work, since the problem lies between the fetcher and the parent resolver - meaning while the fetcher unpacks the current resource, the parent resolver deletes the temp folder that the fetcher unpacks to. Meaning the "guard" has to be before the folder deletion, like I did in my PR. Does that make sense? Hopefully I'm wrong and we can have a single fix for everything :)

jleclanche

comment created time in 2 months

issue commentyarnpkg/yarn

Spurious "Extracting tar content of undefined failed"

I opened a PR which partially fixes the issue. It won't help with github urls and prepare scripts, as that area in the code was a bit more complex for me. If any of you have a consistent way to reproduce the github case, please let me know and I can try to give it a go in my spare time.

jleclanche

comment created time in 2 months

PR opened yarnpkg/yarn

Fix concurrent tarball resolution race condition

Summary

Partially fixes #7212 The original issue root cause is a case where we use a specific temp folder, while another async piece of code decides to delete it. This root cause happens in two occasions - when resolving tarballs (using TarballResolver) and when resolving packages from github that have a prepare script (which uses GitFetcher, although I'm not 100% sure it happens only in this case).

This PR is attempting to fix the tarball resolving scenario. I described the exact scenario in this comment

In my company we started using a generic storage for npm packages that shouldn't be in the registry (thus using urls to tarballs), and installations keep failing randomly, which drove us to find this issue and fix it.

Test plan Since this issue is sporadic, it might be hard to test it on an integration level. Furthermore, we need to create a custom setup as described in the comment above. I have a thought about how to do the setup (using a local static file server), although I first wanted to see if my approach is valid, before I invest a few hours on it.

Thank you for taking the time to read and review the PR. This issue is blocking us and we'll do whatever we can to fix it, we just ask your attention and guidance where needed :)

+17 -1

0 comment

2 changed files

pr created time in 2 months

create barnchohana54/yarn

branch : fix-tarball-resolution-race-condition

created branch time in 2 months

fork ohana54/yarn

📦🐈 Fast, reliable, and secure dependency management.

https://classic.yarnpkg.com

fork in 2 months

issue commentyarnpkg/yarn

Spurious "Extracting tar content of undefined failed"

Thanks @HitkoDev for the validation. This is a major blocker for us, as we started keeping tarballs from PR changes (without the need to publish them to the real registry), and having a link to these tarballs in package.json files is currently a no-go. I can try to create a PR with a promise cache, although I'm still not sure it's good enough.

jleclanche

comment created time in 2 months

pull request commentwix/yoshi

Replace jest-teamcity-reporter with jest-teamcity

Thanks for the merge! We use it for the past few months with no issues.

ohana54

comment created time in 2 months

PR opened wix/yoshi

Replace jest-teamcity-reporter with jest-teamcity

🔦 Summary

jest-teamcity has support for concurrent test reporting and is actively maintained.

🗺️ Test Plan

This should be a drop-in replacement, therefore no need for new tests

+13 -11

0 comment

8 changed files

pr created time in 2 months

create barnchohana54/yoshi

branch : use-jest-teamcity

created branch time in 2 months

push eventohana54/yoshi

Dean Shub

commit sha e4a363c1761886292b84c46e9209f7d292b10bdb

adding bail flag for template tests (#1622)

view details

renovate[bot]

commit sha f53fffcd9ab27fd243be5543862805b8a823ddd3

Update dependencies (weekly) (#1624)

view details

Amit Dahan

commit sha 664a75d03932076edefec1fe05f06b438ff523ef

Remove TS workaround for @types/prompts (#1625)

view details

Ran Yitzhaki

commit sha 3bf403c9cbbb1a8eb013e34b620f160eaea4c913

run install & lint on first time project generation (#1627)

view details

Yaniv Efraim

commit sha 9a96a046e910ef8ff82e5e74c6a3b5bdea58d495

Fix HtmlWebpackPlugin to work inside monorepo (#1626)

view details

Ran Yitzhaki

commit sha b682ae10e695bf92143e3e6e03d6f9c7382cba86

docs: small fix with cya ooi template's readme

view details

Ran Yitzhaki

commit sha 33bf45041ea7349debb4a99c26dd92b121a6c7f9

improving symlinking strategy (#1631)

view details

Dean Shub

commit sha 8ccb23c70bcb46baebd05d9e8c3920ac3cb3b353

adding verbose stdio (#1630) * adding verbose stdio * always be verbosing

view details

Ran Yitzhaki

commit sha 40189220993a96b292949e94eb7f51f4be6fefa3

Revert "adding verbose stdio (#1630)" (#1633) This reverts commit 8ccb23c70bcb46baebd05d9e8c3920ac3cb3b353.

view details

Ran Yitzhaki

commit sha 5925bd3c5bd54e5f546ad2292635544bb8f8d5fd

throw meaningful errors from e2e tests (#1634) * throw meaningful errors from e2e tests * improve code

view details

Ran Yitzhaki

commit sha 82015473f9fbae76c3eadc967b275abd7fd3bbcf

Use yarn (#1635) * move to yarn workspaces and yarn as npm client for lerna * generate a lock file * remove packages (in favor of workspaces)

view details

renovate[bot]

commit sha 0dd8bc71b8c5429302db804507b5afc377f6c497

Update dependencies (weekly) (#1636)

view details

Ran Yitzhaki

commit sha 67313a872cbc2e2f51dec46280ff0ed7d32e8149

Revert "Use yarn (#1635)" (#1644) This reverts commit 82015473f9fbae76c3eadc967b275abd7fd3bbcf.

view details

Ran Yitzhaki

commit sha 0a5eeb10cde79bb036362056cd6a807cab1c647a

Improve wix private mock (#1646) * add INSTANCE_CHANGED event to the wix-private mock * remove wix-private mock from eslintignore * prettier fix

view details

mrokas

commit sha 3c4c157acf899f17eb516109e9853a3dc9d09256

Page close error level (#1641) * do not break build on page close error * check if page is there before closing it

view details

Ran Yitzhaki

commit sha 647a0bed16dcd7f7c6c03ebb528bc8321756c1cb

changelog for v4.18.0

view details

Ran Yitzhaki

commit sha 9222f894b5013587afd7e70f28a46c350a4aa2a5

v4.18.0

view details

Ran Yitzhaki

commit sha c7d9d30fa136756bc790557498e861657535682d

fix changelog

view details

Dean Shub

commit sha 9b3836fda59bc5fe5d92e55cc58739896bc5f05e

Prettier version update (#1654)

view details

Roy Miloh

commit sha d7e8ef6c55ccd71cbafba3d381b0d48b59f9a653

support importing web workers (#1650)

view details

push time in 2 months

pull request commentbcherny/json-schema-to-typescript

Fix cannot use 'in operator #259

@bcherny I took the liberty to build on the great work done here and added a test: #310 I hope that's ok. @LutzR if you're available, feel free to take the test and add it here, and I will close my PR in favor of this one.

LutzR

comment created time in 2 months

PR opened bcherny/json-schema-to-typescript

Fix 'cannot use in operator' error

Took the great work done here #284 and added a test

+47 -2

0 comment

4 changed files

pr created time in 2 months

create barnchohana54/json-schema-to-typescript

branch : fix-canot-use-in-operator

created branch time in 2 months

pull request commentbluelovers/ws-ts-type

Allow using true/false strings in package.json private field

https://github.com/SchemaStore/schemastore/pull/1082

ohana54

comment created time in 2 months

PR opened SchemaStore/schemastore

Allow package.json private field as string

npm allows to use "true" or "false" strings for the private field.

+18 -2

0 comment

3 changed files

pr created time in 2 months

create barnchohana54/schemastore

branch : allow-private-as-string

created branch time in 2 months

fork ohana54/schemastore

A collection of JSON schema files including full API

http://schemastore.org

fork in 2 months

issue commentyarnpkg/yarn

Spurious "Extracting tar content of undefined failed"

I was able to consistently reproduce the error (by deleting the yarn cache after every try). This is my minimal setup: main package - A dependencies:

`A` -> `B`
    -> `C` -> `B`

The dependencies are listed with http urls, not versions - both for A's package.json and C's package.json. Example:

{
	"name": "A",
	"dependencies": {
		"C": "http://remote-cache/C/1.0.0"
	}
}

Basically what happens, is that B is being downloaded twice to the same temporary cache folder. Simplified flow: After downloading B for the first time, it is extracted to the temp cache folder. WHILE the extraction is ongoing, yarn tries to download B again (because it is a dependency of C). Before yarn starts to download it, it checks the temp cache folder to see if it's already there. It does that by looking for a specific metadata file, that is written only after an extraction is complete. Since the first B extraction is still ongoing, the metadata file is not there, and yarn assumes B is not in the temp cache. The problem - yarn deletes the temp cache folder (I guess to handle a corrupt state) before it starts downloading B again. Since the deletion happens during the extraction, we get the "Extracting tar content" error.

I was able to "fix" the problem by changing yarn's code to wait for ongoing download and extractions for packages. Meaning I keep the promise from the first B download process, and return it when we try to download it again, instead of having another download process interfering with the first one. It's a hacky fix so I don't think submitting a PR with it will help, I'm mentioning it here in case someone is familiar with the codebase and provide a better idea.

jleclanche

comment created time in 2 months

pull request commentbluelovers/ws-ts-type

Allow using true/false strings in package.json private field

I changed my import from import IPackageJson from '@ts-type/package-dts' to import IPackageJson from '@ts-type/package-dts/package-json'

And got the same results (which AFAICT makes sense because the first one re-exports the second)

ohana54

comment created time in 2 months

delete branch ohana54/ws-ts-type

delete branch : allow-private-as-string

delete time in 2 months

pull request commentbluelovers/ws-ts-type

Allow using true/false strings in package.json private field

Hi again :) It seems that the private field declaration in the auto-generated CoreProperties interface is overriding this change. Is there any way to fix that? I can try to submit another PR to https://github.com/SchemaStore/schemastore if that's the right thing to do.

ohana54

comment created time in 2 months

pull request commentbluelovers/ws-ts-type

Allow using true/false strings in package.json private field

Thank you!!

ohana54

comment created time in 2 months

pull request commentbluelovers/ws-ts-type

Allow using true/false strings in package.json private field

Not sure I fully understand the question, the reason for the PR is that npm client does allow using the strings "true"/"false" for the private field. My project does some manipulations on package.json files so I needed to support this as well.

ohana54

comment created time in 2 months

create barnchohana54/ws-ts-type

branch : allow-private-as-string

created branch time in 2 months

fork ohana54/ws-ts-type

typescript type helper

fork in 2 months

startedpifantastic/teamcity-service-messages

started time in 2 months

push eventwix-incubator/npm-republish

Tomer Ohana

commit sha 5550b55e2bef1e4307b4c5d8cce4201c00caad40

0.5.3

view details

push time in 2 months

push eventwix-incubator/npm-republish

Tomer Ohana

commit sha 821c85b171bc485c857f8e6cdf09990cf99200dc

Attempt to fix TC build

view details

push time in 2 months

pull request commentwix-incubator/npm-republish

Throw an informative error when npm pack fails

Thanks!

ohana54

comment created time in 2 months

push eventwix-incubator/npm-republish

Tomer Ohana

commit sha 892101d3913523a0ef366e01e4d5ca672a15b0b7

Throw an informative error when npm pack fails

view details

push time in 2 months

PR closed wix-incubator/npm-republish

Reviewers
Throw an informative error when npm pack fails

Instead of parsing/piping command line output, we now use the npm pack library directly, which throws meaningful errors.

+789 -28

2 comments

4 changed files

ohana54

pr closed time in 2 months

pull request commentwix-incubator/npm-republish

Throw an informative error when npm pack fails

libnpmpack needs at least node 10 :( I took the easy way out here: #11

ohana54

comment created time in 2 months

create barnchwix-incubator/npm-republish

branch : informative-error-message-2

created branch time in 2 months

more