profile
viewpoint
Emmanuel T Odeke odeke-em @orijtech Palo Alto, California https://orijtech.com/ Working on @orijtech, the cloud and @golang. We are hiring! Always learning!

google/gops 3698

A tool to list and diagnose Go processes currently running on your system

GoogleCloudPlatform/golang-samples 1926

Sample apps and code written for Google Cloud in the Go programming language.

indragiek/DominantColor 796

Finding dominant colors of an image using k-means clustering

census-instrumentation/opencensus-proto 71

Language Independent Interface Types For OpenCensus

census-ecosystem/opencensus-go-exporter-stackdriver 49

OpenCensus Go exporter for Stackdriver Monitoring and Trace

GoogleCloudPlatform/stackdriver-reverse-proxy 39

Simple HTTP proxy to automatically traces the incoming requests

basvanbeek/opencensus-gokit-example 27

Example of using OpenCensus with Go kit

census-ecosystem/opencensus-go-exporter-ocagent 17

OpenCensus Go exporters for OpenCensus Agent

indutny/pyg 14

Not GYP

delete branch orijtech/opencensus-service

delete branch : gomod-update-prometheus-exporter-to-v0.0.3

delete time in an hour

PR merged census-instrumentation/opencensus-service

Reviewers
go.mod: update to orijtech/prometheus-export@v0.0.3 cla: yes

This update features a dependency update to bring in a fix which removes key length truncation to 100 which AFAIK is an arbitrary key length. This issue was reported by @yiyijin in:

  • https://github.com/orijtech/prometheus-go-metrics-exporter/issues/4 and has been fixed by:
  • https://github.com/orijtech/prometheus-go-metrics-exporter/pull/5
+41 -10

4 comments

2 changed files

odeke-em

pr closed time in an hour

push eventcensus-instrumentation/opencensus-service

Emmanuel T Odeke

commit sha 57e037c599b75fe2dddf89cb9ada67bf4c8de9fc

go.mod: update to orijtech/prometheus-export@v0.0.3 This update features a dependency update to bring in a fix which removes key length truncation to 100 which AFAIK is an arbitrary key length. This issue was reported by @yiyijin in: * https://github.com/orijtech/prometheus-go-metrics-exporter/issues/4 and has been fixed by: * https://github.com/orijtech/prometheus-go-metrics-exporter/pull/5

view details

push time in an hour

push eventcensus-instrumentation/opencensus-website

Johan Brandhorst

commit sha 6e1a66f931901eb5cab80a1610d721491bab3b2b

Update grpc-gateway references (#730) Use "grpc-gateway" phrasing to avoid confusion between the JSON gateway and the grpc-web protocol.

view details

push time in 3 hours

PR merged census-instrumentation/opencensus-website

Reviewers
Update grpc-gateway references cla: yes

Use "grpc-gateway" phrasing to avoid confusion between the JSON gateway and the grpc-web protocol.

+4 -4

0 comment

2 changed files

johanbrandhorst

pr closed time in 3 hours

pull request commentcensus-instrumentation/opencensus-service

go.mod: update to orijtech/prometheus-export@v0.0.3

@yiyijin once this PR is merged, you'll be good to go!

odeke-em

comment created time in 7 hours

pull request commentcensus-instrumentation/opencensus-service

go.mod: update to orijtech/prometheus-export@v0.0.3

Thank you for the review @pjanotti! For the unrelated test failure, I've filed https://github.com/census-instrumentation/opencensus-service/issues/638.

odeke-em

comment created time in 7 hours

issue commentcensus-instrumentation/opencensus-service

receiver/prometheus: Test_jobGC data race

Found from PR https://github.com/census-instrumentation/opencensus-service/pull/637

odeke-em

comment created time in 7 hours

issue openedcensus-instrumentation/opencensus-service

receiver/prometheus: Test_jobGC data race

Just noticed at https://travis-ci.org/census-instrumentation/opencensus-service/builds/654680902#L1937

--- FAIL: Test_jobGC (0.05s)
    metrics_adjuster_test.go:348: Error: JobGC: job 1, round 2- metrics timeseries empty due to job-level gc - expected: [], actual [metric_descriptor:<name:"CUMULATIVE_DOUBLE" description:"description CUMULATIVE_DOUBLE" type:CUMULATIVE_DOUBLE label_keys:<key:"k1" description:"description: k1" > label_keys:<key:"k2" description:"description: k2" > > timeseries:<start_timestamp:<nanos:1000000 > label_values:<value:"v1" has_value:true > label_values:<value:"v2" has_value:true > points:<timestamp:<nanos:4000000 > double_value:55 > > timeseries:<start_timestamp:<nanos:1000000 > label_values:<value:"v10" has_value:true > label_values:<value:"v20" has_value:true > points:<timestamp:<nanos:4000000 > double_value:60 > >  metric_descriptor:<name:"CUMULATIVE_DISTRIBUTION" description:"description CUMULATIVE_DISTRIBUTION" type:CUMULATIVE_DISTRIBUTION label_keys:<key:"k1" description:"description: k1" > label_keys:<key:"k2" description:"description: k2" > > timeseries:<start_timestamp:<nanos:1000000 > label_values:<value:"v1" has_value:true > label_values:<value:"v2" has_value:true > points:<timestamp:<nanos:4000000 > distribution_value:<count:26 sum:52 bucket_options:<explicit:<bounds:1 bounds:2 bounds:4 > > buckets:<count:5 > buckets:<count:6 > buckets:<count:7 > buckets:<count:8 > > > > timeseries:<start_timestamp:<nanos:1000000 > label_values:<value:"v10" has_value:true > label_values:<value:"v20" has_value:true > points:<timestamp:<nanos:4000000 > distribution_value:<count:71 sum:80 bucket_options:<explicit:<bounds:1 bounds:2 bounds:4 > > buckets:<count:15 > buckets:<count:46 > buckets:<count:3 > buckets:<count:7 > > > > ]
==================
WARNING: DATA RACE
Read at 0x00c0002e5968 by goroutine 65:
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.(*JobsMap).gc()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster.go:131 +0x283
Previous write at 0x00c0002e5968 by goroutine 63:
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.(*timeseriesMap).get()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster.go:73 +0x16b
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.(*MetricsAdjuster).adjustMetricTimeseries()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster.go:223 +0x1c5
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.(*MetricsAdjuster).adjustMetric()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster.go:214 +0xde
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.(*MetricsAdjuster).AdjustMetrics()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster.go:192 +0x1b4
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.runScript()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster_test.go:346 +0x2ba
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.Test_jobGC()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster_test.go:320 +0x18b8
  testing.tRunner()
      /home/travis/.gimme/versions/go1.12.17.linux.amd64/src/testing/testing.go:865 +0x163
Goroutine 65 (running) created at:
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.(*JobsMap).maybeGC()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster.go:144 +0x13c
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.(*JobsMap).get()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster.go:155 +0x4cf
  github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal.Test_jobGC()
      /home/travis/gopath/src/github.com/census-instrumentation/opencensus-service/receiver/prometheusreceiver/internal/metrics_adjuster_test.go:318 +0x1809
  testing.tRunner()
      /home/travis/.gimme/versions/go1.12.17.linux.amd64/src/testing/testing.go:865 +0x163
Goroutine 63 (finished) created at:
  testing.(*T).Run()
      /home/travis/.gimme/versions/go1.12.17.linux.amd64/src/testing/testing.go:916 +0x65a
  testing.runTests.func1()
      /home/travis/.gimme/versions/go1.12.17.linux.amd64/src/testing/testing.go:1157 +0xa8
  testing.tRunner()
      /home/travis/.gimme/versions/go1.12.17.linux.amd64/src/testing/testing.go:865 +0x163
  testing.runTests()
      /home/travis/.gimme/versions/go1.12.17.linux.amd64/src/testing/testing.go:1155 +0x523
  testing.(*M).Run()
      /home/travis/.gimme/versions/go1.12.17.linux.amd64/src/testing/testing.go:1072 +0x2eb
  main.main()
      _testmain.go:152 +0x334
==================

created time in 8 hours

issue openedgolang/go

os: TestChdirAndGetwd doesn't restore initial working directory on GOOS=js GOARCH=wasm

Coming here from a test failure that we noticed from @randall77's CL https://go-review.googlesource.com/c/go/+/219143, we got mysterious failures https://go-review.googlesource.com/c/go/+/219143/4#message-18f33eac583b2d9ebefb682fd3d154824e8e5b58 in which even with getting the current working directory totally failed after I had suggested:

Could we perhaps use the current working directory:

   wd, err := Getwd()
   if err != nil {
	t.Fatal(err)
   }
and then
   filepath.Join(wd, ...)

@neelance came in, in https://go-review.googlesource.com/c/go/+/219143/4#message-031f21fab344d60320d779d0ac6b523de9061b22 letting us know that TestChdirAndGetwd is broken on GOOS=js, GOARCH=wasm with

I found the reason: The test TestChdirAndGetwd is unable to restore the initial working directory. This is because fd.Chdir() does not work correctly if the path of fd is relative. This is because NodeJS does not support fchdir so it has to be emulated with chdir.

Here's a possible solution:

	if path[0] != '/' {
		cwd := jsProcess.Call("cwd").String()
		path = cwd + "/" + path
	}
	f := &jsFile{
		path:    path,
		entries: entries,
	}

which is unrelated to Keith's current CL.

I am filing this issue so that we can address that separately and not block Keith's CL.

created time in 9 hours

startedgolang/perf

started time in a day

issue commentgolang/go

runtime: golang 1.14.rc1 3-5% performance regression from golang 1.13 during protobuf marshalling

@randall77 oddly it didn't backport for Go1.14.1, it only created PRs for 1.12 and 1.13.

howardjohn

comment created time in a day

issue commentorijtech/prometheus-go-metrics-exporter

metrics name truncated

Cheers! Thanks for the report, and for using this software!

On Mon, Feb 24, 2020 at 4:16 PM yiyijin notifications@github.com wrote:

Thanks a lot!

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/orijtech/prometheus-go-metrics-exporter/issues/4?email_source=notifications&email_token=ABFL3V5RRUB3U2GQYBJKXZTRERPO3A5CNFSM4K2SW3CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM2BCVQ#issuecomment-590614870, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFL3V3RJ2NHLDIDZ2RCFRDRERPO3ANCNFSM4K2SW3CA .

yiyijin

comment created time in a day

PR opened census-instrumentation/opencensus-service

Reviewers
go.mod: update to orijtech/prometheus-export@v0.0.3

This update features a dependency update to bring in a fix which removes key length truncation to 100 which AFAIK is an arbitrary key length. This issue was reported by @yiyijin in:

  • https://github.com/orijtech/prometheus-go-metrics-exporter/issues/4 and has been fixed by:
  • https://github.com/orijtech/prometheus-go-metrics-exporter/pull/5
+41 -10

0 comment

2 changed files

pr created time in a day

push eventorijtech/opencensus-service

Emmanuel T Odeke

commit sha 57e037c599b75fe2dddf89cb9ada67bf4c8de9fc

go.mod: update to orijtech/prometheus-export@v0.0.3 This update features a dependency update to bring in a fix which removes key length truncation to 100 which AFAIK is an arbitrary key length. This issue was reported by @yiyijin in: * https://github.com/orijtech/prometheus-go-metrics-exporter/issues/4 and has been fixed by: * https://github.com/orijtech/prometheus-go-metrics-exporter/pull/5

view details

push time in a day

release orijtech/prometheus-go-metrics-exporter

v0.0.3

released time in a day

delete tag orijtech/prometheus-go-metrics-exporter

delete tag : 0.0.2

delete time in a day

created tagorijtech/prometheus-go-metrics-exporter

tagv0.0.3

OpenCensus Prometheus Go Metrics exporter

created time in a day

created tagorijtech/prometheus-go-metrics-exporter

tag0.0.2

OpenCensus Prometheus Go Metrics exporter

created time in a day

push eventorijtech/prometheus-go-metrics-exporter

Emmanuel T Odeke

commit sha 56ffe589282a850b3e828a79e5f04b27f9a0f114

go modules: add go.mod + go.sum

view details

push time in a day

PR merged orijtech/prometheus-go-metrics-exporter

sanitize: remove 100 byte key-length limit from OpenCensus

Removes the seemingly arbitrary 100 byte key-length that we pulled years ago from OpenCensus Go's sanitize function verbatim. Contextually those key length limits make sense for Stackdriver, but Prometheus doesn't mention the need for limiting key lengths (at least that I know of).

Fixes #4

+62 -34

0 comment

3 changed files

odeke-em

pr closed time in a day

issue closedorijtech/prometheus-go-metrics-exporter

metrics name truncated

We are using opencensus to collect metrics from the application, which uses oc-agent and oc-collector to send to prometheus.

I have noticed that the metrics name gets truncated if the number of chars is greater than 100, after looking at the code, it looks like: https://github.com/orijtech/prometheus-go-metrics-exporter/blob/b321c5297f6069b012947cfae5924a66c593ea60/sanitize.go#L25 is causing the issue.

I just wonder any reason for this restriction? is there anyway that we can make it configurable?

closed time in a day

yiyijin

push eventorijtech/prometheus-go-metrics-exporter

Emmanuel T Odeke

commit sha fa4bc1e2f20da72c0234141ab4728e569b378ce0

sanitize: remove 100 byte key-length limit from OpenCensus Removes the seemingly arbitrary 100 byte key-length that we pulled years ago from OpenCensus Go's sanitize function verbatim. Contextually those key length limits make sense for Stackdriver, but Prometheus doesn't mention the need for limiting key lengths (at least that I know of). Fixes #4

view details

push time in a day

issue closedorijtech/prometheus-go-metrics-exporter

metrics name truncated

We are using opencensus to collect metrics from the application, which uses oc-agent and oc-collector to send to prometheus.

I have noticed that the metrics name gets truncated if the number of chars is greater than 100, after looking at the code, it looks like: https://github.com/orijtech/prometheus-go-metrics-exporter/blob/b321c5297f6069b012947cfae5924a66c593ea60/sanitize.go#L25 is causing the issue.

I just wonder any reason for this restriction? is there anyway that we can make it configurable?

closed time in a day

yiyijin

issue commentorijtech/prometheus-go-metrics-exporter

metrics name truncated

Looks like Christmas came early for you @yiyijin :) I've mailed out PR https://github.com/orijtech/prometheus-go-metrics-exporter/pull/5 which I shall merge in shortly then make a release. I'll then make a PR to the OpenCensus Agent and after that is made, you'll be on your way to using it without truncation.

yiyijin

comment created time in a day

PR opened orijtech/prometheus-go-metrics-exporter

sanitize: remove 100 byte key-length limit from OpenCensus

Removes the seemingly arbitrary 100 byte key-length that we pulled years ago from OpenCensus Go's sanitize function verbatim. Contextually those key length limits make sense for Stackdriver, but Prometheus doesn't mention the need for limiting key lengths (at least that I know of).

Fixes #4

+62 -34

0 comment

3 changed files

pr created time in a day

issue commentorijtech/prometheus-go-metrics-exporter

metrics name truncated

Hello there @yiyijin! Thanks for filing this issue.

If I recall correctly from 2017/2019, this is to protect and high cardinality labels as the limit for label key names by OpenCensus or Stackdriver, but indeed it truncates long names.

Since Prometheus doesn't seem to have a limit, perhaps we can/could remove this limit?

yiyijin

comment created time in a day

push eventgoogle/sqlcommenter

Emmanuel T Odeke

commit sha 9ed5cc0d0b10a320c4e1ecf86a0bccd9ad41baf8

all: update references to google sqlcommenter

view details

push time in a day

push eventorijtech/sqlcommenter-website

Emmanuel T Odeke

commit sha ca5bb82889e029315ec72488fee70643d4ca6bd7

ruby: move all references to google

view details

push time in a day

push eventorijtech/sqlcommenter-website

Emmanuel T Odeke

commit sha 2dc6d00b120587002d989827ad27d32fb1979b20

java: move all references to com.google.cloud.sqlcommenter

view details

push time in a day

startedtwitter/d3kit

started time in 3 days

startedNPashaP/Viz

started time in 4 days

startedhigsch/svelte-loves-d3

started time in 4 days

startedpeterrcook/d3-radialbar

started time in 4 days

startedpeterrcook/d3-circularheat

started time in 4 days

startedawbrown90/Advance-Lane-Finding

started time in 6 days

startedOanaGaskey/Extended-Kalman-Filter

started time in 6 days

startedgoogleapis/python-spanner

started time in 6 days

startedartix75/redis-cluster-proxy

started time in 6 days

startedkubernetes/ingress-gce

started time in 7 days

startedkubernetes/perf-tests

started time in 7 days

startedGoogleCloudPlatform/compute-image-tools

started time in 7 days

startedGoogleCloudPlatform/compute-image-packages

started time in 7 days

startedparkr/ping

started time in 7 days

push eventorijtech/spanner-benchmarking

Emmanuel T Odeke

commit sha b50b680b8277047a5adbc01eb42eb57b9e5e43b3

all: combine comparing source code into main.py

view details

push time in 7 days

push eventorijtech/spanner-benchmarking

Emmanuel T Odeke

commit sha fe7fb06696db305e036cf2b044887c991cb16644

all: combine comparing source code into main.py

view details

push time in 7 days

startedulikunitz/unixtime

started time in 8 days

issue closedgolang/go

time: (*Time).Unix not equal in location Asia/Shanghai

<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions -->

What version of Go are you using (go version)?

<pre> $ go version go version go1.13.8 windows/amd64 </pre>

Does this issue reproduce with the latest release?

always

What operating system and processor architecture are you using (go env)?

<details><summary><code>go env</code> Output</summary><br><pre> $ go env set GO111MODULE=on set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\小年糕\AppData\Local\go-build set GOENV=C:\Users\小年糕\AppData\Roaming\go\env set GOEXE=.exe set GOFLAGS= -mod= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GONOPROXY=git.windimg.com set GONOSUMDB=git.windimg.com set GOOS=windows set GOPATH=C:\gopath set GOPRIVATE=git.windimg.com set GOPROXY=direct set GOROOT=C:\goroot set GOSUMDB=sum.golang.org set GOTMPDIR= set GOTOOLDIR=C:\goroot\pkg\tool\windows_amd64 set GCCGO=gccgo set AR=ar set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD=C:\gopath\src\git.windimg.com\giantart\art-usercenter\go.mod set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Use rs\小年糕\AppData\Local\Temp\go-build796280254=/tmp/go-build -gno-record-gcc-switches

</pre></details>

What did you do?

<!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. -->

func Test_time_convert(t *testing.T) {
	tz, err := time.LoadLocation("Asia/Shanghai")
	assert.Nil(t, err)
	t1 := time.Date(1890, 01, 01, 0, 0, 0, 0, tz)
	fmt.Println(t1.Unix())

	t2 := time.Unix(t1.Unix(), 0)
	fmt.Println(t2)
}

What did you expect to see?

t2 print output is 1890-01-01 00:00:00 +0800 CST

What did you see instead?

1889-12-31 23:54:17 +0800 CST

btw:
I got this:
https://history.stackexchange.com/questions/8287/why-did-the-clocks-go-back-in-shanghai-on-december-31-1927
and it's means there was a timezone change since 1927.
BUT i try the code from 1890 to 1905,then found out in 1905 case ,t1 equals to t2. any help will be appreciated

closed time in 8 days

stubbornTanzhe

issue commentgolang/go

time: (*Time).Unix not equal in location Asia/Shanghai

Thank you @ulikunitz for owning this issue and for the answer, and thank you @stubbornTanzhe for the question. I shall close this issue then.

stubbornTanzhe

comment created time in 8 days

issue commentgolang/go

encoding/json: Unmarshal into struct field or a map does not validate invalid json.Number

Miha, could you please provide a minimal reproduction that doesn’t work and we can use that for a test case and perhaps for if/when we make a revert? Thank you.

On Tue, Feb 18, 2020 at 12:54 AM Miha Vrhovnik notifications@github.com wrote:

This change just broke the decoding of "field":"" which previously worked and the use of json.Number was on purpose. I don't have the option to change the json input I'm getting.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/golang/go/issues/14702?email_source=notifications&email_token=ABFL3V26WX2IDICKSIWWN4TRDOO4PA5CNFSM4B5NVC22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMBDUAI#issuecomment-587348481, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABFL3V3MXWFSJUT4DEAOC63RDOO4PANCNFSM4B5NVC2Q .

brenol

comment created time in 8 days

issue commentgolang/go

time: (*Time).Unix not equal in location Asia/Shanghai

Thank you for the report @stubbornTanzhe.

Kindly cc-ing @robpike.

stubbornTanzhe

comment created time in 8 days

issue closedgoogle/sqlcommenter

website: figure out how to properly generate static HTML from Hugo

We need to figure out how to properly generate HTML from the website itself that'll then be rendered properly by the content retrieved from the gh-pages here.

@smg727 you have access to the sqlcommenter-website that I created and it can be run locally by

hugo serve

or to generate HTML that'll be found in the /public directory

hugo

closed time in 8 days

odeke-em

issue commentgoogle/sqlcommenter

website: figure out how to properly generate static HTML from Hugo

Completed, thanks to @smg727’s help.

odeke-em

comment created time in 8 days

push eventorijtech/spanner-benchmarking

Emmanuel T Odeke

commit sha 1ee12ed8a72ba895f6e15808cca6c92651924d77

README: add performance graphs

view details

push time in 8 days

push eventorijtech/spanner-benchmarking

Emmanuel T Odeke

commit sha 6537070f515d47bdaf8d4d5540616e525e5bcc4a

README: add performance graphs

view details

push time in 8 days

push eventorijtech/spanner-benchmarking

Emmanuel T Odeke

commit sha b93155a0fa5ec79ea8a8339cb3d9762d20dbe7cc

all: added code

view details

push time in 8 days

push eventorijtech/spanner-benchmarking

Emmanuel T Odeke

commit sha 7003169216f713b1e6df678debb74d7fc7910a0d

all: added code

view details

push time in 8 days

create barnchorijtech/spanner-benchmarking

branch : master

created branch time in 8 days

created repositoryorijtech/spanner-benchmarking

Benchmarking utilities for Cloud Spanner tools

created time in 8 days

issue openedgoogleapis/python-spanner

spanner: unconsumed/uniterated StreamedResultSet doesn't send request to Cloud Spanner server

This is an issue that has plagued me for a while but I just got the time to make a repro.

Basically, if I try for example to invoke Transaction.execute_sql and do NOT consume the result e.g.

txn.execute_sql('DELETE from T1 WHERE 1=1')

instead of

res = txn.execute_sql('DELETE from T1 WHERE 1=1')
_ = list(res)

then the table will NOT be purged.

Seems like a bug to me with the underlying gRPC library, but it would be useful to explicitly document/call-out this bug if we don't have the bandwidth to fix it, to avoid unexpected problems for customers. It definitely sunk some hours for me in the past and also just right now.

created time in 8 days

startedgocd/gocd

started time in 8 days

startedtravis-ci/kubernetes-config

started time in 8 days

pull request commentcensus-instrumentation/opencensus-website

Support for Zenoss

You'll need to sign a CLA @rvykunta, then comment back here when you've signed it.

rvykunta

comment created time in 8 days

issue commentgolang/go

internal compiler error: 'main': schedule does not include all values in block b19

Thank you for the report @amarjeetanandsingh and welcome to the Go project! Thank you @mark-rushakoff for the initial investigation.

Indeed, as @mark-rushakoff confirmed, the problem starts with Go1.12 and from my investigation, it seems to have been caused by https://github.com/golang/go/commit/f062f48c1f8862ff0ef7baccf563497339129743 aka CL 165858 (/cc @randall77 @dr2chase) in the short circuiting logic. It then seems to have been fixed by @josharian's https://github.com/golang/go/commit/52ae04fdfc66664b327a4cb4057e339f132de8f9 aka CL 178197 for Go1.14 aka Go tip so it is already fixed. @amarjeetanandsingh, in the meantime please use Go1.14beta1 https://golang.org/dl/#unstable

go get golang.org/dl/go1.14rc1

Perhaps we might need some backports?

amarjeetanandsingh

comment created time in 10 days

startedspotify/chartify

started time in 10 days

push eventgoogle/sqlcommenter

Emmanuel T Odeke

commit sha 1518e18ddf10bb2fc2e6db22272626bfb43c2f5a

gh-pages: refresh from URL updates

view details

push time in 10 days

issue commentgolang/go

runtime: callstack seems fall into infinite loop with CGO on GOOS=linux GOARCH=arm64

Thank you @iswade for this report, the reproducing code and welcome to the Go project!

I’ll kindly loop in some CGO, runtime and arm64 experts: @randall77 @cherrymui @zhangfannie @aclements @ianlancetaylor

iswade

comment created time in 10 days

startedicza/golab

started time in 10 days

push eventorijtech/sqlcommenter-website

Uzondu Enudeme

commit sha 1bfd6c2fdefe11c402303f699fda8f30e676e821

naming: update module names in python docs - change repo name from github.com/orijtech/... to github.com/google/sqlcommenter - change python doc on PyPi to https://pypi.org/project/google-cloud-sqlcommenter - change imports from names - change middleware names to the google.cloud.sqlcommenter namespace

view details

Uzondu Enudeme

commit sha 2fcc292f13229f688da12cefca98c6fb35e55d55

naming/nodejs docs: update names to match project status - e.g. replace @sqlcommenter/knex to @google-cloud/sqlcommenter-knex

view details

Uzondu Enudeme

commit sha 02c41e3c7cee270aa96b4d3d97a1ef53c5f7cf4d

naming: update module names in python docs - change repo name from github.com/orijtech/... to github.com/google/sqlcommenter - change python doc on PyPi to https://pypi.org/project/google-cloud-sqlcommenter - change imports from names - change middleware names to the google.cloud.sqlcommenter namespace

view details

Uzondu Enudeme

commit sha 140327b09ffa6a4f82c510da14b84a9faa8a39aa

naming/nodejs docs: update names to match project status - e.g. replace @sqlcommenter/knex to @google-cloud/sqlcommenter-knex

view details

Uzondu Enudeme

commit sha 70987cceebc5f848cda196a254c2e38cfaaa028b

naming: merge fixes

view details

Emmanuel T Odeke

commit sha f0c2569d9b3102d9763909862dad09adc2c3ede5

Merge pull request #68 from willpoint/naming Naming: update links and package names/modules to match project state

view details

push time in 10 days

startedgoogle/perf_data_converter

started time in 11 days

startedpypa/warehouse

started time in 12 days

push eventorijtech/telemetry-perfbench

Nathan Dias

commit sha 9f2955d712aa523767dc18f8141952f8c0b0459a

add license file and license headers

view details

Nathan Dias

commit sha ffc73bc8cfe7c618886993d47f0e62d8383c41ae

update go get command to reference correct repository

view details

Emmanuel T Odeke

commit sha 6d2b147fbe74672a58ff0ceb3d0402477c4eab12

Merge pull request #4 from kirbyquerby/addcopyright add license file and license headers

view details

push time in 12 days

issue closedorijtech/telemetry-perfbench

all: add LICENSE header for Go Authors

We'll need to add a LICENSE header inside every .go file and also a LICENSE file in the main repository as the Go repositories do

Exhibits:

  • https://github.com/golang/go/blob/master/LICENSE
  • https://github.com/golang/go/blob/e237df5b53eb91d7a8d7247e7996f5edee6515b7/src/bufio/bufio.go#L1-L3

but obviously with the copyright year updated to 2020.

closed time in 12 days

odeke-em

push eventorijtech/sqlcommenter-website

Emmanuel T Odeke

commit sha 2f9386c1d4e66c0cd3a77a0ed0dec309dac09ce5

config.toml: hardcode baseURL and canonifyURL options Ensures that the site when hosted on Github Pages properly loads assets and images generated after invoking: hugo On other platforms though, without these configurations, they'll load alright, so perhaps we need to add a mental TODO to investigate why we need these options. Thanks to @smg727 for helping with figuring this out!

view details

push time in 12 days

push eventgoogle/sqlcommenter

Emmanuel T Odeke

commit sha 1c1031b8cb1fc84c852abefc5d54e62e352d3509

gh-pages: publish static HTML

view details

push time in 12 days

push eventgoogle/sqlcommenter

Emmanuel T Odeke

commit sha a5c9588d103bd605099c3fb401b67e5a96b262cd

gh-pages: publish static HTML

view details

push time in 12 days

push eventgoogle/sqlcommenter

Emmanuel T Odeke

commit sha 807647398f74ea3d38b0715869c88a7142967392

gh-pages: publish static HTML

view details

push time in 12 days

push eventgoogle/sqlcommenter

Emmanuel T Odeke

commit sha 10b3b9047230d0c2ba1a1eaa2a7d5e050cdd3c2f

gh-pages: publish static HTML

view details

push time in 12 days

push eventgoogle/sqlcommenter

Emmanuel T Odeke

commit sha 914263517bd1d2c9ea08bb6ff0d52c852a3ef893

gh-pages: publish static HTML

view details

push time in 12 days

push eventgoogle/sqlcommenter

Emmanuel T Odeke

commit sha 0ea8b478ddac01c891233d2b8f6756bcd110f3fc

gh-pages: publish static HTML

view details

push time in 12 days

push eventgoogle/sqlcommenter

Emmanuel T Odeke

commit sha db7c64860958513cf04e9d5dae3176e218fe0942

gh-pages: publish static HTML

view details

push time in 12 days

issue openedrs/logbench

comparisons: add x/tools/internal/telemetry to compare against

I just pinged @rs about the comparison work we did at https://github.com/orijtech/telemetry-perfbench and showed him the benchmarks at https://github.com/orijtech/telemetry-perfbench#benchstat-results

He let me know that we could also add our comparisons in here, so this issue is to explore adding them /cc @kirbyquerby @ianthehat. @kirbyquerby, please take a look at this issue.

created time in 12 days

issue commentodeke-em/drive

How can I get uploaded google drive id?

Unfortunately that option isn't directly there because we mostly want the names to mirror each other for synchronization. However, here is a hack to accomplish it

cat /path/to/local.mp4 | drive push -piped path/to/new_file_name.mp4

Unfortunately I currently don't have time and bandwidth, but otherwise it would be nice to have an option with a name change.

Hope this helps and thank you!

quydox

comment created time in 12 days

issue commentgoogle/sqlcommenter

website: figure out how to properly generate static HTML from Hugo

@balachandr the website source is https://github.com/orijtech/sqlcommenter-website and one can generate the public HTML just by

hugo

and then run the website by

hugo serve

and then visiting http://localhost:1313/

odeke-em

comment created time in 12 days

issue commentodeke-em/drive

How can I get uploaded google drive id?

Hello @quydox, thank you for the question and welcome to drive!

So the command to list is drive id <path> and it is documented in the README file at https://github.com/odeke-em/drive#retrieving-fileid

quydox

comment created time in 12 days

pull request commentbasecamp/marginalia

Customizable key-value separator and quoting

Kindly pinging @arthurnn @sharshenov to please take a look at this PR.

glebm

comment created time in 12 days

pull request commentbasecamp/marginalia

Customizable key-value separator and quoting

@balachandr I think he mailed PR https://github.com/basecamp/marginalia/pull/90 to fix the Travis build and that PR passes.

glebm

comment created time in 12 days

issue commentorijtech/telemetry-perfbench

all: add LICENSE header for Go Authors

/cc @ianthehat to check out the benchmarks too or at least be aware of this project.

odeke-em

comment created time in 12 days

issue openedorijtech/telemetry-perfbench

benchmarking: write script to automate step 'benchmarking locally'

In the README we have the steps https://github.com/orijtech/telemetry-perfbench/blob/master/README.md#benchmarking-locally, let's write a script to automate this.

/cc @kirbyquerby

created time in 12 days

issue commentorijtech/telemetry-perfbench

all: add LICENSE header for Go Authors

/cc @kirbyquerby

odeke-em

comment created time in 12 days

issue openedorijtech/telemetry-perfbench

all: add LICENSE header for Go Authors

We'll need to add a LICENSE header inside every .go file and also a LICENSE file in the main repository as the Go repositories do

Exhibits:

  • https://github.com/golang/go/blob/master/LICENSE
  • https://github.com/golang/go/blob/e237df5b53eb91d7a8d7247e7996f5edee6515b7/src/bufio/bufio.go#L1-L3

but obviously with the copyright year updated to 2020.

created time in 12 days

push eventorijtech/telemetry-perfbench

Nathan Dias

commit sha 5446ec6840bdd670ec0cb078f80348d81cc0099e

initial commit

view details

Nathan Dias

commit sha 3dca464deb25afecc0ba8c42e2501b10914f87d9

add initial README

view details

Nathan Dias

commit sha 40e626983b911bf6af80fdc4421f33c53e1fbb8a

Update readme to include command

view details

Nathan Dias

commit sha f2366ee04044cc8e0ff126bd66061e83ae670cd8

add zerolog benchmark

view details

Nathan Dias

commit sha 58d90e4c2c82ff018fe051cd5e7859a977503be2

Add results

view details

Nathan Dias

commit sha 284ec2719d508317fff2c4ea7f9c649c1abd9f63

improve instructions instructions now walk the user through which commands to run and how to benchmark internal/telemetry

view details

Nathan Dias

commit sha 8ff0ec50c14057c88c6e0ee08622c912829c4afd

Include instructions on how to get this repository

view details

Nathan Dias

commit sha d1919603e06a8ce92e379765022118c226bab5b9

Extract RunBenchmark to a separate file

view details

Nathan Dias

commit sha e817b84cb370af716b6ba0d48b79e55b2b80c724

Add tests for no log and stdlog

view details

Nathan Dias

commit sha dbd63f652e12958e56e673ff586463d6a7d6ce42

use a pointer to logger in zerolog

view details

Nathan Dias

commit sha e8f1d263bd9a0dab66c79bb02fa9844fc18331cf

Add sugared zap benchmark and update results

view details

Nathan Dias

commit sha f4168d9ea5f2f636d30baf44cc49227b8671a269

add space in CPU description so it doesn't render as an email address

view details

Nathan Dias

commit sha 22ebe9ac7f51130820911b1cbc54e549771f3abb

removed unused noopWriter

view details

Nathan Dias

commit sha 3fdb401ddab4162ca3b36706346ceabe5af95b11

make logger load test functions unexported

view details

Nathan Dias

commit sha fcb2c5eabeac3a33ad278f9540e5367cbc428292

make zap logger level match the level used for logging

view details

Nathan Dias

commit sha e8806ba3289943f4421ee9f0eb018977091d982b

add logrus benchmark

view details

Nathan Dias

commit sha 8370968c9fcb9dfdfd1dc77bad9b56c289b580e9

Add logrus results

view details

Nathan Dias

commit sha a05a84c601e6b51de57d370bf144ea50893ad287

update analysis

view details

Nathan Dias

commit sha b64a77851d0fc8c24c8835118022fe298a7a7430

add logrus to benchstat command

view details

Emmanuel T Odeke

commit sha 563bfd961cca722ffdbb3170aef1166f9b253ee7

Merge pull request #1 from kirbyquerby/source Add logger benchmarks

view details

push time in 12 days

create barnchorijtech/telemetry-perfbench

branch : master

created branch time in 12 days

created repositoryorijtech/telemetry-perfbench

Benchmarks and comparisons between various telemetry projects

created time in 12 days

issue commentgoogle/sqlcommenter

website: figure out how to properly generate static HTML from Hugo

Kindly pinging you @smg727 to help out here as I currently don't have bandwidth.

odeke-em

comment created time in 13 days

more