profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/nytai/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

mrblueblue/legendables 2

declarative legends for your charts

nytai/prolog-tic-tac-toe 1

A prolog implementation of tic-tac-toe for comp360-fall2014

nytai/cats 0

Some...cats

nytai/cats-re 0

Cats, in reason

nytai/dotfiles 0

Configs I cannot live without

nytai/mapbox-gl-js 0

Interactive vector maps in the browser, powered by WebGL

nytai/pepperoni-app-kit 0

Pepperoni - React Native App Starter Kit for Android and iOS

nytai/react-native 0

A framework for building native apps with React.

push eventnytai/dotfiles

Tai Dupree

commit sha f56374fe0101213b99c22a48dcc16106db1bf74c

typo

view details

push time in 10 days

push eventnytai/dotfiles

Tai Dupree

commit sha e16578088734a2ac19b5bcac028a675826fb77bb

update docs, brewfile, etc

view details

push time in 10 days

push eventapache/superset

cccs-joel

commit sha c6ac10716a8d2dfe222fb2b1639b8486c93687ce

feat: show build number value in the About if present in the config (#14955)

view details

push time in 11 days

PR merged apache/superset

feat: show build number value in the About if present in the config size/S

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

aboutafter

TESTING INSTRUCTIONS

Add a variable called BUILD_NUMBER in the config.py, the value should be displayed in the About section underneath the version/sha. No build information is shown if there is no variable BUILD_NUMBER in the config.py file.

ADDITIONAL INFORMATION

<!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->

  • [ ] Has associated issue:
  • [X] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API
+20 -3

13 comments

5 changed files

cccs-joel

pr closed time in 11 days

pull request commentapache/superset

feat: show build number value in the About if present in the config

@cccs-joel you might have to rebase your branch to fix, seems like some of the more recently opened PRs are not having issues.

cccs-joel

comment created time in 21 days

PullRequestEvent

PR closed apache/superset

feat: show build number value in the About if present in the config size/S

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

aboutafter

TESTING INSTRUCTIONS

Add a variable called BUILD_NUMBER in the config.py, the value should be displayed in the About section underneath the version/sha. No build information is shown if there is no variable BUILD_NUMBER in the config.py file.

ADDITIONAL INFORMATION

<!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->

  • [ ] Has associated issue:
  • [X] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API
+20 -3

10 comments

5 changed files

cccs-joel

pr closed time in 21 days

pull request commentapache/superset

feat: show build number value in the About if present in the config

Yes. I think there’s an issue with a pylint upgrade that’s currently affecting all PRs.

cccs-joel

comment created time in 21 days

issue commentapache/superset

[SIP-72] dataset RBAC

Superset already support this functionality to some degree via the edit roles view, dataset/datasource access can be granted to roles.

Screen Shot 2021-09-01 at 3 23 29 PM

Is this proposal mainly to improve this UI/workflow by adding this control directly on the dataset edit modal instead of in the edit roles menu?

shawnzhu

comment created time in 22 days

push eventnytai/dotfiles

Tai Dupree

commit sha 6b7ca77692a903efd249a85495f84d1eccab8b63

fix nvm

view details

push time in 22 days

PullRequestReviewEvent

Pull request review commentapache-superset/superset-ui

chore: isolate the one actual jquery dependency

 import { formatCellValue, formatDateCellValue } from './utils/formatCells'; import fixTableHeight from './utils/fixTableHeight'; import 'datatables.net-bs/css/dataTables.bootstrap.css'; -if (window.$) {-  dt(window, window.$);-}-const $ = window.$ || dt.$;+dt(window, $);

Does this break since $ will now be undefined.

suddjian

comment created time in 23 days

PullRequestReviewEvent

push eventapache/superset

Daniel Wood

commit sha e024f8c7d6251f4bfd4a6c5c2d23b1e3b2341e2a

fix: Set correct comparison operator for snowflake-sqlalchemy pinning (#16526)

view details

push time in 23 days

PR merged apache/superset

fix: Set correct comparison operator for snowflake-sqlalchemy pinning size/XS v1.3

SUMMARY

Fixes mistake in #16515

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

<!--- Skip this if not applicable -->

TESTING INSTRUCTIONS

<!--- Required! What steps can be taken to manually verify the changes? -->

ADDITIONAL INFORMATION

<!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API
+1 -1

1 comment

1 changed file

danielewood

pr closed time in 23 days

PullRequestReviewEvent

issue closedapache/superset

Having problem from creating new dashboard without having a chart associated with

Here’s what I did:

  1. Click the link on the first 2 screenshots
  2. I got the 3rd screenshot with uri /superset/dashboard/8/.
  3. Expand the See more on the right side, I got the 4th screenshot.
  4. When I go to /dashboard/list/, I can see the broken dashboard on the top as 5th screenshot.

Apparently, the new dashboard was created already, when I clicked both links in the first 2 screenshots. The problem comes from the API call /api/v1/dashboard/8/datasets due to dashboard created without charts as the 6th screenshot. The root cause of this error is the dashboard.datasources is an empty set throwing an exception at line 117 in file superset/dashboards/dao.py in the 7th screenshot. The following is the tracing code:

get_dashboard_and_datasets_changed_on, dao.py:116
<lambda>, api.py:279
wrapper, cache.py:181
dispatch_request, app.py:1936
full_dispatch_request, app.py:1950
wsgi_app, app.py:2447
__call__, app.py:2464
__call__, cli.py:337
debug_application, __init__.py:304
execute, serving.py:314
run_wsgi, serving.py:323
handle_one_request, serving.py:379
handle, server.py:427
handle, serving.py:345
__init__, socketserver.py:747
finish_request, socketserver.py:360
process_request_thread, socketserver.py:683
run, threading.py:870
_bootstrap_inner, threading.py:932
_bootstrap, threading.py:890

The same problem happens at line 94 on the same file (dao.py) when another api /api/v1/dashboard/8/charts is hit without charts on the dashboard shown as the 8th screenshot. To successfully create a new dashboard, I have to create a chart and then create a new dashboard from there as the 9th screenshot. I’m using superset 1.2 version. Does anyone have the same issue? Thanks. Screen Shot 2021-08-30 at 4 05 45 PM Screen Shot 2021-08-30 at 4 05 35 PM Screen Shot 2021-08-30 at 4 10 44 PM Screen Shot 2021-08-30 at 4 07 53 PM Screen Shot 2021-08-30 at 4 16 38 PM Screen Shot 2021-08-30 at 4 21 30 PM Screen Shot 2021-08-30 at 4 27 00 PM Screen Shot 2021-08-30 at 4 31 32 PM

closed time in 24 days

kevinwen2k

issue commentapache/superset

Having problem from creating new dashboard without having a chart associated with

This should be fixed in v1.3

kevinwen2k

comment created time in 24 days

issue commentapache/superset

Having problem from creating new dashboard without having a chart associated with

Nevermind, looks like this was fixed by https://github.com/apache/superset/pull/14450

kevinwen2k

comment created time in 24 days

issue commentapache/superset

Having problem from creating new dashboard without having a chart associated with

The seems to be triggered by this call https://github.com/apache/superset/blob/e2469162fa074af229ff97e845755caf1a29ca0d/superset/dashboards/api.py#L225

When DASHBOARD_CACHE feature flag is enabled.

cc @etr2460

kevinwen2k

comment created time in 24 days

PullRequestReviewEvent

Pull request review commentapache/superset

feat: show build number value in the About if present in the config

 def menu_data() -> Dict[str, Any]:     brand_text = appbuilder.app.config["LOGO_RIGHT_TEXT"]     if callable(brand_text):         brand_text = brand_text()+    build_number = ""+    try:+        build_number = appbuilder.app.config["BUILD_NUMBER"]+    except Exception as ex:+        logger.debug("BUILD_NUMBER is missing from the config", ex)

Yes, you need to get CI passing before we can merge

cccs-joel

comment created time in 25 days

PullRequestReviewEvent

pull request commentapache/superset

fix(explore): JS error for creating new metrics from columns

@ktmud yes, example https://github.com/apache/superset/pull/16329#issuecomment-901366987

ktmud

comment created time in a month

push eventapache/superset

Ke Zhu

commit sha fd6456186df07a14fad2007b39a4085fe43dc626

docs: make code snippet usable with required imports (#16473)

view details

push time in a month

PR merged apache/superset

docs: Make code snippet usable with required imports in configuration doc size/XS

SUMMARY

This is a problem surfaced from this thread in Slack

I try to config like https://superset.apache.org/docs/installation/configuring-superset#flask-app-configuration-hook but it fail with "session" not found

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

<!--- Skip this if not applicable -->

TESTING INSTRUCTIONS

When manually copying the code stanza under section Flask app Configuration Hook, it should not fail application starting.

ADDITIONAL INFORMATION

<!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API
+5 -1

0 comment

1 changed file

shawnzhu

pr closed time in a month

PullRequestReviewEvent

issue commentapache/superset

Better helm chart documentation for different releases

This is configurable https://github.com/apache/superset/blob/db11c3e6c829dbc4f103b58767cd2ca187a24b30/helm/superset/values.yaml#L143

shenrie

comment created time in a month

issue commentapache/superset

superset-websocket Error

You shouldn't need the superset-websocket service unless you plan to configure global async queries. You can probably just comment that out in your docker-compose file. Looks like your error is related to being able to reach the npm registry from your computer.

j0narch3r

comment created time in a month

PullRequestReviewEvent