profile
viewpoint
nurupo nurupo at irc://chat.freenode.net GPG: 1D4E 9375 AD9B D50F 80FF 55AC 6F55 0977 4B1E F0C2

nurupo/chrome-mouse-wheel-tab-scroller 28

Scroll Google Chrome tabs using mouse wheel

nurupo/paper-store 14

Cold store small files on paper as QR codes -- PGP keys, Bitcoin keys, Tox keys or any other small files in general.

nurupo/ci-release-publisher 5

A script for publishing Travis-CI build artifacts on GitHub Releases

nurupo/nfk-lobby 3

A lobby application for Need For Kill video game

nurupo/digitalocean-plugin 2

Jenkins DigitalOcean Slave Plugin

nurupo/docker-mumble 2

A nice and easy way to get a Mumble server up and running using docker.

abibas/webcamCaptureNewDesign 1

new design of the lib + with test app in Qt5

nurupo/asm-irc-logger 1

Simple IRC logger that produces logs that can be processed by irclog2html.py script to generate colorful HTML log pages.

nurupo/mingw-ldd 1

Lists dependencies of a PE (exe/dll) file

issue commentnurupo/vlc-pause-click-plugin

Plugin disfunctional on every VLC update?

and it was still in the correct folder

Are you sure that the plugin was still present in {VLC}\plugins\video_filter\ after the update? I thought that VLC updates essentially re-installed everything, removing all previously existing files, so the dll would be gone. I don't use Windows often, will need to check this later when I'm near a Windows PC.

stonecrusher

comment created time in 4 days

startedjosh-richardson/cadmus

started time in 11 days

startedSystemErrorWang/White-box-Cartoonization

started time in 12 days

pull request commentqTox/qTox

Fix gdb not being cached on Travis, resulting in it rebuilding every time

There.

nurupo

comment created time in 19 days

push eventnurupo/qTox

sudden6

commit sha 8768f6be3795d19a108432f56d0a691568364c07

refactor: remove unused OSX platform code

view details

Maxim Biro

commit sha a686468bfdaf7ecbed3dc5aabf522e9884cd1bb2

fix(build): cache debug deps during 2nd stage

view details

Maxim Biro

commit sha af78a42187faf96dcc2c278062975a5a23a5ac5a

refactor(build): remove specific string tests What we really want to test is if the variable is set/defined/non-empty.

view details

push time in 19 days

pull request commentqTox/qTox

Fix gdb not being cached on Travis, resulting in it rebuilding every time

Sure, no problem.

nurupo

comment created time in 19 days

PR opened qTox/qTox

Fix gdb not being cached on Travis, resulting in it rebuilding every time

I have made a silly mistake in the last PR https://github.com/qTox/qTox/pull/6169. gdb was meant to be built during stage2, but instead it is being built during stage3 which doesn't cache the deps, so gdb isn't getting cached and Travis keeps re-building it on every run. This additional [[ -n "$TRAVIS_CI_STAGE" ]] check should fix it.

+10 -5

0 comment

1 changed file

pr created time in 21 days

push eventnurupo/qTox

Maxim Biro

commit sha 9cef231149c809add99372a42581923af03d34b5

refactor(build): remove specific string tests What we really want to test is if the variable is set/defined/non-empty.

view details

push time in 21 days

create barnchnurupo/qTox

branch : fix-windows-travis-caching

created branch time in 21 days

pull request commentqTox/qTox

refactor: remove unused OSX platform code

Fixes https://github.com/qTox/qTox/issues/6179

(didn't notice this PR when opening the issue)

sudden6

comment created time in 21 days

issue openedqTox/qTox

MacOS build failure due to Qt 5.15.0 deprecating QProcess methods

Travis macOS builds are failing because brew updated their Qt version to 5.15.0, which deprecated some methods in QProcess class that are used in macOS platform code.

e.g. https://travis-ci.org/github/qTox/qTox/jobs/697032350#L9362

created time in 21 days

issue commentqTox/qTox

Is qtox-win.pkg.tox.chat still being used?

Removed.

nurupo

comment created time in 22 days

issue closedqTox/qTox

Is qtox-win.pkg.tox.chat still being used?

Was going over tox.chat's DNS records dong some clean up and saw qtox-win.pkg.tox.chat. Is it okay to remove that dns record? To my knowledge the server itself has been decommissioned (by oranges?) for long time now and is no longer used by qTox. I still have to ask, just in case, since you guys know better what is used and what is not.

closed time in 22 days

nurupo

issue commentsplitbrain/dokuwiki-plugin-upgrade

choosing release candidate instead of last stable

Yeah, updating to a RC version instead of the latest stable version is not what I want the upgrade plugin to do. Preferably you should be able to specify which version to upgrade to, but getting just the latest stable might be a good start.

Spockie

comment created time in 22 days

issue commentTox/tox.chat

Update Android clients

You should have the needed permissions now.

Monsterovich

comment created time in 22 days

issue commentTox/tox.chat

Update Android clients

Sure, what is your wiki username?

Monsterovich

comment created time in 22 days

issue commentTox/tox.chat

Update Android clients

For example: I don't like TCS avatars because they look bad that's why I implemented this popular library.

Hm, looks like the identicon algorithm was made by @zoff99 and then got added to TCS. Looks like no one considered searching for a popular identicon library at the time? Out of curiosity, is there a single-file algorithm for jdention somewhere? All implementations have it split between 20 files.

There are things that should be added to TCS. For example: mobile Tox clients should be able to export/import profiles or the user should have access to them. That's what Trifa doesn't have.

It does specify an export format, but you are right in that it misses a requirement of being able to import it, which is why you'd want to export in the first place.

By the way, we are reevaluating the requirement of TCS in a neighboring issue https://github.com/Tox/tox.chat/issues/224.

Hello. That's me.

Oh, hi! Didn't realize it was you, didn't see your username in the GitLab repo, it uses full name everywhere.

I'd say let's keep his issue on hold for now and see how the TCS reevaluation issue plays out.

Monsterovich

comment created time in 22 days

issue openedTox/tox.chat

Revisiting the requirement of TCS compliance

History

So, some history first.

What is TCS?

Tox Client Standard (TCS), started in 2015, is an attempt to improve interoperability between different Tox clients which also serves as a guide on best security practices. It discusses things like how ToxID should be represented by clients, how avatars should look like, how message text should be formatted/rendered, profile encryption, chat history encryption, common export format for profiles to be able to switch from one client to another, etc.

[GitHub repo] [Git Book]

To quote the Introduction section of it:

  • This document is intended to define behaviours that are not enforced by toxcore, but are otherwise required/recommended to ensure proper client interoperability as well as best security practices.

  • For a Tox client to be endorsed/supported by the Tox Project, it must, at minimum, comply with every [REQUIRED] point in this document (except where otherwise stated). For this reason, things that are [REQUIRED] should not be needlessly specific.

  • Sometimes, it is not immediately obvious why certain points exist in this document. For this purpose, there is a Rationale section, where explanations will be given.

TCS was created as a replacement of the Single Tox Standard (STS). The initial version was made by, if my memory serves right, stal, zero-one and JFreegman, and included a big chunk of STS in it.

Similar to STS's late efforts, TCS was made by getting various client developers together to discuss and vote on things, so it was meant as "by client developers for client developers" standard. If client developers strongly agreed that something needs to be standardized among clients, it would get voted in, and if they didn't strongly agree, it would be left out. Any client developers that wanted to participate in TCS could do so and their opinion would be heard out and considered.

TSC was being worked on by the TCS committee which consisted of iphy (Java reference client maintainer), JXP7 (XwinTox client maintainer), JFreegman (toxic client maintainer), stal (Poison client maintainer), BlameAliens (Antidote client maintainer), grayhatter (uTox client maintainer), tux3 (qTox client maintainer) and Impyy (Toxy client maintainer), with zero-one overseen it. There was also a TCS mailing list made for voting to take place (I think it was initially carried over on IRC/GitHub?).

In 2016 TCS compliance became required for clients that wanted to be listed on tox.chat, with clients that are already listed on it expected to comply with TCS in upcoming versions.

Fast forward a bit into the future -- TCS stayed active for some time but then all activity died out by the middle of 2016. TCS committee was disbanded later in 2016 due to client developers' inactivity on TCS -- no one seemed to want to work on it anymore, and since then it stayed mostly inactive.

Present Time

TSC is still considered to be a good standard by some and there wasn't any discussion on removing or replacing it, so it stayed as a requirement for clients to be added to tox.chat till this day.

Lately many clients listed on tox.chat have became abandoned, specifically Antox, Antidote and Ricin -- they had to be removed from the website (well, Antox is pending removal). With Antidote and Antox removed, we lost our only iOS and Android clients. Fewer and fewer new clients are being developed for Tox and there are no TCS complaint clients that could replace those removed clients. However, there are some Tox clients that don't comply with TCS that could replace them, notably there is TRIfA Android client, which seem to be strongly against complying with TCS, but is currently arguably the most popular Tox client for Android.

There are also concerns that with TCS being inactive it would be hard to modify TCS, and even if it's modified, it would be hard to enforce existing clients to comply with the additions/changes.

Due to these two points, I want us to revisit the requirement of TCS compliance. Should we:

  • Keep it as it is?
  • Replace it with something else?
  • Removed it?
  • Do something else?
  • (I assume there is no interest in resuming the work on TCS?)

@grayhatter, @IngvarX, @iphydf, @JFreegman, @robinlinden, @sudden6, @zer0-one, @zoff99 - want to hear your opinion on this.


p.s.: Actually, when writing this I thought there were more clients that wanted to be listed on tox.chat but refused to comply with TCS, but going through issues it sees like it was just TRIfA.

created time in 22 days

issue commentTox/tox.chat

Update Android clients

Yes, Antox needs to be removed, it seems to be abandoned. Although the repository doesn't state that clearly, the issues users submit are not getting replied/fixed by the developers and there wasn't any commit or a new version released in a while.

As far as adding new clients - it's a bit complicated. Clients need to pass TCS in order to be added to the client list. So Protox, Trifa and aTox need to be checked against TCS. The last time someone requested Trifa to be added, its developer said that it's not compliant with TCS, but that was some time ago, perhaps something has changed since then.

I have reached out to Trifa and aTox devs on IRC, asking if they think their clients are TCS compliant (and ready for general use in case of aTox). Will see what they reply. I was looking for Protox's dev, but it doesn't seem like they hang out on our IRC channels? I noticed they call their versions "alpha", so it's a similar situation to aTox where it might not be ready for general use yet.

Monsterovich

comment created time in 24 days

issue commentMaxKellermann/ferm

will there be support for nftables?

Oh, and forgot to add:

  • Listing multiple ports in a single line, e.g. using the $BASE_ALLOWED_INCOMING_TCP_PORTS from the above, creates multiple rules in ferm, but just one rule in nft. It's sometimes desired to have them as separate rules to have separate counters, which is impossible to do in a single line of nft, so you have to abandon using a variable/set and have to manually copy-paste the same rule for each port.
SvenVD

comment created time in 25 days

issue commentMaxKellermann/ferm

will there be support for nftables?

To add more to @horazont's comment, I just ported a ferm config to ntf and noticed that:

  • nft doesn't support using variables inside strings:

    define LOG_PREFIX = "[foo] "
    table inet filter {
        chain input {
            type filter hook input priority 0; policy drop;
            counter log prefix "$LOG_PREFIX DROP "
        }
    }
    

    Neither $LOG_PREFIX " DROP " nor $LOG_PREFIX" DROP " work.

    This seems to be impossible in nft.

  • nft, doesn't allow empty set variables, so the following is impossible:

    define BASE_ALLOWED_INCOMING_TCP_PORTS = {22, 80, 443}
    define EXTRA_ALLOWED_INCOMING_TCP_PORTS = {}
    table inet filter {
        chain input {
            type filter hook input priority 0; policy drop;
            tcp dport {$BASE_ALLOWED_INCOMING_TCP_PORTS, $EXTRA_ALLOWED_INCOMING_TCP_PORTS} ct state new counter accept
        }
    }
    

    It errors saying that } was unexpected and that EXTRA_ALLOWED_INCOMING_TCP_PORTS is not defined.

Overall nft feels like a downgrade from ferm.

SvenVD

comment created time in 25 days

issue openedqTox/qTox

Is qtox-win.pkg.tox.chat still being used?

Was going over tox.chat's DNS records dong some clean up and saw qtox-win.pkg.tox.chat. Is it okay to remove that dns record? To my knowledge the server itself has been decommissioned (by oranges?) for long time now and is no longer used by qTox. I still have to ask, just in case, since you guys know better what is used and what is not.

created time in 25 days

issue commentsqlcipher/sqlcipher

How to install the lib/dll/*.h to a custom folder on Windows?

When you run configure, pass --prefix="path\to\sqlcipher_lib\include" to it and just make install at the end to install whatever you have built in there. It's the well-known workflow to achieve that when dealing with gnu autotools. That's assuming you are using configure and make on Windows.

playgithub

comment created time in a month

startedfilipdutescu/modern-cpp-template

started time in a month

startedaul12/TemplateCpu

started time in a month

issue commentsemver/semver

What the version should be if only dependencies were updated?

Thanks, will read them.

I see that most of them talk about API and ABI changes, when in my case it's just a desktop GUI application, there is no API or ABI, it's supposed to be used directly by a human.

There is also the part that we are mixing two concepts together: code version and build version. It just happened that previously each software release had a corresponding Windows build made for it that used code's version as its name. But now we want to update our Windows builds with a new OpenSSL version, but we don't modify any code in our GUI application, it's literally identical, so there is no version change of the code, yet we want the binaries to have a version bump, which is what creates this confusion of how it should be handled. If we follow the advice of @jjlharrison and @jwdonahue, we end up releasing a build that is named v1.16.4 which, however, uses v1.16.3 code version, and in our git repository there is no v1.16.4 tag, there is only v1.16.3. So our code and build versions decoupled. So what happens next, when we modify our code and release v1.16.4 version of it, should we call the corresponding build v1.16.5 now? Or should have we made a v1.16.4 code release that is identical to v1.16.3 back when we were creating v1.16.4 build? But nothing has hanged in our code, and users on Linux, who get OpenSSL updates as part of their distro updates, would have no reason to update to v1.16.4, it would be a pointless update for them, it's identical to v1.16.3.

nurupo

comment created time in a month

startedcarlini/printf-tac-toe

started time in a month

issue closednurupo/vlc-pause-click-plugin

Not work with VLC 3.0.10

All copy to folder. Checked in interface. Checked in Video filters. Restarted few times by different ways, even with kill task. Nothing as result. Could you do installation pocket for this plugin? Apologize something goes wrong.

closed time in a month

VitaliyAT

issue commentnurupo/vlc-pause-click-plugin

Not work with VLC 3.0.10

Please fill out the bug report properly, with OS, plugin version, etc. and re-submit.

VitaliyAT

comment created time in a month

PR opened qTox/qTox

Build our own gdb

We have previously shipped debug Windows qTox with a pre-build gdb from https://sourceforge.net/projects/mingw-w64/files/External%20binary%20packages%20%28Win64%20hosted%29/gdb/. It seems kind of trustworthy, but it's better to build it ourselves. As a bonus, we get 10 years worth of improvements in gdb (the one we shipped was a version from 2010).

Feel free to review this PR, I have finished working on it. It's made on top of https://github.com/qTox/qTox/pull/6167 to make use of mingw-ldd.py and to avoid conflicts with that PR, so https://github.com/qTox/qTox/pull/6167 should be merged first, then I will rebase this on master.

+345 -57

0 comment

1 changed file

pr created time in a month

push eventnurupo/qTox

Maxim Biro

commit sha 2f6d3f443fd2e825a4145b398834b20c5bc1cfbc

chore(build): Update copyright year

view details

push time in a month

create barnchnurupo/qTox

branch : windows-build-gdb

created branch time in a month

push eventnurupo/mingw-w64-debug-scripts

Maxim Biro

commit sha c6ae689137844d1a6fd9c1b9a071d3f82a44c593

Remove gdb subdir as per README changes

view details

push time in a month

push eventnurupo/mingw-w64-debug-scripts

Maxim Biro

commit sha 862d8c3e65e311337d12e32156b1cb2c83d26a88

Bump copyright year

view details

push time in a month

push eventnurupo/qTox

Maxim Biro

commit sha bfa49df006ee33d8615e88bd2cd3952422b311cc

feat(windows): Make sure no dlls are missing

view details

push time in a month

push eventnurupo/mingw-w64-debug-scripts

Maxim Biro

commit sha 85da83c7be755ca711aa096e450ef68181ab8371

Add donation information

view details

Maxim Biro

commit sha 5108c7ca1240df56deb08fc22f6410af718dd68b

Remove Makefile, don't download gdb anymore

view details

Maxim Biro

commit sha c8a454f576de3f1f262af90a78fea8e961bf4bdc

Add gdb build example to README

view details

push time in a month

push eventnurupo/qTox

Maxim Biro

commit sha abdb786e041eb73d84a489c66c50b0600a82bacf

feat(windows): Make sure no dlls are missing

view details

push time in a month

issue commentTokTok/c-toxcore

where can i get offlineMessenger Bot Sourcecode

Don't know anything about it, you will have to ask Tok-Android's developers for the source. toxcore doesn't support offline messaging and has no such bot service.

AmerRaza

comment created time in a month

issue commentTokTok/c-toxcore

where can i get offlineMessenger Bot Sourcecode

What is Offline Messenger Bot?

AmerRaza

comment created time in a month

startedomarroth/invidious

started time in a month

issue commentytdl-org/youtube-dl

Twitch live streams fail with Error 410: Gone

This is a real issue, I have started experiencing the same HTTP 410 Gone issue too. It broke sometime within the last 8 hours, worked great before. To reproduce, simply try opening any Twitch channel with youtube-dl.

Salz

comment created time in a month

push eventnurupo/qTox

Maxim Biro

commit sha f5f42233cad3e84d895261c25d693c6da637ef01

fix: Usage of random - Seed random in Core Thread. Core Thread didn't seed random, resulting in always using the same bootstrap nodes, even when you restart qTox or change profiles. - Use QDateTime::currentMSecsSinceEpoch() for seeding random. It provides a bigger range of numbers than QTime::currentTime().msec() does, and the latter somehow managed to result in approximately the same first random number being generated, within a certain range. - Use something a it more sensible than a mod operation to bound random numbers within a range. It's not perfect either, but a lot better. Using mod on random skews its distribution too much. - Use QRandomGenerator's bounded() function to generate random values within a range. - Enable QRandomGenerator's usage starting with Qt 5.10.0. QRandomGenerator is present since Qt 5.10.0, not 5.15.0. - Bootstrap off every 5th node instead of two consecutive nodes. It's likely that two consecutive nodes will have the same owner, which makes some attacks more likely. The node selection algorithm should be scraped and redone from scratch to be honest though.

view details

push time in a month

PR opened qTox/qTox

Windows all dynamic linking

We discussed on IRC how Windows qTox builds have a mix of static and dynamic dependencies and that we perhaps should make them either fully static or fully dynamic. I have made them fully dynamic, as I figured it would be the easier to do -- no need to change qTox's code to add platform, image and style plugins with Q_IMPORT_PLUGIN macros. Also, wrote mingw-ldd to check if qTox has all dlls it needs before making a release.

+236 -32

0 comment

1 changed file

pr created time in a month

push eventnurupo/qTox

Maxim Biro

commit sha ef38c6b7b77f7ff1d37ae9fe50d997c421aa0311

feat(windows): Link all Windows deps dynamically

view details

Maxim Biro

commit sha bbd8d507febd49531f5b148e2a8185f3d2317b51

feat(windows): Make sure no dlls are missing

view details

push time in a month

PR opened qTox/qTox

fix: Usage of random
  • Seed random in Core Thread. Core Thread didn't seed random, resulting in always using the same bootstrap nodes, even when you restart qTox or change profiles.

  • Use QDateTime::currentMSecsSinceEpoch() for seeding random. It provides a bigger range of numbers than QTime::currentTime().msec() does, and the latter somehow managed to result in approximately the same first random number being generated, within a certain range.

  • Use something a it more sensible than a mod operation to bound random numbers within a range. It's not perfect either, but a lot better. Using mod on random skews its distribution too much.

  • Use QRandomGenerator's bounded() function to generate random values within a range.

  • Enable QRandomGenerator's usage starting with Qt 5.10.0. QRandomGenerator is present since Qt 5.10.0, not 5.15.0.

  • Bootstrap off every 5th node instead of two consecutive nodes. It's likely that two consecutive nodes will have the same owner, which makes some attacks more likely. The node selection algorithm should be scraped and redone from scratch to be honest though.

  • [ ] Commits follow our git commit guidelines

+23 -17

0 comment

2 changed files

pr created time in a month

create barnchnurupo/qTox

branch : windows-all-dynamic-linking

created branch time in a month

create barnchnurupo/qTox

branch : improve-random

created branch time in a month

created tagnurupo/mingw-ldd

tagv0.2.0

Lists dependencies of a PE (exe/dll) file

created time in a month

push eventnurupo/mingw-ldd

Maxim Biro

commit sha a3b93e5e73cb9cf85698d4f53f68fd792e1e5936

Bump to v0.2.0

view details

push time in a month

delete tag nurupo/mingw-ldd

delete tag : v0.2.0

delete time in a month

created tagnurupo/mingw-ldd

tagv0.2.0

Lists dependencies of a PE (exe/dll) file

created time in a month

push eventnurupo/mingw-ldd

Maxim Biro

commit sha 647bba67bfe564e18bec6ee8482c1bfa67343807

Add multiprocessing support to speed up PE parsing

view details

Maxim Biro

commit sha d8f54abe0df93f673af9d64b315feab876e3b661

Update README.md

view details

push time in a month

push eventnurupo/mingw-ldd

Maxim Biro

commit sha 0fa5b8fe39d8bd4da8bb0eeffa7f1f31f3e9506b

WIP

view details

Maxim Biro

commit sha c755de6216cd1639c3d29ef6a2aeeeb63909d71e

WIP2

view details

Maxim Biro

commit sha 767f5d9398314cad4ee8a06e3c4d94802968cb68

WIP3

view details

push time in a month

startedelectronicarts/CnC_Remastered_Collection

started time in a month

push eventnurupo/mingw-ldd

Maxim Biro

commit sha 7d82fe7ed893c642bf4f4ca6e75e1f66902bbf7b

Avoid duplicate PE parsing

view details

push time in a month

pull request commentTokTok/c-toxcore

chore: Cygwin build

I have pushed some commits to redmanmale-cygwin-build branch, fixing restyled, CodeFactory and Codacy issues (man, iphy went overboard with these checks!), rewording INSTALL.md and rebasing on master.

I meant to ask to replace contents of PR ranch with my branch. It has been rebased on master, so it won't merge cleanly on top of the PR branch, you would need to undo your commits git reset --hard HEAD~5 and then it would merge. You would need to force-push afterwards.

I can open a PR on my own if that's easier on you.

redmanmale

comment created time in a month

push eventnurupo/mingw-ldd

Maxim Biro

commit sha 067cbee199424cf01aeaf11c3320adee63c78584

Fix Travis-CI

view details

push time in a month

created tagnurupo/mingw-ldd

tagv0.1.0

Lists dependencies of a PE (exe/dll) file

created time in a month

push eventnurupo/mingw-ldd

Maxim Biro

commit sha 1077ee90700216fdd97e1bf1e155eb3e54696686

Update README.md

view details

push time in a month

push eventnurupo/mingw-ldd

Maxim Biro

commit sha 909f42c40ffd1b7c2e70468c98cab43577aa7203

Update README.md

view details

push time in a month

create barnchnurupo/mingw-ldd

branch : master

created branch time in a month

created repositorynurupo/mingw-ldd

Lists dependencies of a PE (exe/dll) file

created time in a month

fork nurupo/mingw-ldd

Tool to list dependencies of a DLL

fork in a month

issue commentTokTok/c-toxcore

build error

@Joey5460 /usr/local is for self-built software, not for distro-packaged, so that's not Fedora's libsodium you have in there. pkg-config doesn't look in /usr/local by default. Obviously, if you have toxcore dependencies installed all over your system, you need to tell pkg-config where to look for them in order to build toxcore, which is done using PKG_CONFIG_* env variables.

KORuL

comment created time in a month

pull request commentTokTok/c-toxcore

chore: Cygwin build

I have pushed some commits to redmanmale-cygwin-build branch, fixing restyled, CodeFactory and Codacy issues (man, iphy went overboard with these checks!), rewording INSTALL.md and rebasing on master.

redmanmale

comment created time in a month

push eventnurupo/InsertProjectNameHere

Robin Linden

commit sha 56992b099eb5b77adfca15678ada9ec4011d8dd3

Add support for the conan C/C++ package manager * Don't overwrite the CMAKE_MODULE_PATH * Allow linking libsodium statically with MSVC * Allow finding libsodium the normal way on MSVC * Allow using pthreads4w for pthreads on MSVC * Fall back to find_package if pkg_find_module fails * Don't pass incompatible compile flags to MSVC * Also try to find Opus and libvpx using their canonical names * Support building using conan * Allow pkg_use_module to take a list of libraries to look for * Build for Windows on Appveyor using conan

view details

redmanmale

commit sha 787aa6304cbd151426f41b5e67a03b68dfccbdfa

Tweak Windows scripts to use Cygwin

view details

redmanmale

commit sha 5e11b2c36df2ac5eb39572dfed12b1d7c2c1e261

Update build docs for Cygwin

view details

Maxim Biro

commit sha 84e156bfca9413e7e7c8d70a7f23e1f3b7be4b33

Fix Codacy warnings

view details

Maxim Biro

commit sha b15c04735ef08c0959db4b11566b375502c6a4cf

Reword Cygwin section of INSTALL.md

view details

Maxim Biro

commit sha de0e4912722a1982ece22fa1fb72fb5a47d672a6

Fix CodeFactor issues

view details

Restyled.io

commit sha 15e4e93aa6abe3bba0e11401e459e89b7f74b0dc

Restyled by shellharden

view details

Restyled.io

commit sha 8f870daca594b6e227b6dc9d00ae488e22dcc51a

Restyled by shfmt

view details

push time in a month

create barnchnurupo/InsertProjectNameHere

branch : redmanmale-cygwin-build

created branch time in a month

pull request commentTokTok/c-toxcore

chore: Cygwin build

Huh, GitHub doesn't want to work with me.

$ git push git@github.com:redmanmale/toxcore.git redmanmale-cygwin-build:cygwin-build
ERROR: Permission to redmanmale/toxcore.git denied to nurupo.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

No idea why I'm unable to add commits to the PR branch.

redmanmale

comment created time in a month

pull request commentTokTok/c-toxcore

chore: Cygwin build

@redmanmale could you check "Allow edits by maintainers" checkbox on this PR? Want to try resolve Codacy issues. It should be under the participant list.

redmanmale

comment created time in a month

issue commentTokTok/c-toxcore

Are tox clients also open source

Security / privacy should be encoded in Tox protocol itself to work in untrusted environment.

Tox protocol can be the most secure/private protocol there is, but it can't stop a client from simply sending a copy of your message to e.g. Chinese government before passing it over to toxcore. So aside from trusting the Tox protocol you also have to trust the client application not to be malicious, which is a lot easier to do if it is open source, as that makes it a lot easier to examine what the client does, and it also allows to build a binary off of the verified source code instead of trusting that the pre-built client used this exact source code, as it could have been built with some unpublished backdoor patches added on top.

Bold statement. For example,

ugintl

comment created time in a month

PR opened qTox/qTox

Update Windows dependencies

A few notes on the changes:

  • libexif has finally made a release since 2012, fixing several CVEs
  • looks like the SQLCipher version update made some of our patches obsolete
  • it would be nice to move away from the openal-soft fork when (and if) the loopback capture gets merged upstream

Tested by loading an empty profile in qTox i686 release in wine and browsing settings, so basically just tested that it doesn't crash on startup.

+14 -32

0 comment

1 changed file

pr created time in 2 months

push eventnurupo/qTox

sudden6

commit sha 1ac7531b591f7cb8eab2359f77c9a94e7b48834a

chore: update sqlite to 4.3.0

view details

sudden6

commit sha 4c79973df5a968a9454005afb862a5579538ef9c

chore: update libsodium for CI builds

view details

sudden6

commit sha a4ac178bbd767b3e990ad0e8f5da5e6cabef48e2

chore(deps): update c-toxcore to v0.2.11

view details

Anthony Bilinski

commit sha 4a81bb1cb50de62ab2642735e8177e23f67a3357

chore(windows): update OpenSSL to 1.1.1f

view details

sudden6

commit sha b7ecf0299552bae9302a9c9320ece78e974587eb

chore(nodes): update bootstrap nodes and tools Add a script to update bootstrap nodes from nodes.tox.chat. Update maintainer instructions for release.

view details

bodwok

commit sha d01fed92f08dfaf9ed8a54fdc275b51b22b56ba7

fix(ui): updating friends list color at runtime

view details

Anthony Bilinski

commit sha 6e2ac12d84df141b85b427765a74a704146d5b70

fix(avatar): reject avatars that are larger than 64KB This will prevent qTox from auto-accepting arbitrarily large avatars. Avatars are already limited by TCS 2.2.4 to 64KB, so we would only receive larger avatars from badly behaving clients.

view details

Anthony Bilinski

commit sha 9888bc2d8072f0360a10ba32b6a5834668f0349f

fix(build): disable Werror by default, keep enabled on CI To allow for easier building with different compilers on user systems. Keep strict checks on CI to make sure new warnings aren't ignored.

view details

Anthony Bilinski

commit sha 5da1e4b9a88db60048147fbf63af09607326cffd

revert(chatlog): "enable dynamic view range in chatlog with history disabled" This reverts commit a7f349595696b3292897ac72b5cffb05b7300eda.

view details

Anthony Bilinski

commit sha b04639c6d0eb4583ead66fff21f7416996867b14

revert(chatlog): "fix stick to bottom behavior" This reverts commit f2fa601073373ae2ef9fba7952aed415af3ccee0.

view details

Anthony Bilinski

commit sha 5d44cd773f8bb35799c9e66863cc4c18315da2da

revert(chatlog): partially revert "prevent invalid history access" This partially reverts commit e3e6e1d9c4e22d6f090f153628677ad427cf4900.

view details

Anthony Bilinski

commit sha efff8d53c9b06f592493a9729cc6b226c2ad10d3

revert(chatlog): "add comments for functions that load history" This reverts commit 5fc1afbab51d06133e2fc1a05d6ef0e8f175ff86.

view details

Anthony Bilinski

commit sha 4cd443ae7ba364b5d2c803b3019c12048956363d

revert(chatlog): "scroll bar stuck to bottom (fix #5755)" This reverts commit 38df897e024393ba15c80017930dac19a92e13b7.

view details

Anthony Bilinski

commit sha 306bbb424e7ed5879df0518056b9aaf5e0176523

revert(chatlog): "update workerStb" This reverts commit 177bf12f1150a842e5263eb573fe110fb717ea5a.

view details

Anthony Bilinski

commit sha 83d5863bbe84572bfd00c3fbef9ced4765e20099

revert(chatlog): "optimize load messages during the search" This reverts commit 6de307e6b98eb8aa9b583c55e4fa19c5c06534c9.

view details

Anthony Bilinski

commit sha c1d0624b5d755580278cbc27ed252377377b8952

revert(chatlog): "feat: save selected search text after scrolling up" This reverts commit dbf880078e8b3207bf5c4f057bc6071b4c74b9ce.

view details

Anthony Bilinski

commit sha 6395ce3aaef2b6fd28d7940212b384ec5dd69141

revert(chatlog): "feat: check chat status before start a search" This reverts commit ce570927b145676ff3a63f36a3fe082fa52b228a.

view details

Anthony Bilinski

commit sha 35c5e77a8a7e6854a74c75013c40d1e478599ea9

revert(chatlog): "fix: data validation during the search" This reverts commit acb91ed731bece1fbdac90064446c61ab68b721f.

view details

Anthony Bilinski

commit sha 3ac6b578df681275aedb1d182a7034fa495ccb27

revert(chatlog): "fix a crash when there are no messages to load" This reverts commit 040c6b95aed26dfc7950770ed4dca379e8be2bc5.

view details

Anthony Bilinski

commit sha bd0ef5de8261bf727e06a9484877feccb6696f03

revert(chatlog): "prohibition to remove messages in group chat" This reverts commit 5aeac56b761ad24b6a2829fca499b8eff480a306.

view details

push time in 2 months

pull request commentkcat/openal-soft

WIP: Add WASAPI loopback capture devices

This would be very useful addition to OpenAL-Soft, thank you for the work!

By the way, it would seem like you have unnecessarily changed the whitespace formatting in the CaptureDevices section, e.g. & in

[name](const DevMap &entry) -> bool

vs

[name](const DevMap& entry) -> bool

and

std::wstring wname{utf8_to_wstr(name)};

vs

std::wstring wname{ utf8_to_wstr(name) };

and maybe more. These changes also got carried over to the new LoopbackDevices section.

CalcProgrammer1

comment created time in 2 months

push eventnurupo/vlc-pause-click-plugin

Maxim Biro

commit sha 049fa152969579a55c1bbba97f1771ae30d30062

Update a screenshot to display the refactored menu

view details

Maxim Biro

commit sha b7289740fa48109b22291830197eaa960f72d168

Update download links

view details

push time in 2 months

push eventnurupo/vlc-pause-click-plugin

Maxim Biro

commit sha b7289740fa48109b22291830197eaa960f72d168

Update download links

view details

push time in 2 months

release nurupo/vlc-pause-click-plugin

2.2.0

released time in 2 months

created tagnurupo/vlc-pause-click-plugin

tag2.2.0

Plugin for VLC that pauses/plays video on mouse click

created time in 2 months

delete tag nurupo/vlc-pause-click-plugin

delete tag : 2.2.0

delete time in 2 months

created tagnurupo/vlc-pause-click-plugin

tag2.2.0

Plugin for VLC that pauses/plays video on mouse click

created time in 2 months

delete tag nurupo/vlc-pause-click-plugin

delete tag : 2.2.0

delete time in 2 months

created tagnurupo/vlc-pause-click-plugin

tag2.2.0

Plugin for VLC that pauses/plays video on mouse click

created time in 2 months

push eventnurupo/vlc-pause-click-plugin

Maxim Biro

commit sha 049fa152969579a55c1bbba97f1771ae30d30062

Update a screenshot to display the refactored menu

view details

push time in 2 months

push eventnurupo/vlc-pause-click-plugin

Maxim Biro

commit sha fb51bd3574e4d2ccda0bde9f0e68026462a46052

Avoid processing pressed mouse move events Pressing and holding a mouse button and moving the mouse around caused us to process those events when there is nothing we were doing on them.

view details

Maxim Biro

commit sha c91db8bbb1d89aa1405d3d3429ba9c2b5cdaecb2

Fix double clicking logic working with any button Double clicking can occur only with the left mouse button, so it makes no sense to apply that logic to any other mouse button.

view details

Maxim Biro

commit sha b2dc57ffbea457c7a998d493a12fb4887e7b1035

Fix incorrect comment That wasn't the actual reason for why it worked. The reason is that VLC doesn't set the left mouse button as pressed on the second click of a double click. This is consistent across platforms. Well, at least for Windows and Plasma on Xorg, can't easily test anything else.

view details

Maxim Biro

commit sha 22bb6d0240720348a336788779c8f6c5376b2baf

Fix the option for ignoring double clicks That option had a rather weird behavior. It was made so that the video wouldn't pause on the double click, when a used supposedly wants to fullscreen the video instead. It would ignore the first click, assuming that it could be the first click of a double click, and it would wait the specified <double click interval> milliseconds for the second click. If there was no second click when the time runs out, the plugin realizes that it was a single click and pauses/plays the video. However, if a second click did happen within that time interval, then it won't pause/play it. It all makes sense aside from the user having to specify the double click interval. It's actually system dependent and VLC provides no facility to query what that interval is, so we rely on the user to provide a good guess. This can result in a weird behavior if user's guess is not good enough, as the double-click-to-fullscreen happens using system's double click interval. For example, if the system double click interval is 300ms, but the user set it in the plugin as 200ms, then when the user double clicks with the clicks being 250ms apart, the plugin won't recognize it as a double click causing the video to pause/play, but the system will recognize it as a double click, causing the video to fullscreen at the same time. With this change we eliminate the OS-specific double click interval and instead make fullscreen happen at the user-specified double click interval, which solves this interval inconsistency issue. It additionally allows the user to control the double-click-to-fullscreen interval, making it shorter or longer, which wasn't possible before.

view details

Maxim Biro

commit sha 658d3ea863bae24e22ac64acbfbe13d8d6ba620c

Add an option to control double click interval It might be useful to be able to change the double click interval without ignoring double clicks, e.g. to make the fullscreen time interval smaller. Some option description had to be changed, but they essentially do the same thing, so it's not a breaking change.

view details

Maxim Biro

commit sha 1bcc9081dc9c9aea6ee684301c0b739df092b801

Group options in sections There are so many options that it's starting to get confusing. Grouping is supposed to help with that.

view details

Maxim Biro

commit sha 6ebc0c5affc2904d09a9ca744bf546642e99bd01

Update donation information

view details

Maxim Biro

commit sha 95d4fb803df7118d2ec747fd3a99e729886d10d4

Add more issue templates

view details

Maxim Biro

commit sha 0a44a8fd780ea6d7bf89e033f3555bb2ebf3d8a1

Add a pull request template

view details

Maxim Biro

commit sha b6ab545a1a84363c49055d7d71bd23732407675e

Bump copyright year

view details

Maxim Biro

commit sha fd22509b4a13b0da5fad8fb645303f6506ee7592

Fix argument marked as unused

view details

Maxim Biro

commit sha ea80dcb81c8f6f55b3ac38c6248e4a34b6f28de5

Revert "Avoid processing pressed mouse move events" This reverts commit fb51bd3574e4d2ccda0bde9f0e68026462a46052. Caused a regression: the option to disable the context menu pop up has stopped working.

view details

Maxim Biro

commit sha fd1f37cb45d5067a7c05a73f39960b0e409edda3

Clarify option descriptions

view details

Maxim Biro

commit sha 54403f96d3bd82dfc64fe154c7b2c79c707be334

Bump copyright year

view details

push time in 2 months

push eventnurupo/vlc-pause-click-plugin

Maxim Biro

commit sha fd1f37cb45d5067a7c05a73f39960b0e409edda3

Clarify option descriptions

view details

Maxim Biro

commit sha 54403f96d3bd82dfc64fe154c7b2c79c707be334

Bump copyright year

view details

push time in 2 months

delete branch nurupo/vlc-pause-click-plugin

delete branch : fix-ignore-double-click

delete time in 2 months

issue closednurupo/vlc-pause-click-plugin

fullscreen double-click speed doesn't do anything (?)

Windows 10, 64-bit VLC v3.0.10, 64-bit

Tools -> Preferences -> All -> Video -> Filters -> Pause click -> Double click interval (ms)

No matter how quick I set the double-click to be, the window still seems absolutely massive. Like half a second or more, resulting in loads of unwanted fullscreen toggles. Changing how many milliseconds doesn't seem to change anything at all. Am I doing something wrong here?

closed time in 2 months

nr1995

issue commentnurupo/vlc-pause-click-plugin

fullscreen double-click speed doesn't do anything (?)

Cool, glad it worked for you.

Note that that test build has a small regression: the option to disable the context menu pop up doesn't work properly. It's fixed in the master branch and will be fixed in the upcoming release.

nr1995

comment created time in 2 months

Pull request review commentTokTok/c-toxcore

chore: Cygwin build

 #!/usr/bin/env sh -set -e -x+# disable on Cygwin otherwise some builds fail

What's the error you are getting?

redmanmale

comment created time in 2 months

Pull request review commentTokTok/c-toxcore

chore: Cygwin build

 build()     do         ${WINDOWS_TOOLCHAIN}-ar xv ${archive}     done++    if [ "${CROSS_COMPILE}" = "true" ]; then+        LIBWINPTHREAD_DIR="/usr/${WINDOWS_TOOLCHAIN}/sys-root/mingw/lib/libwinpthread.a"

Name ends in _DIR, yet contains a path to a file rather than a dir.

redmanmale

comment created time in 2 months

PR closed Tox/tox.chat

Update download.html
+1 -0

1 comment

1 changed file

silvioprog

pr closed time in 2 months

pull request commentTox/tox.chat

Update download.html

tox-rs is not a language binding, it's an entire tox re-implementation, so it doesn't fit that section.

silvioprog

comment created time in 2 months

issue closednurupo/vlc-pause-click-plugin

Add margin on area where the plugin operates to avoid play/pause while seeking

Self-troubleshooting
Software

OS: Windows / Linux / macOS : Windows 10 VLC version: 3.0.10 VLC bitness: 64 Plugin version: 3.0 Plugin bitness: 64

Issue description

It's not an issue but feature request I'm able to use the plugin and while it works flawlessly, the video pauses many a time while seeking because the mouse pointer is slightly above seekbar (just touching the video area) while clicking.

I think it'll be better to reduce the clickable area to something like 20-50 pixel above the seekbar (maybe similar margins below the Menu bar? ) or provide such a setting to the user to modify the same.

closed time in 2 months

tarun0

issue commentnurupo/vlc-pause-click-plugin

Add margin on area where the plugin operates to avoid play/pause while seeking

After a closer look, this feature request is a no go. It doesn't make much sense for the plugin to implement a workaround for user's inability to properly aim their mouse cursor at the seek bar. Many popular players have a seek bar right next to the video image that pauses when clicked on: YouTube's web player, MPC-HC, etc., so it's not something unique to VLC. More so, VLC provides a visual cue of whether a user mouses over a seekbar by displaying a timestamp tooltip, which is hard to miss. Apart from it not making sense to implement in the first place, it would also unnecessarily complicate the already complex plugin (due to having to add exceptions to the double click behavior logic and implementing a sub source submodule). I see no good reason to implement it.

tarun0

comment created time in 2 months

push eventnurupo/vlc-pause-click-plugin

Maxim Biro

commit sha ea80dcb81c8f6f55b3ac38c6248e4a34b6f28de5

Revert "Avoid processing pressed mouse move events" This reverts commit fb51bd3574e4d2ccda0bde9f0e68026462a46052. Caused a regression: the option to disable the context menu pop up has stopped working.

view details

push time in 2 months

push eventnurupo/vlc-pause-click-plugin

Maxim Biro

commit sha fd22509b4a13b0da5fad8fb645303f6506ee7592

Fix argument marked as unused

view details

push time in 2 months

issue commentnurupo/vlc-pause-click-plugin

fullscreen double-click speed doesn't do anything (?)

Here is one vlc-3.0-64bit-win.zip based on the master branch, with

but I will make it possible to adjust the fullscreen interval without it ignoring double clicks later, as an option

added and

re-structure the settings page

done.

nr1995

comment created time in 2 months

delete branch nurupo/vlc-pause-click-plugin

delete branch : check-travis-ci

delete time in 2 months

delete branch nurupo/vlc-pause-click-plugin

delete branch : test

delete time in 2 months

push eventnurupo/vlc-pause-click-plugin

Maxim Biro

commit sha 95d4fb803df7118d2ec747fd3a99e729886d10d4

Add more issue templates

view details

Maxim Biro

commit sha 0a44a8fd780ea6d7bf89e033f3555bb2ebf3d8a1

Add a pull request template

view details

Maxim Biro

commit sha b6ab545a1a84363c49055d7d71bd23732407675e

Bump copyright year

view details

push time in 2 months

more