profile
viewpoint

nodejs/diagnostics 407

Node.js Diagnostics Working Group

nodejs/citgm 354

Canary in the Gold Mine

nodejs/build 290

Better build and test infra for Node.

nodejs/abi-stable-node-addon-examples 226

Node Add-on Examples with PoC ABI stable API for native modules

nodejs/abi-stable-node 219

N-API — Node with PoC ABI stable API for native modules.

nodejs/community-committee 205

The Node.js Community Committee (aka CommComm)

nodejs/changelog-maker 183

A git log to CHANGELOG.md tool

nodejs/code-and-learn 159

A series of workshop sprints for Node.js.

nodejs/docker-iojs 158

Official Docker images from the io.js project

nodejs/benchmarking 152

Node.js Benchmarking Working Group

Pull request review commentnodejs/node

module: allowed module location list

 If this flag is passed, the behavior can still be set to not abort through [`process.setUncaughtExceptionCaptureCallback()`][] (and through usage of the `domain` module that uses it). +### `--allowed-module-location`+<!-- YAML+added: REPLACE_ME
added: REPLACEME
bzoz

comment created time in 6 minutes

issue openednodejs/node

add `writable` and `readable` to `new stream.Duplex(options)` docs.

maybe that's the reason we don't get the option to set writable and readable property as options while creating a new Duplex.

That option actually does exist and should be used. It's just not documented, which we should fix.

Originally posted by @ronag in https://github.com/nodejs/node/issues/34374#issuecomment-658714356

created time in 4 minutes

pull request commentnodejs/node

[v14.x] deps: update V8 to 8.4

@targos I did mean to push that, apologies if it complicated things. There was a conflict due to a V8 change that landed on staging

targos

comment created time in 5 minutes

pull request commentnodejs/node

[v14.x] deps: update V8 to 8.4

I'll try to do it 👍

targos

comment created time in 7 minutes

issue commentnodejs/gyp-next

Add type information

I'm not used to Python and have never worked with typing, so my opinion wouldn't be very informed. I work with TypeScript though and do like type annotations, so I'm not opposed to that if it makes it easier / safer to develop and if it can be introduced incrementally.

ryzokuken

comment created time in 7 minutes

issue commentnodejs/node

N-API: implement something like `yield`

I agree – I don’t think it makes sense to bake this into N-API unless we can actually provide a better implementation than one that just implements the sync (and async) iterable protocol(s) naïvely. For that kind of implemention, one could implement this in a header library separate from N-API itself.

That would have the advantage of accounting for language-specific differences as well; for example, the C++ iterable protocol differs quite a bit from the JS one. A C++ header library would be able to map those between another via N-API.

@nodejs/n-api

WillerZ

comment created time in 9 minutes

pull request commentnodejs/node

tools: update gyp to 0.4.0

I did upstream the changes from https://github.com/nodejs/node/pull/32867. The conflict seems to be because of quote style (I suppose it changed automatically when I saved the file in VS Code). Anyway, we probably don't need to change anything in gyp-next or make a new release.

ryzokuken

comment created time in 10 minutes

Pull request review commentnodejs/node

[v14.x backport] modules: deprecate module.parent

 changes:  Type: Documentation-only 

[`socket.bufferSize`][] is just an alias for [`writable.writableLength`][].

aduh95

comment created time in 12 minutes

pull request commentnodejs/node

v10.22.0 proposal

CITGM: https://ci.nodejs.org/job/citgm-smoker/2417/

richardlau

comment created time in 12 minutes

Pull request review commentnodejs/node

[v14.x backport] modules: deprecate module.parent

 changes:  Type: Documentation-only -[`socket.bufferSize`][] is just an alias for [`writable.writableLength`][].
[`socket.bufferSize`][] is just an alias for [`writable.writableLength`][].
aduh95

comment created time in 13 minutes

startednodejs/node-gyp

started time in 18 minutes

PR closed nodejs/node

doc: sync deprecation numbers with v14.x deprecations doc fast-track

DEP numbers are out of sync between master and v14.x because DEP0143 - Transform._transformState landed on v14.x first.

This PR adds DEP0143 - Transform._transformState to doc/api/deprecations.md on master. This forces the module.parent deprecation to move from DEP0143 to DEP0144. The module.parent deprecation has not been formally released (excluding nightly builds) so updating the DEP number should be low risk.

Refs: https://github.com/nodejs/node/pull/33533#issuecomment-658241298


Syncs master and v14.x for DEP0143 - Transform._transformState. Bumps module.parent from DEP0143 to DEP0144 on master. Adds missing DEP number and metadata for DEP0145: socket.bufferSize.

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+18 -6

8 comments

3 changed files

BethGriggs

pr closed time in 19 minutes

pull request commentnodejs/node

doc: sync deprecation numbers with v14.x

Landed in 3b130327fa96...128ed10fc417

BethGriggs

comment created time in 19 minutes

pull request commentnodejs/node

doc: sync deprecation numbers with v14.x

@sxa I'm going to go ahead and land this and make sure 14.6.0 is in sync so we can just move forward :D

BethGriggs

comment created time in 23 minutes

fork capedcrusader23/node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

https://nodejs.org/

fork in 25 minutes

pull request commentnodejs/node

doc: add author-ready label ref to onboarding-extras guide

@richardlau agreed! I believe the semver-* section comes after the initial list since it has a larger description with subitems, I tried to follow that same pattern there 😁

ruyadorno

comment created time in 28 minutes

pull request commentnodejs/node

module: allowed module location list

I think keeping this in policies makes sense, it essentially is a scoping mechanism that doesn't currently exist in the policies configuration. Currently policies must whitelist all permissions for loading files and the escape hatches to allow arbitrary loading are not currently specified to allow arbitrary folders. I also have concerns about symlink escapes if the idea is that you cannot access files outside of a directory we need to write up a design doc on symlinks to write down the reasoning.

Likely this can be approached in a few ways if we want to put it in the policy file, but I actually think matching "imports" and "exports" design from package.json would be ideal. Detecting a resource with a key with a trailing slash is treated as a scope. I am a bit unclear on what we want to put in the value itself but for now limiting it to {integrity: true, dependencies: true} seems adequate. I'm thinking in the case of collision the longest substring policy would be applied without any sort of cascading. I can also imaging setting "dependencies" properly, but am unclear on if we ever would want to allow an integrity list.

bzoz

comment created time in 31 minutes

issue commentnodejs/node

Experimental-exports feature doesn't work

@FrozenKiwi The flag has been removed, exports is now enabled by default in all recent node releases (12, 13, and 14).

niba

comment created time in 36 minutes

PR opened nodejs/node

doc: add author-ready label ref to onboarding-extras guide doc

The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the author-ready label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place.

Just a small improvement suggested during the onboarding session 😊

/cc @addaleax

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make lint passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+11 -1

0 comment

1 changed file

pr created time in 39 minutes

issue commentnodejs/node

Next 10 years of Node.js

Isn't the meeting tomorrow (according to the OP and Foundation calendar)?

mhdawson

comment created time in 41 minutes

pull request commentnodejs/node

stream: simpler Readable async iterator

Yeah sorry I actually played with this a bunch but I forgot to LGTM here because I wanted to test a few more things 😅

ronag

comment created time in 43 minutes

PR closed nodejs/node

[v10.x] doc: update tls.md author ready build doc meta tools v10.x

#33631 Added the missing single quotes in minVersion and maxVersion of api/tls doc before TLSv1.2

Version: v10.x Platform: n/a Subsystem: doc, tls

  • [x] documentation is changed or added
  • [x] commit message follows [commit guidelines]
+2 -2

7 comments

1 changed file

sparsh-99

pr closed time in 43 minutes

pull request commentnodejs/node

[v10.x] doc: update tls.md

Landed in 00f04e3b7982.

sparsh-99

comment created time in 43 minutes

pull request commentnodejs/node

module: allowed module location list

Does it make sense to have this as part of Policies (see also proposed extensions in https://github.com/nodejs/node/pull/33504)?

This also doesn't appear to affect (intentionally? in which case it should probably be made clearer) ES modules. cc @nodejs/modules @nodejs/security

bzoz

comment created time in an hour

startednodejs/node-gyp

started time in an hour

startednodejs/node

started time in an hour

issue commentnodejs/node

Next 10 years of Node.js

Google doc with proposed agenda and to track discussion in the meeting today: https://docs.google.com/document/d/1yWb2Djrm1uPjBwaT4OPh_Q3XJytTLdT0MVYJPqcegpU/edit

mhdawson

comment created time in an hour

startednodejs/node

started time in an hour

pull request commentnodejs/node

bootstrap: include bootstrapped Environment in builtin snapshot

IIRC, I think @danbev in particular said he was going to try to take a look at this. So hopefully we can get another review....

joyeecheung

comment created time in an hour

fork sadhanareddyb/nodejs.dev

A new Node.js resource built using Gatsby.js with React.js, TypeScript, Emotion, and Remark.

https://nodejs.dev

fork in an hour

more