profile
viewpoint

nodejs/docker-node 5443

Official Docker Image for Node.js :whale: :turtle: :rocket:

nodejs/diagnostics 364

Node.js Diagnostics Working Group

nodejs/citgm 354

Canary in the Gold Mine

nodejs/build 265

Better build and test infra for Node.

nodejs/abi-stable-node-addon-examples 221

Node Add-on Examples with PoC ABI stable API for native modules

nodejs/abi-stable-node 219

N-API — Node with PoC ABI stable API for native modules.

nodejs/community-committee 190

The Node.js Community Committee (aka CommComm)

nodejs/changelog-maker 179

A git log to CHANGELOG.md tool

nodejs/docker-iojs 159

Official Docker images from the io.js project

nodejs/code-and-learn 158

A series of workshop sprints for Node.js.

pull request commentnodejs/node

v10.20.0 proposal

CI: https://ci.nodejs.org/job/node-test-pull-request/30519/

BethGriggs

comment created time in 2 minutes

issue commentnodejs/node

Node.js 14 - V8 version roadmap

Sounds good. Thank you for the heads up @syg!

mmarchini

comment created time in 16 minutes

startednodejs/node

started time in 24 minutes

issue commentnodejs/node

NaN byte representation mysteriously changes

I'm not sure we can consider this a bug. There are multiple valid binary representations for NaN. I don't know if the ECMAScript spec requires only one of them to be materialized when the value is put in a typed array.

josephg

comment created time in 24 minutes

issue openednodejs/node

NaN byte representation mysteriously changes

  • Version: 13.12.0, 12.16.1, not 10.19.0
  • Platform: MacOS
  • Subsystem: v8

This is low priority and almost certainly a bug in v8, and I'm not sure if they care to fix it. But this program has mysterious behaviour:

const printBytes = (name, n) => {
  const bytes = Buffer.allocUnsafe(8)
  bytes.writeDoubleBE(n, 0)
  console.log(name + ': ', bytes)
}

const value = NaN

// Or equivalently:
// const b = Buffer.from('7ff8000000000000', 'hex')
// const value = new DataView(b.buffer).getFloat64(b.byteOffset, false)

const unused = {x: 5, value} // If you comment out this line, the problem goes away.
printBytes('same keys   ', ({x: 5, value}).value)
printBytes('diff keys   ', ({y: 5, value}).value)
printBytes('without prop', ({value}).value)
printBytes('naked       ', value)

Now, all those print statements should print the same value. But instead, this is what happens:

$ node test.js
same keys   :  <Buffer ff f7 ff ff ff f7 ff ff>
diff keys   :  <Buffer 7f f8 00 00 00 00 12 34>
without prop:  <Buffer 7f f8 00 00 00 00 12 34>
naked       :  <Buffer 7f f8 00 00 00 00 12 34>

The problem goes away if:

  • You comment out const unused = ...
  • You swap {x:5, value} to {value, x:5}
  • You use a value that isn't NaN

🤷‍♀️

created time in 32 minutes

issue commentnodejs/build

Download slow, breaking CI

nginx config is over here https://raw.githubusercontent.com/nodejs/build/master/ansible/www-standalone/resources/config/nodejs.org

johnny88

comment created time in 40 minutes

issue commentnodejs/node

Node.js 14 - V8 version roadmap

As a heads up, I plan on removing the deprecated Isolate::SetHostCleanupFinalizationGroupCallback in M84. The FinalizationGroup hooks in C++ in node can be all removed without impacting the functionality of FinalizationRegistry today, so I recommend doing so.

mmarchini

comment created time in 42 minutes

issue commentnodejs/build

release-softlayer-centos6-x64-1 is offline

The machine appears to be down:

build/ansible (centos7-devtoolset-8 $ u=) % ssh release-softlayer-centos6-x64-1
^C
build/ansible (centos7-devtoolset-8 $ u=) % grep -A 4 release-softlayer-centos6-x64-1 ~/.ssh/config 
Host release-softlayer-centos6-x64-1 
  HostName 169.62.77.228
  IdentityFile ~/.ssh/nodejs_build_release
  User root

build/ansible (centos7-devtoolset-8 $ u=) % ping 169.62.77.228
PING 169.62.77.228 (169.62.77.228) 56(84) bytes of data.
^C
--- 169.62.77.228 ping statistics ---
5 packets transmitted, 0 received, 100% packet loss, time 4095ms

It never rains but it pours!

@nodejs/build-infra Sorry... but any chance one of you can restart that machine?

BethGriggs

comment created time in an hour

issue commentnodejs/build

Status page for NodeJS

Absolutely would be more than happy to take that task on (as well as setting it all up, just need approval to get started on that) :)

As I mentioned in the opening post though, I think access should be given to as many folks as possible, so that there is a much higher chance that a first responder to any incident can post to the status page if needed.

MattIPv4

comment created time in an hour

issue commentnodejs/build

Download slow, breaking CI

Someone has our backend address and is hitting it directly (DoS?)

Cloudflare has their full ranges public, if this hadn’t been done already, why not configure the origin with a firewall that only lets those in?

johnny88

comment created time in an hour

startednodejs/examples

started time in an hour

issue commentnodejs/node

 List of tests where console.log|error can be replaced with debug

PR to enable NODE_DEBUG=test by default for ci: #32696

Still turning all this over in my mind, but my immediate reaction is that this will go a long way towards addressing the arguments against doing this at this time. I honestly don't know why I've been assuming that such a change should wait until more tests are changed over to debug().

HarshithaKP

comment created time in an hour

issue commentnodejs/build

Download slow, breaking CI

If modifying the origin is an option, then setting a long max-age for dist, as well as including immutable & stale-if-error should encourage Cloudflare to do much more aggressive caching of these assets.

johnny88

comment created time in an hour

issue commentnodejs/build

Download slow, breaking CI

Just diving into this now, here's the variables so far that I can't reconcile:

VM metrics for our main web server over the past 7 days to right now:

20200407_do_www_metrics

The most interesting part of that is the spike in bandwidth that takes us up toward what I think is that similar threshold that we were hitting with DO before we went full caching with CF; in theory we shouldn't be seeing that anymore since CF is supposed to take that load from us. Zooming out to 30 days shows this as an anomaly.

But here's CF in the past 24 hours:

20200407_cf_24h_www_metrics

Zoomed out to 7 days:

20200407_cf_7d_www_metrics

Looks entirely normal.

Plus we do have load balancing with CF and the CF load balancing logs (available through the dashboard @mhdawson) show zero events! So at no point does CF admit to having to switch between our primary+secondary.

So two puzzles:

  • Why is DO bandwidth spiking like this?
  • Why isn't CF reacting to unresponsiveness if there is in fact unresponsiveness on the backend?

I want to blame both of them, but that's kind of weird. For now at least it seems to have subsided.

One scenario where this might be explainable:

  • Someone has our backend address and is hitting it directly (DoS?)
  • It's not being hit quite enough to trigger CF LB thresholds

I just don't understand that second bit, if users are experiencing such pain, why wouldn't CF's LB algorithm be kicking in to deal with it.

johnny88

comment created time in an hour

issue commentnodejs/build

Download slow, breaking CI

Be careful with these settings. There are files under dist that should not be cached too long. At least index.json and index.tab

johnny88

comment created time in an hour

issue commentnodejs/build

Download slow, breaking CI

For example, the page rule might be configured with:

Target: nodejs.org/dist/* Cache level: Cache everything Edge cache ttl: a month Browser cache ttl: a year

johnny88

comment created time in an hour

issue commentnodejs/build

Status page for NodeJS

The only other ask would then be for someone to ensure an incident is posted on there when something goes wrong and to update it as appropriate until the incident is resolved.

@MattIPv4 Not to put too fine a point on it, but you've seen the team size, are you volunteering to do this? If not, which of the half-dozen or less active build-wg members are you proposing to be responsible for this, in addition to everything they already do?

https://github.com/nodejs/build/issues <--- 158 open issues, including this one. There are lots of things we'd like to do, but without people, progress will remain slow. That doesn't make us any happier than it make anyone else, but that's where we are for the moment.

MattIPv4

comment created time in an hour

issue commentnodejs/build

Download slow, breaking CI

I don't see a lot of config options for the caching,

@mhdawson

  • In the "origin" server's nginx config, tweak the Cache-Control headers emitted for the dist/ files -- CF will honor that, and can be told to cache the dist/ files for time scales much longer than 4 hours.
  • Be sure to add a stale-if-error header because the world does not want to have a single box in the hot path for nodejs downloads (see https://support.cloudflare.com/hc/en-us/articles/115003206852 at the bottom "Toggle Always Online")
johnny88

comment created time in an hour

issue commentnodejs/build

Download slow, breaking CI

Updating that will change caching for the entire nodejs.org site which might not be desirable. And yes, that’s controlling browser cache which wouldn’t have much impact on CI, I agree.

I believe configuring a page rule should be possible though, which can be set to only target /dist/ and allow for a custom cache configuration within Cloudflare, so that Cloudflare will cache and serve assets for longer before going back to the origin server on DO to get a new copy.

johnny88

comment created time in an hour

issue commentnodejs/build

Download slow, breaking CI

I don't see a lot of config options for the caching, the one that seems to match 4 hours is the browser cache TTL. My initial thought is that a different value for that would have necessarily helped. In a lot of cases if downloads are from CI's those probably start with a fresh environment that won't have the cache anyway.

johnny88

comment created time in an hour

issue openednodejs/build

release-softlayer-centos6-x64-1 is offline

https://ci-release.nodejs.org/computer/release-softlayer-centos6-x64-1/

Connection was broken

java.nio.channels.ClosedChannelException
	at org.jenkinsci.remoting.protocol.NetworkLayer.onRecvClosed(NetworkLayer.java:154)
	at org.jenkinsci.remoting.protocol.impl.NIONetworkLayer.ready(NIONetworkLayer.java:179)
	at org.jenkinsci.remoting.protocol.IOHub$OnReady.run(IOHub.java:795)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

The v10.20.0-rc.2 is waiting on this machine to become available - https://ci-release.nodejs.org/job/iojs+release/5820/console

created time in an hour

issue commentnodejs/build

Download slow, breaking CI

Submitted ticket 1864572 with Cloudflare to see if they are aware of anything that might have caused this or alternatively asking for any suggestions as to what we should look for in our configs that might have caused it.

johnny88

comment created time in an hour

pull request commentnodejs/node

v10.20.0 proposal

CI: https://ci.nodejs.org/job/node-test-pull-request/30518/

BethGriggs

comment created time in an hour

push eventnodejs/node

Gabriel Schulhof

commit sha 239377b65460d166784dce58399c6c56680a3865

n-api: correct instance data tests When instance data was backported, some of the tests ended up in a location where they do not get run. This moves the tests into test/addons-napi, merging them with existing tests therein, thereby ensuring that they do get run. PR-URL: https://github.com/nodejs/node/pull/32488 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Gabriel Schulhof

commit sha e9c590ea00ca8c6b73bf48652613730cdbcbf703

n-api: define release 6 Mark all N-APIs that have been added since version 5 as stable. PR-URL: https://github.com/nodejs/node/pull/32058 Backport-PR-URL: https://github.com/nodejs/node/pull/32488 Fixes: https://github.com/nodejs/abi-stable-node/issues/393 Co-Authored-By: legendecas <legendecas@gmail.com> Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

view details

Anna Henningsen

commit sha 34c1c2a82bdfe083d617340148e7bc87f517dd06

doc: add missing version metadata for Readable.from Fixes: https://github.com/nodejs/node/issues/28693 PR-URL: https://github.com/nodejs/node/pull/28695 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Dave Vandyke

commit sha 2e3d511cff9ded88682290198e57ae79f38abe69

doc: correct version metadata for Readable.from PR-URL: https://github.com/nodejs/node/pull/32639 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Richard Lau

commit sha 0177464b0e175cd6581ee44d6af6d3b5afb12350

doc,tools: get altDocs versions from CHANGELOG.md Parse `CHANGELOG.md` for versions of Node.js used by the documentation feature `View another version` so that we don't have to manually update the list when we cut a new version or transition a release to LTS. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/27661 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 1ea70d641d6e6e726d3c9d6ed5312adeb2ba87d8

test: fix flaky doctool and test Doctool tests have been failing a lot in CI on Win2008 R2. It appears async functions and callback-based functions are being used in combination such that the callback-based function cannot guarantee that it will invoke its callback. Convert the callback-based functions to async functions so we have one paradigm and reliable results. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/29979 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

view details

Richard Lau

commit sha ac1ea7312aeaadcb5da4b5a35ea5efdf9a6fbd19

tools: make doctool work if no internet available Allow doctool to fallback to use local files if not building a release build. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/30214 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Joyee Cheung

commit sha 3756be851117d02ce1290a6f8f7730206f456191

tools: add NODE_TEST_NO_INTERNET to the doc builder At the moment the doc builder tries to access the internet for CHANGELOG information and only falls back to local sources after the connection fails or a 5 second timeout. This means that the doc building could take at least 7 minutes on a machine with hijacked connection to Github for useless network attempts. This patch adds a NODE_TEST_NO_INTERNET environment variable to directly bypass these attempts so that docs can be built in reasonable time on a machine like that. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/31849 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Richard Lau

commit sha a175b8d3a7704f30623660858091aae63d03370f

tools: only fetch previous versions when necessary Refactor the logic for working out the previous versions of Node.js for the API documentation so that the parsing (including the potential https get) happens at most once per build (as opposed to the current once per generated API doc). Signed-off-by: Richard Lau <riclau@uk.ibm.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/32518 Fixes: https://github.com/nodejs/node/issues/32512 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Richard Lau

commit sha 017909b847851f40613994506785273a951f9235

test: fix tool path in test-doctool-versions.js Path to the versions tool tested by test-doctool-versions.js would be incorrect if the test temporary directory was redirected (e.g. via NODE_TEST_DIR) outside of `test/`. Signed-off-by: Richard Lau <riclau@uk.ibm.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/32645 Refs: https://github.com/nodejs/node/pull/32518 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

Beth Griggs

commit sha 0326fc13ed81fb19eae65d80b21fa8833e397b20

2020-04-07, Version 10.20.0 'Dubnium' (LTS) Notable changes: - buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](https://github.com/nodejs/node/pull/19691) - build: macOS package notarization (Rod Vagg) [#31459](https://github.com/nodejs/node/pull/31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](https://github.com/nodejs/node/pull/32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](https://github.com/nodejs/node/pull/32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](https://github.com/nodejs/node/pull/31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](https://github.com/nodejs/node/pull/30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](https://github.com/nodejs/node/pull/28682) - define release 6 [#32058](https://github.com/nodejs/node/pull/32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](https://github.com/nodejs/node/pull/26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](https://github.com/nodejs/node/pull/27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](https://github.com/nodejs/node/pull/27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](https://github.com/nodejs/node/pull/26226) PR-URL: https://github.com/nodejs/node/pull/31984

view details

push time in an hour

issue commentnodejs/build

Download slow, breaking CI

A suggestion for improving caching here would be to increase the age on the cache control header for /dist/*.

As I noted in Slack, it seems these are currently served with a max-age of four hours, which seems incredibly low considering these files will never change. Why not set something much higher, like a year?

I have no insight into the Cloudflare config, but it’s worth also checking caching for these files is enabled there. Maybe setup a page rule to ensure they have a long cache configured via Cloudflare directly as well?

johnny88

comment created time in an hour

issue commentnodejs/node-gyp

Can't uninstall node Gyp - Windows

For readability of the logs, please three backticks on a line by themselves above the top of the log and the same below the bottom of the log.

Even in the latest log, it still says gyp info using node-gyp@3.8.0

Also see https://github.com/nodejs/node-gyp/issues/1763#issuecomment-595519804

Leinox

comment created time in an hour

issue commentnodejs/build

retrospective on download outage

I should also say that I’m happy to help in any way I can (eg. getting #2265 going), though I would say I’m an expert on infra.

More than happy to help connect y’all with folks at DO or Cf is you think there’s anything specific we can help with. :)

Trott

comment created time in an hour

pull request commentnodejs/nodejs.org

pt-br translation of welcome red hat

@nodejs/nodejs-pt and, one more review =)

Might want to rebase before reviewing?

caioreis123

comment created time in an hour

Pull request review commentnodejs/node

doc: enable remark-lint-no-literal-urls

 For information about the governance of the Node.js project, see ### TSC (Technical Steering Committee)  * [addaleax](https://github.com/addaleax) --**Anna Henningsen** &lt;anna@addaleax.net&gt; (she/her)+**Anna Henningsen** [anna@addaleax.net](mailto:anna@addaleax.net) (she/her)

@nodejs/automation-collaborators

nschonni

comment created time in an hour

pull request commentnodejs/node

[v10.x backport] doc,tools: get altDocs versions from CHANGELOG.md

Landed in 2e3d511cff...017909b847

richardlau

comment created time in 2 hours

PR closed nodejs/node

[v10.x backport] doc,tools: get altDocs versions from CHANGELOG.md build doc tools v10.x

Backports of the following PRs to v10.x-staging:

  1. https://github.com/nodejs/node/pull/27661
  2. https://github.com/nodejs/node/pull/29979
  3. https://github.com/nodejs/node/pull/30214
  4. https://github.com/nodejs/node/pull/31849
  5. https://github.com/nodejs/node/pull/32518
  6. https://github.com/nodejs/node/pull/32645

The first and fifth of these required manual backporting while the middle three in the sequence cherry-picked cleanly. Does Backport-PR-URL: metadata go on all of the commits in this backport PR or only the ones that didn't cherry-pick cleanly (@nodejs/release)?

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+204 -51

7 comments

6 changed files

richardlau

pr closed time in 2 hours

push eventnodejs/node

Richard Lau

commit sha 0177464b0e175cd6581ee44d6af6d3b5afb12350

doc,tools: get altDocs versions from CHANGELOG.md Parse `CHANGELOG.md` for versions of Node.js used by the documentation feature `View another version` so that we don't have to manually update the list when we cut a new version or transition a release to LTS. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/27661 Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Rich Trott

commit sha 1ea70d641d6e6e726d3c9d6ed5312adeb2ba87d8

test: fix flaky doctool and test Doctool tests have been failing a lot in CI on Win2008 R2. It appears async functions and callback-based functions are being used in combination such that the callback-based function cannot guarantee that it will invoke its callback. Convert the callback-based functions to async functions so we have one paradigm and reliable results. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/29979 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

view details

Richard Lau

commit sha ac1ea7312aeaadcb5da4b5a35ea5efdf9a6fbd19

tools: make doctool work if no internet available Allow doctool to fallback to use local files if not building a release build. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/30214 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Joyee Cheung

commit sha 3756be851117d02ce1290a6f8f7730206f456191

tools: add NODE_TEST_NO_INTERNET to the doc builder At the moment the doc builder tries to access the internet for CHANGELOG information and only falls back to local sources after the connection fails or a 5 second timeout. This means that the doc building could take at least 7 minutes on a machine with hijacked connection to Github for useless network attempts. This patch adds a NODE_TEST_NO_INTERNET environment variable to directly bypass these attempts so that docs can be built in reasonable time on a machine like that. Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/31849 Fixes: https://github.com/nodejs/node/issues/29918 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

Richard Lau

commit sha a175b8d3a7704f30623660858091aae63d03370f

tools: only fetch previous versions when necessary Refactor the logic for working out the previous versions of Node.js for the API documentation so that the parsing (including the potential https get) happens at most once per build (as opposed to the current once per generated API doc). Signed-off-by: Richard Lau <riclau@uk.ibm.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/32518 Fixes: https://github.com/nodejs/node/issues/32512 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Richard Lau

commit sha 017909b847851f40613994506785273a951f9235

test: fix tool path in test-doctool-versions.js Path to the versions tool tested by test-doctool-versions.js would be incorrect if the test temporary directory was redirected (e.g. via NODE_TEST_DIR) outside of `test/`. Signed-off-by: Richard Lau <riclau@uk.ibm.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32642 PR-URL: https://github.com/nodejs/node/pull/32645 Refs: https://github.com/nodejs/node/pull/32518 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

view details

push time in 2 hours

PR closed nodejs/node

Reviewers
doc: updating Ninja guide doc

This PR updates the guide to use Ninja, because the instructions were outdated after merging this PR

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ ] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master
+18 -23

2 comments

1 changed file

edsadr

pr closed time in 2 hours

pull request commentnodejs/node

doc: updating Ninja guide

Landed in fd2b35c576ead289772e2e85d4a07ecf61b800c1

edsadr

comment created time in 2 hours

push eventnodejs/node

Adrian Estrada

commit sha fd2b35c576ead289772e2e85d4a07ecf61b800c1

doc: update Ninja information in build guide PR-URL: https://github.com/nodejs/node/pull/32629 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

push time in 2 hours

issue commentnodejs/build

Download slow, breaking CI

Interestingly it also seems like the cached bandwidth on cloudflare as a ratio to total traffic is going back up. That started at around 4:30 EST PM today based on the graph. As of 5:15 EST is was down to 14% versus 50% when we saw bad performance. It started to go up in terms of the uncached percentage around 7PM EST on April 5th.

As @targos mentioned the load on our machines also seems lower which would make sense if more of the load is being cached.

@tholu I wish I could say I fixed something but I've not changed anything. Was just ramping up looking at the logs and trying to figure out what was going on :).

There were some outages reported for cloudflare today, but nothing that seems related or with times that match the period of time we saw the higher uncached bandwidth.

Apr 6, 2020
Issues enabling DNSSEC
Resolved - Cloudflare has resolved the issue and services have resumed normal operation.
Apr 6, 13:44 UTC
Monitoring - Cloudflare has implemented a fix for this issue and is currently monitoring the results.

We will update the status once the issue is resolved.
Apr 6, 13:35 UTC
Investigating - Cloudflare is investigating issues with enabling DNSSEC.

This does not affect existing DNSSEC configurations, which are working as expected.

We are working to understand the full impact and mitigate this problem. More updates to follow shortly.
Apr 6, 12:53 UTC
Performance Issues in Frankfurt, Germany
Resolved - This incident has been resolved.
Apr 6, 12:12 UTC
Monitoring - A fix has been implemented and we are monitoring the results.
Apr 6, 12:05 UTC
Investigating - We are investigating possible performance issues in Frankfurt, Germany (FRA)
Apr 6, 11:29 UTC

Our cloudflare logs are being pushed to google storage and I've not yet found how to get those, if things are working better now then looking at those can probably wait until @rvagg is online and can take a look or point me to instructions/doc as to how they are stored.

Looking further back in the access logs on our machine I do see lots of 500 errors for downloads. Tailing the access log file now I don't see any.

My main guess is that for some reason less of the traffic was served from the cache between 7PM EST on April 5th and today around 4:30 EST where it started to go back to normal.

johnny88

comment created time in 2 hours

issue commentnodejs/build

retrospective on download outage

Totally makes sense, I intended for my comment to imply that if an on-call system is used, part of that is ensuring there are folks on the other end to call that can actually help.

Trott

comment created time in 2 hours

issue commentnodejs/build

retrospective on download outage

@MattIPv4, it may not be clear from the project activity, https://github.com/nodejs/build/graphs/contributors?from=2020-01-08&to=2020-04-06&type=c (is there an equivalent view for comments on issues and PRs? I wish there was, but it wouldn't substantially change that view), but the top 3 folks at that link are developers, who primarily maintain jenkins and CI, and the 4th (Rod) is an expert, but only 1 person.

We don't lack system for making emergency contacts, IMO, we lack people to contact. There has been talk of getting paid infra support in, this might change that conversation.

cloudfare experts are few and far between in the Node.js project, or at least the number of them volunteering to join the build-wg is aprox zero.

Trott

comment created time in 2 hours

pull request commentnodejs/llnode

build: add node-gyp as a dependency

#355 seems like a problem of debian or ubuntu's own making. If those distros tracked v8.x LTS like they should have, they'd be at a node-gyp version that's new enough (v5.0.5 vs v3.6.2.)

mmarchini

comment created time in 2 hours

issue commentnodejs/node

 List of tests where console.log|error can be replaced with debug

PR to enable NODE_DEBUG=test by default for ci: https://github.com/nodejs/node/pull/32696

HarshithaKP

comment created time in 2 hours

PR opened nodejs/node

build: enable NODE_DEBUG=test by default for tests

By convention, require('util').debuglog('test') can be used within tests to separate debug output from console.log/error statements that are actually a part of the test. These should be enabled by default in most cases in CI.

Running make test-ci or variants (e.g. test-ci-js) will set the NODE_DEBUG=test option by default unless explicitly overridden. vcbuild will set NODE_DEBUG=test automatically unless the no-debug-test option is set.

Refs: https://github.com/nodejs/node/issues/32678

Checklist
  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines
+17 -6

0 comment

2 changed files

pr created time in 2 hours

startednodejs/node

started time in 2 hours

fork Mastercuber/node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

https://nodejs.org/

fork in 2 hours

issue commentnodejs/build

Download slow, breaking CI

@mhdawson Seems fast again now for me, just in time as I set up a simple caching of the needed artifacts. How did you fix it?

johnny88

comment created time in 2 hours

issue commentnodejs/build

Status page for NodeJS

Wouldn't StatusPage also help alert the Node.js team members in a quicker fashion? Maybe that could help jump start on fixing things instead of having to wait for user reports of a problem?

Twofold, depending on whether automation is used. If automation is used and detects the outage, it could be set up to automatically mark a component as having an issue. Anyone should then be able to subscribe to that to get alerts through their service of choice.

Equally, StatusPage has really good support for firing off alerts whenever an incident is posted or updated, which again anyone could subscribe to so that they can be notified when something happens.

Can this not just be addressed by pinning and locking the thread?

Sure. That helps a significant amount (though it hasn't been done here and resulted in a very message set of threads). However, as I said above I personally don't feel that GitHub issues are the correct medium to be used for declaring & tracking incidents of this scale for the greater community.

MattIPv4

comment created time in 2 hours

issue commentnodejs/build

Download slow, breaking CI

@mhdawson I seems back to normal. The load on the server is much lower than before, SSH stopped lagging and kswapd0 / ksoftirqd/0 no longer use the CPU.

johnny88

comment created time in 2 hours

issue commentnodejs/build

Status page for NodeJS

A status page would appear to the average user as a far more official and canonical source of information for incidents (imo) and would allow folks to quickly find official updates, which is rather hard in the messy issues full of "also seeing this" etc.

Can this not just be addressed by pinning and locking the thread?

MattIPv4

comment created time in 2 hours

issue commentnodejs/build

Status page for NodeJS

Wouldn't StatusPage also help alert the Node.js team members in a quicker fashion? Maybe that could help jump start on fixing things instead of having to wait for user reports of a problem?

I do agree tho. For outages, GitHub issues doesn't feel like an obvious place I'd check for that information.

MattIPv4

comment created time in 2 hours

startednodejs/node

started time in 2 hours

issue commentnodejs/build

Status page for NodeJS

I personally don't think a pinned issue on one or two repositories should be regarded as sufficient communication/notification for such incidents.

A status page would appear to the average user as a far more official and canonical source of information for incidents (imo) and would allow folks to quickly find official updates, which is rather hard in the messy issues full of "also seeing this" etc.

but that seems a big ask for a project of this size (size in terms of people volunteering to help maintain the infrastructure).

I honestly don't see this as a big ask at all. Assuming the use of StatusPage, there isn't really any requirement for folks to maintain any infra, StatusPage look after all that. The only other ask would then be for someone to ensure an incident is posted on there when something goes wrong and to update it as appropriate until the incident is resolved.

MattIPv4

comment created time in 2 hours

issue commentnodejs/nodejs.org

Getting random 500s on several file downloads and directory listings + downloads slow

Re-opening per @sam-github's request: https://github.com/nodejs/node/issues/32683#issuecomment-610040853

Tobi042

comment created time in 2 hours

IssuesEvent

issue commentnodejs/build

Download slow, breaking CI

In our CI our build at 3:52:30 pm ET failed. Running another one now and will advise if run into issues.

johnny88

comment created time in 2 hours

issue commentnodejs/node-gyp

Can't uninstall node Gyp - Windows

Sorry, didn't use yarn first time. Here : warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-brush@^1.0.4". warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-color@^1.0.3". warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-force@^1.1.0". warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-format@^1.2.0". warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-hierarchy@^1.1.5". warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-interpolate@^1.1.5". warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-scale@^1.0.6". warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-selection@^1.1.0". warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-shape@^1.2.0". warning " > @swimlane/ngx-charts@10.1.0" has unmet peer dependency "d3-time-format@^2.1.0". warning " > @swimlane/ngx-datatable@11.2.0" has incorrect peer dependency "rxjs@^5.0.0". warning " > angular-calendar@0.23.7" has incorrect peer dependency "@angular/animations@>=5.0.0 <7.0.0". warning " > angular-calendar@0.23.7" has incorrect peer dependency "@angular/common@>=5.0.0 <7.0.0". warning " > angular-calendar@0.23.7" has incorrect peer dependency "@angular/core@>=5.0.0 <7.0.0". warning "angular-calendar > angular-draggable-droppable@2.0.0" has incorrect peer dependency "@angular/core@>=5.0.0 <7.0.0". warning "angular-calendar > angular-resizable-element@2.0.0" has incorrect peer dependency "@angular/core@>=5.0.0 <7.0.0". warning " > angular-in-memory-web-api@0.6.1" has incorrect peer dependency "@angular/common@^6.0.0". warning " > angular-in-memory-web-api@0.6.1" has incorrect peer dependency "@angular/core@^6.0.0". warning " > angular-in-memory-web-api@0.6.1" has incorrect peer dependency "@angular/http@^6.0.0". warning " > bootstrap@4.4.1" has unmet peer dependency "jquery@1.9.1 - 3". warning " > bootstrap@4.4.1" has unmet peer dependency "popper.js@^1.16.0". warning " > leaflet.markercluster@1.4.1" has incorrect peer dependency "leaflet@~1.3.1". warning "ngx-tags-input > @angular/common@5.2.11" has incorrect peer dependency "rxjs@^5.5.0". warning "ngx-tags-input > @angular/core@5.2.11" has incorrect peer dependency "rxjs@^5.5.0". warning "ngx-tags-input > @angular/forms@5.2.11" has incorrect peer dependency "rxjs@^5.5.0". warning "ngx-tags-input > @angular/forms@5.2.11" has incorrect peer dependency "@angular/platform-browser@5.2.11". warning " > ngx-toastr@8.10.2" has incorrect peer dependency "@angular/core@^5.2.0 || ^6.0.0". warning " > ngx-toastr@8.10.2" has incorrect peer dependency "@angular/common@^5.2.0 || ^6.0.0". warning " > ngx-toastr@8.10.2" has incorrect peer dependency "@angular/platform-browser@^5.2.0 || ^6.0.0". warning " > ngx-translate-multi-http-loader@3.0.0" has incorrect peer dependency "@ngx-translate/core@>=10.0.0". warning " > @angular/compiler-cli@7.2.16" has incorrect peer dependency "@angular/compiler@7.2.16". warning " > tslint-sonarts@1.9.0" has incorrect peer dependency "tslint@^5.11.0". [4/4] Building fresh packages... [-/5] ⡀ waiting... [2/5] ⡀ node-sass [-/5] ⡀ waiting... [-/5] ⡀ waiting... warning Error running install script for optional dependency: "F:\\source\\TAO\\BO\\node_modules\\node-sass: Command failed. Exit code: 1 Command: node scripts/build.js Arguments: Directory: F:\\source\\TAO\\BO\\node_modules\\node-sass Output: Building: C:\\Program Files\\nodejs\\node.exe F:\\source\\TAO\\BO\\node_modules\\node-sass\\node_modules\\node-gyp\\bin\\node-gyp.js rebuild --verbose --libsass_ext= --libsass_cflags= --libsass_ldflags= --libsass_library= gyp info it worked if it ends with ok gyp verb cli [ gyp verb cli 'C:\\\\Program Files\\\\nodejs\\\\node.exe', gyp verb cli 'F:\\\\source\\\\TAO\\\\BO\\\\node_modules\\\\node-sass\\\\node_modules\\\\node-gyp\\\\bin\\\\node-gyp.js', gyp verb cli 'rebuild', gyp verb cli '--verbose', gyp verb cli '--libsass_ext=', gyp verb cli '--libsass_cflags=', gyp verb cli '--libsass_ldflags=', gyp verb cli '--libsass_library=' gyp verb cli ] gyp info using node-gyp@3.8.0 gyp info using node@12.16.1 | win32 | x64 gyp verb command rebuild [] gyp verb command clean [] gyp verb clean removing \"build\" directory gyp verb command configure [] gyp verb check python checking for Python executable \"python2\" in the PATH gyp verbwhichfailed Error: not found: python2 gyp verbwhichfailed at getNotFoundError (F:\\source\\TAO\\BO\\node_modules\\which\\which.js:13:12) gyp verbwhichfailed at F (F:\\source\\TAO\\BO\\node_modules\\which\\which.js:68:19) gyp verbwhichfailed at E (F:\\source\\TAO\\BO\\node_modules\\which\\which.js:80:29) gyp verbwhichfailed at F:\\source\\TAO\\BO\\node_modules\\which\\which.js:89:16 gyp verbwhichfailed at F:\\source\\TAO\\BO\\node_modules\\isexe\\index.js:42:5 gyp verbwhichfailed at F:\\source\\TAO\\BO\\node_modules\\isexe\\windows.js:36:5 gyp verbwhichfailed at FSReqCallback.oncomplete (fs.js:166:21) gyp verbwhichfailed python2 Error: not found: python2 gyp verbwhichfailed at getNotFoundError (F:\\source\\TAO\\BO\\node_modules\\which\\which.js:13:12) gyp verbwhichfailed at F (F:\\source\\TAO\\BO\\node_modules\\which\\which.js:68:19) gyp verbwhichfailed at E (F:\\source\\TAO\\BO\\node_modules\\which\\which.js:80:29) gyp verbwhichfailed at F:\\source\\TAO\\BO\\node_modules\\which\\which.js:89:16 gyp verbwhichfailed at F:\\source\\TAO\\BO\\node_modules\\isexe\\index.js:42:5 gyp verbwhichfailed at F:\\source\\TAO\\BO\\node_modules\\isexe\\windows.js:36:5 gyp verbwhichfailed at FSReqCallback.oncomplete (fs.js:166:21) { gyp verbwhichfailed stack: 'Error: not found: python2\\n' + gyp verbwhichfailed ' at getNotFoundError (F:\\\\source\\\\TAO\\\\BO\\\\node_modules\\\\which\\\\which.js:13:12)\\n' + gyp verbwhichfailed ' at F (F:\\\\source\\\\TAO\\\\BO\\\\node_modules\\\\which\\\\which.js:68:19)\\n' + gyp verbwhichfailed ' at E (F:\\\\source\\\\TAO\\\\BO\\\\node_modules\\\\which\\\\which.js:80:29)\\n' + gyp verbwhichfailed ' at F:\\\\source\\\\TAO\\\\BO\\\\node_modules\\\\which\\\\which.js:89:16\\n' + gyp verbwhichfailed ' at F:\\\\source\\\\TAO\\\\BO\\\\node_modules\\\\isexe\\\\index.js:42:5\\n' + gyp verbwhichfailed ' at F:\\\\source\\\\TAO\\\\BO\\\\node_modules\\\\isexe\\\\windows.js:36:5\\n' + gyp verbwhichfailed ' at FSReqCallback.oncomplete (fs.js:166:21)', gyp verbwhichfailed code: 'ENOENT' gyp verbwhichfailed } gyp verb check python checking for Python executable \"python\" in the PATH gyp verbwhichsucceeded python C:\\Python27\\python.EXE gyp verb check python versionC:\Python27\python.EXE -c "import sys; print "2.7.17 gyp verb check python version .%s.%s" % sys.version_info[:3];"` returned: %j gyp verb get node dir no --target version specified, falling back to host node version: 12.16.1 gyp verb command install [ '12.16.1' ] gyp verb install input version string "12.16.1" gyp verb install installing version: 12.16.1 gyp verb install --ensure was passed, so won't reinstall if already installed gyp verb install version is already installed, need to check "installVersion" gyp verb got "installVersion" 9 gyp verb needs "installVersion" 9 gyp verb install version is good gyp verb get node dir target node version installed: 12.16.1 gyp verb build dir attempting to create "build" dir: F:\source\TAO\BO\node_modules\node-sass\build gyp verb build dir "build" dir needed to be created? F:\source\TAO\BO\node_modules\node-sass\build gyp verb find vs2017 Found installation at: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools gyp verb find vs2017 - Found Microsoft.VisualStudio.Component.Windows10SDK.17763 gyp verb find vs2017 - Found Microsoft.VisualStudio.Component.VC.Tools.x86.x64 gyp verb find vs2017 - Found Microsoft.VisualStudio.VC.MSBuild.Base gyp verb find vs2017 - Using this installation with Windows 10 SDK gyp verb find vs2017 using installation: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools gyp verb build/config.gypi creating config file gyp verb build/config.gypi writing out config file: F:\source\TAO\BO\node_modules\node-sass\build\config.gypi gyp verb config.gypi checking for gypi file: F:\source\TAO\BO\node_modules\node-sass\config.gypi gyp verb common.gypi checking for gypi file: F:\source\TAO\BO\node_modules\node-sass\common.gypi gyp verb gyp gyp format was not specified; forcing "msvs" gyp info spawn C:\Python27\python.EXE gyp info spawn args [ gyp info spawn args 'F:\\source\\TAO\\BO\\node_modules\\node-sass\\node_modules\\node-gyp\\gyp\\gyp_main.py', gyp info spawn args 'binding.gyp', gyp info spawn args '-f', gyp info spawn args 'msvs', gyp info spawn args '-G', gyp info spawn args 'msvs_version=2015', gyp info spawn args '-I', gyp info spawn args 'F:\\source\\TAO\\BO\\node_modules\\node-sass\\build\\config.gypi', gyp info spawn args '-I', gyp info spawn args 'F:\\source\\TAO\\BO\\node_modules\\node-sass\\node_modules\\node-gyp\\addon.gypi', gyp info spawn args '-I', gyp info spawn args 'C:\\Users\\leino\\.node-gyp\\12.16.1\\include\\node\\common.gypi', gyp info spawn args '-Dlibrary=shared_library', gyp info spawn args '-Dvisibility=default', gyp info spawn args '-Dnode_root_dir=C:\\Users\\leino\\.node-gyp\\12.16.1', gyp info spawn args '-Dnode_gyp_dir=F:\\source\\TAO\\BO\\node_modules\\node-sass\\node_modules\\node-gyp', gyp info spawn args '-Dnode_lib_file=C:\\Users\\leino\\.node-gyp\\12.16.1\\<(target_arch)\\node.lib', gyp info spawn args '-Dmodule_root_dir=F:\\source\\TAO\\BO\\node_modules\\node-sass', gyp info spawn args '-Dnode_engine=v8', gyp info spawn args '--depth=.', gyp info spawn args '--no-parallel', gyp info spawn args '--generator-output', gyp info spawn args 'F:\\source\\TAO\\BO\\node_modules\\node-sass\\build', gyp info spawn args '-Goutput_dir=.' gyp info spawn args ] gyp verb command build [] gyp verb build type Release gyp verb architecture x64 gyp verb node dev dir C:\Users\leino\.node-gyp\12.16.1 gyp verb found first Solution file build/binding.sln gyp verb using MSBuild: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\MSBuild.exe gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\Bin\MSBuild.exe gyp info spawn args [ gyp info spawn args 'build/binding.sln', gyp info spawn args '/nologo', gyp info spawn args '/p:Configuration=Release;Platform=x64' gyp info spawn args ] Les projets sont g�n�r�s individuellement dans cette solution. Pour activer la g�n�ration en parall�le, ajoutez le commutateur "/m". La g�n�ration a d�marr� 06/04/2020 23:10:30. Projet "F:\source\TAO\BO\node_modules\node-sass\build\binding.sln" sur le noud 1 (cibles par d�faut). ValidateSolutionConfiguration: G�n�ration de la configuration de solution "Release|x64". Le projet "F:\source\TAO\BO\node_modules\node-sass\build\binding.sln" (1) g�n�re "F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj.metaproj" (2) sur le noud 1 (cibles par d�faut). Le projet "F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj.metaproj" (2) g�n�re "F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj" (3) sur le noud 1 (cibles par d�faut). PrepareForBuild: Cr�ation du r�pertoire "Release\obj\libsass\". Cr�ation du r�pertoire "F:\source\TAO\BO\node_modules\node-sass\build\Release\". Cr�ation du r�pertoire "Release\obj\libsass\libsass.tlog\". InitializeBuildStatus: Cr�ation de "Release\obj\libsass\libsass.tlog\unsuccessfulbuild", car "AlwaysCreate" a �t� sp�cifi�. ClCompile: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\CL.exe /c /I"C:\Users\leino\.node-gyp\12.16.1\include\node" /I"C:\Users\leino\.node-gyp\12.16.1\src" /I"C:\Users\leino\.node-gyp\12.16.1\deps\openssl\config" /I"C:\Users\leino\.node-gyp\12.16.1\deps\openssl\openssl\include" /I"C:\Users\leino\.node-gyp\12.16.1\deps\uv\include" /I"C:\Users\leino\.node-gyp\12.16.1\deps\zlib" /I"C:\Users\leino\.node-gyp\12.16.1\deps\v8\include" /I..\..\src\libsass\include /Z7 /nologo /W3 /WX- /diagnostics:classic /MP /Ox /Ob2 /Oi /Ot /Oy /D NODE_GYP_MODULE_NAME=libsass /D USING_UV_SHARED=1 /D USING_V8_SHARED=1 /D V8_DEPRECATION_WARNINGS=1 /D V8_DEPRECATION_WARNINGS /D V8_IMMINENT_DEPRECATION_WARNINGS /D WIN32 /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _HAS_EXCEPTIONS=0 /D OPENSSL_NO_PINSHARED /D OPENSSL_THREADS /D "LIBSASS_VERSION=\"3.5.4\"" /GF /Gm- /MT /GS /Gy /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR- /Fo"Release\obj\libsass\\" /Fd"Release\obj\libsass\libsass.pdb" /Gd /TP /wd4351 /wd4355 /wd4800 /wd4251 /wd4275 /wd4244 /wd4267 /FC /errorReport:queue /GR /EHsc ..\..\src\libsass\src\ast.cpp ..\..\src\libsass\src\ast_fwd_decl.cpp ..\..\src\libsass\src\backtrace.cpp ..\..\src\libsass\src\base64vlq.cpp ..\..\src\libsass\src\bind.cpp ..\..\src\libsass\src\check_nesting.cpp ..\..\src\libsass\src\color_maps.cpp ..\..\src\libsass\src\constants.cpp ..\..\src\libsass\src\context.cpp ..\..\src\libsass\src\cssize.cpp ..\..\src\libsass\src\emitter.cpp ..\..\src\libsass\src\environment.cpp ..\..\src\libsass\src\error_handling.cpp ..\..\src\libsass\src\eval.cpp ..\..\src\libsass\src\expand.cpp ..\..\src\libsass\src\extend.cpp ..\..\src\libsass\src\file.cpp ..\..\src\libsass\src\functions.cpp ..\..\src\libsass\src\inspect.cpp ..\..\src\libsass\src\json.cpp ..\..\src\libsass\src\lexer.cpp ..\..\src\libsass\src\listize.cpp ..\..\src\libsass\src\memory\SharedPtr.cpp ..\..\src\libsass\src\node.cpp ..\..\src\libsass\src\operators.cpp ..\..\src\libsass\src\output.cpp ..\..\src\libsass\src\parser.cpp ..\..\src\libsass\src\plugins.cpp ..\..\src\libsass\src\position.cpp ..\..\src\libsass\src\prelexer.cpp ..\..\src\libsass\src\remove_placeholders.cpp ..\..\src\libsass\src\sass.cpp ..\..\src\libsass\src\sass2scss.cpp ..\..\src\libsass\src\sass_context.cpp ..\..\src\libsass\src\sass_functions.cpp ..\..\src\libsass\src\sass_util.cpp ..\..\src\libsass\src\sass_values.cpp ..\..\src\libsass\src\source_map.cpp ..\..\src\libsass\src\subset_map.cpp ..\..\src\libsass\src\to_c.cpp ..\..\src\libsass\src\to_value.cpp ..\..\src\libsass\src\units.cpp ..\..\src\libsass\src\utf8_string.cpp ..\..\src\libsass\src\util.cpp ..\..\src\libsass\src\values.cpp cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] ast.cpp cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] ast_fwd_decl.cpp cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] backtrace.cpp cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] base64vlq.cpp cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] bind.cpp check_nesting.cpp cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] color_maps.cpp constants.cpp context.cpp cssize.cpp emitter.cpp environment.cpp error_handling.cpp eval.cpp expand.cpp extend.cpp file.cpp functions.cpp inspect.cpp json.cpp f:\source\tao\bo\node_modules\node-sass\src\libsass\src\json.cpp(26): warning C4005: '_CRT_NONSTDC_NO_DEPRECATE'�: red�finition de macro [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] f:\source\tao\bo\node_modules\node-sass\src\libsass\src\json.cpp: note: voir la d�finition pr�c�dente de '_CRT_NONSTDC_NO_DEPRECATE' lexer.cpp listize.cpp SharedPtr.cpp node.cpp operators.cpp output.cpp parser.cpp plugins.cpp position.cpp prelexer.cpp remove_placeholders.cpp sass.cpp sass2scss.cpp f:\source\tao\bo\node_modules\node-sass\src\libsass\src\sass2scss.cpp(9): warning C4005: '_CRT_NONSTDC_NO_DEPRECATE'�: red�finition de macro [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] f:\source\tao\bo\node_modules\node-sass\src\libsass\src\sass2scss.cpp: note: voir la d�finition pr�c�dente de '_CRT_NONSTDC_NO_DEPRECATE' sass_context.cpp sass_functions.cpp sass_util.cpp sass_values.cpp source_map.cpp subset_map.cpp to_c.cpp to_value.cpp units.cpp utf8_string.cpp util.cpp values.cpp C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\CL.exe /c /I"C:\Users\leino\.node-gyp\12.16.1\include\node" /I"C:\Users\leino\.node-gyp\12.16.1\src" /I"C:\Users\leino\.node-gyp\12.16.1\deps\openssl\config" /I"C:\Users\leino\.node-gyp\12.16.1\deps\openssl\openssl\include" /I"C:\Users\leino\.node-gyp\12.16.1\deps\uv\include" /I"C:\Users\leino\.node-gyp\12.16.1\deps\zlib" /I"C:\Users\leino\.node-gyp\12.16.1\deps\v8\include" /I..\..\src\libsass\include /Z7 /nologo /W3 /WX- /diagnostics:classic /MP /Ox /Ob2 /Oi /Ot /Oy /D NODE_GYP_MODULE_NAME=libsass /D USING_UV_SHARED=1 /D USING_V8_SHARED=1 /D V8_DEPRECATION_WARNINGS=1 /D V8_DEPRECATION_WARNINGS /D V8_IMMINENT_DEPRECATION_WARNINGS /D WIN32 /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _HAS_EXCEPTIONS=0 /D OPENSSL_NO_PINSHARED /D OPENSSL_THREADS /D "LIBSASS_VERSION=\"3.5.4\"" /GF /Gm- /MT /GS /Gy /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR- /Fo"Release\obj\libsass\\" /Fd"Release\obj\libsass\libsass.pdb" /Gd /TC /wd4351 /wd4355 /wd4800 /wd4251 /wd4275 /wd4244 /wd4267 /FC /errorReport:queue /GR /EHsc ..\..\src\libsass\src\cencode.c cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cencode.c Lib: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\Lib.exe /OUT:"F:\source\TAO\BO\node_modules\node-sass\build\Release\libsass.lib" /NOLOGO /MACHINE:X64 Release\obj\libsass\ast.obj Release\obj\libsass\ast_fwd_decl.obj Release\obj\libsass\backtrace.obj Release\obj\libsass\base64vlq.obj Release\obj\libsass\bind.obj Release\obj\libsass\cencode.obj Release\obj\libsass\check_nesting.obj Release\obj\libsass\color_maps.obj Release\obj\libsass\constants.obj Release\obj\libsass\context.obj Release\obj\libsass\cssize.obj Release\obj\libsass\emitter.obj Release\obj\libsass\environment.obj Release\obj\libsass\error_handling.obj Release\obj\libsass\eval.obj Release\obj\libsass\expand.obj Release\obj\libsass\extend.obj Release\obj\libsass\file.obj Release\obj\libsass\functions.obj Release\obj\libsass\inspect.obj Release\obj\libsass\json.obj Release\obj\libsass\lexer.obj Release\obj\libsass\listize.obj Release\obj\libsass\SharedPtr.obj Release\obj\libsass\node.obj Release\obj\libsass\operators.obj Release\obj\libsass\output.obj Release\obj\libsass\parser.obj Release\obj\libsass\plugins.obj Release\obj\libsass\position.obj Release\obj\libsass\prelexer.obj Release\obj\libsass\remove_placeholders.obj Release\obj\libsass\sass.obj Release\obj\libsass\sass2scss.obj Release\obj\libsass\sass_context.obj Release\obj\libsass\sass_functions.obj Release\obj\libsass\sass_util.obj Release\obj\libsass\sass_values.obj Release\obj\libsass\source_map.obj Release\obj\libsass\subset_map.obj Release\obj\libsass\to_c.obj Release\obj\libsass\to_value.obj Release\obj\libsass\units.obj Release\obj\libsass\utf8_string.obj Release\obj\libsass\util.obj Release\obj\libsass\values.obj libsass.vcxproj -> F:\source\TAO\BO\node_modules\node-sass\build\Release\\libsass.lib FinalizeBuildStatus: Suppression du fichier "Release\obj\libsass\libsass.tlog\unsuccessfulbuild". Mise � jour de l'horodatage "Release\obj\libsass\libsass.tlog\libsass.lastbuildstate". G�n�ration du projet "F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj" termin�e (cibles par d�faut). Le projet "F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj.metaproj" (2) g�n�re "F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj" (4) sur le noud 1 (cibles par d�faut). PrepareForBuild: Cr�ation du r�pertoire "Release\obj\binding\". Cr�ation du r�pertoire "Release\obj\binding\binding.tlog\". InitializeBuildStatus: Cr�ation de "Release\obj\binding\binding.tlog\unsuccessfulbuild", car "AlwaysCreate" a �t� sp�cifi�. ClCompile: C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\CL.exe /c /I"C:\Users\leino\.node-gyp\12.16.1\include\node" /I"C:\Users\leino\.node-gyp\12.16.1\src" /I"C:\Users\leino\.node-gyp\12.16.1\deps\openssl\config" /I"C:\Users\leino\.node-gyp\12.16.1\deps\openssl\openssl\include" /I"C:\Users\leino\.node-gyp\12.16.1\deps\uv\include" /I"C:\Users\leino\.node-gyp\12.16.1\deps\zlib" /I"C:\Users\leino\.node-gyp\12.16.1\deps\v8\include" /I..\..\nan /I..\src\libsass\include /Z7 /nologo /W3 /WX- /diagnostics:classic /MP /Ox /Ob2 /Oi /Ot /Oy /D NODE_GYP_MODULE_NAME=binding /D USING_UV_SHARED=1 /D USING_V8_SHARED=1 /D V8_DEPRECATION_WARNINGS=1 /D V8_DEPRECATION_WARNINGS /D V8_IMMINENT_DEPRECATION_WARNINGS /D WIN32 /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _HAS_EXCEPTIONS=0 /D OPENSSL_NO_PINSHARED /D OPENSSL_THREADS /D BUILDING_NODE_EXTENSION /D _WINDLL /GF /Gm- /MT /GS /Gy /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR- /Fo"Release\obj\binding\\" /Fd"Release\obj\binding\vc141.pdb" /Gd /TP /wd4351 /wd4355 /wd4800 /wd4251 /wd4275 /wd4244 /wd4267 /FC /errorReport:queue /Zc:threadSafeInit- ..\src\binding.cpp ..\src\create_string.cpp ..\src\custom_function_bridge.cpp ..\src\custom_importer_bridge.cpp ..\src\sass_context_wrapper.cpp ..\src\sass_types\boolean.cpp ..\src\sass_types\color.cpp ..\src\sass_types\error.cpp ..\src\sass_types\factory.cpp ..\src\sass_types\list.cpp ..\src\sass_types\map.cpp ..\src\sass_types\null.cpp ..\src\sass_types\number.cpp ..\src\sass_types\string.cpp "F:\source\TAO\BO\node_modules\node-sass\node_modules\node-gyp\src\win_delay_load_hook.cc" binding.cpp create_string.cpp custom_function_bridge.cpp custom_importer_bridge.cpp sass_context_wrapper.cpp boolean.cpp color.cpp error.cpp f:\source\tao\bo\node_modules\node-sass\src\create_string.cpp(17): error C2664: 'v8::String::Utf8Value::Utf8Value(const v8::String::Utf8Value &)'�: impossible de convertir l'argument 1 de 'v8::Localv8::Value' en 'const v8::String::Utf8Value &' [F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj] f:\source\tao\bo\node_modules\node-sass\src\create_string.cpp(17): note: Raison�: impossible de convertir de 'v8::Localv8::Value' en 'const v8::String::Utf8Value' f:\source\tao\bo\node_modules\node-sass\src\create_string.cpp(17): note: Aucun op�rateur de conversion d�finie par l'utilisateur disponible qui puisse effectuer cette conversion, ou l'op�rateur ne peut pas �tre appel� factory.cpp list.cpp map.cpp null.cpp number.cpp string.cpp win_delay_load_hook.cc G�n�ration du projet "F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj" termin�e (cibles par d�faut) -- �CHEC. G�n�ration du projet "F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj.metaproj" termin�e (cibles par d�faut) -- �CHEC. G�n�ration du projet "F:\source\TAO\BO\node_modules\node-sass\build\binding.sln" termin�e (cibles par d�faut) -- �CHEC.

�CHEC de la build.

"F:\source\TAO\BO\node_modules\node-sass\build\binding.sln" (cible par d�faut) (1) -> "F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj.metaproj" (cible par d�faut) (2) -> "F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj" (cible par d�faut) (3) -> (ClCompile cible) -> cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] f:\source\tao\bo\node_modules\node-sass\src\libsass\src\json.cpp(26): warning C4005: '_CRT_NONSTDC_NO_DEPRECATE'�: red�finition de macro [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj] f:\source\tao\bo\node_modules\node-sass\src\libsass\src\sass2scss.cpp(9): warning C4005: '_CRT_NONSTDC_NO_DEPRECATE'�: red�finition de macro [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj]

"F:\source\TAO\BO\node_modules\node-sass\build\binding.sln" (cible par d�faut) (1) -> "F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj" (cible par d�faut) (3) -> cl : Ligne de commande warning D9025: substitution de '/GR-' par '/GR' [F:\source\TAO\BO\node_modules\node-sass\build\src\libsass.vcxproj]

"F:\source\TAO\BO\node_modules\node-sass\build\binding.sln" (cible par d�faut) (1) -> "F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj.metaproj" (cible par d�faut) (2) -> "F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj" (cible par d�faut) (4) -> (ClCompile cible) -> f:\source\tao\bo\node_modules\node-sass\src\create_string.cpp(17): error C2664: 'v8::String::Utf8Value::Utf8Value(const v8::String::Utf8Value &)'�: impossible de convertir l'argument 1 de 'v8::Localv8::Value' en 'const v8::String::Utf8Value &' [F:\source\TAO\BO\node_modules\node-sass\build\binding.vcxproj]

12 Avertissement(s)
1 Erreur(s)

Temps �coul� 00:00:29.88 gyp ERR! build error gyp ERR! stack Error: C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\MSBuild\\15.0\\Bin\\MSBuild.exe failed with exit code: 1 gyp ERR! stack at ChildProcess.onExit (F:\source\TAO\BO\node_modules\node-sass\node_modules\node-gyp\lib\build.js:262:23) gyp ERR! stack at ChildProcess.emit (events.js:311:20) gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12) gyp ERR! System Windows_NT 10.0.18363 gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "F:\\source\\TAO\\BO\\node_modules\\node-sass\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library=" gyp ERR! cwd F:\source\TAO\BO\node_modules\node-sass gyp ERR! node -v v12.16.1 success Saved lockfile. Done in 87.47s.`

Leinox

comment created time in 2 hours

IssuesEvent

issue commentnodejs/node

Some https://nodejs.org/dist/ builds are experiencing intermittent 500 errors

@bnb is it possible to leave it open and locked? That might better reflect the situation, if technically possible.

ryanolee

comment created time in 2 hours

pull request commentnodejs/nodejs.org

change "persian language" to "persian" & adding other indexes

@ebraminio I will add Persian language to Crowdin project for you

AliSawari

comment created time in 2 hours

issue commentnodejs/build

Status page for NodeJS

This will come up in the retrospective, #2264 , but from my point of view we have issues pinned at the top of https://github.com/nodejs/node/issues and the top of (since I just did it) of https://github.com/nodejs/build/issues.. I appreciate that people would like notifications from their tool of choice (status page, twitter, etc.), but that seems a big ask for a project of this size (size in terms of people volunteering to help maintain the infrastructure).

MattIPv4

comment created time in 2 hours

issue commentnodejs/build

Download slow, breaking CI

Are people still seeing the issue? I have yet to have a download be slow or fail?

johnny88

comment created time in 2 hours

issue commentnodejs/build

Download slow, breaking CI

I don't think that Cloudflare in front of a single box is the right solution for serving these dist files when robustness is the goal.

Even small hiccups in the backend are exposed.

The single machine that we talk about here is in the hot path more often than it should be. For Cloudflare to fall back to serving from cache while the backend is not available very specific conditions need to be met: https://support.cloudflare.com/hc/en-us/articles/200168436-Understanding-Cloudflare-Always-Online

I myself have Cloudflare in front of a single box and was often surprised how this setup does not magically heal transient problems in the backend.

Let's strive towards a solution where the backend is never in the hot path.

Typically, dist files like the ones we talk about here should be served by a real CDN like fastly (which sponsors the hosting for Python), cloudfront, Google Cloud CDN, etc.

johnny88

comment created time in 2 hours

issue commentnodejs/build

Download slow, breaking CI

One thing on cloudflare that stands out so far is that for the last month only 12% of the traffic was uncached, and stat for last week is similar. Uncached for the last 6 hours is 48%

johnny88

comment created time in 2 hours

PR opened nodejs/node

test: replace console.log/error with debuglog

Use utility debug logs instead of console logs in test-cluster-setup-master-multiple.js

Fixes: https://github.com/nodejs/node/issues/32678

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+3 -2

0 comment

1 changed file

pr created time in 2 hours

issue commentnodejs/build

Download slow, breaking CI

HTTP/2 stream 0 was not closed cleanly

^--- that's interesting, do we always serve over HTTP/2? Is it possible something changed wrt. that?

johnny88

comment created time in 2 hours

issue commentnodejs/build

https://ci.nodejs.org/computer/test-osuosl-centos7-ppc64_le-1/ is down, investigating

Hm. Reloaded the unit file and waited a while, and it started connecting again.

sam-github

comment created time in 2 hours

issue commentnodejs/node

 List of tests where console.log|error can be replaced with debug

The other possibility here is to prioritize these changes for tests where timing is most likely to be an issue... most often from what I've seen: tests involving networking

HarshithaKP

comment created time in 2 hours

issue commentnodejs/build

Download slow, breaking CI

Going to see if there is anything in the cloudflare logs

johnny88

comment created time in 3 hours

pull request commentnodejs/node

n-api: detect deadlocks in thread-safe function

CI: https://ci.nodejs.org/job/node-test-pull-request/30517/

gabrielschulhof

comment created time in 3 hours

issue commentnodejs/build

Download slow, breaking CI

At the same time plenty of requests for downloads in /var/log/nginx/nodejs/ndoejs.org-access.log

johnny88

comment created time in 3 hours

issue commentnodejs/build

Download slow, breaking CI

We are getting a lot of No such file or directory in /var/log/nginx/nodejs/nodejs.org-error.log but non of those are for requests to downloads

johnny88

comment created time in 3 hours

issue openednodejs/build

https://ci.nodejs.org/computer/test-osuosl-centos7-ppc64_le-1/ is down, investigating

Its looping with

Apr 06 20:51:30 test-osuosl-centos7-ppc64--le-1 java[21827]: Failed to obtain https://ci.nodejs.org/computer/test-osuosl-centos7-ppc64_le-1/slave-agent.jnlp?encrypt=true
Apr 06 20:51:30 test-osuosl-centos7-ppc64--le-1 java[21827]: com.sun.org.apache.xerces.internal.impl.io.MalformedByteSequenceException: Invalid byte 1 of 1-byte UTF-8 sequence.
Apr 06 20:51:30 test-osuosl-centos7-ppc64--le-1 java[21827]: at com.sun.org.apache.xerces.internal.impl.io.UTF8Reader.invalidByte(UTF8Reader.java:701)
Apr 06 20:51:30 test-osuosl-centos7-ppc64--le-1 java[21827]: at com.sun.org.apache.xerces.internal.impl.io.UTF8Reader.read(UTF8Reader.java:567)

created time in 3 hours

issue commentnodejs/node

Some https://nodejs.org/dist/ builds are experiencing intermittent 500 errors

(Going to leave pinned until resolved so we don't see duplicate issues created.)

ryanolee

comment created time in 3 hours

issue closednodejs/nodejs.org

Getting random 500s on several file downloads and directory listings + downloads slow

  • URL: https://nodejs.org/dist/v12.13.0/ , https://nodejs.org/dist/v12.13.0/SHASUMS256.txt.asc , https://nodejs.org/dist/v12.16.1/node-v12.16.1-darwin-x64.tar.gz
  • Browser version: Chrome 80.0.3987.162 , curl 7.64.1
  • Operating system: macOS 10.15.4

I'm getting a mix of slow / broken binary downloads, non-functional directory listings and file downloads both on my home internet connection in Germany, as well as from our CI server in AWS (don't know the region). Sometimes it works without a problem, but more than half the times, I'm getting the error.

If an error occurs, it's a 500 by nginx.

curl 7.64.1 (x86_64-apple-darwin19.0) libcurl/7.64.1 (SecureTransport) LibreSSL/2.8.3 zlib/1.2.11 nghttp2/1.39.2
Release-Date: 2019-03-27
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: AsynchDNS GSS-API HTTP2 HTTPS-proxy IPv6 Kerberos Largefile libz MultiSSL NTLM NTLM_WB SPNEGO SSL UnixSockets
➜  ~ curl -v https://nodejs.org/dist/v12.13.0/SHASUMS256.txt.asc
*   Trying 2606:4700:10::6814:162e...
* TCP_NODELAY set
* Connected to nodejs.org (2606:4700:10::6814:162e) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/cert.pem
  CApath: none
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Change cipher spec (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):
* SSL connection using TLSv1.2 / ECDHE-RSA-CHACHA20-POLY1305
* ALPN, server accepted to use h2
* Server certificate:
*  subject: OU=Domain Control Validated; OU=PositiveSSL Wildcard; CN=*.nodejs.org
*  start date: Oct 21 00:00:00 2019 GMT
*  expire date: Jan 18 23:59:59 2022 GMT
*  subjectAltName: host "nodejs.org" matched cert's "nodejs.org"
*  issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; CN=Sectigo RSA Domain Validation Secure Server CA
*  SSL certificate verify ok.
* Using HTTP2, server supports multi-use
* Connection state changed (HTTP/2 confirmed)
* Copying HTTP/2 data in stream buffer to connection buffer after upgrade: len=0
* Using Stream ID: 1 (easy handle 0x7f82ff00d600)
> GET /dist/v12.13.0/SHASUMS256.txt.asc HTTP/2
> Host: nodejs.org
> User-Agent: curl/7.64.1
> Accept: */*
>
* Connection state changed (MAX_CONCURRENT_STREAMS == 256)!
< HTTP/2 500
< date: Mon, 06 Apr 2020 08:19:11 GMT
< content-type: text/html
< set-cookie: __cfduid=d491984f37389168cb113964828dd085c1586161151; expires=Wed, 06-May-20 08:19:11 GMT; path=/; domain=.nodejs.org; HttpOnly; SameSite=Lax
< cf-cache-status: BYPASS
< expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
< server: cloudflare
< cf-ray: 57fa151af99cdfd7-FRA
<
<html>
<head><title>500 Internal Server Error</title></head>
<body bgcolor="white">
<center><h1>500 Internal Server Error</h1></center>
<hr><center>nginx</center>
</body>
</html>
* Connection #0 to host nodejs.org left intact
* Closing connection 0

closed time in 3 hours

Tobi042

issue commentnodejs/nodejs.org

Getting random 500s on several file downloads and directory listings + downloads slow

Since @mhdawson has pointed to https://github.com/nodejs/build/issues/2263 as the single source of truth for this discussion (ref: https://github.com/nodejs/node/issues/32683#issuecomment-610014994), I'm going to lock this discussion in favor of that one. There are already further updates there ❤️

Tobi042

comment created time in 3 hours

issue closednodejs/node

Some https://nodejs.org/dist/ builds are experiencing intermittent 500 errors

  • Version: Many (see list)
  • Platform: All
  • Subsystem: Dist build system

See: https://github.com/nodejs/nodejs.org/issues/3075 https://github.com/nodejs/build/issues/2263

For other node repos effected by this.

What steps will reproduce the bug?

Many /dist/ builds are giving 500 errors. Such as https://nodejs.org/dist/v0.11.15/

How often does it reproduce? Is there a required condition?

Temperamental as it currently stands. Currently 500-ing for me

What is the expected behavior?

Dist zip download

What do you see instead?

500 errors

Additional information

A number of other issues have been raised about this: https://github.com/nodejs/node/issues/32680 https://github.com/nodejs/node/issues/32681 https://github.com/nodejs/node/issues/32682

We will probably want to flatten them into one global issue surrounding builds across all of these versions failing to properly load.

Currently building a list of effected URLS Thus far failing builds can be found here <- Likley to change given 500 errors seem almost random at this stage

closed time in 3 hours

ryanolee

issue commentnodejs/nodejs.org

Getting random 500s on several file downloads and directory listings + downloads slow

Are there any mirros that one could use for NodeJS ? Or perhaps a company is willing to start one.

Tobi042

comment created time in 3 hours

issue commentnodejs/node

 List of tests where console.log|error can be replaced with debug

I will say that I have seen a case where a test fails, but then starts passing as soon as a console.log() is added because is affected timing. This does suggest that console.log() may be masking bugs. I don't believe there's a lot of evidence that this is a frequent problem. But since it is something that can happen, that would be a reason for wanting to do this.

FWIW, for me, that's the most compelling reason to do this.

HarshithaKP

comment created time in 3 hours

issue commentnodejs/build

Status page for NodeJS

Yeah, totally. StatusPage comes with Twitter support (@cdnjsStatus for example). I think that'd likely be a step after getting the initial status page stood up, but shouldn't be hard.

MattIPv4

comment created time in 3 hours

issue commentnodejs/node

Different behavior between transform function and async generator using pipelines

pipeline should still have the the workaround though to support older versions of streams from e.g. readable-stream.

Can we safely do that? Because we would be calling .end() twice.

Xstoudi

comment created time in 3 hours

startednodejs/node

started time in 3 hours

pull request commentnodejs/nodejs.org

New Persian translations

@nodejs/nodejs-fa Friendly reminder

ebraminio

comment created time in 3 hours

issue commentnodejs/node

 List of tests where console.log|error can be replaced with debug

we could enable debug option when test fail and rerun it then output the error log in CI. I think it’s not a big problem.

Well, sure, if the failure can be easily reproduced. Which it cannot in many cases.

HarshithaKP

comment created time in 3 hours

pull request commentnodejs/nodejs.org

Update index.md

@nodejs/nodejs-ja Please review this PR

sh9temp

comment created time in 3 hours

issue commentnodejs/build

Status page for NodeJS

It would be great if there was twitter account that one could follow the status updates akin to githubstatus.

MattIPv4

comment created time in 3 hours

issue commentnodejs/node

 List of tests where console.log|error can be replaced with debug

@himself65 That’s true, but what if the test doesn’t fail then? As Rich said, we do have an actual problem with tests failing in CI that are not easily reproducible and don’t provide sufficient debugging information. We do not commonly run into trouble because a test has too many logging statements.

HarshithaKP

comment created time in 3 hours

pull request commentnodejs/nodejs.org

Feature / Improve Spanish Translation

@nodejs/nodejs-es Please take a look on this PR

JoseJPR

comment created time in 3 hours

pull request commentnodejs/nodejs.org

pt-br translation of welcome red hat

@nodejs/nodejs-pt and, one more review =)

caioreis123

comment created time in 3 hours

issue commentnodejs/node

 List of tests where console.log|error can be replaced with debug

we could enable debug option when test fail and rerun it then output the error log in CI. I think it’s not a big problem.

HarshithaKP

comment created time in 3 hours

pull request commentnodejs/node

n-api: detect deadlocks in thread-safe function

CI: https://ci.nodejs.org/job/node-test-pull-request/30516/

gabrielschulhof

comment created time in 3 hours

PR closed nodejs/node

src: munmap(2) upon class instance destructor C++

Replace OnScopeLeave with a class whose instance destructor performs the munmap(2).

Signed-off-by: @gabrielschulhof Fixes: https://github.com/nodejs/node/issues/32532

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+102 -72

27 comments

1 changed file

gabrielschulhof

pr closed time in 4 hours

pull request commentnodejs/node

src: munmap(2) upon class instance destructor

Landed in a50745e60817392d3a220d0e346d6b74fb911548.

gabrielschulhof

comment created time in 4 hours

push eventnodejs/node

Gabriel Schulhof

commit sha a50745e60817392d3a220d0e346d6b74fb911548

src: munmap(2) upon class instance destructor Replace `OnScopeLeave` with a class whose instance destructor performs the munmap(2). Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Fixes: https://github.com/nodejs/node/issues/32532 PR-URL: https://github.com/nodejs/node/pull/32570 Co-Authored-By: Anna Henningsen <github@addaleax.net> Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

push time in 4 hours

issue closednodejs/node

Convert mmap()s to smart pointers

Re: https://github.com/nodejs/node/pull/32396#discussion_r399553321

closed time in 4 hours

gabrielschulhof

issue commentnodejs/build

retrospective on download outage

Having a proper system for an emergency contact makes sense, either through an on-call system of trusted volunteers (build-infra) or a paid position that comes with the responsibility of being okay with being woken up in the middle of the night if the world falls apart.

Trott

comment created time in 4 hours

issue commentnodejs/node

Different behavior between transform function and async generator using pipelines

@ronag Do we not want to fix this for pipe()?

Was closed through the commit. I think that's a different issue than this though.

But yes, I think we should fix it in pipe() as well. pipeline should still have the the workaround though to support older versions of streams from e.g. readable-stream.

Xstoudi

comment created time in 4 hours

issue commentnodejs/node

 List of tests where console.log|error can be replaced with debug

The idea is to separate output that is considered part of the test itself from informational/debug output. The rationale is to make the intent of the output clear and to avoid cases where the debug output itself may alter the outcome of the test

Should clarify things up.

Yeah, here's the thing. That's a problem that comes up infrequently. It happens. I've been bit by it. But the problem of a test intermittently timing out in CI and there not being enough information to figure out what's going on? Happens a lot. Way more often than console.log() messing up a test with timing, and so on. And the test only times out once in 100 runs or 1000 runs. And often the stress test job can't reproduce it because it only happens under certain conditions on a certain machine, but that's not obvious at the outset.

I will take "some extra information that confuses me a little bit once in a long while" over "spending hours trying to reproduce a test failure so I can debug it" every single time.

I'm not opposed to this. I'm not going to block it. But I am, sorry to say, unenthusiastic.

HarshithaKP

comment created time in 4 hours

issue commentnodejs/node

Different behavior between transform function and async generator using pipelines

@ronag Do we not want to fix this for pipe()?

Xstoudi

comment created time in 4 hours

more