profile
viewpoint

nodejs/docker-node 5287

Official Docker Image for Node.js :whale: :turtle: :rocket:

nodejs/diagnostics 357

Node.js Diagnostics Working Group

nodejs/citgm 352

Canary in the Gold Mine

nodejs/build 257

Better build and test infra for Node.

nodejs/abi-stable-node 219

N-API — Node with PoC ABI stable API for native modules.

nodejs/abi-stable-node-addon-examples 219

Node Add-on Examples with PoC ABI stable API for native modules

nodejs/community-committee 190

The Node.js Community Committee (aka CommComm)

nodejs/changelog-maker 171

A git log to CHANGELOG.md tool

nodejs/docker-iojs 160

Official Docker images from the io.js project

nodejs/code-and-learn 158

A series of workshop sprints for Node.js.

issue commentnodejs/web-server-frameworks

Alignment on meeting dates and time(s)

Personally I think another vote won’t really help give us more information than we already have from the last one. Is anyone opposed to these meeting times? If the times are fine we just need to pick a day.

ghermeto

comment created time in 3 minutes

issue commentnodejs/web-server-frameworks

Node.js Foundation Web Server Team Meeting 2020-01-24

Yep, I have been busy and also dropped the ball here, sorry folks! Next step is scheduling the official meeting times. I think we can do that in parallel with the governance updates as long as there are folks willing to dedicate the time.

wesleytodd

comment created time in 7 minutes

issue commentnodejs/docker-node

@nodejs/docker I think we should invite @nschonni to join our team as an active contributor.

Forgot about this, I'm not sure if this is something that needs to be opened on the nodejs/admin repo or not

nschonni

comment created time in 11 minutes

issue commentnodejs/web-server-frameworks

Node.js Foundation Web Server Team Meeting 2020-01-24

Sorry @Ethan-Arrowood, I told @wesleytodd I was going to help, but I dropped the ball...

I think the thing that we are missing is finishing the discussion about the time of the meetings. I have created issue #31 to align on that before we schedule the next one. I want to finish updating the team's governance, but I need this alignment first.

wesleytodd

comment created time in 12 minutes

pull request commentnodejs/remark-preset-lint-node

feat: prohibit possessive form of Node.js

Sorry for the unrelated message, but I'd probably be interested in the Linting team. Note sure if that is a TSC group or not.

Trott

comment created time in 14 minutes

issue openednodejs/web-server-frameworks

Alignment on meeting dates and time(s)

Hi folks,

I would like to align on the recurring meeting days and time.

Should we have 2 alternating times (6am PST and 10am PST), like the package maintenance WG?

I specifically mentioned 6am and 10am PST because our previous meeting was 6am and 10am was the most voted time on the Doodle. Not sure if 6am works well for everyone in California.

Should we have another vote?

created time in 15 minutes

pull request commentnodejs/docker-node

chore: upgrade to node 12.16.1

Created PR to the official-images repo (https://github.com/docker-library/official-images/pull/7492). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

SimenB

comment created time in 16 minutes

pull request commentnodejs/docker-node

chore: upgrade to node 12.16.1

#1219 sent for v13, official builds are ready, waiting for unofficial builds.

SimenB

comment created time in 20 minutes

PR opened nodejs/docker-node

Update node.js v13.x to v13.9.0 with Yarn v1.22.0
  • https://nodejs.org/en/blog/release/v13.9.0/
  • https://github.com/nodejs/node/releases/tag/v13.9.0
  • https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md#13.9.0

Waiting Alpine unofficial build to be ready.

+14 -14

0 comment

6 changed files

pr created time in 21 minutes

push eventnodejs/docker-node

Simen Bekkhus

commit sha 5351774b970cd32b80fc0c47a8abff5ba155fccc

chore: upgrade to node 12.16.1

view details

Peter Dave Hello

commit sha cda575809f8eacec585f47a27efca978b4cf9568

Merge pull request #1217 from SimenB/12.16.1 chore: upgrade to node 12.16.1

view details

push time in 24 minutes

PR merged nodejs/docker-node

chore: upgrade to node 12.16.1

https://nodejs.org/en/blog/release/v12.16.1/

13.9 has been released as well (https://github.com/nodejs/node/releases/tag/v13.9.0) but no blog post or Alpine release yet

+10 -10

1 comment

7 changed files

SimenB

pr closed time in 24 minutes

startednodejs/docker-node

started time in 32 minutes

pull request commentnodejs/node

events: fix not emit removeListener

LGTM, and based on your OP, you can probably use something like this as the test:

'use strict';
const common = require('../common');
const assert = require('assert');
const EventEmitter = require('events');
const myEmitter = new EventEmitter();
const sym = Symbol('symbol');
const fn = () => {};
myEmitter.on(sym, fn);

myEmitter.on('removeListener', common.mustCall((...args) => {
  assert.deepStrictEqual(args, [sym, fn]);
}));

myEmitter.removeAllListeners();

Thank you, it was very helpful for me. I have added the test code to an existing test file ‘test-event-emitter-remove-all-listeners.js’.

fuxingZhang

comment created time in 35 minutes

IssuesEvent

issue closednodejs/node-v8

zlib build fail on windows platform

C:\projects\appveyor-playground\node-v8\deps\v8\third_party\zlib\cpu_features.c(45,1): fatal error C1189: #error:  cpu_features.c CPU feature detection in not defined for your platform 

closed time in an hour

gengjiawen

issue openednodejs/node-v8

zlib build fail on windows platform

C:\projects\appveyor-playground\node-v8\deps\v8\third_party\zlib\cpu_features.c(45,1): fatal error C1189: #error:  cpu_features.c CPU feature detection in not defined for your platform 

created time in an hour

startednodejs/node

started time in an hour

pull request commentnodejs/node

esm: implement import.meta.resolve and make nodejs: scheme public

The signatures of import.meta.resolve(…) and require.resolve(…) differ in terms of which arguments they accept: https://github.com/nodejs/node/issues/31861.

guybedford

comment created time in an hour

issue openednodejs/node

esm: Make `import.meta.resolve(…)` take an options argument

require.resolve(…) takes a second optional options argument, instead of a second optional parent string argument.

This differs from what's been implemented in https://github.com/nodejs/node/pull/31032.

import.meta.resolve(…) and require.resolve(…) should both take a string and an options object, instead of one taking two strings and the other taking a string and an options object.


/cc @guybedford

created time in an hour

issue commentnodejs/modules

ESM module load

@jcjolley -- in your typescript source, when importing another typescript file, use the .js extension, and it will work

that is, when importing b.ts, the code in a.ts should look like this:

import * as b from "b.js"
gengjiawen

comment created time in an hour

Pull request review commentnodejs/node

esm: implement import.meta.resolve and make nodejs: scheme public

 const __filename = fileURLToPath(import.meta.url); const __dirname = dirname(__filename); ``` +### No `require.resolve`++Former use cases relying on `require.resolve` to determine the resolved path+of a module can be supported via `import.meta.resolve`:++```js+(async () => {+  const dependencyAsset = await import.meta.resolve('component-lib/asset.css');+})();+```++`import.meta.resolve` also accepts a second argument which is the parent module

It’s been supported since https://github.com/nodejs/node/pull/16397 as:

require.resolve('./dep', { paths: [ __filename ] });
guybedford

comment created time in an hour

fork arjunrawal07/node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

https://nodejs.org/

fork in an hour

pull request commentnodejs/node-gyp

gyp: sync code base with nodejs repo

Sorry for not dismissing my review earlier, I missed it when I investigated the failure.

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/176/ ✔️ (this does not rebase, would be good to run CI on the final rebased version before landing)

Looks like the CI passed. If we have no future questions, I want to land this.

targos

comment created time in an hour

Pull request review commentnodejs/nodejs.dev

refactor(linting warnings): Fixed linting warnings

 interface Props {   darkModeController?: DarkModeController; } -const Header = ({ darkModeController }: Props) => (+const Header = ({ darkModeController }: Props): JSX.Element => (

Id welcome any guidance on typings with React, I dont actually know much about this at all honestly.

What Im seeing here is that because we are using a function expression we should document that expression returns a react functional component function, instead of just documenting the return type of that function itself.

I dont fully understand the benefits of this but I do think I understand the semantic difference.

Thank you for taking a look at this and bringing it up, Im very open to a discussion around the conventions we are using ❤️

benhalverson

comment created time in 2 hours

Pull request review commentnodejs/nodejs.dev

refactor(linting warnings): Fixed linting warnings

 interface Props {   darkModeController?: DarkModeController; } -const Header = ({ darkModeController }: Props) => (+const Header = ({ darkModeController }: Props): JSX.Element => (

Id welcome any guidance on typings with React, I dont actually know much about this at all honestly.

What Im seeing here is that because we are using a function expression we should document that expression returns a react functional component function, instead of just documenting the return type of that function itself.

I dont fully understand the benefits of this but I do think I understand the semantic difference.

Thank you for taking a look at this and bringing it up, Im very open to a discussion around the conventions we are using ❤️

benhalverson

comment created time in 2 hours

startednodejs/node

started time in 2 hours

startednodejs/node

started time in 2 hours

fork SilenceDB/node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

https://nodejs.org/

fork in 2 hours

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-02-19

For next week - please remove me from the meeting template. 😅

mhdawson

comment created time in 2 hours

startednodejs/nodejs-ko

started time in 2 hours

Pull request review commentnodejs/node

stream: fix broken pipeline tests

 const { promisify } = require('util');       ret += chunk;     }     return ret;-  }, common.mustCall((err, val) => {-    assert.ok(!err);-    assert.strictEqual(val, 'HELLOWORLD');+  }, mustCall((err, val) => {+    // assert.ok(!err);+    // assert.strictEqual(val, 'HELLOWORLD');

why are those commented out?

ronag

comment created time in 2 hours

Pull request review commentnodejs/node

stream: fix broken pipeline tests

 function destroyer(stream, reading, writing, callback) {      destroyImpl.destroyer(stream, err); -    callback(err || new ERR_STREAM_DESTROYED('pipe'));

What types of errors is this causing? By calling the destroyed to tear down the pipeline, we are making sure that the callback at the end is called with an error - a pipeline that is teared down before "normal" conclusion is a notable fact and an error condition. I'd be fine if this error is only created once for the pipeline and not once for every stream (same behavior, less number of Error objects)

ronag

comment created time in 2 hours

Pull request review commentnodejs/node

stream: fix broken pipeline tests

 const assert = require('assert'); const http = require('http'); const { promisify } = require('util'); +function mustCall(fn) {+  if (!fn) {+    return common.mustCall();+  }+  return common.mustCall((...args) => {+    new Promise(() => fn(...args));+  });+}

I don't understand this change, can you please articulate?

ronag

comment created time in 2 hours

Pull request review commentnodejs/node

net: autoDestroy Socket

 const server = tls.createServer(serverConfig, common.mustCall(function() {       secureProtocol: v.secureProtocol     }, common.mustCall(function() {       assert.strictEqual(this.getProtocol(), v.version);-      this.on('end', common.mustCall(function() {

is end not being emitted anymore?

ronag

comment created time in 2 hours

Pull request review commentnodejs/node

net: autoDestroy Socket

 function onexit() {         id: 'tcpconnect:1', triggerAsyncId: 'tcp:1' },       { type: 'TCPWRAP', id: 'tcp:2', triggerAsyncId: 'tcpserver:1' },       { type: 'TLSWRAP', id: 'tls:2', triggerAsyncId: 'tcpserver:1' },-      { type: 'Immediate', id: 'immediate:1', triggerAsyncId: 'tcp:2' },-      { type: 'Immediate', id: 'immediate:2', triggerAsyncId: 'tcp:1' },+      { type: 'Immediate', id: 'immediate:1', triggerAsyncId: 'tcp:1' },+      { type: 'Immediate', id: 'immediate:2', triggerAsyncId: 'tcp:2' },

Why? Can you please articulate?

ronag

comment created time in 2 hours

Pull request review commentnodejs/node

net: autoDestroy Socket

 function writeAfterFIN(chunk, encoding, cb) {   // eslint-disable-next-line no-restricted-syntax   const er = new Error('This socket has been ended by the other party');   er.code = 'EPIPE';-  process.nextTick(emitErrorNT, this, er);   if (typeof cb === 'function') {     defaultTriggerAsyncIdScope(this[async_id_symbol], process.nextTick, cb, er);   }+  errorOrDestroy(this, er, true);

It seems the errorOrDestroy utility is necessary for implementors. Can we avoid it somehow? Alternatively, we might want to consider moving it into the Readable and Writable prototypes and document it for implementors.

ronag

comment created time in 2 hours

pull request commentnodejs/docker-node

Corrected yarn version on node 10 and 13

Node 10 will be supported so long as it's not EOL (which is slated for April 2021), so I assume we'll update at some point before that. But we don't want to change the version (unless it's a security release) within an existing version of node.

GrahamCampbell

comment created time in 2 hours

issue commentnodejs/i18n

i18n WG Meeting - Feb 14

Accidentally closed this issue (on mobile), however the meeting is passed so I guess it's ok. @alexandrtovmach so excited to get things moving with your and very thankful for your continued help! 🙌

maddhruv

comment created time in 3 hours

pull request commentnodejs/docker-node

Corrected yarn version on node 10 and 13

They are scheduled to go into maintenance only in April 2020, so hopefully they will decide to do a release with some new stuff before then.

GrahamCampbell

comment created time in 3 hours

pull request commentnodejs/docker-node

Corrected yarn version on node 10 and 13

Hopefully, there will be at least one more release of node 10, otherwise you will never put yarn 1.22 in the image?

GrahamCampbell

comment created time in 3 hours

issue closednodejs/i18n

i18n WG Meeting - Feb 14

Date & Time

  • 5:00 pm GMT on Feb 14, 2020

Links

Agenda

  • Unblock translation process - https://github.com/nodejs/nodejs.org/issues/2906
  • Intl vs i18n - https://github.com/nodejs/TSC/issues/813
  • website content to be translated - https://github.com/nodejs/i18n/issues/72
  • i18n WG Meeting Time & Frequency - https://github.com/nodejs/i18n/issues/34
  • Publish a module to npm - https://github.com/nodejs/i18n/issues/92
  • Audit of our l10n groups - https://github.com/nodejs/i18n/issues/19
  • automatic approve and merge translation PRs - https://github.com/nodejs/i18n/issues/161
  • Create Crowdin Glossary - https://github.com/nodejs/i18n/issues/81 / https://github.com/nodejs/i18n/pull/91
  • In case I missed something - https://github.com/nodejs/i18n/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3Ai18n-agenda

Invited Members

  • @nodejs/i18n
  • @nodejs/website-redesign
  • @nodejs/community-committee
  • @nodejs/tsc
  • @nodejs/website

closed time in 3 hours

maddhruv

PR opened nodejs/make-node-meeting

Replace HTTP with HTTPS in template

Noticed this when Rogers hijacked the HTTP connection to tell me about their new billing mechanism.

+2 -2

0 comment

1 changed file

pr created time in 3 hours

issue commentnodejs/i18n

i18n WG Meeting - Feb 14

I'll get a reoccurring calendar invite going for everyone asap. 🙌

maddhruv

comment created time in 3 hours

issue commentnodejs/i18n

i18n WG Meeting - Feb 14

We'll likely need to do a bi-monthly or monthly meeting at a time that's ideal globally like that as well in order to make this group accessible to everyone.

maddhruv

comment created time in 3 hours

fork tniessen/make-node-meeting

Generate a text for a GitHub issue announcing a Node.js working group meeting

fork in 3 hours

PR closed nodejs/docker-node

Corrected yarn version on node 10 and 13

This change was made for node 12, but forgotten for 10 and 13.

+16 -16

1 comment

16 changed files

GrahamCampbell

pr closed time in 3 hours

pull request commentnodejs/docker-node

Corrected yarn version on node 10 and 13

We only update the yarn version on new releases of node that are not security releases.

Node 13 will be updated when 13.9.0 are available on Alpine (possibly blocked by https://github.com/nodejs/node/issues/31858) and 10 will be updated whenever 10 has a new release.

See https://github.com/nodejs/docker-node/blob/master/CONTRIBUTING.md#version-updates and https://github.com/nodejs/docker-node/blob/master/docs/BestPractices.md#upgradingdowngrading-yarn for how to upgrade yourself if you want to

GrahamCampbell

comment created time in 3 hours

issue commentnodejs/i18n

i18n WG Meeting - Feb 14

@zeke oh, sorry if there's been a miscommunication! We're meeting weekly on Fridays at 10am PT (6pm UTC) at the moment. 👍

maddhruv

comment created time in 3 hours

issue openednodejs/node

`vm.compileFunction` is missing `importModuleDynamically`

<!-- Thank you for suggesting an idea to make Node.js better.

Please fill in as much of the template below as you're able. -->

Is your feature request related to a problem? Please describe.

I'm currently working on implementing support for native ES Modules in Jest. While both vm.SourceTextModule and vm.Script allows us to define an importModuleDynamically option, this is missing from vm.compileFunction. The option is also present in runInContext and runInThisContext.

(I'm aware that vm's ESM APIs are experimental - I'm just playing with the APIs to see if they fit with Jest's use cases for them. It's currently looking really good! 🙂)

Describe the solution you'd like

The option should be added to compileFunction as well, to have parity with the other vm functions/constructs.

Describe alternatives you've considered

Not using compileFunction and sticking to vm.Script for CommonJS. I'd really like to avoid that as we just migrated to compileFunction which made V8 code coverage mapping from source maps way easier than the old manual module wrapper we use in vm.Scripts. Also, it's a bit cleaner on our side when we can avoid manually creating the module wrapper.

created time in 3 hours

issue commentnodejs/i18n

i18n WG Meeting - Feb 14

Eek! Sorry I missed this meeting, y'all.

I would love to attend the next one. Unfortunately, I don't think I can make it to that 10:30pm Pacific time slot. I'm usually offline (and asleep!) by that time. If it's possible to do another doodle that would make my chances of attendance much higher.

maddhruv

comment created time in 3 hours

startednodejs/node-chakracore

started time in 3 hours

pull request commentnodejs/docker-node

Add missing Alpine 3.9 image for node.js v13

The same situation is with the other official docker images. The Python 3.8 and 3.9 images are only available in the newer dists.

PeterDaveHello

comment created time in 3 hours

pull request commentnodejs/docker-node

Add missing Alpine 3.9 image for node.js v13

I don't think we really need this. Similarly, when node 14 is released, there won't be a 3.9 image.

PeterDaveHello

comment created time in 3 hours

PR opened nodejs/docker-node

Corrected yarn version on node 10 and 13

This change was made for node 12, but forgotten for 10 and 13.

+16 -16

0 comment

16 changed files

pr created time in 3 hours

fork geraldview/node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

https://nodejs.org/

fork in 3 hours

startednodejs/node

started time in 3 hours

fork GrahamCampbell/docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:

https://hub.docker.com/_/node/

fork in 3 hours

pull request commentnodejs/docker-node

chore: upgrade to node 12.16.1

👍

SimenB

comment created time in 3 hours

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-02-19

Not a lot on the agenda but I =know that @jasnell wanted to give a Quic update and that @sam-github wanted to have an update on the security side.

I'd also like to talk about #797 as well.

mhdawson

comment created time in 3 hours

issue commentnodejs/node

Contexts created with vm.createContext() do not define the URL() constructor

For JSDOM, we don’t want any node‑specific things (e.g.: Buffer, process, global, etc.) to be added to brand‑new contexts by default.

davidflanagan

comment created time in 3 hours

pull request commentnodejs/node

stream: use callback to properly propagate error

CI: https://ci.nodejs.org/job/node-test-pull-request/29226/

ronag

comment created time in 4 hours

pull request commentnodejs/node

stream: use callback to properly propagate error

CI: https://ci.nodejs.org/job/node-test-pull-request/29225/

ronag

comment created time in 4 hours

PR closed nodejs/node

Reviewers
doc: fix Writable.write callback description author ready doc stream

Clarifies a userland invariant until a better solution can be found.

Also moves a misplaced sentence from _write to write.

Refs: https://github.com/nodejs/node/pull/31756 Refs: https://github.com/nodejs/node/pull/31765

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md -->

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] tests and/or benchmarks are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+4 -4

10 comments

1 changed file

ronag

pr closed time in 4 hours

pull request commentnodejs/node

doc: fix Writable.write callback description

Landed in 7c524fb092b1

ronag

comment created time in 4 hours

push eventnodejs/node

Robert Nagy

commit sha 7c524fb092b143470795c8ca869de4654c728fe1

doc: fix Writable.write callback description Clarifies a userland invariant until a better solution can be found. Also moves a misplaced sentence from _write to write. Refs: https://github.com/nodejs/node/pull/31756 Refs: https://github.com/nodejs/node/pull/31765 PR-URL: https://github.com/nodejs/node/pull/31812 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 4 hours

startednodejs/nodejs.org

started time in 4 hours

issue commentnodejs/node

v13.9.0 tarball seems to be missing `deps/zlib/contrib`

Is it just contrib/optimizations that we need to add?

Probably.

mhart

comment created time in 4 hours

issue openednodejs/build

Access to VM?

I am struggling with resolving a bug specific to a specific build on CI. In particular this PR fails on two specific platforms and currently I have no viable way of debugging this.

Is it possible to get access to a VM or a VM image of the failing environments that I can use to quickly change, build end debug?

Alternatively some other way that this can be more easily debugged? Currently I'm left with guessing fixes and pushing to the repo in order to restrt the specific CI job and hoping it passes.

created time in 4 hours

issue commentnodejs/node-gyp

Build failure on Node 12.3.1

node v10.19.0 worked for me.

robd003

comment created time in 4 hours

Pull request review commentnodejs/node

lib: refactor isLegalPort, move to validators

 Socket.prototype.bind = function(port_, address_ /* , callback */) {   return this; }; --function validatePort(port) {-  const legal = isLegalPort(port);-  if (legal)-    port = port | 0;

Ok, not allowing zero is now accounted for.

jasnell

comment created time in 4 hours

startednodejs/i18n

started time in 4 hours

Pull request review commentnodejs/node

lib: refactor isLegalPort, move to validators

 Socket.prototype.bind = function(port_, address_ /* , callback */) {   return this; }; --function validatePort(port) {-  const legal = isLegalPort(port);-  if (legal)-    port = port | 0;

Ugh. ok

jasnell

comment created time in 4 hours

issue openednodejs/i18n

l10n (Spanish)

Hi there! 👋

Thanks for moving forward the initiative and I'm happy to facilitate more people into translating content. My goal would be to keep this repo up-to-date with relevant information and possibly add people to the @nodejs/nodejs-es team. I wanted first to ask a few things I struggled to understand so that we can work on a better CONTRIBUTING.MD.

  • source of truth: I saw crowdin is being used and seems really nice, my question would be if every changes that are reflected automatically into https://github.com/nodejs/i18n/tree/master/content/v10.x/es-ES/doc or there's a PR someone can comment on the changes then merge
  • content on the website: if I select PT-BR as language on the website and go to the Guides section, even though those are translated the links point to the English versions (screenshot below) image Is this because a website pending change? Is it something the localization team should tackle?

It would also be great to hear from your experiences if there were people able to contribute without having to deal with any GitHub-related tasks.

created time in 4 hours

PR opened nodejs/node

doc: prevent tables from shrinking page
Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

This change prevents tables from growing so wide that they shrink the page on mobile.

Problem (currently on https://nodejs.org/api/crypto.html):

nodejs org_dist_latest-v13 x_docs_api_crypto html(iPhone 6_7_8)

Now, on phones, table content will break if it has to, so the page loads the same width as all the other pages. The padding's a tiny bit less, too.

nodejs org_dist_latest-v13 x_docs_api_crypto html(iPhone 6_7_8) (1)

On larger screens, the first column is prevented from wrapping, since it often contains variables. Content in other columns will still wrap (note the URLs wrap, which they don't currently).

nodejs org_dist_latest-v13 x_docs_api_crypto html(iPad)

+17 -1

0 comment

1 changed file

pr created time in 4 hours

startednodejs/node-gyp

started time in 4 hours

issue commentnodejs/node-gyp

Build failure on Node 12.3.1

node v12.16.1 also failed. Going to try with version 10

robd003

comment created time in 4 hours

fork stjeffrey/docker-node

Official Docker Image for Node.js :whale: :turtle: :rocket:

https://hub.docker.com/_/node/

fork in 4 hours

fork silentknight10/node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

https://nodejs.org/

fork in 5 hours

PR closed nodejs/node

v12.16.1 proposal C++ meta n-api v12.x

2020-02-18, Version 12.16.1 'Erbium' (LTS), @MylesBorins

Notable changes

Node.js 12.16.0 included 6 regressions that are being fixed in this release

Accidental Unflagging of Self Resolving Modules:

12.16.0 included a large update to the ESM implementation. One of the new features, Self Referential Modules, was accidentally released without requiring the --experimental-modules flag. This release is being made to appropriately flag the feature.

Process Cleanup Changed Introduced WASM-Related Assertion:

A change during Node.js process cleanup led to a crash in combination with specific usage of WASM. This has been fixed by partially reverted said change. A regression test and a full fix are being worked on and will likely be included in future 12.x and 13.x releases.

Use Largepages Runtime Option Introduced Linking Failure:

A Semver-Minor change to introduce --use-largepages as a runtime option introduced a linking failure. This had been fixed in master but regressed as the fix has not yet gone out in a Current release. The feature has been reverted, but will be able to reland with a fix in a future Semver-Minor release.

Async Hooks was Causing an Exception When Handling Errors:

Changes in async hooks internals introduced a case where an internal api call could be called with undefined causing a process to crash. The change to async hooks was reverted. A regression test and fix has been proposed and the change could re-land in a future Semver-Patch release if the regression is reliably fixed.

New Enumerable Read-Only Property on EventEmitter breaks @types/extend

A new property for enumerating events was added to the EventEmitter class. This broke existing code that was using the @types/extend module for extending classses as @types/extend was attemping to write over the existing field which the new change made read-only. As this is the first property on EventEmitter that is read-only this feature could be considered Semver-Major. The new feature has been reverted but could re-land in a future Semver-Minor release if a non breaking way of applying it is found.

Exceptions in the HTTP parser were not emitting an uncaughtException

A refactoring to Node.js interanls resulted in a bug where errors in the HTTP parser were not being emitted by process.on('uncaughtException') when the async_hooks after hook exists. The fix to this bug has been included in this release.

Commits

  • [51fdd759b9] - async_hooks: ensure event after been emitted on runInAsyncScope (legendecas) #31784
  • [7a1b0ac06f] - Revert "build: re-introduce --use-largepages as no-op" (Myles Borins) #31782
  • [a53eeca2a9] - Revert "build: switch realpath to pwd" (Myles Borins) #31782
  • [6d432994e6] - Revert "build: warn upon --use-largepages config option" (Myles Borins) #31782
  • [a5bc00af12] - Revert "events: allow monitoring error events" (Myles Borins)
  • [f0b2d875d9] - module: 12.x self resolve flag as experimental modules (Guy Bedford) #31757
  • [42b68a4e24] - src: inform callback scopes about exceptions in HTTP parser (Anna Henningsen) #31801
  • [065a32f064] - Revert "src: make --use-largepages a runtime option" (Myles Borins) #31782
  • [3d5beebc62] - Revert "src: make large_pages node.cc include conditional" (Myles Borins) #31782
  • [43d02e20e0] - src: keep main-thread Isolate attached to platform during Dispose (Anna Henningsen) #31795
  • [7a5954ef26] - src: fix -Winconsistent-missing-override warning (Colin Ihrig) #30549
+191 -229

29 comments

25 changed files

MylesBorins

pr closed time in 5 hours

pull request commentnodejs/node

v12.16.1 proposal

landed in d3fb1680dc

MylesBorins

comment created time in 5 hours

Pull request review commentnodejs/node

doc: add note about ssh key to releases

 formatting passes the lint rules on `master`. to promote the builds as the `SHASUMS256.txt` file needs to be signed with the same GPG key!** -Use `tools/release.sh` to promote and sign the build. When run, it will perform-the following actions:+Use `tools/release.sh` to promote and sign the build. Before doing this, you'll+need to ensure you've loaded the correct ssh key, or you'll see the following:++```sh+# Checking for releases ...+Enter passphrase for key '/Users/<user>/.ssh/id_rsa':+dist@direct.nodejs.org's password:+```++You can specify this at run-time if need be with:

should we add a note about loading your key via ssh-add ~/.ssh/id_rsa_${key}?

codebytere

comment created time in 5 hours

Pull request review commentnodejs/node

doc: add note about ssh key to releases

 formatting passes the lint rules on `master`. to promote the builds as the `SHASUMS256.txt` file needs to be signed with the same GPG key!** -Use `tools/release.sh` to promote and sign the build. When run, it will perform-the following actions:+Use `tools/release.sh` to promote and sign the build. Before doing this, you'll+need to ensure you've loaded the correct ssh key, or you'll see the following:++```sh+# Checking for releases ...+Enter passphrase for key '/Users/<user>/.ssh/id_rsa':+dist@direct.nodejs.org's password:+```++You can specify this at run-time if need be with:+```sh+# Substitute node_id_rsa with whatever you've named the key+$ ./tools/release.sh -i ~/.ssh/node_id_rsa+```++When run, `tools/release.sh` will perform the following actions:
`tools/release.sh` will perform the following actions when run:

nit

codebytere

comment created time in 5 hours

push eventnodejs/node

Shelley Vohr

commit sha 31290824de068eb4b282ab74829450b988ae225b

doc: fix notable changes for v13.9.0 PR-URL: https://github.com/nodejs/node/pull/31857 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

push time in 5 hours

PR closed nodejs/node

doc: fix notable changes for v13.9.0 doc fast-track

Fixes Notable Changes for v13.9.0. They're correct in the release commit and in the blog post, but I whiffed on them here.

cc @BethGriggs

Checklist

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines

<!-- Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

+21 -8

2 comments

1 changed file

codebytere

pr closed time in 5 hours

pull request commentnodejs/node

doc: fix notable changes for v13.9.0

Landed in 31290824de06

codebytere

comment created time in 5 hours

fork amahaulu/node

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

https://nodejs.org/

fork in 5 hours

fork Acidburn0zzz/node-1

Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:

https://nodejs.org/

fork in 5 hours

issue openednodejs/Release

Rename Current release line Canary?

It's been a couple years since we've changed the names of things so I figured this might be worth discussing. My personal understanding of the "current" release line is that it gets anything on master that isn't semver-major, and there is a non-trivial chance of bugs / regressions showing up. This is imho a feature of the "current" release line. That said folks are using it in production and I've spoken to a number of people who were unaware that things are not entirely "stable" (the old name for current).

As such I feel a name like "canary" might be more appropriate.

Thoughts?

created time in 5 hours

pull request commentnodejs/node

doc: add zlib maintenance doc

CI: https://ci.nodejs.org/job/node-test-pull-request/29224/

sam-github

comment created time in 5 hours

startednodejs/http-parser

started time in 5 hours

pull request commentnodejs/node

doc: fix notable changes for v13.9.0

fast track?

codebytere

comment created time in 5 hours

push eventnodejs/node

Myles Borins

commit sha db125c561880d8b2b272fb85c7a3baa91fcec31a

doc: fix missing changelog corrections There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch. PR-URL: https://github.com/nodejs/node/pull/31854 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

push time in 5 hours

PR closed nodejs/node

doc: fix missing changelog corrections doc fast-track

There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch.

+4 -4

2 comments

1 changed file

MylesBorins

pr closed time in 5 hours

pull request commentnodejs/node

doc: fix missing changelog corrections

Landed in 43fb664701d7

MylesBorins

comment created time in 5 hours

push eventnodejs/node

Myles Borins

commit sha 43fb664701d771c00595fa1c152cfca03b10a4fd

doc: fix missing changelog corrections There was a slight discrepancy between the build of 12.16.1 and what landed on 12.x. This was only a couple spelling errors that didn't get updated between machines I was working on. This change gets the changelog up to date with what went out in the release vs what is current on the 12.x release branch. PR-URL: https://github.com/nodejs/node/pull/31854 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

view details

push time in 5 hours

issue commentnodejs/TSC

De-charter Benchmark WG

We'll need some volunteers to help with whatever we decided to keep around.

I can help with that. Maybe we should keep the @nodejs/benchmarking team around then, so that others can ping when there are benchmark-related issues?

mhdawson

comment created time in 5 hours

Pull request review commentnodejs/node

module: disable conditional exports, self resolve warnings

 class Loader {   }    async resolve(specifier, parentURL) {+    if (parentURL instanceof URL)

Agreed. Yeah it seems like it's not clear enough to be a simple change - ok I've reverted the URL change for now.

guybedford

comment created time in 5 hours

pull request commentnodejs/node

test: remove common.PORT from test-net-write-callbacks.js

CI: https://ci.nodejs.org/job/node-test-pull-request/29223/

Trott

comment created time in 5 hours

pull request commentnodejs/remark-preset-lint-node

feat: prohibit possessive form of Node.js

/ping @nodejs/linting

Trott

comment created time in 5 hours

more