profile
viewpoint
Noah Dietz noahdietz Google/ @googleapis United States https://www.noahdietz.me/

googleapis/go-genproto 440

Generated code for Google Cloud client libraries.

apigee-127/sway 183

A library that simplifies OpenAPI (fka Swagger) integrations/tooling.

apigee-127/swagger-test-templates 162

Test code generated from Swagger

googleapis/gapic-generator-go 137

Generate Go API client libraries from Protocol Buffers.

googleapis/gapic-showcase 84

An API that demonstrates Generated API Client (GAPIC) features and common API patterns used by Google.

apigee/apigeetool-node 78

"apigeetool" implementation in Node.js for managing Apigee Edge apps and proxies

googleapis/grpc-fallback-go 48

A lightweight proxy that connects gRPC to HTTP/1.1

apigee-127/swagger-testing 16

Automated API Testing Using SwaggerAPI

googleapis/gapic-config-validator 9

protoc plugin that validates GAPIC config proto annotations

pull request commentGoogleCloudPlatform/golang-samples

fix(compute): fix compute API usage after some breaking changes

Yeah updating version of storage to v1.18.2 should fix it.

codyoss

comment created time in 3 days

pull request commentGoogleCloudPlatform/golang-samples

fix(compute): fix compute API usage after some breaking changes

Potentially need to update to storage@v1.18.2?

codyoss

comment created time in 3 days

pull request commentGoogleCloudPlatform/golang-samples

fix(compute): fix compute API usage after some breaking changes

Looks like there is something wrong with the Storage code

codyoss

comment created time in 3 days

pull request commentGoogleCloudPlatform/golang-samples

fix(compute): fix compute API usage after some breaking changes

Thank you for updating these.

codyoss

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentgoogleapis/gapic-generator-go

Add support for some complex URL paths in generated REST clients.

 func (g *generator) generateURLString(m *descriptor.MethodDescriptorProto) error 	fmtStr := info.url 	// TODO(dovs): handle more complex path urls involving = and *, 	// e.g. v1beta1/repeat/{info.f_string=first/*}/{info.f_child.f_string=second/**}:pathtrailingresource-	re := regexp.MustCompile(`{([a-zA-Z0-9_.]+?)}`)+	re := regexp.MustCompile(`{([a-zA-Z0-9_.]+?)(=[^}]+)?}`)

I think we'd also want to disallow { to ensure there are no nested variables. Also not a big deal.

timburks

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentgoogleapis/gapic-generator-go

Add support for some complex URL paths in generated REST clients.

 func (g *generator) generateURLString(m *descriptor.MethodDescriptorProto) error 	fmtStr := info.url 	// TODO(dovs): handle more complex path urls involving = and *, 	// e.g. v1beta1/repeat/{info.f_string=first/*}/{info.f_child.f_string=second/**}:pathtrailingresource-	re := regexp.MustCompile(`{([a-zA-Z0-9_.]+?)}`)+	re := regexp.MustCompile(`{([a-zA-Z0-9_.]+?)(=[^}]+)?}`)

yeah this would capture the = in the second capture group, but idk if we even need that value tbh so not a big deal.

timburks

comment created time in 3 days

Pull request review commentgoogleapis/gapic-generator-go

Add support for some complex URL paths in generated REST clients.

 func (g *generator) shouldDisableComplexPaths(m *descriptor.MethodDescriptorProt  	info, _ := getHTTPInfo(m) -	re := regexp.MustCompile(`[^a-zA-Z0-9_.]+?`)-	pathParams := g.pathParams(m)-	for pName := range pathParams {-		if re.MatchString(pName) {-			p(`    return nil, fmt.Errorf("complex url paths are not yet supported: %s")`, info.url)-			p("}")-			p("")-			return true-		}+	if len(g.pathParams(m)) > 1 {

Agreed

timburks

comment created time in 3 days

PullRequestReviewEvent

push eventgoogleapis/googleapis

noahdietz

commit sha 72ca29250a1636b3b3052973f2f445fbf327c133

add missing diregapic flag

view details

push time in 3 days

push eventnoahdietz/common-protos-php

Brent Shaffer

commit sha b1ee63636d94fe88f6cff600a0f23fae06b6fa2e

feat: update routing and extended-operations protos (#26)

view details

Brent Shaffer

commit sha 32a023125e767f72f2917e5a91eafe7a83ac99e7

chore: switch to main (#28)

view details

push time in 3 days

create barnchnoahdietz/common-protos-php

branch : main

created branch time in 3 days

push eventnoahdietz/gapic-generator-php

Brent Shaffer

commit sha a0bf471bdc6542e9a3cbde1374ade4357fabae3b

fix: link in php docs (#418)

view details

Brent Shaffer

commit sha fba81258034261caa0bdb98f36bc3258c91e58cf

chore: switch from master to main (#419)

view details

Brent Shaffer

commit sha 30293bdc1356e321e08cc44318701ec02881310d

chore: remove main branch (#421) I added both branches for a second so that the checks could pass against master before the branch was renamed. now they can be removed.

view details

push time in 3 days

create barnchnoahdietz/gapic-generator-php

branch : main

created branch time in 3 days

delete branch noahdietz/gapic-generator-php

delete branch : reno

delete time in 3 days

delete branch noahdietz/gapic-generator-php

delete branch : release-v1.1.0

delete time in 3 days

delete branch noahdietz/gapic-generator-php

delete branch : main/oneofs

delete time in 3 days

delete branch noahdietz/gapic-generator-php

delete branch : dev/diregapic-strict_deps

delete time in 3 days

delete branch noahdietz/gapic-generator-php

delete branch : release-v0.2.0

delete time in 3 days

delete branch noahdietz/gapic-generator-php

delete branch : dev/experimental_tags

delete time in 3 days

delete branch noahdietz/gapic-generator-php

delete branch : bcb-to-fb

delete time in 3 days

delete branch noahdietz/gapic-generator-php

delete branch : diregapic-main

delete time in 3 days

create barnchnoahdietz/gapic-generator-php

branch : diregapic-constants

created branch time in 3 days

create barnchgoogleapis/gapic-generator-php

branch : update-owners

created branch time in 3 days

Pull request review commentgoogleapis/googleapis

chore(compute): include Go GAPIC targets

 java_gapic_assembly_gradle_pkg(     ], ) +##############################################################################+# Go+##############################################################################+load(+    "@com_google_googleapis_imports//:imports.bzl",+    "go_gapic_assembly_pkg",+    "go_gapic_library",+    "go_proto_library",+    "go_test",+)++go_proto_library(+    name = "compute_go_proto",+    importpath = "google.golang.org/genproto/googleapis/cloud/compute/v1",+    protos = [":compute_proto"],+    deps = [+        "//google/api:annotations_go_proto",+    ],+)++go_gapic_library(+    name = "compute_go_gapic",+    srcs = [":compute_proto_with_info"],+    grpc_service_config = "compute_grpc_service_config.json",+    importpath = "cloud.google.com/go/compute/apiv1;compute",+    service_yaml = "compute_v1.yaml",+    transport = ["rest"],+    deps = [+        ":compute_go_proto",+    ],+)++go_test(+    name = "compute_go_gapic_test",+    srcs = [":compute_go_gapic_srcjar_test"],+    embed = [":compute_go_gapic"],+    importpath = "cloud.google.com/go/compute/apiv1",+)++# Open Source Packages+go_gapic_assembly_pkg(

Nope we do not need transport parameter for assembly. The transport param just toggles which transport interface implementations to generate. REST and/or gRPC. The code all goes into the same files, etc.

noahdietz

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentgoogleapis/googleapis

chore(compute): include Go GAPIC targets

 java_gapic_assembly_gradle_pkg(     ], ) +##############################################################################+# Go+##############################################################################+load(+    "@com_google_googleapis_imports//:imports.bzl",+    "go_gapic_assembly_pkg",+    "go_gapic_library",+    "go_proto_library",+    "go_test",+)++go_proto_library(+    name = "compute_go_proto",+    importpath = "google.golang.org/genproto/googleapis/cloud/compute/v1",+    protos = [":compute_proto"],+    deps = [+        "//google/api:annotations_go_proto",+    ],+)++go_gapic_library(+    name = "compute_go_gapic",+    srcs = [":compute_proto_with_info"],+    grpc_service_config = "compute_grpc_service_config.json",+    importpath = "cloud.google.com/go/compute/apiv1;compute",+    service_yaml = "compute_v1.yaml",+    transport = ["rest"],

Yep, it has been supported for some time, it is just omitted from build_gen.

noahdietz

comment created time in 3 days

PullRequestReviewEvent
more