profile
viewpoint

push eventKhan/math-input

Nick Rowe

commit sha 9547dfb76fc0b7cd2ab1875982f8f4fd799a1dbc

Fix String interpolation (#43)

view details

push time in 3 days

PR merged Khan/math-input

Fix String interpolation

Fixes missing babel plugin for string interpolation.

+31 -0

0 comment

3 changed files

nixterrimus

pr closed time in 3 days

PR opened Khan/math-input

Fix up missing babel plugin

Fixes missing babel plugin for string interpolation.

+31 -0

0 comment

3 changed files

pr created time in 3 days

create barnchKhan/math-input

branch : babel_fix

created branch time in 3 days

pull request commentKhan/math-input

WIP Webpack upgrade

Screen Shot 2020-01-14 at 11 38 51 AM

Math doesn't work yet. This should be 5 squared

nixterrimus

comment created time in 3 days

push eventKhan/math-input

Nicholas Rowe

commit sha b3e92efabb051e74caca8c6bd112ffd779c30324

Resolve jquery locally

view details

push time in 3 days

push eventKhan/math-input

Nicholas Rowe

commit sha dbfb30e1c6a5372b09e139030780d56026f5ee07

Notes about further upgrades

view details

push time in 3 days

PR opened Khan/math-input

WIP Webpack upgrade
+9165 -689

0 comment

10 changed files

pr created time in 4 days

create barnchKhan/math-input

branch : webpack_upgrade

created branch time in 4 days

push eventnixterrimus/math-input

Nicholas Rowe

commit sha 83c0c676c94e3fea39741a86cf1443016ca1aa5a

tests run again

view details

push time in 4 days

Pull request review commentKhan/math-input

Upgrade to babel 7

         }     </style> </head>+ <body> -<div id="root"></div>+    <div id="root"></div> -<script src="lib/i18n.js"></script>-<script src="lib/icu-slim.js"></script>-<script src="node_modules/jquery/dist/jquery.min.js"></script>-<script src="mathquill/mathquill.js"></script>-<script src="node_modules/babel-polyfill/browser.js"></script>

I am nervous about removing this @kevinbarabash. Everything seems to work but there also doesn't seem to be a replacement. Does that seem right to you?

nixterrimus

comment created time in 4 days

Pull request review commentKhan/math-input

Upgrade to babel 7

 module.exports = {                 loader: 'babel',                 query: {                     presets: [-                        ["es2015", {"loose": true}],-                        "react",-                        "stage-2",+                        "@babel/env",

Done!

nixterrimus

comment created time in 4 days

Pull request review commentKhan/math-input

Upgrade to babel 7

 class App extends React.Component {         keypadType: consts.KeypadTypes.EXPRESSION,     }; -    handleChange = (e: SyntheticEvent<>) => {

Right? This should not have worked!

nixterrimus

comment created time in 4 days

push eventnixterrimus/math-input

Nicholas Rowe

commit sha c619554f2865476f6f2a56f8aa543e5c5d6b3a84

Remove no-longer-needed babel polyfill

view details

push time in 4 days

push eventnixterrimus/math-input

Nicholas Rowe

commit sha 6f992af84e7f19b51d797099b47cc1e0b3b089a6

Add browserslistrc

view details

push time in 4 days

push eventnixterrimus/AOC-19

Nick Rowe

commit sha 826033414ce9723711cd889d2ebbe19b57297d3d

Readme

view details

push time in 7 days

create barnchnixterrimus/AOC-19

branch : master

created branch time in 7 days

created repositorynixterrimus/AOC-19

created time in 7 days

PR closed nixterrimus/math-input

WIP migrate to Jest
+2063 -153

0 comment

10 changed files

nixterrimus

pr closed time in 8 days

PR opened nixterrimus/math-input

WIP migrate to Jest
+2063 -153

0 comment

10 changed files

pr created time in 8 days

create barnchnixterrimus/math-input

branch : jest

created branch time in 8 days

PR opened Khan/math-input

Reviewers
Upgrade to babel 7

Upgrades this project to babel 7. This is a prerequisite for migrating to jest.

+1910 -833

0 comment

5 changed files

pr created time in 8 days

create barnchnixterrimus/math-input

branch : babel-upgrade

created branch time in 8 days

push eventKhan/math-input

Nick Rowe

commit sha 4a7e359fba7d66c63f8f87d0dd528d7dd1b880d7

Hardware keyboard input (#36) Adds the ability to use a hardware keyboard with the math input. This allows basic input of numbers, operators, and the delete key. In the future we could choose to allow multi character input (like != or >=) and complex input (like sin, cos, tan), and more movement keys (like arrows, control+a, control+e). All of these things will greatly increase the complexity in the implementation and might be platform dependent so we want to wait until learners give a clear signal that they want these features.

view details

push time in a month

PR merged Khan/math-input

Reviewers
Hardware keyboard input

Adds the ability to use a hardware keyboard with the math input. This allows basic input of numbers, operators, and the delete key.

In the future we could choose to allow multi character input (like != or >=) and complex input (like sin, cos, tan), and more movement keys (like arrows, control+a, control+e). All of these things will greatly increase the complexity in the implementation and might be platform dependent so we want to wait until learners give a clear signal that they want these features.

+51 -0

2 comments

1 changed file

nixterrimus

pr closed time in a month

push eventnixterrimus/math-input

Nicholas Rowe

commit sha 5a7855a66e5434a834eab00ab3e70af45b1471a1

Feedback

view details

push time in a month

push eventnixterrimus/math-input

Nicholas Rowe

commit sha ba98f9152e70b5b9bb4af50226c1c2c7d727cb61

Feedback

view details

Nicholas Rowe

commit sha 14301197fae1589ec41d591d230a480cb30a26b6

Revert "Feedback" This reverts commit 5a7855a66e5434a834eab00ab3e70af45b1471a1.

view details

push time in a month

push eventnixterrimus/math-input

Nicholas Rowe

commit sha d00fbb6328582a928aa1d53a55e053660ea8f00e

Make sure the cursor is hidden

view details

push time in a month

PR opened Khan/math-input

WIP hardware keyboard input

Adds the ability to use a hardware keyboard with the math input.

+55 -0

0 comment

1 changed file

pr created time in a month

create barnchnixterrimus/math-input

branch : hardware_keyboard_input

created branch time in a month

push eventKhan/math-input

Nick Rowe

commit sha e745368823b53bf60d8b1a15eb9b2a976bc1d703

Keep focus on input after entering a key (#32) Keeps the focus on the keypad after entering a key by listening for changes to the focus event. In future revisions we need to listen for keyboard events when focused and handle focus/blur events for showing and hiding the keyboard.

view details

push time in a month

PR merged Khan/math-input

Reviewers
Keep focus on input after entering a key

Keeps the focus on the keypad after entering a key by listening for changes to the focus event.

In future revisions we need to listen for keyboard events when focused and handle focus/blur events for showing and hiding the keyboard.

+44 -1

0 comment

1 changed file

nixterrimus

pr closed time in a month

Pull request review commentKhan/math-input

Keep focus on input after entering a key

 class MathInput extends React.Component {         this._keypadBounds = keypadNode.getBoundingClientRect();     }; +    _keepInputFocus = event => {+        if (!this.state.focused) {+          return;+        }+    +        if (event.relatedTarget === null) {+          event.preventDefault();+          this.inputRef.focus();

I believe the flow still works out ok (at least in my testing!). I've added a bunch of comments to make more clear what's going on here. Thank you for the suggestion.

nixterrimus

comment created time in 2 months

Pull request review commentKhan/math-input

Keep focus on input after entering a key

 class MathInput extends React.Component {         window.removeEventListener('resize', this._clearKeypadBoundsCache());         window.removeEventListener(                 'orientationchange', this._clearKeypadBoundsCache());+        window.document.addEventListener("focusout", this._keepInputFocus);

Yep. :( Fixed!

nixterrimus

comment created time in 2 months

push eventnixterrimus/math-input

Nicholas Rowe

commit sha 8ca5a4eaa97d99979eae26df125c565084a0f9ae

Comments and corrections

view details

push time in 2 months

Pull request review commentKhan/math-input

Keep focus on input after entering a key

 class MathInput extends React.Component {         >             {/* NOTE(charlie): This is used purely to namespace the styles in                 overrides.css. */}-            <div className='keypad-input'>+            <div +                className="keypad-input"+                tabIndex={"0"}+                ref={ref => {

Fixed! ✨ Write

nixterrimus

comment created time in 2 months

push eventnixterrimus/math-input

Nicholas Rowe

commit sha 5c8192cf238a8f56c77d73c564e86e7bae059b6c

Fix naming

view details

push time in 2 months

Pull request review commentKhan/math-input

Keep focus on input after entering a key

 class MathInput extends React.Component {         this._keypadBounds = keypadNode.getBoundingClientRect();     }; +    _keepInputFocus = event => {+        if (!this.state.focused) {+          return;+        }+    +        if (event.relatedTarget === null) {+          event.preventDefault();+          this.inputRef.focus();+        } else {+          this.inputRef.blur();

This is for when a learner tabs beyond the field.

nixterrimus

comment created time in 2 months

Pull request review commentKhan/math-input

Keep focus on input after entering a key

 class MathInput extends React.Component {         this._keypadBounds = keypadNode.getBoundingClientRect();     }; +    _keepInputFocus = event => {+        if (!this.state.focused) {+          return;+        }+    +        if (event.relatedTarget === null) {+          event.preventDefault();+          this.inputRef.focus();

This only happens if THIS input is focused. There's a check for that at the start of this block

nixterrimus

comment created time in 2 months

PR opened Khan/math-input

Keep focus on input after entering a key

Keeps the focus on the keypad after entering a key by listening for changes to the focus event.

In future revisions we need to listen for keyboard events when focused and handle focus/blur events for showing and hiding the keyboard.

+24 -1

0 comment

1 changed file

pr created time in 2 months

create barnchnixterrimus/math-input

branch : keep_focus_on_input

created branch time in 2 months

fork nixterrimus/math-input

math-input = react + redux + mathquill

fork in 2 months

more