niw ( Yoshimasa Niwa )

Thanks, good to know I'm on the right track. I certainly understand the difficulties with textView(_:shouldChangeTextIn:replacementText:), which is one of the reasons I'm using TwitterTextEditor (thanks!). You may want to vend a conforming type users can use to customize the response. As it is now, returning the incoming value or nil seem to do the same thing in the delegate method.

By the way, for limiting number of characters, I recommend to not actually limit number of characters by the text editor level, but provides commit action to users such as adding Save or Send button to the interface then decide if application accepts the text or not when these buttons are tapped. Because users may want to type more and then polish it in regular typing situation, so if it is limited by the number characters, it might be annoying. Well, it’s just ”in general” for regular user experiences. It might be vary for the application requirements.

That's what I argued for, but the requirements went the other way. 😢

jshier

comment created time in 4 days

issue commenttwitter/TwitterTextEditor

UITextViewDelegate-like functionality?

Adding my own conforming type seems to work.

extension TextEditor: TextEditorViewEditingContentDelegate {
    func textEditorView(_ textEditorView: TextEditorView,
                        updateEditingContent editingContent: TextEditorViewEditingContent)
    -> TextEditorViewEditingContent? {
        guard editingContent.text.count > maximumCharacterCount else { return editingContent }
        
        return EditedContent(text: String(editingContent.text.prefix(maximumCharacterCount)),
                             selectedRange: NSRange(location: maximumCharacterCount, length: 0))
    }
}

private struct EditedContent: TextEditorViewEditingContent {
    var text: String
    
    var selectedRange: NSRange
}

jshier

comment created time in 4 days

issue openedtwitter/TwitterTextEditor

UITextViewDelegate-like functionality?

Question

UITextViewDelegate allows you to control whether the user's edits take effect through textView(_:shouldChangeTextIn:replacementText:). I can find no replacement for TwitterTextEditor. The closest I can find is TextEditorViewEditingContentDelegate's textEditorView(_:updateEditingContent) method, but returning nil from that method doesn't seem to have the affect I want (not applying the change). It seems like I should be able to create my own editing content, but there are no types which publicly conform to TextEditorViewEditingContent. Am I supposed to create my own conforming type? In any case, it seems like this functionality should be simpler.

created time in 4 days

startedniw/HapticKey

started time in 6 days

startedniw/KeyboardGuide

started time in 6 days

startedniw/KeyboardGuide

started time in 7 days

startedniw/HapticKey

started time in 7 days

issue openedniw/HapticKey

Release a new version?

As #42 #43 have been merged, and M1 devices has been released for months. I think it's a good idea to release a version with those fixes?