Codecov Report

commit sha a3d86d880b220a09f68401756011da650cd52b3d

Review feedback

Connection pool alternative implementation

push time in 2 hours

Pull request review commenteclipse-vertx/vert.x

+/*+ * Copyright (c) 2011-2019 Contributors to the Eclipse Foundation+ *+ * This program and the accompanying materials are made available under the+ * terms of the Eclipse Public License 2.0 which is available at+ * http://www.eclipse.org/legal/epl-2.0, or the Apache License, Version 2.0+ * which is available at https://www.apache.org/licenses/LICENSE-2.0.+ *+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0+ */++package io.vertx.benchmarks;++import io.vertx.core.net.impl.pool.LockSynchronization;+import io.vertx.core.net.impl.pool.NonBlockingSynchronization1;+import io.vertx.core.net.impl.pool.NonBlockingSynchronization2;+import io.vertx.core.net.impl.pool.Synchronization;+import org.openjdk.jmh.annotations.Benchmark;+import org.openjdk.jmh.annotations.BenchmarkMode;+import org.openjdk.jmh.annotations.Measurement;+import org.openjdk.jmh.annotations.Mode;+import org.openjdk.jmh.annotations.Scope;+import org.openjdk.jmh.annotations.Setup;+import org.openjdk.jmh.annotations.State;+import org.openjdk.jmh.annotations.TearDown;+import org.openjdk.jmh.annotations.Threads;+import org.openjdk.jmh.annotations.Warmup;+import org.openjdk.jmh.infra.Blackhole;++import java.util.concurrent.CountDownLatch;+import java.util.concurrent.TimeUnit;++import static java.util.concurrent.TimeUnit.MILLISECONDS;++/**+ * @author Thomas Segismont+ * @author slinkydeveloper+ */+@State(Scope.Benchmark)+@Warmup(iterations = 20, time = 200, timeUnit = TimeUnit.MILLISECONDS)+@Measurement(iterations = 10, time = 200, timeUnit = MILLISECONDS)+@Threads(2)+public class SynchronizationBenchmark extends BenchmarkBase {++  private Synchronization<Object> synchronization1;+  private Synchronization<Object> synchronization2;+  private Synchronization.Action<Object> action;++  private CountDownLatch latch = new CountDownLatch(1);++  @Setup+  public void setup() throws Exception {+    synchronization1 = new NonBlockingSynchronization1<>(new Object());+    synchronization2 = new NonBlockingSynchronization2<>(new Object());+    action = state -> {+      Blackhole.consumeCPU(0);+      return null;+    };+    CountDownLatch l = new CountDownLatch(2);+    new Thread(() -> {+      synchronization1.execute(state -> {+        l.countDown();+        try {+          latch.await();+        } catch (InterruptedException e) {+          e.printStackTrace();+        }+        return null;+      });+    }).start();+    new Thread(() -> {+      synchronization2.execute(state -> {+        l.countDown();+        try {+          latch.await();+        } catch (InterruptedException e) {+          e.printStackTrace();+        }+        return null;+      });+    }).start();+    l.await(20, TimeUnit.SECONDS);+  }++  @TearDown+  public void tearDown() {+    latch.countDown();+  }++  @Benchmark+  public void lock1() {+    synchronization1.execute(action);

it is actually the intention to measure the submission cost to compare the two implementations. I think what you describe can be another benchmark.

vietj

comment created time in 2 hours

push eventeclipse-vertx/vert.x

commit sha f2f1ccf12344547fce12ca8481751325181ad36f

The ChannelProvider should deliver connection on an handler in order to avoid connection races when the connection is performed on a non vertx thread to avoid message losses. For the same reason the HttpChannelConnector should use a promise internally.

commit sha 689af8f4f7ab6c713d01493c9225bd558ceabbc7

Draft pool API and implementation

commit sha c3d97bf964d3391ac30fb9bd8bebaa4c26db6250

Make API async

commit sha 3c8db0dc3944f2bfcc8dbc2bcaaa5223687b79db

Use factory methods

commit sha 16dbc84fea9759851eba19685c87ac5aac252193

Internal pool refactoring to prepare for using pool action to modify pool state

commit sha b7ee88759f4e79c01e666f552c9ca33e6a98e6c1

Actionize the pool

commit sha 0d464c7f32b793ee54ed3cf63e82924218b2d88b

Encapsulate pool synchronization in a class

commit sha 897b451409a47a87aa49a7177a7c084f178ebcf5

Review feedback

commit sha 1506bbf5fdfeacf9708b01c23fd9751e56e216be

Exclude Http1xTest#testPoolLIFOPolicy for now as it cannot pass

commit sha 2397fe508a2bb1a1d70e0861153a50612f2739d8

Comment test not passing in CI

commit sha 5179264abf84e7e84bbd81ec945cafe0ec39512e

Javadoc

commit sha ce595527cfece78ed89dd91c49bdc2875ce7dcdc

Minor cleanup of commented stuff

commit sha 1ae60dfa9951c580cfa1a98cf08fbca3bb5b3acb

Uncomment parameterized tests

push time in 3 hours

push eventeclipse-vertx/vert.x

commit sha f2f1ccf12344547fce12ca8481751325181ad36f

The ChannelProvider should deliver connection on an handler in order to avoid connection races when the connection is performed on a non vertx thread to avoid message losses. For the same reason the HttpChannelConnector should use a promise internally.

chore(deps): update external fixes

push time in 3 hours

pull request commentadobe/helix-embed

Codecov Report

Merging #405 (fa2f2d2) into main (7e8ff10) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files           7        7           
  Lines         242      242           
=======================================
  Hits          237      237           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb7f15a...f81d9f0. Read the comment docs.

renovate[bot]

comment created time in 3 hours

push eventadobe/helix-embed

adobe-bot

commit sha f81d9f099ec529e393adc289d624b8416a661e6c

chore(ci): trigger ci [skip action]

chore(deps): update external fixes

push time in 3 hours

pull request commentadobe/helix-embed

This PR will trigger no release when merged.

renovate[bot]

comment created time in 3 hours

PR opened adobe/helix-embed

chore(deps): update external fixes

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
chai (source)	`4.3.0` -> `4.3.3`
eslint (source)	`7.20.0` -> `7.21.0`
mocha (source)	`8.3.0` -> `8.3.1`
semantic-release	`17.4.0` -> `17.4.1`
unfurl.js	`5.2.4` -> `5.2.5`

Release Notes

<details> <summary>chaijs/chai</summary>

`v4.3.3`

This reintroduces Assertion as an export in the mjs file. See #1378 & #1375

`v4.3.2`

This fixes a regression in IE11. See #1380 & #1379

`v4.3.1`

This releases fixed an engine incompatibility with 4.3.0

The 4.x.x series of releases will be compatible with Node 4.0. Please report any errors found in Node 4 as bugs, and they will be fixed.

The 5.x.x series, when released, will drop support for Node 4.0

This fix also ensures pathval is updated to 1.1.1 to fix CVE-2020-7751

</details>

<details> <summary>eslint/eslint</summary>

`v7.21.0`

3cd5440 Upgrade: @eslint/eslintrc to 0.4.0 (#14147) (Brandon Mills)
c0b8c71 Upgrade: Puppeteer to 7.1.0 (#14122) (Tim van der Lippe)
08ae31e New: Implement cacheStrategy (refs eslint/rfcs#63) (#14119) (Manu Chambon)
5e51fd2 Update: do not ignore symbolic links (fixes #13551, fixes #13615) (#14126) (Pig Fang)
87c43a5 Chore: improve a few comments and fix typos (#14125) (Tobias Nießen)
e19c51e Sponsors: Sync README with website (ESLint Jenkins)
b8aea99 Fix: pluralize 'line' to 'lines' in max-lines-per-function description (#14115) (Trevin Hofmann)
f5b53e2 Sponsors: Sync README with website (ESLint Jenkins)
eee1213 Sponsors: Sync README with website (ESLint Jenkins)
5c4d7ea Sponsors: Sync README with website (ESLint Jenkins)

</details>

<details> <summary>mochajs/mocha</summary>

`v8.3.1`

:bug: Fixes

#4577: Browser: fix EvalError caused by regenerator-runtime (@snoack)
#4574: ESM: allow import from mocha in parallel mode (@nicojs)

</details>

<details> <summary>semantic-release/semantic-release</summary>

`v17.4.1`

Bug Fixes

deps: peer dependecy error with marked-terminal (#1829) (07f12b9)

</details>

<details> <summary>jacktuck/unfurl</summary>

`v5.2.5`

branch : renovate-external-fixes

Bug Fixes

typings (#74) (915bf8a)

</details>

Renovate configuration

:date: Schedule: "after 2pm on Saturday" in timezone Europe/Zurich.

:vertical_traffic_light: Automerge: Enabled.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:ghost: Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+128 -260

1 commit in adobe/helix-embed/tree/renovate-external-fixes adobe/helix-embed/tree/main

0 comment

2 changed files

pr created time in 3 hours

create barnchadobe/helix-embed

created branch time in 3 hours

push eventeclipse-vertx/vert.x

commit sha e4511dccf501ea2d23e1966faf0d2b44cbbb5608

Remove race

push time in 6 hours

push eventeclipse-vertx/vert.x

commit sha bab3705e1a5d4a8a576196bfe7425ea5062a4ee7

Draft pool API and implementation

commit sha 246c99ed611f4e23039cb43a89c227ccc99940ca

Make API async

commit sha 67000e5db5bae6da8fc13776f711a103069b7316

Use factory methods

commit sha 0e1f46f0bd1d2d3010eb024b7a5d807cad7bfc3c

Internal pool refactoring to prepare for using pool action to modify pool state

commit sha bcb32b7613a3c7d0db1bd622ffad83dccedcb405

Actionize the pool

commit sha 2353cb2feda8c5303541e83aeeadd01c981afcb8

Encapsulate pool synchronization in a class

commit sha 52febae91e73159cadffd7101be8c3d0babd125f

Review feedback

commit sha a94e331a50628da1b34e8cab7aabd30954e5233a

Exclude Http1xTest#testPoolLIFOPolicy for now as it cannot pass

commit sha 9c57a7f8f48bc6e9386f6829e00ce2b7223f9377

Comment test not passing in CI

commit sha ea1921ffddd41ea27ad3be16ccf6a35d55bb7c13

Javadoc

commit sha 0414c35c31fd8814f010cbb9b021e6b067a0d2c8

Minor cleanup of commented stuff

commit sha 2313d6af8355a53aaf81e714c042cfc2e3b6833e

Uncomment parameterized tests

commit sha 5db7eeffd171272b5c9a9fa03cc73fd785073a6b

Fix racy ChannelProvider that could resolve the channel handler promise with null

commit sha 374a521bc97a2ba7038e6672ded9b486dcaf1cd1

debug

commit sha 41b5b672274993a74b2c58520bcd0d06093532b8

debug

commit sha 6fc9de804a55757fec2075cabe4b976d73c34363

debug

commit sha e758df9d39435fc1cf725705ba6ef93b39061544

debug

commit sha b58abd67c5a344d3133219fac982eba66fe237a3

debug

commit sha e3cab3e662d147ff4be1c3ce748af3a32a7585e8

debug

push time in 6 hours

issue commentChainSafe/web3.js

nodejs running problem

Yes i need help /( for network optimization geth

On Saturday, 6 March 2021, Wyatt Barnes notifications@github.com wrote:

Hi there, checking to see if this is still an issue for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ChainSafe/web3.js/issues/3771#issuecomment-791607325, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ45CZZZDFTNYHGJ233FQULTCEQRZANCNFSM4TIWLWVQ .

lottemilk

comment created time in 7 hours

push eventeclipse-vertx/vert.x

commit sha 8de03ab0f95891589d21511eb9855a97e2cffbc5

The ChannelProvider should deliver connection on an handler in order to avoid connection races when the connection is performed on a non vertx thread to avoid message losses.

commit sha 50c93e208751ea1382961e7da105e5fb5dc7ca5f

Draft pool API and implementation

commit sha 7345bfac04f56a1db08f6a7d291044bf55d9e31c

Make API async

commit sha ad754fa724555b7c69900378a8a3544c676f11a4

Use factory methods

commit sha 68ebd249956075116cbd94c0a4eda1e5dacc6b45

Internal pool refactoring to prepare for using pool action to modify pool state

commit sha 515bbfc32861b8cdc1327c2441538ec3d293ee22

Actionize the pool

commit sha 0f188812df8065b793857f5534ae502de2691437

Encapsulate pool synchronization in a class

commit sha bfdea1846169c35c300b6b5a8884d148eaf63358

Review feedback

commit sha 0e1eef6e8ed2b43dedc98b71f4507201a9717bd5

Exclude Http1xTest#testPoolLIFOPolicy for now as it cannot pass

commit sha b059378901b57a2e7e0a12d9fe2bdadcecf28a2b

Comment test not passing in CI

commit sha 06060dbbca46165b68483275632672dfd60b8679

Javadoc

commit sha 8aef8124712484675f09e371e8fae15222e2b72b

Minor cleanup of commented stuff

commit sha ddd0769b4a92c05b986f31e0dc8c8e00a3345563

Uncomment parameterized tests

push time in 8 hours

push eventeclipse-vertx/vert.x

commit sha 7d4f0df48a152ad7f18b872d15b132305d4d1dc8

debug

push time in 9 hours

push eventeclipse-vertx/vert.x

commit sha c1c61ef4be137b5ca8979e2627855ccac4e0fb94

debug

push time in 10 hours

push eventeclipse-vertx/vert.x

commit sha a1ad6e7a65e40f9faf5bdfe32af3a691d7516c2c

debug

the prefix of empty string in the router leading to a blocking without any info when the server is on starting?

push time in 11 hours

issue commenteclipse-vertx/vert.x

the platform is macOS Catalina 15.7

jxffly

comment created time in 14 hours

issue commenteclipse-vertx/vert.x

the prefix of empty string in the router leading to a blocking without any info when the server is on starting?

if you can't recurrent the case i cant upload my test code

jxffly

comment created time in 14 hours

issue openedeclipse-vertx/vert.x

the prefix of empty string in the router leading to a blocking without any info when the server is on starting?

Questions

Version

<vertx.version>4.0.2</vertx.version>

JDK1.8

code

`` Router router = Router.router(vertx);

router.route(" /api/wallet/v1/userInfo/byAddress").handler(context -> context.json( new JsonObject() .put("code", 0) .put("msg", "HELLO WORLD") .put("data", 854940268259348481L) )); `

`

Extra

this will leading to block on start ,

created time in 14 hours

issue commentChainSafe/web3.js

TypeError: constants_1.MaxUint256.mask is not a function

Hello. Sorry for long response. I've decided to investigate it myself once more. Then come back with results. I will share details soon @spacesailor24

vetal20600

comment created time in 17 hours

push eventeclipse-vertx/vert.x

commit sha 01f597653faef3a878e04f6fcd00df3e592a416d

debug

push time in 17 hours

push eventadobe/xdm

cmathis

commit sha a7d7859a57bed37156485b13d40ed3cb767b8821

Update webpagedetails.schema.json

push time in 18 hours

push eventadobe/xdm

cmathis

commit sha e538904815237fa6bd3a84ad2918df39d49ed072

Update webpagedetails.schema.json

push time in 18 hours

PR opened adobe/xdm

WebPageDetails URL Pattern

Updating the URL field to be our own custom pattern rather then the standard URI format. The URI format is too restrictive for what browsers can provide.

+1 -1

1 commit in adobe/xdm/tree/url-pattern adobe/xdm/tree/master

0 comment

1 changed file

pr created time in 18 hours

push eventeclipse-vertx/vert.x

commit sha 74945e6ebcfaaa661c7fcc574043ce7b8f6a767e

debug