profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/nginnever/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

libp2p/js-peer-id 61

peer-id implementation in JavaScript

matryx/MatryxToken 9

Collection of smart contracts for the ERC20 Matryx Token

libp2p/gossipsub-hardening 4

testground plans for evaluating gossipsub under attack scenarios

nginnever/crypto-kitty-battle 3

A smart contract battle arena for crypto kitties.

nginnever/data-structures-c 1

data structures and algorithms in c/c++

daonear/daonear 0

DAO implementation on NEAR

push eventHyphalDAO/Seele

nginnever

commit sha 0a2754996ac30ad7bebf29020519ce9f79e15fad

small updates

view details

push time in 4 days

push eventHyphalDAO/Seele

nginnever

commit sha 7d97336e855c632b17b28a395fd407859a5d471f

rename strategy

view details

push time in 6 days

push eventHyphalDAO/Seele

nginnever

commit sha 049dd38b889c1acc729961f3dac6d7ca9ef5c4cb

initial state + remove checks

view details

push time in 6 days

push eventHyphalDAO/Seele

nginnever

commit sha 4f4f928c016d2b66c0fe6de50ff9a7d08a518d80

remove unnecessary state

view details

push time in 6 days

push eventHyphalDAO/Seele

nginnever

commit sha d6457562601a8fed95cfbeb924f490b6f5c23058

uniswap sqrt

view details

push time in 7 days

push eventHyphalDAO/Seele

nginnever

commit sha 903c4111de1cce3415cdb2f097ce353c08a5e227

readme

view details

push time in 7 days

push eventHyphalDAO/Seele

nginnever

commit sha 351da933152e734b25f798a9f9f33ba070083941

audit scope update

view details

push time in 7 days

push eventHyphalDAO/Seele

nginnever

commit sha 6ef6b6f15b1af134716285060ce542f901b073a1

scope abstraction

view details

push time in 7 days

push eventHyphalDAO/Seele

nginnever

commit sha c7a7f09b5f9cb4ca2603e2353baa0fb3da73bf60

member abstraction

view details

push time in 7 days

push eventHyphalDAO/Seele

nginnever

commit sha 5f8725eabf1e2a1ddbdcc032482def71f3f82fcd

readme

view details

push time in 8 days

push eventHyphalDAO/Seele

nginnever

commit sha 868e973bf28fadad9b58e0305a76bdaaf2e05f22

readme

view details

push time in 8 days

push eventHyphalDAO/Seele

nginnever

commit sha 8e2485bfe16adab3517a7472bec81e244fd8d7d0

readme

view details

push time in 8 days

push eventHyphalDAO/Seele

nginnever

commit sha 0fe533a21c53b3c0c644a522affa6baf7e964306

readme

view details

push time in 8 days

push eventHyphalDAO/Seele

nginnever

commit sha b5891f79ae873396813cbd2a03b6b475fd868d44

tests

view details

push time in 8 days

push eventHyphalDAO/Seele

nginnever

commit sha 8e942d7bf55cd74fd2b1f056efd5130c4301d3d7

update

view details

push time in 8 days

push eventHyphalDAO/Seele

nginnever

commit sha de98235d047ccf9b42dd5e1447851f6155b2b67f

update audit doc

view details

push time in 8 days

push eventHyphalDAO/Seele

nginnever

commit sha cde17af4241b9ce67c8fcb68e930a40d15477085

audit

view details

push time in 8 days

issue commentHyphalDAO/Seele

How to stop griefing / malicious proposals?

can now cancel multiple proposals https://github.com/HyphalDAO/Seele/commit/5ff48b2b8c722fefaa6ba5056f6b9cccfc11b3bd

auryn-macmillan

comment created time in 8 days

push eventHyphalDAO/Seele

nginnever

commit sha 5ff48b2b8c722fefaa6ba5056f6b9cccfc11b3bd

cancel multiple proposals

view details

push time in 8 days

push eventHyphalDAO/Seele

nginnever

commit sha 69424cfbe39cf885c49b05f9c49172809e261a26

single tests

view details

push time in 9 days

IssuesEvent

issue closedTokenWalk/Seele

Should _proposal.proposer be able to cancel their proposal?

I see the rationale for the proposer to be able to cancel their proposal (maybe they made an typo or an error in the included transactions, etc), but this also potentially opens a route to the proposer having some privileged access to manipulating proposals.

I wonder if there is a more sensible compromise here? Two options that come to mind:

  1. proposer cannot delete once anyone else has cast a vote
  2. proposer cannot delete after some amount of time has passed

I'm sure there are other reasonable conditions one might put on this, so I wonder if it should actually be deferred to the strategy? So calling cancelProposal() would then check with the strategy to determine if the proposal can actually be cancelled.

closed time in 9 days

auryn-macmillan

issue commentTokenWalk/Seele

Should _proposal.proposer be able to cancel their proposal?

That's also a good point. Which makes me wonder if the cancel logic in the Seele contract should just be removed altogether?

I think it's still valuable to keep the cancel logic on the Seele contract since the delay logic is there as well. This gives cancel guards/committees the ability to stop proposals in the delay period, not just the voting period.

auryn-macmillan

comment created time in 9 days

issue commentTokenWalk/Seele

Should _proposal.proposer be able to cancel their proposal?

That's also a good point. Which makes me wonder if the cancel logic in the Seele contract should just be removed altogether?

I think it's still valuable to keep the cancel logic on the Seele contract since the delay logic is there as well. This gives cancel guards/committees the ability to stop proposals in the delay period, not just the voting period.

auryn-macmillan

comment created time in 9 days

create barnchTokenWalk/TokenWalk

branch : linear-api

created branch time in 9 days

push eventTokenWalk/Seele

nginnever

commit sha eb269dafcbc4f89cb35b82c1e8bb9ebefb28908c

refactor proxy tests

view details

push time in 9 days

push eventTokenWalk/Seele

nginnever

commit sha 1739bcc095a9de025e43fae0506b062f3a0cbf5c

proxy refactor

view details

push time in 9 days

push eventTokenWalk/Seele

nginnever

commit sha 43fc740db8d0929d460a220a320ae4dfea22ca75

nft voting

view details

push time in 10 days

push eventTokenWalk/Seele

nginnever

commit sha 93a0171aeb00cae8d4ad1fff8ab085fa8583fc7f

proposal guard tests

view details

push time in 10 days

push eventTokenWalk/Seele

nginnever

commit sha 99f27b6ec5704568995c936d7b0b46ab4ea1936c

member linear test

view details

push time in 10 days