profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/nekrich/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

MacPaw/Setapp-SmartSuggestionsSample 2

This repo contains a sample code for Setapp's Smart Suggestion Initiative.

nekrich/Localize-Swift 1

Swift 2.0 friendly localization and i18n with in-app language switching

nekrich/Alamofire 0

Elegant HTTP Networking in Swift

nekrich/ApplySyntax 0

Syntax detector for Sublime Text

nekrich/CocoaLumberjack 0

A fast & simple, yet powerful & flexible logging framework for Mac and iOS

nekrich/Commandant 0

Type-safe command line argument handling

nekrich/Core-Data-Editor 0

Core Data Editor lets you easily view, edit and analyze applications‘ data. Core Data Editor is compatible with Mac and iOS applications and supports XML, SQLite and binary stores, visualizes all relationships and is able to edit the data and generate Objective-C code for the data model.

nekrich/Dynamic 0

Call hidden/private API in style! The Swift way.

created tagnekrich/fastlane-plugin-create_dmg

tagv0.1.1

created time in 5 days

push eventnekrich/fastlane-plugin-create_dmg

Vitalii Budnik

commit sha 9f4d86d83ac88151f47151c92b7f68da32ce91ef

fix: Warning about declared UI typealias

view details

Vitalii Budnik

commit sha 230307c74ae4474a8c3b78a7818c22ff655171b5

chore: Bump version to 0.1.1

view details

push time in 5 days

pull request commentfastlane/fastlane

[match] Add ability to include all development certificates to the development provisioning profile

Will take a look when I can! Got LASIK a few days ago so eyes are a bit sensitive to light and computer screens still 🤷‍♂️

Get well soon ❤️‍🩹.

nekrich

comment created time in 7 days

pull request commentfastlane/fastlane

[match] Add ability to include all development certificates to the development provisioning profile

@joshdholtz , appveyor failed to DL some dependency, and there is a strange new CLA request after rebasing. idk 🤷

nekrich

comment created time in 7 days

created tagnekrich/fastlane-plugin-create_dmg

tagv0.1.0

created time in 10 days

created tagnekrich/fastlane-plugin-create_dmg

tag0.1.0

created time in 10 days

push eventnekrich/fastlane-plugin-create_dmg

Vitalii Budnik

commit sha 228eef8475789b19c8bde1e7ce260d29cd67b561

Initial commit

view details

push time in 10 days

push eventnekrich/fastlane-plugin-create_dmg

Vitalii Budnik

commit sha e8124d2123f386050ec9739a9f5e4550345ba696

Initial commit

view details

push time in 10 days

push eventnekrich/fastlane-plugin-create_dmg

Vitalii Budnik

commit sha e056a87e9783d2172ef6800fea1553b90bede66a

Initial commit

view details

push time in 10 days

push eventnekrich/fastlane-plugin-create_dmg

Vitalii Budnik

commit sha 3b24982f5d7d59c0f17a4f22e9a5a2a11fe6ef52

Initial commit

view details

push time in 10 days

push eventnekrich/fastlane-plugin-create_dmg

Vitalii Budnik

commit sha 92c94da2fe2d6a2bf2d432e81e63a324f9c4b0b3

Initial commit

view details

push time in 10 days

delete tag nekrich/fastlane-plugin-create_dmg

delete tag : 0.1.0

delete time in 10 days

created tagnekrich/fastlane-plugin-create_dmg

tag0.1.0

created time in 10 days

create barnchnekrich/fastlane-plugin-create_dmg

branch : main

created branch time in 10 days

created repositorynekrich/fastlane-plugin-create_dmg

created time in 10 days

push eventnekrich/fastlane

Vitalii Budnik

commit sha 574ed09b3495857c8a3fc3e502ff6023df8d4534

chore: Silence rubocop for Match::Runner

view details

push time in 11 days

Pull request review commentfastlane/fastlane

[match] Add ability to include all development certificates to the development provisioning profile

 def fetch_provisioning_profile(params: nil, certificate_id: nil, app_identifier:         end       end +      if params[:include_all_certificates]+        # Clearing specified certificate id which will prevent a profile being created with only one certificate+        certificate_id = nil++        if params[:force_for_new_certificates] && !params[:readonly]+          if prov_type == :development && !params[:force]+            force = certificate_count_different?(profile: profile, keychain_path: keychain_path, platform: params[:platform].to_sym)+          else

Moved all checks into separate methods to reduce complexity.

nekrich

comment created time in 11 days

PullRequestReviewEvent

push eventnekrich/fastlane

Lukasz Grabowski

commit sha df6e234a7dc7f5d725b40bb59286edfe8d1dc745

[docs] Adjust markdown docs generator to move files to dedicated directory (#19322) * Adjust markdown docs generator to move files to dedicated directory * Customize branch of docs repository * Make generated/actions dir if it doesn't exist * Revert FASTLANE_DOCS_GIT_BRANCH * Setting correct reference path in mkdocs.yml Co-authored-by: Josh Holtz <me@joshholtz.com>

view details

Atsuto Yamashita

commit sha 63fabb062d563b49dc19b2359f83e7b3abb1d0bc

add github option to slather action (#19347)

view details

Atsuto Yamashita

commit sha ad549c51c1b23862274e1fbea36866c8c00d2c43

fix typo (identifier) (#19346)

view details

Atsuto Yamashita

commit sha de0d0745ec8e44f3d6f50baa183ae327d8b9d252

fix typo (declaration) (#19345)

view details

Lukasz Grabowski

commit sha abb80d62ddcde67fc4d4d28e2a72c382433a2d58

[docs] Change links for api_key option explanation in App Store Connect API Key docs (#19350)

view details

Jonas Kalderstam

commit sha a3427533c67318007a63e4451bd33f5c950c0c96

Fixed supply promote uploading metadata to wrong track (#19343) Fixes #19058

view details

Lukasz Grabowski

commit sha a169a4c4e422c72fd9137604bd35a09d40ee7fcc

[fastlane_core] build watcher fails when build_beta_detail is nil - fix (#19331) * Build watcher fails when beta_build_details is nil - fix * Code review improvement Co-authored-by: Josh Holtz <me@joshholtz.com> * Fix small syntax error * Added tests Co-authored-by: Josh Holtz <me@joshholtz.com>

view details

Joseph Duffy

commit sha 6bcd74c9c99311245e999cc6c054b6b6e251d0ee

Wait for simulator to boot before overriding status bar (#19344) `xcrun instruments` fails with the error "xcrun: error: Failed to locate 'instruments'." This command will boot the simulator if it's not curerntly booted and then wait for it finish booting before terminating. Fixes #19317.

view details

Vitalii Budnik

commit sha e9d0dc658d5d666b4b1ed74f8f05a9232d2d5b7c

[notarize] Add support for api_key parameter (#19353)

view details

Josh Holtz

commit sha a5616116d0e686a6975321bc38a51b5ce1e3c056

Version bump to 2.194.0 (#19354)

view details

Vitalii Budnik

commit sha 88ae36a6da3a832ca0d4a5ea2000c531e077fb48

[sigh] Add an option to include all development certificates to the provisioning profiles

view details

Vitalii Budnik

commit sha 4f6d606063b1978f329c477efc68fef4e4a92289

[match] Add include_all_certificates & force_for_new_certificates to match

view details

Vitalii Budnik

commit sha 5d93bb7869f84dd218001c7f0f8eebe715f7b620

Update match/lib/match/runner.rb Co-authored-by: Josh Holtz <me@joshholtz.com>

view details

Vitalii Budnik

commit sha 4d858b67f3ec027c79ed8c994a04850273870eee

[match] Reduce force_ checks if already forced

view details

Vitalii Budnik

commit sha 921de882592327c468af41621b84f6974e02d92b

[match] Refactor force_for_new_devices and include_all_certificates options

view details

Vitalii Budnik

commit sha 39544fecd20000bdfde44a302d6b504cf3f1936f

[sigh] Fix false-positive warning about skipping device if include_all_certificates

view details

push time in 11 days

Pull request review commentfastlane/fastlane

[match] Add ability to include all development certificates to the development provisioning profile

 def fetch_provisioning_profile(params: nil, certificate_id: nil, app_identifier:         end       end +      if params[:include_all_certificates]+        # Clearing specified certificate id which will prevent a profile being created with only one certificate+        certificate_id = nil++        if params[:force_for_new_certificates] && !params[:readonly]+          if prov_type == :development && !params[:force]+            force = certificate_count_different?(profile: profile, keychain_path: keychain_path, platform: params[:platform].to_sym)+          else

Fixed. Better to review w/o space changes

nekrich

comment created time in 12 days

PullRequestReviewEvent

push eventnekrich/fastlane

Vitalii Budnik

commit sha 70fa37a18be0c44a7ef56091dd9a205da4a9c412

[match] Reduce force_ checks if already forced

view details

push time in 12 days

Pull request review commentfastlane/fastlane

[match] Add ability to include all development certificates to the development provisioning profile

 def fetch_provisioning_profile(params: nil, certificate_id: nil, app_identifier:         end       end +      if params[:include_all_certificates]+        # Clearing specified certificate id which will prevent a profile being created with only one certificate+        certificate_id = nil++        if params[:force_for_new_certificates] && !params[:readonly]+          if prov_type == :development && !params[:force]+            force = certificate_count_different?(profile: profile, keychain_path: keychain_path, platform: params[:platform].to_sym)+          else

Good catch. I think I'll need to wrap it in the unless force

nekrich

comment created time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened fastlane/fastlane

[notarize] Add support for api_key parameter

<!-- Thanks for contributing to fastlane! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->

Checklist

  • [x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • [x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • [x] I've read the Contribution Guidelines
  • [x] I've updated the documentation if necessary.

Motivation and Context

I tried to notarize the macOS app and was surprised that it doesn't support an api_key parameter and doesn't use the shared Spaceship::ConnectAPI::Token. So, I had a dilemma: to save JSON file with shared API token and pass that file to notarize and then delete it (for security sake), or make this PR 😅.

Description

  • Add api_key parameter to notarize action, and fall back to the shared lane context if it's nil.
  • Update notarytool & altool methods to work directly with api_key.

Testing Steps

app_store_connect_api_key

app_path = build_app

# api_key_path is not needed anymore 🎉
notarize(package: app_path)
+27 -18

0 comment

1 changed file

pr created time in 12 days

create barnchnekrich/fastlane

branch : notarize-add-api_key-parameter

created branch time in 12 days

pull request commentfastlane/fastlane

[match] Add ability to include all development certificates to the development provisioning profile

This looks great! Just one little suggestion about adding a comment line 😇 👍 Thanks. Done.

nekrich

comment created time in 14 days

push eventnekrich/fastlane

Vitalii Budnik

commit sha f3067163bc36338d94aeb2158b3aaa0467a3c178

Update match/lib/match/runner.rb Co-authored-by: Josh Holtz <me@joshholtz.com>

view details

push time in 14 days