narusemotoki ( Motoki Naruse )

Since this field is supposed to be filled from within the client I assume this client is no longer operational. And/or doesn't work on newer version of PHP.

Have raised a support ticket for this as well but they don't even understand what I am talking about; they consistently refer me to the REST API documentation; even when explicitly (three times) telling them I'm using the PHP client.

created time in 15 days

pull request commentgengo/gengo-php

Adding proper guzzle version to work with laravel 8.0

@ryvasquez Can you please help? This issue holds me back from upgrading to PHP 8.

Lastwisher

comment created time in a month

fork webromik/srx_segmenter

Segment text with SRX

narusemotoki/srx_segmenter webromik/srx_segmenter

fork in 2 months

delete branch gengo/gengo-php

delete branch : v2.1.8

delete time in 3 months

PR closed gengo/gengo-php

Reviewers

hide debug outputs

To remove debug message it's displayed on debug environment, comment out messages.

This PR won't be merged to master because current main stream version is 3.x but this is a successor of 2.1.x.

+0 -7

1 commit in gengo/gengo-php/tree/v2.1.8 gengo/gengo-php/tree/master

2 comments

1 changed file

shinji-kohara

pr closed time in 3 months

pull request commentgengo/gengo-php

hide debug outputs

close this PR because this shouldn't be merged into master. this should be remained as a branch because v2.1.x isn't main stream anymore.

shinji-kohara

comment created time in 3 months

delete branch gengo/gengo-php

delete branch : remove-getPreferredTranslators

delete time in 3 months

created taggengo/gengo-php

tag2.1.8

A PHP library to interface with the Gengo API for translation.

created time in 3 months

delete tag gengo/gengo-php

delete tag : 2.1.8

delete time in 3 months

push eventgengo/gengo-php

shinji

commit sha 3754f75acce9c4c4e81aeb81c8ba0ba6c7fe7df1

remove debug outputs

view details

push time in 3 months

pull request commentgengo/gengo-php

hide debug outputs

@markjezreeldagot @matthias-mess I think either's fine. I just thought it may convenient for some purpose because it have been remained long time. well, let's remove these statements if we don't need it.

shinji-kohara

comment created time in 3 months

Pull request review commentgengo/gengo-php

hide debug outputs

 protected function request($url, $method, $format = null, $params = null)             if ($this->config->get('debug', false))             {                 $response = $this->client->request($method);-                echo $this->client->getUri(true) . "\n";-                echo $this->client->getLastRequest() . "\n";+                echo "<!-- " . $this->client->getUri(true) . " -->\n";+                echo "<!-- " . $this->client->getLastRequest() . " -->\n";

Maybe we could just remove this messages? Not sure what it is for.

shinji-kohara

comment created time in 3 months

Pull request review commentgengo/gengo-php

hide debug outputs

 protected function request($url, $method, $format = null, $params = null)             if ($this->config->get('debug', false))             {                 $response = $this->client->request($method);-                echo $this->client->getUri(true) . "\n";-                echo $this->client->getLastRequest() . "\n";+                echo "<!-- " . $this->client->getUri(true) . " -->\n";+                echo "<!-- " . $this->client->getLastRequest() . " -->\n";

how about we will delete it?

shinji-kohara

comment created time in 3 months

PR opened gengo/gengo-php

hide debug outputs

To remove debug message it's displayed on debug environment, comment out messages.

This PR won't be merged to master because current main stream version is 3.x but this is a successor of 2.1.x.

+2 -2

1 commit in gengo/gengo-php/tree/v2.1.8 gengo/gengo-php/tree/master

0 comment

1 changed file

pr created time in 3 months