profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/naglis/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

ytdl-org/youtube-dl 100650

Command-line program to download videos from YouTube.com and other video sites

naglis/misc-addons 9

Miscellaneous Odoo addons

versada/sentry-openproject 7

An extension for Sentry which integrates with OpenProject.

thomasklosinsky/purchase_barcode_qweb 2

Odoo 8 module to print barcode labels from purchse orders

versada/connector 0

Odoo generic connector framework (jobs queue, asynchronous tasks, channels)

versada/connector-telephony 0

Odoo modules for telephony integration

versada/crm 0

Odoo CRM, Mail & Newsletter advanced features

versada/edgedb 0

The next generation object-relational database. A @magicstack project.

versada/hr 0

Odoo Human Resources Addons

create barnchnaglis/libopds2-go

branch : opds2-contributor-handle-array-of-strings

created branch time in 12 days

fork naglis/libopds2-go

An OPDS 2.0 library written in Go that can also parse OPDS 1.x

fork in 12 days

pull request commentodoo/odoo

[FIX] base_address_extended: add complete address to contact

Hi, is there any chance this will be forward ported to Odoo 14.0?

nboulif

comment created time in 19 days

delete branch naglis/rich

delete branch : fix-typos

delete time in 24 days

PR opened willmcgugan/rich

Fix typos in `rich.table.Table` docstring

Type of changes

  • [ ] Bug fix
  • [ ] New feature
  • [X] Documentation / docstrings
  • [ ] Tests
  • [ ] Other

Checklist

  • [X] I've run the latest black with default args on new code.
  • [ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • [ ] I've added tests for new code.
  • [X] I accept that @willmcgugan may be pedantic in the code review.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

+1 -1

0 comment

1 changed file

pr created time in 25 days

push eventnaglis/rich

Naglis Jonaitis

commit sha 90d634fdc04589e726330a219e713158337e6d35

Fix typos in `rich.table.Table` docstring

view details

push time in 25 days

create barnchnaglis/rich

branch : fix-typos

created branch time in 25 days

fork naglis/rich

Rich is a Python library for rich text and beautiful formatting in the terminal.

https://rich.readthedocs.io/en/latest/

fork in 25 days

issue closedodoo/odoo

[12.0] The tax amount (`price_tax`) in invoice line does not match the tax (`amount_tax`) on the invoice

Impacted versions:

Steps to reproduce:

  • Create a sales tax named e.g. VAT21 with Amount set to 21% and Tax Computation set to Percentage of Price;
  • Set Product Unit of Measure UoM decimal.precision record to 5 decimal places;
  • Set the company's Tax Calculation Rounding Method to Round Globally;
  • For display purposes, add Tax Amount (price_tax) account.invoice.line field to invoice form view in Invoice Lines tab;
  • Create an invoice with one line where Quantity is 0.67742, Price is 21.0 and taxes is VAT21 and click Save.

Current behavior:

  • The Tax Amount (price_tax) on the invoice line is 2.98 and does not match the Tax (amount_tax) on the invoice (which is 2.99).

Expected behavior:

  • The Tax Amount (price_tax) on the invoice line is 2.99 and matches the Tax (amount_tax) on the invoice.

Video/Screenshot link (optional):

invoice_tax

closed time in 25 days

naglis

issue commentodoo/odoo

[12.0] The tax amount (`price_tax`) in invoice line does not match the tax (`amount_tax`) on the invoice

Closing as it was explained to me by someone who is more knowledgeable in accounting that this is not a bug. Sorry for wasting your time.

naglis

comment created time in 25 days

delete branch versada/social

delete branch : 14.0-mig-mail_notification_custom_subject

delete time in a month

pull request commentOCA/social

[MIG] mail_notification_custom_subject: Migration to 14.0

Can you please squash the administrative commits into the migration one?

@pedrobaeza, it is done.

naglis

comment created time in a month

push eventversada/social

Carlos Roca

commit sha fd58a75e608a23b25b846714c6c4eab1bd961c29

[MIG] mail_notification_custom_subject: Migration to v13.0

view details

Víctor Martínez

commit sha d3a355fdd30f4998097b982b8914f6d255143550

[IMP] mail_notification_custom_subject: Add comment to explain test_bad_template_does_not_break test

view details

Naglis Jonaitis

commit sha ae067c5b979b75c9a3acaa2fe981e68f11bcb4ad

[IMP] mail_notification_custom_subject: black, isort, prettier

view details

Naglis Jonaitis

commit sha 1c42c0f6ab0fcb4017adc715ec6038a923527f84

[MIG] mail_notification_custom_subject: Migration to 14.0

view details

push time in a month

delete branch naglis/odoo

delete branch : 14.0-rem-account-pos_adyen-missing-qweb-files

delete time in a month

PR closed odoo/odoo

Reviewers
[12.0] [13.0] [14.0] account, pos_adyen: remove missing QWeb files from manifest

Description of the issue/feature this PR addresses:

Removes nonexistent QWeb files listed in account and pos_adyen addon manifests.

Current behavior before PR:

  • Nonexistent QWeb files are listed in the manifest.

Desired behavior after PR is merged:

  • Nonexistent QWeb files are not listed in the manifest.

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

+0 -2

2 comments

2 changed files

naglis

pr closed time in a month

push eventversada/social

Ivàn Todorovich

commit sha 676bc438409c65710f003e5c65e6d9afe22d32c2

[ADD] mail_autosubscribe

view details

David Beal

commit sha 629dceb22d1e413e77e47d8ebd3a81a842148d3f

ADD module mail_inline_css

view details

David Beal

commit sha 58a4d208aa116047092d0eab6692b687f8013a9c

IMP README use case

view details

OCA Transbot

commit sha 37947ff3a47defecdf380102233450465ed91314

OCA Transbot updated translations from Transifex

view details

oca-travis

commit sha 101f8728c824de4413eaa389fea9391a74946670

[UPD] Update mail_inline_css.pot

view details

Timon Tschanz

commit sha 890c87f7e6cf805e17c55c841788b4aaab0f27ea

[11.0][MIG] mail_inline_css

view details

Timon Tschanz

commit sha 280284ec6443a39a3a3c0db8b13eccd3158121ba

[IMP] mail_inline_css: Improve and add test cov

view details

mpanarin

commit sha 229068ccfed373cdf517b821b0cb826e58aa7292

[IMP] mail_inline_css: allow passing options to premailer

view details

OCA-git-bot

commit sha 1ecb906b3248774d065b712bb01ae8ff1d891a6b

[ADD] icon.png

view details

oca-travis

commit sha 99fc9e6036342a47902c7bed7548ab4b8a371495

[UPD] Update mail_inline_css.pot

view details

OCA-git-bot

commit sha 0d8a74d0af82049ebaa60a6c1dc5645c84b8c2f9

[UPD] README.rst

view details

Simone Orsi

commit sha f140c6d16e1d1afb956e88d5daa91f69f9754562

[MIG] mail_inline_css: Migration to 12.0

view details

Simone Orsi

commit sha 9901e140c38dcef3b8e4baf9f97d202d2001fc41

mail_inline_css: unify premailer transform apply

view details

oca-travis

commit sha c7d779fc1ff6ffb01b0ee817da53975b4d489b1b

[UPD] Update mail_inline_css.pot

view details

OCA-git-bot

commit sha 9d10c1df86f6578c64589503c4722924f6c1fc76

[UPD] README.rst

view details

OCA Transbot

commit sha 118ea6e7b7cdd3b1dc0f714c62e962fe52ce10f5

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-12.0/social-12.0-mail_inline_css Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_inline_css/

view details

Simone Orsi

commit sha 53530348d71a994d66ea727d3b16e9699d2564e9

[REF] mail_inline_css: apply pre-commit

view details

Simone Orsi

commit sha 692e0d978d1352a939a9a0dc09d61c21edb5984d

[MIG] mail_inline_css: Migration to 13.0

view details

oca-travis

commit sha 72ad6819638c4a0aa228bac39d70d211ba771c29

[UPD] Update mail_inline_css.pot

view details

OCA-git-bot

commit sha f8d35325af7e6aa19491879cc726e3c93bbda1da

[UPD] README.rst

view details

push time in 2 months

issue commentOCA/social

Migration to version 14.0

mail_notification_custom_subject: https://github.com/OCA/social/pull/757

OCA-git-bot

comment created time in 2 months

PR opened OCA/social

[MIG] mail_notification_custom_subject: Migration to 14.0

Most notable changes:

  • mail.thread message_post and mail.template _render_template signatures changed;
  • Changed mail.message.custom.subject model_id ondelete attribute to cascade (the default for required fields is restrict) as you now cannot have ondelete="restrict" for IR models: https://github.com/odoo/odoo/blob/f964b761eae32016e36dd9d39cc2c35fc2270eba/odoo/fields.py#L2601-L2606:

    Field model_id of model mail.message.custom.subject is defined as ondelete='restrict' while having ir.model as comodel, the 'restrict' mode is not supported for this type of field as comodel.

  • (Tests) assertEqual instead of assertEquals (deprecated);
  • (Tests) SavepointCase + tracking_disable=True context to reduce the number of queries.
+1253 -0

0 comment

20 changed files

pr created time in 2 months

create barnchversada/social

branch : 14.0-mig-mail_notification_custom_subject

created branch time in 2 months

Pull request review commentOCA/connector-magento

[MIG][13.0] connector_magento

+# Copyright 2017 ACSONE SA/NV+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).++import base64+import contextlib+import io+import json+import logging++from odoo import _, api, fields, models, tools+from odoo.exceptions import UserError++from odoo.addons.component import core++_logger = logging.getLogger(__name__)+++class MagentoBindingBackendRead(models.TransientModel):++    _name = "magento.binding.backend.read"+    _description = "Magento Generic Object Reader Wizard"++    @api.model+    @tools.ormcache_context("self._uid", "model_name", keys=("lang",))+    def _get_translated_model_name(self, model_name):+        # get the translated model name to build+        # a meaningful model description+        search_result = self.env["ir.model"].name_search(model_name, operator="=")+        if search_result:+            return search_result[0][1]+        return self.env[model_name]._description++    @api.model+    def _default_magento_backend_id(self):+        active_model = self._context.get("active_model")+        if active_model and active_model == self._name:+            # method called when the result is displayed+            return self.env["magento.backend"].browse([])+        if active_model and active_model != "magento.backend":+            raise UserError(+                _("The wizard must be launched from a magento " "backend model")+            )+        active_id = self._context.get("active_ids", [])+        if len(active_id) > 1:+            raise UserError(+                _("The wizard must be launched on a single " "magento backend instance")+            )+        active_id = (active_id and active_id[0]) or self._context.get("active_id")+        return self.env["magento.backend"].browse(active_id)++    @api.model+    def _get_magento_binding_model(self):+        """+        This method return a list of magento bindings for which a backend+        adapter is registered+        :return:+        """+        try:+            components_registry = core._component_databases[self.env.cr.dbname]+        except KeyError:+            _logger.info(+                "No component registry for database %s. "+                "Probably because the Odoo registry has not been built "+                "yet."

Thanks!

bizzappdev

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentOCA/connector-magento

[MIG][13.0] connector_magento

+# Copyright 2017 ACSONE SA/NV+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).++import base64+import contextlib+import io+import json+import logging++from odoo import _, api, fields, models, tools+from odoo.exceptions import UserError++from odoo.addons.component import core++_logger = logging.getLogger(__name__)+++class MagentoBindingBackendRead(models.TransientModel):++    _name = "magento.binding.backend.read"+    _description = "Magento Generic Object Reader Wizard"++    @api.model+    @tools.ormcache_context("self._uid", "model_name", keys=("lang",))+    def _get_translated_model_name(self, model_name):+        # get the translated model name to build+        # a meaningful model description+        search_result = self.env["ir.model"].name_search(model_name, operator="=")+        if search_result:+            return search_result[0][1]+        return self.env[model_name]._description++    @api.model+    def _default_magento_backend_id(self):+        active_model = self._context.get("active_model")+        if active_model and active_model == self._name:+            # method called when the result is displayed+            return self.env["magento.backend"].browse([])+        if active_model and active_model != "magento.backend":+            raise UserError(+                _("The wizard must be launched from a magento " "backend model")+            )+        active_id = self._context.get("active_ids", [])+        if len(active_id) > 1:+            raise UserError(+                _("The wizard must be launched on a single " "magento backend instance")+            )+        active_id = (active_id and active_id[0]) or self._context.get("active_id")+        return self.env["magento.backend"].browse(active_id)++    @api.model+    def _get_magento_binding_model(self):+        """+        This method return a list of magento bindings for which a backend+        adapter is registered+        :return:+        """+        try:+            components_registry = core._component_databases[self.env.cr.dbname]+        except KeyError:+            _logger.info(+                "No component registry for database %s. "+                "Probably because the Odoo registry has not been built "+                "yet." % (self.env.cr.dbname)
                "yet.", self.env.cr.dbname

Please note that leaving the string formatting to the logger is better, since it will only format it if the logging level is enabled (avoids computation if not needed) and also it can have unintended consequences with other tools, e.g. Sentry will not group the events correctly if the log message is already formatted.

Sources: [1], see also pylint W1202 rule.

bizzappdev

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentOCA/connector-magento

[MIG][13.0] connector Magento

+# Copyright 2017 ACSONE SA/NV+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).++import base64+import contextlib+import io+import json+import logging++from odoo import _, api, fields, models, tools+from odoo.exceptions import UserError++from odoo.addons.component import core++_logger = logging.getLogger(__name__)+++class MagentoBindingBackendRead(models.TransientModel):++    _name = "magento.binding.backend.read"+    _description = "Magento Generic Object Reader Wizard"++    @api.model+    @tools.ormcache_context("self._uid", "model_name", keys=("lang",))+    def _get_translated_model_name(self, model_name):+        # get the translated model name to build+        # a meaningful model description+        search_result = self.env["ir.model"].name_search(model_name, operator="=")+        if search_result:+            return search_result[0][1]+        return self.env[model_name]._description++    @api.model+    def _default_magento_backend_id(self):+        active_model = self._context.get("active_model")+        if active_model and active_model == self._name:+            # method called when the result is displayed+            return self.env["magento.backend"].browse([])+        if active_model and active_model != "magento.backend":+            raise UserError(+                _("The wizard must be launched from a magento " "backend model")+            )+        active_id = self._context.get("active_ids", [])+        if len(active_id) > 1:+            raise UserError(+                _("The wizard must be launched on a single " "magento backend instance")+            )+        active_id = (active_id and active_id[0]) or self._context.get("active_id")+        return self.env["magento.backend"].browse(active_id)++    @api.model+    def _get_magento_binding_model(self):+        """+        This method return a list of magento bindings for which a backend+        adapter is registered+        :return:+        """+        try:+            components_registry = core._component_databases[self.env.cr.dbname]+        except KeyError:+            _logger.info(+                "No component registry for database %s. "+                "Probably because the Odoo registry has not been built "+                "yet."

Database name not passed.

                "yet.", self.env.cr.dbname
bizzappdev

comment created time in 2 months

PullRequestReviewEvent

PR opened naglis/test_repo

Add new_addon
+11 -0

0 comment

4 changed files

pr created time in 2 months

delete branch naglis/test_repo

delete branch : new_addon

delete time in 2 months

PR closed naglis/test_repo

Add new_addon
+11 -0

0 comment

4 changed files

naglis

pr closed time in 2 months

PR closed naglis/test_repo

Add addon_3
+9 -0

0 comment

4 changed files

naglis

pr closed time in 2 months