profile
viewpoint

mrlubos/selftype 37

JavaScript class that animates text similarly to the style that can be found at Slack's homepage.

letswarkk/react-datepicker 0

A simple and reusable datepicker component for React

mrlubos/auto-assign 0

🤖 A Probot app that adds reviewers to pull requests when pull requests are opened.

mrlubos/create-react-app 0

Set up a modern web app by running one command.

mrlubos/poorpen 0

CodePen Pro for the poorer of us.

issue commentreact-hook-form/resolvers

ESLint error: Unable to resolve path to module '@hookform/resolvers'

Same issue and what @minimaluminium said fixed it, using react-hook-form 6.0.1

minimaluminium

comment created time in 6 days

issue openedreact-spring/use-cannon

Fails to compile on `npm start` with TypeScript support

Hey! I am trying to run the basic example using create-react-app with the TypeScript template. I installed the latest use-cannon version (0.4.9), imported it using import { Physics } from 'use-cannon' and then hit npm start. This is what I get.

/root/node_modules/use-cannon/dist/hooks.d.ts
TypeScript error in /root/node_modules/use-cannon/dist/hooks.d.ts(1,13):
'=' expected.  TS1005

  > 1 | import type { MaterialOptions, RayOptions } from 'cannon-es';
      |             ^
    2 | import type { Event } from './index';
    3 | import * as THREE from 'three';
    4 | import React from 'react';

Are you able to help me debug what's going wrong please? Not sure if it's an issue with my setup or not

created time in 15 days

issue commentstorybookjs/storybook

start-storybook opens the wrong browser

@yannbf Can confirm, 5.3.x does not solve the issue, 6.0.0 works! 🎉

mrlubos

comment created time in 21 days

issue commentReactTraining/history

history.push() stoppped working after upgrading to v5

Looks like a duplicate of #803

saadbinsaeed

comment created time in a month

issue commentmapbox/mapbox-gl-js

`div` markers shift position near map edge on drag

Hi @ansis @andrewharvey, thanks for looking into this! Indeed, I have been unable to reproduce this issue using just Mapbox, so I am inclined to believe this is an issue with react-mapbox-gl

mrlubos

comment created time in a month

issue commentalex3165/react-mapbox-gl

Cluster marker disappear when close to window boundaries

I suppose I ran into another flavour of this issue in https://github.com/alex3165/react-mapbox-gl/issues/867

ScriptArtist

comment created time in a month

issue openedalex3165/react-mapbox-gl

`div` markers shift position near map edge on drag

mapbox-gl-js version: 1.10.1

browser: Chrome 83.0.4103.97

Steps to Trigger Behavior

  1. Create HTML marker using div element as a wrapper
  2. Drag the map until the marker approaches the map edge
  3. Observe the marker shifts position.

Link to Demonstration

See react-mapbox-gl demo.

  1. Choose the html-marker demo.
  2. Search for "London Heathrow Airport."
  3. Click the result to display a marker.
  4. Follow steps to reproduce the issue above.

Expected Behavior

Marker does not shift its position. In fact, I am unable to reproduce this issue when using plain svg icons. It only happens when I wrap the icon inside div element.

Actual Behavior

Marker shifts its position.

Screen Recording 2020-06-09 at 12 14 43 am

created time in a month

issue openedmapbox/mapbox-gl-js

`div` markers shift position near map edge on drag

mapbox-gl-js version: 1.10.1

browser: Chrome 83.0.4103.97

Steps to Trigger Behavior

  1. Create HTML marker using div element as a wrapper
  2. Drag the map until the marker approaches the map edge
  3. Observe the marker shifts position.

Link to Demonstration

See react-mapbox-gl demo.

  1. Choose the html-marker demo.
  2. Search for "London Heathrow Airport."
  3. Click the result to display a marker.
  4. Follow steps to reproduce the issue above.

Expected Behavior

Marker does not shift its position. In fact, I am unable to reproduce this issue when using plain svg icons. It only happens when I wrap the icon inside div element.

Actual Behavior

Marker shifts its position.

Screen Recording 2020-06-09 at 12 14 43 am

created time in a month

issue commentstorybookjs/storybook

start-storybook opens the wrong browser

It’s 5.1.11 @yannbf, sounds like a time to upgrade! Thank you!

mrlubos

comment created time in a month

issue commentstorybookjs/storybook

start-storybook opens the wrong browser

This is the specific utility they use https://github.com/facebook/create-react-app/blob/master/packages/react-dev-utils/openBrowser.js

mrlubos

comment created time in a month

issue commentstorybookjs/storybook

start-storybook opens the wrong browser

@shilman @yannbf I believe create-react-app solved these problems already with react-scripts. Would it be possible to use something similar or get inspired by their solution?

mrlubos

comment created time in a month

issue commentmicrosoft/TypeScript

`import 'constants' ` always resolving to the node 'constants' module

Hey @RyanCavanaugh, that sounds good! How would I go about overriding it to resolve to my local “constants” when working on client code? Importing from “constants/index” doesn’t look as nice 😀 do you recommend simply renaming the folder to something else to avoid all this trouble?

mrlubos

comment created time in a month

issue commentstorybookjs/storybook

start-storybook opens the wrong browser

Previous discussion about this issue can be found in https://github.com/storybookjs/storybook/issues/7975

mrlubos

comment created time in a month

issue openedstorybookjs/storybook

start-storybook opens the wrong browser

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

When running Storybook, I'd want it to open a new tab in the currently open browser or refresh the existing tab on port 6006. Instead, Storybook always opens a new tab in Safari. Super annoying!

Describe the solution you'd like A clear and concise description of what you want to happen.

Ideally, Storybook would work the same as create-react-app which does exactly what I described above. If I have Chrome open, it will open a new tab there. If I have Chrome open with localhost:6006, it will just focus and refresh that tab.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

N/A

Are you able to assist bring the feature to reality? no | yes, I can...

No.

Additional context Add any other context or screenshots about the feature request here.

N/A

created time in a month

issue openedmicrosoft/TypeScript

Intellisense not excluding definitions from `node_modules`

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version:
Version: 1.44.2
Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
Date: 2020-04-16T17:07:18.473Z (2 wks ago)
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0
  • OS Version: macOS Catalina 10.15.3 (19D76)

Steps to Reproduce:

  1. Open VSCode.
  2. Create a file src/constants.js exporting foo
  3. Import foo as import { foo } from 'constants'
  4. Hover over the constants file path.
  5. See the following.
module "constants"
@deprecated — since v6.3.0 - use constants property exposed by the relevant module instead.
  1. ⌘ + click on constants file path.
  2. See there are 2 definitions – constants.d.ts and index.d.ts but no src/constants.js

Expected result:

  • see the definition of foo from src/constants

The same issue occurs when using foo for the first time in a module, no import suggestion is shown.

My jsconfig.json file

{
  "compilerOptions": {
    "baseUrl": "./src",
    "jsx": "preserve",
    "module": "es6",
    "moduleResolution": "node",
    "target": "es6"
  },
  "exclude": [
    "**/node_modules/*",
    "coverage",
    "dist",
    "node_modules"
  ],
  "typeAcquisition": {
    "include": [
      "cypress",
      "jest"
    ]
  }
}

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes/No

created time in a month

issue openedtravis-ci/dpl

ElasticBeanstalk deployment fails (SSL_connect certificate verify failed (Seahorse::Client::NetworkingError))

I am trying to deploy an application following this guide.

Here is the .travis.yml file.

addons:
  apt:
    packages:
      - libssl1.0.0

language: node_js
cache: npm

script:
 - npm test
 - npm run build

deploy:
  provider: elasticbeanstalk
  skip_cleanup: true
  access_key_id:
    secure: NBuJGJnRTlOes6Y6915xLrc4r3rG5+8l7Pj9Ah0WDyPQ3+HjvBv0Qeb5HuNx0IyI2fHfK85j9w78x3xdniXO2nUS1XviRcQ8fcTuvo0hKmTQcu1E/BATslJnNtRly4zDokFuwURPD326rA8mrjy1KM2Ty9kEatZLh8B4+TP08C74PnGgqH8xrzNjPzN6X6DHubGqCWI1Xq208M1zLT/vLxG+vOrz9WJg7KlOgdMN4jnZYa69jp/l3rBkosWCzwyQbqqspvKYfDsAMY1XioraDob62VAhxLg8S6+xmNlWC/sMOLFdGSg7mH4uS/BbR9wQq4smzlGf6e2xN5Lko3kp9TCHgz7VAmlBSfXJiWtEYWe+ZJ+OHQWWbiLIctQSSs8MIu+Jost/QuwADGkzXKkUAuhLDD3KQz65aeRaGVgtq1ham14mWcmJrRd5QglF2e94VtrOjveR71FXmk5AMmy8I2IE1KRji2OCJDv8p5MbWCSv4BnmhA63DKvi9is/F6sORN967D+Zw00tnqJxoe147jHOuy/kg4ekL10hvonP1SoJfpvNzyt/z8Q6Tt8Xit+0VhkBDeWbknxmNtgyUuIgVSST7CsE7Em99KbqWQ3tT/vc3Khby0qqJYWxn76aOcyMMGo1inRZ1uHiCw0sSB8zyRMiAQoXJz6wzLfN5l+t+YA=
  secret_access_key:
    secure: bxr1iFrT1pB1viXgmO+XT11a1iQssn//YyUkV6a7uLbkmFUmlwZIIQ+xZAYRXVfTMYKK6VLd21dSQaAexSTpwHVRtRyPmTWDgIh5wqnaj1D6f9dEzzk25l6BnSVvJVsVK+sRpA19cLgsV59q/HCf/D6eWs0vk9eYXzwMNorGSLVVVYS0f+LPPaJYTpKvER6USNKXgpFuUgyUNHrCzaqEqu8dd6jZYW3XYEKZ6HY/K3z4iUO5dAkWgZO7S9FasG+nwV1pTV1D4x580AjL/nGbPM3P/RRMMTZNC60RThkB4VePiHlcl77UgFzglfvbOwBt35WjCOujEEAVxbZABygSceoWPELEClYiu8IviUy+8qWeiVpWP7nehv97i8Y0QoUkvvCs4NfZyaknKBBU4n+wTRAvZq83CYoGnks3BqAPoAFu1stD+BG9eopX9t0JsMLea+SO1XMylL4N6pOKVQdFmoDuc0SVaTm2YZVTQ5bToMSkLe6Z4l8ZZULttJ2E1LKP3Z5EInBNIojb7LUlOG6wVqSLORAwSRs1k7PBA1t2E/w+aCHT9YqIaSuq91+a75ZOeV3bgvygBdVGWURGh0IxYPAUmtfSlEwc9LMoI3ZoilnpM1iar7fbaGzQRRzVwpLLCLX3qnwJ7ovMKU5xv7wVUl/l+oko2+ue3tqC10kBdQM=
  region: eu-west-1
  app: webapp-dev
  env: WECO
  bucket_name: travis-dev.weco.io
  on:
    branch: develop

And error log.

Deploying application
S3 client configured for "eu-west-1" but the bucket "travis-dev.weco.io" is in "eu-west-1"; Please configure the proper region to avoid multiple unnecessary redirects and signing attempts

/home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/net/protocol.rb:44:in `connect_nonblock': SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed (Seahorse::Client::NetworkingError)
	from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/net/protocol.rb:44:in `ssl_socket_connect'
	from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/net/http.rb:948:in `connect'
	from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/net/http.rb:887:in `do_start'
	from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/net/http.rb:882:in `start'
	from /home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/delegate.rb:83:in `method_missing'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/seahorse/client/net_http/connection_pool.rb:285:in `start_session'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/seahorse/client/net_http/connection_pool.rb:92:in `session_for'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/seahorse/client/net_http/handler.rb:119:in `session'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/seahorse/client/net_http/handler.rb:71:in `transmit'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/seahorse/client/net_http/handler.rb:45:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/seahorse/client/plugins/content_length.rb:12:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_request_signer.rb:88:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_request_signer.rb:23:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_host_id.rb:14:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/xml/error_handler.rb:8:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/helpful_socket_errors.rb:10:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_request_signer.rb:65:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_redirects.rb:15:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:108:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:139:in `retry_request'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:122:in `retry_if_possible'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:110:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:139:in `retry_request'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:122:in `retry_if_possible'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:110:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:139:in `retry_request'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:122:in `retry_if_possible'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/retry_errors.rb:110:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_dualstack.rb:32:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_accelerate.rb:49:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_md5s.rb:31:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_expect_100_continue.rb:21:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_bucket_name_restrictions.rb:12:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_bucket_dns.rb:31:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/rest/handler.rb:7:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/user_agent.rb:12:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/endpoint_pattern.rb:27:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/endpoint_discovery.rb:67:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/seahorse/client/plugins/endpoint.rb:41:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/param_validator.rb:21:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_sse_cpk.rb:19:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_dualstack.rb:24:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/s3_accelerate.rb:34:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/jsonvalue_converter.rb:20:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/idempotency_token.rb:18:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/plugins/param_converter.rb:20:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/seahorse/client/plugins/response_target.rb:21:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/seahorse/client/request.rb:70:in `send_request'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/poller.rb:61:in `send_request'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/poller.rb:47:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/waiter.rb:104:in `block in poll'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/waiter.rb:101:in `loop'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/waiter.rb:101:in `poll'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/waiter.rb:91:in `block (2 levels) in wait'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/waiter.rb:90:in `catch'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/waiter.rb:90:in `block in wait'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/waiter.rb:89:in `catch'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/waiters/waiter.rb:89:in `wait'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-core-2.11.225/lib/aws-sdk-core/client_waiters.rb:110:in `wait_until'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-resources-2.11.225/lib/aws-sdk-resources/operations.rb:229:in `call'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-resources-2.11.225/lib/aws-sdk-resources/operation_methods.rb:19:in `block in add_operation'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/aws-sdk-resources-2.11.225/lib/aws-sdk-resources/resource.rb:131:in `exists?'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-elastic_beanstalk-1.10.7/lib/dpl/provider/elastic_beanstalk.rb:101:in `bucket_exists?'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-elastic_beanstalk-1.10.7/lib/dpl/provider/elastic_beanstalk.rb:41:in `push_app'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.7/lib/dpl/provider.rb:199:in `block in deploy'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.7/lib/dpl/cli.rb:41:in `fold'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.7/lib/dpl/provider.rb:199:in `deploy'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.7/lib/dpl/cli.rb:32:in `run'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.7/lib/dpl/cli.rb:7:in `run'
	from /home/travis/.rvm/gems/ruby-2.4.1/gems/dpl-1.10.7/bin/dpl:5:in `<top (required)>'
	from /home/travis/.rvm/gems/ruby-2.4.1/bin/dpl:23:in `load'
	from /home/travis/.rvm/gems/ruby-2.4.1/bin/dpl:23:in `<main>'
failed to deploy

Not sure what's going on there, but something about client configured for "eu-west-1" but the bucket is in "eu-west-1" does not sound right. It also seems that travis setup elasticbeanstalk is outdated as it does not ask for a required attribute bucket_name.

created time in 2 months

issue openedleekevinyg/react-tag-input

Ability to set maximum tags allowed and filter duplicate tags?

Hey! Another feature I'd be interested in having is being able to filter duplicate tags and limit the amount of tags I can input. This is currently impossible without doing some complex magic because the component accepts tags only on load, so even if I implemented this logic in the onTagsChanged() handler, I cannot simply update the passed tags array.

Side question: Why do tags have to be objects? You destructure them so the only other value (index) would've been lost anyway.

created time in 2 months

issue commentleekevinyg/react-tag-input

README `onInputChange` prop typo

Thank you!

mrlubos

comment created time in 2 months

issue openedleekevinyg/react-tag-input

README `onInputChange` prop typo

Hey! Just wanted to point out there's a typo in README. Instead of the onInputChange prop, TagInput accepts a onInputChanged prop.

created time in 2 months

issue closedtoomuchdesign/re-reselect

Dropped support for createCachedSelector calls with multiple arguments?

Do you want to request a feature or report a bug?

Question

What is the current behaviour?

Why was the support for calling createCachedSelector() with multiple arguments dropped and what exactly does this mean?

What is the expected behaviour?

N/A

Steps to Reproduce the Problem

N/A

Specifications

N/A

closed time in 2 months

mrlubos

issue commenttoomuchdesign/re-reselect

Dropped support for createCachedSelector calls with multiple arguments?

Thank you for the explanation @toomuchdesign!

mrlubos

comment created time in 2 months

issue openedtoomuchdesign/re-reselect

Dropped support for createCachedSelector calls with multiple arguments?

Do you want to request a feature or report a bug?

Question

What is the current behaviour?

Why was the support for calling createCachedSelector() with multiple arguments dropped and what exactly does this mean?

What is the expected behaviour?

N/A

Steps to Reproduce the Problem

N/A

Specifications

N/A

created time in 2 months

issue commentmicrosoft/vscode

Intellisense not excluding definitions from `node_modules`

Hey @yume-chan! Thank you for the reply! I believe I tried this but to no avail. 😭 I’ve seen this issue in a TypeScript project as well but I haven’t tried your suggestion there yet

mrlubos

comment created time in 2 months

issue openedmicrosoft/vscode

Intellisense not excluding definitions from `node_modules`

<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->

<!-- Use Help > Report Issue to prefill these. -->

  • VSCode Version:
Version: 1.44.2
Commit: ff915844119ce9485abfe8aa9076ec76b5300ddd
Date: 2020-04-16T17:07:18.473Z (2 wks ago)
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0
  • OS Version: macOS Catalina 10.15.3 (19D76)

Steps to Reproduce:

  1. Open VSCode.
  2. Create a file src/constants.js exporting foo
  3. Import foo as import { foo } from 'constants'
  4. Hover over the constants file path.
  5. See the following.
module "constants"
@deprecated — since v6.3.0 - use constants property exposed by the relevant module instead.
  1. ⌘ + click on constants file path.
  2. See there are 2 definitions – constants.d.ts and index.d.ts but no src/constants.js

Expected result:

  • see the definition of foo from src/constants

The same issue occurs when using foo for the first time in a module, no import suggestion is shown.

My jsconfig.json file

{
  "compilerOptions": {
    "baseUrl": "./src",
    "jsx": "preserve",
    "module": "es6",
    "moduleResolution": "node",
    "target": "es6"
  },
  "exclude": [
    "**/node_modules/*",
    "coverage",
    "dist",
    "node_modules"
  ],
  "typeAcquisition": {
    "include": [
      "cypress",
      "jest"
    ]
  }
}

<!-- Launch with code --disable-extensions to check. --> Does this issue occur when all extensions are disabled?: Yes/No

created time in 2 months

issue commentgoogle/marzipano

Styling Marzipano hotspot container?

There are two reasons for this complexity:

Thanks for this explanation!

Since one of the hotspots must necessarily be first in DOM order, the only ways to ensure the context menu appears on top of everything else are to either (1) make the context menu a child of the hotspot element, but move the hotspot element to the first position when the user interacts with it, or (2) move the context menu out of the hotspot hierarchy.

My understanding is that you're currently doing (2). The suggestion I made above was to implement an API that helps you do (1).

Correct. There's also a third option, which is what I was originally attempting to do. Consider the following DOM structure.

Screenshot 2020-04-25 at 1 10 09 am

If I want the highlighted hotspot to be above everything else visually, I could just update z-index to any value larger than 1. No need to reorder the nodes! Sadly, I am currently unable to do this, so I was wondering why is this wrapper there and why can't it be directly modified?

mrlubos

comment created time in 3 months

issue commentgoogle/marzipano

Styling Marzipano hotspot container?

@tjgq pardon my ignorance, but why should they stack in the order they are added to the DOM? For my purposes, I want the first click on the hotspot to open a context menu. The only position I care about is the first to ensure my menu won’t be overlapped by any other hotspot. Currently, I need to insert my context menu higher in the DOM to ensure it sits on top of all hotspots.

While I was solving this problem, I noticed there are a lot of wrapper div containers and often they’re unused/hidden. Is this behaviour documented anywhere? It feels very messy to have so many dead/sleeping nodes. It might be also me using the Hotspots API incorrectly, but worth asking. Thank you!

mrlubos

comment created time in 3 months

issue openedgoogle/marzipano

Styling Marzipano hotspot container?

Hey! Currently, rendering a hotspot wraps it in a div layer that looks something like this.

<div style="display: block; z-index: 1; transform: translateX(569.339px) translateY(719.866px) translateZ(0px); position: absolute;">
  <!-- my hotspot component -->
</div>

I have a full control over my hotspot component and its styling. Is it possible to apply any styling to this wrapper element? The specific use case I have is that I want my hotspot to sit on top of all other hotspots when "active." This is currently impossible as all hotspots have the same z-index.

created time in 3 months

more